Re: kickoff qml
On Mon, Oct 22, 2012 at 10:16 AM, Marco Martin wrote: > Hi all, > one thing i would like to have merged for 4.10 is the qml port of kickoff. > i have been looking at it past few days, and it seems to have most of the > features, even tough is still quite rough, i'm not 100% sure it may be ready > yet. > i've fixed some things in last couple of days, it still has some layout and > painting problems (sometimes elements don't seem to repaint correctly) > right now even if not really far i don't think is really merge-able yet. > > also the code organization doesn't seem to be that great (it has a quite > complex logic and there is a context menu copy in each delegate that makes > things quite heavy) > > i think it should have a minor refactor on how the various pages are managed, > a qml file for each page (favourites, applications, leave etc) and one single > contextmenu for each page. > > I would like to invite people to test it (kickoff-qml branch) to see if it can > be made good enough in time. > > Cheers, > Marco Martin > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel To anyone who has issues with runinng this branch, make sure you have the latest kde-runtime which contains the ConditionalLoader. Marco, where do you want bug reports / tracking what needs to be done. I'm going to devote my next day to fixing all the bits I can. (got two fixes already) Dave ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: slc repo as dependency
It would need to be moved from playground if kde-workspace was to depend on it. The procedure I've had to go through is: - open a sysadmin request to move repo to kdereview stating you want to move to review, and the intended final destination - post to kde-devel to inform people about the move, explain what it is etc. - wait the review period, answering comments, etc. - file a new sysadmin request to move to the correct repository. The wiki page is a bit outdated, it talks about SVN. I think it still applies http://techbase.kde.org/Policies/SVN_Guidelines This is important: http://techbase.kde.org/Policies/Suggested_Review_Criteria David On Mon, Oct 22, 2012 at 10:27 AM, Marco Martin wrote: > Hi all, > since freeze is looming, if we want to use slc in 4.10 by default, its > repository should become part of sc and be a dependency of kde-workspace (if a > default applet) > > what is the procedure for that? > > Cheers, > Marco Martin > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20758 --- This review has been submitted with commit 6d4955bf63b7d13757a495f4583e1033068c3d9d by Diego Casella to branch KDE/4.9. - Commit Hook On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106999/ > --- > > (Updated Oct. 22, 2012, 11:01 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > When you open the Activity Manager, and click the "Configure" button, the > stacked config page displays a misplaced iconButton (see figure on the left). > That's because, in ActivityDelegate, the implicitHeight of the component is > forced to 20. > Funny observation: this weird behavior shows up only when Activity Manager is > displayed horizontally ... Vertically, everything is just fine. > Anyway the "patch" is just an one-liner so it should be OK, I suppose. > The fixed component is shown in the screenshot on the right. > > > Diffs > - > > > plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml > 4af21e7 > > Diff: http://git.reviewboard.kde.org/r/106999/diff/ > > > Testing > --- > > Works perfectly, both with horizontal and vertical placement (see shots > below). > > > Screenshots > --- > > Activity Manager, before > http://git.reviewboard.kde.org/r/106999/s/790/ > Activity Manager, after > http://git.reviewboard.kde.org/r/106999/s/791/ > Activity Manager, Androbit theme > http://git.reviewboard.kde.org/r/106999/s/792/ > Activity Manager, Aya theme > http://git.reviewboard.kde.org/r/106999/s/793/ > Activity Manager, Produkt theme > http://git.reviewboard.kde.org/r/106999/s/794/ > Activity Manager, Slim Glow theme > http://git.reviewboard.kde.org/r/106999/s/795/ > Activity Manager, Tibanna theme > http://git.reviewboard.kde.org/r/106999/s/796/ > > > Thanks, > > Diego Casella > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20757 --- This review has been submitted with commit fe5032ec7d5d85caca79983ad7fd392c39cff58a by Diego Casella to branch master. - Commit Hook On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106999/ > --- > > (Updated Oct. 22, 2012, 11:01 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > When you open the Activity Manager, and click the "Configure" button, the > stacked config page displays a misplaced iconButton (see figure on the left). > That's because, in ActivityDelegate, the implicitHeight of the component is > forced to 20. > Funny observation: this weird behavior shows up only when Activity Manager is > displayed horizontally ... Vertically, everything is just fine. > Anyway the "patch" is just an one-liner so it should be OK, I suppose. > The fixed component is shown in the screenshot on the right. > > > Diffs > - > > > plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml > 4af21e7 > > Diff: http://git.reviewboard.kde.org/r/106999/diff/ > > > Testing > --- > > Works perfectly, both with horizontal and vertical placement (see shots > below). > > > Screenshots > --- > > Activity Manager, before > http://git.reviewboard.kde.org/r/106999/s/790/ > Activity Manager, after > http://git.reviewboard.kde.org/r/106999/s/791/ > Activity Manager, Androbit theme > http://git.reviewboard.kde.org/r/106999/s/792/ > Activity Manager, Aya theme > http://git.reviewboard.kde.org/r/106999/s/793/ > Activity Manager, Produkt theme > http://git.reviewboard.kde.org/r/106999/s/794/ > Activity Manager, Slim Glow theme > http://git.reviewboard.kde.org/r/106999/s/795/ > Activity Manager, Tibanna theme > http://git.reviewboard.kde.org/r/106999/s/796/ > > > Thanks, > > Diego Casella > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.
> On Oct. 23, 2012, 7:01 a.m., Ivan Čukić wrote: > > You didn't have to bother with screenshots, your word would be sufficient :) > > Diego Casella wrote: > No problem ;) > Btw, should I commit into master and 4.9, or just master? IMO, it can be considered a bugfix, so both. - Ivan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20718 --- On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106999/ > --- > > (Updated Oct. 22, 2012, 11:01 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > When you open the Activity Manager, and click the "Configure" button, the > stacked config page displays a misplaced iconButton (see figure on the left). > That's because, in ActivityDelegate, the implicitHeight of the component is > forced to 20. > Funny observation: this weird behavior shows up only when Activity Manager is > displayed horizontally ... Vertically, everything is just fine. > Anyway the "patch" is just an one-liner so it should be OK, I suppose. > The fixed component is shown in the screenshot on the right. > > > Diffs > - > > > plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml > 4af21e7 > > Diff: http://git.reviewboard.kde.org/r/106999/diff/ > > > Testing > --- > > Works perfectly, both with horizontal and vertical placement (see shots > below). > > > Screenshots > --- > > Activity Manager, before > http://git.reviewboard.kde.org/r/106999/s/790/ > Activity Manager, after > http://git.reviewboard.kde.org/r/106999/s/791/ > Activity Manager, Androbit theme > http://git.reviewboard.kde.org/r/106999/s/792/ > Activity Manager, Aya theme > http://git.reviewboard.kde.org/r/106999/s/793/ > Activity Manager, Produkt theme > http://git.reviewboard.kde.org/r/106999/s/794/ > Activity Manager, Slim Glow theme > http://git.reviewboard.kde.org/r/106999/s/795/ > Activity Manager, Tibanna theme > http://git.reviewboard.kde.org/r/106999/s/796/ > > > Thanks, > > Diego Casella > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.
> On Oct. 23, 2012, 7:01 a.m., Ivan Čukić wrote: > > You didn't have to bother with screenshots, your word would be sufficient :) No problem ;) Btw, should I commit into master and 4.9, or just master? - Diego --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20718 --- On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106999/ > --- > > (Updated Oct. 22, 2012, 11:01 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > When you open the Activity Manager, and click the "Configure" button, the > stacked config page displays a misplaced iconButton (see figure on the left). > That's because, in ActivityDelegate, the implicitHeight of the component is > forced to 20. > Funny observation: this weird behavior shows up only when Activity Manager is > displayed horizontally ... Vertically, everything is just fine. > Anyway the "patch" is just an one-liner so it should be OK, I suppose. > The fixed component is shown in the screenshot on the right. > > > Diffs > - > > > plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml > 4af21e7 > > Diff: http://git.reviewboard.kde.org/r/106999/diff/ > > > Testing > --- > > Works perfectly, both with horizontal and vertical placement (see shots > below). > > > Screenshots > --- > > Activity Manager, before > http://git.reviewboard.kde.org/r/106999/s/790/ > Activity Manager, after > http://git.reviewboard.kde.org/r/106999/s/791/ > Activity Manager, Androbit theme > http://git.reviewboard.kde.org/r/106999/s/792/ > Activity Manager, Aya theme > http://git.reviewboard.kde.org/r/106999/s/793/ > Activity Manager, Produkt theme > http://git.reviewboard.kde.org/r/106999/s/794/ > Activity Manager, Slim Glow theme > http://git.reviewboard.kde.org/r/106999/s/795/ > Activity Manager, Tibanna theme > http://git.reviewboard.kde.org/r/106999/s/796/ > > > Thanks, > > Diego Casella > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Possibility to set QIcon to PlasmaCore.Tooltip
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107013/#review20751 --- Ship it! sensible addition - Marco Martin On Oct. 23, 2012, 4:43 p.m., Dmitry Ashkadov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107013/ > --- > > (Updated Oct. 23, 2012, 4:43 p.m.) > > > Review request for Plasma. > > > Description > --- > > PlasmaCore.Tooltip [org.kde.plasma.core] QML item can handle only name of > icon. Some system tray tasks give QIcon as a tooltip icon. It would be better > if Tooltip QML item can handle QIcon. > > > Diffs > - > > plasma/declarativeimports/core/tooltip.h 3c8a930 > plasma/declarativeimports/core/tooltip.cpp 9f5836c > > Diff: http://git.reviewboard.kde.org/r/107013/diff/ > > > Testing > --- > > > Thanks, > > Dmitry Ashkadov > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Possibility to set QIcon to PlasmaCore.Tooltip
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107013/ --- Review request for Plasma. Description --- PlasmaCore.Tooltip [org.kde.plasma.core] QML item can handle only name of icon. Some system tray tasks give QIcon as a tooltip icon. It would be better if Tooltip QML item can handle QIcon. Diffs - plasma/declarativeimports/core/tooltip.h 3c8a930 plasma/declarativeimports/core/tooltip.cpp 9f5836c Diff: http://git.reviewboard.kde.org/r/107013/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Doxyqml, supporting type
On Tue, Oct 23, 2012 at 10:19 AM, Marco Martin wrote: > On Tuesday 23 October 2012, Aleix Pol wrote: > >> >> More seriously though, I think that a patch on some current code would >> be really helpful. >> >> Also did we consider how different will be C++ components vs. QML >> components? Ideally they should have a similar aspect since we'll >> likely be using them both together. > > the c++ ones right now are harvested by doxygen, but the look is quite > horrible: > http://api.kde.org/4.x-api/kde-runtime- > apidocs/plasma/html/classPlasma_1_1FrameSvgItem.html > > (ideally all the functions that are not slots/invokable/scriptable should not > appear there) > the documentation of the properties are drowned in the enumeration of > undocumented functions right now (and that should remain undocumented, since > they are either just setter/getter of documented properties or functions not > invokable from qml) > > Cheers, > Marco Martin > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel Yes, also it would be quite interesting to pack the properties together like they do with Qt documentation. It's helpful to see them together and it's more clean. Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stackfolder inclusion to 4.10 [attempt#2]
Hi Ural, I would also suggest to give the label text at least some shadows since the current white is somewhat hard to read: http://wstaw.org/m/2012/10/23/plasma-desktopr24762.png Yours, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stackfolder inclusion to 4.10 [attempt#2]
Hi Martin! > I just tried it and I quite like it, nice work! I have few suggestions > for improvements - first of all don't hide and show the popup when you > change folder, I wasn't sure what's happening when I clicked some > folder in it, I thought Dolphin is being opened and then suddenly the > same popup but different size showed up. So keep the popup visible all > the time and don't change the size, keep it to some sane default. Resizing popup window to contents of folder is our feature. And hiding/showing popup window smooths resizing effect during folders changing. To open selected folder in the Dolphin you should press Alt-Enter or click on button on the right top corner. If it will be needed, I think, we can make special version for KDE. > The scrollbar actually work the other way around - dragging it up > scrolls down, dragging down scrolls up. That's inconsistent with the > rest of the whole desktop. It isn't scrollbar, it's more like indicator of visible area. I agree with you it needs to be reworked to the standard scrollbar. > > Also there's this project called Homerun which implements exactly this > and it works quite nicely, even with breadcrumb navigation. Maybe you > can contact Aurelien, the author, and share code/collaborate in the > development? Here's the project: > https://projects.kde.org/projects/playground/base/homerun Thank you for your suggestions! We will consider them. Regards, Ural Mullabaev Rosa Laboratory www.rosalab.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: SystemTray: QML version #3
23.10.2012 12:51, Marco Martin пишет: On Tuesday 23 October 2012, Dmitry Ashkadov wrote: 23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've fixed this blue circle. Now blue circle of kmail works for me. Could you try choqok& kmail again? I tried with Choqok and it works now. Thanks. i really think it should be merged now (today?) then problems fixed when they surface, but not delayed anymore So, should I merge it today into master? Should I use git merge or git rebase? yep, let's do that ;) git merge is fine. It has been shipped [in master]. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Doxyqml, supporting type
Le mardi 23 octobre 2012 00:23:25 Aleix Pol a écrit :
> I think you are great Aurélien :D
*blushes* :)
>
> More seriously though, I think that a patch on some current code would
> be really helpful.
Sure. When this is deployed, I want to go through the current documentation
and split it accordingly.
> Also did we consider how different will be C++ components vs. QML
> components? Ideally they should have a similar aspect since we'll
> likely be using them both together.
Agreed.
That reminds me of a problem I did not mention: some QML components are mostly
empty, their API comes from their C++ base class, but Doxygen cannot show it
because the C++ base class is not exposed with the same name on the QML side.
If this sounds confusing, here is an example:
ContextMenu.qml only contains this (stripping imports and comments):
Menu {
id: root
}
It inherits from Menu, but looking at plasmacomponentsplugin.cpp, one finds
this:
qmlRegisterType(uri, 0, 1, "Menu");
Doxygen has no chance of parsing this and cannot show the inherited
properties, functions and methods.
That can be work-arounded by adding a "typedef QMenuProxy Menu;" to qmenu.h
(QMenuProxy header file). With this typedef in, Doxygen shows the base class
info, but it is still a bit ugly because the typedef gets resolved so
ContextMenu is documented as inheriting from QMenuProxy, a class which is not
accessible from the QML side.
I think we should rename C++ classes so that they use the same name on the C++
and QML sides.
> Code-wise, I don't think having a type: prefix is bad and given that
> the type can be any class name, it can be good to have it specified
> because it's easy to read it, if it starts with string but not so easy
> if it starts with e.g. TextField.
OK. I keep it this way then.
Aurélien
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix build when NepomukCore and KDELibs reside in different locations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107004/#review20724 --- This review has been submitted with commit 5908a28041b7a0fc0830ba24b41870824b7f1234 by Ben Cooksley to branch master. - Commit Hook On Oct. 23, 2012, 9:06 a.m., Ben Cooksley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107004/ > --- > > (Updated Oct. 23, 2012, 9:06 a.m.) > > > Review request for Plasma. > > > Description > --- > > This patch is required if your NepomukCore installation exists in a seperate > installation prefix to KDELibs, which is the case on build.kde.org. > Otherwise, NepomukCore headers are not found, causing the build to fail. > > > Diffs > - > > applications/webbrowser/src/CMakeLists.txt 850ad8c > applications/webbrowser/src/ontologies/CMakeLists.txt d4a3dcb > components/metadatamodel/CMakeLists.txt cda517e > dataengines/metadata/CMakeLists.txt 9cd002a > shell/CMakeLists.txt 911dd1d > > Diff: http://git.reviewboard.kde.org/r/107004/diff/ > > > Testing > --- > > Build now succeeds. > > > Thanks, > > Ben Cooksley > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix build when NepomukCore and KDELibs reside in different locations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107004/#review20723 --- Ship it! Ship It! - Marco Martin On Oct. 23, 2012, 9:06 a.m., Ben Cooksley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107004/ > --- > > (Updated Oct. 23, 2012, 9:06 a.m.) > > > Review request for Plasma. > > > Description > --- > > This patch is required if your NepomukCore installation exists in a seperate > installation prefix to KDELibs, which is the case on build.kde.org. > Otherwise, NepomukCore headers are not found, causing the build to fail. > > > Diffs > - > > applications/webbrowser/src/CMakeLists.txt 850ad8c > applications/webbrowser/src/ontologies/CMakeLists.txt d4a3dcb > components/metadatamodel/CMakeLists.txt cda517e > dataengines/metadata/CMakeLists.txt 9cd002a > shell/CMakeLists.txt 911dd1d > > Diff: http://git.reviewboard.kde.org/r/107004/diff/ > > > Testing > --- > > Build now succeeds. > > > Thanks, > > Ben Cooksley > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fix build when NepomukCore and KDELibs reside in different locations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107004/ --- Review request for Plasma. Description --- This patch is required if your NepomukCore installation exists in a seperate installation prefix to KDELibs, which is the case on build.kde.org. Otherwise, NepomukCore headers are not found, causing the build to fail. Diffs - applications/webbrowser/src/CMakeLists.txt 850ad8c applications/webbrowser/src/ontologies/CMakeLists.txt d4a3dcb components/metadatamodel/CMakeLists.txt cda517e dataengines/metadata/CMakeLists.txt 9cd002a shell/CMakeLists.txt 911dd1d Diff: http://git.reviewboard.kde.org/r/107004/diff/ Testing --- Build now succeeds. Thanks, Ben Cooksley ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stackfolder inclusion to 4.10 [attempt#2]
Hey Ural, On Mon, Oct 22, 2012 at 12:45 PM, Ural Mullabaev wrote: > Hi Aaron and Marco! > > I fixed the problems which you specified the last time: > - icon decreasing on the panel (attachment - smallicon.png); > - empty popup dialog (now it should show correctly) > And also I changed path to the qml contents to > /plasma/packages/org.kde.stackfolder. > > Now what else do I need to do to enter StackFolder in KDE 4.10? > > I remind that StackFolder is an independent applet and placed in a > playground repo ( > https://projects.kde.org/projects/playground/base/stackfolder). > Originally StackFolder is a fork of FolderView applet, that was redesigned > to look like MacOS X Stask utility. It allow to browse the stack of > folders and quick access to files and also may interact with another > Rosa's utility - Klook to preview a wide range types of files (including > playing video and audio). For the time being the GUI part of code is > rewritten on QML. And recently we reworked StackFolder to PopupApplet. > Now StackFolder has little in common with the FolderView. > I just tried it and I quite like it, nice work! I have few suggestions for improvements - first of all don't hide and show the popup when you change folder, I wasn't sure what's happening when I clicked some folder in it, I thought Dolphin is being opened and then suddenly the same popup but different size showed up. So keep the popup visible all the time and don't change the size, keep it to some sane default. The scrollbar actually work the other way around - dragging it up scrolls down, dragging down scrolls up. That's inconsistent with the rest of the whole desktop. Also there's this project called Homerun which implements exactly this and it works quite nicely, even with breadcrumb navigation. Maybe you can contact Aurelien, the author, and share code/collaborate in the development? Here's the project: https://projects.kde.org/projects/playground/base/homerun Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: SystemTray: QML version #3
On Tuesday 23 October 2012, Dmitry Ashkadov wrote: > 23.10.2012 12:44, Marco Martin пишет: > > On Tuesday 23 October 2012, Luca Beltrame wrote: > >> In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: > >>> it shows only dark blue circle. I've fixed this blue circle. Now blue > >>> circle of kmail works for me. Could you try choqok& kmail again? > >> > >> I tried with Choqok and it works now. Thanks. > > > > i really think it should be merged now (today?) > > then problems fixed when they surface, but not delayed anymore > > So, should I merge it today into master? Should I use git merge or git > rebase? yep, let's do that ;) git merge is fine. Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: SystemTray: QML version #3
23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've fixed this blue circle. Now blue circle of kmail works for me. Could you try choqok& kmail again? I tried with Choqok and it works now. Thanks. i really think it should be merged now (today?) then problems fixed when they surface, but not delayed anymore So, should I merge it today into master? Should I use git merge or git rebase? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: SystemTray: QML version #3
On Tuesday 23 October 2012, Luca Beltrame wrote: > In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: > > it shows only dark blue circle. I've fixed this blue circle. Now blue > > circle of kmail works for me. Could you try choqok & kmail again? > > I tried with Choqok and it works now. Thanks. i really think it should be merged now (today?) then problems fixed when they surface, but not delayed anymore Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: SystemTray: QML version #3
In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: > it shows only dark blue circle. I've fixed this blue circle. Now blue > circle of kmail works for me. Could you try choqok & kmail again? I tried with Choqok and it works now. Thanks. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: SystemTray: QML version #3
22.10.2012 19:17, Luca Beltrame пишет: In data giovedì 18 ottobre 2012 09:50:49, Dmitry Ashkadov ha scritto: Hello, I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): I've been playing with this for a bit and I noticed a regression with applications that paint over their tray icon (examples include kmail's unread mail count, or choqok's new post count): the icon does not change (i.e. nothing is painted over it). Not that it would be a showstopper for merging, but I thought I'd let you know: I will file a BR as reminder once it is merged. Hello! Thank you for your feedback. I never use clients for microblogging. But I tried setup kmail. It [kmail] doesn't show number of unread messages, it shows only dark blue circle. I've fixed this blue circle. Now blue circle of kmail works for me. Could you try choqok & kmail again? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Doxyqml, supporting type
On Tuesday 23 October 2012, Aleix Pol wrote: > > More seriously though, I think that a patch on some current code would > be really helpful. > > Also did we consider how different will be C++ components vs. QML > components? Ideally they should have a similar aspect since we'll > likely be using them both together. the c++ ones right now are harvested by doxygen, but the look is quite horrible: http://api.kde.org/4.x-api/kde-runtime- apidocs/plasma/html/classPlasma_1_1FrameSvgItem.html (ideally all the functions that are not slots/invokable/scriptable should not appear there) the documentation of the properties are drowned in the enumeration of undocumented functions right now (and that should remain undocumented, since they are either just setter/getter of documented properties or functions not invokable from qml) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20718 --- Ship it! You didn't have to bother with screenshots, your word would be sufficient :) - Ivan Čukić On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106999/ > --- > > (Updated Oct. 22, 2012, 11:01 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > When you open the Activity Manager, and click the "Configure" button, the > stacked config page displays a misplaced iconButton (see figure on the left). > That's because, in ActivityDelegate, the implicitHeight of the component is > forced to 20. > Funny observation: this weird behavior shows up only when Activity Manager is > displayed horizontally ... Vertically, everything is just fine. > Anyway the "patch" is just an one-liner so it should be OK, I suppose. > The fixed component is shown in the screenshot on the right. > > > Diffs > - > > > plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml > 4af21e7 > > Diff: http://git.reviewboard.kde.org/r/106999/diff/ > > > Testing > --- > > Works perfectly, both with horizontal and vertical placement (see shots > below). > > > Screenshots > --- > > Activity Manager, before > http://git.reviewboard.kde.org/r/106999/s/790/ > Activity Manager, after > http://git.reviewboard.kde.org/r/106999/s/791/ > Activity Manager, Androbit theme > http://git.reviewboard.kde.org/r/106999/s/792/ > Activity Manager, Aya theme > http://git.reviewboard.kde.org/r/106999/s/793/ > Activity Manager, Produkt theme > http://git.reviewboard.kde.org/r/106999/s/794/ > Activity Manager, Slim Glow theme > http://git.reviewboard.kde.org/r/106999/s/795/ > Activity Manager, Tibanna theme > http://git.reviewboard.kde.org/r/106999/s/796/ > > > Thanks, > > Diego Casella > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
