Re: QML style guide
30.10.2012 21:33, Martin Gräßlin пишет:
On Tuesday 30 October 2012 18:16:26 Aurélien Gâteau wrote:
The only part I don't really like is putting left curly brace on its own
line for functions because:
- having different conventions for event-handlers and function code blocks
look inconsistent
- it differs from many coding styles: Qt QML JavaScript, Douglas Crockford,
jQuery, Node... so I think it is going to look odd and unfamiliar to many
newcomers.
+1 - I am even not sure whether putting curly brace on new line is JSLint
compliant in this case.
+1 for brace on the same line for JS. jslint.com: Expected exactly one
space between ')' and '{'.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving applet to review group
Hi, Nicolas! regarding licencing, i doubt you can use GPLV3+ when you use GPLV2+ KDE code. We can change licence. Will GPLV2+ be good? Ural ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving applet to review group
On Saturday, October 27, 2012 23:54:55 nlecure...@mandriva.com wrote: Le 26.10.2012 10:17, Ural Mullabaev a écrit : You have to open a sysadmin request (https://bugs.kde.org/enter_sysadmin_request.cgi) asking for moving the applet from playground to kdereview. Many thanks Luca! Hi, regarding licencing, i doubt you can use GPLV3+ when you use GPLV2+ KDE code. the plus means or later, at your discretion. the problem will be in using that GPLv3+ code in any other code that is licensed e.g. GPLv2+. but yes, having a consistent GPLv2+ would be nicest. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PLASMA_PLATFORM and kdeglobals runtimePlatform
On Tuesday 30 October 2012, Aaron J. Seigo wrote: testing for regressions is desired, though it is working here nicely (for whatever that's worth :) at least now we have *one* place that all of this ties together, both in terms of configuration and use from the code. ah, forgotten to add: http://techbase.kde.org/Development/Tutorials/Plasma/PackageOverview#Device_specific_user_interface feel free to correct anything there -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PLASMA_PLATFORM and kdeglobals runtimePlatform
On Tuesday 30 October 2012, Aaron J. Seigo wrote: On Tuesday, October 30, 2012 22:34:11 Marco Martin wrote: * plasma active default settings i already did that :) what did you change? in plasma-mobile-config repo? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PLASMA_PLATFORM and kdeglobals runtimePlatform
On Wednesday, October 31, 2012 10:25:22 Marco Martin wrote: On Tuesday 30 October 2012, Aaron J. Seigo wrote: On Tuesday, October 30, 2012 22:34:11 Marco Martin wrote: * plasma active default settings i already did that :) what did you change? in plasma-mobile-config repo? yes. kdeglobals entry, kdeclarativerc gone -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Declarative bindings for ToolBox
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/ --- Review request for Plasma. Description --- This class, which is exposed through the javascript/declarative scriptengine, exposes some properties of AbstractToolBox to the declarative containment. Specifically, actions, mutability and wether or not its shown (so other windows should be hidden). Diffs - plasma/scriptengines/javascript/CMakeLists.txt fe06582 plasma/scriptengines/javascript/declarative/internaltoolbox.h PRE-CREATION plasma/scriptengines/javascript/declarative/internaltoolbox.cpp PRE-CREATION plasma/scriptengines/javascript/plasmoid/appletinterface.h 6fc2d74 plasma/scriptengines/javascript/plasmoid/appletinterface.cpp ed5c8ae Diff: http://git.reviewboard.kde.org/r/107150/diff/ Testing --- Using this with my proof-of-concept desktop containment, seems to work as expected, for example screen locking changes are picked up as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- Aaron has noticed in his mail to plasma-devel that the system tray requires some refactoring. This is a first step of refactoring. If it is approved I'll continue work on system tray. Diffs - plasma/generic/applets/systemtray/CMakeLists.txt d3478a8 plasma/generic/applets/systemtray/core/manager.h 3b6b6f8 plasma/generic/applets/systemtray/core/manager.cpp c23225e plasma/generic/applets/systemtray/core/task.h 66bf6e1 plasma/generic/applets/systemtray/core/task.cpp 8754785 plasma/generic/applets/systemtray/package/contents/code/main.js 10518cd plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml f251cc5 plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml 27d476a plasma/generic/applets/systemtray/package/contents/ui/main.qml f80abc7 plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 34aae74 plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 6364272 plasma/generic/applets/systemtray/protocols/fdo/fdoprotocol.h b006967 plasma/generic/applets/systemtray/protocols/fdo/fdoprotocol.cpp c1bb8b1 plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.h c86a2d5 plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp 4257202 plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 85a9ec5 plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp d1a18df plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h 1913986 plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp 761a62f plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtaskprotocol.cpp 505e0c4 plasma/generic/applets/systemtray/ui/applet.h bab8d9c plasma/generic/applets/systemtray/ui/applet.cpp 41efb10 plasma/generic/applets/systemtray/ui/plasmoid.h 01a7c5b plasma/generic/applets/systemtray/ui/plasmoid.cpp d3e1937 plasma/generic/applets/systemtray/ui/taskspool.h 4b5bcd4 plasma/generic/applets/systemtray/ui/taskspool.cpp df39e3d plasma/generic/applets/systemtray/ui/uitask.h 7b20bde plasma/generic/applets/systemtray/ui/uitask.cpp 2a15800 plasma/generic/applets/systemtray/ui/widgetitem.h 40aa92d plasma/generic/applets/systemtray/ui/widgetitem.cpp 9d2c622 Diff: http://git.reviewboard.kde.org/r/107160/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving applet to review group
Le 31.10.2012 09:55, Ural Mullabaev a écrit : Hi, Nicolas! regarding licencing, i doubt you can use GPLV3+ when you use GPLV2+ KDE code. We can change licence. Will GPLV2+ be good? Ural yes as aseigo expained, this is way better here. For stackfolder itself, as it seems close from folderview, why not try to merge the code in folderview ? ( maybe with a config to enable folderview or stackfolder.). I would like to add that it seems not possible to right click on the files to have normal options ( like folderview does ). In addition, this is a pb at least for me that the widget size change depending of which folder we look. My 2cts. Nicolas Lécureuil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Microblog port to Akonadi pushed into a branch
On Sat, Oct 27, 2012 at 7:23 PM, Martin Klapetek martin.klape...@gmail.comwrote: * refreshing the list pushes garbage/no data into qml, I'm not yet sure where this problem originates, simple reloading of the applet fixes it Found the issue today, was a bug in Akonadi, posted a patch which now awaits review [1], so the major issues are now solved \o/ About the scrollbar and uniform items height - today I realized the items cannot be all the same height, because some of them has links, some has pictures, some say Retweeted by..., so unless the height is as big as all possible combinations of things, I don't think this is feasible (and that would looks bad on posts without images, which are 100px high - 100px blank space). One possible solution would be to limit the number of shown items to say 200 and then make the list load 200 delegates, but obviously the memory costs could go really up. I'm actually quite curious about the amount, so I'll do a benchmark tomorrow. [1] - https://git.reviewboard.kde.org/r/107153https://git.reviewboard.kde.org/r/107153/diff/#index_header -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: AppletContainer has moved to scriptengine
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107165/ --- Review request for Plasma. Description --- * remove AppletContainer from MobileComponents * Port all uses of AppletContainer to org.kde.plasma.containments This class has been moved into the scriptengine in kde-runtime (master), and is available for all containments as type. My branch splits this up into two commits (one for the mobilecomponents and one for the porting), I've put it into one review request since their both closely related (and fairly trivial). Diffs - components/mobilecomponents/CMakeLists.txt 981843c4be970c5aef450ef4cdc6721162f950c3 components/mobilecomponents/appletcontainer.h 76587f2ca6131c228f70677b8c5f989039b3f4f6 components/mobilecomponents/appletcontainer.cpp 2dc54092033e8d07737a2b31e006f8211137e48a components/mobilecomponents/mobilecomponentsplugin.cpp 6a63631413a2508ba547c2402803a45d07bb4d4a containments/activityscreen/contents/ui/PlasmoidGroup.qml b394bc03f73c84d58aefd3a91ef4999f9703615a containments/appletstrip/contents/ui/PlasmoidContainer.qml 70226dae7caf55c0d163490ee7b5375bda882ce6 containments/systemtray/contents/ui/PlasmoidContainer.qml 270c4fcd5085a9236b48609caa03c98fa24fc453 Diff: http://git.reviewboard.kde.org/r/107165/diff/ Testing --- Tested actity screen and system tray in plasma-device and plasma-desktop and plasmoidviewer, no errors. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Add Package bindings from MobileComponents to PlasmaCore
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107166/ --- Review request for Plasma. Description --- Add Package bindings from MobileComponents This adds bindings for Plasma::Package to the PlasmaCore plugin. This class has moved and been renamed from plasma-mobile's MobileComponents (Package - PackageProxy, runtime-visible, it's just PlasmaCore.Package). Diffs - plasma/declarativeimports/core/CMakeLists.txt bf4625c588d13f00da9bd9f72f0eec60cb889616 plasma/declarativeimports/core/corebindingsplugin.cpp 755dad61ceee070d50c7731e14f284b89c0f8d30 plasma/declarativeimports/core/packageproxy.h PRE-CREATION plasma/declarativeimports/core/packageproxy.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107166/diff/ Testing --- Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
