Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
---


this still does not work p[roperly. now i'm getting a (too small) black 
rectangle on the screen around which i can see the rest of my desktop and the 
locker window is still not being shown. investigating now.


ksmserver/screenlocker/lockwindow.cpp


spaces, not tabs.


- Aaron J. Seigo


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> ---
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix 
> is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets 
> on it (which has a translucent background when compositing is active and 
> relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know 
> where to check for the sources.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> ---
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the 
> screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), 
> killed the gretter (noticed that i could have simply xrandr'd the geometry 
> from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Thomas Lübking]

> On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote:
> > this still does not work p[roperly. now i'm getting a (too small) black 
> > rectangle on the screen around which i can see the rest of my desktop and 
> > the locker window is still not being shown. investigating now.

See above, try setting "p.setColor(backgroundRole(), Qt::black);"
The paintEvent is worthless (right after init) - if the window is for some 
reason considered ARGB, it will be translucent with the formerly black painted 
area.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
---


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> ---
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix 
> is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets 
> on it (which has a translucent background when compositing is active and 
> relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know 
> where to check for the sources.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> ---
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the 
> screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), 
> killed the gretter (noticed that i could have simply xrandr'd the geometry 
> from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108640: Check for Valid Wallet Pointer

[David Narváez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108640/
---

Review request for Plasma.


Description
---

Related to bug 312137. According to the documentation, the wallet pointer can 
be null if it was denied, so we need to check for null values before the other 
checks.


Diffs
-

  dataengines/microblog/koauth.cpp 7566b95 

Diff: http://git.reviewboard.kde.org/r/108640/diff/


Testing
---

1. Make sure your plasma desktop does not have "Allow Always" in your kwallet
2. Add a microblogging plasmoid
3. Configure your plasmoid with an identi.ca account
4. Deny any kwallet prompt

Before this path it would crash trying to store the access tokens.


Thanks,

David Narváez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

[David Narváez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108641/
---

Review request for Plasma.


Description
---

I think this is all equivalent to the previous code, but wanted to make sure 
this won't break anything.


Diffs
-

  dataengines/microblog/tweetjob.cpp ba8104a 

Diff: http://git.reviewboard.kde.org/r/108641/diff/


Testing
---

Tested if I was still able to dent with the new code.


Thanks,

David Narváez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108640: Check for Valid Wallet Pointer

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108640/#review26304
---

Ship it!



dataengines/microblog/koauth.cpp


can just as easily be: if (wallet &&

the isNull is not particularly necessary.


- Aaron J. Seigo


On Jan. 28, 2013, 12:40 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108640/
> ---
> 
> (Updated Jan. 28, 2013, 12:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Related to bug 312137. According to the documentation, the wallet pointer can 
> be null if it was denied, so we need to check for null values before the 
> other checks.
> 
> 
> Diffs
> -
> 
>   dataengines/microblog/koauth.cpp 7566b95 
> 
> Diff: http://git.reviewboard.kde.org/r/108640/diff/
> 
> 
> Testing
> ---
> 
> 1. Make sure your plasma desktop does not have "Allow Always" in your kwallet
> 2. Add a microblogging plasmoid
> 3. Configure your plasmoid with an identi.ca account
> 4. Deny any kwallet prompt
> 
> Before this path it would crash trying to store the access tokens.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108641/#review26305
---

Ship it!


Ship It!

- Aaron J. Seigo


On Jan. 28, 2013, 12:43 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108641/
> ---
> 
> (Updated Jan. 28, 2013, 12:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I think this is all equivalent to the previous code, but wanted to make sure 
> this won't break anything.
> 
> 
> Diffs
> -
> 
>   dataengines/microblog/tweetjob.cpp ba8104a 
> 
> Diff: http://git.reviewboard.kde.org/r/108641/diff/
> 
> 
> Testing
> ---
> 
> Tested if I was still able to dent with the new code.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108641/#review26307
---


This review has been submitted with commit 
0f52372b78b4df8ebf59c15b4c807bba7f643b92 by David E. Narváez to branch KDE/4.10.

- Commit Hook


On Jan. 28, 2013, 12:43 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108641/
> ---
> 
> (Updated Jan. 28, 2013, 12:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> I think this is all equivalent to the previous code, but wanted to make sure 
> this won't break anything.
> 
> 
> Diffs
> -
> 
>   dataengines/microblog/tweetjob.cpp ba8104a 
> 
> Diff: http://git.reviewboard.kde.org/r/108641/diff/
> 
> 
> Testing
> ---
> 
> Tested if I was still able to dent with the new code.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108640: Check for Valid Wallet Pointer

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108640/#review26308
---


This review has been submitted with commit 
6e626a7c6ace1b1101d7db512c8c129d3bb32811 by David E. Narváez to branch KDE/4.10.

- Commit Hook


On Jan. 28, 2013, 12:40 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108640/
> ---
> 
> (Updated Jan. 28, 2013, 12:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Related to bug 312137. According to the documentation, the wallet pointer can 
> be null if it was denied, so we need to check for null values before the 
> other checks.
> 
> 
> Diffs
> -
> 
>   dataengines/microblog/koauth.cpp 7566b95 
> 
> Diff: http://git.reviewboard.kde.org/r/108640/diff/
> 
> 
> Testing
> ---
> 
> 1. Make sure your plasma desktop does not have "Allow Always" in your kwallet
> 2. Add a microblogging plasmoid
> 3. Configure your plasmoid with an identi.ca account
> 4. Deny any kwallet prompt
> 
> Before this path it would crash trying to store the access tokens.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Aaron J. Seigo]

> On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote:
> > this still does not work p[roperly. now i'm getting a (too small) black 
> > rectangle on the screen around which i can see the rest of my desktop and 
> > the locker window is still not being shown. investigating now.
> 
> Thomas Lübking wrote:
> See above, try setting "p.setColor(backgroundRole(), Qt::black);"
> The paintEvent is worthless (right after init) - if the window is for 
> some reason considered ARGB, it will be translucent with the formerly black 
> painted area.

ok, this does work better. now i get a fully black screen .. but also i get a 
fully black screen ;) the greeter window is stilling getting the input, so 
evidently has focus, but it isn't raised. i'll see what can be done about that 
next.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
---


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> ---
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix 
> is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets 
> on it (which has a translucent background when compositing is active and 
> relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know 
> where to check for the sources.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> ---
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the 
> screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), 
> killed the gretter (noticed that i could have simply xrandr'd the geometry 
> from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Aaron J. Seigo]

> On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote:
> > this still does not work p[roperly. now i'm getting a (too small) black 
> > rectangle on the screen around which i can see the rest of my desktop and 
> > the locker window is still not being shown. investigating now.
> 
> Thomas Lübking wrote:
> See above, try setting "p.setColor(backgroundRole(), Qt::black);"
> The paintEvent is worthless (right after init) - if the window is for 
> some reason considered ARGB, it will be translucent with the formerly black 
> painted area.
> 
> Aaron J. Seigo wrote:
> ok, this does work better. now i get a fully black screen .. but also i 
> get a fully black screen ;) the greeter window is stilling getting the input, 
> so evidently has focus, but it isn't raised. i'll see what can be done about 
> that next.

well, THAT was easy. simply calling raise() on the view in greeterapp.cpp fixed 
all that.

i also took the opportunity to get rid of kephal .. i'll post a review request 
momentarily.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
---


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> ---
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix 
> is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets 
> on it (which has a translucent background when compositing is active and 
> relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know 
> where to check for the sources.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> ---
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the 
> screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), 
> killed the gretter (noticed that i could have simply xrandr'd the geometry 
> from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/
---

Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.


Description
---

Updated version of Thomas' patch from https://git.reviewboard.kde.org/r/108585/

Tested and works in the use case originally noted as broken, and as a bonus 
includes getting rid of usage of lib#kephal.


This addresses bug 313835.
http://bugs.kde.org/show_bug.cgi?id=313835


Diffs
-

  ksmserver/screenlocker/CMakeLists.txt 
bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
  ksmserver/screenlocker/greeter/CMakeLists.txt 
f89a98d66b774d00bbe8b881c66298ed7e339dac 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
b41cc74ce4f072610772366be3abdf1f4f25f24e 
  ksmserver/screenlocker/lockwindow.h 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
  ksmserver/screenlocker/lockwindow.cpp 
147853b5625277a35bf01247366c6597636c638c 

Diff: http://git.reviewboard.kde.org/r/108643/diff/


Testing
---

start locker when internal laptop screen is on
plug in external screen
kscreen automagically switches it on and the laptop screen off
locker displays properly


Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/
---

(Updated Jan. 28, 2013, 2:38 p.m.)


Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.


Description (updated)
---

Updated version of Thomas' patch from https://git.reviewboard.kde.org/r/108585/

Tested and works in the use case originally noted as broken, and as a bonus 
includes getting rid of usage of libkephal.


This addresses bug 313835.
http://bugs.kde.org/show_bug.cgi?id=313835


Diffs
-

  ksmserver/screenlocker/CMakeLists.txt 
bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
  ksmserver/screenlocker/greeter/CMakeLists.txt 
f89a98d66b774d00bbe8b881c66298ed7e339dac 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
b41cc74ce4f072610772366be3abdf1f4f25f24e 
  ksmserver/screenlocker/lockwindow.h 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
  ksmserver/screenlocker/lockwindow.cpp 
147853b5625277a35bf01247366c6597636c638c 

Diff: http://git.reviewboard.kde.org/r/108643/diff/


Testing
---

start locker when internal laptop screen is on
plug in external screen
kscreen automagically switches it on and the laptop screen off
locker displays properly


Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Aaron J. Seigo]

> On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote:
> > this still does not work p[roperly. now i'm getting a (too small) black 
> > rectangle on the screen around which i can see the rest of my desktop and 
> > the locker window is still not being shown. investigating now.
> 
> Thomas Lübking wrote:
> See above, try setting "p.setColor(backgroundRole(), Qt::black);"
> The paintEvent is worthless (right after init) - if the window is for 
> some reason considered ARGB, it will be translucent with the formerly black 
> painted area.
> 
> Aaron J. Seigo wrote:
> ok, this does work better. now i get a fully black screen .. but also i 
> get a fully black screen ;) the greeter window is stilling getting the input, 
> so evidently has focus, but it isn't raised. i'll see what can be done about 
> that next.
> 
> Aaron J. Seigo wrote:
> well, THAT was easy. simply calling raise() on the view in greeterapp.cpp 
> fixed all that.
> 
> i also took the opportunity to get rid of kephal .. i'll post a review 
> request momentarily.

ok, check out https://git.reviewboard.kde.org/r/108643/ ... it does indeed work 
as expected w/out PaintOutsidePaintEvent, but with the correct backgroundRole 
as thomas noted, and with an extra call to raise() the QML UI (otherwise it 
just gets a black screen).


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
---


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> ---
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix 
> is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets 
> on it (which has a translucent background when compositing is active and 
> relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know 
> where to check for the sources.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> ---
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the 
> screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), 
> killed the gretter (noticed that i could have simply xrandr'd the geometry 
> from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Oliver Henshaw]

> On Jan. 26, 2013, 2:03 p.m., Oliver Henshaw wrote:
> > I don't have multiple monitors to test with, but can you test with the the 
> > LockWindow set to some colour other than black? Just so that any bizarre 
> > side effects are more obvious.
> 
> Thomas Lübking wrote:
> What "bizarre side effects" would you expect?
> My screens are ok ;-P
> 
> (I could see the clock from the WM on where the exposed area would have 
> been and that area was now black)
> 
> I'll try by a nice dodgerblue nevertheless.
> 
> Oliver Henshaw wrote:
> I wanted to be completely sure that it is the lockwindow that is covering 
> the screen and not some other component. Perhaps that's overly paranoid, but 
> I suppose we should err towards the paranoid.
> 
> Thomas Lübking wrote:
> Turns nicely blue, i also debugged me the geometry and that the slot is 
> caught (twice for the screecount change AND the resize)
> 
> Btw and while at it - the code is partially a bit "weird":
> 
> QPalette p = palette();
> p.setColor(backgroundRole(), Qt::transparent); // this is what you got  
> to turn blue
> ** Q: wtf is the background color "transparent" - this is black for 
> 24bit, but guess what it is on a 32 drawable (hint: it's not pink)
> --> Reason?
> setPalette(p); // good
> setAttribute(Qt::WA_PaintOnScreen, true); // bypasses doublebuffer, saves 
> RAM - good
> setAttribute(Qt::WA_NoSystemBackground, false); // iirc default, but good
> setAttribute(Qt::WA_PaintOutsidePaintEvent, true); // for bitBlt in 
> resume()
> ** Q: what ::resume() and what bitBlt? - bitBlt is afair not evel legally 
> supported since Qt 4 and "grep -r resume *" in the screenlocker path is this 
> lone and a label content.
> 
> void LockWindow::paintEvent(QPaintEvent* )
> {
> QPainter p(this);
> p.setBrush(Qt::black); // set only this to Qt::blue, attempt a resize 
> (no matter on how many screens) and watch the result
> p.drawRect(geometry());
> }
> 
> ** Q: "why"? - everything on top says "no paint events", so why is 
> paintevent implemented at all (it will for other reasons once shadow the 
> contents)
> ** Q: p.setPen(Qt::black)?
> 
> Does anybody know about the legacy of this?
> Some Qt3 port that requires cleanup or is this to work-a-round special 
> system issues?
> Quite some of it also is only supported on X11, not Windows or MacOS and 
> i'm not sure about Wayland and Symbian.
> 
> To test this, one btw. does not necessarily require a multiscreen setup - 
> it's sufficient to "xrandr -s 1024x768", lock screen, VT1, export DISPLAY=:0; 
> xrandr -s 0 and "sleep 5; pkill kscreenlocker_g" (or so) -> VT7, see 
> lockwindow

suspend()/resume() seem to have been methods in the 4.9 krunner/lock to 
stop/start the 4.9 screensaver if e.g. it couldn't be seen.

The bitBlt comment was introduced in commit 
71b8c4e239d1b9f7f4884d75afefda794e011034; the bitBlt use in resume() was 
removed/replaced in commit 2a23308ce7fb6f5918b3f7c25ed3b2a70cbcc0e7.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26205
---


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> ---
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> ---
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix 
> is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets 
> on it (which has a translucent background when compositing is active and 
> relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know 
> where to check for the sources.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> ---
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the 
> screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), 
> killed the gretter (noticed that i could have simply xrandr'd the geometry 
> from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-de

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26313
---



ksmserver/screenlocker/greeter/greeterapp.cpp


This is pointless because the greeter view is not managed 
("view->setWindowFlags(Qt::X11BypassWindowManagerHint);")

Internal activation will be required to get the focus, kwin won't set it.

The additional raise might be required on top (if the lockerwindow moved 
itself above the greeter) - at least activateWindow will not raise the window.


- Thomas Lübking


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26314
---


What kinda strucks me is that the window is translucent for the Qt::transparent.
This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed 
out of sth. else here (eg. plasma-desktop) or do you eventually run into this 
with the oxygen-transparent style or the resp. settings of QtCurve or Bespin?

- Thomas Lübking


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

New (QML) Desktop Containment, Take 2 (with movie!)

[Sebastian Kügler]

Hi,

The new desktop containment is coming along nicely. After the first round of 
feedback (thanks for that, btw, for reference, it's the thread with subject 
"[RFC] New (QML) Desktop Containment").

In this iteration, the design is much closer to the current containment. The 
handle has been revamped and is now integrated into the frame, and a bunch of 
missing features has been added (rotation, for example), others brought in 
line with the goals of this piece of software.

A movie says more than thousand words, so please watch this:

http://www.youtube.com/watch?v=GR5UZUtcOGc

The changes from the current (non-QML) containment are, roughly:
- all done in QML ;)
- handle has moved inside the appletframe
- applets align to an invisible grid

The new containnment has a (temporary, it's really only for testing and will 
be removed before release) tuning screen which allows to play around with a 
bunch of values (enable visual debugging aids to show interesting areas, 
change icon size, animation duration and opacity of the halo). This helps us 
to fine-tune a couple of variables in the current layout.

The containment still has a few bugs, but it's pretty functional and feels 
quite solid already. Bugs are:
- sizing issues, applets don't get properly laid out inside the frame
- rotation is hard to control, rotation is very skippy

toolbox:
- add panel doesn't work, missing available plugin reading machinery (works 
  fine from the context menu)
- Containment settings in context menu is grayed out (works fine from toolbox)

The latest state can be found in kde-workspace, in my branch called 
plasma/sebas/desktop-qml. This will install two additional Plasma packages, 
one for the toolbox, one for the containment. Please give it a try and report 
your findings.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Sebastian Kügler]

On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote:
> The new containnment has a (temporary, it's really only for testing and
> will  be removed before release) tuning screen

Ow, forgot: You can get at it by clicking the tiny configure icon in the top-
left corner. Make sure no applet is there, otherwise it won't receive any 
clicks.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Luca Beltrame]

In data lunedì 28 gennaio 2013 16:58:19, Sebastian Kügler ha scritto:

> A movie says more than thousand words, so please watch this:
> http://www.youtube.com/watch?v=GR5UZUtcOGc

The video is marked as private, was that intentional?

--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: 6E1A4E79

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Aaron J. Seigo]

> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote:
> > What kinda strucks me is that the window is translucent for the 
> > Qt::transparent.
> > This also requires it to be 32bit, ie. ARGB - is that lockerwindow 
> > constructed out of sth. else here (eg. plasma-desktop) or do you eventually 
> > run into this with the oxygen-transparent style or the resp. settings of 
> > QtCurve or Bespin?

yes, that's also true: it probably doesn't need to be translucent. or rather, 
shouldn't be because we actively do *not* want content visible through it. this 
could be a hold-over from prior incarnations of the system.

feel free to take the changes in this patch and make more changes :)


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26314
---


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Aaron J. Seigo]

> On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 210
> > 
> >
> > This is pointless because the greeter view is not managed 
> > ("view->setWindowFlags(Qt::X11BypassWindowManagerHint);")
> > 
> > Internal activation will be required to get the focus, kwin won't set 
> > it.
> > 
> > The additional raise might be required on top (if the lockerwindow 
> > moved itself above the greeter) - at least activateWindow will not raise 
> > the window.

this was in the original patch, so i simply left it there. can easily be 
removed.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26313
---


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Aaron J. Seigo]

> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote:
> > What kinda strucks me is that the window is translucent for the 
> > Qt::transparent.
> > This also requires it to be 32bit, ie. ARGB - is that lockerwindow 
> > constructed out of sth. else here (eg. plasma-desktop) or do you eventually 
> > run into this with the oxygen-transparent style or the resp. settings of 
> > QtCurve or Bespin?
> 
> Aaron J. Seigo wrote:
> yes, that's also true: it probably doesn't need to be translucent. or 
> rather, shouldn't be because we actively do *not* want content visible 
> through it. this could be a hold-over from prior incarnations of the system.
> 
> feel free to take the changes in this patch and make more changes :)

aaah .. this was probably indeed related to screensavers and 
widgets-on-screensaver which requires the ability to see through various 
windows and thus argb.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26314
---


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Sebastian Kügler]

On Monday, January 28, 2013 17:01:29 Luca Beltrame wrote:
> In data lunedì 28 gennaio 2013 16:58:19, Sebastian Kügler ha scritto:
> > A movie says more than thousand words, so please watch this:
> > http://www.youtube.com/watch?v=GR5UZUtcOGc
> 
> The video is marked as private, was that intentional?

Ah, sorry. I forgot to change the permission post-upload. It's public now.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Aaron J. Seigo]

On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote:
> A movie says more than thousand words, so please watch this:
>
> http://www.youtube.com/watch?v=GR5UZUtcOGc

cool; when you blog about this (assuming that's at least partly what the video
is for), you may want to make it ++clear that the QML containment shown is
just one example of what can be done with the new QML integration features and
that in turn that means people can much, much more easily create custom
containments as they won't have to touch C++ e.g.

you may even want to point out that it starts to bridge the gap between Plasma
Active's plasma-device shell which uses QML for containments, but in a more
limited fashion, and other Plasma shells for other form factors. .. . which in
turn will lead us to be able to have one shared generic shell which can load
different form foctor layouts on the fly without having to restart the shell
process (as we currently do with, e.g., netbook vs desktop)

it's look rather nice, and it's great to see another component clicking into
place so nicely.

--
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Sebastian Kügler]

On Monday, January 28, 2013 17:26:07 Aaron J. Seigo wrote:
> On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote:
> > A movie says more than thousand words, so please watch this:
> > 
> > http://www.youtube.com/watch?v=GR5UZUtcOGc
> 
> cool; when you blog about this (assuming that's at least partly what the
> video  is for), you may want to make it ++clear that the QML containment

Yes, in the first place, I wanted to collect feedback here. I'll likely also 
put it up on my blog.

> shown is just one example of what can be done with the new QML integration
> features and that in turn that means people can much, much more easily
> create custom containments as they won't have to touch C++ e.g.
> 
> you may even want to point out that it starts to bridge the gap between
> Plasma  Active's plasma-device shell which uses QML for containments, but
> in a more limited fashion, and other Plasma shells for other form factors.
> .. . which in turn will lead us to be able to have one shared generic shell
> which can load different form foctor layouts on the fly without having to
> restart the shell process (as we currently do with, e.g., netbook vs
> desktop)

Good points. :)

> it's look rather nice, and it's great to see another component clicking
> into  place so nicely.

Thanks...
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Oliver Henshaw]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26318
---


This going to be a patch series, isn't it? There looks like there's a few 
things lumped together in this patch (port from kephal, change from transparent 
to black, removal of legacy code snippet, the geometry change fix, the greeter 
window fixup).

I'm not familiar enough with this code to know whether I'm being 
over-sensitive, but please give a thought to future git blamers when this is 
ready to ship.

- Oliver Henshaw


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Marco Martin]

On Monday 28 January 2013, Sebastian Kügler wrote:
> Hi,
> 
> The new desktop containment is coming along nicely. After the first round
> of feedback (thanks for that, btw, for reference, it's the thread with
> subject "[RFC] New (QML) Desktop Containment").
> 
> In this iteration, the design is much closer to the current containment.
> The handle has been revamped and is now integrated into the frame, and a
> bunch of missing features has been added (rotation, for example), others
> brought in line with the goals of this piece of software.
> 
> A movie says more than thousand words, so please watch this:
> 
> http://www.youtube.com/watch?v=GR5UZUtcOGc
> 

looks rather cool ;)

and the new handle seems to actually work well, nice that sketch on the window 
actually worked ;)

is a pretty important piece that was almost a blocker (and thus adapting to 
plasma2 is something that can start soonish)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

repository changes for plasma2/frameworks5

[Marco Martin]

Hi all,

As you know, Plasma is composed mainly by two parts: the library, now in 
kdelibs and a runtime part, now in kde-runtime.

the runtime part is basically:
* QML imports
* A "scriptengine" to write plasmoids in QML, dataengines in javascript etc
* a kpart
* default theme
* some command line tools

For the development of plasma2, the development of those parts will have to go 
together since both have to be ported to QML2 that has some significant 
differences at runtime level.

Since one idea of Frameworks was to have in the same place the library and the 
runtime, this was the idea of repo reorganize:

* what's is now in kdelibs/plasma goes to kdelibs/plasma/plasma (last name 
still being plasma makes possible to move without changes in the code)
* what's now in kde-runtime/plasma (except the "containments" subfolder) goes 
in kdelibs/plasma
* what's now in kde-runtime/desktoptheme goes to kdelibs/plasma/desktoptheme

probably in the end i guess all of this will have to go in a separate repo of 
its own: so the merge operation can be done either before, still in kdelibs or 
after the creation of a new repo (if we want it in a separate repo)


Most important, what is the less messy git way to do it?

Cheers, 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repository changes for plasma2/frameworks5

[Stephen Kelly]

Marco Martin wrote:

> Most important, what is the less messy git way to do it?

As we discussed on IRC, it may be better to split plasma out into its own 
repo now already, like we did with nepomuk.

As the frameworks branch has a 'use-by' date, I'd prefer not to import more 
things into it from kde-runtime.

Thanks,

Steve.


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Aaron J. Seigo]

> On Jan. 28, 2013, 4:44 p.m., Oliver Henshaw wrote:
> > This going to be a patch series, isn't it? There looks like there's a few 
> > things lumped together in this patch (port from kephal, change from 
> > transparent to black, removal of legacy code snippet, the geometry change 
> > fix, the greeter window fixup).
> > 
> > I'm not familiar enough with this code to know whether I'm being 
> > over-sensitive, but please give a thought to future git blamers when this 
> > is ready to ship.

there are exactly 2 things in this changeset: the screen painting and geometry 
fix (which make no sense apart from each other and require changes to both the 
greeter and the locker) and the removal of kephal. i was hoping they would be 
easily separated with a simple git commit --interactive but the kephal change 
overlapped too far with one of the other changes. if/when committed, i will 
obviously put those into 2 commits.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26318
---


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repository changes for plasma2/frameworks5

[Marco Martin]

On Monday 28 January 2013, Stephen Kelly wrote:
> Marco Martin wrote:
> > Most important, what is the less messy git way to do it?
> 
> As we discussed on IRC, it may be better to split plasma out into its own
> repo now already, like we did with nepomuk.
> 
> As the frameworks branch has a 'use-by' date, I'd prefer not to import more
> things into it from kde-runtime.

yeah, would go for creating a new repo now, now asked scm interest and will 
let you know since may be useful again in frameworks in the future

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Fwd: KDE switch desktop direction

[Chani]

-- Forwarded message --
From: Anders Aspegren Søndergaard 
Date: Mon, Jan 28, 2013 at 5:06 AM
Subject: KDE switch desktop direction
To: ch...@kde.org


Hi

When in KDE "search and launch" activity, scrolling up switches
desktop to lower numbers
and down to higher numbers. I.e. you go from Desktop n to Desktop n +
1 when scrolling down.
Can this be reversed?

Anders A. Søndergaard


--
Chani
www.chani.ca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Fwd: KDE switch desktop direction

[Sebastian Kügler]

Hi Chani,

On Monday, January 28, 2013 10:15:54 Chani wrote:
> When in KDE "search and launch" activity, scrolling up switches
> desktop to lower numbers
> and down to higher numbers. I.e. you go from Desktop n to Desktop n +
> 1 when scrolling down.
> Can this be reversed?

Please direct the user to bugs.kde.org, instead of plasma-devel.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Thomas Lübking]

> On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 210
> > 
> >
> > This is pointless because the greeter view is not managed 
> > ("view->setWindowFlags(Qt::X11BypassWindowManagerHint);")
> > 
> > Internal activation will be required to get the focus, kwin won't set 
> > it.
> > 
> > The additional raise might be required on top (if the lockerwindow 
> > moved itself above the greeter) - at least activateWindow will not raise 
> > the window.
> 
> Aaron J. Seigo wrote:
> this was in the original patch, so i simply left it there. can easily be 
> removed.

from RR 108585? (it's not in the RB diff)

The thing i posted at the greeter bug is only to document the local alteration 
at that time (experimented with a managed window because of the focus thing - 
it's not an option though unless we rely on a NETWM compliant WM)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26313
---


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

[Thomas Lübking]

> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote:
> > What kinda strucks me is that the window is translucent for the 
> > Qt::transparent.
> > This also requires it to be 32bit, ie. ARGB - is that lockerwindow 
> > constructed out of sth. else here (eg. plasma-desktop) or do you eventually 
> > run into this with the oxygen-transparent style or the resp. settings of 
> > QtCurve or Bespin?
> 
> Aaron J. Seigo wrote:
> yes, that's also true: it probably doesn't need to be translucent. or 
> rather, shouldn't be because we actively do *not* want content visible 
> through it. this could be a hold-over from prior incarnations of the system.
> 
> feel free to take the changes in this patch and make more changes :)
> 
> Aaron J. Seigo wrote:
> aaah .. this was probably indeed related to screensavers and 
> widgets-on-screensaver which requires the ability to see through various 
> windows and thus argb.

The locker window is not 32bit here.
(print yourself the winId() and from VT1 or ssh do "xwininfo -id "
The "Depth" says "24" here.
If it does for you as well, this could be a driver issue (eg. the MSAA problem 
- would not happen with XRender compositing then)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/#review26314
---


On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108643/
> ---
> 
> (Updated Jan. 28, 2013, 2:38 p.m.)
> 
> 
> Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.
> 
> 
> Description
> ---
> 
> Updated version of Thomas' patch from 
> https://git.reviewboard.kde.org/r/108585/
> 
> Tested and works in the use case originally noted as broken, and as a bonus 
> includes getting rid of usage of libkephal.
> 
> 
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 
> f89a98d66b774d00bbe8b881c66298ed7e339dac 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b41cc74ce4f072610772366be3abdf1f4f25f24e 
>   ksmserver/screenlocker/lockwindow.h 
> 5cbc76956a4b83d46da96a7ef768116ffdd505c3 
>   ksmserver/screenlocker/lockwindow.cpp 
> 147853b5625277a35bf01247366c6597636c638c 
> 
> Diff: http://git.reviewboard.kde.org/r/108643/diff/
> 
> 
> Testing
> ---
> 
> start locker when internal laptop screen is on
> plug in external screen
> kscreen automagically switches it on and the laptop screen off
> locker displays properly
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New (QML) Desktop Containment, Take 2 (with movie!)

[Sebastian Kügler]

On Monday, January 28, 2013 17:29:36 Sebastian Kügler wrote:
> On Monday, January 28, 2013 17:26:07 Aaron J. Seigo wrote:
> > On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote:
> > > A movie says more than thousand words, so please watch this:
> > >
> > > http://www.youtube.com/watch?v=GR5UZUtcOGc
> >
> > cool; when you blog about this (assuming that's at least partly what the
> > video  is for), you may want to make it ++clear that the QML containment
> 
> Yes, in the first place, I wanted to collect feedback here. I'll likely
> also  put it up on my blog.

I've blogged about it: 

http://vizzzion.org/blog/2013/01/desktop-containment-moving-to-plasma-quick/
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Non-OAuth Support in Microblogging Plasmoid

[David Narvaez]

Hi,

As you'll see in the logs, I've been giving some maintenance to the
Microblogging plasmoid. As I was reviewing open bug reports I stumbled upon
bug 304704. The users expecto be able to use the microblogging plasmoid to
log into any StatusNet instance, but we are only supporting OAuth right
now, so it means we have to set up keys for the services we support
(currently the two most common). Is this intended and we should close the
bug as invalid? Or should we support both OAuth and the regular
authentication mechanism?

David E. Narváez
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel