Re: Review Request 108223: use Plasma::Dialog for kmix osd
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review27114 --- Just got a bug report that is likely realted to this change (started happening on kde 4.10): Bug 314803 - OSD glitches out and freezes https://bugs.kde.org/show_bug.cgi?id=314803 - Christian Esken On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 11:52 p.m.) Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian Esken. Description --- Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for kmix osd. Diffs - gui/osdwidget.h 9ec0100 gui/osdwidget.cpp 2dc202e Diff: http://git.reviewboard.kde.org/r/108223/diff/ Testing --- localily tested, no problem Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- Review request for kdelibs, Plasma and David Faure. Description --- This patch adds a variable QML_INSTALL_DIR, pointing to the location to install QtQuick2 imports. These are co-installable with QtQuick 1.x, so we need both dirs. Naming is consistent with the path, so IMPORT is ditched from the name (the path doesn't have imports in it anymore). Diffs - kde-modules/KDEInstallDirs.cmake ea132e6 Diff: http://git.reviewboard.kde.org/r/108889/diff/ Testing --- Used it in plasma-framework, functions as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 10, 2013, 3:37 p.m.) Review request for kdelibs, Plasma and David Faure. Description --- This patch adds a variable QML_INSTALL_DIR, pointing to the location to install QtQuick2 imports. These are co-installable with QtQuick 1.x, so we need both dirs. Naming is consistent with the path, so IMPORT is ditched from the name (the path doesn't have imports in it anymore). Diffs - kde-modules/KDEInstallDirs.cmake ea132e6 Diff: http://git.reviewboard.kde.org/r/108889/diff/ Testing --- Used it in plasma-framework, functions as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27129 --- kde-modules/KDEInstallDirs.cmake http://git.reviewboard.kde.org/r/108889/#comment20443 For an install prefix in /usr, this would make it /usr/qml ... is this really wanted? Shouldn't this be QT_PLUGIN_INSTALL_DIR/qml, i.e. /usr/lib/plugins/qml ? - David Faure On Feb. 10, 2013, 3:37 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 10, 2013, 3:37 p.m.) Review request for kdelibs, Plasma and David Faure. Description --- This patch adds a variable QML_INSTALL_DIR, pointing to the location to install QtQuick2 imports. These are co-installable with QtQuick 1.x, so we need both dirs. Naming is consistent with the path, so IMPORT is ditched from the name (the path doesn't have imports in it anymore). Diffs - kde-modules/KDEInstallDirs.cmake ea132e6 Diff: http://git.reviewboard.kde.org/r/108889/diff/ Testing --- Used it in plasma-framework, functions as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27131 --- Ship it! Looks good. - Alexander Neundorf On Feb. 10, 2013, 3:37 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 10, 2013, 3:37 p.m.) Review request for kdelibs, Plasma and David Faure. Description --- This patch adds a variable QML_INSTALL_DIR, pointing to the location to install QtQuick2 imports. These are co-installable with QtQuick 1.x, so we need both dirs. Naming is consistent with the path, so IMPORT is ditched from the name (the path doesn't have imports in it anymore). Diffs - kde-modules/KDEInstallDirs.cmake ea132e6 Diff: http://git.reviewboard.kde.org/r/108889/diff/ Testing --- Used it in plasma-framework, functions as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes
On Feb. 10, 2013, 3:40 p.m., David Faure wrote: kde-modules/KDEInstallDirs.cmake, line 136 http://git.reviewboard.kde.org/r/108889/diff/1/?file=113440#file113440line136 For an install prefix in /usr, this would make it /usr/qml ... is this really wanted? Shouldn't this be QT_PLUGIN_INSTALL_DIR/qml, i.e. /usr/lib/plugins/qml ? Apparently not. I've looked at where the example imports from the Qt codebase install these things, and that is indeed $PREFIX/qml, not inside the plugin directory. This location is also where these imports are being found automatically, i.e. without specifying additional import pathes (which we have to do for Plasma in kdelibs 4). - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27129 --- On Feb. 10, 2013, 3:37 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 10, 2013, 3:37 p.m.) Review request for kdelibs, Plasma and David Faure. Description --- This patch adds a variable QML_INSTALL_DIR, pointing to the location to install QtQuick2 imports. These are co-installable with QtQuick 1.x, so we need both dirs. Naming is consistent with the path, so IMPORT is ditched from the name (the path doesn't have imports in it anymore). Diffs - kde-modules/KDEInstallDirs.cmake ea132e6 Diff: http://git.reviewboard.kde.org/r/108889/diff/ Testing --- Used it in plasma-framework, functions as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 108891: Force row settings in Task Manager should use row first sorting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108891/ --- Review request for Plasma. Description --- Dear everyone, I'd like to draw your attention to the somewhat recent activity that's been happening concerning issue #215231 (https://bugs.kde.org/show_bug.cgi?id=215231 ). Basically it boils down to people strongly voicing their opinions on their preference of a row first sorting order for the task bar when the force rows setting is enabled. This issue has come up before 2 years ago (see https://svn.reviewboard.kde.org/r/5776/ ), where the request to implement this was denied. Interestingly enough, the negatively received change was only introduced in the 4.6 release. Effectively, we, the users, feel this is a feature regression, breaking a functionality that's worked in previous releases just fine. We therefore kindly ask for this issue to be reconsidered for resolution, i.e. bringing back the behaviour from pre 4.6 releases. This addresses bug 215231. None Diffs - Diff: http://git.reviewboard.kde.org/r/108891/diff/ Testing --- Thanks, Michael Biech ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108891: Force row settings in Task Manager should use column major sorting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108891/ --- (Updated Feb. 10, 2013, 5:22 p.m.) Review request for Plasma. Changes --- Had the sorting order the wrong way around. Summary (updated) - Force row settings in Task Manager should use column major sorting Description --- Dear everyone, I'd like to draw your attention to the somewhat recent activity that's been happening concerning issue #215231 (https://bugs.kde.org/show_bug.cgi?id=215231 ). Basically it boils down to people strongly voicing their opinions on their preference of a row first sorting order for the task bar when the force rows setting is enabled. This issue has come up before 2 years ago (see https://svn.reviewboard.kde.org/r/5776/ ), where the request to implement this was denied. Interestingly enough, the negatively received change was only introduced in the 4.6 release. Effectively, we, the users, feel this is a feature regression, breaking a functionality that's worked in previous releases just fine. We therefore kindly ask for this issue to be reconsidered for resolution, i.e. bringing back the behaviour from pre 4.6 releases. This addresses bug 215231. None Diffs - Diff: http://git.reviewboard.kde.org/r/108891/diff/ Testing --- Thanks, Michael Biech ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plans for SVN infrastructure shutdown
Hi all, What's about user home dir hosted in SVN repository which must be moved somewhere is GIT. Typically, mine is here : http://websvn.kde.org/branches/work/~cgilles/ Best Gilles Caulier 2013/2/7 Marco Martin notm...@gmail.com On Wednesday 02 January 2013, Nicolás Alvarez wrote: The initial draft of the SVN shutdown plan is available on the community wiki: http://community.kde.org/Sysadmin/SVNInfrastructureShutdown As you can see this is a long-term plan. None of this is written in stone; any feedback is welcome! Is this still the active plan? in plasma we have some stuff into svn, kept here because git doesn't work that well, basically artwork: kde-artwork kde-wallpapers kde-artwork-active all of that can be moved, but will probably be among most problematic repositories that still have to be migrated.. suggestions for those? Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plans for SVN infrastructure shutdown
2013/2/7 Ben Cooksley bcooks...@kde.org On Fri, Feb 8, 2013 at 1:38 AM, Gilles Caulier caulier.gil...@gmail.com wrote: Hi all, Hi Gilles, What's about user home dir hosted in SVN repository which must be moved somewhere is GIT. Typically, mine is here : http://websvn.kde.org/branches/work/~cgilles/ You should migrate those to repositories under your scratch namespace on git.kde.org. Hi Ben, My scratch namespace ? I'm not sure to understand... Gilles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 104281: Drop Decorations B2, Laptop and Plastik
On Feb. 7, 2013, 10:25 p.m., Albert Astals Cid wrote: I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited? Aaron J. Seigo wrote: plastik is gone, but b2 and laptop are still there. Albert Astals Cid wrote: Is anyone planning to take care of that removal? Martin? Thomas? Thomas Lübking wrote: Regarding the bug reports about plastik became slow i'd say such movement (at least for Laptop) is only possible along the introduction of a maintained legacy decoration. I sent a round an RFC reg. a deco for low (network) overhead and maximum usability (so we've a failsafe decoration for ppl. with bad eys or weird network setups with the WM remote) but got no comment on that (needs input from a11y and HIG and possibly a veto from the oxygen team) As Thomas wrote: it's blocked by waiting for a (maintained) legacy decoration. The decorations need to go (B2 is intercepting XEvents, Laptop is just broken), but they are currently our only chance to offer something useable for remote users (not that I would say it's a valid use case in 2013). - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104281/#review26898 --- On March 29, 2012, 11:27 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104281/ --- (Updated March 29, 2012, 11:27 a.m.) Review request for kwin and Plasma. Description --- As discussed on mailinglist: http://lists.kde.org/?l=kwinm=133136239707091w=2 Diffs - kwin/clients/CMakeLists.txt 6019a9e kwin/clients/b2/CMakeLists.txt 9295cbe kwin/clients/b2/b2.desktop 2846e39 kwin/clients/b2/b2client.h c9e9b57 kwin/clients/b2/b2client.cpp 6b52996 kwin/clients/b2/bitmaps.h 00c4552 kwin/clients/b2/config/CMakeLists.txt 1aaf8da kwin/clients/b2/config/config.h c5bc33c kwin/clients/b2/config/config.cpp fc9c7b9 kwin/clients/laptop/CMakeLists.txt 1f4d600 kwin/clients/laptop/laptop.desktop ccc9d54 kwin/clients/laptop/laptopclient.h 4f1196d kwin/clients/laptop/laptopclient.cpp 52efcd1 kwin/clients/plastik/CMakeLists.txt fce0829 kwin/clients/plastik/config/CMakeLists.txt e48955d kwin/clients/plastik/config/config.h b037efe kwin/clients/plastik/config/config.cpp a4ddfe0 kwin/clients/plastik/config/configdialog.ui fe9f53a kwin/clients/plastik/plastik.h ae7a46e kwin/clients/plastik/plastik.cpp ff9825f kwin/clients/plastik/plastik.desktop 30550c6 kwin/clients/plastik/plastikbutton.h 395f628 kwin/clients/plastik/plastikbutton.cpp db29d76 kwin/clients/plastik/plastikclient.h 4c5b0d9 kwin/clients/plastik/plastikclient.cpp 58f8324 Diff: http://git.reviewboard.kde.org/r/104281/diff/ Testing --- it compiles Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
