Re: Review Request 109773: New runner that translates words and sentences via Google Translate.
> On April 15, 2013, 11:08 a.m., Aaron J. Seigo wrote: > > spiffy! this can go in for 4.11 and i look forward to using it. > > > > as a german language learner, i'm constantly hitting leo and google > > translate to fill in gaps .. so this will be a nice addition to the tools > > on my desktop! thanks... Thanks. Would you like to commit it? I don't have a contributer account yet. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109773/#review31079 --- On April 15, 2013, 1:17 a.m., David Baum wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109773/ > --- > > (Updated April 15, 2013, 1:17 a.m.) > > > Review request for Plasma. > > > Description > --- > > The Runner uses the Google Translate Homepage and supports all languages > provided by Google. It doesn't use the API, because it's not free of charge. > > > Diffs > - > > runners/CMakeLists.txt bb4b491b10e6fef8183a66f55f5d5832dd7bc41a > runners/translator/CMakeLists.txt PRE-CREATION > runners/translator/plasma-runner-translator.desktop PRE-CREATION > runners/translator/translator.h PRE-CREATION > runners/translator/translator.cpp PRE-CREATION > runners/translator/translatorjob.h PRE-CREATION > runners/translator/translatorjob.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109773/diff/ > > > Testing > --- > > > Thanks, > > David Baum > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Behaviours with States
Hi there,
In my QML plasmoid I was tracking a bug related to using Behaviours
with States, when I found this helpful documentation page:
http://qt-project.org/doc/qt-4.8/qml-behaviors-and-states.html
This solved it for me, or rather nudged me in the right direction. I
have found another way of solving this problem - just explicitly
define the default state:
states: [
State {
name: "GreenState"
when: mouser.containsMouse
PropertyChanges {
target: coloredRect
color: "green"
}
},
State {
name: ""
PropertyChanges {
target: coloredRect
color: "red"
}
}
]
This does not require the rest of the QML app to be aware of the name
of the new "default" state; nor does it require the default state
conditions to be precisely defined (which sometimes might be a
challenge, and besides opens the plasmoid for new, hard to track
errors).
The empty name "" denotes the default base state anyway.
I have tested it in my plasmoid and it indeed works. I think it would
be a good idea to out that in the docs.
--
Pozdrawiam
Michał "rysiek" Woźniak
Fundacja Wolnego i Otwartego Oprogramowania
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Menu branch
A UI draft: http://imagebin.org/254401 Maybe move "Icon size" to the "Arrangement" section? Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: GSOC Project Proposal Draft :: Improvement and Enhancements for Plasma Media Center
Overall, draft proposal looks good to me :) On Mon, Apr 15, 2013 at 11:05 PM, Akshay Ratan wrote: > Hello, > Here is my proposal draft for GSOC 2013. I would look forward for > your constructive criticisms and feedback. It can be accessed at the > following link: > https://dl.dropboxusercontent.com/u/107169565/GSOC_Proposal_Draft.doc . > > Regards, > Akshay Ratan > (akshay_r #plasma #kde-devel) > > > > On Fri, Apr 12, 2013 at 11:28 PM, Sinny Kumari wrote: > >> Doing CC to plasma-devel >> >> You need to send email to plasma-devel@kde.org instead of >> plasma-devel-requ...@kde.org :) >> >> >> On Thu, Apr 11, 2013 at 10:49 PM, Akshay Ratan wrote: >> >>> Hello everyone, >> >> >> Hi! >> >> >>> I am working on the Project :: *Improvement and >>> Enhancements for Plasma Media Center*. Before finalizing my GSOC >>> Proposal, I wish to share a few ideas which I have regarding the project >>> besides those which are mentioned in the KDE Community wiki. As we all know >>> this year, KDE theme for GSOC is "Polishing Existing Things", I look >>> forward to help make PMC even better. >>> >> >> Good to know that ! >> >> Few of these ideas are described below, some of which I would like to >>> work on::: >>> >>> 1. There is no option for subtitles in the video player. Its need is >>> immense in any video player. Implementing the subtitle feature in the >>> Plasma Media Center's Video player as a part of my GSOC would be great ! >>> Though there is subtitleprovider.cpp file relevant but still on testing, >>> there comes no option for subtitles. >>> >> >> +1 >> >> Yes, It would be good if we have option to add subtitles too. >> >> >>> 2. Currently available backends for fetching media are from Picasa and >>> Flickr. Extending the "onlineservices" library, so that after the >>> implementation, backend support is available for Facebook and Dropbox. >>> digiKam for that matter has plugins to import and export to various online >>> services. This would not only make PMC Application better but also put it >>> forward in the line of top image viewer applications. >>> >> >> Its good to have more and more plugins in PMC but I would suggest not to >> concentrate on additional plugins. Instead of that try to focus on core >> functionalities in PMC and improvement wherever possible. >> >>> >>> Line of action would be on the basis of existing backend support like : >>> https://github.com/akshayratan/Plasma-Media-Center/blob/master/browsingbackends/onlineservices/picasa/moc_picasamodel.cpp >>> >>> >> >> Don't look at moc files. These are auto-generated file when cmake run. >> Look at >> https://projects.kde.org/projects/kdereview/plasma-mediacenter/repository/revisions/master/entry/browsingbackends/onlineservices/picasa/picasamodel.cpp. >> >> >>> 3. In the working of the Plasma Media Center Application, I propose to >>> implement the "Keyboard's BACKSPACE KEY" to function as one-level before. >>> Just as arrow keys are used to view pictures left to right and vice versa, >>> backspace tool would be great as users can entirely control it using >>> keyboard. Further, a relevant bug(though not exactly same) is already there >>> on bugs.kde.org . The link is : >>> https://bugs.kde.org/show_bug.cgi?id=317233 . >>> >>> >> +1 >> >> Other than that we also have to do some redesign of the flow so that >> keyboard-only navigation is possible. >> >> >>> 4. Improved indexing of metadata of videos using Webminer and Nepomuk >>> Indexer. >>> >>> Though I am very comfortable in Qt C++ framework, I am not that much >>> familiar with qml(Qt Meta Language) which I hope to learn soon. Anyways, >>> following is a qml function which needs to be polished to implement the >>> backspace feature :: >>> https://github.com/akshayratan/Code/blob/master/handling_keys. This >>> particular function is for ImageViewer in PMC. This feature I would like to >>> take upon in my GSOC project. >>> >>> Besides this, following were the community ideas for implementation >>> >>>- Categorizing media better like pictures on the basis of tags, >>>videos according to different filters - length, quality etc >>>- Improving playlist search - should be able to search through >>>artist, album etc >>>- Folder preview in Local Media Browsing >>> >>> >>> I would soon post a draft of my implementation scheme and further ideas >>> framed in a proper proposal format. Please help me correct myself if I am >>> wrong somewhere. I am looking forward for a positive response. >>> I would further like to know in detail a little bit about the third >>> community suggestion of "Folder preview in Local Media Browsing". Where >>> exactly I should begin hacking for this feature. >>> >> >> You need to look into Dolphin source code since Dolphin has this >> functionality. >> >> >>> >>> To tell the Plasma Community something about myself- I am an ICT >>> undergraduate student at DA-IICT, Gandhinagar, India. I love hacking on >>> open-source.
Re: Menu branch
Hello, Wow that was fast :) Glad to see you coding for plasma, your experience is very welcome (not to say I finally have someone to poke to death with design questions ;) ) - Display options is indeed a mess, well is it ok to mix combos and checkboxes together? i.e. 2 combos, 1 checkobox, then 1 combo and 2 checkboes etc. And they keep growing in number, although the existing changes should have added the last ones. - Icon alignment aka flow: I have been thinking about splitting that up ever since I saw it, but that means one more checkbox. On the other hand, honestly, it would make sense to split that in the code as well (see the current code - imho it sucks - to answer "are we using rows or columns" the flow is is compared with two enums, same for left vs right, not as easy to read). The UI, on the other hand, is up to aseigo, from what I understand - I'm all for it, but a decent UI advice is of course welcome. (fredrikh, what do you think?) - setCurrentItem() - which one did you like better, monolithic setCurrentItem(), find() and then set() depending on find(), or the last one with set() being unnecessary? For me, it's usually "code what to do not how", but this time I was not sure if it was just too much auxiliary code. - int(FolderViev::Unsorted) is a hack around the fact the sorting column is not homogenuous. 4 of them are enum KDirModel::(something), 1 is FV::Unsorted. Hence there is no way to have a real typed enum bracing them all in there. All the others, which you should have noticed, are enums with qvariant's since that gives you compiler warnings and errors in case you mess up - a nice thing imho :) Thank you for the advice! Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/ --- (Updated April 17, 2013, 4:57 p.m.) Review request for Plasma and Marco Martin. Changes --- fix some space.. Description --- Current notifications will give quite a lot warning, since jobsSource.data[modelData] might be undefined in the first place. And this can also cause label1NameText to be shown as "undefinded: " for a job, this can be reproduced when you do the job of copy a large folder to sftp, the label1 will be undefined when doing the folder creation. Diffs (updated) - plasma/generic/applets/notifications/contents/ui/JobDelegate.qml cf60946 Diff: http://git.reviewboard.kde.org/r/110065/diff/ Testing --- all related warning is now suppressed, and undefined will not be shown in the same case. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/ --- Review request for Plasma and Marco Martin. Description --- Current notifications will give quite a lot warning, since jobsSource.data[modelData] might be undefined in the first place. And this can also cause label1NameText to be shown as "undefinded: " for a job, this can be reproduced when you do the job of copy a large folder to sftp, the label1 will be undefined when doing the folder creation. Diffs - plasma/generic/applets/notifications/contents/ui/JobDelegate.qml cf60946 Diff: http://git.reviewboard.kde.org/r/110065/diff/ Testing --- all related warning is now suppressed, and undefined will not be shown in the same case. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Menu branch
Hi, the branch generally looks OK to me, however: - Display -> Icons in the config dialog is getting to be pretty messy; with that abundance of options it might make sense to split things into group boxes for Arrangement (flow, grid, lock) and Sorting (role, direction, folders first) to avoid e.g. role and folders first being seven items removed from each other despite being topically closely linked. - It might be my tiredness and the still-lingering cold, but it took me an embarassingly long time to wrap my brain around the entries in the flow combo - I think expecting users to get an ordered list of sort factors like those variants of "Left to Right, Top to Bottom" is a bit of a tall order. Since there are no Bottom to Top variants anyway, it might more easily build a mental picture to speak of Rows vs. Columns and Alignment, i.e.: Layout: [Rows | Columns] Align: [Left | Right] ... yes, that makes for _even more options_, but from pro- gressive disclosure POV and how users presumably approach the problem, it hopefully makes more sense. I.e. I doubt there are going to be many users who intuitively go "I want it to place the icons top to bottom first, and then right to left!" (that's just how the code goes about it :), they are more likely to go "I kind of want rows, not columns." Take that as a brainstorm tho, this is one of these things you can overthink to death - I liked your original setCurrentItem() helper better than the solution you wound up with, which ends up attempting to set a QComboBoxes' currentIndex to -1 in the failure case instead of just leaving it alone. - Fun fact: All that int(FolderView::Foo) everywhere can go with C++11 strongly typed enumerations, allowing you to explicitly inherit an enum from int or uint ... Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
snapshot of the kanban
Hi all, to make documentation of what is happening here in nuremberg here is a photo of the initial status of the kanban board. http://makeplaylive.com/~notmart/tokamak6_kanban_todo.jpg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Menu branch
A small update: I think that the setCurrentItem() abstraction is superfluous, not to mention that the name coincides with that of a QComboBox member function, thus I've put the workaround in findComboboxItem(), so now it is clear what is worked around, and once qt5 comes, it will be easy to swap the necessary code for QComboBox::findData() (in qt5, QVariant::operator==() works fine wrt to enums that are Q_DECLARE_METATYPE'd - tested by tsdgeos in a qt5 installation). For the record: [Thursday 11 April 2013] [00:07:23]qDebug() << (QVariant::fromValue(Test::two) == QVariant::fromValue(Test::two)); [Thursday 11 April 2013] [00:07:24]false [Thursday 11 April 2013] [00:08:30]Compares this QVariant with v and returns true if they are equal; otherwise returns false. [Thursday 11 April 2013] [00:08:32]In the case of custom types, their equalness operators are not called. Instead the values' addresses are compared. [Thursday 11 April 2013] [00:14:58]isemenov: yeah that works in qt5 [Thursday 11 April 2013] [00:15:05]qDebug() << (QVariant::fromValue(Test::two) == QVariant::fromValue(Test::two)); [Thursday 11 April 2013] [00:15:06]returns true Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Menu branch
Hello plasma devs and users, Please review the plasma/isemenov/menu branch. Based on #306537 but goes a bit further than that. Fixes: "Arrange icons" (flow configuration) added to the context menu "Sort order" and "folders first" added to the config UI Update the "Sort" combo if the user moves the icons while the dialog is open - fix by Eike Hein, I expressed it using a helper func since the relevant code has changed slightly Update sort order, sort direction, flow combos when the user cnahges those using the context menu if the config dialog is open Update the align to grid, lock in place, folders first, click to view checkboxes when the user cnahges those using the context menu if the config dialog is open Fix a potential stall (instead of iterating the combos from 0 till maxCount() (INTMAX) which can result in a minute-long loop (tested) if the value is not found iterate them from 0 till count()) - thanks goes to tsdgeos for explaiing me that comboboxes are contiguous Changed the hardcoded "-1" to an anonymous enum "FolderView::Unsorted = -1" for code clarity and maintainability Only show the "Unsorted" action in the "Sort" combo if the view is not sorted. It appears when the users drags icons around, and lives until the dialog is closed. Then, when the dialog is opened again, if the view is still unsorted, it is added to the list. If the user sorts the view using the combo or the context menu, unsorted still stays until the dialog is closed - probably better than have it appear and disappear within an open dialog. This implements aseigo's idea. Also, since I had to move the flow and sorting direction to QActionGroups (to enable them in the context menu), and that lead to duplicated for loops, I created a little helper to add action groups to combos. (trying to follow "code what to do, not how to do it"). Another thing worth mentioning is the setCurrentItem() helper func. I should be using QComboBox::findData(), *but* we use enums for the action data, hence QVariant's and Q_DECLARE_METATYPE. QVariant::operator==() fails for user defined types, including Q_DECLARE_METATYPE'd enums. Debugged together with tsdgeos and steveire. So we have to workaround that, in a manually written loop, which I put in a helper func. Thank you for your attention! Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
