FW: GSOC-2013 Proj- PMC rel. queries

[Saurabh Jain]

Dear sir/mam,Please went through the below forwarded mail which is in 
continuation to what Sinny mam had presented her views on my earlier ideas. In 
my last email, I have mentioned 2 more improvements so I request you to please 
give your feedback to me. Also, I apologize for not sending my past e-mails to 
"plasma-devel@kde.org". 
Thanks and Regards,Saurabh Jain
From: saurabh...@hotmail.com
To: ksi...@gmail.com
Subject: RE: GSOC-2013 Proj- PMC rel. queries
Date: Sat, 20 Apr 2013 15:26:41 +0530







Thank you.
All music, All pictures and All Videos are still not working on my system even 
after reinstalling the nepomuk packages. When restarting the nepomukindexer, I 
get the following error in the end-  Error: "/var/tmp/kdecache-saurabh" is 
owned by uid 1001 instead of uid 0. I will try to resolve this issue with 
nepomuk community. 

Yes, shuffle mode is working well and mistakenly I pointed it out as missing. 
What I would like to point out is once you have created a playlist, you cannot 
rearrange the existing order of songs to the desired one. The only way, which I 
found, to do so is to create an another playlist from the beginning. 

One more improvement which I would like to mention in Pictures section is that 
in presence of proxy server, picasa is unable to connect to the google account 
or to load the pictures.
Also, pressing the "tab" key after entering the email id in google account 
section does not move the cursor to next section, i.e., password textbox. 
Keyboard does not seem to produce any output in some other situations as well.


Regards,
Saurabh Jain

Date: Fri, 19 Apr 2013 23:46:37 +0530
Subject: Re: GSOC-2013 Proj- PMC rel. queries
From: ksi...@gmail.com
To: saurabh...@hotmail.com
CC: Plasma-devel@kde.org


Doing CC to plasma-devel


Thanks Saurabh for you effort. Nice start! 

On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain  wrote:
















Dear mam,

Thanks for replying me back and presenting your views. Yes, you were right and 
I did deviate from the main point as I used the software and liked the idea of 
building such an application and therefore I thought more in enhancing and 
incorporating new features in it.
I forgot to mention some of the improvements, which I think, can be done in 
this application. The "open with" menu option which I mentioned in my first 
mail also needs to be improved as the user can see this application in the 
above menu but due to lack of functionality provided on the back end, the user 
does not get the desired output response. 



+1
I like this idea, this need to be implemented.
 

Improvements in following sections can be:- 
Music :-
Search engine (in Songs, Album, etc.) does not seem to work at all. I tried 
searching for a music which is also there in the playlist but did not get any 
results (neither did it respond with search failure nor with song 

found). Improving the song search can have an alternative if sorting feature is 
introduced by virtue of which user can sort the albums, songs etc according to 
their names. Player can be enhanced with modes like repeat, shuffle, etc. and 
reordering of songs in the playlist is also not there. 


Ummm, For me search works fine for Artist, Album and songs works fine but yeah, 
it doesn't display message when search result is zero.


Shuffle works in Playlist. Repeat option can be added.
Sorting of media is needed on the basis of different field like size, date, 
name, length etc.



Pictures:-
Again, clicking on "All Picture" does not produce any results. Every time if 
the user has to view the pictures, he/she has to browse the pictures in the 
folders first and then load it. Further, just like we have the option to select 
some files and play them only, in a similar fashion, we can have option to 
select some pictures and then view them via slide show. 



I guess, your Nepomuk indexer is not running or maybe haven't indexed your 
picture directory. Check with that then All Picture will work fine.


Yeah, we can think of viewing selected pictures in slideshow.
 
Videos:-
The full screen mode toggle button can be added into video section so that the 
user can directly watch the video in full screen mode. Also, many a times, it 
happens that the user downloads the subtitles of the movie which he/she wants 
to watch as the movie is not in his/her native language. For eg. if the movie's 
name is abc.avi, the subtitle's file is renamed to abc.en.srt in order to view 
the subtitle along with the movie in media player. The plasma media center is 
unable to show the subtitles when the movie is being played. 



Earlier Full screen Icon was in Media Player but it didn't fit well there so we 
moved it into configuration section in HomeScreen.

Yeah, Video subtitle doesn't work for all possible subtitles file. Right now it 
works only for ffile with filename.srt file. It needs to be improved to work 
with all kinds of subtitle files.


Kindly review the points mentioned above and please give me you

Tokamak6 report

[Sebastian Kügler]

http://dot.kde.org/2013/04/24/plasma-pow-wow-produces-detailed-plans-workspace-convergence


In case you haven't seen it. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 24, 2013, 11:47 a.m.)


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Changes
---

Made Kickoff, locker and Powerdevil runner use fd.o service, and adjusted 
timeengine, ksmserver and krandr for new org.Solid.PowerManagement actions.

@Lukáš, resumedFromSuspend is moved to 
org.kde.Solid.PowerManagement.Actions.SuspendSession so that is why i changed 
it.
I have checked your suggestion for Solid::PowerManagement, but seems everyone 
uses this approach, and most of them ported away from it already, and i see 
Dario already did the same adjustments for dataengine with commit 7a0a21


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs (updated)
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

[Dario Freddi]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31490
---


Ok, so finally we should be near a solution - we've been doing it totally wrong 
for ages, and thanks Hrvoje and Lukas for bringing up the problem.

Long story short: Using DBus interfaces is not a good idea at all as we don't 
guarantee stability for all of them. For actions such as suspend/hibernate, we 
already have a way to do this in KDELibs: 
http://api.kde.org/4.x-api/kdelibs-apidocs/tier1/solid/html/namespaceSolid_1_1PowerManagement.html#a7dfbc8eef79e2c16ccae30df6c487fcc
 . So we should use this instead of DBus.

About resumingFromSuspend, same applies. A signal from 
PowerManagement::Notifier should instead be used: 
http://api.kde.org/4.x-api/kdelibs-apidocs/tier1/solid/html/classSolid_1_1PowerManagement_1_1Notifier.html#aad2c04c80d5dcb707a1f9098bc0262bf

So we should definitely change this all over workspace (and, at the same time, 
make sure all applications do the same).

- Dario Freddi


On April 24, 2013, 11:47 a.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 24, 2013, 11:47 a.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FW: GSOC-2013 Proj- PMC rel. queries

[Shantanu Tushar Jha]

Hi Saurabh,

Nice to see your interest in Plasma Media Center, find my comments inline.
Also, you don't have to use sir/madam etc in your emails, just use people's
names to address them :)

On Wed, Apr 24, 2013 at 3:53 PM, Saurabh Jain wrote:

> Dear sir/mam,
> Please went through the below forwarded mail which is in continuation to
> what Sinny mam had presented her views on my earlier ideas. In my last
> email, I have mentioned 2 more improvements so I request you to please give
> your feedback to me.
> Also, I apologize for not sending my past e-mails to "plasma-devel@kde.org
> ".
>
> Thanks and Regards,
> Saurabh Jain
>
> --
> From: saurabh...@hotmail.com
> To: ksi...@gmail.com
> Subject: RE: GSOC-2013 Proj- PMC rel. queries
> Date: Sat, 20 Apr 2013 15:26:41 +0530
>
>  Thank you.
> All music, All pictures and All Videos are still not working on my system
> even after reinstalling the nepomuk packages. When restarting the
> nepomukindexer, I get the following error in the end-  Error:
> "/var/tmp/kdecache-saurabh" is owned by uid 1001 instead of uid 0. I will
> try to resolve this issue with nepomuk community.
>
> Yes, shuffle mode is working well and mistakenly I pointed it out as
> missing. What I would like to point out is once you have created a
> playlist, you cannot rearrange the existing order of songs to the desired
> one. The only way, which I found, to do so is to create an another playlist
> from the beginning.
>

Yes, manual ordering will be a nice thing to implement.

>
> One more improvement which I would like to mention in *Pictures* section
> is that in presence of *proxy server*, picasa is unable to connect to the
> google account or to load the pictures.
>

PMC should pick up the proxy settings from your proxy settings in Network
Settings in KDE system settings. You should check that.


> Also, pressing the "tab" key after entering the email id in google account
> section does not move the cursor to next section, i.e., password textbox.
> Keyboard does not seem to produce any output in some other situations as
> well.
>

Yep that sounds like a good idea :)

>
>
> Regards,
> Saurabh Jain
>
> --
> Date: Fri, 19 Apr 2013 23:46:37 +0530
>
> Subject: Re: GSOC-2013 Proj- PMC rel. queries
> From: ksi...@gmail.com
> To: saurabh...@hotmail.com
> CC: Plasma-devel@kde.org
>
>
>
> Doing CC to plasma-devel
>
>
> Thanks Saurabh for you effort. Nice start!
>
> On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote:
>
>   Dear mam,
>
> Thanks for replying me back and presenting your views. Yes, you were right
> and I did deviate from the main point as I used the software and liked the
> idea of building such an application and therefore I thought more in
> enhancing and incorporating new features in it.
> I forgot to mention some of the improvements, which I think, can be done
> in this application. The "open with" menu option which I mentioned in my
> first mail also needs to be improved as the user can see this application
> in the above menu but due to lack of functionality provided on the back
> end, the user does not get the desired output response.
>
>
> +1
> I like this idea, this need to be implemented.
>
>
> Improvements in following sections can be:-
> *Music* *:-
> *Search engine (in Songs, Album, etc.) does not seem to work at all. I
> tried searching for a music which is also there in the playlist but did not
> get any results (neither did it respond with search failure nor with song
> found). Improving the song search can have an alternative if sorting
> feature is introduced by virtue of which user can sort the albums, songs
> etc according to their names. Player can be enhanced with modes like
> repeat, shuffle, etc. and reordering of songs in the playlist is also not
> there.
>
>
> Ummm, For me search works fine for Artist, Album and songs works fine but
> yeah, it doesn't display message when search result is zero.
>
> Shuffle works in Playlist. Repeat option can be added.
> Sorting of media is needed on the basis of different field like size,
> date, name, length etc.
>
>
> *Pictures:-
> *Again, clicking on "All Picture" does not produce any results. Every
> time if the user has to view the pictures, he/she has to browse the
> pictures in the folders first and then load it. Further, just like we have
> the option to select some files and play them only, in a similar fashion,
> we can have option to select some pictures and then view them via slide
> show.
>
>
> I guess, your Nepomuk indexer is not running or maybe haven't indexed your
> picture directory. Check with that then All Picture will work fine.
>
> Yeah, we can think of viewing selected pictures in slideshow.
>
>
> *Videos:-
> *The full screen mode toggle button can be added into video section so
> that the user can directly watch the video in full screen mode. Also, many
> a times, it happens that the user downloads the subtitles of the movie
> which he/she wants to watc

Re: Menu branch

[Ignat Semenov]

Hello guys,

The branch has been merged to master with a few more cleanups (namely fixed 
missing or incorrect "What's this" for the newly added items; changed the 
page name to "Icons"; changed the page icon to "preferences-desktop-icons").

Thanks goes to Sho for reviewing the branch and nitpicking on everything, as 
well as general support. :)

Best regards,
Ignat Semenov
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 24, 2013, 5:41 p.m.)


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Changes
---

Changed suspend, hibernate and ResumingfromSuspend actions from using DBus to 
Solid::PowerManagement


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs (updated)
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

[Dario Freddi]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31501
---

Ship it!


Great! Thanks a lot for your efforts. Please push to master after fixing the 
small issue below.


plasma/generic/dataengines/time/timeengine.cpp


Watch out for whitespaces


- Dario Freddi


On April 24, 2013, 5:41 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 24, 2013, 5:41 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31503
---


This review has been submitted with commit 
ad805b504eb3ddec063a3e9060a6d07180232a47 by Hrvoje Senjan to branch master.

- Commit Hook


On April 24, 2013, 5:41 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 24, 2013, 5:41 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 24, 2013, 6:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/
---

Review request for Plasma and Aaron J. Seigo.


Description
---

This patch fixes a crash tracked in KDE bug 318528.

94e1d5c (KDE/4.10) exposed a latent crash in 
Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether 
the publishUi (the widget network sharing ()) has been initialized by checking 
whether publishUI.publishCheckbox is not null, however this is a uic-generated 
pointer, and uic generated classes don't zero-init their member pointers in the 
constructor. Plasma::Applet attempts to cope with this by initializing 
publishUI.publishCheckbox to 0 in showConfigurationInterface(), but this isn't 
run in the containment case, where things move through a signal handled by the 
shell instead. This patch adds a second zero-initialization of publishCheckbox 
in the AppletPrivate constructor to handle this case as well. I've chosen to 
keep the one in showConfigurationInterface() regardless to leave it 
context-free.

I would like to apply this patch to both the KDE/4.10 and master branches.


This addresses bug 318528.
http://bugs.kde.org/show_bug.cgi?id=318528


Diffs
-

  plasma/applet.cpp 9ed62bc 

Diff: http://git.reviewboard.kde.org/r/110158/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 105319: DBus-interface for changing wallpapers

[Varun Herale]

> On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote:
> > Varun, it seems Aaron had some comments, can you have a look at them?

Yes, I am looking at it right now.


- Varun


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review27009
---


On July 1, 2012, 5:56 a.m., Varun Herale wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> ---
> 
> (Updated July 1, 2012, 5:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch is for hosting a dbus-interface that can be used to load any 
> installed wallpaper plugin onto current desktop containment. In case of 
> default "image" plugin, the path to the image can also be sent which will 
> change the wallpaper.  
> 
> 
> Diffs
> -
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> ---
> 
> Tested on different activities and made sure it works for per-virtual desktop 
> containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have 
> access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/
---

(Updated April 24, 2013, 6:21 p.m.)


Review request for Plasma and Aaron J. Seigo.


Changes
---

Fix referenced bug number (previous was a dupe).


Description (updated)
---

This patch fixes a crash tracked in KDE bug 318806.

94e1d5c (KDE/4.10) exposed a latent crash in 
Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether 
the publishUi (the widget network sharing ()) has been initialized by checking 
whether publishUI.publishCheckbox is not null, however this is a uic-generated 
pointer, and uic generated classes don't zero-init their member pointers in the 
constructor. Plasma::Applet attempts to cope with this by initializing 
publishUI.publishCheckbox to 0 in showConfigurationInterface(), but this isn't 
run in the containment case, where things move through a signal handled by the 
shell instead. This patch adds a second zero-initialization of publishCheckbox 
in the AppletPrivate constructor to handle this case as well. I've chosen to 
keep the one in showConfigurationInterface() regardless to leave it 
context-free.

I would like to apply this patch to both the KDE/4.10 and master branches.


This addresses bug 318806.
http://bugs.kde.org/show_bug.cgi?id=318806


Diffs
-

  plasma/applet.cpp 9ed62bc 

Diff: http://git.reviewboard.kde.org/r/110158/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

FW: Plasma-devel Digest, Vol 58, Issue 78

[Saurabh Jain]

; parallel session of media center (* process- based *multitasking ) but
> > the latter one will be expensive and limited (in terms of Inter-process
> > communication as well) and will require an extra memory space which will
> > eventually decrease the CPU performance. Using thread- based multitasking
> > in the code, rather than starting a new process every time in cases
> > mentioned above, a program can run many instants of it at the same time
> > which also share same memory/address space. Further, Interthread
> > communication is also easily done and inexpensive as well. This concept can
> > also be used to compare many pictures simultaneously and then rate it and
> > tag your peers and share it (the feature of "sharing on social networking
> > site") .
> >
> > I have an experience of working with multi- threading in Java as I built
> > quite a few applets in my first year of college. So I think above mentioned
> > features can also be coded in Qt platform.
> > Synchronization feature- I would like to discuss with you on IRC as I am
> > having some queries related to its implementation.
> > I would like to know whether a scripting language like perl etc be used to
> > introduce some more features based upon socket programming in media-
> > center?
> >
> > Regards,
> > Saurabh Jain
> >
> > --
> > From: saurabh...@hotmail.com
> > To: ksi...@gmail.com
> > Subject: GSOC-2013 Proj- PMC rel. queries
> > Date: Wed, 17 Apr 2013 22:53:52 +0530
> >
> >  Dear *mam,
> > I, Saurabh Jain, am a sophomore, B.Tech in Computer Science and
> > Engineering student at IIT Mandi. I would like to participate in this
> > year's google summer of code 2013 and therefore went through the projects
> > listed by KDE organisation. I explored a couple of those projects
> > thoroughly and hence, I would like to share some ideas and ask queries
> > related to this project with title- *Improvements and enhancements for
> > Plasma Media Center. *
> > I recently installed the software on my linux system and found this
> > project idea to be quite an awesome to begin with. The all-in-one
> > integration keeps it apart from other software. Some additional features
> > like implementing a search engine which shows all the results irrespective
> > of whether its a music, picture or video. Using the concept of
> > multi-threading, multiple files of same type can be executed in parallel.
> > Using this feature, if the user wants to compare the two files, in case of
> > pictures, then he/she can do it with ease. Another feature which is
> > synchronizing your files stored on the mobile device can also be added.
> > Sharing of files on the social networking site can also be incorporated in
> > this software which can be done using the concept of socket programming.
> > At present, based upon my experience in using this software, any file like
> > a song etc cannot be directly played with this application by just right
> > clicking on that file and then choosing this application in the "open with"
> > menu option. Adding this feature will make the user to play the file
> > directly rather than first opening the software and then browsing the file
> > in the directory, in case the file is not already present there in the
> > media center.
> >
> > Kindly let me know your opinions on the above mentioned ideas.
> >
> > Regards and Thanks,
> >
> > Saurabh Jain
> > Coordinator, Programming Club
> > B.Tech'15, C.S.E.
> > IIT Mandi
> > Ph: +91-9805377265
> >
> >
> >
> >
> > --
> > http://www.sinny.in
> >
> >
> >
> >
> > --
> > http://www.sinny.in
> >
> > ___
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> >
> Cheers,
> 
> -- 
> Shantanu Tushar(UTC +0530)
> http://www.shantanutushar.com
> -- next part --
> An HTML attachment was scrubbed...
> URL: 
> <http://mail.kde.org/pipermail/plasma-devel/attachments/20130424/6110a455/attachment.html>
> 
> --
> 
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> 
> End of Plasma-devel Digest, Vol 58, Issue 78
> 

  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: FW: GSOC-2013 Proj- PMC rel. queries

[Sinny Kumari]

On Wed, Apr 24, 2013 at 10:41 PM, Shantanu Tushar Jha wrote:

> Hi Saurabh,
>
> Nice to see your interest in Plasma Media Center, find my comments inline.
> Also, you don't have to use sir/madam etc in your emails, just use people's
> names to address them :)
>
>
+1
No sir / madam

On Wed, Apr 24, 2013 at 3:53 PM, Saurabh Jain wrote:
>
>> Dear sir/mam,
>> Please went through the below forwarded mail which is in continuation to
>> what Sinny mam had presented her views on my earlier ideas. In my last
>> email, I have mentioned 2 more improvements so I request you to please give
>> your feedback to me.
>> Also, I apologize for not sending my past e-mails to "
>> plasma-devel@kde.org".
>>
>> Thanks and Regards,
>> Saurabh Jain
>>
>> --
>> From: saurabh...@hotmail.com
>> To: ksi...@gmail.com
>> Subject: RE: GSOC-2013 Proj- PMC rel. queries
>> Date: Sat, 20 Apr 2013 15:26:41 +0530
>>
>>  Thank you.
>> All music, All pictures and All Videos are still not working on my system
>> even after reinstalling the nepomuk packages. When restarting the
>> nepomukindexer, I get the following error in the end-  Error:
>> "/var/tmp/kdecache-saurabh" is owned by uid 1001 instead of uid 0. I will
>> try to resolve this issue with nepomuk community.
>>
>> Yes, shuffle mode is working well and mistakenly I pointed it out as
>> missing. What I would like to point out is once you have created a
>> playlist, you cannot rearrange the existing order of songs to the desired
>> one. The only way, which I found, to do so is to create an another playlist
>> from the beginning.
>>
>
> Yes, manual ordering will be a nice thing to implement.
>

Right now, playlist has very limited functionality. So, yes lot of scope of
improvement here.


>
>> One more improvement which I would like to mention in *Pictures* section
>> is that in presence of *proxy server*, picasa is unable to connect to
>> the google account or to load the pictures.
>>
>
> PMC should pick up the proxy settings from your proxy settings in Network
> Settings in KDE system settings. You should check that.
>
>
>> Also, pressing the "tab" key after entering the email id in google
>> account section does not move the cursor to next section, i.e., password
>> textbox. Keyboard does not seem to produce any output in some other
>> situations as well.
>>
>
> Yep that sounds like a good idea :)
>

True, this need to be done. Other than that, keyboard navigation doesn't
work at many other places in PMC. All of them needs to be fixed.


>
>>
>> Regards,
>> Saurabh Jain
>>
>> --
>> Date: Fri, 19 Apr 2013 23:46:37 +0530
>>
>> Subject: Re: GSOC-2013 Proj- PMC rel. queries
>> From: ksi...@gmail.com
>> To: saurabh...@hotmail.com
>> CC: Plasma-devel@kde.org
>>
>>
>>
>> Doing CC to plasma-devel
>>
>>
>> Thanks Saurabh for you effort. Nice start!
>>
>> On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote:
>>
>>   Dear mam,
>>
>> Thanks for replying me back and presenting your views. Yes, you were
>> right and I did deviate from the main point as I used the software and
>> liked the idea of building such an application and therefore I thought more
>> in enhancing and incorporating new features in it.
>> I forgot to mention some of the improvements, which I think, can be done
>> in this application. The "open with" menu option which I mentioned in my
>> first mail also needs to be improved as the user can see this application
>> in the above menu but due to lack of functionality provided on the back
>> end, the user does not get the desired output response.
>>
>>
>> +1
>> I like this idea, this need to be implemented.
>>
>>
>> Improvements in following sections can be:-
>> *Music* *:-
>> *Search engine (in Songs, Album, etc.) does not seem to work at all. I
>> tried searching for a music which is also there in the playlist but did not
>> get any results (neither did it respond with search failure nor with song
>> found). Improving the song search can have an alternative if sorting
>> feature is introduced by virtue of which user can sort the albums, songs
>> etc according to their names. Player can be enhanced with modes like
>> repeat, shuffle, etc. and reordering of songs in the playlist is also not
>> there.
>>
>>
>> Ummm, For me search works fine for Artist, Album and songs works fine but
>> yeah, it doesn't display message when search result is zero.
>>
>> Shuffle works in Playlist. Repeat option can be added.
>> Sorting of media is needed on the basis of different field like size,
>> date, name, length etc.
>>
>>
>> *Pictures:-
>> *Again, clicking on "All Picture" does not produce any results. Every
>> time if the user has to view the pictures, he/she has to browse the
>> pictures in the folders first and then load it. Further, just like we have
>> the option to select some files and play them only, in a similar fashion,
>> we can have option to select some pictures and then view them via slide
>> show.
>>
>>
>> I guess, your Nepomuk in

Re: GSOC- 2013 Proj.- PMC ideas

[Saurabh Jain]

; parallel session of media center (* process- based *multitasking ) but
> > the latter one will be expensive and limited (in terms of Inter-process
> > communication as well) and will require an extra memory space which will
> > eventually decrease the CPU performance. Using thread- based multitasking
> > in the code, rather than starting a new process every time in cases
> > mentioned above, a program can run many instants of it at the same time
> > which also share same memory/address space. Further, Interthread
> > communication is also easily done and inexpensive as well. This concept can
> > also be used to compare many pictures simultaneously and then rate it and
> > tag your peers and share it (the feature of "sharing on social networking
> > site") .
> >
> > I have an experience of working with multi- threading in Java as I built
> > quite a few applets in my first year of college. So I think above mentioned
> > features can also be coded in Qt platform.
> > Synchronization feature- I would like to discuss with you on IRC as I am
> > having some queries related to its implementation.
> > I would like to know whether a scripting language like perl etc be used to
> > introduce some more features based upon socket programming in media-
> > center?
> >
> > Regards,
> > Saurabh Jain
> >
> > --
> > From: saurabh...@hotmail.com
> > To: ksi...@gmail.com
> > Subject: GSOC-2013 Proj- PMC rel. queries
> > Date: Wed, 17 Apr 2013 22:53:52 +0530
> >
> >  Dear *mam,
> > I, Saurabh Jain, am a sophomore, B.Tech in Computer Science and
> > Engineering student at IIT Mandi. I would like to participate in this
> > year's google summer of code 2013 and therefore went through the projects
> > listed by KDE organisation. I explored a couple of those projects
> > thoroughly and hence, I would like to share some ideas and ask queries
> > related to this project with title- *Improvements and enhancements for
> > Plasma Media Center. *
> > I recently installed the software on my linux system and found this
> > project idea to be quite an awesome to begin with. The all-in-one
> > integration keeps it apart from other software. Some additional features
> > like implementing a search engine which shows all the results irrespective
> > of whether its a music, picture or video. Using the concept of
> > multi-threading, multiple files of same type can be executed in parallel.
> > Using this feature, if the user wants to compare the two files, in case of
> > pictures, then he/she can do it with ease. Another feature which is
> > synchronizing your files stored on the mobile device can also be added.
> > Sharing of files on the social networking site can also be incorporated in
> > this software which can be done using the concept of socket programming.
> > At present, based upon my experience in using this software, any file like
> > a song etc cannot be directly played with this application by just right
> > clicking on that file and then choosing this application in the "open with"
> > menu option. Adding this feature will make the user to play the file
> > directly rather than first opening the software and then browsing the file
> > in the directory, in case the file is not already present there in the
> > media center.
> >
> > Kindly let me know your opinions on the above mentioned ideas.
> >
> > Regards and Thanks,
> >
> > Saurabh Jain
> > Coordinator, Programming Club
> > B.Tech'15, C.S.E.
> > IIT Mandi
> > Ph: +91-9805377265
> >
> >
> >
> >
> > --
> > http://www.sinny.in
> >
> >
> >
> >
> > --
> > http://www.sinny.in
> >
> > ___
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> >
> Cheers,
> 
> -- 
> Shantanu Tushar(UTC +0530)
> http://www.shantanutushar.com
> -- next part --
> An HTML attachment was scrubbed...
> URL: 
> <http://mail.kde.org/pipermail/plasma-devel/attachments/20130424/6110a455/attachment.html>
> 
> --
> 
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> 
> End of Plasma-devel Digest, Vol 58, Issue 78
> 

  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/#review31507
---

Ship it!


Ship It!

- Marco Martin


On April 24, 2013, 6:21 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110158/
> ---
> 
> (Updated April 24, 2013, 6:21 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> ---
> 
> This patch fixes a crash tracked in KDE bug 318806.
> 
> 94e1d5c (KDE/4.10) exposed a latent crash in 
> Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether 
> the publishUi (the widget network sharing ()) has been initialized by 
> checking whether publishUI.publishCheckbox is not null, however this is a 
> uic-generated pointer, and uic generated classes don't zero-init their member 
> pointers in the constructor. Plasma::Applet attempts to cope with this by 
> initializing publishUI.publishCheckbox to 0 in showConfigurationInterface(), 
> but this isn't run in the containment case, where things move through a 
> signal handled by the shell instead. This patch adds a second 
> zero-initialization of publishCheckbox in the AppletPrivate constructor to 
> handle this case as well. I've chosen to keep the one in 
> showConfigurationInterface() regardless to leave it context-free.
> 
> I would like to apply this patch to both the KDE/4.10 and master branches.
> 
> 
> This addresses bug 318806.
> http://bugs.kde.org/show_bug.cgi?id=318806
> 
> 
> Diffs
> -
> 
>   plasma/applet.cpp 9ed62bc 
> 
> Diff: http://git.reviewboard.kde.org/r/110158/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110160: Switch to Solid::PowerManagement instead of using DBus interface

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110160/
---

Review request for Plasma and Ivan Čukić.


Description
---

Patch for lancelot-datamodels.
Follow up to review 110135, and to resolve problem introduced with 
kde-workspace commit 63e9e0. Interface changed, and as pointed in mentioned 
review, this should provide more stability over time.
(Same review done for homerun, from where is also description c/p)


Diffs
-

  libs/lancelot-datamodels/SystemActions.cpp 7b9df63 

Diff: http://git.reviewboard.kde.org/r/110160/diff/


Testing
---

Compiled, works.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
---

Ship it!


Ship It!

- Marco Martin


On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> ---
> 
> (Updated Dec. 25, 2012, 2:43 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> ---
> 
> This patch disables the setCustomNotification while a button (close, next, 
> back) is pressed, to prevent popup re-shifting which seems to eat the clicked 
> event.
> Problem is more deep in Plasma but has been around since Plasma exists, so 
> this should fix it for the notifications.
> 
> 
> This addresses bug 311413.
> http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 
> e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
> 
> 
> Testing
> ---
> 
> kdialog --passivepopup "bla"
> click, closes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Eike Hein]

> On April 24, 2013, 6:41 p.m., Marco Martin wrote:
> > Ship It!

Thanks, got a fix confirmation from Rex Dieter as well, so I'll push.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/#review31507
---


On April 24, 2013, 6:21 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110158/
> ---
> 
> (Updated April 24, 2013, 6:21 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> ---
> 
> This patch fixes a crash tracked in KDE bug 318806.
> 
> 94e1d5c (KDE/4.10) exposed a latent crash in 
> Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether 
> the publishUi (the widget network sharing ()) has been initialized by 
> checking whether publishUI.publishCheckbox is not null, however this is a 
> uic-generated pointer, and uic generated classes don't zero-init their member 
> pointers in the constructor. Plasma::Applet attempts to cope with this by 
> initializing publishUI.publishCheckbox to 0 in showConfigurationInterface(), 
> but this isn't run in the containment case, where things move through a 
> signal handled by the shell instead. This patch adds a second 
> zero-initialization of publishCheckbox in the AppletPrivate constructor to 
> handle this case as well. I've chosen to keep the one in 
> showConfigurationInterface() regardless to leave it context-free.
> 
> I would like to apply this patch to both the KDE/4.10 and master branches.
> 
> 
> This addresses bug 318806.
> http://bugs.kde.org/show_bug.cgi?id=318806
> 
> 
> Diffs
> -
> 
>   plasma/applet.cpp 9ed62bc 
> 
> Diff: http://git.reviewboard.kde.org/r/110158/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/#review31515
---


This review has been submitted with commit 
1babeb4689f6b3fa990250571448eb840048d598 by Eike Hein to branch KDE/4.10.

- Commit Hook


On April 24, 2013, 6:21 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110158/
> ---
> 
> (Updated April 24, 2013, 6:21 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> ---
> 
> This patch fixes a crash tracked in KDE bug 318806.
> 
> 94e1d5c (KDE/4.10) exposed a latent crash in 
> Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether 
> the publishUi (the widget network sharing ()) has been initialized by 
> checking whether publishUI.publishCheckbox is not null, however this is a 
> uic-generated pointer, and uic generated classes don't zero-init their member 
> pointers in the constructor. Plasma::Applet attempts to cope with this by 
> initializing publishUI.publishCheckbox to 0 in showConfigurationInterface(), 
> but this isn't run in the containment case, where things move through a 
> signal handled by the shell instead. This patch adds a second 
> zero-initialization of publishCheckbox in the AppletPrivate constructor to 
> handle this case as well. I've chosen to keep the one in 
> showConfigurationInterface() regardless to leave it context-free.
> 
> I would like to apply this patch to both the KDE/4.10 and master branches.
> 
> 
> This addresses bug 318806.
> http://bugs.kde.org/show_bug.cgi?id=318806
> 
> 
> Diffs
> -
> 
>   plasma/applet.cpp 9ed62bc 
> 
> Diff: http://git.reviewboard.kde.org/r/110158/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/
---

(Updated April 24, 2013, 8:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Aaron J. Seigo.


Description
---

This patch fixes a crash tracked in KDE bug 318806.

94e1d5c (KDE/4.10) exposed a latent crash in 
Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether 
the publishUi (the widget network sharing ()) has been initialized by checking 
whether publishUI.publishCheckbox is not null, however this is a uic-generated 
pointer, and uic generated classes don't zero-init their member pointers in the 
constructor. Plasma::Applet attempts to cope with this by initializing 
publishUI.publishCheckbox to 0 in showConfigurationInterface(), but this isn't 
run in the containment case, where things move through a signal handled by the 
shell instead. This patch adds a second zero-initialization of publishCheckbox 
in the AppletPrivate constructor to handle this case as well. I've chosen to 
keep the one in showConfigurationInterface() regardless to leave it 
context-free.

I would like to apply this patch to both the KDE/4.10 and master branches.


This addresses bug 318806.
http://bugs.kde.org/show_bug.cgi?id=318806


Diffs
-

  plasma/applet.cpp 9ed62bc 

Diff: http://git.reviewboard.kde.org/r/110158/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-framework] /: Make installPackage cmake macro useful for other package types

[Sebastian Kügler]

Git commit b679eb6dabea787f4e73097cb340c35b9862bfc2 by Sebastian Kügler.
Committed on 25/04/2013 at 02:08.
Pushed by sebas into branch 'master'.

Make installPackage cmake macro useful for other package types

Make it possible to install any type into any path prefix. We just add
an optional argument to also specify the type, so from now on installed
service files will not all be plasma-applet-.desktop, but
for example plasma-wallpaper-.desktop.

CCMAIL:plasma-devel@kde.org

M  +6-2CMakeLists.txt

http://commits.kde.org/plasma-framework/b679eb6dabea787f4e73097cb340c35b9862bfc2

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 671aedf..ca26a0f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -146,12 +146,16 @@ configure_file(config-compiler.h.cmake 
${CMAKE_CURRENT_BINARY_DIR}/config-compil
 
 
 macro(installPackage dir component)
-   set(root ${ARGN})
+   set(root ${ARGV2})
+   set(type ${ARGV3})
if(NOT root)
   set(root plasma/plasmoids)
endif()
+   if(NOT type)
+  set(type applet)
+   endif()
install(DIRECTORY ${dir}/ DESTINATION 
${DATA_INSTALL_DIR}/${root}/${component} PATTERN Messages.sh EXCLUDE)
-   install(FILES ${dir}/metadata.desktop DESTINATION ${SERVICES_INSTALL_DIR} 
RENAME plasma-applet-${component}.desktop)
+   install(FILES ${dir}/metadata.desktop DESTINATION ${SERVICES_INSTALL_DIR} 
RENAME plasma-${type}-${component}.desktop)
 endmacro()
 
 # list the subdirectories #

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel