FW: GSOC-2013 Proj- PMC rel. queries
Dear sir/mam,Please went through the below forwarded mail which is in continuation to what Sinny mam had presented her views on my earlier ideas. In my last email, I have mentioned 2 more improvements so I request you to please give your feedback to me. Also, I apologize for not sending my past e-mails to plasma-devel.org. Thanks and Regards,Saurabh Jain From: saurabh...@hotmail.com To: ksi...@gmail.com Subject: RE: GSOC-2013 Proj- PMC rel. queries Date: Sat, 20 Apr 2013 15:26:41 +0530 Thank you. All music, All pictures and All Videos are still not working on my system even after reinstalling the nepomuk packages. When restarting the nepomukindexer, I get the following error in the end- Error: /var/tmp/kdecache-saurabh is owned by uid 1001 instead of uid 0. I will try to resolve this issue with nepomuk community. Yes, shuffle mode is working well and mistakenly I pointed it out as missing. What I would like to point out is once you have created a playlist, you cannot rearrange the existing order of songs to the desired one. The only way, which I found, to do so is to create an another playlist from the beginning. One more improvement which I would like to mention in Pictures section is that in presence of proxy server, picasa is unable to connect to the google account or to load the pictures. Also, pressing the tab key after entering the email id in google account section does not move the cursor to next section, i.e., password textbox. Keyboard does not seem to produce any output in some other situations as well. Regards, Saurabh Jain Date: Fri, 19 Apr 2013 23:46:37 +0530 Subject: Re: GSOC-2013 Proj- PMC rel. queries From: ksi...@gmail.com To: saurabh...@hotmail.com CC: Plasma-devel@kde.org Doing CC to plasma-devel Thanks Saurabh for you effort. Nice start! On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain saurabh...@hotmail.com wrote: Dear mam, Thanks for replying me back and presenting your views. Yes, you were right and I did deviate from the main point as I used the software and liked the idea of building such an application and therefore I thought more in enhancing and incorporating new features in it. I forgot to mention some of the improvements, which I think, can be done in this application. The open with menu option which I mentioned in my first mail also needs to be improved as the user can see this application in the above menu but due to lack of functionality provided on the back end, the user does not get the desired output response. +1 I like this idea, this need to be implemented. Improvements in following sections can be:- Music :- Search engine (in Songs, Album, etc.) does not seem to work at all. I tried searching for a music which is also there in the playlist but did not get any results (neither did it respond with search failure nor with song found). Improving the song search can have an alternative if sorting feature is introduced by virtue of which user can sort the albums, songs etc according to their names. Player can be enhanced with modes like repeat, shuffle, etc. and reordering of songs in the playlist is also not there. Ummm, For me search works fine for Artist, Album and songs works fine but yeah, it doesn't display message when search result is zero. Shuffle works in Playlist. Repeat option can be added. Sorting of media is needed on the basis of different field like size, date, name, length etc. Pictures:- Again, clicking on All Picture does not produce any results. Every time if the user has to view the pictures, he/she has to browse the pictures in the folders first and then load it. Further, just like we have the option to select some files and play them only, in a similar fashion, we can have option to select some pictures and then view them via slide show. I guess, your Nepomuk indexer is not running or maybe haven't indexed your picture directory. Check with that then All Picture will work fine. Yeah, we can think of viewing selected pictures in slideshow. Videos:- The full screen mode toggle button can be added into video section so that the user can directly watch the video in full screen mode. Also, many a times, it happens that the user downloads the subtitles of the movie which he/she wants to watch as the movie is not in his/her native language. For eg. if the movie's name is abc.avi, the subtitle's file is renamed to abc.en.srt in order to view the subtitle along with the movie in media player. The plasma media center is unable to show the subtitles when the movie is being played. Earlier Full screen Icon was in Media Player but it didn't fit well there so we moved it into configuration section in HomeScreen. Yeah, Video subtitle doesn't work for all possible subtitles file. Right now it works only for ffile with filename.srt file. It needs to be improved to work with all kinds of subtitle files. Kindly review the points mentioned above and please
Re: Review Request 110176: Change the visual appearance of the composited outline
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31539 --- Ship it! seems a nice idea. since the shadow for that item is huge, does take it into account when it resizes the frame? )you would want the frame border, not the shadow more or less aligned with the window size) - Marco Martin On April 25, 2013, 8:58 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/ --- (Updated April 25, 2013, 8:58 a.m.) Review request for kwin and Plasma. Description --- Change the visual appearance of the composited outline Uses widgets/translucentbackground as FrameSvg item to ensure that we don't get a huge black square on the screen. When bordering a screen edge we disable the border except if all edges are bordered. This makes a little bit more clear in the quick tiling case what will be the geometry. Blur behind the outline does not work as: * moving the window generates artefacts * moved window needs to be above the outline, but outline needs to be on top of everything. Elevating the moved window results in strange side effects when moving the window below a keep above, etc. Diffs - kwin/outline.cpp ad3cfc01f6fa29010de6845d6c17a54e59d9474e Diff: http://git.reviewboard.kde.org/r/110176/diff/ Testing --- I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110176: Change the visual appearance of the composited outline
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31550 --- It's a definitively visual improvement with many themes (including and esp. air), but eg. (old) oxygen and several others still get me a black overlay that does not much look like a frame or window and with opaquity it's (surprise) *opaque* (ie. one side of the screen turns -near- black) http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails /translucentbackground.svg: a standard background image for plasmoids that for their nature are bigger and with not much text. In this case a translucent background looks better. It needs the same elements of background.svg in it. If this file is not present, the plasmoids that uses this will use background.svg instead. There's (unfortunately) no explicit requirement on that either this is translucent or exists at all (what will get us the regular solid background) For the beginning, i'd strongly recommend to elevate the to-be-tiled window over the outline. - Thomas Lübking On April 25, 2013, 8:58 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/ --- (Updated April 25, 2013, 8:58 a.m.) Review request for kwin and Plasma. Description --- Change the visual appearance of the composited outline Uses widgets/translucentbackground as FrameSvg item to ensure that we don't get a huge black square on the screen. When bordering a screen edge we disable the border except if all edges are bordered. This makes a little bit more clear in the quick tiling case what will be the geometry. Blur behind the outline does not work as: * moving the window generates artefacts * moved window needs to be above the outline, but outline needs to be on top of everything. Elevating the moved window results in strange side effects when moving the window below a keep above, etc. Diffs - kwin/outline.cpp ad3cfc01f6fa29010de6845d6c17a54e59d9474e Diff: http://git.reviewboard.kde.org/r/110176/diff/ Testing --- I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110176: Change the visual appearance of the composited outline
On April 25, 2013, 2:29 p.m., Thomas Lübking wrote: It's a definitively visual improvement with many themes (including and esp. air), but eg. (old) oxygen and several others still get me a black overlay that does not much look like a frame or window and with opaquity it's (surprise) *opaque* (ie. one side of the screen turns -near- black) http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails /translucentbackground.svg: a standard background image for plasmoids that for their nature are bigger and with not much text. In this case a translucent background looks better. It needs the same elements of background.svg in it. If this file is not present, the plasmoids that uses this will use background.svg instead. There's (unfortunately) no explicit requirement on that either this is translucent or exists at all (what will get us the regular solid background) For the beginning, i'd strongly recommend to elevate the to-be-tiled window over the outline. @Plasma devs: could you please clarify whether there is a theme element which is guaranteed to be translucent? I'll update the patch with the elevating code. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31550 --- On April 25, 2013, 10:58 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/ --- (Updated April 25, 2013, 10:58 a.m.) Review request for kwin and Plasma. Description --- Change the visual appearance of the composited outline Uses widgets/translucentbackground as FrameSvg item to ensure that we don't get a huge black square on the screen. When bordering a screen edge we disable the border except if all edges are bordered. This makes a little bit more clear in the quick tiling case what will be the geometry. Blur behind the outline does not work as: * moving the window generates artefacts * moved window needs to be above the outline, but outline needs to be on top of everything. Elevating the moved window results in strange side effects when moving the window below a keep above, etc. Diffs - kwin/outline.cpp ad3cfc01f6fa29010de6845d6c17a54e59d9474e Diff: http://git.reviewboard.kde.org/r/110176/diff/ Testing --- I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109965: Refactor assetimporters
On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, line 326 http://git.reviewboard.kde.org/r/109965/diff/1/?file=138225#file138225line326 this is more partnerId than partnerQuery? Giorgos Tsiapaliokas wrote: yes you can call it a partnerId, but I didn't. Because partnerQuery is a virtual method of databasecommon and I wanted to emphasize the fact that *this* partner has changed. So I believe we should leave the method as partnerQuery or to rename all of them into partnerId. We have to emphasize the change in the value(if it changes at all), no? What is important is not the implementation of the method, but what it takes and what it returns. This method takes nothing (languageQuery below takes a language by name) and it returns the id of the partner (languageQuery returns the id of the language). It's usually better to name the method after what the method signature says rather than the implementation. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/#review30976 --- On April 20, 2013, 10:52 a.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated April 20, 2013, 10:52 a.m.) Review request for Plasma. Description --- This patch * removes the duplicated code in assetimporters * adds asset's size into the db * and fixes a few small issues Diffs - assetimporters/CMakeLists.txt 24e76a0 assetimporters/database-common/channelscatalog.h 5d39c02 assetimporters/database-common/channelscatalog.cpp 6ca0aef assetimporters/database-common/database.h 9883216 assetimporters/database-common/database.cpp e860bdd assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9 assetimporters/kdeartwork-wallpapers/database.h 6991758 assetimporters/kdeartwork-wallpapers/database.cpp d75cdda assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION assetimporters/kdeartwork-wallpapers/main.cpp 708a949 assetimporters/obs/CMakeLists.txt 2dbcd42 assetimporters/obs/channelscatalog.h PRE-CREATION assetimporters/obs/channelscatalog.cpp PRE-CREATION assetimporters/obs/packagedatabase.h 99f4e17 assetimporters/obs/packagedatabase.cpp ae43b8e assetimporters/projectgutenberg/CMakeLists.txt b86cc49 assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c assetimporters/projectgutenberg/src/database.h 8dba0ba assetimporters/projectgutenberg/src/database.cpp 75cba69 assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION assetimporters/projectgutenberg/src/main.cpp 46f2340 sql/bodega.sql 44f8641 Diff: http://git.reviewboard.kde.org/r/109965/diff/ Testing --- I haven't noticed regression. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- sorry for the late reply; the people who could review this one were off in the last week at a dev sprint and reviews tend to get neglected when that happens. but better late than never, right? ;) looks pretty good, a few minor issues below, and Marco Martin should also have a glance through it. plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml http://git.reviewboard.kde.org/r/110122/#comment23501 no minimum is set here as there was in the prior code. there should probably be some sensible minimum applied. plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml http://git.reviewboard.kde.org/r/110122/#comment23502 this tends to lead to accidental timers running when the code changes later (QML makes it a little too easy to accomplish that at times ;) would prefer that this stays as a single shot and is restarted as needed. - Aaron J. Seigo On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110176: Change the visual appearance of the composited outline
On April 25, 2013, 12:29 p.m., Thomas Lübking wrote: It's a definitively visual improvement with many themes (including and esp. air), but eg. (old) oxygen and several others still get me a black overlay that does not much look like a frame or window and with opaquity it's (surprise) *opaque* (ie. one side of the screen turns -near- black) http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails /translucentbackground.svg: a standard background image for plasmoids that for their nature are bigger and with not much text. In this case a translucent background looks better. It needs the same elements of background.svg in it. If this file is not present, the plasmoids that uses this will use background.svg instead. There's (unfortunately) no explicit requirement on that either this is translucent or exists at all (what will get us the regular solid background) For the beginning, i'd strongly recommend to elevate the to-be-tiled window over the outline. Martin Gräßlin wrote: @Plasma devs: could you please clarify whether there is a theme element which is guaranteed to be translucent? I'll update the patch with the elevating code. no such guarantees, i'm afraid, as the themer can in theory screw you over by doing whatever they want but then that's their fault. there is a translucent/ directory and in there are backgrounds that are supposed to be, well, translucent. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31550 --- On April 25, 2013, 8:58 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/ --- (Updated April 25, 2013, 8:58 a.m.) Review request for kwin and Plasma. Description --- Change the visual appearance of the composited outline Uses widgets/translucentbackground as FrameSvg item to ensure that we don't get a huge black square on the screen. When bordering a screen edge we disable the border except if all edges are bordered. This makes a little bit more clear in the quick tiling case what will be the geometry. Blur behind the outline does not work as: * moving the window generates artefacts * moved window needs to be above the outline, but outline needs to be on top of everything. Elevating the moved window results in strange side effects when moving the window below a keep above, etc. Diffs - kwin/outline.cpp ad3cfc01f6fa29010de6845d6c17a54e59d9474e Diff: http://git.reviewboard.kde.org/r/110176/diff/ Testing --- I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, line 52 http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line52 no minimum is set here as there was in the prior code. there should probably be some sensible minimum applied. The minimum is set on line 45. - James --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, line 188 http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line188 this tends to lead to accidental timers running when the code changes later (QML makes it a little too easy to accomplish that at times ;) would prefer that this stays as a single shot and is restarted as needed. Yes I totally agree with you, unfortunately due to a limitation of the timer class, when used from QML, this is not possible (you can't re-arm the timer from inside of a timer callback). - James --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, line 52 http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line52 no minimum is set here as there was in the prior code. there should probably be some sensible minimum applied. James Pike wrote: The minimum is set on line 45. I did however remove the 60 second maximum as I believe this is too low, many people in my office have expressed a desire for higher notification timeouts. I mark notifications from my boss with a timeout of several thousand seconds to ensure I never miss them. Else he'll get angry. - James --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, line 188 http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line188 this tends to lead to accidental timers running when the code changes later (QML makes it a little too easy to accomplish that at times ;) would prefer that this stays as a single shot and is restarted as needed. James Pike wrote: Yes I totally agree with you, unfortunately due to a limitation of the timer class, when used from QML, this is not possible (you can't re-arm the timer from inside of a timer callback). I actually implemented it as you would have preferred in my first shot, this lead me to discover the timer limitation. I had to re-implement it to use repeat in this way later. - James --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, line 52 http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line52 no minimum is set here as there was in the prior code. there should probably be some sensible minimum applied. James Pike wrote: The minimum is set on line 45. James Pike wrote: I did however remove the 60 second maximum as I believe this is too low, many people in my office have expressed a desire for higher notification timeouts. I mark notifications from my boss with a timeout of several thousand seconds to ensure I never miss them. Else he'll get angry. Please feel free to re-instate the 60 second maximum though, it just means I'll never be able to use KDE and have a non-angry boss at the same time :P - James --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
On April 25, 2013, 2:02 p.m., Aaron J. Seigo wrote: sorry for the late reply; the people who could review this one were off in the last week at a dev sprint and reviews tend to get neglected when that happens. but better late than never, right? ;) looks pretty good, a few minor issues below, and Marco Martin should also have a glance through it. By any other project's standards, this isn't a late reply. This is why I love contributing to KDE so much, you guys are always so respectful, polite and attentive; a real inspiration for the entire OSS community. - James --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/#review31563 --- On April 25, 2013, 1:58 p.m., James Pike wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110122/ --- (Updated April 25, 2013, 1:58 p.m.) Review request for Plasma. Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. This addresses bug 318295. http://bugs.kde.org/show_bug.cgi?id=318295 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: http://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Removing noKephal branch
Hey there Long time ago I pushed a branch called noKephal to kde-workspace with the intention of removing the internal library and replace it with QDesktopWidget (which kephal uses underneath). At this point, it makes little sense to continue with the work since for Qt5 we want to use QScreen, and I guess that lot will change in the unified shell+plasma-framework. Additionally modifying this delicate code in the release where we'll change focus to Qt5 does not make much sense. I thought on leaving it there just as a reference but I'm unsure how useful it will be. So, any argument against removing the branch? Cheers. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Removing noKephal branch
On Thursday, April 25, 2013 16:31:54 Àlex Fiestas wrote: So, any argument against removing the branch? none here ... but is there any reason to not merge it? e.g. is it incomplete, or just untested? if untested, we have plenty of time between now and 4.11 to make sure it is tested, and then it is a simple matter of search and replacing QDesktopWidget usage going into Qt5 and kephal will already be dropped, which needs doing. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
