Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-25 Thread Aaron J. Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/#review36500
---


the QVariantList args is s ugly imho; wish there was a better way of doing 
this. in any case .. small comment below


src/plasma/dataengine.h


are the args also needed on this one?


- Aaron J. Seigo


On July 25, 2013, 4:03 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111691/
> ---
> 
> (Updated July 25, 2013, 4:03 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> ---
> 
> This adds back a ctor that is useful for creating a KPluginFactory, which has 
> the metadata baked into the plugin. With corresponding patches to kdelibs, 
> this allows to create a dataengine, with valid KPluginInfo from a Qt plugin 
> (i.e. without using KService)
> 
> 
> Diffs
> -
> 
>   src/plasma/dataengine.h d3baad3 
>   src/plasma/dataengine.cpp a2c68cb 
>   src/plasma/private/dataengine_p.h d8ade83 
> 
> Diff: http://git.reviewboard.kde.org/r/111691/diff/
> 
> 
> Testing
> ---
> 
> Build and loaded plugin, verified metadata is completely inside KPluginInfo
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111691: Add KPluginFactory compatible ctor to dataengine

2013-07-25 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/
---

Review request for Plasma and Aaron J. Seigo.


Description
---

This adds back a ctor that is useful for creating a KPluginFactory, which has 
the metadata baked into the plugin. With corresponding patches to kdelibs, this 
allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. 
without using KService)


Diffs
-

  src/plasma/dataengine.h d3baad3 
  src/plasma/dataengine.cpp a2c68cb 
  src/plasma/private/dataengine_p.h d8ade83 

Diff: http://git.reviewboard.kde.org/r/111691/diff/


Testing
---

Build and loaded plugin, verified metadata is completely inside KPluginInfo


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma components outside of a plasma package / GSoC

2013-07-25 Thread Sebastian Kügler 
On Thursday, July 25, 2013 16:02:53 Michael Bohlender wrote:
> On Thu, Jul 25, 2013 at 4:00 PM, Michael Bohlender 
 wrote:
> > I am using plasma components outside of a plasma package in kmail-mobile
> > and some components don't get displayed / themed correctly.
> > 
> > # PageRow: bordershadows not visible
> > 
> > "
> > file:///opt/kde4/lib/kde4/imports/org/kde/plasma/extras/PageRow.qml:316:13
> > :
> > QML QDeclarativeImage_QML_25: Failed to get image from provider:
> > image://appbackgrounds/shadow-right "
> 
> Try importing org.kde.plasma.extras in that file, this will make the
> image://backgrounds url work.
> 
> I imported  org.kde.plasma.extras as PlasmaExtras  already (to get
> PlasmaExtras.PageRow) 
> 
> > # ListItem: not 3D is like I expected them to be with the air-mobile theme
> 
> Have you verified it works? If it is fine in other themes, don't worry about
> it.
> 
> What I wanted to say is the ListItem looks like it is not styled at all but
> that was because of my bad monitor from a different viewing angle it looks
> like it is transparent-white. always. so I assume it does not pick up the
> theme that was set on the desktop so I need to set the theme manually when
> starting the app? How can I do that ? Could you point me to an example app
> that is using plasma components but not a plasma package?

The theme has nothing to do with wether you're using a package or not.

Try with the oxygen theme in order to verify that a list item svg is actually 
used. If it is, you're fine. (Which means: if you're not fine, you'll have to 
change the theme, but usually you shouldn't.)

> What are the advantages of having the app  UI in a plasma package other then
> a clean and well structured project folder?

This way, other apps can use it easily.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma components outside of a plasma package / GSoC

2013-07-25 Thread Michael Bohlender 
On Thu, Jul 25, 2013 at 4:00 PM, Michael Bohlender <
michael.bohlen...@gmail.com> wrote:

>
> > I am using plasma components outside of a plasma package in kmail-mobile
>> and
>> > some components don't get displayed / themed correctly.
>> >
>> > # PageRow: bordershadows not visible
>> >
>> > "
>> >
>> file:///opt/kde4/lib/kde4/imports/org/kde/plasma/extras/PageRow.qml:316:13:
>> > QML QDeclarativeImage_QML_25: Failed to get image from provider:
>> > image://appbackgrounds/shadow-right "
>>
>> Try importing org.kde.plasma.extras in that file, this will make the
>> image://backgrounds url work.
>>
>
> I imported  org.kde.plasma.extras as PlasmaExtras  already (to get
> PlasmaExtras.PageRow)
>
>
>> > # ListItem: not 3D is like I expected them to be with the air-mobile
>> theme
>>
>> Have you verified it works? If it is fine in other themes, don't worry
>> about
>> it.
>
>
> What I wanted to say is the ListItem looks like it is not styled at all
> but that was because of my bad monitor from a different viewing angle it
> looks like it is transparent-white. always. so I assume it does not pick up
> the theme that was set on the desktop so I need to set the theme manually
> when starting the app? How can I do that ? Could you point me to an example
> app that is using plasma components but not a plasma package?
>
> What are the advantages of having the app  UI in a plasma package other
> then a clean and well structured project folder?
>
> Cheers
>
> Mike
>
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma components outside of a plasma package / GSoC

2013-07-25 Thread Sebastian Kügler 
Hi Michael,

On Thursday, July 25, 2013 14:22:09 Michael Bohlender wrote:
> I am using plasma components outside of a plasma package in kmail-mobile and
> some components don't get displayed / themed correctly. 
> 
> # PageRow: bordershadows not visible 
>  
> "
> file:///opt/kde4/lib/kde4/imports/org/kde/plasma/extras/PageRow.qml:316:13:
> QML QDeclarativeImage_QML_25: Failed to get image from provider:
> image://appbackgrounds/shadow-right "

Try importing org.kde.plasma.extras in that file, this will make the 
image://backgrounds url work.

> # ListItem: not 3D is like I expected them to be with the air-mobile theme

Have you verified it works? If it is fine in other themes, don't worry about 
it.

> # Buttons; TextField; ScrollArea and Checkbox seem to look fine.
> 
> So my question is: How can I enable the correct theme and how can I
> get/enable the background provider ? Do I need to make  the UI a plasma
> package?

That's not necessary.

> I asked twice on IRC before and didn't get a response so I am wondering if
> my question is stupid or IRC was just the wrong place to ask. 

Your question was stupid, so we decided to ignore you and laugh instead!

... just kidding. :D

Your questions are entirely OK, probably nobody saw it or had time to answer 
it, or didn't know the answer. That happens, no biggie, asking on the 
mailinglist is the right thing to do then.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: framework5/plasma2

2013-07-25 Thread Sebastian Kügler 
On Thursday, July 25, 2013 00:06:49 Heena Mahour wrote:
> ^^And, I could not use plasmoidviewer for plasma2 plasmoids :p

plasmoidviewer hasn't been ported yet, as it needs a bit of rework.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

plasma components outside of a plasma package / GSoC

2013-07-25 Thread Michael Bohlender 
I am using plasma components outside of a plasma package in kmail-mobile
and some components don't get displayed / themed correctly.

# PageRow: bordershadows not visible

"
file:///opt/kde4/lib/kde4/imports/org/kde/plasma/extras/PageRow.qml:316:13:
QML QDeclarativeImage_QML_25: Failed to get image from provider:
image://appbackgrounds/shadow-right "

# ListItem: not 3D is like I expected them to be with the air-mobile theme

# Buttons; TextField; ScrollArea and Checkbox seem to look fine.

So my question is: How can I enable the correct theme and how can I
get/enable the background provider ?
Do I need to make  the UI a plasma package?

I asked twice on IRC before and didn't get a response so I am wondering if
my question is stupid or IRC was just the wrong place to ask.

Thanks for your help!

Mike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel