Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43323 --- Ship it! OK. I only meant don't remove existing code that might make sense for some users. But if the real solution for Solaris support is to do it in Qt rather than here, then this code doesn't make sense anymore, remove it. - David Faure On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KModifierKeyInfo usage and API
Aaron? Anyone from the plasma team? I would appreciate input on this (see precise question at the end), it's preventing KF5 from moving forward with KModifierKeyInfo. Please CC kde-frameworks-devel, I'm not on plasma-devel. On Wednesday 16 October 2013 09:56:03 David Faure wrote: We are still a bit unsure what to do about KModifierKeyInfo in KF5: * It's currently only implemented on X11 (PovAddict says querying for modifiers on Windows is easy to add, but getting notified of changes seems quite problematic) * The API (latching vs locking) seems to be a bit too X11 specific, it's unsure that these concepts exist on other platforms (issue raised in http://git.reviewboard.kde.org/r/112443/#review41013) * gwenview was ported away from it (a simple keyPress handler takes care of notifying the app that Ctrl was pressed) * This leaves two users for KModifierKeyInfo as far as lxr.kde.org can see: 1) kile uses it to query the status of Caps Lock at the time when a key is pressed. It uses isKeyLatched()||isKeyLocked() so clearly it doesn't need the distinction. 2) Plasma's KeyService offers the KModifierKeyInfo API in the KeyStatesEngine. Not sure how to then find the users of that general search on keystate found this: http://lxr.kde.org/source/kde/kdeplasma-addons/applets/plasmaboard/widget.cpp but I can't find the actual use of the engine in there? Can a plasma developer tell me how to find the use of this stuff, to see how much we can change its API? Thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43331 --- Ship it! Ship It! - John Layt On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KModifierKeyInfo usage and API
Hello! It looks like keystate applet which was removed from KDE4 was(?) the user of keystate dataengine. If we bring back this applet in Plasma2 then this DataEngine will be used. And this applet is necessary for disabled people, See https://bugs.kde.org/show_bug.cgi?id=165402 Thanks! On Sun, Nov 10, 2013 at 2:46 PM, David Faure fa...@kde.org wrote: Aaron? Anyone from the plasma team? I would appreciate input on this (see precise question at the end), it's preventing KF5 from moving forward with KModifierKeyInfo. Please CC kde-frameworks-devel, I'm not on plasma-devel. On Wednesday 16 October 2013 09:56:03 David Faure wrote: We are still a bit unsure what to do about KModifierKeyInfo in KF5: * It's currently only implemented on X11 (PovAddict says querying for modifiers on Windows is easy to add, but getting notified of changes seems quite problematic) * The API (latching vs locking) seems to be a bit too X11 specific, it's unsure that these concepts exist on other platforms (issue raised in http://git.reviewboard.kde.org/r/112443/#review41013) * gwenview was ported away from it (a simple keyPress handler takes care of notifying the app that Ctrl was pressed) * This leaves two users for KModifierKeyInfo as far as lxr.kde.org can see: 1) kile uses it to query the status of Caps Lock at the time when a key is pressed. It uses isKeyLatched()||isKeyLocked() so clearly it doesn't need the distinction. 2) Plasma's KeyService offers the KModifierKeyInfo API in the KeyStatesEngine. Not sure how to then find the users of that general search on keystate found this: http://lxr.kde.org/source/kde/kdeplasma-addons/applets/plasmaboard/widget.cpp but I can't find the actual use of the engine in there? Can a plasma developer tell me how to find the use of this stuff, to see how much we can change its API? Thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list kde-frameworks-de...@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
List of batteries not updated at runtime
Hi, Tue battery monitor has a strange bug [1] I cannot make sense of. When plugging in a mouse for example, it does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer though. I am not sure on how that onSourceAdded: connectSource(source) works. Any idea what is wrong here? I tried multiple patches into the blue (attached to the bug report) but none of them worked properly. Best, Kai Uwe [1] https://bugs.kde.org/show_bug.cgi?id=324847 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Nested data model
Hi there,
I am trying to create a nested, tree-view like structure. I am trying to base
on:
http://www.codeproject.com/Articles/632795/QML-TreeModel-and-TreeView
However, I do not have QtQuick 2.0 (and the components that go with it).
Anyway, I have created the following code that... crashes both PlasMate and
plasmoidviewer with the message:
QDeclarativeComponent: Cannot create new component instance before completing
the previous
As soon as I comment-out the line:
model: subitems
in the Repeater element, the plasmoid works, but obviously does not display
the sub-items.
Any suggestions?
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
import QtQuick 1.1
import org.kde.plasma.components 0.1 as PlasmaComponents
Item {
width: 200
height: 300
function makeList(list, data){
// as suggested on StackOverflow
// http://stackoverflow.com/questions/5818334/qml-listview-filled-by-
// javascript
for (var t in data) {
list.append(data[t]);
console.log('+-- handling: ' + data[t].text)
}
}
ListModel {
id: theModel
}
Component {
id: recursiveToDoItem
Rectangle {
id: todoContainer
property alias text: todoText.text
property bool running: model.running
property bool done: model.done
property int index: model.index
Component.onCompleted: {
console.log('+-- handled: ' + todoContainer.text +
' as index: ' + todoContainer.index)
}
color: (todoContainer.done) ? grey : white
border {
width:1
color: (todoContainer.running) ? green : red
}
anchors {
left: parent.left
right: parent.right
}
height: todoRow.implicitHeight
Row {
id: todoRow
Text {
id: todoText
text: model.text
color: black
height:28
}
Repeater {
id: todoSubitems
delegate: recursiveToDoItem
model: subitems
}
}
}
}
ListView {
id: itemContainer
anchors.fill: parent
delegate: recursiveToDoItem
}
Component.onCompleted: {
makeList(
theModel,
[{
text:Test 1,
elapsed:4,
running:false,
done:false,
expanded:true,
subitems:[]
},{
text:Test 2,
elapsed:26398,
running:false,
done:false,
expanded:false,
subitems:[{
text:Test 2.1,
elapsed:0,
running:false,
done:false,
expanded:true,
subitems:[]
},{
text:Test 2.2,
elapsed:0,
running:false,
done:false,
expanded:true,
subitems:[]
}]
},{
text:Test 3,
elapsed:26398,
running:false,
done:false,
expanded:false,
subitems:[]
},{
text:Test 4,
elapsed:26398,
running:false,
done:false,
expanded:false,
subitems:[{
text:Test 4.1,
elapsed:0,
running:false,
done:false,
expanded:true,
subitems:[]
},{
text:Test 4.2,
elapsed:0,
running:false,
done:false,
expanded:true,
subitems:[]
},{
text:Test 4.2,
elapsed:0,
running:false,
done:false,
expanded:true,
subitems:[{
text:Test 4.2.1,
elapsed:0,
running:false,
done:false,
expanded:true,
subitems:[]
}]
}]
}]
)
itemContainer.model = theModel
}
}
--
Pozdrawiam
Michał rysiek Woźniak
Fundacja Wolnego i Otwartego Oprogramowania
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
[kde-workspace] plasma: add qmlpackages subdirectory.
Git commit af62be3fbbb1ada4ba42049ea9f42e0c15fc4673 by Bhushan Shah. Committed on 11/11/2013 at 03:58. Pushed by bshah into branch 'master'. add qmlpackages subdirectory. Without that plasma-shell crashes on clean install, saying no shell handlers are installed. CC: plasma-devel@kde.org M +1-1plasma/CMakeLists.txt http://commits.kde.org/kde-workspace/af62be3fbbb1ada4ba42049ea9f42e0c15fc4673 diff --git a/plasma/CMakeLists.txt b/plasma/CMakeLists.txt index 3a5bea4..b191fa6 100644 --- a/plasma/CMakeLists.txt +++ b/plasma/CMakeLists.txt @@ -10,4 +10,4 @@ add_definitions(-DKDE_DEFAULT_DEBUG_AREA=1204) add_subdirectory(desktop) add_subdirectory(generic) - +add_subdirectory(qmlpackages) \ No newline at end of file ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
