Re: Regression from commit 5fdf522c

2013-12-17 Thread Shantanu Tushar Jha 
On Wed, Dec 18, 2013 at 10:27 AM, sujith h  wrote:

> Hi All,
>
> Extremely sorry for the inconvenience caused by me. I didn't tested with
> Open with feautre
>

Dude c'mon, this is very natural and happens all the time. You don't need
to be sorry for this, these things have to happen when we don't have tests
:P

with PMC. Thanks Shantanu that you pointed it out. This also gives us a
> lesson to test PMC
> with the test cases we haven't followed.
>
> Thanks,
>
> Sujith H
>
>
> On Wed, Dec 18, 2013 at 12:32 AM, Shantanu Tushar Jha wrote:
>
>> Hi folks,
>>
>> I just noticed that commit 
>> 5fdf522cbreaks
>>  Open With .. feature with PMC. The media get added to Default
>> playlist while PMC switches to another playlist and plays that. I tried to
>> fix this by creating a new playlist for command line media but our current
>> design makes it very complicated to switch playlists from code on demand.
>>
>> Because the release is in 2 days, I will revert the commit, live without
>> that extra convenience. We can properly implement playlist switching in 1.3
>> so that this can be re-added.
>>
>> Also, lets take this as a lesson to avoid the temptation of adding such
>> small conveniences after a beta release.
>>
>> Thanks!
>>
>> --
>> Shantanu Tushar(UTC +0530)
>> http://www.shantanutushar.com
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> Contributor to KDE project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>  http://sujithh.info
>



-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Regression from commit 5fdf522c

2013-12-17 Thread sujith h 
Hi All,

Extremely sorry for the inconvenience caused by me. I didn't tested with
Open with feautre
with PMC. Thanks Shantanu that you pointed it out. This also gives us a
lesson to test PMC
with the test cases we haven't followed.

Thanks,

Sujith H


On Wed, Dec 18, 2013 at 12:32 AM, Shantanu Tushar Jha wrote:

> Hi folks,
>
> I just noticed that commit 
> 5fdf522cbreaks
>  Open With .. feature with PMC. The media get added to Default
> playlist while PMC switches to another playlist and plays that. I tried to
> fix this by creating a new playlist for command line media but our current
> design makes it very complicated to switch playlists from code on demand.
>
> Because the release is in 2 days, I will revert the commit, live without
> that extra convenience. We can properly implement playlist switching in 1.3
> so that this can be re-added.
>
> Also, lets take this as a lesson to avoid the temptation of adding such
> small conveniences after a beta release.
>
> Thanks!
>
> --
> Shantanu Tushar(UTC +0530)
> http://www.shantanutushar.com
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
 http://sujithh.info
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-framework] src/shell: [plasma-shell] Add an option to suppress any output (--shut-up)

2013-12-17 Thread Àlex Fiestas 
Git commit c047dd5f686c5850fdb2638854885bd76151ef93 by Àlex Fiestas.
Committed on 17/12/2013 at 18:33.
Pushed by afiestas into branch 'master'.

[plasma-shell] Add an option to suppress any output (--shut-up)

The amount of warnings that plasma-shell has, makes it super hard to
make use of tools like journalctl or to grep ~/.xsession-errors.

We need these tools to diagnose possible bugs in the session start or
any other software that redirects stderr or those places.

We can remove this option once all the Warnings are fixed, specially
the one in Qt: https://codereview.qt-project.org/#change,73943

CCMAIL: plasma-devel@kde.org

M  +12   -0src/shell/main.cpp

http://commits.kde.org/plasma-framework/c047dd5f686c5850fdb2638854885bd76151ef93

diff --git a/src/shell/main.cpp b/src/shell/main.cpp
index f6c797d..e073d00 100644
--- a/src/shell/main.cpp
+++ b/src/shell/main.cpp
@@ -32,6 +32,11 @@ static const char description[] = "Plasma Shell";
 static const char version[] = "2.0";
 static QCommandLineParser parser;
 
+void noMessageOutput(QtMsgType type, const char *msg)
+{
+ Q_UNUSED(type);
+ Q_UNUSED(msg);
+}
 int main(int argc, char** argv)
 {
 QApplication app(argc, argv);
@@ -54,11 +59,15 @@ int main(int argc, char** argv)
  QStringLiteral("Recent number of 
crashes"),
  QStringLiteral("n"));
 
+QCommandLineOption shutup(QStringList() << QStringLiteral("s") << 
QStringLiteral("shut-up"),
+ QStringLiteral("Shuts up the output"));
+
 parser.addVersionOption();
 parser.addHelpOption();
 parser.addOption(dbg);
 parser.addOption(win);
 parser.addOption(crash);
+parser.addOption(shutup);
 
 parser.process(app);
 
@@ -68,6 +77,9 @@ int main(int argc, char** argv)
 QQmlDebuggingEnabler enabler;
 }
 
+if (parser.isSet(shutup)) {
+qInstallMsgHandler(noMessageOutput);
+}
 Plasma::PluginLoader::setPluginLoader(new ShellPluginLoader);
 
 ShellManager::setCrashCount(parser.value(crash).toInt());

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-framework] src/shell: [plasma-shell] Mute all debug output when started from autostart

2013-12-17 Thread Àlex Fiestas 
Git commit dfcfad1182e51d5165bd8d289a33253aba7b8776 by Àlex Fiestas.
Committed on 17/12/2013 at 18:44.
Pushed by afiestas into branch 'master'.

[plasma-shell] Mute all debug output when started from autostart

This enables other developers to use journalctl/~.xsession-errors and
do not drown on warnings.

CCMAIL: plasma-devel@kde.org

M  +1-1src/shell/plasma-shell.desktop

http://commits.kde.org/plasma-framework/dfcfad1182e51d5165bd8d289a33253aba7b8776

diff --git a/src/shell/plasma-shell.desktop b/src/shell/plasma-shell.desktop
index f6c4229..0d6d231 100644
--- a/src/shell/plasma-shell.desktop
+++ b/src/shell/plasma-shell.desktop
@@ -1,5 +1,5 @@
 [Desktop Entry]
-Exec=plasma-shell
+Exec=plasma-shell --shut-up
 X-DBUS-StartupType=Unique
 Name=Plasma Desktop Workspace
 Name[de]=Plasma-Arbeitsflächenbereich
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Regression from commit 5fdf522c

2013-12-17 Thread Shantanu Tushar Jha 
Hi folks,

I just noticed that commit
5fdf522cbreaks
Open With .. feature with PMC. The media get added to Default
playlist while PMC switches to another playlist and plays that. I tried to
fix this by creating a new playlist for command line media but our current
design makes it very complicated to switch playlists from code on demand.

Because the release is in 2 days, I will revert the commit, live without
that extra convenience. We can properly implement playlist switching in 1.3
so that this can be re-added.

Also, lets take this as a lesson to avoid the temptation of adding such
small conveniences after a beta release.

Thanks!

-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kde-workspace] ksmserver: [ksmserver] Port the shutdowndlg, HUGE hack just to make it work

2013-12-17 Thread Àlex Fiestas 
Git commit 63197074b17e042d2d99973488358a14afae8560 by Àlex Fiestas.
Committed on 17/12/2013 at 17:34.
Pushed by afiestas into branch 'master'.

[ksmserver] Port the shutdowndlg, HUGE hack just to make it work

Please, somebody else should properly port this, I have done the minimum
required work to allow the dialog to work.

CCMAIL: plasma-devel@kde.org

M  +19   -13   ksmserver/shutdowndlg.cpp
M  +4-4ksmserver/themes/contour/ContourButton.qml
M  +4-4ksmserver/themes/contour/main.qml
M  +5-5ksmserver/themes/default/ContextMenu.qml
M  +9-9ksmserver/themes/default/KSMButton.qml
M  +4-4ksmserver/themes/default/MenuItem.qml
M  +86   -86   ksmserver/themes/default/main.qml

http://commits.kde.org/kde-workspace/63197074b17e042d2d99973488358a14afae8560

diff --git a/ksmserver/shutdowndlg.cpp b/ksmserver/shutdowndlg.cpp
index 6ad428d..00704e4 100644
--- a/ksmserver/shutdowndlg.cpp
+++ b/ksmserver/shutdowndlg.cpp
@@ -162,11 +162,12 @@ void KSMShutdownFeedback::logoutCanceled()
 
 
 Q_DECLARE_METATYPE(Solid::PowerManagement::SleepState)
+#include 
 
 KSMShutdownDlg::KSMShutdownDlg( QWidget* parent,
 bool maysd, bool choose, 
KWorkSpace::ShutdownType sdtype,
 const QString& theme)
-  : QDialog( parent, Qt::Popup ) //krazy:exclude=qclasses
+  : QDialog( parent/*, Qt::Popup */) //krazy:exclude=qclasses
 // this is a WType_Popup on purpose. Do not change that! Not
 // having a popup here has severe side effects.
 {
@@ -181,8 +182,13 @@ KSMShutdownDlg::KSMShutdownDlg( QWidget* parent,
 
 KDialog::centerOnScreen(this, -3);
 
+ setMinimumSize(300, 200);
 //kDebug() << "Creating QML view";
-m_view = new QQuickView(windowHandle());
+QVBoxLayout *vbox = new QVBoxLayout(this);
+m_view = new QQuickView( );
+QWidget *windowContainer = QWidget::createWindowContainer(m_view, this);
+vbox->addWidget(windowContainer);
+windowContainer->setSizePolicy(QSizePolicy::Preferred, 
QSizePolicy::Preferred);
 QQmlContext *context = m_view->rootContext();
 context->setContextProperty(QStringLiteral("maysd"), maysd);
 context->setContextProperty(QStringLiteral("choose"), choose);
@@ -223,22 +229,23 @@ KSMShutdownDlg::KSMShutdownDlg( QWidget* parent,
 setModal( true );
 
 // window stuff
-m_view->setFlags(Qt::X11BypassWindowManagerHint);
-//m_view->setFrameShape(QFrame::NoFrame);
-//m_view->setAttribute(Qt::WA_TranslucentBackground);
+// setFlags(Qt::X11BypassWindowManagerHint);
+// windowContainer->setFrameShape(QFrame::NoFrame);
+windowContainer->setAttribute(Qt::WA_TranslucentBackground);
+setAttribute(Qt::WA_TranslucentBackground);
 setAttribute(Qt::WA_TranslucentBackground);
 setStyleSheet(QStringLiteral("background:transparent;"));
-//QPalette pal = m_view->palette();
-//pal.setColor(backgroundRole(), Qt::transparent);
-//m_view->setPalette(pal);
-//m_view->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
-//m_view->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+QPalette pal = windowContainer->palette();
+pal.setColor(backgroundRole(), Qt::transparent);
+windowContainer->setPalette(pal);
+//setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+//setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
 // engine stuff
 KDeclarative kdeclarative;
 kdeclarative.setDeclarativeEngine(m_view->engine());
 kdeclarative.initialize();
 kdeclarative.setupBindings();
-m_view->installEventFilter(this);
+windowContainer->installEventFilter(this);
 
 QString fileName = 
QStandardPaths::locate(QStandardPaths::GenericDataLocation, 
QStringLiteral("ksmserver/themes/%1/main.qml").arg(theme));
 if (QFile::exists(fileName)) {
@@ -253,8 +260,7 @@ KSMShutdownDlg::KSMShutdownDlg( QWidget* parent,
 connect(rootObject, SIGNAL(rebootRequested2(int)), SLOT(slotReboot(int)) );
 connect(rootObject, SIGNAL(cancelRequested()), SLOT(reject()));
 connect(rootObject, SIGNAL(lockScreenRequested()), SLOT(slotLockScreen()));
-m_view->show();
-//m_view->setFocus();
+
 adjustSize();
 }
 
diff --git a/ksmserver/themes/contour/ContourButton.qml 
b/ksmserver/themes/contour/ContourButton.qml
index ee82205..5176c6a 100644
--- a/ksmserver/themes/contour/ContourButton.qml
+++ b/ksmserver/themes/contour/ContourButton.qml
@@ -22,7 +22,7 @@ Inherits:
 PlasmaCore.FrameSvgItem
 
 Imports:
-QtQuick 1.0
+QtQuick 2.0
 org.kde.plasma.core
 org.kde.qtextracomponents
 
@@ -53,9 +53,9 @@ Signals:
 This handler is called when there is a click.
 **/
 
-import QtQuick 1.0
-import org.kde.plasma.core 0.1 as PlasmaCore
-import org.kde.qtextracomponents 0.1
+import QtQuick 2.0
+import org.kde.plasma.core 2.0 as PlasmaCore
+import org.kde.qtextracomponents 2.0
 
 PlasmaCore.FrameSvgItem {
 id: button
diff --git a/ksmserver/themes/cont

[kde-workspace] ksplash/ksplashqml: [ksplash] Make KPlashQML stages ready to be run asynchronously

2013-12-17 Thread Àlex Fiestas 
Git commit c1d668f167a9bd3ac4db1475564dea49e8f7adac by Àlex Fiestas.
Committed on 17/12/2013 at 18:12.
Pushed by afiestas into branch 'master'.

[ksplash] Make KPlashQML stages ready to be run asynchronously

Since we ported to DBus we are using ASync calls to send the
QDBusMessages that indicate to KSplash that a new stage has happened.
Since we are using an async method we can't take into account the order
anymore.

I tried changing all calls to be sync and then KSplash works correctly
which shows that we are starting the session correctly but it is better
if we keep these calls async because you know, the future is async.

CCMAIL: plasma-devel@kde.org

M  +5-14   ksplash/ksplashqml/SplashApp.cpp
M  +1-0ksplash/ksplashqml/SplashApp.h

http://commits.kde.org/kde-workspace/c1d668f167a9bd3ac4db1475564dea49e8f7adac

diff --git a/ksplash/ksplashqml/SplashApp.cpp b/ksplash/ksplashqml/SplashApp.cpp
index 20bde13..893bf1b 100644
--- a/ksplash/ksplashqml/SplashApp.cpp
+++ b/ksplash/ksplashqml/SplashApp.cpp
@@ -74,20 +74,11 @@ void SplashApp::timerEvent(QTimerEvent * event)
 
 void SplashApp::setStage(const QString &stage)
 {
-if (stage == QLatin1String("initial") && m_stage < 0)
-setStage(0); // not actually used
-else if (stage == QLatin1String("kded") && m_stage < 1)
-setStage(1);
-else if (stage == QLatin1String("confupdate") && m_stage < 2)
-setStage(2);
-else if (stage == QLatin1String("kcminit") && m_stage < 3)
-setStage(3);
-else if (stage == QLatin1String("ksmserver") && m_stage < 4)
-setStage(4);
-else if (stage == QLatin1String("wm") && m_stage < 5)
-setStage(5);
-else if (stage == QLatin1String("desktop") && m_stage < 6)
-setStage(6);
+if (m_stages.contains(stage)) {
+return;
+}
+m_stages.append(stage);
+setStage(m_stages.count());
 }
 
 void SplashApp::setStage(int stage)
diff --git a/ksplash/ksplashqml/SplashApp.h b/ksplash/ksplashqml/SplashApp.h
index 3ba3147..e720998 100644
--- a/ksplash/ksplashqml/SplashApp.h
+++ b/ksplash/ksplashqml/SplashApp.h
@@ -47,6 +47,7 @@ private:
 int m_stage;
 QList m_windows;
 bool m_testing;
+QStringList m_stages;
 QBasicTimer m_timer;
 QDesktopWidget *m_desktop;
 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel