[plasma-mediacenter] shells/newshell: Merge branch 'shantanu-sinny-media-caching'
Git commit b574f17b803d4c355b6f354dde0634026d536cd4 by Shantanu Tushar.
Committed on 16/02/2014 at 12:41.
Pushed by shantanu into branch 'master'.
Merge branch 'shantanu-sinny-media-caching'
This implements a media cache for PMC which is populated by one or more
media sources. The media sources can be plugins, currently the one that
we have pulls data from Nepomuk.
The media cache is stored in a SQLite database and accessed using an ORM
layer called ODB. The README, especially the build instructions have been
updated. If you have trouble building or have a concern, please drop an
email to plasma-devel@kde.org
Finally, PMC now also contains test for the new media library code and hope
is that the core libs/ will get good test coverage soon.
CCMAIL: plasma-devel@kde.org
M +10 -0shells/newshell/main.cpp
http://commits.kde.org/plasma-mediacenter/b574f17b803d4c355b6f354dde0634026d536cd4
diff --cc shells/newshell/main.cpp
index 377ba70,ea2cb75..3100d4f
--- a/shells/newshell/main.cpp
+++ b/shells/newshell/main.cpp
@@@ -62,13 -65,15 +66,19 @@@ int main(int argc, char *argv[]
options.add(disable-opengl, ki18n(Starts Plasma Media Center without
OpenGL support));
options.add(+[Url], ki18nc(@info:shell, Document to open));
KCmdLineArgs::addCmdLineOptions(options);
+KUniqueApplication::addCmdLineOptions();
+
+if( !KUniqueApplication::start() ) {
+qDebug() Plasma Mediacenter is already running;
+return 0;
+}
-KApplication app;
+ SingletonFactory::instanceForMediaLibrary()-start();
+
+ qRegisterMetaType QHashint,QVariant (QHashint,QVariant);
+ MediaSourcesLoader mediaSourcesLoader;
+ mediaSourcesLoader.load();
+
-MainWindow *mw = new MainWindow;
-mw-show();
+Application app;
return app.exec();
}
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Request for review
Hey,
-- Forwarded message --
From: Conny Marco Menebröcker ad...@menebroecker-web.de
Date: Sat, Feb 15, 2014 at 7:44 PM
Subject: Request for review
To: kde-de...@kde.org
Hello all,
I have written my first plasmoid. I called it PlasmaTaskViewer,
because it views the todos of a calendar file.
In my case it shows the entries of my iPhone reminder app.
I would be happy if someone reviews my code. I am especially
interested in comments about the use of kcalcore and the data engine.
But every other comment is welcome, too.
I just did a quick look over your code and tried to build it. You'll need
to explicitly look for KdepimLibs + set include_dirs in order to build
everywhere with no problems. Attached is a simple patch fixing the build.
I tried running it but have no .ics files present so can't really try it
out. Though your configuration dialog is somewhat too small and cannot be
resized easily for some reason. One more comment on the visuals - if I add
the applet is added on the desktop and you have no data/must set it up
first, it should show some label what to do, otherwise it's just an empty
Plasma-themed rectangle sitting on your desktop :)
Final note, we do not really support Applets based on QGraphicsView
anymore, the proper way to go is to use QML, which is way superior in tech
and ease of writing. I think this[1] should be a good way to get you
started :)
[1] -
http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted
Cheers
--
Martin Klapetek | KDE Developer
Index: CMakeLists.txt
===
--- CMakeLists.txt (revision 2)
+++ CMakeLists.txt (working copy)
@@ -23,10 +23,11 @@
# Find the required Libraries
find_package(KDE4 REQUIRED)
+find_package (KdepimLibs REQUIRED)
include(KDE4Defaults)
add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS})
-include_directories(
+include_directories(${KDEPIMLIBS_INCLUDE_DIRS}
${CMAKE_SOURCE_DIR}
${CMAKE_BINARY_DIR}
${KDE4_INCLUDES}
@@ -51,7 +52,7 @@
target_link_libraries(plasma_dataengine_TaskViewerContainer
${KDE4_PLASMA_LIBS}
${KDE4_KIO_LIBS}
- kcalcore)
+ ${KDEPIMLIBS_KCALCORE_LIBS})
install(TARGETS plasma_applet_taskviewer
DESTINATION ${PLUGIN_INSTALL_DIR})
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115764: Make playlist model aware of currently playing media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/#review50008 --- Tested with my recent patches with this patch. It doesn't break. Hence I am ok with this change. - Sujith Haridasan On Feb. 15, 2014, 5:24 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/ --- (Updated Feb. 15, 2014, 5:24 p.m.) Review request for Plasma, Sinny Kumari and Sujith Haridasan. Repository: plasma-mediacenter Description --- We have lots of issues because of the fact that the playlist model is not aware of what is playing right now and what is current index for the ListView. Additionally logic was thrown here and there in C++ and QML. This patch makes the model aware of the conect of currently playing index and it also makes sure that the model is in control of what is playing and how to play next/previous. This patch should not break any existing functionality except that changing playlist will make the current media to stop. This is to have consistency in what is playing and what the model can deduce it is playing. This will be improved in an upcoming patch but other things should keep working. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 mediaelements/playlist/MultiplePlaylists.qml d94fe6e mediaelements/playlist/Playlist.qml fd83c21 mediaelements/playlist/PlaylistDelegate.qml e1bd31d shells/newshell/application.cpp adc95dc shells/newshell/mainwindow.h d918e3d shells/newshell/mainwindow.cpp 7f7f31d shells/newshell/package/contents/ui/mediacenter.qml b6cb87c libs/mediacenter/multipleplaylistmodel.h 06b64df libs/mediacenter/multipleplaylistmodel.cpp f2c9246 libs/mediacenter/playlistmodel.h f79f814 Diff: https://git.reviewboard.kde.org/r/115764/diff/ Testing --- Tested with usual playback and with passing multiple files as command line parameters. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Request for review
Hello Martin, Am 16.02.2014 17:41, schrieb Martin Klapetek: Hey, -- Forwarded message -- From: Conny Marco Menebröcker ad...@menebroecker-web.de mailto:ad...@menebroecker-web.de Date: Sat, Feb 15, 2014 at 7:44 PM Subject: Request for review To: kde-de...@kde.org mailto:kde-de...@kde.org Hello all, I have written my first plasmoid. I called it PlasmaTaskViewer, because it views the todos of a calendar file. In my case it shows the entries of my iPhone reminder app. I would be happy if someone reviews my code. I am especially interested in comments about the use of kcalcore and the data engine. But every other comment is welcome, too. I just did a quick look over your code and tried to build it. You'll need to explicitly look for KdepimLibs + set include_dirs in order to build everywhere with no problems. Attached is a simple patch fixing the build. Thank you very much for the patch and your comments. Yesterday, I checked in your patch. I tried running it but have no .ics files present so can't really try it out. Though your configuration dialog is somewhat too small and cannot be resized easily for some reason. One more comment on the visuals - if I add the applet is added on the desktop and you have no data/must set it up first, it should show some label what to do, otherwise it's just an empty Plasma-themed rectangle sitting on your desktop :) I already noticed the issue with the configuration dialog, but couldn't figure out how to fix it, yet. I will add the label with one of my next changes. Final note, we do not really support Applets based on QGraphicsView anymore, the proper way to go is to use QML, which is way superior in tech and ease of writing. I think this[1] should be a good way to get you started :) I will read the tutorial and decide afterwards, if I will change something. I don't know much about QML, I thought it was only a specific programming language for QT development. So, currently I don't understand the advantage. But we will see. [1] - http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted Cheers -- Martin Klapetek | KDE Developer Best regards, Conny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
