Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)

[Sinny Kumari]

On Thu, Feb 27, 2014 at 2:04 AM, Thomas Pfeiffer wrote:

> On Tuesday 25 February 2014 10:48:47 Shantanu Tushar Jha wrote:
> > Hi Harshit,
> >
> > First of all, just a note, whenever you have a new thing to discuss, it
> is
> > a bad idea to reply to an existing thread which is not directly related
> > (this is popularly known as hacking others' threads :P)
> >
> > To the topic, I personally don't think it is a good idea to let the user
> > change the background of the media center. The rationale behind this is
> > that the background is part of our UI so changing it can lead to visual
> > inconsistency.
> >
> > I'll love to hear from others' views on this, especially our Usability
> > folks.
>
> Hi Harshit, hi Shantanu,
> from a usability perspective, changing the background of a UI isn't a
> no-go,
> but it has to be handled with care. The most important thing is that to
> avoid
> bad contrast, every other element of the UI has to have a standard-color
> background on top of the user-selected background.
> You'd have to try that out (black background behind every UI element,
> probably
> with a few pixels around the actual element) and see whether it
> a) looks good
> b) leaves enough of the background visible to make sense at al


+1 , Nice idea in case we want to go for user customized background


-- 
http://www.sinny.in
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Harshit Agarwal]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/
---

(Updated Feb. 27, 2014, 4:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Through this patch, the user can go to the previous window through the 
backspace key also. The issue with the focus on the Search Bar has been solved. 
The backspace option works only when the search bar is not in focus.


Diffs
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116063/diff/


Testing
---

It has been tested.


Thanks,

Harshit Agarwal

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review50997
---


This review has been submitted with commit 
125ce5b22dd7f4983480e38bd2669efa1157f46d by Shantanu Tushar on behalf of 
Harshit Agarwal to branch master.

- Commit Hook


On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> ---
> 
> (Updated Feb. 26, 2014, 7:45 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Through this patch, the user can go to the previous window through the 
> backspace key also. The issue with the focus on the Search Bar has been 
> solved. The backspace option works only when the search bar is not in focus.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
> 
> 
> Testing
> ---
> 
> It has been tested.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review50996
---

Ship it!


Just checked again on master instead of my branch. Works fine, this can go in :)

- Shantanu Tushar


On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> ---
> 
> (Updated Feb. 26, 2014, 7:45 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Through this patch, the user can go to the previous window through the 
> backspace key also. The issue with the focus on the Search Bar has been 
> solved. The backspace option works only when the search bar is not in focus.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
> 
> 
> Testing
> ---
> 
> It has been tested.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)

[Thomas Pfeiffer]

On Tuesday 25 February 2014 10:48:47 Shantanu Tushar Jha wrote:
> Hi Harshit,
> 
> First of all, just a note, whenever you have a new thing to discuss, it is
> a bad idea to reply to an existing thread which is not directly related
> (this is popularly known as hacking others' threads :P)
> 
> To the topic, I personally don't think it is a good idea to let the user
> change the background of the media center. The rationale behind this is
> that the background is part of our UI so changing it can lead to visual
> inconsistency.
> 
> I'll love to hear from others' views on this, especially our Usability
> folks.

Hi Harshit, hi Shantanu,
from a usability perspective, changing the background of a UI isn't a no-go, 
but it has to be handled with care. The most important thing is that to avoid 
bad contrast, every other element of the UI has to have a standard-color 
background on top of the user-selected background. 
You'd have to try that out (black background behind every UI element, probably 
with a few pixels around the actual element) and see whether it
a) looks good
b) leaves enough of the background visible to make sense at all

I agree with Shantanu that without background behind the other elements, we 
could end up with unreadable, unrecognizable or completely invisible elements 
with the wrong background.

CC'ing Jens to hear what he may have to say from a design perspective.

Cheers,
Thomas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Selecting wallpaper during Activity creation

[Thomas Pfeiffer]

Hi everyone,
when Ivan posted a screenshot of the Activities sidebar on Google+ recently, I 
liked it a lot! The only thing I found missing was the selection of a 
wallpaper right in the Activity creation dialog, like we have in Plasma Active 
[1].
The big advantage I see in this is that it assures that each Activity is 
visually personalized and recognizable from the get-go.
Do you think that this would make sense for Plasma Desktop as well, or do you 
think that it only makes sense for Plasma Active, or that it makes no sense in 
general?

Cheers,
Thomas

[1] 
http://community.kde.org/images.community/thumb/9/94/Task_Dialog.png/800px-Task_Dialog.png
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Kevin Krammer]

On Wednesday, 2014-02-26, 20:07:58, Marco Martin wrote:
> On Wednesday 26 February 2014 19:51:54 Kevin Krammer wrote:
> > > if some kind of api is done to link the whatever bindings are in the
> > > application that is using qtscript and the console (just something
> > > really
> > > easy, like run this string with a script) then i guess it would be
> > > realistic provising a console like that in a public library
> > 
> > I am most likely confused by the terminology :-)
> > 
> > So do I understand this correctly that it needs to be part of a specific
> > process, not just any process with a script engine.
> 
> no no, just the same process in which the script engine is, unless you want
> to expose a full api to run scripts via dbus, but that's a security issue

Ah, ok. My assumption was always in-process, something like instantiating a 
"script console" class and passing in the QScriptEngine to operate on.

My context is that I have been experiementing with QtScript and Akonadi APIs 
but non-interactive is only good for "extension downloads", not for actual 
user scripting.
The latter needs some way for user to discover capabilities and experiement.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Marco Martin]

On Wednesday 26 February 2014 19:51:54 Kevin Krammer wrote:
> > if some kind of api is done to link the whatever bindings are in the
> > application that is using qtscript and the console (just something really
> > easy, like run this string with a script) then i guess it would be
> > realistic provising a console like that in a public library
> 
> I am most likely confused by the terminology :-)
> 
> So do I understand this correctly that it needs to be part of a specific
> process, not just any process with a script engine.

no no, just the same process in which the script engine is, unless you want to 
expose a full api to run scripts via dbus, but that's a security issue

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote:
> > src/shell/CMakeLists.txt, line 20
> > 
> >
> > This would mean:
> > a) propagate KTextEditor to part of the KF5 releases (that was not the 
> > case with TP1 & alpha1)
> > b) move the console or shell altogether to a different repo
> > c) rewrite it without this framework
> 
> Marco Martin wrote:
> ah.
> is ok to depend from it from other projects?
> We tought about moving the whole shell subdirectory to kde-workspace, 
> looks like we have to do it sooner.
> 
> Hrvoje Senjan wrote:
> it 'can' depend atm - but alpha2 is scheduled for weekend =) (personally, 
> i'd love to have KTextEditor there, but that's something for release & kate 
> guys ;-)

since unfortunately it has been already merged,
would be a branch (or just a tag) from before this branch was merged be ok for 
alpha2?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50965
---


On Feb. 26, 2014, 5:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 5:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Kevin Krammer]

On Wednesday, 2014-02-26, 19:00:49, Marco Martin wrote:
> On Wednesday 26 February 2014 18:51:34 Kevin Krammer wrote:
> > On Wednesday, 2014-02-26, 11:27:04, Marco Martin wrote:
> > > Hi all,
> > > yesterday i was toying with porting the javascript interactive console
> > > for
> > > plasma-shell.
> > 
> > Maybe that is a stupid question, but how Plasma specific is this console?
> > Would it be something other QtScript/QJSEngine using applications could
> > find useful as well?
> 
> the specific part is that it needs to be in the same process as the plasma
> shell.
> if some kind of api is done to link the whatever bindings are in the
> application that is using qtscript and the console (just something really
> easy, like run this string with a script) then i guess it would be realistic
> provising a console like that in a public library

I am most likely confused by the terminology :-)

So do I understand this correctly that it needs to be part of a specific 
process, not just any process with a script engine.

Due to doing something like runtime symbol lookup, i.e. expecting certain 
QObjects to exist?

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Hrvoje Senjan]

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote:
> > src/shell/CMakeLists.txt, line 20
> > 
> >
> > This would mean:
> > a) propagate KTextEditor to part of the KF5 releases (that was not the 
> > case with TP1 & alpha1)
> > b) move the console or shell altogether to a different repo
> > c) rewrite it without this framework
> 
> Marco Martin wrote:
> ah.
> is ok to depend from it from other projects?
> We tought about moving the whole shell subdirectory to kde-workspace, 
> looks like we have to do it sooner.

it 'can' depend atm - but alpha2 is scheduled for weekend =) (personally, i'd 
love to have KTextEditor there, but that's something for release & kate guys ;-)


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50965
---


On Feb. 26, 2014, 5:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 5:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Marco Martin]

On Wednesday 26 February 2014 15:00:36 Martin Gräßlin wrote:
> > so, opinion poll:
> > move plasma-shell to kde-workspace? (btw, is kde-workspace the final
> > nameit's going to have? what is the status of the splitting it?)
> 
> Right it could be put together with the other plasma parts when splitting
> and maybe it doesn't make much sense to change anything prior to splitting.

apparently we have to kinda move quickly:
a framework can't depend from ktexteditor yet because it hasn't been part of 
the tp and alpha releases of kf5

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Marco Martin]

On Wednesday 26 February 2014 18:51:34 Kevin Krammer wrote:
> On Wednesday, 2014-02-26, 11:27:04, Marco Martin wrote:
> > Hi all,
> > yesterday i was toying with porting the javascript interactive console for
> > plasma-shell.
> 
> Maybe that is a stupid question, but how Plasma specific is this console?
> Would it be something other QtScript/QJSEngine using applications could find
> useful as well?

the specific part is that it needs to be in the same process as the plasma 
shell.
if some kind of api is done to link the whatever bindings are in the 
application that is using qtscript and the console (just something really 
easy, like run this string with a script) then i guess it would be realistic 
provising a console like that in a public library

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote:
> > src/shell/CMakeLists.txt, line 20
> > 
> >
> > This would mean:
> > a) propagate KTextEditor to part of the KF5 releases (that was not the 
> > case with TP1 & alpha1)
> > b) move the console or shell altogether to a different repo
> > c) rewrite it without this framework

ah.
is ok to depend from it from other projects?
We tought about moving the whole shell subdirectory to kde-workspace, looks 
like we have to do it sooner.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50965
---


On Feb. 26, 2014, 5:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 5:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Kevin Krammer]

On Wednesday, 2014-02-26, 11:27:04, Marco Martin wrote:
> Hi all,
> yesterday i was toying with porting the javascript interactive console for
> plasma-shell.

Maybe that is a stupid question, but how Plasma specific is this console?
Would it be something other QtScript/QJSEngine using applications could find 
useful as well?

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50965
---



src/shell/CMakeLists.txt


This would mean:
a) propagate KTextEditor to part of the KF5 releases (that was not the case 
with TP1 & alpha1)
b) move the console or shell altogether to a different repo
c) rewrite it without this framework


- Hrvoje Senjan


On Feb. 26, 2014, 5:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 5:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/
---

(Updated Feb. 26, 2014, 5:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

this ports the js interactive console from plasma1 and ports it way from 
kde4support

ui-wise it should look the same


Diffs
-

  src/shell/CMakeLists.txt db0e569 
  src/shell/interactiveconsole.h PRE-CREATION 
  src/shell/interactiveconsole.cpp PRE-CREATION 
  src/shell/packages.h 999b4c9 
  src/shell/packages.cpp 0b2aa3f 
  src/shell/scripting/layouttemplatepackagestructure.h abc5562 
  src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
  src/shell/scripting/scriptengine.cpp 29735a0 
  src/shell/shellcorona.cpp e84e0bf 
  src/shell/shellpluginloader.cpp c57b348 

Diff: https://git.reviewboard.kde.org/r/116085/diff/


Testing
---

tried to add plasmoids from the console


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50963
---


This review has been submitted with commit 
1fd741b5d30929d18311c050cf3aa1d080088ab5 by Marco Martin to branch master.

- Commit Hook


On Feb. 26, 2014, 4:03 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 4:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50960
---

Ship it!


Ship It!

- David Edmundson


On Feb. 26, 2014, 4:03 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 4:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115764: Make playlist model aware of currently playing media

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115764/#review50956
---


This review has been submitted with commit 
125a9e295a4e1f0b9b627dda0158f31f1ea3c2d5 by Shantanu Tushar to branch 
shantanu-qxorm.

- Commit Hook


On Feb. 15, 2014, 5:24 p.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115764/
> ---
> 
> (Updated Feb. 15, 2014, 5:24 p.m.)
> 
> 
> Review request for Plasma, Sinny Kumari and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> We have lots of issues because of the fact that the playlist model is not 
> aware of what is playing right now and what is current index for the 
> ListView. Additionally logic was thrown here and there in C++ and QML. This 
> patch makes the model aware of the conect of currently playing index and it 
> also makes sure that the model is in control of what is playing and how to 
> play next/previous.
> 
> This patch should not break any existing functionality except that changing 
> playlist will make the current media to stop. This is to have consistency in 
> what is playing and what the model can deduce it is playing. This will be 
> improved in an upcoming patch but other things should keep working.
> 
> 
> Diffs
> -
> 
>   libs/mediacenter/playlistmodel.cpp 9c1dea9 
>   mediaelements/playlist/MultiplePlaylists.qml d94fe6e 
>   mediaelements/playlist/Playlist.qml fd83c21 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
>   shells/newshell/application.cpp adc95dc 
>   shells/newshell/mainwindow.h d918e3d 
>   shells/newshell/mainwindow.cpp 7f7f31d 
>   shells/newshell/package/contents/ui/mediacenter.qml b6cb87c 
>   libs/mediacenter/multipleplaylistmodel.h 06b64df 
>   libs/mediacenter/multipleplaylistmodel.cpp f2c9246 
>   libs/mediacenter/playlistmodel.h f79f814 
> 
> Diff: https://git.reviewboard.kde.org/r/115764/diff/
> 
> 
> Testing
> ---
> 
> Tested with usual playback and with passing multiple files as command line 
> parameters.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115764: Make playlist model aware of currently playing media

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115764/
---

(Updated Feb. 26, 2014, 4:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Sinny Kumari and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

We have lots of issues because of the fact that the playlist model is not aware 
of what is playing right now and what is current index for the ListView. 
Additionally logic was thrown here and there in C++ and QML. This patch makes 
the model aware of the conect of currently playing index and it also makes sure 
that the model is in control of what is playing and how to play next/previous.

This patch should not break any existing functionality except that changing 
playlist will make the current media to stop. This is to have consistency in 
what is playing and what the model can deduce it is playing. This will be 
improved in an upcoming patch but other things should keep working.


Diffs
-

  libs/mediacenter/playlistmodel.cpp 9c1dea9 
  mediaelements/playlist/MultiplePlaylists.qml d94fe6e 
  mediaelements/playlist/Playlist.qml fd83c21 
  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
  shells/newshell/application.cpp adc95dc 
  shells/newshell/mainwindow.h d918e3d 
  shells/newshell/mainwindow.cpp 7f7f31d 
  shells/newshell/package/contents/ui/mediacenter.qml b6cb87c 
  libs/mediacenter/multipleplaylistmodel.h 06b64df 
  libs/mediacenter/multipleplaylistmodel.cpp f2c9246 
  libs/mediacenter/playlistmodel.h f79f814 

Diff: https://git.reviewboard.kde.org/r/115764/diff/


Testing
---

Tested with usual playback and with passing multiple files as command line 
parameters.


Thanks,

Shantanu Tushar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/
---

(Updated Feb. 26, 2014, 4:03 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

this ports the js interactive console from plasma1 and ports it way from 
kde4support

ui-wise it should look the same


Diffs (updated)
-

  src/shell/CMakeLists.txt db0e569 
  src/shell/interactiveconsole.h PRE-CREATION 
  src/shell/interactiveconsole.cpp PRE-CREATION 
  src/shell/packages.h 999b4c9 
  src/shell/packages.cpp 0b2aa3f 
  src/shell/scripting/layouttemplatepackagestructure.h abc5562 
  src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
  src/shell/scripting/scriptengine.cpp 29735a0 
  src/shell/shellcorona.cpp e84e0bf 
  src/shell/shellpluginloader.cpp c57b348 

Diff: https://git.reviewboard.kde.org/r/116085/diff/


Testing
---

tried to add plasmoids from the console


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

> On Feb. 26, 2014, 3:47 p.m., David Edmundson wrote:
> > src/shell/interactiveconsole.cpp, line 57
> > 
> >
> > Are you not doing that on line 130?

yeah, comes from the copy of the oold file ;)


> On Feb. 26, 2014, 3:47 p.m., David Edmundson wrote:
> > src/shell/interactiveconsole.h, line 2
> > 
> >
> > Is this copied from somewhere then?
> > Update copyright if you need to, otherwise ignore this.

yeah, i tought about it after sending the rr, it comes from the plasma1 
implementation, is just the same file adapted


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50941
---


On Feb. 26, 2014, 3:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115695/
---

(Updated Feb. 26, 2014, 4:53 p.m.)


Status
--

This change has been discarded.


Review request for kde-workspace, KDE Frameworks, Plasma, and Sune Vuorela.


Repository: knotifications


Description
---

This patch merges KNotify daemon into KNotificationManager to have less daemons 
running and less dbus traffic. The patch is not yet finished (and for now it's 
full of QDebugs, that will all be removed and FIXMEs to indicate what needs 
doing), but as the Alpha2 is quite soon, I'd like to start the general review 
asap so some more changes can be done if needed.

Now it's KNotificationManager that handles the KNotifyPlugin-s and hands them 
the notification directly. KNotifyConfig was repurposed a bit, now it serves 
mostly just as the .notifyrc wrapper, all the rest is reused from the 
KNotification object. There are some changes in the KNotification API - id() 
and appName() are now exposed to public and "slotReceivedId(int)" is now also 
public so that KNotificationManager can directly give it an id. I'd like to 
rename this and make it a non-slot. It's not the DBus/Galago server ID anymore, 
that is handled in NotifyByPopup which is responsible for communicating with 
the galago server (all the methods there were renamed to actually have *galago* 
in the name so it's clear), therefore the mapping of DBus/Galago Server ids is 
managed only there as it is actually only needed here. KNotitification::id() is 
assigned by the KNotificationManager and it's a simple increasing counter.

The UI/Plasmoid changes will come next - basically the plan is to put only the 
"Persistent" notifications in the notifications history.


Diffs
-

  src/knotifyconfig.h PRE-CREATION 
  src/knotifyconfig.cpp PRE-CREATION 
  src/knotifyplugin.h PRE-CREATION 
  src/knotifyplugin.cpp PRE-CREATION 
  src/notifybypopup.h PRE-CREATION 
  src/notifybypopup.cpp PRE-CREATION 
  src/notifybypopupgrowl.h PRE-CREATION 
  src/notifybypopupgrowl.cpp PRE-CREATION 
  CMakeLists.txt 63ebf71 
  src/CMakeLists.txt a81b913 
  src/knotification.h 00554ba 
  src/knotification.cpp 5d7405b 
  src/knotificationmanager.cpp a4d0dfa 
  src/knotificationmanager_p.h 81d962d 

Diff: https://git.reviewboard.kde.org/r/115695/diff/


Testing
---

Works perfectly with both plasma notifications and kpassivepopup.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50941
---



src/shell/interactiveconsole.h


Is this copied from somewhere then?
Update copyright if you need to, otherwise ignore this.



src/shell/interactiveconsole.cpp


Are you not doing that on line 130?



src/shell/interactiveconsole.cpp


m_closeWhenCompleted should be initialised

to be consistent m_output should be too; but that's at least set in the 
ctor somewhere.



src/shell/interactiveconsole.cpp


this isn't a very helpful debug message :)


- David Edmundson


On Feb. 26, 2014, 3:25 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116027: High dpi support for Svg

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116027/
---

(Updated Feb. 26, 2014, 3:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

This gives support in Svg for devicePixelRatio, just exposed in the api from 
Svg side.


on the component side, it sets the devicepixelratio of the svg and framesvg 
with units.
devicepixelratio is always set integer in the svg, so needs at least 192dpi to 
double up.
(it needs to be integer to have lines contained inside a svg piece to keep 
being pixel aligned)


Diffs
-

  src/declarativeimports/core/framesvgitem.h e348c4c 
  src/declarativeimports/core/framesvgitem.cpp 1826d88 
  src/declarativeimports/core/svgitem.h c8be7cc 
  src/declarativeimports/core/svgitem.cpp e90751a 
  src/declarativeimports/plasmacomponents/qml/ToolButton.qml 2319879 
  src/plasma/framesvg.h 482956d 
  src/plasma/framesvg.cpp 9e1a53e 
  src/plasma/private/framesvg_p.h 1bbc744 
  src/plasma/private/svg_p.h 332efda 
  src/plasma/svg.h 01d98f8 
  src/plasma/svg.cpp 9ec2aa5 

Diff: https://git.reviewboard.kde.org/r/116027/diff/


Testing
---

unfortunately i can only test by hardcoding different values and check if the 
layout of the widgets stays correct, and is fine, it would be needed somebody 
with a retina screen to see it really in action


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116027: High dpi support for Svg

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116027/#review50951
---


This review has been submitted with commit 
b2fec905b597e8320cdff72678ef03c627c258ef by Marco Martin to branch master.

- Commit Hook


On Feb. 24, 2014, 5:30 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116027/
> ---
> 
> (Updated Feb. 24, 2014, 5:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This gives support in Svg for devicePixelRatio, just exposed in the api from 
> Svg side.
> 
> 
> on the component side, it sets the devicepixelratio of the svg and framesvg 
> with units.
> devicepixelratio is always set integer in the svg, so needs at least 192dpi 
> to double up.
> (it needs to be integer to have lines contained inside a svg piece to keep 
> being pixel aligned)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/framesvgitem.h e348c4c 
>   src/declarativeimports/core/framesvgitem.cpp 1826d88 
>   src/declarativeimports/core/svgitem.h c8be7cc 
>   src/declarativeimports/core/svgitem.cpp e90751a 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 2319879 
>   src/plasma/framesvg.h 482956d 
>   src/plasma/framesvg.cpp 9e1a53e 
>   src/plasma/private/framesvg_p.h 1bbc744 
>   src/plasma/private/svg_p.h 332efda 
>   src/plasma/svg.h 01d98f8 
>   src/plasma/svg.cpp 9ec2aa5 
> 
> Diff: https://git.reviewboard.kde.org/r/116027/diff/
> 
> 
> Testing
> ---
> 
> unfortunately i can only test by hardcoding different values and check if the 
> layout of the widgets stays correct, and is fine, it would be needed somebody 
> with a retina screen to see it really in action
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116024: Port IconItem to native QSGTexture

[Marco Martin]

> On Feb. 24, 2014, 4:55 p.m., Marco Martin wrote:
> > not sure how much will be visible in the end result.
> > tough if i understood correctly how it works, it does the animation by 
> > animating the opacity of the old image from 1 to 0, and the opacity of the 
> > new one from 0 to 1.
> > 
> > This is not the same thing as a crossfade, that's what it was doing.
> > I fear it will be visible the opacity of the whole result go down and then 
> > up again, especially when animating with an highlight effect (that is the 
> > same icon)
> 
> David Edmundson wrote:
> I think it should be possible to keep that behaviour, with something like 
> this patch.
> 
> I would need to create a QSGMaterialShader then copy and paste the 
> relevant fragmentShader from qtgraphicseffects. I can then put the shader 
> directly on my texture, rather than needing the extra node.
> 
> David Edmundson wrote:
> Marco can you confirm this fading looks right.
> http://paste.kde.org/p17wtna35 . It should run as a standalone in 
> qmlscene.
> 
> For comparison the old IconItem is on the right. The animations look 
> slightly different because my hacked example of the fragment shader doesn't 
> have the delay waiting for the pixmap to load.
> 
> It uses a fragmentShader to do the transition. If it's OK, I'll merge 
> this shader into the C++ code I have here as a custom material on the root 
> node.

here (ati drivers) works perfectly.
if it works correctly on intel as well, +1


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/#review50720
---


On Feb. 24, 2014, 4:09 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116024/
> ---
> 
> (Updated Feb. 24, 2014, 4:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Port IconItem to native QSGTexture including the animation.
> This will save constantly uploading a new texture to OpenGL throughout the 
> animation.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 26ee410 
>   src/declarativeimports/core/iconitem.cpp fed2f9b 
> 
> Diff: https://git.reviewboard.kde.org/r/116024/diff/
> 
> 
> Testing
> ---
> 
> Test app: http://paste.kde.org/pl5pwdnel
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116027: High dpi support for Svg

[David Edmundson]

> On Feb. 25, 2014, 11:10 a.m., David Edmundson wrote:
> > src/plasma/svg.cpp, line 132
> > 
> >
> > Do we want to have size and devicePixelRatio separate in the cache ID?
> > 
> > It means if I request 20x20 at ratio 1.0, it will have a different ID 
> > to 40x40 at ratio 2.0 despite being (as I understand it) visually identical?
> 
> Marco Martin wrote:
> the only problem is that when the svg is not scaled, instead of the 
> actual size, "Native" gets in the id instead.
> now i don't remember the reason anymore, but it breaks in that case
> 
> Marco Martin wrote:
> (/me digs down in git history)
> at that point you don't know yet what is the size of the element (or the 
> whole svg for what matters), because the renderer doesn't exist yet (and one 
> of the points of the cache is to avoid to instantiate the svg renderer 
> altogether if possible)

OK, add that comment in the code.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116027/#review50794
---


On Feb. 24, 2014, 5:30 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116027/
> ---
> 
> (Updated Feb. 24, 2014, 5:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This gives support in Svg for devicePixelRatio, just exposed in the api from 
> Svg side.
> 
> 
> on the component side, it sets the devicepixelratio of the svg and framesvg 
> with units.
> devicepixelratio is always set integer in the svg, so needs at least 192dpi 
> to double up.
> (it needs to be integer to have lines contained inside a svg piece to keep 
> being pixel aligned)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/framesvgitem.h e348c4c 
>   src/declarativeimports/core/framesvgitem.cpp 1826d88 
>   src/declarativeimports/core/svgitem.h c8be7cc 
>   src/declarativeimports/core/svgitem.cpp e90751a 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 2319879 
>   src/plasma/framesvg.h 482956d 
>   src/plasma/framesvg.cpp 9e1a53e 
>   src/plasma/private/framesvg_p.h 1bbc744 
>   src/plasma/private/svg_p.h 332efda 
>   src/plasma/svg.h 01d98f8 
>   src/plasma/svg.cpp 9ec2aa5 
> 
> Diff: https://git.reviewboard.kde.org/r/116027/diff/
> 
> 
> Testing
> ---
> 
> unfortunately i can only test by hardcoding different values and check if the 
> layout of the widgets stays correct, and is fine, it would be needed somebody 
> with a retina screen to see it really in action
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116027: High dpi support for Svg

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116027/#review50944
---

Ship it!


Ship It!

- David Edmundson


On Feb. 24, 2014, 5:30 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116027/
> ---
> 
> (Updated Feb. 24, 2014, 5:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This gives support in Svg for devicePixelRatio, just exposed in the api from 
> Svg side.
> 
> 
> on the component side, it sets the devicepixelratio of the svg and framesvg 
> with units.
> devicepixelratio is always set integer in the svg, so needs at least 192dpi 
> to double up.
> (it needs to be integer to have lines contained inside a svg piece to keep 
> being pixel aligned)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/framesvgitem.h e348c4c 
>   src/declarativeimports/core/framesvgitem.cpp 1826d88 
>   src/declarativeimports/core/svgitem.h c8be7cc 
>   src/declarativeimports/core/svgitem.cpp e90751a 
>   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 2319879 
>   src/plasma/framesvg.h 482956d 
>   src/plasma/framesvg.cpp 9e1a53e 
>   src/plasma/private/framesvg_p.h 1bbc744 
>   src/plasma/private/svg_p.h 332efda 
>   src/plasma/svg.h 01d98f8 
>   src/plasma/svg.cpp 9ec2aa5 
> 
> Diff: https://git.reviewboard.kde.org/r/116027/diff/
> 
> 
> Testing
> ---
> 
> unfortunately i can only test by hardcoding different values and check if the 
> layout of the widgets stays correct, and is fine, it would be needed somebody 
> with a retina screen to see it really in action
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Shantanu Tushar]

> On Feb. 26, 2014, 2:52 p.m., Shantanu Tushar wrote:
> > I see a weird behavior with this patch, if you follow these steps-
> > 1. Open PMC, select "All Videos"
> > 2. Press backspace to go back to home screen
> > 3. Press enter to go to "All Videos" again
> > 
> > This leads to a blank browser without anything in it. Can you verify this 
> > and fix?
> 
> Harshit Agarwal wrote:
> I seem to be unable to reproduce the error. On doing the exact same 
> steps, it goes to the 'All Videos' window, and shows the videos listed there, 
> with default focus at the search bar. To use the backspace functionality 
> again, one would have to press the down arrow key once, in order to lose 
> focus on the search bar and gain focus on the videos over there, then the 
> backspace would work to go back to the previous window.
> 
> Can you explain on the problem bit more so that it can be reproduced?
> 
> However I noticed a thing, when PMC is opened for the first time, and 
> 'All Videos' is selected, it takes around 2 seconds to load the videos with 
> their thumbnails. Probably this is the time taken for it to read the folder, 
> and then display the content. Or any anomaly here?

Hmm then it might just be because of something else I'm working on. I'll wait 
for someone else to try this out.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review50939
---


On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> ---
> 
> (Updated Feb. 26, 2014, 7:45 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Through this patch, the user can go to the previous window through the 
> backspace key also. The issue with the focus on the Search Bar has been 
> solved. The backspace option works only when the search bar is not in focus.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
> 
> 
> Testing
> ---
> 
> It has been tested.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

this ports the js interactive console from plasma1 and ports it way from 
kde4support

ui-wise it should look the same


Diffs
-

  src/shell/scripting/scriptengine.cpp 29735a0 
  src/shell/shellcorona.cpp e84e0bf 
  src/shell/shellpluginloader.cpp c57b348 
  src/shell/CMakeLists.txt db0e569 
  src/shell/interactiveconsole.h PRE-CREATION 
  src/shell/interactiveconsole.cpp PRE-CREATION 
  src/shell/packages.h 999b4c9 
  src/shell/packages.cpp 0b2aa3f 
  src/shell/scripting/layouttemplatepackagestructure.h abc5562 
  src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 

Diff: https://git.reviewboard.kde.org/r/116085/diff/


Testing
---

tried to add plasmoids from the console


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Harshit Agarwal]

> On Feb. 26, 2014, 2:52 p.m., Shantanu Tushar wrote:
> > I see a weird behavior with this patch, if you follow these steps-
> > 1. Open PMC, select "All Videos"
> > 2. Press backspace to go back to home screen
> > 3. Press enter to go to "All Videos" again
> > 
> > This leads to a blank browser without anything in it. Can you verify this 
> > and fix?

I seem to be unable to reproduce the error. On doing the exact same steps, it 
goes to the 'All Videos' window, and shows the videos listed there, with 
default focus at the search bar. To use the backspace functionality again, one 
would have to press the down arrow key once, in order to lose focus on the 
search bar and gain focus on the videos over there, then the backspace would 
work to go back to the previous window.

Can you explain on the problem bit more so that it can be reproduced?

However I noticed a thing, when PMC is opened for the first time, and 'All 
Videos' is selected, it takes around 2 seconds to load the videos with their 
thumbnails. Probably this is the time taken for it to read the folder, and then 
display the content. Or any anomaly here?


- Harshit


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review50939
---


On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> ---
> 
> (Updated Feb. 26, 2014, 7:45 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Through this patch, the user can go to the previous window through the 
> backspace key also. The issue with the focus on the Search Bar has been 
> solved. The backspace option works only when the search bar is not in focus.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
> 
> 
> Testing
> ---
> 
> It has been tested.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review50939
---


I see a weird behavior with this patch, if you follow these steps-
1. Open PMC, select "All Videos"
2. Press backspace to go back to home screen
3. Press enter to go to "All Videos" again

This leads to a blank browser without anything in it. Can you verify this and 
fix?

- Shantanu Tushar


On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> ---
> 
> (Updated Feb. 26, 2014, 7:45 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Through this patch, the user can go to the previous window through the 
> backspace key also. The issue with the focus on the Search Bar has been 
> solved. The backspace option works only when the search bar is not in focus.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
> 
> 
> Testing
> ---
> 
> It has been tested.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116024: Port IconItem to native QSGTexture

[David Edmundson]

> On Feb. 24, 2014, 4:55 p.m., Marco Martin wrote:
> > not sure how much will be visible in the end result.
> > tough if i understood correctly how it works, it does the animation by 
> > animating the opacity of the old image from 1 to 0, and the opacity of the 
> > new one from 0 to 1.
> > 
> > This is not the same thing as a crossfade, that's what it was doing.
> > I fear it will be visible the opacity of the whole result go down and then 
> > up again, especially when animating with an highlight effect (that is the 
> > same icon)
> 
> David Edmundson wrote:
> I think it should be possible to keep that behaviour, with something like 
> this patch.
> 
> I would need to create a QSGMaterialShader then copy and paste the 
> relevant fragmentShader from qtgraphicseffects. I can then put the shader 
> directly on my texture, rather than needing the extra node.

Marco can you confirm this fading looks right.
http://paste.kde.org/p17wtna35 . It should run as a standalone in qmlscene.

For comparison the old IconItem is on the right. The animations look slightly 
different because my hacked example of the fragment shader doesn't have the 
delay waiting for the pixmap to load.

It uses a fragmentShader to do the transition. If it's OK, I'll merge this 
shader into the C++ code I have here as a custom material on the root node.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/#review50720
---


On Feb. 24, 2014, 4:09 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116024/
> ---
> 
> (Updated Feb. 24, 2014, 4:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Port IconItem to native QSGTexture including the animation.
> This will save constantly uploading a new texture to OpenGL throughout the 
> animation.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 26ee410 
>   src/declarativeimports/core/iconitem.cpp fed2f9b 
> 
> Diff: https://git.reviewboard.kde.org/r/116024/diff/
> 
> 
> Testing
> ---
> 
> Test app: http://paste.kde.org/pl5pwdnel
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: javascript interactive console

[Martin Gräßlin]

On Wednesday 26 February 2014 12:56:41 Marco Martin wrote:
> On Wednesday 26 February 2014 11:36:16 Martin Gräßlin wrote:
> > On Wednesday 26 February 2014 11:27:04 Marco Martin wrote:
> > > Hi all,
> > > yesterday i was toying with porting the javascript interactive console
> > > for
> > > plasma-shell.
> > > one thing that i stumbled upon is how much dependencies the thing has.
> > > 
> > > apart the usual removal of kde4support, it depends from new things like
> > > ktexteditor,ktextbrowser etc.
> > > 
> > > so, it would bump up the dependencies of the plasma-framework repo even
> > > more and i don't really like it.
> > > so, there could be alternatives:
> > > 
> > > * rewrite it with less dependencies (tough it need kate as the editor to
> > > not suck..)
> > > * split the shell out of the repo
> > 
> > What's the reason of having the shell in the plasma-framework? Shouldn't
> > it
> > be in kde-workspace in the first place?
> 
> so, opinion poll:
> move plasma-shell to kde-workspace? (btw, is kde-workspace the final
> nameit's going to have? what is the status of the splitting it?)

Right it could be put together with the other plasma parts when splitting and 
maybe it doesn't make much sense to change anything prior to splitting.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116081: Removed unused dependencies

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116081/#review50928
---


This review has been submitted with commit 
3b7bac1e780d0440ef29ef90237fe55fd8c65ebf by Michael Palimaka to branch master.

- Commit Hook


On Feb. 26, 2014, 12:31 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116081/
> ---
> 
> (Updated Feb. 26, 2014, 12:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> I can't find references to any of these dependencies, so remove them.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 2ecfd45032613893287f0e9b8f3cc98e245fe847 
> 
> Diff: https://git.reviewboard.kde.org/r/116081/diff/
> 
> 
> Testing
> ---
> 
> Builds. Tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116081: Removed unused dependencies

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116081/
---

(Updated Feb. 26, 2014, 12:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

I can't find references to any of these dependencies, so remove them.


Diffs
-

  CMakeLists.txt 2ecfd45032613893287f0e9b8f3cc98e245fe847 

Diff: https://git.reviewboard.kde.org/r/116081/diff/


Testing
---

Builds. Tests pass.


Thanks,

Michael Palimaka

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116081: Removed unused dependencies

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116081/#review50927
---

Ship it!


Ship It!

- David Edmundson


On Feb. 26, 2014, 12:31 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116081/
> ---
> 
> (Updated Feb. 26, 2014, 12:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> I can't find references to any of these dependencies, so remove them.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 2ecfd45032613893287f0e9b8f3cc98e245fe847 
> 
> Diff: https://git.reviewboard.kde.org/r/116081/diff/
> 
> 
> Testing
> ---
> 
> Builds. Tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116081: Removed unused dependencies

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116081/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

I can't find references to any of these dependencies, so remove them.


Diffs
-

  CMakeLists.txt 2ecfd45032613893287f0e9b8f3cc98e245fe847 

Diff: https://git.reviewboard.kde.org/r/116081/diff/


Testing
---

Builds. Tests pass.


Thanks,

Michael Palimaka

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Bhushan Shah]

Hello,

On Wed, Feb 26, 2014 at 5:26 PM, Marco Martin  wrote:
> move plasma-shell to kde-workspace

IMHO No I think.. Lets see if I develop shell "Plasma ABC" I have to
pull dep of kde-workspace.. instead I prefer to have separate repo for
the shell.. :)

Thanks!

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115910: Screenedge show support for Clients

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/
---

(Updated Feb. 26, 2014, 11:57 a.m.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kde-workspace


Description
---

Screenedge show support for Clients

This provides a new protocol intended to be used by auto-hiding panels
to make use of the centralized screen edges. To use it a Client can
set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
As value it takes:
* 0: top edge
* 1: right edge
* 2: bottom edge
* 3: left edge

KWin will hide the Client (hide because unmap or minimize would break
it) and create an Edge. If that Edge gets triggered the Client is shown
again and the property gets deleted. If the Client doesn't border the
specified screen edge the Client gets shown immediately so that we
never end in a situation that we cannot unhide the auto-hidden panel
again. The exact process is described in the documentation of
ScreenEdges. The Client can request to be shown again by deleting the
property.

If KWin gets restarted the state is read from the property and it is
tried to create the edge as described.

As this is a KWin specific extension we need to discuss what it means
for Clients using this feature with other WMs: it does nothing. As
the Client gets hidden by KWin and not by the Client, it just doesn't
get hidden if the WM doesn't provide the feature. In case of an
auto-hiding panel this seems like a good solution given that we don't
want to hide it if we cannot unhide it. Of course there's the option
for the Client to provide that feature itself and if that's wanted we
would need to announce the feature in the _NET_SUPPORTED atom. At the
moment that doesn't sound like being needed as Plasma doesn't want to
provide an own implementation.

The implementation comes with a small test application showing how
the feature is intended to be used.


Diffs
-

  kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf 
  kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d 
  kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 
  kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 
  kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 
  kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f 
  kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 
  kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf 
  kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 
  kwin/tests/screenedgeshowtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115910/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Marco Martin]

On Wednesday 26 February 2014 11:36:16 Martin Gräßlin wrote:
> On Wednesday 26 February 2014 11:27:04 Marco Martin wrote:
> > Hi all,
> > yesterday i was toying with porting the javascript interactive console for
> > plasma-shell.
> > one thing that i stumbled upon is how much dependencies the thing has.
> > 
> > apart the usual removal of kde4support, it depends from new things like
> > ktexteditor,ktextbrowser etc.
> > 
> > so, it would bump up the dependencies of the plasma-framework repo even
> > more and i don't really like it.
> > so, there could be alternatives:
> > 
> > * rewrite it with less dependencies (tough it need kate as the editor to
> > not suck..)
> > * split the shell out of the repo
> 
> What's the reason of having the shell in the plasma-framework? Shouldn't it
> be in kde-workspace in the first place?

so, opinion poll:
move plasma-shell to kde-workspace? (btw, is kde-workspace the final nameit's 
going to have? what is the status of the splitting it?)

anyways, +1 from me

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115910: Screenedge show support for Clients

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/#review50924
---


This review has been submitted with commit 
74e98695445ad8f9cb11762e7a7dc5105783f20c by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 24, 2014, 10:16 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115910/
> ---
> 
> (Updated Feb. 24, 2014, 10:16 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Screenedge show support for Clients
> 
> This provides a new protocol intended to be used by auto-hiding panels
> to make use of the centralized screen edges. To use it a Client can
> set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
> As value it takes:
> * 0: top edge
> * 1: right edge
> * 2: bottom edge
> * 3: left edge
> 
> KWin will hide the Client (hide because unmap or minimize would break
> it) and create an Edge. If that Edge gets triggered the Client is shown
> again and the property gets deleted. If the Client doesn't border the
> specified screen edge the Client gets shown immediately so that we
> never end in a situation that we cannot unhide the auto-hidden panel
> again. The exact process is described in the documentation of
> ScreenEdges. The Client can request to be shown again by deleting the
> property.
> 
> If KWin gets restarted the state is read from the property and it is
> tried to create the edge as described.
> 
> As this is a KWin specific extension we need to discuss what it means
> for Clients using this feature with other WMs: it does nothing. As
> the Client gets hidden by KWin and not by the Client, it just doesn't
> get hidden if the WM doesn't provide the feature. In case of an
> auto-hiding panel this seems like a good solution given that we don't
> want to hide it if we cannot unhide it. Of course there's the option
> for the Client to provide that feature itself and if that's wanted we
> would need to announce the feature in the _NET_SUPPORTED atom. At the
> moment that doesn't sound like being needed as Plasma doesn't want to
> provide an own implementation.
> 
> The implementation comes with a small test application showing how
> the feature is intended to be used.
> 
> 
> Diffs
> -
> 
>   kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf 
>   kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d 
>   kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 
>   kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 
>   kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 
>   kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f 
>   kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 
>   kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf 
>   kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 
>   kwin/tests/screenedgeshowtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115910: Screenedge show support for Clients

[Martin Gräßlin]

> On Feb. 26, 2014, 12:18 p.m., Thomas Lübking wrote:
> > kwin/screenedge.cpp, line 179
> > 
> >
> > ElectricBorderPushbackPixels is by default "1" (and not configurable by 
> > UI)
> > Not sure if this is enough in this context as it's meant to read "i 
> > really want to go here" (notice that the re/activation thresholds can be 
> > arbitrarily low)
> > 
> > The user will likely still be moving the mouse when this happens and 
> > 1px can be crossed by even accidental judder.
> > 
> > Sth. to test (in the wild) but I assume we'll need either special 
> > pushback distance or reactivation delay.

yeah, that is something to test with and also to play with it. With my 
trackball it was OK. Though I'm not sure whether the cursor push back mattered 
or whether the reset of the activation timestamp did the trick. Somehow I think 
the latter - it clearly also protects against accidental judder.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/#review50919
---


On Feb. 24, 2014, 11:16 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115910/
> ---
> 
> (Updated Feb. 24, 2014, 11:16 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Screenedge show support for Clients
> 
> This provides a new protocol intended to be used by auto-hiding panels
> to make use of the centralized screen edges. To use it a Client can
> set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
> As value it takes:
> * 0: top edge
> * 1: right edge
> * 2: bottom edge
> * 3: left edge
> 
> KWin will hide the Client (hide because unmap or minimize would break
> it) and create an Edge. If that Edge gets triggered the Client is shown
> again and the property gets deleted. If the Client doesn't border the
> specified screen edge the Client gets shown immediately so that we
> never end in a situation that we cannot unhide the auto-hidden panel
> again. The exact process is described in the documentation of
> ScreenEdges. The Client can request to be shown again by deleting the
> property.
> 
> If KWin gets restarted the state is read from the property and it is
> tried to create the edge as described.
> 
> As this is a KWin specific extension we need to discuss what it means
> for Clients using this feature with other WMs: it does nothing. As
> the Client gets hidden by KWin and not by the Client, it just doesn't
> get hidden if the WM doesn't provide the feature. In case of an
> auto-hiding panel this seems like a good solution given that we don't
> want to hide it if we cannot unhide it. Of course there's the option
> for the Client to provide that feature itself and if that's wanted we
> would need to announce the feature in the _NET_SUPPORTED atom. At the
> moment that doesn't sound like being needed as Plasma doesn't want to
> provide an own implementation.
> 
> The implementation comes with a small test application showing how
> the feature is intended to be used.
> 
> 
> Diffs
> -
> 
>   kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf 
>   kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d 
>   kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 
>   kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 
>   kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 
>   kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f 
>   kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 
>   kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf 
>   kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 
>   kwin/tests/screenedgeshowtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115910: Screenedge show support for Clients

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/#review50919
---

Ship it!


See comment. But should be nice for a wild test =)


kwin/screenedge.cpp


ElectricBorderPushbackPixels is by default "1" (and not configurable by UI)
Not sure if this is enough in this context as it's meant to read "i really 
want to go here" (notice that the re/activation thresholds can be arbitrarily 
low)

The user will likely still be moving the mouse when this happens and 1px 
can be crossed by even accidental judder.

Sth. to test (in the wild) but I assume we'll need either special pushback 
distance or reactivation delay.


- Thomas Lübking


On Feb. 24, 2014, 10:16 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115910/
> ---
> 
> (Updated Feb. 24, 2014, 10:16 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Screenedge show support for Clients
> 
> This provides a new protocol intended to be used by auto-hiding panels
> to make use of the centralized screen edges. To use it a Client can
> set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
> As value it takes:
> * 0: top edge
> * 1: right edge
> * 2: bottom edge
> * 3: left edge
> 
> KWin will hide the Client (hide because unmap or minimize would break
> it) and create an Edge. If that Edge gets triggered the Client is shown
> again and the property gets deleted. If the Client doesn't border the
> specified screen edge the Client gets shown immediately so that we
> never end in a situation that we cannot unhide the auto-hidden panel
> again. The exact process is described in the documentation of
> ScreenEdges. The Client can request to be shown again by deleting the
> property.
> 
> If KWin gets restarted the state is read from the property and it is
> tried to create the edge as described.
> 
> As this is a KWin specific extension we need to discuss what it means
> for Clients using this feature with other WMs: it does nothing. As
> the Client gets hidden by KWin and not by the Client, it just doesn't
> get hidden if the WM doesn't provide the feature. In case of an
> auto-hiding panel this seems like a good solution given that we don't
> want to hide it if we cannot unhide it. Of course there's the option
> for the Client to provide that feature itself and if that's wanted we
> would need to announce the feature in the _NET_SUPPORTED atom. At the
> moment that doesn't sound like being needed as Plasma doesn't want to
> provide an own implementation.
> 
> The implementation comes with a small test application showing how
> the feature is intended to be used.
> 
> 
> Diffs
> -
> 
>   kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf 
>   kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d 
>   kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 
>   kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 
>   kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 
>   kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f 
>   kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 
>   kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf 
>   kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 
>   kwin/tests/screenedgeshowtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Michael Palimaka]

On 02/26/2014 09:36 PM, Martin Gräßlin wrote:
> On Wednesday 26 February 2014 11:27:04 Marco Martin wrote:
>> Hi all,
>> yesterday i was toying with porting the javascript interactive console for
>> plasma-shell.
>> one thing that i stumbled upon is how much dependencies the thing has.
>>
>> apart the usual removal of kde4support, it depends from new things like
>> ktexteditor,ktextbrowser etc.
>>
>> so, it would bump up the dependencies of the plasma-framework repo even more
>> and i don't really like it.
>> so, there could be alternatives:
>>
>> * rewrite it with less dependencies (tough it need kate as the editor to not
>> suck..)
>> * split the shell out of the repo
> 
> What's the reason of having the shell in the plasma-framework? Shouldn't it 
> be 
> in kde-workspace in the first place?

Indeed, and it even autostarts it: /etc/xdg/autostart/plasma-shell.desktop



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: javascript interactive console

[Martin Gräßlin]

On Wednesday 26 February 2014 11:27:04 Marco Martin wrote:
> Hi all,
> yesterday i was toying with porting the javascript interactive console for
> plasma-shell.
> one thing that i stumbled upon is how much dependencies the thing has.
> 
> apart the usual removal of kde4support, it depends from new things like
> ktexteditor,ktextbrowser etc.
> 
> so, it would bump up the dependencies of the plasma-framework repo even more
> and i don't really like it.
> so, there could be alternatives:
> 
> * rewrite it with less dependencies (tough it need kate as the editor to not
> suck..)
> * split the shell out of the repo

What's the reason of having the shell in the plasma-framework? Shouldn't it be 
in kde-workspace in the first place?

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

javascript interactive console

[Marco Martin]

Hi all,
yesterday i was toying with porting the javascript interactive console for 
plasma-shell.
one thing that i stumbled upon is how much dependencies the thing has.

apart the usual removal of kde4support, it depends from new things like 
ktexteditor,ktextbrowser etc.

so, it would bump up the dependencies of the plasma-framework repo even more 
and i don't really like it.
so, there could be alternatives:

* rewrite it with less dependencies (tough it need kate as the editor to not 
suck..)
* split the shell out of the repo
* move the console in another process, but there may be too much that would 
have to be exposed trough dbus for that

opinion, comments?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50911
---


+1 from me

- Marco Martin


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50910
---


+1 from me

- Marco Martin


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Kevin Krammer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50909
---



src/platformtheme/kdeplatformsystemtrayicon.h


remove virtual and add Q_DECL_OVERRIDE?
or change the signature at SystemTrayMenu?
currently that is a bit inconsistent :)



src/platformtheme/kdeplatformsystemtrayicon.h


see above



src/platformtheme/kdeplatformsystemtrayicon.cpp


I see lambdas being using later on, in which case this looks like a 
candidate for std::find_if() with a lambda predicate


- Kevin Krammer


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115910: Screenedge show support for Clients

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/#review50907
---


@Thomas: any further comments on the latest approach?

- Martin Gräßlin


On Feb. 24, 2014, 11:16 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115910/
> ---
> 
> (Updated Feb. 24, 2014, 11:16 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Screenedge show support for Clients
> 
> This provides a new protocol intended to be used by auto-hiding panels
> to make use of the centralized screen edges. To use it a Client can
> set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
> As value it takes:
> * 0: top edge
> * 1: right edge
> * 2: bottom edge
> * 3: left edge
> 
> KWin will hide the Client (hide because unmap or minimize would break
> it) and create an Edge. If that Edge gets triggered the Client is shown
> again and the property gets deleted. If the Client doesn't border the
> specified screen edge the Client gets shown immediately so that we
> never end in a situation that we cannot unhide the auto-hidden panel
> again. The exact process is described in the documentation of
> ScreenEdges. The Client can request to be shown again by deleting the
> property.
> 
> If KWin gets restarted the state is read from the property and it is
> tried to create the edge as described.
> 
> As this is a KWin specific extension we need to discuss what it means
> for Clients using this feature with other WMs: it does nothing. As
> the Client gets hidden by KWin and not by the Client, it just doesn't
> get hidden if the WM doesn't provide the feature. In case of an
> auto-hiding panel this seems like a good solution given that we don't
> want to hide it if we cannot unhide it. Of course there's the option
> for the Client to provide that feature itself and if that's wanted we
> would need to announce the feature in the _NET_SUPPORTED atom. At the
> moment that doesn't sound like being needed as Plasma doesn't want to
> provide an own implementation.
> 
> The implementation comes with a small test application showing how
> the feature is intended to be used.
> 
> 
> Diffs
> -
> 
>   kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf 
>   kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d 
>   kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 
>   kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 
>   kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 
>   kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f 
>   kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 
>   kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf 
>   kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 
>   kwin/tests/screenedgeshowtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Thomas Braxton]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50904
---



src/platformtheme/kdeplatformsystemtrayicon.cpp


couldn't this be replaced with m_items.removeOne(ours) ?


- Thomas Braxton


On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated Feb. 26, 2014, 8:09 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---

Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: frameworkintegration


Description
---

Add menu support to KDEPlatformSystemTrayIcon

Uses new QPA API which got introduced in Qt 5.3.

Provide an implementation for QPlatformSystemTrayIcon

The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.

The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.

This is adressed in Qt 5.3 which extends the QPA API.


Diffs
-

  autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
  src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
  src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
  src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
  src/platformtheme/kdeplatformtheme.cpp 
a5d86c27385447b7744cb8bca0cf65889872fb0b 

Diff: https://git.reviewboard.kde.org/r/116075/diff/


Testing
---

Using systray from qtbase/examples/widgets/desktop/systray


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel