Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- (Updated March 16, 2014, 6:09 a.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The Play All button when clicked multiple times, was adding all the media multiple times onto the playlist. This is resolved, and now it adds the media only single time if the button is clicked multiple times. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 8aaddcc browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116824/diff/ Testing --- It has been tested with the local files in Music as well as the Videos section. Patch found to be consistent. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
On March 15, 2014, 7:44 p.m., Shantanu Tushar wrote: browsingbackends/localfiles/localfilesabstractbackend.cpp, line 169 https://git.reviewboard.kde.org/r/116554/diff/2/?file=254194#file254194line169 0 won't work when there are already some itmes in the playlist before addAllSongsToPlaylist is called. Harshit Agarwal wrote: As discussed, it's working fine, I tested it such: 1. Empty playlist, press PlayAll, songs get populated to the playlist, and the first one starts playing. 2. With the playlist having songs, pressed PlayAll for a different list. The songs get pushed to the playlist, and the current song plays without any interrupt. 3. With no song playing, pressed PlayAll in a third folder, the songs again get pushed to the playlist, and the playback starts from the top of the playlist. (This behaviour is correct, right?) #2 and #3 both should play the first song of the *new* song list that the user has added. So if there were 5 songs already and you added 10 more songs, 6th song should start playing. - Shantanu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53000 --- On March 15, 2014, 6:21 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 15, 2014, 6:21 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 9:30 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Implemented the thing pointed out by Shantanu. Now the media plays from the point where it is added. That is, it starts playing the new PlayAll media when it is clicked, even when there is media present in the playlist before. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:29 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Apologies for the wrong patch. That did not contain a line. Please review this instead. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Alpha delayed
Hey, We've looked over what would be needed to tag Plasma Next Alpha1 this week, and found it not feasible due to too much moving code. Please refer to the reasoning in my email subj: Delaying the Alpha1?. The plan is to get missing stuff in right now, and tag Plasma Next Alpha 1 shortly after KF5 Beta is out. Then release. That puts it into the first week of April. http://techbase.kde.org/Schedules/Plasma/2014.6_Release_Schedule has been adjusted accordingly. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53040 --- browsingbackends/localfiles/localfilesabstractbackend.cpp https://git.reviewboard.kde.org/r/116554/#comment37339 const int in shells/newshell/package/contents/ui/mediacenter.qml https://git.reviewboard.kde.org/r/116554/#comment37338 now that you are loading the playlist in init(), this call in play() is no longer needed. Remove it as well (and do confirm that files passed through command line still work) - Shantanu Tushar On March 16, 2014, 10:29 a.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:29 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/ --- Review request for Plasma and Sebastian Kügler. Repository: kde-workspace Description --- This patch expands the search results list to cover the entire height (or horizontal space in case of left/right panel) of the plasmoid since the tabbar is hidden and it looks weird to reserve space for something that isn't there at the moment. It also animates the re-appearance of the tabbar. Disappearance/Opacity of the tabbar is not animated due to performance reasons (got heavy lagging). Diffs - plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml bfb1d16 Diff: https://git.reviewboard.kde.org/r/116836/diff/ Testing --- Tested in bottom, top, left and right panel and repeatedly typed in characters and removed them again :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/#review53066 --- Overall, good idea. I just noticed this the other day that this was wrong. I'm pondering also to not show the tabbar, b/c I think it's still useful to switch tabs with open search results. Also, search doesn't clear right now (it should), so the tabbar being shown is a bit more apparent than it used to be. Overall, almost good to go. Thanks for looking into this. plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml https://git.reviewboard.kde.org/r/116836/#comment37378 This is going to raise a warning b/c you're assigning undefined to an int, no? Returning 0 here is fine and avoids that warning. Same for the height. plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml https://git.reviewboard.kde.org/r/116836/#comment37379 Warning. :) - Sebastian Kügler On March 16, 2014, 3:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/ --- (Updated March 16, 2014, 3:54 p.m.) Review request for Plasma and Sebastian Kügler. Repository: kde-workspace Description --- This patch expands the search results list to cover the entire height (or horizontal space in case of left/right panel) of the plasmoid since the tabbar is hidden and it looks weird to reserve space for something that isn't there at the moment. It also animates the re-appearance of the tabbar. Disappearance/Opacity of the tabbar is not animated due to performance reasons (got heavy lagging). Diffs - plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml bfb1d16 Diff: https://git.reviewboard.kde.org/r/116836/diff/ Testing --- Tested in bottom, top, left and right panel and repeatedly typed in characters and removed them again :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106118/#review53068 --- Please either commit or discard or mark as committed, whatever applies. - Sebastian Kügler On Feb. 12, 2013, 12:26 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106118/ --- (Updated Feb. 12, 2013, 12:26 p.m.) Review request for kwin, Plasma, Martin Gräßlin, Sebastian Kügler, and Giorgos Tsiapaliokas. Repository: plasmate Description --- Hello, This patch is adding the konsolepreviewer support to the KWin Scripts. When the user, is pressing the Execute button, then the script is being called. Also on the toolbar, there is a new action with name konsole. This action is visible only when we are inside to a KWin Script. All the other packages, have a previewer. So the konsole action is located inside the previewer. Diffs - plasmate/konsole/konsolepreviewer.h 8dd4369 plasmate/konsole/konsolepreviewer.cpp 7e180cb plasmate/mainwindow.h 4daaaea plasmate/mainwindow.cpp 7a96925 Diff: https://git.reviewboard.kde.org/r/106118/diff/ Testing --- Screenshots --- konsole https://git.reviewboard.kde.org/r/106118/s/693/ Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Meta key and Qt (Re: kglobalaccel fixes)
On Tuesday 11 March 2014 13:54:56 Sebastian Kügler wrote: One thing is a bit puzzling, perhaps someone knows how to go about this: The meta key behaves different now, when I edit a shortcut, it's accepted as soon as I press the meta key, so it's not seen as a modifier, but as a key of its own. This means that one can effectively (through the GUI) only assign meta to an action, but not, for example meta+arrow_left. Any ideas how to best fix this? Could be a bug in the XKB code inside Qt. I tried to look into it, but how do you actually get a meta key in the first place? I tried rebinding the Windows key to Meta in xmodmap [*], and it works in `xev`, but the keyval in Qt is Qt::Key_Multi_key which activates compose sequences in this file: qtbase/src/plugins/platforminputcontexts/compose/qcomposeplatforminputcontext.cpp Looks like this code works on keycodes, not keysyms, so it basically ignores my xmodmap configuration. [*] keycode 133 = Meta_L Meta_L Meta_L Meta_L -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)
On March 16, 2014, 4:11 p.m., Sebastian Kügler wrote: plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml, line 185 https://git.reviewboard.kde.org/r/116836/diff/1/?file=254503#file254503line185 This is going to raise a warning b/c you're assigning undefined to an int, no? Returning 0 here is fine and avoids that warning. Same for the height. Yeah made me suspicious that the original code (in the switch default) did that which I just adopted - I guess they know what they're doing mode - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/#review53066 --- On March 16, 2014, 3:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/ --- (Updated March 16, 2014, 3:54 p.m.) Review request for Plasma and Sebastian Kügler. Repository: kde-workspace Description --- This patch expands the search results list to cover the entire height (or horizontal space in case of left/right panel) of the plasmoid since the tabbar is hidden and it looks weird to reserve space for something that isn't there at the moment. It also animates the re-appearance of the tabbar. Disappearance/Opacity of the tabbar is not animated due to performance reasons (got heavy lagging). Diffs - plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml bfb1d16 Diff: https://git.reviewboard.kde.org/r/116836/diff/ Testing --- Tested in bottom, top, left and right panel and repeatedly typed in characters and removed them again :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116796: Show brightness OSD only on user input
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/ --- (Updated March 16, 2014, 10:20 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- As discussed at the Plasma sprint, we want to show the OSD only on user input as a way of feedback to the action the user just did. Diffs - powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 228645b Diff: https://git.reviewboard.kde.org/r/116796/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:08 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- const (Something I need to remember always :P) As for the dual getPlaylist() call, I substituted it with getMediaPlayer(), so the effect remains the same, while avoiding to load the playlist twice, and the media can be played through the command line (tested). Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml bac33c2 browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Testing a plasmoid with local installation / solved
SOLVED. By issuing this command... export KDEDIRS=$DEVUSR:`kde4-config --prefix` ...the local version of the plasmoid is used. It is the third option given by the tutorial [1], section Testing the Applet. Gregor [1] http://techbase.kde.org/Development/Tutorials/Plasma/GettingStarted On 09/03/14 22:28, Gregor Mi wrote: Hi, I would like to install a (KDE4) plasmoid locally to test it with plasmoidviewer. As example I use kdeplasma-addons/applets/showdesktop/ from https://projects.kde.org/projects/kde/kdeplasma-addons I did the following setup $ cd src/kdeplasma-addons $ mkdir build $ cd build $ . home-kde4-env-setup # which sets DEVUSR, XDG_DATA_DIRS, PATH, # LD_LIBRARY_PATH, CMAKE_PREFIX_PATH # DEVUSR is my local usr directory $ cmake .. -DCMAKE_INSTALL_PREFIX=$DEVUSR $ make install $ plasmapkg --list | grep desktop lists showdesktop. This is the original (system installed) one, because kbuildsycoca4 was not called yet. To make sure that the original plasmoid is not found by the next command I moved the file /usr/share/kde4/services/plasma-applet-showdesktop.desktop away. Now: $ kbuildsycoca4 $ plasmapkg --list | grep desktop This does NOT show the locally installed plasmoid. So I am a little lost here. What conditions must hold so that kbuildsycoca4 finds the locally installed files (.desktop and .so) to make them available for plasmapkg? Thanks for any hint. Gregor ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
