Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

[Bhushan Shah]

> On March 26, 2014, 11:39 p.m., Alex Merry wrote:
> > All looks sane.  Is this Qt4 or Qt5?  Because you've got a KUrl in the 
> > added code...

Qt4


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review54220
---


On March 26, 2014, 10:53 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> ---
> 
> (Updated March 26, 2014, 10:53 p.m.)
> 
> 
> Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, 
> Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma 
> Mediacenter.
> Specification reference: 
> http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> 
> Some more work needs to be done in the adaptor which I plan to do soon.
> 
> 
> Diffs
> -
> 
>   libs/mpris2/mediaplayer2.h e68bc5c 
>   libs/mpris2/mediaplayer2.cpp ff96618 
>   libs/mpris2/mediaplayer2player.h 203d681 
>   libs/mpris2/mediaplayer2player.cpp 7871efa 
>   libs/mpris2/mpris2.cpp a8ad3ef 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   shells/newshell/mainwindow.cpp d2d71d4 
>   shells/newshell/package/contents/ui/mediacenter.qml bac33c2 
> 
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
> 
> 
> Testing
> ---
> 
> Tested with qdbusviewer, the properties and methods are working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117101: This patch fixes font size behaviour when pmc is resized.

[Nikolaos Chatzidakis]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117101/
---

Review request for Plasma and Shantanu Tushar.


Repository: plasma-mediacenter


Description
---

This is my first patch trying to hack PMC. Untill now, whenever PMC was 
resized, the menu strings font size remained fixed. Now it changes the font 
size according to parents dimensions.


Diffs
-

  mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 
  mediaelements/mediawelcome/MediaWelcome.qml a3108d8 

Diff: https://git.reviewboard.kde.org/r/117101/diff/


Testing
---

The size of the icons in the menus remains the same, due to the file format 
(png). Converting these graphics to SVG may solve the graphics resize issue as 
well.


Thanks,

Nikolaos Chatzidakis

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: technology demonstration release 2

[Aleix Pol]

On Tue, Mar 25, 2014 at 7:58 PM, Aleix Pol  wrote:

> n Tue, Mar 25, 2014 at 7:01 PM, Marco Martin  wrote:
>
>> On Tuesday 25 March 2014, Jonathan Riddell wrote:
>> > Good day Plasma
>> >
>> > There is a Technology demonstration release 2 due next week according
>> > to http://community.kde.org/Plasma/Next#Time_Based_Goals .  Sebas is
>> > away and has asked that I help out with release management.  Would
>> > that be welcomed?
>>
>> +100 :)
>>
>> > What needs released?  Seems to be Comme Font (was Oxygen Font,
>> > annoyingly I can't get it to compile without FontForge segfaulting),
>> > kde-runtime and kde-workspace.  Except kde-runtime and kde-workspace
>> > are being split up, is there any plan written down for what happening
>> > to them?
>>
>> iirc Aleix had plans on doing the split for end week?
>>
> Yes, kde-workspace should happen this week. kde-runtime I would say next
> but that's not part of the release I think.
>
>
>>
>> > Am I right in thinking that kde-runtime should be co-installable with
>> > the equivalent from kdelibs4 land?  This probably needs quite a lot of
>> > bits renaming. (I've started on kglobalaccel
>> > https://git.reviewboard.kde.org/r/116956/).
>>
>> i *think* so, can anybody else confirm?
>>
> kde-runtime probably should be yes. I would suggest to do this work after
> the split. It will be more clear what goes where.
>
>
>>
>> > Am I right in thinking that kde-workspace doesn't need to be
>> > coinstallable with kdelibs4 equivalent?
>>
>
>> kde-workspace definitely doesn't need to.
>>
>> --
>> Marco Martin
>> ___
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>
> Aleix
>

Alright, then it is. I thought that it wasn't given the lack of attention
it has received.

Either way, we're still moving things out of kde-runtime to frameworks,
then we'll split the directories wherever it has to go.

I would suggest you to use the dependency-data-kf5-qt5 from
kde-build-metadata. There we're documenting what depends on what entirely.
I'm unsure whether it's part of the packaging and distribution process yet.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review54220
---


All looks sane.  Is this Qt4 or Qt5?  Because you've got a KUrl in the added 
code...

- Alex Merry


On March 26, 2014, 5:23 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> ---
> 
> (Updated March 26, 2014, 5:23 p.m.)
> 
> 
> Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, 
> Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma 
> Mediacenter.
> Specification reference: 
> http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> 
> Some more work needs to be done in the adaptor which I plan to do soon.
> 
> 
> Diffs
> -
> 
>   libs/mpris2/mediaplayer2.h e68bc5c 
>   libs/mpris2/mediaplayer2.cpp ff96618 
>   libs/mpris2/mediaplayer2player.h 203d681 
>   libs/mpris2/mediaplayer2player.cpp 7871efa 
>   libs/mpris2/mpris2.cpp a8ad3ef 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   shells/newshell/mainwindow.cpp d2d71d4 
>   shells/newshell/package/contents/ui/mediacenter.qml bac33c2 
> 
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
> 
> 
> Testing
> ---
> 
> Tested with qdbusviewer, the properties and methods are working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/
---

(Updated March 26, 2014, 10:53 p.m.)


Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, 
Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
---

Made necessary changes.


Repository: plasma-mediacenter


Description
---

Implemented "Player" DBus adaptor of MPRIS specifications for Plasma 
Mediacenter.
Specification reference: 
http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html

Some more work needs to be done in the adaptor which I plan to do soon.


Diffs (updated)
-

  libs/mpris2/mediaplayer2.h e68bc5c 
  libs/mpris2/mediaplayer2.cpp ff96618 
  libs/mpris2/mediaplayer2player.h 203d681 
  libs/mpris2/mediaplayer2player.cpp 7871efa 
  libs/mpris2/mpris2.cpp a8ad3ef 
  mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
  shells/newshell/mainwindow.cpp d2d71d4 
  shells/newshell/package/contents/ui/mediacenter.qml bac33c2 

Diff: https://git.reviewboard.kde.org/r/116907/diff/


Testing
---

Tested with qdbusviewer, the properties and methods are working fine.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

[R.Harish Navnit]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---

(Updated March 26, 2014, 4 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
---

Checked with the playlistModel.currentIndex. Now, Songs do not play when the 
next button is pressed, which solves the issue, but the currentIndex gets 
incremented(expected behaviour ?)


Bugs: 330990 and Bug
http://bugs.kde.org/show_bug.cgi?id=330990
http://bugs.kde.org/show_bug.cgi?id=Bug


Repository: plasma-mediacenter


Description
---

Now the next and previous buttons do not work unless a media is playing. 


Diffs (updated)
-

  mediaelements/playlist/Playlist.qml fd83c21 

Diff: https://git.reviewboard.kde.org/r/116874/diff/


Testing
---

I've done the testing for this patch.

These are the steps that I followed. 
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center 
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous buttons.
6. The buttons worked seamlessly.  


Thanks,

R.Harish  Navnit

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review54208
---


I have general feedback around the code below. It will be nice if you can poke 
someone who has written MPRIS-related code before to review this before 
finalizing.


libs/mpris2/mediaplayer2.cpp


This would look better-

QDBusConnection::sessionBus().registerObject("/org/mpris/MediaPlayer2", 
this, 
QDBusConnection::ExportAllSlots |
QDBusConnection::ExportAllProperties |
QDBusConnection::ExportAllSignals);



libs/mpris2/mediaplayer2player.h


Are these supposed to be called on this object from outside? If yes, why 
are these protected? If no, why Q_INVOKABLE?



libs/mpris2/mediaplayer2player.cpp


How is 64 decided?



libs/mpris2/mediaplayer2player.cpp


if and else need braces, even when single-line, see 
http://techbase.kde.org/Policies/Kdelibs_Coding_Style



libs/mpris2/mediaplayer2player.cpp


const int



shells/newshell/mainwindow.cpp


whitespace



shells/newshell/package/contents/ui/mediacenter.qml


instead of this, can't you use onPlayRequested instead? Its better to avoid 
dependencies for components (In this case Playlist requires a mprisPlayer to 
work).


- Shantanu Tushar


On March 26, 2014, 6:46 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> ---
> 
> (Updated March 26, 2014, 6:46 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
> Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma 
> Mediacenter.
> Specification reference: 
> http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> 
> Some more work needs to be done in the adaptor which I plan to do soon.
> 
> 
> Diffs
> -
> 
>   libs/mpris2/mpris2.cpp a8ad3ef 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   mediaelements/playlist/Playlist.qml 5dde297 
>   shells/newshell/mainwindow.cpp d2d71d4 
>   shells/newshell/package/contents/ui/mediacenter.qml bac33c2 
>   libs/mpris2/mediaplayer2.h e68bc5c 
>   libs/mpris2/mediaplayer2.cpp ff96618 
>   libs/mpris2/mediaplayer2player.h 203d681 
>   libs/mpris2/mediaplayer2player.cpp 7871efa 
> 
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
> 
> 
> Testing
> ---
> 
> Tested with qdbusviewer, the properties and methods are working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Please report KWin bugs against KWin

[Martin Gräßlin]

On Wednesday 26 March 2014 14:44:51 Sebastian Kügler wrote:
> On Wednesday, March 26, 2014 14:27:03 Martin Gräßlin wrote:
> > On Wednesday 26 March 2014 13:16:21 Sebastian Kügler wrote:
> > > On Wednesday, March 26, 2014 11:01:42 Marco Martin wrote:
> > > > i see the plasma-shell component is again becoming a catch-all
> > > > dumpster
> > > > and
> > > 
> > > We definitely need a way though to get an overview of all the bugs
> > > relevant
> > > to the next release, otherwise, we're going to make bugzilla a
> > > blackhole.
> > > 
> > > 
> > > 
> > > Are keywords suitable for that?
> > 
> > Sounds like a lot of manual work, maybe we can just create a suited
> > search?
> > 
> > Have a look at the "Plasma-workspace 1.0" search I just created and
> > shared.
> > 
> > This is a query of all bugs against plasma-shell with target milestone 1.0
> > and  kwin with target milestone 5.
> > 
> > Clicked together through the advanced search.
> 
> How can I find it?

Like all others: Preferences -> Saved Searches

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please report KWin bugs against KWin

[Bhushan Shah]

On Wed, Mar 26, 2014 at 7:14 PM, Sebastian Kügler  wrote:
> How can I find it?


https://bugs.kde.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=Plasma-workspace%201.0&sharer_id=84780&list_id=951398

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please report KWin bugs against KWin

[Sebastian Kügler]

On Wednesday, March 26, 2014 14:27:03 Martin Gräßlin wrote:
> On Wednesday 26 March 2014 13:16:21 Sebastian Kügler wrote:
> > On Wednesday, March 26, 2014 11:01:42 Marco Martin wrote:
> > > i see the plasma-shell component is again becoming a catch-all dumpster
> > > and
> >
> > 
> >
> > We definitely need a way though to get an overview of all the bugs
> > relevant
> > to the next release, otherwise, we're going to make bugzilla a blackhole.
> >
> > 
> >
> > Are keywords suitable for that?
> 
> Sounds like a lot of manual work, maybe we can just create a suited search?
> 
> Have a look at the "Plasma-workspace 1.0" search I just created and shared.
> 
> This is a query of all bugs against plasma-shell with target milestone 1.0
> and  kwin with target milestone 5.
> 
> Clicked together through the advanced search.

How can I find it?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Please report KWin bugs against KWin

[Martin Gräßlin]

On Wednesday 26 March 2014 13:16:21 Sebastian Kügler wrote:
> On Wednesday, March 26, 2014 11:01:42 Marco Martin wrote:
> > i see the plasma-shell component is again becoming a catch-all dumpster
> > and
> 
> We definitely need a way though to get an overview of all the bugs relevant
> to the next release, otherwise, we're going to make bugzilla a blackhole.
> 
> Are keywords suitable for that?

Sounds like a lot of manual work, maybe we can just create a suited search?

Have a look at the "Plasma-workspace 1.0" search I just created and shared.

This is a query of all bugs against plasma-shell with target milestone 1.0 and 
kwin with target milestone 5.

Clicked together through the advanced search.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: technology demonstration release 2

[Sebastian Kügler]

On Tuesday, March 25, 2014 19:02:07 Jonathan Riddell wrote:
> On Tue, Mar 25, 2014 at 07:58:21PM +0100, Aleix Pol wrote:
> >Yes, kde-workspace should happen this week. kde-runtime I would say
> >next but that's not part of the release I think.
> 
> How can kde-runtime not be part of the release, it won't be very
> funcational without it surely?

I'm puzzled by that, too.

Maybe Aleix meant that it's split up by then? Otherwise, the Alpha won't be 
very useful (namely entirely useless).

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please report KWin bugs against KWin

[Sebastian Kügler]

On Wednesday, March 26, 2014 11:01:42 Marco Martin wrote:
> i see the plasma-shell component is again becoming a catch-all dumpster and 

We definitely need a way though to get an overview of all the bugs relevant to 
the next release, otherwise, we're going to make bugzilla a blackhole.

Are keywords suitable for that?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115409: Workaround battery detection at runtime

[Kai Uwe Broulik]

> On March 7, 2014, 12:19 p.m., Christoph Feck wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 
> > 75
> > 
> >
> > Removal of this causes two other regressions: bug 331797, bug 331831.
> > 
> > I re-added the "onDataChanged:" handling and both bugs are gone, but I 
> > only have a single battery, so I cannot test if bug 324847 is still fixed.
> 
> Kai Uwe Broulik wrote:
> Sorry for the inconvenience :-(
> 
> Will try to test your patch [1] tomorrow.
> 
> [1] http://bugsfiles.kde.org/attachment.cgi?id=85464
>
> 
> Christoph Feck wrote:
> Don't worry :) The regressions are minor, and to be honest, I would 
> prefer  to not commit my patch, unless we find a way to get both bug 321823 
> and the regressions fixed.
> 
> Kai Uwe Broulik wrote:
> Just tested it, plugged in and out my mouse multiple times and it appears 
> and re-appears, and also the tooltip (which is reported broken in Bug 324847 
> Comment 19) seems properly updated.
> 
> Go ahead and push it, thanks for taking care of this! :-)
> 
> Christoph Feck wrote:
> But then we would get bug 321823 again...

I think showing wrong brightness (0%) is worse than the auto-closing popup with 
Ac plugged in and battery charged and the thing hidden in the popup.
I'm seeing a lot of posts about this regression on G+ and other sources lately.
So, please push. :/

Plasma Next should fix the Bug 321823 for us at least I guess.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115409/#review52338
---


On Feb. 15, 2014, 10:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115409/
> ---
> 
> (Updated Feb. 15, 2014, 10:19 p.m.)
> 
> 
> Review request for Plasma, Solid and Sebastian Kügler.
> 
> 
> Bugs: 324847
> http://bugs.kde.org/show_bug.cgi?id=324847
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> For some reason when a new battery appears (eg. mouse plugged in), the 
> battery does not appear right away in the battery monitor. It appears 
> instantly in plasmaengineexplorer, however.
> I am really clueless on to what causes this, so I just throw this patch in 
> for enlightenment as it sort of makes it work. :/
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 
> c1c0169 
> 
> Diff: https://git.reviewboard.kde.org/r/115409/diff/
> 
> 
> Testing
> ---
> 
> Has some minor glitches, please see bugreport.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116956/
---

(Updated March 26, 2014, 11:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Runtime, Plasma and Martin Gräßlin.


Repository: kde-runtime


Description
---

kde-runtime will soon get an alpha release.  Because both KF5 and kdelibs4 
applications should be able to be installed and run it should be co-installable 
with kde-runtime from KDE 4 times.  Starting at the top of the cmake file I've 
renamed kglobalaccel to see if it's sane to do so.


Diffs
-

  kglobalaccel/CMakeLists.txt e0b739f 
  kglobalaccel/kglobalaccel.desktop a61516e 
  kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 

Diff: https://git.reviewboard.kde.org/r/116956/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please report KWin bugs against KWin

[Harald Sitter]

On Wed, Mar 26, 2014 at 12:28 PM, David Edmundson
 wrote:
> Where do we want bugs for the KCMs in kde-workspace/plasma-desktop/kcms
>
> Currently they are all grouped under systemsettings in bugzilla.
> Should I add a new version there?

random note of the day:
help->report bug should bring you to the systemsettings product on
bugs.kde, so adding a new version there would probably be the most
sensible thing.

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please report KWin bugs against KWin

[David Edmundson]

Where do we want bugs for the KCMs in kde-workspace/plasma-desktop/kcms

Currently they are all grouped under systemsettings in bugzilla.
Should I add a new version there?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

kde-workspace split incoming!

[Àlex Fiestas]

Hi everybody!

We are done doing CMake on kde-workspace so we have asked sysadmin team  to 
create the new repositories. Once that's done we will freeze kde-
workspace/master and proceed to split and setup everything (kdesrc-build, 
build.kde.org etc).

We will try to send a last reminder of the freeze just before it happens (I 
guess sysadmins will do so anyway) so you can be prepared for it.

cheers!

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please report KWin bugs against KWin

[Marco Martin]

On Wednesday 26 March 2014 07:53:25 Martin Gräßlin wrote:
> Hi all,
> 
> just a small reminder: please report KWin bugs against KWin. It's not
> plasma- shell and it makes the work of the KWin team way more difficult if
> those bugs get reported to plasma-shell or end up being assigned to me.

yes, this is important.
i see the plasma-shell component is again becoming a catch-all dumpster and 
that's will only make sure the plasma1 situation is repeated
such as a ksmserver bug:
https://bugs.kde.org/show_bug.cgi?id=332140
and please, please check for duplicated before reporting:
https://bugs.kde.org/show_bug.cgi?id=332510
(still the same one)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Fwd: debuggind keypress event handling in the plasmoid

[Marek Kochanowicz]

Dnia wtorek, 25 marca 2014 15:17:37 Myriam Schweingruber pisze:
> I presume since this is about Plasma it should go to the Plasma-devel
> mailinglist...
Yes thanks!
> 
> A fork? What fork?
> 
It is not public yet. Once it will be not pure hack on top of the current 
codei will publish it.

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

[Dominik Haumann]

> On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> > The frameworks version is ready, but the GUI is a complete rewrite as in 
> > Plasma 2, C++ plasmoids are not supported.
> > 
> > Personally, I don't think these options are needed:
> > 1. I've never had a problem with accidentally sharing anything.
> > 2. the plasmoid should have enough resources to know what size it should 
> > be. I would prefer a saner default.
> > 
> > Regarding the group, you should use plasma.
> 
> Gregor Mi wrote:
> 1. This is why I made it an option. :)
> In my opinion, potentially private data should not be send to the 
> internet without given the user the chance to know what is happening. When I 
> was using pastebin the first time I was a bit surprised how quick the data 
> went away.
> Advanced users can easily disable this option. With the "do not ask 
> again" method suggested by Dominik it should not hurt at all.
> 
> 2. Are you referring to the default width (or height) of 22.0 pixels? Or 
> the widget geometry in general? Do you already have a "saner default" in mind?
> 
> > complete rewrite as in Plasma 2, C++ plasmoids are not supported
> Is plasma2 going to be released with KDE frameworks 5? Because there are 
> still many c++ applets in the frameworks branch. So all of them have to be 
> rewritten?
>
> 
> Aleix Pol Gonzalez wrote:
> 1. So you mean that only advanced users care about sharing too much data?
> 2. Well, I guess you added this option because the applet became huge, 
> right?
> 
> Yes, either the applets get rewritten or they die. And actually it's not 
> a trivial task.

Hi Aleix,

to 1) I'm pretty sure this is not at all what Gregor wants to say. It's more 
like the behavior should be:
- On a fresh install, the message box asks you whether you really want to send 
the data.
- This message box always pops up, except if you
  - either activated "[x] Don't show again",
  - or you deactivated in the settings "[ ] Ask for confirmation"

Granted, the code in the review request does not yet fully do that (as far as I 
can see), but this is totally NOT about "advanced users not careing about 
sharing too much data" ;)


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117041/#review54054
---


On March 25, 2014, 10:24 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117041/
> ---
> 
> (Updated March 25, 2014, 10:24 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan 
> Čukić.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Summary
> ---
> Add two options:
>   1. Show confirmation before sending (to prevent accidental sending of maybe 
> sensible data)
>   2. Appearance: Restrict width on large host panel (to prevent huge icon on 
> large panels)
> 
> How does this change manifest on screen?
> 
> Settings dialog:
>   - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
>   - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png
> 
> Behaviour:
>   1. "Show confirmation before sending" turned on and after dropping an 
> image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
>   2. "Appearance: Restrict width on large host panel"
>  - turned off (default): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared 
> to other icons in system tray)
>  - turned on (new): 
> http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is 
> restricted so it does not eat up horizontal space)
> 
> Open issues
> ---
> - Is there a default "review board TARGET_GROUP" for kdeplasma-addons 
> review-request?
> 
> @apol: I saw that in the frameworks branch you replaced pastebin with 
> quickshare. I haven't had the chance to test it out. Does it already have the 
> same features as pastebin?
> 
> 
> Diffs
> -
> 
>   applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 
>   .gitignore PRE-CREATION 
>   .reviewboardrc PRE-CREATION 
>   applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e 
>   applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117041/diff/
> 
> 
> Testing
> ---
> 
> See screenshots in description. Test if settings are getting stored. Test 
> with different form factors (horizontal, vertical).
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel