Re: RFC: plasma-shell in pasma-workspace
On Thursday 03 April 2014 17:49:33 Marco Martin wrote: Hi all, this was briefly mentioned in the past. the idea is to leave only libraries and plugins in plasma-workspace, I assume you mean plasma-framework here? and mode plasma-shell in the new plasma-workspace repository instead. Is everybody fine with this? Sounds good to me. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/media.h 2bdef4d libs/mediacenter/medialibrary.cpp 713827a libs/mediacenter/medialibrary.h 3ac18a6 libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/mediacenter.h a2855dd Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: plasma-shell in pasma-workspace
On Friday 04 April 2014 08:34:14 Martin Gräßlin wrote: On Thursday 03 April 2014 17:49:33 Marco Martin wrote: Hi all, this was briefly mentioned in the past. the idea is to leave only libraries and plugins in plasma-workspace, I assume you mean plasma-framework here? eh, yeah :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: plasma-shell in pasma-workspace
Makes sense to me. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112208: KMix qml applet
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 - Christian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm; Known issues: * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume; * no scroll events over the sliders too; * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click KMix Setup button, KMix window will not restored anymore: this needs to be pathed as well. * resize doesn't work properly. Diffs - plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/112208/diff/ Testing --- Tested against master and works fine. File Attachments Default look https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png Menu Actions https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png Applet Config Options https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png Vertical Control https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png ToolButton label and Config page after updates https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png Control Icon and Label left aligned https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png Thanks, Diego Casella ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 4:21 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Fixed some issues with the previous diff. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs (updated) - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/medialibrary.cpp 713827a libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117368/#review54977
---
libs/mediacenter/mediacenter.cpp
https://git.reviewboard.kde.org/r/117368/#comment38360
since your are not using the first_run in another place you should not
create a variable with it. You could just do
if (!QDir(pcm_path).exists()) {
QDir().mkpath(pmc_path);
}
Also the correct coding style is
if () {
mycontent;
}
- Antonis Tsiapaliokas
On April 4, 2014, 11:21 a.m., Nikolaos Chatzidakis wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117368/
---
(Updated April 4, 2014, 11:21 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Repository: plasma-mediacenter
Description
---
This patch resolves the crash of PMC if it's running for the first time and
its data directory does not exist in ~/.kde4/share/apps.
Diffs
-
libs/mediacenter/mediacenter.cpp 35240d3
Diff: https://git.reviewboard.kde.org/r/117368/diff/
Testing
---
Tested the fix, it creates the directory if it doesn't exist (first-time-run
assumption).
Thanks,
Nikolaos Chatzidakis
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 11:42 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Removed bool variable and fixed parenthesis. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs (updated) - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/#review54978 --- Ship it! Looks good to me, I have one suggestion below. Make sure that all tests pass before pushing. libs/mediacenter/mediacenter.cpp https://git.reviewboard.kde.org/r/117368/#comment38361 const QString pmc_path - Shantanu Tushar On April 4, 2014, 11:42 a.m., Nikolaos Chatzidakis wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 11:42 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112208: KMix qml applet
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 My bad, sorry guys but I'm still in a busy period of my life :/ I'll try to fix the remaining issues pointed out in this review request, and then submit the changes here. There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events. AFAIK there still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix applet, one feature everyone is using is the ability to adjust volume level with just few mouse scrolls over the applet icon. I think we need to fix this problem as well, what do you think? - Diego --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm; Known issues: * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume; * no scroll events over the sliders too; * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click KMix Setup button, KMix window will not restored anymore: this needs to be pathed as well. * resize doesn't work properly. Diffs - plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/112208/diff/ Testing --- Tested against master and works fine. File Attachments Default look https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png Menu Actions https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png Applet Config Options https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png Vertical Control https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png ToolButton label and Config page after updates https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png Control Icon and Label left aligned https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png Thanks, Diego Casella ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117372: replace kde4-config with kf5-config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117372/ --- Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace Description --- startkde still uses kde4-config, this should be kf5-config in the kf5 world. Diffs - startkde/startkde.cmake e845603 Diff: https://git.reviewboard.kde.org/r/117372/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112208: KMix qml applet
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 Diego Casella wrote: My bad, sorry guys but I'm still in a busy period of my life :/ I'll try to fix the remaining issues pointed out in this review request, and then submit the changes here. There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events. AFAIK there still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix applet, one feature everyone is using is the ability to adjust volume level with just few mouse scrolls over the applet icon. I think we need to fix this problem as well, what do you think? Yes, most definitely we should have mouse scroll events. I guess everybody is using it on the tray icon and in the main window, and so it should also be there for the applet. But if users can choose the plasmoid as an optional, then this is not a showstopper. It is probably better to get it started as is. We could mark it early-access, so interested people can start playing around with it and using it. - Christian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm; Known issues: * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume; * no scroll events over the sliders too; * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click KMix Setup button, KMix window will not restored anymore: this needs to be pathed as well. * resize doesn't work properly. Diffs - plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/112208/diff/ Testing --- Tested against master and works fine. File Attachments Default look https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png Menu Actions https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png Applet Config Options https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png Vertical Control https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png ToolButton label and Config page after updates https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png Control Icon and Label left aligned https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png Thanks, Diego Casella ___ Plasma-devel mailing list
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/#review54982 --- Works fine, I can see the values in the table. However, the actual set of the value should happen inside Media instead of MediaLibrary as the comments below. libs/mediacenter/media.h https://git.reviewboard.kde.org/r/117365/#comment38362 doesnt need to be const QString for the return, just QString will do. The const QString you see at other places is quite some bad luck and needs to be fixed to QString as well, separately. For more http://techbase.kde.org/Policies/Library_Code_Policy#Const_References libs/mediacenter/medialibrary.cpp https://git.reviewboard.kde.org/r/117365/#comment38363 Instead of handling this here, you should let media-setValueForRole take care of updating the value. Just implement MediaCenter::GenreRole in Media::setValueForRole. Also, if you set wasUpdated to true always, the point of wasUpdated is lost. It is supposed to be set to true only when the old value and new value are different (which is when the setValueForRole method is supposed to return true). At the end, this else if should be removed (notice how there is no else if for createdAt (extractAndSaveDurationInfo should not have been there as well, it was missed and should be removed separately). libs/mediacenter/medialibrary.cpp https://git.reviewboard.kde.org/r/117365/#comment38364 same as above plugins/kdedesktopsearch/kdemetadatamediasource.cpp https://git.reviewboard.kde.org/r/117365/#comment38365 Just for consistency, move this to the line after CreatedAtRole - Shantanu Tushar On April 4, 2014, 10:51 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 10:51 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/medialibrary.cpp 713827a libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/#review54983 --- This review has been submitted with commit ff70cda90e786a7998802339178ed520cc672ff2 by Nikolaos Chatzidakis to branch master. - Commit Hook On April 4, 2014, 11:42 a.m., Nikolaos Chatzidakis wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 11:42 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 12:31 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 6:32 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Made changes suggested by Shantanu Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs (updated) - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117359: move phonon kcm and platform plugin to plasma-workspace
On April 3, 2014, 4:19 p.m., Aleix Pol Gonzalez wrote: Can you create the patch with --find-copies-harder? It will be much easier to review. Harald Sitter wrote: I am not sure how that would help as this is a cross-repo move from kde-runtime (: The kcm should go to plasma-desktop (since it is desktop only atm), the plugin should go to -workspace since it affects all form factors. - Àlex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117359/#review54948 --- On April 3, 2014, 3:31 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117359/ --- (Updated April 3, 2014, 3:31 p.m.) Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace Description --- import phonon KCM and phonon platform plugin - both ported away from deprecated classes - the kcm additionally had a cleanup of phonon private header copies - backendselection in the KCM was ported to a native Qt solution for phonon4qt5 - the platform plugin has just about all pointless features removed leading up to what may (or may not) be a platform plugin in a future phonon5 API - all direct ALSA handling was removed (e.g. the kded phononserver), we prefer PulseAudio device control over anything else, and short of that we'll expect the actual backend to provide a list of possible outputs Diffs - phonon/kcm/Messages.sh PRE-CREATION phonon/kcm/CMakeLists.txt PRE-CREATION CMakeLists.txt 28ad201 phonon/CMakeLists.txt PRE-CREATION phonon/platform_kde/phononbackend.desktop PRE-CREATION phonon/platform_kde/phonon.notifyrc PRE-CREATION phonon/platform_kde/kiomediastream_p.h PRE-CREATION phonon/platform_kde/kiomediastream.cpp PRE-CREATION phonon/platform_kde/kiomediastream.h PRE-CREATION phonon/platform_kde/kdeplatformplugin.cpp PRE-CREATION phonon/platform_kde/kdeplatformplugin.h PRE-CREATION phonon/platform_kde/debug.cpp PRE-CREATION phonon/platform_kde/debug.h PRE-CREATION phonon/platform_kde/Messages.sh PRE-CREATION phonon/platform_kde/CMakeLists.txt PRE-CREATION phonon/kcm/testspeakerwidget.cpp PRE-CREATION phonon/kcm/main.cpp PRE-CREATION phonon/kcm/testspeakerwidget.h PRE-CREATION phonon/kcm/main.h PRE-CREATION phonon/kcm/listview-background.png PRE-CREATION phonon/kcm/kcm_phonon.desktop PRE-CREATION phonon/kcm/devicepreference.ui PRE-CREATION phonon/kcm/devicepreference.cpp PRE-CREATION phonon/kcm/devicepreference.h PRE-CREATION phonon/kcm/backendselection.ui PRE-CREATION phonon/kcm/backendselection.cpp PRE-CREATION phonon/kcm/backendselection.h PRE-CREATION phonon/kcm/audiosetup.ui PRE-CREATION phonon/kcm/audiosetup.h PRE-CREATION phonon/kcm/audiosetup.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117359/diff/ Testing --- - build install - kcm change device order change backend order Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117356: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117356/#review54990 --- This review has been submitted with commit 81c322bf0328fd3df180010c498d04d9ace001d1 by Michael Palimaka to branch master. - Commit Hook On April 3, 2014, 10:27 a.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117356/ --- (Updated April 3, 2014, 10:27 a.m.) Review request for Plasma. Repository: ksysguard Description --- I can't find any reference to them, so remove them. Diffs - CMakeLists.txt 7a29dec035c6fc532a1da6c941220d0c173b10db Diff: https://git.reviewboard.kde.org/r/117356/diff/ Testing --- Inspected source. Builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117356: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117356/ --- (Updated April 4, 2014, 1:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: ksysguard Description --- I can't find any reference to them, so remove them. Diffs - CMakeLists.txt 7a29dec035c6fc532a1da6c941220d0c173b10db Diff: https://git.reviewboard.kde.org/r/117356/diff/ Testing --- Inspected source. Builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112208: KMix qml applet
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 Diego Casella wrote: My bad, sorry guys but I'm still in a busy period of my life :/ I'll try to fix the remaining issues pointed out in this review request, and then submit the changes here. There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events. AFAIK there still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix applet, one feature everyone is using is the ability to adjust volume level with just few mouse scrolls over the applet icon. I think we need to fix this problem as well, what do you think? Christian Esken wrote: Yes, most definitely we should have mouse scroll events. I guess everybody is using it on the tray icon and in the main window, and so it should also be there for the applet. But if users can choose the plasmoid as an optional, then this is not a showstopper. It is probably better to get it started as is. We could mark it early-access, so interested people can start playing around with it and using it. Quote: There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events Seriously? I never ever used the scrolling on the tray icon itself. I didn't even know it was possible till you said it in this post. But please don't let such a minor issue block your progress :) Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm; Known issues: * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume; * no scroll events over the sliders too; * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click KMix Setup button, KMix window will not restored anymore: this needs to be pathed as well. * resize doesn't work properly. Diffs - plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/112208/diff/ Testing --- Tested against master and works fine. File Attachments Default look https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png Menu Actions https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png Applet Config
Re: Review Request 112208: KMix qml applet
On March 23, 2014, 12:09 a.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 Diego Casella wrote: My bad, sorry guys but I'm still in a busy period of my life :/ I'll try to fix the remaining issues pointed out in this review request, and then submit the changes here. There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events. AFAIK there still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix applet, one feature everyone is using is the ability to adjust volume level with just few mouse scrolls over the applet icon. I think we need to fix this problem as well, what do you think? Christian Esken wrote: Yes, most definitely we should have mouse scroll events. I guess everybody is using it on the tray icon and in the main window, and so it should also be there for the applet. But if users can choose the plasmoid as an optional, then this is not a showstopper. It is probably better to get it started as is. We could mark it early-access, so interested people can start playing around with it and using it. Mark Gaiser wrote: Quote: There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events Seriously? I never ever used the scrolling on the tray icon itself. I didn't even know it was possible till you said it in this post. But please don't let such a minor issue block your progress :) Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. I use it extensively and every new user I put on Plasma, that's one of the first things I teach them. It's much more convenient because ~80% of the time you're holding your mouse in your hand and ~95% of the time you have your eyes on the screen. Going for keyboard button means in many cases taking your eyes off the screen and looking at the exact button position, often you even have to let the mouse go and move your hand to keyboard (for example YouTube video/any other media being too loud). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 10:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 10:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm; Known issues: * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume; * no scroll events over the sliders too; * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click KMix Setup
Review Request 117374: Add a kded module for ksysguard
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117374/ --- Review request for Plasma. Repository: plasma-workspace Description --- This module is responsible for launching the simple ksysguard module that krunner used to show when pressing the Ctrl + Escape keyboard shortcut. Most of this code used to exist in the old krunner Diffs - CMakeLists.txt 8834986 ksysguard/CMakeLists.txt PRE-CREATION ksysguard/kded_ksysguard.desktop PRE-CREATION ksysguard/kdedksysguard.h PRE-CREATION ksysguard/kdedksysguard.cpp PRE-CREATION ksysguard/ksystemactivitydialog.h PRE-CREATION ksysguard/ksystemactivitydialog.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117374/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112208: KMix qml applet
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 Diego Casella wrote: My bad, sorry guys but I'm still in a busy period of my life :/ I'll try to fix the remaining issues pointed out in this review request, and then submit the changes here. There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events. AFAIK there still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix applet, one feature everyone is using is the ability to adjust volume level with just few mouse scrolls over the applet icon. I think we need to fix this problem as well, what do you think? Christian Esken wrote: Yes, most definitely we should have mouse scroll events. I guess everybody is using it on the tray icon and in the main window, and so it should also be there for the applet. But if users can choose the plasmoid as an optional, then this is not a showstopper. It is probably better to get it started as is. We could mark it early-access, so interested people can start playing around with it and using it. Mark Gaiser wrote: Quote: There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events Seriously? I never ever used the scrolling on the tray icon itself. I didn't even know it was possible till you said it in this post. But please don't let such a minor issue block your progress :) Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. Martin Klapetek wrote: Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. I use it extensively and every new user I put on Plasma, that's one of the first things I teach them. It's much more convenient because ~80% of the time you're holding your mouse in your hand and ~95% of the time you have your eyes on the screen. Going for keyboard button means in many cases taking your eyes off the screen and looking at the exact button position, often you even have to let the mouse go and move your hand to keyboard (for example YouTube video/any other media being too loud). But you can do it all with your mouse. 1. Click the icon 2. move your cursor to the stream (or master channel). 3. scroll... Just to be sure, scrolling (as i described in the steps above) works in this proposed component, right? All that's not working is scrolling on the tray icon, correct? Note: I happen to have a keyboard without media keys. I always click the icon and scroll on the stream where i want to change the sound level. - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 8:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon
Re: Review Request 112208: KMix qml applet
On March 23, 2014, 12:09 a.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original submitter or somebody else would have to push this. I added this as a topic for the KDE Multimedia Sprint. It takes place in about 4 months (August 2014): https://sprints.kde.org/sprint/212 Diego Casella wrote: My bad, sorry guys but I'm still in a busy period of my life :/ I'll try to fix the remaining issues pointed out in this review request, and then submit the changes here. There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events. AFAIK there still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix applet, one feature everyone is using is the ability to adjust volume level with just few mouse scrolls over the applet icon. I think we need to fix this problem as well, what do you think? Christian Esken wrote: Yes, most definitely we should have mouse scroll events. I guess everybody is using it on the tray icon and in the main window, and so it should also be there for the applet. But if users can choose the plasmoid as an optional, then this is not a showstopper. It is probably better to get it started as is. We could mark it early-access, so interested people can start playing around with it and using it. Mark Gaiser wrote: Quote: There is still an ongoing (and BIG imho) issue anyway: we really really really need a Plasma QML callback to capture mouse scroll events Seriously? I never ever used the scrolling on the tray icon itself. I didn't even know it was possible till you said it in this post. But please don't let such a minor issue block your progress :) Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. Martin Klapetek wrote: Clicking the icon or using the media keys on most keyboards is probably enough possibilities for people change the volume. Scrolling on the icon is imho just bonus stuff. I use it extensively and every new user I put on Plasma, that's one of the first things I teach them. It's much more convenient because ~80% of the time you're holding your mouse in your hand and ~95% of the time you have your eyes on the screen. Going for keyboard button means in many cases taking your eyes off the screen and looking at the exact button position, often you even have to let the mouse go and move your hand to keyboard (for example YouTube video/any other media being too loud). Mark Gaiser wrote: But you can do it all with your mouse. 1. Click the icon 2. move your cursor to the stream (or master channel). 3. scroll... Just to be sure, scrolling (as i described in the steps above) works in this proposed component, right? All that's not working is scrolling on the tray icon, correct? Note: I happen to have a keyboard without media keys. I always click the icon and scroll on the stream where i want to change the sound level. Sure you can, it's just way easier to simply scroll on an icon than opening this - http://i.imgur.com/LcyFzq6.png and identifying the channel you need to change (the assumption being that you want to change only the main volume, not per stream controls). That way you're doing the visual identification twice - first locating the systray icon, click, now locating the proper handle. So doing it that way is mentally harder task than simply scroll the icon, which also saves you a click ;) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 --- On Aug. 27, 2013, 10:40 a.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 27, 2013, 10:40 a.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences
Re: RFC: plasma-shell in pasma-workspace
On Thursday 03 April 2014 17:49:33 you wrote: Hi all, this was briefly mentioned in the past. the idea is to leave only libraries and plugins in plasma-workspace, and mode plasma-shell in the new plasma-workspace repository instead. Is everybody fine with this? Also, how to do the move? (i think filter-branch is the only option in this case?) the shell is moved. Please test, in case any build-related problem will surface (here seems to be working fine) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/#review55005 --- Ship it! Ship It! - Shantanu Tushar On April 4, 2014, 1:02 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 1:02 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Visual design for logout/login/lockscreen
Hello, After reading Aaron's nearly year old blog entry again this week ( http://aseigo.blogspot.de/2013/05/visual-harmony-in-plasma-workspaces-2.html) , especially the following quote: ...the log out dialog still has things that look like little push buttons and it still has inexplicable picture on the left, despite now being written in QML and having all the power that implies. Plasma Workspaces 2 is our opportunity to improve these parts by harmonizing and modernizing them. The log out interface ought to look like it belongs with the lock screen; the log in screen ought to mesh with the splash screen... We have a couple people who can do this kind of work, but they have lots on their plate already. This is a great opportunity for someone with a flair for design to get involved... I put a little effort into identifying a visual design that might get us a little bit closer. I apologize that I don't have any idea what work may have already been put into this area, so please don't take my ignorance as a dismissal of any work that has already occurred. I also shared this design with other members of the Visual Design Group and there were no objections to offering these designs here. Anyway here goes: Login: http://wstaw.org/m/2014/04/05/login_mockup.png Logout: http://wstaw.org/m/2014/04/03/logout_mockup.png Unlock: http://wstaw.org/m/2014/04/05/unlock_mockup.png Shutdown: http://wstaw.org/m/2014/04/03/shutdown_mockup2_1.png We're happy to provide any visual assets required, which shouldn't be much. (We already have a few to choose from). I won't speak to architecture since that's your wheelhouse, but my assumption is that the UI layer could be handled by the same QML package with enough hooks for the various existing underlying functionality to use. I would like to have offered up a QML package with this, but it's early days yet for my QML familiarity (but getting better fast). :-) Hope this is helpful and please let me know if there are any questions, Andrew Lake Community designer in the KDE Visual Design Group ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Could someone look at the plasmoid top placement bug?
Hi, Could someone please look at this bug [1, 2]. The report [2] is on bugzilla for close to two years and is there since KDE 4.10. I am reporting it on the list because the bug is quite annoying if you use plasmoids and is known for quite a while without a solution. Yes, i did try to look in the code, but it's all a bit strange and weird code for me to follow. It's not the area i feel comfortable (or even understand) so i hope someone from the plasma team could take a look at this and perhaps even fix it. Probably a one liner for you guys :) How to reproduce? Simple. Just drag the notes plasmoid to the top of your screen. It will jump down to what you see in the screenshot [1] and leave too much top space compared to the left of it. I would expect the top and left spacing to be equal (15px?) Cheers, Mark [1] http://i.imgur.com/9zOWLc0.jpg [2] https://bugs.kde.org/show_bug.cgi?id=301225 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Visual design for logout/login/lockscreen
Awesome! That login theme in nice, and I like the idea of the visual consistency throughout. I'll have a go at implementing the login stuff on Monday, maybe the lock screen too as it'll be mostly copy paste. I have a few things that need adding to the login theme, maybe you can incorporate them in the mockup? - Session Choosing (KDE, Gnome, etc.) - Language selection (English, Deutsch) - Possibly keyboard layout selection I also currently need all 4 power options, suspend, shutdown, reboot, hibernate. Maybe they could be grouped into a menu from a button. It would be ideal for me if in future in mockups from the SVG we can label which SVGs from the Plasma theme are being used where; and if there's anything new/custom. I think the main horizontal stripe is new? David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/#review55011 --- This review has been submitted with commit 035eba60fd682a608f4855b25f0d7be872ba8388 by Ashish Madeti to branch master. - Commit Hook On April 4, 2014, 1:02 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 1:02 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 5, 2014, 3:32 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
