[KDE Bugtracking System] REMINDER: current Plasma regressions

2014-05-01 Thread bugzilla_noreply 
Please find below a list of the current regressions reported for Plasma. This 
is a weekly reminder.

  This search was scheduled by myr...@kde.org.


Plasma regressions
--
Bug 301424:
  https://bugs.kde.org/show_bug.cgi?id=301424
  Priority: NOR  Severity: normal  Platform: openSUSE RPMs
  Assignee: plasma-b...@kde.org
Status: REOPENED
   Summary: Cannot open battery monitor applet if set to hidden in systray


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117934: if HAVE -> ifdef HAVE

2014-05-01 Thread David Heidelberger 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117934/
---

(Updated May 1, 2014, 9:01 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

simply fix compilation ( gcc 4.8.2 )


Diffs
-

  drkonqi/drkonqidialog.cpp 7dc4021 
  kglobalaccel/component.cpp 2b8b6f1 
  kglobalaccel/globalshortcutsregistry.cpp 532334a 
  klipper/klipper.cpp cde65f5 
  klipper/urlgrabber.cpp 923aa94 
  libkworkspace/kdisplaymanager.h d9972ea 
  libkworkspace/kdisplaymanager.cpp 4a58bfb 
  libkworkspace/kworkspace.cpp bad054a 
  libkworkspace/kworkspace_p.h 3df837f 
  libtaskmanager/task.h 13a5a9c 
  libtaskmanager/taskmanager.cpp 27eeed7 
  shell/panelshadows.cpp 0f99721 
  shell/panelview.cpp 545fe91 
  shell/shellcorona.cpp 2f82132 

Diff: https://git.reviewboard.kde.org/r/117934/diff/


Testing
---


Thanks,

David Heidelberger

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117934: if HAVE -> ifdef HAVE

2014-05-01 Thread David Heidelberger 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117934/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

simply fix compilation ( gcc 4.8.2 )


Diffs
-

  drkonqi/drkonqidialog.cpp 7dc4021 
  kglobalaccel/component.cpp 2b8b6f1 
  kglobalaccel/globalshortcutsregistry.cpp 532334a 
  klipper/klipper.cpp cde65f5 
  klipper/urlgrabber.cpp 923aa94 
  libkworkspace/kdisplaymanager.h d9972ea 
  libkworkspace/kdisplaymanager.cpp 4a58bfb 
  libkworkspace/kworkspace.cpp bad054a 
  libkworkspace/kworkspace_p.h 3df837f 
  libtaskmanager/task.h 13a5a9c 
  libtaskmanager/taskmanager.cpp 27eeed7 
  shell/panelshadows.cpp 0f99721 
  shell/panelview.cpp 545fe91 
  shell/shellcorona.cpp 2f82132 

Diff: https://git.reviewboard.kde.org/r/117934/diff/


Testing
---


Thanks,

David Heidelberger

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117894: Add a kscreenlocker_test test application

2014-05-01 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117894/#review57069
---


The greeter is invokable on it's own anyway, what benefit does this have?

- David Edmundson


On April 30, 2014, 9:44 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117894/
> ---
> 
> (Updated April 30, 2014, 9:44 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Wolfgang Bauer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Add a kscreenlocker_test test application
> 
> The idea is to have a small test application for the screenlocker part
> to test without having to restart ksmserver.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/CMakeLists.txt 
> 700cdff95f46125952ab2503bb125c5b6cd3ce67 
>   ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION 
>   ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117894/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117900: Cleanup of screenlocker

2014-05-01 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117900/#review57068
---

Ship it!



ksmserver/screenlocker/ksldapp.cpp


I don't see why we're using lambdas here. IMHO it's makes establishGrab 
more unreadable and has no advantages. 

Either it can be inline properly or it can be in a new function properly.


- David Edmundson


On April 30, 2014, 1:45 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117900/
> ---
> 
> (Updated April 30, 2014, 1:45 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Remove saverLockReady from org.kde.screensaver interface
> 
> Wasn't implemented.
> 
> [screenlocker] Remove setupPlasma from org.kde.screensaver interface
> 
> We don't have the plasma-overlay anymore, so let's remove it.
> 
> [screenlocker] Remove boolean trap in ::lock
> 
> Use an enum value to indicate whether there's an immediate or a delayed
> lock. At the same time lock is no longer a slot.
> 
> [screenlocker] Remove lock slot without argument
> 
> Replace by lambda slot which delegates to lock(true).
> 
> [screenlocker] Turn idleTimeout slot into lambda slot
> 
> Code is only and should only be executed after the timeoutReached signal
> from KIdleTime. Using a lambda slot enforces that as well as adding
> compile time checking for connect syntax.
> 
> [screenlocker] Turn lockProcessReady slot into a lambda slot
> 
> Code should only be executed in reply to signal
> QProcess::readyReadStandardOutput. From anywhere else it would have been
> wrong. By using a lambda slot this gets enforces and the connection gets
> compile time checked.
> 
> [screenlocker] Turn lockProcessFinished slot into a lambda slot
> 
> LockProcessFinished should only be invoked when the QProcess::finished
> signal fired. Right now it was possible to invoke that from other code
> paths. By turning it into a lambda slot this becomes more clear and we
> get compile time checking for the connection.
> 
> [screenlocker] Turn KSldApp::grabKeyboard and ::grabMouse into lambdas
> 
> It's only used by ::establishGrab and shouldn't be used from anywhere
> else. To make this more clear the code is moved into lambda functions
> in ::establishGrab.
> 
> [screenlocker] Move sanity checks for lockGrace to kcfg
> 
> Kcfg provides min/max values, so we don't need the qBound in source code
> side.
> 
> [screenlocker] Remove not needed includes
> 
> Instead of using QDesktopWidget to get the id of the X11 rootWindow we
> just ask QX11Info.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/dbus/org.kde.screensaver.xml 
> e700b88215973f11b2601e5d164371874d262580 
>   ksmserver/screenlocker/interface.h 97a60737632e1cd799c0a1b09cc73ab4b580d757 
>   ksmserver/screenlocker/interface.cpp 
> 0ce68c0d0d8aaf41588d5b5e73e66aa1b6320d15 
>   ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg 
> 6a1cbb0935461c8045dd847a63e31e72fb6ca007 
>   ksmserver/screenlocker/ksldapp.h 958b55c1ff83e21d57e3c1dfb812016f325046be 
>   ksmserver/screenlocker/ksldapp.cpp c678cfc33f82509776047894e46c4fbe15563d49 
> 
> Diff: https://git.reviewboard.kde.org/r/117900/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117822: Add safety checks to XCB functions in WindowThumbnail

2014-05-01 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117822/#review57066
---

Ship it!


Ship It!

- David Edmundson


On April 28, 2014, 8:20 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117822/
> ---
> 
> (Updated April 28, 2014, 8:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add safety checks to XCB functions in WindowThumbnail
> 
> Prevents XCB warnings about BadWindow when a tooltip is shown for the
> first time.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> d1a7fef1fc5fd119592710d80274d2abe0c8b3b1 
> 
> Diff: https://git.reviewboard.kde.org/r/117822/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117931: Restrict sourceSize to screen size

2014-05-01 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117931/#review57065
---

Ship it!


Ship It!

- Sinny Kumari


On May 1, 2014, 1:33 p.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117931/
> ---
> 
> (Updated May 1, 2014, 1:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 334176
> http://bugs.kde.org/show_bug.cgi?id=334176
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This helps by limiting the image source width so that it doesnt load full 
> versions of images with resolutions more than the screen size.
> 
> 
> Diffs
> -
> 
>   mediaelements/imageviewer/ImageViewer.qml b182bf2 
> 
> Diff: https://git.reviewboard.kde.org/r/117931/diff/
> 
> 
> Testing
> ---
> 
> works with both portrait and landscape
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #114

2014-05-01 Thread KDE CI System 
See 

Changes:

[jr] as with other libraries in workspace bump soversion to 5

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson3829894657879950344.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-desktop
   4c9f9dd..40e0aba  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 4c9f9dd Port fontinst away from KIcon
Success build forhudson.tasks.Shell@40820681
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
Checking out Revision 40e0abac4500534622c6f79f4e2218eaca911201 
(refs/heads/jenkins)
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson8696054922316151294.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch master
== Build Dependencies:
 kdesignerplugin - Branch master
 kitemviews - Branch master
 ktextwidgets - Branch master
 sonnet - Branch master
 kcrash - Branch master
 attica - Branch master
 kfilemetadata - Branch frameworks
 kwallet - Branch master
 cmake - Branch master
 kconfigwidgets - Branch master
 milou - Branch frameworks
 khtml - Branch master
 kiconthemes - Branch master
 plasma-workspace - Branch master
 kactivities - Branch master
 khelpcenter - Branch master
 kparts - Branch master
 kwindowsystem - Branch master
 kguiaddons - Branch master
 kross - Branch master
 kde-cli-tools - Branch master
 plasma-framework - Branch master
 qt5 - Branch stable
 kdelibs4support - Branch master
 kcmutils - Branch master
 kf5umbrella - Branch master
 kjsembed - Branch master
 kcodecs - Branch master
 kjs - Branch master
 baloo - Branch frameworks
 kwin - Branch master
 kwidgetsaddons - Branch master
 knewstuff - Branch master
 powerdevil - Branch master
 kidletime - Branch master
 kio-extras - Branch master
 threadweaver - Branch master
 kcoreaddons - Branch master
 polkit-qt-1 - Branch qt5
 kdewebkit - Branch master
 kded - Branch master
 frameworkintegration - Branch master
 kdnssd - Branch master
 ksysguard - Branch master
 kservice - Branch master
 kglobalaccel - Branch master
 kinit - Branch master
 knotifications - Branch master
 ktexteditor - Branch master
 kpty - Branch master
 kemoticons - Branch master
 kcompletion - Branch master
 solid - Branch master
 kdeclarative - Branch master
 kdesupport-svn - Branch master
 kitemmodels - Branch master
 krunner - Branch master
 phonon - Branch master
 kjobwidgets - Branch master
 oxygen - Branch master
 kunitconversion - Branch master
 ki18n - Branch master
 libksysguard - Branch master
 kxmlgui - Branch master
 kauth - Branch master
 karchive - Branch master
 kconfig - Branch master
 kbookmarks - Branch master
 knotifyconfig - Branch master
 kio - Branch master
 extra-cmake-modules - Branch master
 libdbusmenu-qt - Branch master
 systemsettings - Branch master
 breeze - Branch master
 kdbusaddons - Branch master
 kdoctools - Branch master
 kdesu - Branch master
 kplotting - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-desktop failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117906: set soversion to 5

2014-05-01 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117906/#review57062
---


This review has been submitted with commit 
40e0abac4500534622c6f79f4e2218eaca911201 by Jonathan Riddell to branch master.

- Commit Hook


On April 30, 2014, 3:11 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117906/
> ---
> 
> (Updated April 30, 2014, 3:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> as with other libraries in workspace bump soversion to 5
> 
> 
> Diffs
> -
> 
>   kcms/kfontinst/lib/CMakeLists.txt d174596 
> 
> Diff: https://git.reviewboard.kde.org/r/117906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117906: set soversion to 5

2014-05-01 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117906/
---

(Updated May 1, 2014, 3:16 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
---

as with other libraries in workspace bump soversion to 5


Diffs
-

  kcms/kfontinst/lib/CMakeLists.txt d174596 

Diff: https://git.reviewboard.kde.org/r/117906/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117931: Restrict sourceSize to screen size

2014-05-01 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117931/
---

Review request for Plasma.


Bugs: 334176
http://bugs.kde.org/show_bug.cgi?id=334176


Repository: plasma-mediacenter


Description
---

This helps by limiting the image source width so that it doesnt load full 
versions of images with resolutions more than the screen size.


Diffs
-

  mediaelements/imageviewer/ImageViewer.qml b182bf2 

Diff: https://git.reviewboard.kde.org/r/117931/diff/


Testing
---

works with both portrait and landscape


Thanks,

Shantanu Tushar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #134

2014-05-01 Thread KDE CI System 
See 

Changes:

[jr] Use Breeze mouse cursor theme by default

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5163250262147545775.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   78024a9..ba097fe  davidedmundson/faster_systray -> 
origin/davidedmundson/faster_systray
   60ae68a..744a82f  master -> origin/master
 * [new branch]  plasmashell+libkscreen -> origin/plasmashell+libkscreen
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 60ae68a Drop some unneeded QDesktopWidget references
Removing build/
Success build forhudson.tasks.Shell@807d1fd
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
Checking out Revision 744a82f4c3515f5b8b8d0f785c24373da989f5f8 
(refs/heads/jenkins)
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson631638851095552280.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kwallet - Branch master
 knotifications - Branch master
 knewstuff - Branch master
 sonnet - Branch master
 kcrash - Branch master
 threadweaver - Branch master
 kross - Branch master
 kdewebkit - Branch master
 kde-cli-tools - Branch master
 attica - Branch master
 milou - Branch frameworks
 kiconthemes - Branch master
 breeze - Branch master
 kglobalaccel - Branch master
 khelpcenter - Branch master
 kplotting - Branch master
 kparts - Branch master
 kservice - Branch master
 cmake - Branch master
 qt5 - Branch stable
 ktextwidgets - Branch master
 kconfigwidgets - Branch master
 kcmutils - Branch master
 kf5umbrella - Branch master
 kactivities - Branch master
 kjsembed - Branch master
 kcodecs - Branch master
 baloo - Branch frameworks
 kwin - Branch master
 kdnssd - Branch master
 extra-cmake-modules - Branch master
 libdbusmenu-qt - Branch master
 kidletime - Branch master
 kio - Branch master
 kpty - Branch master
 kio-extras - Branch master
 kcoreaddons - Branch master
 polkit-qt-1 - Branch qt5
 kdesupport-svn - Branch master
 kdbusaddons - Branch master
 kdelibs4support - Branch master
 kunitconversion - Branch master
 kxmlgui - Branch master
 kjs - Branch master
 kded - Branch master
 frameworkintegration - Branch master
 plasma-framework - Branch master
 ktexteditor - Branch master
 kdeclarative - Branch master
 kwindowsystem - Branch master
 solid - Branch master
 kfilemetadata - Branch frameworks
 kguiaddons - Branch master
 khtml - Branch master
 kemoticons - Branch master
 kitemmodels - Branch master
 krunner - Branch master
 phonon - Branch master
 kjobwidgets - Branch master
 kitemviews - Branch master
 kcompletion - Branch master
 ki18n - Branch master
 kconfig - Branch master
 kauth - Branch master
 knotifyconfig - Branch master
 libksysguard - Branch master
 kbookmarks - Branch master
 karchive - Branch master
 kwidgetsaddons - Branch master
 kdesignerplugin - Branch master
 kinit - Branch master
 kdoctools - Branch master
 kdesu - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-workspace failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117899: Use Breeze mouse cursor theme by default

2014-05-01 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117899/
---

(Updated May 1, 2014, 1:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

In startkde set the breeze bridge mouse cursor theme to be the default for new 
plasma next users.


Diffs
-

  startkde/startkde.cmake c4782ab 

Diff: https://git.reviewboard.kde.org/r/117899/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117899: Use Breeze mouse cursor theme by default

2014-05-01 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117899/
---

(Updated May 1, 2014, 1:32 p.m.)


Review request for Plasma.


Summary (updated)
-

Use Breeze mouse cursor theme by default


Repository: plasma-workspace


Description
---

In startkde set the breeze bridge mouse cursor theme to be the default for new 
plasma next users.


Diffs
-

  startkde/startkde.cmake c4782ab 

Diff: https://git.reviewboard.kde.org/r/117899/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117899: Use Breeze mouse cursor theme by default

2014-05-01 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117899/#review57059
---


This review has been submitted with commit 
744a82f4c3515f5b8b8d0f785c24373da989f5f8 by Jonathan Riddell to branch master.

- Commit Hook


On May 1, 2014, 1:32 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117899/
> ---
> 
> (Updated May 1, 2014, 1:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> In startkde set the breeze bridge mouse cursor theme to be the default for 
> new plasma next users.
> 
> 
> Diffs
> -
> 
>   startkde/startkde.cmake c4782ab 
> 
> Diff: https://git.reviewboard.kde.org/r/117899/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-05-01 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117923/
---

(Updated May 1, 2014, 11:58 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-mediacenter


Description
---

Currently test is getting compiled along with libs. Due to this same source was 
compiled multiple times. With this patch, Plasma-medacenter creates a new 
plasmamediacentertest library which has default all exported symbols from libs. 
Now, test can be linked with libplasmamediacentertest.


Diffs
-

  libs/CMakeLists.txt a0a0f72 
  libs/mediacenter/CMakeLists.txt 2dbec83 
  libs/mediacenter/test/fakemediavalidator.h 201973c 
  libs/mediacenter/test/fakemediavalidator.cpp 9b2feca 
  libs/mediacenter/test/lastfmimagefetchertest.h 6422824 
  libs/mediacenter/test/lastfmimagefetchertest.cpp b0fcf6f 
  libs/mediacenter/test/mediacentertest.h 6997ae9 
  libs/mediacenter/test/mediacentertest.cpp 96a70a9 
  libs/mediacenter/test/medialibrarytest.h 718457d 
  libs/mediacenter/test/medialibrarytest.cpp 08af239 
  libs/mediacenter/test/mediatest.h da16e59 
  libs/mediacenter/test/mediatest.cpp 832fedb 
  libs/mediacenter/test/pmcmediatest.h 2322176 
  libs/mediacenter/test/pmcmediatest.cpp 0da8dd3 
  libs/mediacenter/test/singletonfactorytest.h 79e4197 
  libs/mediacenter/test/singletonfactorytest.cpp 308487d 
  libs/mediacenter/test/testhelpers.h 9825e85 
  libs/test/CMakeLists.txt PRE-CREATION 
  libs/test/fakemediavalidator.h PRE-CREATION 
  libs/test/fakemediavalidator.cpp PRE-CREATION 
  libs/test/lastfmimagefetchertest.h PRE-CREATION 
  libs/test/lastfmimagefetchertest.cpp PRE-CREATION 
  libs/test/mediacentertest.h PRE-CREATION 
  libs/test/mediacentertest.cpp PRE-CREATION 
  libs/test/medialibrarytest.h PRE-CREATION 
  libs/test/medialibrarytest.cpp PRE-CREATION 
  libs/test/mediatest.h PRE-CREATION 
  libs/test/mediatest.cpp PRE-CREATION 
  libs/test/pmcmediatest.h PRE-CREATION 
  libs/test/pmcmediatest.cpp PRE-CREATION 
  libs/test/singletonfactorytest.h PRE-CREATION 
  libs/test/singletonfactorytest.cpp PRE-CREATION 
  libs/test/testhelpers.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117923/diff/


Testing
---

Application runs as expected and all unit test passed


Thanks,

Sinny Kumari

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-05-01 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117923/#review57054
---


This review has been submitted with commit 
270c1c65d944654402755b9e9a8fac25a7166b39 by Sinny Kumari to branch master.

- Commit Hook


On May 1, 2014, 7:32 a.m., Sinny Kumari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117923/
> ---
> 
> (Updated May 1, 2014, 7:32 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Currently test is getting compiled along with libs. Due to this same source 
> was compiled multiple times. With this patch, Plasma-medacenter creates a new 
> plasmamediacentertest library which has default all exported symbols from 
> libs. Now, test can be linked with libplasmamediacentertest.
> 
> 
> Diffs
> -
> 
>   libs/CMakeLists.txt a0a0f72 
>   libs/mediacenter/CMakeLists.txt 2dbec83 
>   libs/mediacenter/test/fakemediavalidator.h 201973c 
>   libs/mediacenter/test/fakemediavalidator.cpp 9b2feca 
>   libs/mediacenter/test/lastfmimagefetchertest.h 6422824 
>   libs/mediacenter/test/lastfmimagefetchertest.cpp b0fcf6f 
>   libs/mediacenter/test/mediacentertest.h 6997ae9 
>   libs/mediacenter/test/mediacentertest.cpp 96a70a9 
>   libs/mediacenter/test/medialibrarytest.h 718457d 
>   libs/mediacenter/test/medialibrarytest.cpp 08af239 
>   libs/mediacenter/test/mediatest.h da16e59 
>   libs/mediacenter/test/mediatest.cpp 832fedb 
>   libs/mediacenter/test/pmcmediatest.h 2322176 
>   libs/mediacenter/test/pmcmediatest.cpp 0da8dd3 
>   libs/mediacenter/test/singletonfactorytest.h 79e4197 
>   libs/mediacenter/test/singletonfactorytest.cpp 308487d 
>   libs/mediacenter/test/testhelpers.h 9825e85 
>   libs/test/CMakeLists.txt PRE-CREATION 
>   libs/test/fakemediavalidator.h PRE-CREATION 
>   libs/test/fakemediavalidator.cpp PRE-CREATION 
>   libs/test/lastfmimagefetchertest.h PRE-CREATION 
>   libs/test/lastfmimagefetchertest.cpp PRE-CREATION 
>   libs/test/mediacentertest.h PRE-CREATION 
>   libs/test/mediacentertest.cpp PRE-CREATION 
>   libs/test/medialibrarytest.h PRE-CREATION 
>   libs/test/medialibrarytest.cpp PRE-CREATION 
>   libs/test/mediatest.h PRE-CREATION 
>   libs/test/mediatest.cpp PRE-CREATION 
>   libs/test/pmcmediatest.h PRE-CREATION 
>   libs/test/pmcmediatest.cpp PRE-CREATION 
>   libs/test/singletonfactorytest.h PRE-CREATION 
>   libs/test/singletonfactorytest.cpp PRE-CREATION 
>   libs/test/testhelpers.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117923/diff/
> 
> 
> Testing
> ---
> 
> Application runs as expected and all unit test passed
> 
> 
> Thanks,
> 
> Sinny Kumari
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #113

2014-05-01 Thread KDE CI System 
See 

Changes:

[sebas] Use Q_GLOBAL_STATIC instead of K_*

[sebas] kfontinst: Port to QUrl

[sebas] Port viewpart away from KUrl

[sebas] Port lib away from KUrl

[sebas] KStandardDirs--;

[sebas] Port fontinst away from KIcon

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson8816757375576243232.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-desktop
   0350ffb..4c9f9dd  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 0350ffb Paranoia++.
Success build forhudson.tasks.Shell@40820681
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
Checking out Revision 4c9f9ddae79e5934c2b20d7ef115a30d1df7329e 
(refs/heads/jenkins)
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson3179336690475076652.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch master
== Build Dependencies:
 kjs - Branch master
 kbookmarks - Branch master
 kwallet - Branch master
 extra-cmake-modules - Branch master
 solid - Branch master
 kcrash - Branch master
 frameworkintegration - Branch master
 attica - Branch master
 ktextwidgets - Branch master
 kwindowsystem - Branch master
 kdeclarative - Branch master
 kio-extras - Branch master
 kiconthemes - Branch master
 breeze - Branch master
 kcompletion - Branch master
 kparts - Branch master
 kguiaddons - Branch master
 kservice - Branch master
 plasma-framework - Branch master
 qt5 - Branch stable
 ksysguard - Branch master
 kcmutils - Branch master
 kf5umbrella - Branch master
 kinit - Branch master
 kjsembed - Branch master
 kcodecs - Branch master
 baloo - Branch frameworks
 kwin - Branch master
 krunner - Branch master
 powerdevil - Branch master
 khelpcenter - Branch master
 kde-cli-tools - Branch master
 knotifications - Branch master
 kdnssd - Branch master
 kross - Branch master
 threadweaver - Branch master
 kcoreaddons - Branch master
 polkit-qt-1 - Branch qt5
 kwidgetsaddons - Branch master
 kdewebkit - Branch master
 kjobwidgets - Branch master
 kpty - Branch master
 kdbusaddons - Branch master
 kdelibs4support - Branch master
 kglobalaccel - Branch master
 karchive - Branch master
 ktexteditor - Branch master
 kunitconversion - Branch master
 kplotting - Branch master
 kconfig - Branch master
 kded - Branch master
 kio - Branch master
 cmake - Branch master
 sonnet - Branch master
 kfilemetadata - Branch frameworks
 kdesupport-svn - Branch master
 kactivities - Branch master
 kitemmodels - Branch master
 knewstuff - Branch master
 kconfigwidgets - Branch master
 kdesignerplugin - Branch master
 phonon - Branch master
 khtml - Branch master
 kemoticons - Branch master
 kitemviews - Branch master
 oxygen - Branch master
 milou - Branch frameworks
 ki18n - Branch master
 kxmlgui - Branch master
 kauth - Branch master
 knotifyconfig - Branch master
 libdbusmenu-qt - Branch master
 systemsettings - Branch master
 kidletime - Branch master
 plasma-workspace - Branch master
 libksysguard - Branch master
 kdoctools - Branch master
 kdesu - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-desktop failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-workspace/plasmashell+libkscreen] /: Adopt libkscreen to get information of the screens

2014-05-01 Thread Martin Klapetek 
Note that the coding style is quite off and it messes up the existing style
in all those files; can you please run astyle on it before merging so it
can all be the same?

Cheers
-- 
Martin Klapetek | KDE Developer


On Thu, May 1, 2014 at 3:42 AM, Aleix Pol  wrote:

> Git commit 168c15a463746cf9039f2f9e188b1827ed809f97 by Aleix Pol.
> Committed on 01/05/2014 at 01:41.
> Pushed by apol into branch 'plasmashell+libkscreen'.
>
> Adopt libkscreen to get information of the screens
>
> Qt subsystem has deficiencies on their approximation to multiple
> screens. [1]
> This patch adopts libkscreen to figure out screen additions and primary
> modifications.
> I'm not merging to master yet as I'm experiencing some issues but it's
> already far more comfortable to work with than QGuiApplication::screens().
>
> [1] https://bugreports.qt-project.org/browse/QTBUG-38404
>
> CCMAIL: plasma-devel@kde.org
>
> M  +1-0CMakeLists.txt
> M  +1-0shell/CMakeLists.txt
> M  +151  -42   shell/shellcorona.cpp
> M  +11   -2shell/shellcorona.h
>
>
> http://commits.kde.org/plasma-workspace/168c15a463746cf9039f2f9e188b1827ed809f97
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 31e29b2..8078b0b 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -13,6 +13,7 @@ find_package(KF5 REQUIRED COMPONENTS
>  IdleTime ThreadWeaver Declarative PlasmaQuick WebKit
> KDELibs4Support)
>
>  find_package(KF5 REQUIRED COMPONENTS SysGuard)
> +find_package(KF5 REQUIRED COMPONENTS Screen)
>  find_package(KWinDBusInterface CONFIG REQUIRED)
>
>  include(KDEInstallDirs)
> diff --git a/shell/CMakeLists.txt b/shell/CMakeLists.txt
> index 5f58d8c..5b2a290 100644
> --- a/shell/CMakeLists.txt
> +++ b/shell/CMakeLists.txt
> @@ -87,6 +87,7 @@ target_link_libraries(plasma-shell
>   KF5::Activities
>   KF5::GlobalAccel
>   KF5::DBusAddons
> + KF5::Screen
>  )
>  if (TARGET KF5::TextEditor)
>   target_link_libraries(plasma-shell KF5::TextEditor)
> diff --git a/shell/shellcorona.cpp b/shell/shellcorona.cpp
> index 2f82132..0670b43 100644
> --- a/shell/shellcorona.cpp
> +++ b/shell/shellcorona.cpp
> @@ -42,6 +42,9 @@
>  #include 
>  #include 
>
> +#include 
> +#include 
> +
>  #include "config-ktexteditor.h" // HAVE_KTEXTEDITOR
>
>
> @@ -59,8 +62,6 @@
>
>  #include "plasmashelladaptor.h"
>
> -
> -
>  static const int s_configSyncDelay = 1; // 10 seconds
>
>  class ShellCorona::Private {
> @@ -70,7 +71,8 @@ public:
>activityController(new KActivities::Controller(q)),
>activityConsumer(new KActivities::Consumer(q)),
>addPanelAction(nullptr),
> -  addPanelsMenu(nullptr)
> +  addPanelsMenu(nullptr),
> +  screenConfiguration(nullptr)
>  {
>  appConfigSyncTimer.setSingleShot(true);
>  appConfigSyncTimer.setInterval(s_configSyncDelay);
> @@ -99,10 +101,20 @@ public:
>  QWeakPointer console;
>  #endif
>
> +KScreen::Config* screenConfiguration;
>  QTimer waitingPanelsTimer;
>  QTimer appConfigSyncTimer;
>  };
>
> +static QScreen* outputToScreen(KScreen::Output* output)
> +{
> +foreach(QScreen* screen, QGuiApplication::screens()) {
> +if(screen->name() == output->name()) {
> +return screen;
> +}
> +}
> +return 0;
> +}
>
>  WorkspaceScripting::DesktopScriptEngine * ShellCorona::scriptEngine()
> const
>  {
> @@ -233,6 +245,20 @@ QString ShellCorona::shell() const
>  return d->shell;
>  }
>
> +static QList sortOutputs(const QHash KScreen::Output*> &outputs)
> +{
> +QList ret;
> +foreach(KScreen::Output* output, outputs) {
> +if(!output->isEnabled())
> +;
> +else if(output->isPrimary())
> +ret.prepend(output);
> +else
> +ret.append(output);
> +}
> +return ret;
> +}
> +
>  void ShellCorona::load()
>  {
>  if (d->shell.isEmpty() ||
> @@ -269,17 +295,73 @@ void ShellCorona::load()
>  }
>  }
>
> -for (QScreen *screen : QGuiApplication::screens()) {
> -screenAdded(screen);
> +d->screenConfiguration = KScreen::Config::current();
> +KScreen::ConfigMonitor::instance()->addConfig(d->screenConfiguration);
> +for (KScreen::Output *output :
> sortOutputs(d->screenConfiguration->connectedOutputs())) {
> +outputAdded(output);
>  }
> -connect(qApp, &QGuiApplication::screenAdded,
> -this, &ShellCorona::screenAdded);
> +connect(d->screenConfiguration, &KScreen::Config::outputAdded,
> +this, &ShellCorona::outputAdded);
> +connect(d->screenConfiguration,
> &KScreen::Config::primaryOutputChanged,
> +this, &ShellCorona::primaryOutputChanged);
>
>  if (!d->waitingPanels.isEmpty()) {
>  d->waitingPanelsTimer.start();
>  }
>  }
>
> +void ShellCorona::primaryOutputChanged()
> +{
> +KScreen::Config* current = d->screenConfiguration;
> +QScreen* newPrimary = outputToScreen(current->primaryOutput());
> +int i=0;
> +f

Re: Review Request 117801: Make PMC MPRIS compatible

2014-05-01 Thread Ashish Madeti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117801/
---

(Updated May 1, 2014, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Add Dbus adaptors through which any other application can programmatically 
control PMC using MPRIS specifications.
http://specifications.freedesktop.org/mpris-spec/latest/index.html


Diffs
-

  libs/mediacenter/CMakeLists.txt 37769f6 
  libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION 
  libs/mediacenter/mpris2/mpris2.h PRE-CREATION 
  libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION 
  mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
  shells/newshell/mainwindow.h 9cbf77c 
  shells/newshell/mainwindow.cpp c1be61a 
  shells/newshell/package/contents/ui/mediacenter.qml 50f3576 

Diff: https://git.reviewboard.kde.org/r/117801/diff/


Testing
---

Tested with qdbusviewer and mpristester : 
https://github.com/randomguy3/mpristester


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117801: Make PMC MPRIS compatible

2014-05-01 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117801/#review57048
---

Ship it!


looks good now. Please make sure to run mpristester once more before pushing to 
master.

- Shantanu Tushar


On April 27, 2014, 7:12 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117801/
> ---
> 
> (Updated April 27, 2014, 7:12 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
> Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Add Dbus adaptors through which any other application can programmatically 
> control PMC using MPRIS specifications.
> http://specifications.freedesktop.org/mpris-spec/latest/index.html
> 
> 
> Diffs
> -
> 
>   libs/mediacenter/CMakeLists.txt 37769f6 
>   libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION 
>   libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION 
>   libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION 
>   libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION 
>   libs/mediacenter/mpris2/mpris2.h PRE-CREATION 
>   libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   shells/newshell/mainwindow.h 9cbf77c 
>   shells/newshell/mainwindow.cpp c1be61a 
>   shells/newshell/package/contents/ui/mediacenter.qml 50f3576 
> 
> Diff: https://git.reviewboard.kde.org/r/117801/diff/
> 
> 
> Testing
> ---
> 
> Tested with qdbusviewer and mpristester : 
> https://github.com/randomguy3/mpristester
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-05-01 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117923/#review57046
---

Ship it!


Cool, looks to do what is expected. Can go in with a minor fix-


libs/mediacenter/CMakeLists.txt


NEPOMUK_CORE_LIBRARY is not required


- Shantanu Tushar


On May 1, 2014, 7:32 a.m., Sinny Kumari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117923/
> ---
> 
> (Updated May 1, 2014, 7:32 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Currently test is getting compiled along with libs. Due to this same source 
> was compiled multiple times. With this patch, Plasma-medacenter creates a new 
> plasmamediacentertest library which has default all exported symbols from 
> libs. Now, test can be linked with libplasmamediacentertest.
> 
> 
> Diffs
> -
> 
>   libs/CMakeLists.txt a0a0f72 
>   libs/mediacenter/CMakeLists.txt 2dbec83 
>   libs/mediacenter/test/fakemediavalidator.h 201973c 
>   libs/mediacenter/test/fakemediavalidator.cpp 9b2feca 
>   libs/mediacenter/test/lastfmimagefetchertest.h 6422824 
>   libs/mediacenter/test/lastfmimagefetchertest.cpp b0fcf6f 
>   libs/mediacenter/test/mediacentertest.h 6997ae9 
>   libs/mediacenter/test/mediacentertest.cpp 96a70a9 
>   libs/mediacenter/test/medialibrarytest.h 718457d 
>   libs/mediacenter/test/medialibrarytest.cpp 08af239 
>   libs/mediacenter/test/mediatest.h da16e59 
>   libs/mediacenter/test/mediatest.cpp 832fedb 
>   libs/mediacenter/test/pmcmediatest.h 2322176 
>   libs/mediacenter/test/pmcmediatest.cpp 0da8dd3 
>   libs/mediacenter/test/singletonfactorytest.h 79e4197 
>   libs/mediacenter/test/singletonfactorytest.cpp 308487d 
>   libs/mediacenter/test/testhelpers.h 9825e85 
>   libs/test/CMakeLists.txt PRE-CREATION 
>   libs/test/fakemediavalidator.h PRE-CREATION 
>   libs/test/fakemediavalidator.cpp PRE-CREATION 
>   libs/test/lastfmimagefetchertest.h PRE-CREATION 
>   libs/test/lastfmimagefetchertest.cpp PRE-CREATION 
>   libs/test/mediacentertest.h PRE-CREATION 
>   libs/test/mediacentertest.cpp PRE-CREATION 
>   libs/test/medialibrarytest.h PRE-CREATION 
>   libs/test/medialibrarytest.cpp PRE-CREATION 
>   libs/test/mediatest.h PRE-CREATION 
>   libs/test/mediatest.cpp PRE-CREATION 
>   libs/test/pmcmediatest.h PRE-CREATION 
>   libs/test/pmcmediatest.cpp PRE-CREATION 
>   libs/test/singletonfactorytest.h PRE-CREATION 
>   libs/test/singletonfactorytest.cpp PRE-CREATION 
>   libs/test/testhelpers.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117923/diff/
> 
> 
> Testing
> ---
> 
> Application runs as expected and all unit test passed
> 
> 
> Thanks,
> 
> Sinny Kumari
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-05-01 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117923/
---

(Updated May 1, 2014, 7:32 a.m.)


Review request for Plasma.


Changes
---

Forgot to add libs/test/CMakeLists.txt in previous pacth


Repository: plasma-mediacenter


Description
---

Currently test is getting compiled along with libs. Due to this same source was 
compiled multiple times. With this patch, Plasma-medacenter creates a new 
plasmamediacentertest library which has default all exported symbols from libs. 
Now, test can be linked with libplasmamediacentertest.


Diffs (updated)
-

  libs/CMakeLists.txt a0a0f72 
  libs/mediacenter/CMakeLists.txt 2dbec83 
  libs/mediacenter/test/fakemediavalidator.h 201973c 
  libs/mediacenter/test/fakemediavalidator.cpp 9b2feca 
  libs/mediacenter/test/lastfmimagefetchertest.h 6422824 
  libs/mediacenter/test/lastfmimagefetchertest.cpp b0fcf6f 
  libs/mediacenter/test/mediacentertest.h 6997ae9 
  libs/mediacenter/test/mediacentertest.cpp 96a70a9 
  libs/mediacenter/test/medialibrarytest.h 718457d 
  libs/mediacenter/test/medialibrarytest.cpp 08af239 
  libs/mediacenter/test/mediatest.h da16e59 
  libs/mediacenter/test/mediatest.cpp 832fedb 
  libs/mediacenter/test/pmcmediatest.h 2322176 
  libs/mediacenter/test/pmcmediatest.cpp 0da8dd3 
  libs/mediacenter/test/singletonfactorytest.h 79e4197 
  libs/mediacenter/test/singletonfactorytest.cpp 308487d 
  libs/mediacenter/test/testhelpers.h 9825e85 
  libs/test/CMakeLists.txt PRE-CREATION 
  libs/test/fakemediavalidator.h PRE-CREATION 
  libs/test/fakemediavalidator.cpp PRE-CREATION 
  libs/test/lastfmimagefetchertest.h PRE-CREATION 
  libs/test/lastfmimagefetchertest.cpp PRE-CREATION 
  libs/test/mediacentertest.h PRE-CREATION 
  libs/test/mediacentertest.cpp PRE-CREATION 
  libs/test/medialibrarytest.h PRE-CREATION 
  libs/test/medialibrarytest.cpp PRE-CREATION 
  libs/test/mediatest.h PRE-CREATION 
  libs/test/mediatest.cpp PRE-CREATION 
  libs/test/pmcmediatest.h PRE-CREATION 
  libs/test/pmcmediatest.cpp PRE-CREATION 
  libs/test/singletonfactorytest.h PRE-CREATION 
  libs/test/singletonfactorytest.cpp PRE-CREATION 
  libs/test/testhelpers.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117923/diff/


Testing
---

Application runs as expected and all unit test passed


Thanks,

Sinny Kumari

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel