Review Request 117954: Port keditfiletype away from kde4support

2014-05-02 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117954/
---

Review request for Plasma.


Repository: kde-cli-tools


Description
---

This patch contains multiple commits, which I can make available if needed. It 
ports keditfiletype away from kde4support, which helps identifying its 
dependencies so that it can hopefully be moved closer to the classes which need 
it in frameworks (right now kwidgetsaddons and kio forks it)


Diffs
-

  CMakeLists.txt d62ee8b 
  keditfiletype/CMakeLists.txt 0adfde9 
  keditfiletype/filegroupdetails.cpp c733ba4 
  keditfiletype/filetypedetails.h 7c0abb4 
  keditfiletype/filetypedetails.cpp bfcbb07 
  keditfiletype/filetypesview.h 82fd0ab 
  keditfiletype/filetypesview.cpp 886892f 
  keditfiletype/keditfiletype.h 0b235ce 
  keditfiletype/keditfiletype.cpp aab0830 
  keditfiletype/kservicelistwidget.h c817d24 
  keditfiletype/kservicelistwidget.cpp 88dface 
  keditfiletype/kserviceselectdlg.h 8e6d0d0 
  keditfiletype/kserviceselectdlg.cpp 09c7c5d 
  keditfiletype/mimetypedata.h 042b043 
  keditfiletype/mimetypedata.cpp 057113f 
  keditfiletype/mimetypewriter.h 5a618a6 
  keditfiletype/mimetypewriter.cpp be5e5d4 
  keditfiletype/newtypedlg.h fba8385 
  keditfiletype/newtypedlg.cpp c933a8f 
  keditfiletype/sharedmimeinfoversion.h 9824d7b 
  keditfiletype/sharedmimeinfoversion.cpp 9dabf0e 
  keditfiletype/tests/CMakeLists.txt 489bb4d 
  keditfiletype/tests/filetypestest.cpp 68eef26 
  keditfiletype/typeslistitem.h 05e425a 
  keditfiletype/typeslistitem.cpp 97cd3c1 

Diff: https://git.reviewboard.kde.org/r/117954/diff/


Testing
---

Program starts and looks like it behaves correctly. Unit-test is failing, but 
was already failing before :/


Thanks,

Aurélien Gâteau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117813: Make the system tray faster

2014-05-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/
---

(Updated May 2, 2014, 4:10 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Port QQmlListProperty to QAbstractListModel.
QQmlListProperty only has a signal that the list has changed.This means when 
used in a ListView every delegate has to be redone whenever a single item is 
inserted or removed rather than just moved.

Given TaskDelegate is not the simplest of things this has a performance gain, 
most noticeably on startup. Also rather than sorting all items after an insert 
items are inserted in the right place using qLowerBound. Now we have the 
correct signals we can remove the compression, they won't add anything. 


Other commits:

Avoid constructing a QString for comparing, use QLatin1String for == operators.

Remove useless include

Do not construct a map inside a lessThan function

lessThan functions have to be fast.
Also Map -> Hash as we're not using order here.


Diffs (updated)
-

  applets/systemtray/package/contents/ui/CompactRepresentation.qml 01308e7 
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 646b908 
  applets/systemtray/package/contents/ui/PlasmoidItem.qml 0eb1687 
  applets/systemtray/package/contents/ui/StatusNotifierItem.qml fc889a8 
  applets/systemtray/package/contents/ui/TaskDelegate.qml 913d8f1 
  applets/systemtray/package/contents/ui/TaskListDelegate.qml 5501e02 
  applets/systemtray/package/contents/ui/main.qml d1a6851 
  applets/systemtray/plugin/CMakeLists.txt f6e23b4 
  applets/systemtray/plugin/host.h 02c5bbe 
  applets/systemtray/plugin/host.cpp eafd0b6 
  applets/systemtray/plugin/task.h 68dcd12 
  applets/systemtray/plugin/task.cpp 1f8e3ca 
  applets/systemtray/plugin/tasklistmodel.h PRE-CREATION 
  applets/systemtray/plugin/tasklistmodel.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117813/diff/


Testing
---

Seems to work :)

see branch davidedmundson/faster_systray to test


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-05-02 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/
---

(Updated May 2, 2014, 3:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Before, the notifications would create new Dialog for each incoming 
notification. Now it reuses only 3 Dialogs to save resources.

The notification popup is a QML component; I decided to handle all this in the 
cpp plugin as JS Array is quite crap compared to QList and I had quite some 
crashes in QV4 on slightly heavier Array processing. But as the QML component 
needs to talk to the dataengine (like when you close the notification or 
exectue an action) and uses some methods from the rest of the plasmoid, I can't 
just instantiate it from the cpp side. So I create the component in QML, pass 
it to CPP, set the ownership to CPP so it's not deleted ever and then handle it 
all there.


Diffs
-

  applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
  applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
  applets/notifications/plugin/notificationshelper.h 1e1f6c2 
  applets/notifications/plugin/notificationshelper.cpp 1edfbad 

Diff: https://git.reviewboard.kde.org/r/117903/diff/


Testing
---

Plasma no more leaks memory with every notification (the root memleak, coming 
from Dialog, is quite possibly still present, but the notifications don't 
expose it anymore). Notifications work as before, even better.

For testing purposes, you can try running 

for i in {1..10}; do notify-send asasd$i -i kde; done


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-05-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/#review57145
---


This review has been submitted with commit 
8f76fed3a4cc3f1f16edc43d816c51f32ae05b88 by Martin Klapetek to branch master.

- Commit Hook


On May 2, 2014, 12:40 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117903/
> ---
> 
> (Updated May 2, 2014, 12:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Before, the notifications would create new Dialog for each incoming 
> notification. Now it reuses only 3 Dialogs to save resources.
> 
> The notification popup is a QML component; I decided to handle all this in 
> the cpp plugin as JS Array is quite crap compared to QList and I had quite 
> some crashes in QV4 on slightly heavier Array processing. But as the QML 
> component needs to talk to the dataengine (like when you close the 
> notification or exectue an action) and uses some methods from the rest of the 
> plasmoid, I can't just instantiate it from the cpp side. So I create the 
> component in QML, pass it to CPP, set the ownership to CPP so it's not 
> deleted ever and then handle it all there.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
>   applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
>   applets/notifications/plugin/notificationshelper.h 1e1f6c2 
>   applets/notifications/plugin/notificationshelper.cpp 1edfbad 
> 
> Diff: https://git.reviewboard.kde.org/r/117903/diff/
> 
> 
> Testing
> ---
> 
> Plasma no more leaks memory with every notification (the root memleak, coming 
> from Dialog, is quite possibly still present, but the notifications don't 
> expose it anymore). Notifications work as before, even better.
> 
> For testing purposes, you can try running 
> 
> for i in {1..10}; do notify-send asasd$i -i kde; done
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-02 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/#review57143
---

Ship it!


Looks good to me

- Martin Klapetek


On May 2, 2014, 4:42 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117946/
> ---
> 
> (Updated May 2, 2014, 4:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Track screen changes in the containment when the containment is inside an 
> applet
> 
> Make the system tray containment update which screen it is on when the
> system tray applet is moved.
> 
> This fixes notifications if the panel is moved between screens.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/containment_p.h 24049c7 
>   src/plasma/private/containment_p.cpp 9e67382 
> 
> Diff: https://git.reviewboard.kde.org/r/117946/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Track screen changes in the containment when the containment is inside an applet

Make the system tray containment update which screen it is on when the
system tray applet is moved.

This fixes notifications if the panel is moved between screens.


Diffs
-

  src/plasma/private/containment_p.h 24049c7 
  src/plasma/private/containment_p.cpp 9e67382 

Diff: https://git.reviewboard.kde.org/r/117946/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-05-02 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915/
---

(Updated May 2, 2014, 2:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Vishesh Handa.


Repository: plasma-mediacenter


Description
---

Just like the Nepomuk media source, the Baloo media source needs to provide the 
date/time information for media. This is used to sort the media to show the 
more recent media first.
For images, the date/time when the photo was actually taken is used, and the 
file creation date/time is used for other media.


Diffs
-

  plugins/baloosearch/CMakeLists.txt 1ff81fb 
  plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION 
  plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION 
  plugins/baloosearch/baloosearchmediasource.h e315de4 
  plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 
  plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION 
  plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION 
  plugins/baloosearch/searchresulthandler.h PRE-CREATION 
  plugins/baloosearch/searchresulthandler.cpp PRE-CREATION 
  plugins/baloosearch/videosearchresulthandler.h PRE-CREATION 
  plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117915/diff/


Testing
---

Tested with all three types of media, works fine. Unit tests for the new code 
to follow.


Thanks,

Shantanu Tushar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117931: Restrict sourceSize to screen size

2014-05-02 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117931/
---

(Updated May 2, 2014, 2:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 334176
http://bugs.kde.org/show_bug.cgi?id=334176


Repository: plasma-mediacenter


Description
---

This helps by limiting the image source width so that it doesnt load full 
versions of images with resolutions more than the screen size.


Diffs
-

  mediaelements/imageviewer/ImageViewer.qml b182bf2 

Diff: https://git.reviewboard.kde.org/r/117931/diff/


Testing
---

works with both portrait and landscape


Thanks,

Shantanu Tushar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-05-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915/#review57137
---


This review has been submitted with commit 
e8e58d79829f07f3821bbf9202cbf63eb509327d by Shantanu Tushar to branch master.

- Commit Hook


On May 1, 2014, 6:06 a.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117915/
> ---
> 
> (Updated May 1, 2014, 6:06 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Just like the Nepomuk media source, the Baloo media source needs to provide 
> the date/time information for media. This is used to sort the media to show 
> the more recent media first.
> For images, the date/time when the photo was actually taken is used, and the 
> file creation date/time is used for other media.
> 
> 
> Diffs
> -
> 
>   plugins/baloosearch/CMakeLists.txt 1ff81fb 
>   plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/baloosearchmediasource.h e315de4 
>   plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 
>   plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117915/diff/
> 
> 
> Testing
> ---
> 
> Tested with all three types of media, works fine. Unit tests for the new code 
> to follow.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117931: Restrict sourceSize to screen size

2014-05-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117931/#review57136
---


This review has been submitted with commit 
d2979dac2fb6a91ca256ca89efc1c22f923a58c5 by Shantanu Tushar to branch master.

- Commit Hook


On May 1, 2014, 1:33 p.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117931/
> ---
> 
> (Updated May 1, 2014, 1:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 334176
> http://bugs.kde.org/show_bug.cgi?id=334176
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This helps by limiting the image source width so that it doesnt load full 
> versions of images with resolutions more than the screen size.
> 
> 
> Diffs
> -
> 
>   mediaelements/imageviewer/ImageViewer.qml b182bf2 
> 
> Diff: https://git.reviewboard.kde.org/r/117931/diff/
> 
> 
> Testing
> ---
> 
> works with both portrait and landscape
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-05-02 Thread Shantanu Tushar 


> On May 2, 2014, 9:07 a.m., Vishesh Handa wrote:
> > Looks fine from a Baloo point of view. I cannot comment on the PMC parts, I 
> > don't know the code.

That is cool :)


> On May 2, 2014, 9:07 a.m., Vishesh Handa wrote:
> > plugins/baloosearch/searchresulthandler.cpp, line 36
> > 
> >
> > Please keep in mind that this is sync, and you'll be blocking. You want 
> > to put it another thread via the Runnable if you want it to be async.

That is fine, the media sources are themselves running in a separate thread.


> On May 2, 2014, 9:07 a.m., Vishesh Handa wrote:
> > plugins/baloosearch/audiosearchresulthandler.cpp, line 60
> > 
> >
> > Considering that you're checking if the title is empty, do you want to 
> > do the same for the Artist and Album?

Usually things like empty Album and Artist are handled by the Media Library 
which shows then as "Unknown" so there is no need to check this here.

For the title, when we haven't fetched the File metadata, we would've put the 
filename (foo.mp3) as the title. This check is to make sure that we don't end 
up erasing foo.mp3 unless the title "The Foo Song" is available in Baloo::File.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915/#review57102
---


On May 1, 2014, 6:06 a.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117915/
> ---
> 
> (Updated May 1, 2014, 6:06 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Just like the Nepomuk media source, the Baloo media source needs to provide 
> the date/time information for media. This is used to sort the media to show 
> the more recent media first.
> For images, the date/time when the photo was actually taken is used, and the 
> file creation date/time is used for other media.
> 
> 
> Diffs
> -
> 
>   plugins/baloosearch/CMakeLists.txt 1ff81fb 
>   plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/baloosearchmediasource.h e315de4 
>   plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 
>   plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117915/diff/
> 
> 
> Testing
> ---
> 
> Tested with all three types of media, works fine. Unit tests for the new code 
> to follow.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/

2014-05-02 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117942/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/


Diffs
-

  kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 
  kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 

Diff: https://git.reviewboard.kde.org/r/117942/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117941: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/

2014-05-02 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117941/
---

(Updated May 2, 2014, 1:14 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
---

use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/


Diffs
-

  kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 

Diff: https://git.reviewboard.kde.org/r/117941/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117941: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/

2014-05-02 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117941/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/


Diffs
-

  kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 

Diff: https://git.reviewboard.kde.org/r/117941/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-05-02 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/
---

(Updated May 2, 2014, 2:40 p.m.)


Review request for Plasma.


Changes
---

* created special private slot for the timer-based queued popup display, so it 
can be separated from the invokable method and that method now does less 
shenanigans
* changed the method name from "positionPopup" to "displayNotification" as the 
purpose has changed
  ** forgot to change the name in the qml; done locally now


Repository: plasma-workspace


Description
---

Before, the notifications would create new Dialog for each incoming 
notification. Now it reuses only 3 Dialogs to save resources.

The notification popup is a QML component; I decided to handle all this in the 
cpp plugin as JS Array is quite crap compared to QList and I had quite some 
crashes in QV4 on slightly heavier Array processing. But as the QML component 
needs to talk to the dataengine (like when you close the notification or 
exectue an action) and uses some methods from the rest of the plasmoid, I can't 
just instantiate it from the cpp side. So I create the component in QML, pass 
it to CPP, set the ownership to CPP so it's not deleted ever and then handle it 
all there.


Diffs (updated)
-

  applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
  applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
  applets/notifications/plugin/notificationshelper.h 1e1f6c2 
  applets/notifications/plugin/notificationshelper.cpp 1edfbad 

Diff: https://git.reviewboard.kde.org/r/117903/diff/


Testing
---

Plasma no more leaks memory with every notification (the root memleak, coming 
from Dialog, is quite possibly still present, but the notifications don't 
expose it anymore). Notifications work as before, even better.

For testing purposes, you can try running 

for i in {1..10}; do notify-send asasd$i -i kde; done


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-05-02 Thread Martin Klapetek 


> On May 2, 2014, 2:12 p.m., David Edmundson wrote:
> > applets/notifications/package/contents/ui/Notifications.qml, line 41
> > 
> >
> > personally I would have parsed the QQmlComponent object to cpp then 
> > done the create using http://qt-project.org/doc/qt-5/qqmlcomponent.html
> > It makes them easier to track

I tried loading it in cpp (using KDeclarative and Plasma::Package), the problem 
was that it didn't have access to the rest of the plasmoid and vice-versa -> 
the ultimate result was that the plasmoid was unable to communicate with the 
dataengine which meant no actions or unable to close the notification from the 
dataengine (like if you switch to a chat window and the notification should 
just close). So I went for this way, it's the easiest and works just fine.


> On May 2, 2014, 2:12 p.m., David Edmundson wrote:
> > applets/notifications/plugin/notificationshelper.h, line 45
> > 
> >
> > slot and invokable?
> > 
> > doubly invokable!
> > 
> > also can you document the QVariantMap a bit to say what the keys are 
> > (or that it's the data from the dataengine or something..)

eheh, yeah, this was just moved from above the slots; will fix


> On May 2, 2014, 2:12 p.m., David Edmundson wrote:
> > applets/notifications/plugin/notificationshelper.cpp, line 142
> > 
> >
> > is there a nice constant in plasma for the 300?
> > 
> > There's a shortDuration and longDuration exposed to plasma from 
> > somewhere.

That's in units, which have no equiv in cpp (except reading the config file 
directly). I guess I could just pass it over from QML if really needed


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/#review57120
---


On April 30, 2014, 4:27 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117903/
> ---
> 
> (Updated April 30, 2014, 4:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Before, the notifications would create new Dialog for each incoming 
> notification. Now it reuses only 3 Dialogs to save resources.
> 
> The notification popup is a QML component; I decided to handle all this in 
> the cpp plugin as JS Array is quite crap compared to QList and I had quite 
> some crashes in QV4 on slightly heavier Array processing. But as the QML 
> component needs to talk to the dataengine (like when you close the 
> notification or exectue an action) and uses some methods from the rest of the 
> plasmoid, I can't just instantiate it from the cpp side. So I create the 
> component in QML, pass it to CPP, set the ownership to CPP so it's not 
> deleted ever and then handle it all there.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
>   applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
>   applets/notifications/plugin/notificationshelper.h 1e1f6c2 
>   applets/notifications/plugin/notificationshelper.cpp 1edfbad 
> 
> Diff: https://git.reviewboard.kde.org/r/117903/diff/
> 
> 
> Testing
> ---
> 
> Plasma no more leaks memory with every notification (the root memleak, coming 
> from Dialog, is quite possibly still present, but the notifications don't 
> expose it anymore). Notifications work as before, even better.
> 
> For testing purposes, you can try running 
> 
> for i in {1..10}; do notify-send asasd$i -i kde; done
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-05-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/#review57120
---

Ship it!


Looks good, minor comments which you can chose to ignore.


applets/notifications/package/contents/ui/Notifications.qml


personally I would have parsed the QQmlComponent object to cpp then done 
the create using http://qt-project.org/doc/qt-5/qqmlcomponent.html
It makes them easier to track



applets/notifications/plugin/notificationshelper.h


slot and invokable?

doubly invokable!

also can you document the QVariantMap a bit to say what the keys are (or 
that it's the data from the dataengine or something..)



applets/notifications/plugin/notificationshelper.cpp


is there a nice constant in plasma for the 300?

There's a shortDuration and longDuration exposed to plasma from somewhere.


- David Edmundson


On April 30, 2014, 2:27 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117903/
> ---
> 
> (Updated April 30, 2014, 2:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Before, the notifications would create new Dialog for each incoming 
> notification. Now it reuses only 3 Dialogs to save resources.
> 
> The notification popup is a QML component; I decided to handle all this in 
> the cpp plugin as JS Array is quite crap compared to QList and I had quite 
> some crashes in QV4 on slightly heavier Array processing. But as the QML 
> component needs to talk to the dataengine (like when you close the 
> notification or exectue an action) and uses some methods from the rest of the 
> plasmoid, I can't just instantiate it from the cpp side. So I create the 
> component in QML, pass it to CPP, set the ownership to CPP so it's not 
> deleted ever and then handle it all there.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
>   applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
>   applets/notifications/plugin/notificationshelper.h 1e1f6c2 
>   applets/notifications/plugin/notificationshelper.cpp 1edfbad 
> 
> Diff: https://git.reviewboard.kde.org/r/117903/diff/
> 
> 
> Testing
> ---
> 
> Plasma no more leaks memory with every notification (the root memleak, coming 
> from Dialog, is quite possibly still present, but the notifications don't 
> expose it anymore). Notifications work as before, even better.
> 
> For testing purposes, you can try running 
> 
> for i in {1..10}; do notify-send asasd$i -i kde; done
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-05-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/#review57118
---

Ship it!


to me looks fine.
have to trust you you tested it thoroughly tough :)

- Marco Martin


On April 30, 2014, 2:27 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117903/
> ---
> 
> (Updated April 30, 2014, 2:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Before, the notifications would create new Dialog for each incoming 
> notification. Now it reuses only 3 Dialogs to save resources.
> 
> The notification popup is a QML component; I decided to handle all this in 
> the cpp plugin as JS Array is quite crap compared to QList and I had quite 
> some crashes in QV4 on slightly heavier Array processing. But as the QML 
> component needs to talk to the dataengine (like when you close the 
> notification or exectue an action) and uses some methods from the rest of the 
> plasmoid, I can't just instantiate it from the cpp side. So I create the 
> component in QML, pass it to CPP, set the ownership to CPP so it's not 
> deleted ever and then handle it all there.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
>   applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
>   applets/notifications/plugin/notificationshelper.h 1e1f6c2 
>   applets/notifications/plugin/notificationshelper.cpp 1edfbad 
> 
> Diff: https://git.reviewboard.kde.org/r/117903/diff/
> 
> 
> Testing
> ---
> 
> Plasma no more leaks memory with every notification (the root memleak, coming 
> from Dialog, is quite possibly still present, but the notifications don't 
> expose it anymore). Notifications work as before, even better.
> 
> For testing purposes, you can try running 
> 
> for i in {1..10}; do notify-send asasd$i -i kde; done
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117813: Make the system tray faster

2014-05-02 Thread Martin Klapetek 


> On May 2, 2014, 10:39 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> David Edmundson wrote:
> I have a crash when combined with Martin's new notifications.
> 
> Fixing first.
>

Speaking of which https://git.reviewboard.kde.org/r/117903/ ;)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review57097
---


On April 28, 2014, 12:51 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117813/
> ---
> 
> (Updated April 28, 2014, 12:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Port QQmlListProperty to QAbstractListModel.
> QQmlListProperty only has a signal that the list has changed.This means when 
> used in a ListView every delegate has to be redone whenever a single item is 
> inserted or removed rather than just moved.
> 
> Given TaskDelegate is not the simplest of things this has a performance gain, 
> most noticeably on startup. Also rather than sorting all items after an 
> insert items are inserted in the right place using qLowerBound. Now we have 
> the correct signals we can remove the compression, they won't add anything. 
> 
> 
> Other commits:
> 
> Avoid constructing a QString for comparing, use QLatin1String for == 
> operators.
> 
> Remove useless include
> 
> Do not construct a map inside a lessThan function
> 
> lessThan functions have to be fast.
> Also Map -> Hash as we're not using order here.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 2ef180b 
>   applets/systemtray/package/contents/ui/PlasmoidItem.qml 0eb1687 
>   applets/systemtray/package/contents/ui/StatusNotifierItem.qml fc889a8 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 913d8f1 
>   applets/systemtray/package/contents/ui/TaskListDelegate.qml 5501e02 
>   applets/systemtray/plugin/CMakeLists.txt f6e23b4 
>   applets/systemtray/plugin/host.h 02c5bbe 
>   applets/systemtray/plugin/host.cpp eafd0b6 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 2b846f2 
>   applets/systemtray/plugin/tasklistmodel.h PRE-CREATION 
>   applets/systemtray/plugin/tasklistmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117813/diff/
> 
> 
> Testing
> ---
> 
> Seems to work :)
> 
> see branch davidedmundson/faster_systray to test
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117813: Make the system tray faster

2014-05-02 Thread David Edmundson 


> On May 2, 2014, 8:39 a.m., Marco Martin wrote:
> > what's the status of this?

I have a crash when combined with Martin's new notifications.

Fixing first.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review57097
---


On April 27, 2014, 10:51 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117813/
> ---
> 
> (Updated April 27, 2014, 10:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Port QQmlListProperty to QAbstractListModel.
> QQmlListProperty only has a signal that the list has changed.This means when 
> used in a ListView every delegate has to be redone whenever a single item is 
> inserted or removed rather than just moved.
> 
> Given TaskDelegate is not the simplest of things this has a performance gain, 
> most noticeably on startup. Also rather than sorting all items after an 
> insert items are inserted in the right place using qLowerBound. Now we have 
> the correct signals we can remove the compression, they won't add anything. 
> 
> 
> Other commits:
> 
> Avoid constructing a QString for comparing, use QLatin1String for == 
> operators.
> 
> Remove useless include
> 
> Do not construct a map inside a lessThan function
> 
> lessThan functions have to be fast.
> Also Map -> Hash as we're not using order here.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 2ef180b 
>   applets/systemtray/package/contents/ui/PlasmoidItem.qml 0eb1687 
>   applets/systemtray/package/contents/ui/StatusNotifierItem.qml fc889a8 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 913d8f1 
>   applets/systemtray/package/contents/ui/TaskListDelegate.qml 5501e02 
>   applets/systemtray/plugin/CMakeLists.txt f6e23b4 
>   applets/systemtray/plugin/host.h 02c5bbe 
>   applets/systemtray/plugin/host.cpp eafd0b6 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 2b846f2 
>   applets/systemtray/plugin/tasklistmodel.h PRE-CREATION 
>   applets/systemtray/plugin/tasklistmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117813/diff/
> 
> 
> Testing
> ---
> 
> Seems to work :)
> 
> see branch davidedmundson/faster_systray to test
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-workspace_master_qt5 #137

2014-05-02 Thread KDE CI System 
See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-desktop_master_qt5 #118

2014-05-02 Thread KDE CI System 
See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : khotkeys_master_qt5 #21

2014-05-02 Thread KDE CI System 
See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : kmenuedit_master_qt5 #15

2014-05-02 Thread KDE CI System 
See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #136

2014-05-02 Thread KDE CI System 
See 

Changes:

[notmart] make sure nothing is positioned to the half pixel

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson525002126563970532.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   78024a9..ba097fe  davidedmundson/faster_systray -> 
origin/davidedmundson/faster_systray
   d5fa781..c8e8ab6  master -> origin/master
 * [new branch]  plasmashell+libkscreen -> origin/plasmashell+libkscreen
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at d5fa781 use correct soversion in libtaskmanager
Removing build/
Removing install/
Success build forhudson.tasks.Shell@807d1fd
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
Checking out Revision c8e8ab6212497266bbcba2135b9a020470f125d7 
(refs/heads/jenkins)
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson7075502549453051375.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kwidgetsaddons - Branch master
 khelpcenter - Branch master
 kjobwidgets - Branch master
 sonnet - Branch master
 kjsembed - Branch master
 polkit-qt-1 - Branch qt5
 threadweaver - Branch master
 qt5 - Branch stable
 kinit - Branch master
 kwindowsystem - Branch master
 kxmlgui - Branch master
 kcrash - Branch master
 frameworkintegration - Branch master
 kded - Branch master
 kwallet - Branch master
 kcodecs - Branch master
 baloo - Branch frameworks
 khtml - Branch master
 breeze - Branch master
 kconfigwidgets - Branch master
 plasma-framework - Branch master
 kdesignerplugin - Branch master
 kcmutils - Branch master
 solid - Branch master
 kf5umbrella - Branch master
 kglobalaccel - Branch master
 kio-extras - Branch master
 kdesupport-svn - Branch master
 knewstuff - Branch master
 kparts - Branch master
 kross - Branch master
 kdbusaddons - Branch master
 kdelibs4support - Branch master
 kjs - Branch master
 kdoctools - Branch master
 kauth - Branch master
 kbookmarks - Branch master
 extra-cmake-modules - Branch master
 kunitconversion - Branch master
 libksysguard - Branch master
 karchive - Branch master
 kiconthemes - Branch master
 kitemviews - Branch master
 kdesu - Branch master
 kitemmodels - Branch master
 ktexteditor - Branch master
 kemoticons - Branch master
 kdewebkit - Branch master
 kguiaddons - Branch master
 kwin - Branch master
 kio - Branch master
 kidletime - Branch master
 krunner - Branch master
 kfilemetadata - Branch frameworks
 ki18n - Branch master
 cmake - Branch master
 kdeclarative - Branch master
 libdbusmenu-qt - Branch master
 kactivities - Branch master
 kpty - Branch master
 kplotting - Branch master
 ktextwidgets - Branch master
 knotifyconfig - Branch master
 attica - Branch master
 kconfig - Branch master
 kcoreaddons - Branch master
 kde-cli-tools - Branch master
 kcompletion - Branch master
 milou - Branch frameworks
 knotifications - Branch master
 kdnssd - Branch master
 phonon - Branch master
 kservice - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-workspace failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Build failed in Jenkins: plasma-desktop_master_qt5 #111

2014-05-02 Thread Marco Martin 
uhm, what does this error mean?
i think it's trying to install the breeze repobut it's not in ci?

09:25:36 rsync: change_dir "/srv/jenkins/install/linux/x86_64/g++/kf5-
qt5/kde/workspace/breeze/inst" failed: No such file or directory (2)
09:25:36 rsync error: some files/attrs were not transferred (see previous 
errors) (code 23) at main.c(1530) [Receiver=3.0.9]


On Wednesday 30 April 2014, KDE CI System wrote:
> See 
> 
> Changes:
> 
> [hein] Fix uninitialized value, thanks apol.
> 
> --
> Started by remote host 127.0.0.1 with note: Triggered by commit
> Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
>  Running Prebuild
> steps
> [plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson5865511457004990149.sh
> + /home/jenkins/scripts/setup-env.sh
> 
> Preparing to perform KDE Continuous Integration build
> == Setting Up Sources
> 
> From git://anongit.kde.org/plasma-desktop
>1f62aaf..84f1cb1  master -> origin/master
> Branch jenkins set up to track remote branch master from origin.
> 
> == Cleaning Source Tree
> 
> HEAD is now at 1f62aaf Copy Kicker's kmenuedit action.
> Removing build/
> Removing install/
> Success build forhudson.tasks.Shell@40820681
> Fetching changes from the remote Git repository
> Fetching upstream changes from git://anongit.kde.org/plasma-desktop
> Checking out Revision 84f1cb1c18024ed84421ce5afafa87f3b98d3e09
> (refs/heads/jenkins) [plasma-desktop_master_qt5] $ /bin/sh -xe
> /tmp/hudson62208330053718236.sh + /home/jenkins/scripts/execute-job.sh
> 
> KDE Continuous Integration Build
> == Building Project: plasma-desktop - Branch master
> == Build Dependencies:
>  kwallet - Branch master
>  kemoticons - Branch master
>  solid - Branch master
>  kcrash - Branch master
>  attica - Branch master
>  extra-cmake-modules - Branch master
>  ktextwidgets - Branch master
>  kwindowsystem - Branch master
>  kde-cli-tools - Branch master
>  kcodecs - Branch master
>  breeze - Branch master
>  kfilemetadata - Branch frameworks
>  kparts - Branch master
>  khelpcenter - Branch master
>  libdbusmenu-qt - Branch master
>  kservice - Branch master
>  kwin - Branch master
>  plasma-framework - Branch master
>  qt5 - Branch stable
>  kconfigwidgets - Branch master
>  kcmutils - Branch master
>  karchive - Branch master
>  kwidgetsaddons - Branch master
>  kbookmarks - Branch master
>  kf5umbrella - Branch master
>  kjobwidgets - Branch master
>  kjsembed - Branch master
>  kiconthemes - Branch master
>  kunitconversion - Branch master
>  ksysguard - Branch master
>  kinit - Branch master
>  knewstuff - Branch master
>  kdbusaddons - Branch master
>  kidletime - Branch master
>  frameworkintegration - Branch master
>  kplotting - Branch master
>  kcoreaddons - Branch master
>  polkit-qt-1 - Branch qt5
>  kcompletion - Branch master
>  kross - Branch master
>  kio - Branch master
>  kdelibs4support - Branch master
>  kglobalaccel - Branch master
>  khtml - Branch master
>  powerdevil - Branch master
>  kactivities - Branch master
>  oxygen - Branch master
>  kdewebkit - Branch master
>  knotifications - Branch master
>  sonnet - Branch master
>  threadweaver - Branch master
>  libksysguard - Branch master
>  kguiaddons - Branch master
>  kitemmodels - Branch master
>  krunner - Branch master
>  phonon - Branch master
>  kdnssd - Branch master
>  kitemviews - Branch master
>  kdesupport-svn - Branch master
>  kdeclarative - Branch master
>  kdesignerplugin - Branch master
>  ki18n - Branch master
>  kjs - Branch master
>  kpty - Branch master
>  kconfig - Branch master
>  kauth - Branch master
>  knotifyconfig - Branch master
>  kio-extras - Branch master
>  milou - Branch frameworks
>  systemsettings - Branch master
>  kxmlgui - Branch master
>  baloo - Branch frameworks
>  cmake - Branch master
>  kded - Branch master
>  ktexteditor - Branch master
>  kdoctools - Branch master
>  kdesu - Branch master
>  plasma-workspace - Branch master
> 
> == Applying Patches
> === No patches to apply
> 
> == Syncing Dependencies from Master Server
> 
> rsync: change_dir
> "/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst"
> failed: No such file or directory (2) rsync error: some files/attrs were
> not transferred (see previous errors) (code 23) at main.c(1530)
> [Receiver=3.0.9] Syncing dependencies from master server for project
> plasma-desktop failed. Build step 'Execute shell' marked build as failure
> [WARNINGS] Skipping publisher since build result is FAILURE
> Recording test results
> _

Build failed in Jenkins: plasma-desktop_master_qt5 #117

2014-05-02 Thread KDE CI System 
See 

Changes:

[notmart] fade out old menu entries

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson4105074833462155983.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-desktop
   abe510f..05a1d69  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at abe510f remove the slide animation as the other menus
Success build forhudson.tasks.Shell@40820681
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
Checking out Revision 05a1d69cba0afe2763df33882649af733eb2dbe3 
(refs/heads/jenkins)
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson2980397476963369634.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch master
== Build Dependencies:
 phonon - Branch master
 kiconthemes - Branch master
 solid - Branch master
 kdesignerplugin - Branch master
 polkit-qt-1 - Branch qt5
 kwidgetsaddons - Branch master
 kdeclarative - Branch master
 threadweaver - Branch master
 qt5 - Branch stable
 ktextwidgets - Branch master
 kcompletion - Branch master
 kdbusaddons - Branch master
 kcodecs - Branch master
 kwallet - Branch master
 baloo - Branch frameworks
 kwindowsystem - Branch master
 khtml - Branch master
 frameworkintegration - Branch master
 kplotting - Branch master
 attica - Branch master
 kbookmarks - Branch master
 kjsembed - Branch master
 plasma-framework - Branch master
 kconfigwidgets - Branch master
 kcmutils - Branch master
 kf5umbrella - Branch master
 breeze - Branch master
 kwin - Branch master
 plasma-workspace - Branch master
 kparts - Branch master
 libdbusmenu-qt - Branch master
 knewstuff - Branch master
 kauth - Branch master
 kross - Branch master
 kdnssd - Branch master
 kdelibs4support - Branch master
 khelpcenter - Branch master
 kinit - Branch master
 kglobalaccel - Branch master
 powerdevil - Branch master
 kidletime - Branch master
 kservice - Branch master
 kdesupport-svn - Branch master
 kunitconversion - Branch master
 extra-cmake-modules - Branch master
 kjs - Branch master
 kio-extras - Branch master
 kpty - Branch master
 kactivities - Branch master
 ksysguard - Branch master
 kdewebkit - Branch master
 kdesu - Branch master
 kde-cli-tools - Branch master
 ktexteditor - Branch master
 sonnet - Branch master
 kxmlgui - Branch master
 kguiaddons - Branch master
 kded - Branch master
 kitemmodels - Branch master
 krunner - Branch master
 kfilemetadata - Branch frameworks
 kcoreaddons - Branch master
 libksysguard - Branch master
 kjobwidgets - Branch master
 kitemviews - Branch master
 knotifications - Branch master
 ki18n - Branch master
 kemoticons - Branch master
 kconfig - Branch master
 oxygen - Branch master
 karchive - Branch master
 knotifyconfig - Branch master
 kdoctools - Branch master
 cmake - Branch master
 milou - Branch frameworks
 kcrash - Branch master
 kio - Branch master
 systemsettings - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-desktop failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #116

2014-05-02 Thread KDE CI System 
See 

Changes:

[notmart] proper background for toolbox menu

[notmart] remove the slide animation as the other menus

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson2903828100039728946.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-desktop
   20b132c..abe510f  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 20b132c SVN_SILENT made messages (.desktop file)
Success build forhudson.tasks.Shell@40820681
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
Checking out Revision abe510f0eec7759e0a3c7bdc23650dc81f2eda40 
(refs/heads/jenkins)
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson207819416633959985.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch master
== Build Dependencies:
 kiconthemes - Branch master
 libksysguard - Branch master
 solid - Branch master
 kjsembed - Branch master
 polkit-qt-1 - Branch qt5
 kwidgetsaddons - Branch master
 kdeclarative - Branch master
 threadweaver - Branch master
 qt5 - Branch stable
 ktextwidgets - Branch master
 kcompletion - Branch master
 plasma-workspace - Branch master
 kdbusaddons - Branch master
 kcodecs - Branch master
 kwallet - Branch master
 karchive - Branch master
 baloo - Branch frameworks
 khtml - Branch master
 frameworkintegration - Branch master
 kplotting - Branch master
 attica - Branch master
 breeze - Branch master
 plasma-framework - Branch master
 kservice - Branch master
 kconfigwidgets - Branch master
 kcmutils - Branch master
 kcrash - Branch master
 kf5umbrella - Branch master
 kio-extras - Branch master
 kparts - Branch master
 libdbusmenu-qt - Branch master
 knewstuff - Branch master
 kauth - Branch master
 kross - Branch master
 kdnssd - Branch master
 kde-cli-tools - Branch master
 kdelibs4support - Branch master
 kglobalaccel - Branch master
 kdoctools - Branch master
 kidletime - Branch master
 khelpcenter - Branch master
 kdesupport-svn - Branch master
 kunitconversion - Branch master
 extra-cmake-modules - Branch master
 kinit - Branch master
 kjs - Branch master
 kpty - Branch master
 kactivities - Branch master
 ksysguard - Branch master
 kdewebkit - Branch master
 kdesu - Branch master
 kbookmarks - Branch master
 knotifications - Branch master
 sonnet - Branch master
 kdesignerplugin - Branch master
 kxmlgui - Branch master
 kguiaddons - Branch master
 kded - Branch master
 ktexteditor - Branch master
 kitemmodels - Branch master
 krunner - Branch master
 kfilemetadata - Branch frameworks
 kcoreaddons - Branch master
 phonon - Branch master
 kjobwidgets - Branch master
 kitemviews - Branch master
 ki18n - Branch master
 kemoticons - Branch master
 kconfig - Branch master
 oxygen - Branch master
 knotifyconfig - Branch master
 powerdevil - Branch master
 cmake - Branch master
 kwin - Branch master
 kwindowsystem - Branch master
 kio - Branch master
 systemsettings - Branch master
 milou - Branch frameworks

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-desktop failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-05-02 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915/#review57102
---

Ship it!


Looks fine from a Baloo point of view. I cannot comment on the PMC parts, I 
don't know the code.


plugins/baloosearch/audiosearchresulthandler.cpp


Considering that you're checking if the title is empty, do you want to do 
the same for the Artist and Album?



plugins/baloosearch/searchresulthandler.cpp


Please keep in mind that this is sync, and you'll be blocking. You want to 
put it another thread via the Runnable if you want it to be async.


- Vishesh Handa


On May 1, 2014, 6:06 a.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117915/
> ---
> 
> (Updated May 1, 2014, 6:06 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Just like the Nepomuk media source, the Baloo media source needs to provide 
> the date/time information for media. This is used to sort the media to show 
> the more recent media first.
> For images, the date/time when the photo was actually taken is used, and the 
> file creation date/time is used for other media.
> 
> 
> Diffs
> -
> 
>   plugins/baloosearch/CMakeLists.txt 1ff81fb 
>   plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/baloosearchmediasource.h e315de4 
>   plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 
>   plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117915/diff/
> 
> 
> Testing
> ---
> 
> Tested with all three types of media, works fine. Unit tests for the new code 
> to follow.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: khotkeys_master_qt5 #20

2014-05-02 Thread KDE CI System 
See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[khotkeys_master_qt5] $ /bin/sh -xe /tmp/hudson8395775817449157035.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/khotkeys
   4603350..9ec3a09  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 4603350 Moved the documentation together with the kcm
Removing build/
Success build forhudson.tasks.Shell@71856d16
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/khotkeys
Checking out Revision 9ec3a09f965a09ff1238fff4abcb9464f1f0411c 
(refs/heads/jenkins)
[khotkeys_master_qt5] $ /bin/sh -xe /tmp/hudson4730953796932452744.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: khotkeys - Branch master
== Build Dependencies:
 kjsembed - Branch master
 solid - Branch master
 kglobalaccel - Branch master
 kdelibs4support - Branch master
 frameworkintegration - Branch master
 karchive - Branch master
 kdewebkit - Branch master
 kactivities - Branch master
 kdeclarative - Branch master
 ktextwidgets - Branch master
 kwidgetsaddons - Branch master
 kde-cli-tools - Branch master
 khelpcenter - Branch master
 baloo - Branch frameworks
 kparts - Branch master
 knewstuff - Branch master
 kfilemetadata - Branch frameworks
 kidletime - Branch master
 kunitconversion - Branch master
 libdbusmenu-qt - Branch master
 kwin - Branch master
 cmake - Branch master
 ktexteditor - Branch master
 kinit - Branch master
 kservice - Branch master
 kplotting - Branch master
 kconfigwidgets - Branch master
 sonnet - Branch master
 kauth - Branch master
 kdesignerplugin - Branch master
 krunner - Branch master
 knotifyconfig - Branch master
 ki18n - Branch master
 kdesu - Branch master
 khtml - Branch master
 plasma-workspace - Branch master
 kross - Branch master
 kxmlgui - Branch master
 knotifications - Branch master
 libksysguard - Branch master
 kwallet - Branch master
 phonon - Branch master
 kcrash - Branch master
 attica - Branch master
 kwindowsystem - Branch master
 kdbusaddons - Branch master
 kitemviews - Branch master
 kcmutils - Branch master
 kpty - Branch master
 kf5umbrella - Branch master
 kjs - Branch master
 kbookmarks - Branch master
 kiconthemes - Branch master
 kcodecs - Branch master
 kcompletion - Branch master
 kio-extras - Branch master
 kdnssd - Branch master
 kemoticons - Branch master
 kio - Branch master
 kguiaddons - Branch master
 threadweaver - Branch master
 kitemmodels - Branch master
 kdoctools - Branch master
 polkit-qt-1 - Branch qt5
 kjobwidgets - Branch master
 kdesupport-svn - Branch master
 milou - Branch frameworks
 extra-cmake-modules - Branch master
 kconfig - Branch master
 qt5 - Branch stable
 breeze - Branch master
 plasma-framework - Branch master
 kded - Branch master
 kcoreaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project khotkeys failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: kmenuedit_master_qt5 #14

2014-05-02 Thread KDE CI System 
See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kmenuedit_master_qt5] $ /bin/sh -xe /tmp/hudson1880998248336260159.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/kmenuedit
   4efbbf7..8e99368  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 4efbbf7 SVN_SILENT made messages (.desktop file)
Removing build/
Removing install/
Success build forhudson.tasks.Shell@1b489b95
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/kmenuedit
Checking out Revision 8e993681224d83735eb49f0eed16e48d2783791d 
(refs/heads/jenkins)
[kmenuedit_master_qt5] $ /bin/sh -xe /tmp/hudson7656330689362065272.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kmenuedit - Branch master
== Build Dependencies:
 libdbusmenu-qt - Branch master
 kiconthemes - Branch master
 solid - Branch master
 kjsembed - Branch master
 polkit-qt-1 - Branch qt5
 kdeclarative - Branch master
 threadweaver - Branch master
 qt5 - Branch stable
 kauth - Branch master
 plasma-workspace - Branch master
 kwindowsystem - Branch master
 krunner - Branch master
 kparts - Branch master
 kcompletion - Branch master
 baloo - Branch frameworks
 phonon - Branch master
 khtml - Branch master
 frameworkintegration - Branch master
 attica - Branch master
 karchive - Branch master
 kconfigwidgets - Branch master
 kcmutils - Branch master
 kf5umbrella - Branch master
 knotifyconfig - Branch master
 kcodecs - Branch master
 knewstuff - Branch master
 kservice - Branch master
 kdbusaddons - Branch master
 kross - Branch master
 kdelibs4support - Branch master
 kjs - Branch master
 kcoreaddons - Branch master
 kidletime - Branch master
 kjobwidgets - Branch master
 kdesupport-svn - Branch master
 kdnssd - Branch master
 kbookmarks - Branch master
 extra-cmake-modules - Branch master
 kdesignerplugin - Branch master
 kglobalaccel - Branch master
 kpty - Branch master
 plasma-framework - Branch master
 kemoticons - Branch master
 kunitconversion - Branch master
 kxmlgui - Branch master
 kwin - Branch master
 kinit - Branch master
 sonnet - Branch master
 kdesu - Branch master
 knotifications - Branch master
 kguiaddons - Branch master
 kded - Branch master
 ktexteditor - Branch master
 kitemmodels - Branch master
 kwidgetsaddons - Branch master
 kfilemetadata - Branch frameworks
 khelpcenter - Branch master
 libksysguard - Branch master
 ktextwidgets - Branch master
 kitemviews - Branch master
 kde-cli-tools - Branch master
 breeze - Branch master
 ki18n - Branch master
 kconfig - Branch master
 kplotting - Branch master
 kwallet - Branch master
 kdewebkit - Branch master
 kio-extras - Branch master
 kactivities - Branch master
 kdoctools - Branch master
 cmake - Branch master
 milou - Branch frameworks
 kcrash - Branch master
 kio - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kmenuedit failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #115

2014-05-02 Thread KDE CI System 
See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson7308848075534907700.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-desktop
   40e0aba..20b132c  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 40e0aba as with other libraries in workspace bump soversion to 5
Success build forhudson.tasks.Shell@40820681
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
Checking out Revision 20b132cd6af43da32296a416245f59cebc2d7ddb 
(refs/heads/jenkins)
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson1154482476408134598.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch master
== Build Dependencies:
 kde-cli-tools - Branch master
 kiconthemes - Branch master
 kwin - Branch master
 solid - Branch master
 kdesignerplugin - Branch master
 polkit-qt-1 - Branch qt5
 kitemmodels - Branch master
 threadweaver - Branch master
 qt5 - Branch stable
 libksysguard - Branch master
 ktextwidgets - Branch master
 kcompletion - Branch master
 plasma-workspace - Branch master
 kjsembed - Branch master
 kcodecs - Branch master
 kwallet - Branch master
 baloo - Branch frameworks
 khtml - Branch master
 kauth - Branch master
 kwindowsystem - Branch master
 attica - Branch master
 plasma-framework - Branch master
 libdbusmenu-qt - Branch master
 kconfigwidgets - Branch master
 kcmutils - Branch master
 khelpcenter - Branch master
 kf5umbrella - Branch master
 kio-extras - Branch master
 kparts - Branch master
 knewstuff - Branch master
 kpty - Branch master
 kross - Branch master
 kdbusaddons - Branch master
 kdewebkit - Branch master
 kdelibs4support - Branch master
 kglobalaccel - Branch master
 powerdevil - Branch master
 kxmlgui - Branch master
 kdesupport-svn - Branch master
 knotifications - Branch master
 frameworkintegration - Branch master
 kdnssd - Branch master
 extra-cmake-modules - Branch master
 kservice - Branch master
 kjs - Branch master
 kcoreaddons - Branch master
 kactivities - Branch master
 ksysguard - Branch master
 kdesu - Branch master
 kemoticons - Branch master
 ktexteditor - Branch master
 sonnet - Branch master
 kunitconversion - Branch master
 kguiaddons - Branch master
 kidletime - Branch master
 krunner - Branch master
 kfilemetadata - Branch frameworks
 breeze - Branch master
 kbookmarks - Branch master
 kjobwidgets - Branch master
 kitemviews - Branch master
 kinit - Branch master
 ki18n - Branch master
 kded - Branch master
 kconfig - Branch master
 oxygen - Branch master
 karchive - Branch master
 kwidgetsaddons - Branch master
 kdeclarative - Branch master
 knotifyconfig - Branch master
 kdoctools - Branch master
 cmake - Branch master
 kplotting - Branch master
 milou - Branch frameworks
 kcrash - Branch master
 phonon - Branch master
 kio - Branch master
 systemsettings - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-desktop failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #135

2014-05-02 Thread KDE CI System 
See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson9042311728880112710.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   78024a9..ba097fe  davidedmundson/faster_systray -> 
origin/davidedmundson/faster_systray
   e5b6eac..f6fa9c9  master -> origin/master
 * [new branch]  plasmashell+libkscreen -> origin/plasmashell+libkscreen
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at e5b6eac have "configure" context memnu in the panel
Removing build/
Removing install/
Success build forhudson.tasks.Shell@807d1fd
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
Checking out Revision f6fa9c9cd7385514a28af3e6641139ca3a9219e9 
(refs/heads/jenkins)
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson1046174370747457691.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kbookmarks - Branch master
 khelpcenter - Branch master
 kactivities - Branch master
 kglobalaccel - Branch master
 sonnet - Branch master
 kjsembed - Branch master
 polkit-qt-1 - Branch qt5
 threadweaver - Branch master
 qt5 - Branch stable
 kio - Branch master
 kinit - Branch master
 kwindowsystem - Branch master
 knotifications - Branch master
 kded - Branch master
 kwallet - Branch master
 baloo - Branch frameworks
 khtml - Branch master
 kdelibs4support - Branch master
 breeze - Branch master
 plasma-framework - Branch master
 kdbusaddons - Branch master
 kdesignerplugin - Branch master
 kcmutils - Branch master
 kxmlgui - Branch master
 kf5umbrella - Branch master
 frameworkintegration - Branch master
 kio-extras - Branch master
 kparts - Branch master
 kcodecs - Branch master
 knewstuff - Branch master
 kcoreaddons - Branch master
 attica - Branch master
 kdnssd - Branch master
 kjobwidgets - Branch master
 kconfigwidgets - Branch master
 kitemmodels - Branch master
 kwin - Branch master
 kjs - Branch master
 kdoctools - Branch master
 solid - Branch master
 kdesupport-svn - Branch master
 kauth - Branch master
 kde-cli-tools - Branch master
 extra-cmake-modules - Branch master
 kservice - Branch master
 kunitconversion - Branch master
 libksysguard - Branch master
 karchive - Branch master
 kemoticons - Branch master
 kdesu - Branch master
 kiconthemes - Branch master
 kcompletion - Branch master
 kdewebkit - Branch master
 kwidgetsaddons - Branch master
 ktextwidgets - Branch master
 kguiaddons - Branch master
 kross - Branch master
 kidletime - Branch master
 krunner - Branch master
 kfilemetadata - Branch frameworks
 kdeclarative - Branch master
 libdbusmenu-qt - Branch master
 kitemviews - Branch master
 phonon - Branch master
 ktexteditor - Branch master
 kpty - Branch master
 kplotting - Branch master
 knotifyconfig - Branch master
 kconfig - Branch master
 cmake - Branch master
 milou - Branch frameworks
 kcrash - Branch master
 ki18n - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kde/workspace/breeze/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-workspace failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117813: Make the system tray faster

2014-05-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117813/#review57097
---


what's the status of this?

- Marco Martin


On April 27, 2014, 10:51 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117813/
> ---
> 
> (Updated April 27, 2014, 10:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Port QQmlListProperty to QAbstractListModel.
> QQmlListProperty only has a signal that the list has changed.This means when 
> used in a ListView every delegate has to be redone whenever a single item is 
> inserted or removed rather than just moved.
> 
> Given TaskDelegate is not the simplest of things this has a performance gain, 
> most noticeably on startup. Also rather than sorting all items after an 
> insert items are inserted in the right place using qLowerBound. Now we have 
> the correct signals we can remove the compression, they won't add anything. 
> 
> 
> Other commits:
> 
> Avoid constructing a QString for comparing, use QLatin1String for == 
> operators.
> 
> Remove useless include
> 
> Do not construct a map inside a lessThan function
> 
> lessThan functions have to be fast.
> Also Map -> Hash as we're not using order here.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 2ef180b 
>   applets/systemtray/package/contents/ui/PlasmoidItem.qml 0eb1687 
>   applets/systemtray/package/contents/ui/StatusNotifierItem.qml fc889a8 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 913d8f1 
>   applets/systemtray/package/contents/ui/TaskListDelegate.qml 5501e02 
>   applets/systemtray/plugin/CMakeLists.txt f6e23b4 
>   applets/systemtray/plugin/host.h 02c5bbe 
>   applets/systemtray/plugin/host.cpp eafd0b6 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 2b846f2 
>   applets/systemtray/plugin/tasklistmodel.h PRE-CREATION 
>   applets/systemtray/plugin/tasklistmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117813/diff/
> 
> 
> Testing
> ---
> 
> Seems to work :)
> 
> see branch davidedmundson/faster_systray to test
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117884: rename binaries for co-installability

2014-05-02 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117884/#review57096
---


Regarding keditmimetype: I find it odd that KWidgetsAddons depends on a binary 
which is not provided by itself or by a component it depends on. Do we have 
other situations like this?

The "correct" solution would be to:

- Move keditmimetype from kde-cli-tools to KIO
- Move the KMimeTypeChooser class (the one which uses keditmimetype) from 
KWidgetsAddons to KIO

According to LXR KMimeTypeChooser is only used in KIO, so this change would 
work. The problem is this would break source compatibility, and now that we are 
close to the release date I don't think Kevin or David would allow that.

- Aurélien Gâteau


On April 29, 2014, 6:16 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117884/
> ---
> 
> (Updated April 29, 2014, 6:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> these cli tools are in kde-runtime in KDE 4 land so need to be renames so 
> they are co-installable.
> 
> Many are unused in the KDE codebase according to lxr but some are used and 
> I'll submit renaming patches to them if this is accepted..
>  keditfiletype used by:
>   frameworks/kio/src/widgets/kpropertiesdialog.cpp
>   frameworks/kwidgetsaddons/src/kmimetypechooser.cpp
>   applications/kde-baseapps/lib/konq/konq_operations.cpp
>   
> workspace/plasma-desktop/containments/folder/plugin/internallibkonq/konq_operations.cpp
>   
> workspace/plasma-desktop/kcms/componentchooser/componentchooserfilemanager.cpp
>  kmimetypefinder: unused
>  ktraderclient: used in
>   kde/workspace/kio-extras/kurifilter-plugins/tests/kurifiltertest.cpp
>  kioclient: used in
>   applications/kde-baseapps/konqueror/client/kfmclient.cpp
>   
> workspace/plasma-workspace/applets/devicenotifier/test-predicate-openinwindow.desktop
>   workspace/plasma-workspace/ksmserver/startup.cpp
>   workspace/plasma-workspace/drkonqi/data/mappings
>  kdecp: unused
>  kdemv: unused
>  kde-open: unused
>  ksvgtopng: unused
> 
> I note keditfiletype is used in frameworks so I should also look into moving 
> that into a framework.
> 
> 
> Diffs
> -
> 
>   keditfiletype/CMakeLists.txt 0adfde946b783cbee09661cfe445792eb1a54649 
>   kioclient/CMakeLists.txt cca4f5c222a3266f7ec468fa138bd2cefa880902 
>   kmimetypefinder/CMakeLists.txt 720ccb07bd7a0a6a567b3bf70caa00d532232663 
>   kstart/CMakeLists.txt e7810d2788290b5f33447f90948dc020e1c8b1b9 
>   ksvgtopng/CMakeLists.txt 82602887bb7370e591545b059418a68457c85c28 
>   ktraderclient/CMakeLists.txt 028aac3ef9c5e293078df0796ee35577b0679afb 
> 
> Diff: https://git.reviewboard.kde.org/r/117884/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel