Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118038/
---

(Updated June 3, 2014, 8:53 a.m.)


Review request for Plasma and Thomas Pfeiffer.


Changes
---

* added Messages.sh
* reconfigure KSLD through DBus
* adjust config values to UI
 ** timeout stored in minutes (used to be seconds)
 ** grace time stored in seconds (used to be msec)
 ** lock enabled by default


Repository: plasma-workspace


Description (updated)
---

Bring back a KCM for the screen locker

Together with adding back the KCM the settings are slightly adjusted to
have them fit the UI without needing a transformation in the KCM.

* timeout is stored in minutes (used to be seconds)
* grace time is stored in seconds (used to be msec)
* lock is enabled by default

Also disabling the locking after idle timeout is no longer possible. An
endless grace made some sense with the screensavers, but not with the
screenlocker. In order to not break an unknown but maybe valid use case
the option is still available, just not exposed through UI.

REVIEW: 118038


Diffs (updated)
-

  ksmserver/screenlocker/CMakeLists.txt 
486563720cfd9af59f1ae2f06a0b9ff4a3c96ea8 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 
18a12935e127aad75fcf72213f8e34c25a8ed16c 
  ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION 
  ksmserver/screenlocker/kcm/Messages.sh PRE-CREATION 
  ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION 
  ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION 
  ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION 
  ksmserver/screenlocker/ksldapp.cpp eff9d8d7d7a661a2eac9bf76196380816951bd7a 

Diff: https://git.reviewboard.kde.org/r/118038/diff/


Testing
---


File Attachments


KCM with values
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png
KCM without values
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png
In Systemsettings
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118388: rename systemsettings binary to systemsettings5

2014-06-02 Thread Martin Gräßlin 


> On May 29, 2014, 9:10 a.m., Ben Cooksley wrote:
> > Code wise, this change looks fine. In terms of renaming the desktop files - 
> > i'm fine with changing the filenames, but please don't change the name of 
> > the application itself. Ideally the KF5 based system settings will still be 
> > able to set configuration details relevant for KDE 4 applications.
> 
> Hrvoje Senjan wrote:
> >Ideally the KF5 based system settings will still be able to set 
> configuration details relevant for KDE 4 applications.
> 
> that sounds great to me - just that it would need work in every kcm 
> module. additional caveats:
> what if there's only 4.x variant of the kcm?
> an option is removed in KF5 variant?
> most importantly - how to implement it (different config locations, etc)? 
> =)
> 
> Ben Cooksley wrote:
> Indeed, that could complicate things quite a bit. I'm not sure what we 
> should do in that case then - but we can't have two "System Settings" 
> applications installed which do different things on the same system

it's kind of the same situation as we had during the KDE3 -> 4 transition. We 
had kcontrol to configure KDE3 and systemsettings to configure KDE4.

The big problem for the developers is that we don't have any access to the KDE4 
configuration files, thus it's difficult to adjust the configuration. Now to 
make it even more complex: should adjusting e.g. the widget style in a Plasma 
Next session really change the widget style of a Plasma 4 session or just in 
Plasma Next?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review58690
---


On May 28, 2014, 9:32 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118388/
> ---
> 
> (Updated May 28, 2014, 9:32 p.m.)
> 
> 
> Review request for Plasma and Ben Cooksley.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> while workspace might not be targeted to co-exist with 4.x variant - 
> systemsettings should IMHO be able to co-exist. not only workspace components 
> are adjusting in there, and telling people to do kcmshell$notinstalledvariant 
> $wantedkcm is very user-unfriendly...
> one TODO if this gets a green light, is to rename desktop files, so people 
> know which variant they are opening.
> 
> 
> Diffs
> -
> 
>   app/systemsettings.desktop 5f27318 
>   app/kdesystemsettings.desktop 946d498 
>   app/CMakeLists.txt c45f7e7 
> 
> Diff: https://git.reviewboard.kde.org/r/118388/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118388: rename systemsettings binary to systemsettings5

2014-06-02 Thread Ben Cooksley 


> On May 29, 2014, 7:10 a.m., Ben Cooksley wrote:
> > Code wise, this change looks fine. In terms of renaming the desktop files - 
> > i'm fine with changing the filenames, but please don't change the name of 
> > the application itself. Ideally the KF5 based system settings will still be 
> > able to set configuration details relevant for KDE 4 applications.
> 
> Hrvoje Senjan wrote:
> >Ideally the KF5 based system settings will still be able to set 
> configuration details relevant for KDE 4 applications.
> 
> that sounds great to me - just that it would need work in every kcm 
> module. additional caveats:
> what if there's only 4.x variant of the kcm?
> an option is removed in KF5 variant?
> most importantly - how to implement it (different config locations, etc)? 
> =)

Indeed, that could complicate things quite a bit. I'm not sure what we should 
do in that case then - but we can't have two "System Settings" applications 
installed which do different things on the same system


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review58690
---


On May 28, 2014, 7:32 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118388/
> ---
> 
> (Updated May 28, 2014, 7:32 p.m.)
> 
> 
> Review request for Plasma and Ben Cooksley.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> while workspace might not be targeted to co-exist with 4.x variant - 
> systemsettings should IMHO be able to co-exist. not only workspace components 
> are adjusting in there, and telling people to do kcmshell$notinstalledvariant 
> $wantedkcm is very user-unfriendly...
> one TODO if this gets a green light, is to rename desktop files, so people 
> know which variant they are opening.
> 
> 
> Diffs
> -
> 
>   app/systemsettings.desktop 5f27318 
>   app/kdesystemsettings.desktop 946d498 
>   app/CMakeLists.txt c45f7e7 
> 
> Diff: https://git.reviewboard.kde.org/r/118388/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118038/#review59029
---


It needs a little bit more work: it doesn't trigger a reload of the settings in 
KSLD yet.

- Martin Gräßlin


On May 8, 2014, 7:17 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118038/
> ---
> 
> (Updated May 8, 2014, 7:17 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Bring back a KCM for the screen locker
> 
> Note: I will improve the default values to get them sane. That needs 
> adjustements in the screenlocker source base and I want to get the review of 
> the UI started earlier.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION 
>   ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION 
>   ksmserver/screenlocker/CMakeLists.txt 
> 3407ea46d5046f2f5b2e7321d714ad1e65ffceea 
> 
> Diff: https://git.reviewboard.kde.org/r/118038/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> KCM with values
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png
> KCM without values
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png
> In Systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

2014-06-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/
---

(Updated June 3, 2014, 7:48 a.m.)


Review request for Plasma.


Summary (updated)
-

[klipper] Port from KIntSpinBox to KPluralHandlingSpinBox


Repository: plasma-workspace


Description (updated)
---

[klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

This introduces new dependency to KF5TextWidgets.

REVIEW: 118347


Diffs
-

  klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
  klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 
  CMakeLists.txt 1f507a88f60188d34761a7a1eab95b33abd1f783 

Diff: https://git.reviewboard.kde.org/r/118347/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralAwareSpinBox

2014-06-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/
---

(Updated June 3, 2014, 7:48 a.m.)


Review request for Plasma.


Changes
---

ported to new KPluralAwareSpinBox which supports the plural base again. Has 
commit embargo till after beta release as it's not yet in frameworks beta 
release.


Summary (updated)
-

[klipper] Port from KIntSpinBox to KPluralAwareSpinBox


Repository: plasma-workspace


Description (updated)
---

[klipper] Port from KIntSpinBox to KPluralAwareSpinBox

This introduces new dependency to KF5TextWidgets.

REVIEW: 118347


Diffs (updated)
-

  klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
  klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 
  CMakeLists.txt 1f507a88f60188d34761a7a1eab95b33abd1f783 

Diff: https://git.reviewboard.kde.org/r/118347/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

2014-06-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118482/#review59027
---


maybe we should make it a define like in kwin's source tree?

- Martin Gräßlin


On June 2, 2014, 8:43 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118482/
> ---
> 
> (Updated June 2, 2014, 8:43 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure 
> kwin_x11 is started)
> 
> 
> Diffs
> -
> 
>   ksmserver/server.cpp 644013b 
>   ksmserver/startup.cpp 6f5d502 
> 
> Diff: https://git.reviewboard.kde.org/r/118482/diff/
> 
> 
> Testing
> ---
> 
> using it for some ~10 days, noticed no regression.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118487: fix type issue with qreal

2014-06-02 Thread Harald Sitter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118487/
---

(Updated June 3, 2014, 1:48 a.m.)


Review request for Plasma.


Changes
---

I'd consider the redundancy a boon really ;)


Repository: plasma-framework


Description
---

floor() returns double, qreal is a typedef and could be float (for example), so 
running a qmax(qreal, floor) may cause build failures


Diffs (updated)
-

  src/declarativeimports/core/framesvgitem.cpp 
def17ea551340e952ce1a9c52d8e7df308b2b8f1 

Diff: https://git.reviewboard.kde.org/r/118487/diff/


Testing
---


Thanks,

Harald Sitter

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118487: fix type issue with qreal

2014-06-02 Thread Thomas Braxton 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118487/#review59023
---



src/declarativeimports/core/framesvgitem.cpp


double

and isn't this redundant since 1.0 is double unless cast to something else?


- Thomas Braxton


On June 3, 2014, 1:36 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118487/
> ---
> 
> (Updated June 3, 2014, 1:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> floor() returns double, qreal is a typedef and could be float (for example), 
> so running a qmax(qreal, floor) may cause build failures
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/framesvgitem.cpp 
> def17ea551340e952ce1a9c52d8e7df308b2b8f1 
> 
> Diff: https://git.reviewboard.kde.org/r/118487/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118487: fix type issue with qreal

2014-06-02 Thread Harald Sitter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118487/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

floor() returns double, qreal is a typedef and could be float (for example), so 
running a qmax(qreal, floor) may cause build failures


Diffs
-

  src/declarativeimports/core/framesvgitem.cpp 
def17ea551340e952ce1a9c52d8e7df308b2b8f1 

Diff: https://git.reviewboard.kde.org/r/118487/diff/


Testing
---


Thanks,

Harald Sitter

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118482: Adjust ksmserver for renamed KWin binary

2014-06-02 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118482/
---

Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
---

as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure 
kwin_x11 is started)


Diffs
-

  ksmserver/server.cpp 644013b 
  ksmserver/startup.cpp 6f5d502 

Diff: https://git.reviewboard.kde.org/r/118482/diff/


Testing
---

using it for some ~10 days, noticed no regression.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ghns for plasmoids

2014-06-02 Thread Marco Martin 
On Monday 02 June 2014, Jeremy Whiting wrote:
> Ok, I'll take a look at bodega-client this week.  Does KDE have a
> bodega server in place ? Are there plans to create one ? Is there work

i don't think there is at the moment

> to be done on the server side also or only maintenance is needed
> there?

on the server side is pretty much about dependencies, iirc:
node.js (plus usual bunch of modules installed just on the user home)
redis
postgresql

*should* be it

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler 


> On June 2, 2014, 4:26 p.m., Andrew Lake wrote:
> > The group box HIG has been updated after discussion on the HIG mailing 
> > list. Using a group box with the 'flat' property set true is now 
> > recommended; it provides a consistent way to use spacing to group visual 
> > elements without the line-y, boxy noise of a visible frame. If you used 
> > group boxes here and followed this new guidance you should get the visual 
> > design you're aiming for with more consistent spacing.
> > 
> > Hope this helps!
> 
> Sebastian Kügler wrote:
> It helps partly, but it still makes aligning the widgets in different 
> groupboxes really hard. I'd really prefer just simple spacing. If we make it 
> hard to align things properly, people just won't. In this specific case in 
> powerdevil, using groupboxes really seems overkill as well, we can do just 
> fine with section titles and a bit of spacing (as can be seen here).
> 
> Andrew Lake wrote:
> Honestly, if in any one instance we can achieve the same consistency in 
> spacing without using the groupbox I'm fine with deviating from the 
> guidelines. They are, after all, guidelines. I understand the impact in terms 
> alignment and there are times when we have to trade strict compliance with 
> one guideline to reap the benefits of complying with the another.

Amen to that. :)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
---


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> ---
> 
> (Updated June 2, 2014, 4:04 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can 
> find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -
> 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
>   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
>   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
>   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
>   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
> 231c5d6 
>   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
>   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
>   daemon/actions/powerdevilaction.desktop 5b74fea 
>   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
>   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
>   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
>   daemon/powerdevil.desktop 20d31c9 
>   kcmodule/activities/activitypage.cpp 48e9c6c 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
>   kcmodule/common/actionconfigwidget.cpp 2161c84 
>   kcmodule/common/actioneditwidget.cpp 4c67b4f 
>   kcmodule/global/GeneralPage.cpp d025e42 
>   kcmodule/global/generalPage.ui 2ce7cef 
>   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
>   kcmodule/profiles/EditPage.cpp a674ccb 
>   kcmodule/pro

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

2014-06-02 Thread R.Harish Navnit 
On Mon, Jun 2, 2014 at 10:35 PM, Shantanu Tushar  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118468/
>
> Ship it!
>
> Hmm, looks good to me.
>
> Can you/anyone commit on my behalf ?


Cheers :)

Thanking You,
R.Harish Navnit
The Enigma 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Andrew Lake 


> On June 2, 2014, 4:26 p.m., Andrew Lake wrote:
> > The group box HIG has been updated after discussion on the HIG mailing 
> > list. Using a group box with the 'flat' property set true is now 
> > recommended; it provides a consistent way to use spacing to group visual 
> > elements without the line-y, boxy noise of a visible frame. If you used 
> > group boxes here and followed this new guidance you should get the visual 
> > design you're aiming for with more consistent spacing.
> > 
> > Hope this helps!
> 
> Sebastian Kügler wrote:
> It helps partly, but it still makes aligning the widgets in different 
> groupboxes really hard. I'd really prefer just simple spacing. If we make it 
> hard to align things properly, people just won't. In this specific case in 
> powerdevil, using groupboxes really seems overkill as well, we can do just 
> fine with section titles and a bit of spacing (as can be seen here).

Honestly, if in any one instance we can achieve the same consistency in spacing 
without using the groupbox I'm fine with deviating from the guidelines. They 
are, after all, guidelines. I understand the impact in terms alignment and 
there are times when we have to trade strict compliance with one guideline to 
reap the benefits of complying with the another.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
---


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> ---
> 
> (Updated June 2, 2014, 4:04 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can 
> find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -
> 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
>   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
>   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
>   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
>   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
> 231c5d6 
>   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
>   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
>   daemon/actions/powerdevilaction.desktop 5b74fea 
>   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
>   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
>   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
>   daemon/powerdevil.desktop 20d31c9 
>   kcmodule/activities/activitypage.cpp 48e9c6c 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
>   kcmodule/common/actionconfigwidget.cpp 2161c84 
>   kcmodule/common/actioneditwidget.cpp 4c67b4f 
>   kcmodule/global/GeneralPage.cpp d025e42 
>   kcmodule/global/generalPage.ui 2ce7cef 
>   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
>   kcmodule/profiles/EditPage.cpp a674ccb 
>   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
>   kcmodu

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

2014-06-02 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118468/#review59005
---

Ship it!


Hmm, looks good to me.

- Shantanu Tushar


On June 2, 2014, 12:24 p.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118468/
> ---
> 
> (Updated June 2, 2014, 12:24 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> As of now, PMC only uses the MediaPlay button to give the user an option to 
> play/pause media from the home screen. However, not all keyboards have the 
> MediaPlay button AFAIK. 
> This patch gives the user the option to play/pause the media from the home 
> screen using the spacebar key as another alternative. 
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml e1bc0e6 
> 
> Diff: https://git.reviewboard.kde.org/r/118468/diff/
> 
> 
> Testing
> ---
> 
> Play any media, navigate to homescreen. Press the spacebar to check if the 
> media plays/pauses. 
> 
> Seems to work fine to me. 
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ghns for plasmoids

2014-06-02 Thread Jeremy Whiting 
Ok, I'll take a look at bodega-client this week.  Does KDE have a
bodega server in place ? Are there plans to create one ? Is there work
to be done on the server side also or only maintenance is needed
there?

BR,
Jeremy

On Mon, Jun 2, 2014 at 10:48 AM, Marco Martin  wrote:
> On Monday 02 June 2014, Jeremy Whiting wrote:
>> Marco,
>>
>> On Mon, Jun 2, 2014 at 10:19 AM, Marco Martin  wrote:
>> > Hi all,
>> > now that get hot new stuff for wallpapers is "kindof" fixed (still
>> > depends from pending patches https://git.reviewboard.kde.org/r/118473/)
>> >
>> > there is the old question of ghns for plasmoids.
>> > I do know that the answer always is "there should be an alternative to
>> > kdelook".
>> > However, that's an answer that doesn't work in the short term (ie first
>> > release)
>> > The possibilities at the moment are pretty much 2:
>> > * getting somehow a Plasmoids->Plasma5 section on kde-look (eh, who to
>> > ask to? is this possible at all?)
>>
>> I think this is still possible. probably send an e-mail to some
>> address @ kde-look.org and cc frank.
>
> I can try that... "Plasma5" would be ok for everybody as category?
>
>> I agreed that this would be the best option.  Also, is there some
>> information on bodega I could see to investigate how quickly/easily a
>> bodega backend for knewstuff could be put together?
>
> one thing is that it would probably need someone volunteering as maintainer.
> anyways, current informations:
> * in repo bodega-server the 3 readmes explain the architecture well
> * in repo bodega-client/lib there is a client library (Qt4) that should be in
> theory not too hard to attach to knewstuff
> * in bodega-webapp-manager repo, there is a manual (more user oriented, but
> maybe useful) "Bodega Participants Manual.pdf"
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ghns for plasmoids

2014-06-02 Thread Marco Martin 
On Monday 02 June 2014, Jeremy Whiting wrote:
> Marco,
> 
> On Mon, Jun 2, 2014 at 10:19 AM, Marco Martin  wrote:
> > Hi all,
> > now that get hot new stuff for wallpapers is "kindof" fixed (still
> > depends from pending patches https://git.reviewboard.kde.org/r/118473/)
> > 
> > there is the old question of ghns for plasmoids.
> > I do know that the answer always is "there should be an alternative to
> > kdelook".
> > However, that's an answer that doesn't work in the short term (ie first
> > release)
> > The possibilities at the moment are pretty much 2:
> > * getting somehow a Plasmoids->Plasma5 section on kde-look (eh, who to
> > ask to? is this possible at all?)
> 
> I think this is still possible. probably send an e-mail to some
> address @ kde-look.org and cc frank.

I can try that... "Plasma5" would be ok for everybody as category?

> I agreed that this would be the best option.  Also, is there some
> information on bodega I could see to investigate how quickly/easily a
> bodega backend for knewstuff could be put together?

one thing is that it would probably need someone volunteering as maintainer.
anyways, current informations:
* in repo bodega-server the 3 readmes explain the architecture well
* in repo bodega-client/lib there is a client library (Qt4) that should be in 
theory not too hard to attach to knewstuff
* in bodega-webapp-manager repo, there is a manual (more user oriented, but 
maybe useful) "Bodega Participants Manual.pdf"

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118476: Move kded module to kf5/kded subdirectory

2014-06-02 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118476/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Move kded module to kf5/kded subdirectory

This makes sure the module is properly versioned.


Diffs
-

  src/platformstatus/CMakeLists.txt 676a8be30df41b042758d55b58caa22fc6c89311 
  src/platformstatus/kded_platformstatus.desktop 
9976fa3041a6c12fc4b3ce2146fb481181fa65b8 

Diff: https://git.reviewboard.kde.org/r/118476/diff/


Testing
---

qdbus org.kde.kded5 /kded loadModule kded_platformstatus
succeeds


Thanks,

Alex Merry

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler 


> On June 2, 2014, 4:26 p.m., Andrew Lake wrote:
> > The group box HIG has been updated after discussion on the HIG mailing 
> > list. Using a group box with the 'flat' property set true is now 
> > recommended; it provides a consistent way to use spacing to group visual 
> > elements without the line-y, boxy noise of a visible frame. If you used 
> > group boxes here and followed this new guidance you should get the visual 
> > design you're aiming for with more consistent spacing.
> > 
> > Hope this helps!

It helps partly, but it still makes aligning the widgets in different 
groupboxes really hard. I'd really prefer just simple spacing. If we make it 
hard to align things properly, people just won't. In this specific case in 
powerdevil, using groupboxes really seems overkill as well, we can do just fine 
with section titles and a bit of spacing (as can be seen here).


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
---


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> ---
> 
> (Updated June 2, 2014, 4:04 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can 
> find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -
> 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
>   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
>   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
>   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
>   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
> 231c5d6 
>   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
>   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
>   daemon/actions/powerdevilaction.desktop 5b74fea 
>   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
>   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
>   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
>   daemon/powerdevil.desktop 20d31c9 
>   kcmodule/activities/activitypage.cpp 48e9c6c 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
>   kcmodule/common/actionconfigwidget.cpp 2161c84 
>   kcmodule/common/actioneditwidget.cpp 4c67b4f 
>   kcmodule/global/GeneralPage.cpp d025e42 
>   kcmodule/global/generalPage.ui 2ce7cef 
>   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
>   kcmodule/profiles/EditPage.cpp a674ccb 
>   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
>   kcmodule/profiles/profileEditPage.ui dc26579 
>   powerdevil.notifyrc 36acdb6 
> 
> Diff: https://git.reviewboard.kde.org/r/118390/diff/
> 
> 
> Testing
> ---
> 
> Tested in kcmshell5 and systemsettings, still fully functional.
> 
> 
> File Attachments
> 
> 
> Energy Saving page before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
---


The group box HIG has been updated after discussion on the HIG mailing list. 
Using a group box with the 'flat' property set true is now recommended; it 
provides a consistent way to use spacing to group visual elements without the 
line-y, boxy noise of a visible frame. If you used group boxes here and 
followed this new guidance you should get the visual design you're aiming for 
with more consistent spacing.

Hope this helps!

- Andrew Lake


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> ---
> 
> (Updated June 2, 2014, 4:04 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can 
> find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -
> 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
>   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
>   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
>   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
>   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
> 231c5d6 
>   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
>   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
>   daemon/actions/powerdevilaction.desktop 5b74fea 
>   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
>   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
>   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
>   daemon/powerdevil.desktop 20d31c9 
>   kcmodule/activities/activitypage.cpp 48e9c6c 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
>   kcmodule/common/actionconfigwidget.cpp 2161c84 
>   kcmodule/common/actioneditwidget.cpp 4c67b4f 
>   kcmodule/global/GeneralPage.cpp d025e42 
>   kcmodule/global/generalPage.ui 2ce7cef 
>   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
>   kcmodule/profiles/EditPage.cpp a674ccb 
>   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
>   kcmodule/profiles/profileEditPage.ui dc26579 
>   powerdevil.notifyrc 36acdb6 
> 
> Diff: https://git.reviewboard.kde.org/r/118390/diff/
> 
> 
> Testing
> ---
> 
> Tested in kcmshell5 and systemsettings, still fully functional.
> 
> 
> File Attachments
> 
> 
> Energy Saving page before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
> Energy Saving page after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
> Advanced page after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
> Advanced page before
>   
> https://git.reviewboard.kde.org/media/uploade

Re: ghns for plasmoids

2014-06-02 Thread Jeremy Whiting 
Marco,

On Mon, Jun 2, 2014 at 10:19 AM, Marco Martin  wrote:
> Hi all,
> now that get hot new stuff for wallpapers is "kindof" fixed (still depends
> from pending patches https://git.reviewboard.kde.org/r/118473/)
>
> there is the old question of ghns for plasmoids.
> I do know that the answer always is "there should be an alternative to
> kdelook".
> However, that's an answer that doesn't work in the short term (ie first
> release)
> The possibilities at the moment are pretty much 2:
> * getting somehow a Plasmoids->Plasma5 section on kde-look (eh, who to ask to?
> is this possible at all?)

I think this is still possible. probably send an e-mail to some
address @ kde-look.org and cc frank.
I agreed that this would be the best option.  Also, is there some
information on bodega I could see to investigate how quickly/easily a
bodega backend for knewstuff could be put together?

BR,
Jeremy

> * remove the "Download new widgets" button altogether from the first release
>
> (I would love to not lose the feature btw)
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

ghns for plasmoids

2014-06-02 Thread Marco Martin 
Hi all,
now that get hot new stuff for wallpapers is "kindof" fixed (still depends 
from pending patches https://git.reviewboard.kde.org/r/118473/)

there is the old question of ghns for plasmoids.
I do know that the answer always is "there should be an alternative to 
kdelook".
However, that's an answer that doesn't work in the short term (ie first 
release)
The possibilities at the moment are pretty much 2:
* getting somehow a Plasmoids->Plasma5 section on kde-look (eh, who to ask to? 
is this possible at all?)
* remove the "Download new widgets" button altogether from the first release

(I would love to not lose the feature btw)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/
---

(Updated June 2, 2014, 4:04 p.m.)


Review request for Plasma, Solid and KDE Usability.


Changes
---

Fix labels in Advanced tab.


Repository: powerdevil


Description
---

This is a series of UI updates I've applied to the powerdevil KCMs. You can 
find them as individual patch series in the sebas/kcmupdates branch.

General:
- Less icon usage, especially in the form layouts
- Title casing throughout
- Better HIG compliance (not 100%, but improved)
- Energy Saving / Actions UI now scales with dialog
- Proper usage of FormLayouts
- A bunch of cleanups of dead code
- Parenting fixes

In Detail:

* Improve Advanced Settings page

- Use a QFormLayout, and do it properly
- Fix up spacing and alignment
- Remove icons before titles
- Use Title Case for Labels
- Shorter labels for better readability

* Clean up brightness-OSD-related dead code


* Make powerdevil actions layout stretch out horizontally


* Compile-time connections in actionconfigwidget


* widget and layout parenting fixes


* No bold font, increased spacing instead

This removes the bold fonts from the checkboxes, as that is non-standard
in the HIG. In order to make it look a bit more structured between the
sections, a bit of spacing is added.

* Remove icons from actions

The icons are really small and add more visual noise than being useful.

* Streamline Comments of KCMs


* Clean up dead code


Diffs (updated)
-

  daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
  daemon/actions/bundled/dimdisplayconfig.cpp f683935 
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
  daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
  daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
  daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
  daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
  daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
231c5d6 
  daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
  daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
  daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
  daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
  daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
  daemon/actions/powerdevilaction.desktop 5b74fea 
  daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
  daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
  daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
  daemon/powerdevil.desktop 20d31c9 
  kcmodule/activities/activitypage.cpp 48e9c6c 
  kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
  kcmodule/common/actionconfigwidget.cpp 2161c84 
  kcmodule/common/actioneditwidget.cpp 4c67b4f 
  kcmodule/global/GeneralPage.cpp d025e42 
  kcmodule/global/generalPage.ui 2ce7cef 
  kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
  kcmodule/profiles/EditPage.cpp a674ccb 
  kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
  kcmodule/profiles/profileEditPage.ui dc26579 
  powerdevil.notifyrc 36acdb6 

Diff: https://git.reviewboard.kde.org/r/118390/diff/


Testing
---

Tested in kcmshell5 and systemsettings, still fully functional.


File Attachments


Energy Saving page before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
Energy Saving page after
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
Advanced page after
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
Advanced page before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118470: Avoid references to QApplication

2014-06-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118470/#review58988
---


This review has been submitted with commit 
23068fb2b0f9aa18f3c79f4f30fe4abe43c6fbcb by David Edmundson to branch master.

- Commit Hook


On June 2, 2014, 3:38 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118470/
> ---
> 
> (Updated June 2, 2014, 3:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Avoid references to QApplication
> 
> They potentially cause problems when running in QGuiApplication
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/units.cpp 0f20b8e 
>   src/plasma/private/theme_p.cpp 56c7132 
> 
> Diff: https://git.reviewboard.kde.org/r/118470/diff/
> 
> 
> Testing
> ---
> 
> change qApp macro in QApplication to qobject_cast and then fixed wherever my 
> application crashed.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118470: Avoid references to QApplication

2014-06-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118470/
---

(Updated June 2, 2014, 3:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

Avoid references to QApplication

They potentially cause problems when running in QGuiApplication


Diffs
-

  src/declarativeimports/core/units.cpp 0f20b8e 
  src/plasma/private/theme_p.cpp 56c7132 

Diff: https://git.reviewboard.kde.org/r/118470/diff/


Testing
---

change qApp macro in QApplication to qobject_cast and then fixed wherever my 
application crashed.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118470: Avoid references to QApplication

2014-06-02 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118470/#review58986
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On June 2, 2014, 3:38 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118470/
> ---
> 
> (Updated June 2, 2014, 3:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Avoid references to QApplication
> 
> They potentially cause problems when running in QGuiApplication
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/units.cpp 0f20b8e 
>   src/plasma/private/theme_p.cpp 56c7132 
> 
> Diff: https://git.reviewboard.kde.org/r/118470/diff/
> 
> 
> Testing
> ---
> 
> change qApp macro in QApplication to qobject_cast and then fixed wherever my 
> application crashed.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118470: Avoid references to QApplication

2014-06-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118470/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Avoid references to QApplication

They potentially cause problems when running in QGuiApplication


Diffs
-

  src/declarativeimports/core/units.cpp 0f20b8e 
  src/plasma/private/theme_p.cpp 56c7132 

Diff: https://git.reviewboard.kde.org/r/118470/diff/


Testing
---

change qApp macro in QApplication to qobject_cast and then fixed wherever my 
application crashed.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Thomas Pfeiffer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58985
---


Almost there ;)
The only title case labels I didn't see fixed in the diffs are those in the 
"Battery Levels" group of the Advanced Settings: Low Level, Critical Level, At 
Critical Level.
All others seem fixed now from what I can tell from the diffs.

- Thomas Pfeiffer


On June 2, 2014, 1:35 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> ---
> 
> (Updated June 2, 2014, 1:35 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can 
> find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -
> 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
>   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
>   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
>   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
>   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
> 231c5d6 
>   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
>   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
>   daemon/actions/powerdevilaction.desktop 5b74fea 
>   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
>   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
>   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
>   daemon/powerdevil.desktop 20d31c9 
>   kcmodule/activities/activitypage.cpp 48e9c6c 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
>   kcmodule/common/actionconfigwidget.cpp 2161c84 
>   kcmodule/common/actioneditwidget.cpp 4c67b4f 
>   kcmodule/global/GeneralPage.cpp d025e42 
>   kcmodule/global/generalPage.ui 2ce7cef 
>   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
>   kcmodule/profiles/EditPage.cpp a674ccb 
>   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
>   kcmodule/profiles/profileEditPage.ui dc26579 
>   powerdevil.notifyrc 36acdb6 
> 
> Diff: https://git.reviewboard.kde.org/r/118390/diff/
> 
> 
> Testing
> ---
> 
> Tested in kcmshell5 and systemsettings, still fully functional.
> 
> 
> File Attachments
> 
> 
> Energy Saving page before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
> Energy Saving page after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
> Advanced page after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
> Advanced page before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

_

Re: Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread Marco Martin 


> On June 2, 2014, 2:13 p.m., David Edmundson wrote:
> > krunner/view.cpp, line 85
> > 
> >
> > If you really can't fix dialog create a tiny QML file with the contents
> > 
> > import org.kde.plasmacore 2.0
> > FrameSvgItem {
> >  svg:...
> >  anchors.fill: parent
> > }
> > 
> > 
> > then do a setSource(myQMLFile.qml)
> > 
> > that way you won't need to clone half the world to load an.

That would be already better.
but would still not have shadows, shaped blur behind or window masks


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/#review58973
---


On June 2, 2014, 1:15 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118469/
> ---
> 
> (Updated June 2, 2014, 1:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KRunner: Stop using the dialog class
> 
> The dialog class provides a number of features such as resizing itself
> when the item size changes, vice versa, and has slightly complex logic
> to handle to being a tooltip / dialog / etc. We do not really need any
> of this logic. We're just a simple window with a item + border.
> 
> This removes the duplicated dialog.h header file, but it unfortunately
> introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
> should be a temporary copy until these files are exported properly.
> 
> This patch fixes all the annoying flickering issues with krunner and
> makes it much much smoother. It also fixes issues where the top border
> is initially present but later disappears.
> 
> 
> Diffs
> -
> 
>   krunner/view.h fe7fa1c 
>   krunner/units.h PRE-CREATION 
>   krunner/units.cpp PRE-CREATION 
>   krunner/svgtexturenode.h PRE-CREATION 
>   krunner/framesvgitem.cpp PRE-CREATION 
>   krunner/view.cpp 8e1b448 
>   krunner/framesvgitem.h PRE-CREATION 
>   krunner/dialog.h 6759a6e 
>   krunner/CMakeLists.txt c7dbd71 
> 
> Diff: https://git.reviewboard.kde.org/r/118469/diff/
> 
> 
> Testing
> ---
> 
> Is much much smoother, and the number of repaints/resizes are much less. 
> Tested by comparing frames via apitrace.
> 
> 
> File Attachments
> 
> 
> KRunner + Dialog Class
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png
> KRunner without dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/#review58973
---



krunner/view.cpp


If you really can't fix dialog create a tiny QML file with the contents

import org.kde.plasmacore 2.0
FrameSvgItem {
 svg:...
 anchors.fill: parent
}


then do a setSource(myQMLFile.qml)

that way you won't need to clone half the world to load an.


- David Edmundson


On June 2, 2014, 1:15 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118469/
> ---
> 
> (Updated June 2, 2014, 1:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KRunner: Stop using the dialog class
> 
> The dialog class provides a number of features such as resizing itself
> when the item size changes, vice versa, and has slightly complex logic
> to handle to being a tooltip / dialog / etc. We do not really need any
> of this logic. We're just a simple window with a item + border.
> 
> This removes the duplicated dialog.h header file, but it unfortunately
> introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
> should be a temporary copy until these files are exported properly.
> 
> This patch fixes all the annoying flickering issues with krunner and
> makes it much much smoother. It also fixes issues where the top border
> is initially present but later disappears.
> 
> 
> Diffs
> -
> 
>   krunner/view.h fe7fa1c 
>   krunner/units.h PRE-CREATION 
>   krunner/units.cpp PRE-CREATION 
>   krunner/svgtexturenode.h PRE-CREATION 
>   krunner/framesvgitem.cpp PRE-CREATION 
>   krunner/view.cpp 8e1b448 
>   krunner/framesvgitem.h PRE-CREATION 
>   krunner/dialog.h 6759a6e 
>   krunner/CMakeLists.txt c7dbd71 
> 
> Diff: https://git.reviewboard.kde.org/r/118469/diff/
> 
> 
> Testing
> ---
> 
> Is much much smoother, and the number of repaints/resizes are much less. 
> Tested by comparing frames via apitrace.
> 
> 
> File Attachments
> 
> 
> KRunner + Dialog Class
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png
> KRunner without dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/
---

(Updated June 2, 2014, 1:35 p.m.)


Review request for Plasma, Solid and KDE Usability.


Changes
---

Well spot, Thomas. I had forgotten to update the entries in the .desktop files 
(which end up being used as checkbox labels, so they need to not use title 
case). Fixed now.


Repository: powerdevil


Description
---

This is a series of UI updates I've applied to the powerdevil KCMs. You can 
find them as individual patch series in the sebas/kcmupdates branch.

General:
- Less icon usage, especially in the form layouts
- Title casing throughout
- Better HIG compliance (not 100%, but improved)
- Energy Saving / Actions UI now scales with dialog
- Proper usage of FormLayouts
- A bunch of cleanups of dead code
- Parenting fixes

In Detail:

* Improve Advanced Settings page

- Use a QFormLayout, and do it properly
- Fix up spacing and alignment
- Remove icons before titles
- Use Title Case for Labels
- Shorter labels for better readability

* Clean up brightness-OSD-related dead code


* Make powerdevil actions layout stretch out horizontally


* Compile-time connections in actionconfigwidget


* widget and layout parenting fixes


* No bold font, increased spacing instead

This removes the bold fonts from the checkboxes, as that is non-standard
in the HIG. In order to make it look a bit more structured between the
sections, a bit of spacing is added.

* Remove icons from actions

The icons are really small and add more visual noise than being useful.

* Streamline Comments of KCMs


* Clean up dead code


Diffs (updated)
-

  daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
  daemon/actions/bundled/dimdisplayconfig.cpp f683935 
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
  daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
  daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
  daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
  daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
  daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
231c5d6 
  daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
  daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
  daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
  daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
  daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
  daemon/actions/powerdevilaction.desktop 5b74fea 
  daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
  daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
  daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
  daemon/powerdevil.desktop 20d31c9 
  kcmodule/activities/activitypage.cpp 48e9c6c 
  kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
  kcmodule/common/actionconfigwidget.cpp 2161c84 
  kcmodule/common/actioneditwidget.cpp 4c67b4f 
  kcmodule/global/GeneralPage.cpp d025e42 
  kcmodule/global/generalPage.ui 2ce7cef 
  kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
  kcmodule/profiles/EditPage.cpp a674ccb 
  kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
  kcmodule/profiles/profileEditPage.ui dc26579 
  powerdevil.notifyrc 36acdb6 

Diff: https://git.reviewboard.kde.org/r/118390/diff/


Testing
---

Tested in kcmshell5 and systemsettings, still fully functional.


File Attachments


Energy Saving page before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
Energy Saving page after
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
Advanced page after
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
Advanced page before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/#review58967
---


Also, loses the window shadows (would need duplication of other classes that 
are not going to be exported)
I see that it pretty much causes duplication of a ton of codethat is not public 
and not scheduled to ever be public.

Flickers and excess of repaints are a bug that has to be fixed upstream, not 
worked around with that that is effectively a fork of an huge quantity of code.

- Marco Martin


On June 2, 2014, 1:15 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118469/
> ---
> 
> (Updated June 2, 2014, 1:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KRunner: Stop using the dialog class
> 
> The dialog class provides a number of features such as resizing itself
> when the item size changes, vice versa, and has slightly complex logic
> to handle to being a tooltip / dialog / etc. We do not really need any
> of this logic. We're just a simple window with a item + border.
> 
> This removes the duplicated dialog.h header file, but it unfortunately
> introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
> should be a temporary copy until these files are exported properly.
> 
> This patch fixes all the annoying flickering issues with krunner and
> makes it much much smoother. It also fixes issues where the top border
> is initially present but later disappears.
> 
> 
> Diffs
> -
> 
>   krunner/view.h fe7fa1c 
>   krunner/units.h PRE-CREATION 
>   krunner/units.cpp PRE-CREATION 
>   krunner/svgtexturenode.h PRE-CREATION 
>   krunner/framesvgitem.cpp PRE-CREATION 
>   krunner/view.cpp 8e1b448 
>   krunner/framesvgitem.h PRE-CREATION 
>   krunner/dialog.h 6759a6e 
>   krunner/CMakeLists.txt c7dbd71 
> 
> Diff: https://git.reviewboard.kde.org/r/118469/diff/
> 
> 
> Testing
> ---
> 
> Is much much smoother, and the number of repaints/resizes are much less. 
> Tested by comparing frames via apitrace.
> 
> 
> File Attachments
> 
> 
> KRunner + Dialog Class
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png
> KRunner without dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/
---

(Updated June 2, 2014, 1:15 p.m.)


Review request for Plasma.


Changes
---

Added screenshots showing before and after


Repository: plasma-workspace


Description
---

KRunner: Stop using the dialog class

The dialog class provides a number of features such as resizing itself
when the item size changes, vice versa, and has slightly complex logic
to handle to being a tooltip / dialog / etc. We do not really need any
of this logic. We're just a simple window with a item + border.

This removes the duplicated dialog.h header file, but it unfortunately
introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
should be a temporary copy until these files are exported properly.

This patch fixes all the annoying flickering issues with krunner and
makes it much much smoother. It also fixes issues where the top border
is initially present but later disappears.


Diffs
-

  krunner/view.h fe7fa1c 
  krunner/units.h PRE-CREATION 
  krunner/units.cpp PRE-CREATION 
  krunner/svgtexturenode.h PRE-CREATION 
  krunner/framesvgitem.cpp PRE-CREATION 
  krunner/view.cpp 8e1b448 
  krunner/framesvgitem.h PRE-CREATION 
  krunner/dialog.h 6759a6e 
  krunner/CMakeLists.txt c7dbd71 

Diff: https://git.reviewboard.kde.org/r/118469/diff/


Testing
---

Is much much smoother, and the number of repaints/resizes are much less. Tested 
by comparing frames via apitrace.


File Attachments (updated)


KRunner + Dialog Class
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png
KRunner without dialog
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png


Thanks,

Vishesh Handa

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

KRunner: Stop using the dialog class

The dialog class provides a number of features such as resizing itself
when the item size changes, vice versa, and has slightly complex logic
to handle to being a tooltip / dialog / etc. We do not really need any
of this logic. We're just a simple window with a item + border.

This removes the duplicated dialog.h header file, but it unfortunately
introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
should be a temporary copy until these files are exported properly.

This patch fixes all the annoying flickering issues with krunner and
makes it much much smoother. It also fixes issues where the top border
is initially present but later disappears.


Diffs
-

  krunner/view.h fe7fa1c 
  krunner/units.h PRE-CREATION 
  krunner/units.cpp PRE-CREATION 
  krunner/svgtexturenode.h PRE-CREATION 
  krunner/framesvgitem.cpp PRE-CREATION 
  krunner/view.cpp 8e1b448 
  krunner/framesvgitem.h PRE-CREATION 
  krunner/dialog.h 6759a6e 
  krunner/CMakeLists.txt c7dbd71 

Diff: https://git.reviewboard.kde.org/r/118469/diff/


Testing
---

Is much much smoother, and the number of repaints/resizes are much less. Tested 
by comparing frames via apitrace.


Thanks,

Vishesh Handa

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

2014-06-02 Thread Martin Gräßlin 


> On June 2, 2014, noon, Aleix Pol Gonzalez wrote:
> > Why do you rename the desktop file? If that's needed, then maybe we should 
> > rename them all?
> 
> Martin Gräßlin wrote:
> I just didn't find the email thread, but IIRC dfaure requested such 
> changes. It's done in kate which I looked at for the other change.

ok found it: http://comments.gmane.org/gmane.comp.kde.devel.core/83106


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118461/#review58940
---


On June 2, 2014, 7:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118461/
> ---
> 
> (Updated June 2, 2014, 7:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Rename desktop file to org.kde.klipper.desktop
> 
> 
> [klipper] Add X-DBUS-ServiceName to desktop file
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 
>   klipper/klipper.desktop e8085c91f6bcb55c63c65ee110abb918306b3d02 
> 
> Diff: https://git.reviewboard.kde.org/r/118461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer

2014-06-02 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118414/
---

(Updated June 2, 2014, 1:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kwin


Description
---

[killer] Use dialog-warning icon as window icon for killer

Based on the discussion on kwin [1] and plasma-devel [2] mailing list.

[1] http://lists.kde.org/?l=kwin&m=140119827404150&w=2
[2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html


Diffs
-

  killer/killer.cpp 0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25 

Diff: https://git.reviewboard.kde.org/r/118414/diff/


Testing
---


File Attachments


Killer with warning icon
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer

2014-06-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118414/#review58960
---


This review has been submitted with commit 
dc37805586fdb0f061e1949dc4e26cc6f6699077 by Martin Gräßlin to branch master.

- Commit Hook


On May 30, 2014, 6:54 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118414/
> ---
> 
> (Updated May 30, 2014, 6:54 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> [killer] Use dialog-warning icon as window icon for killer
> 
> Based on the discussion on kwin [1] and plasma-devel [2] mailing list.
> 
> [1] http://lists.kde.org/?l=kwin&m=140119827404150&w=2
> [2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html
> 
> 
> Diffs
> -
> 
>   killer/killer.cpp 0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25 
> 
> Diff: https://git.reviewboard.kde.org/r/118414/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Killer with warning icon
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-02 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/
---

(Updated June 2, 2014, 12:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

As agreed on irc (someday ago), the agenda part is useless until there's a 
proper agenda backend and should just be hidden. Here's a patch simply hiding 
the left part - it's easier to do just "visible: false" than comment it out and 
then comment out/remove all the lines referencing parts of the agenda, also 
cleaner.

I added a big comment at the file beginning, I'll fill the commit sha after 
committing so it can be easily reverted (the comment will be separate commit).

Screenshot attached.

Oh and you might want to remove the clock from panel and readd it/remove plasma 
config as the popup size seems to be saved and so after this patch you may 
still get the original-sized half-empty dialog.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 

Diff: https://git.reviewboard.kde.org/r/118357/diff/


Testing
---


File Attachments


Calendar without agenda
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-02 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/#review58957
---


This review has been submitted with commit 
bfd62154d8e892d4fdc87d27d25d07cb7841c1e6 by Martin Klapetek to branch master.

- Commit Hook


On May 27, 2014, 4 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118357/
> ---
> 
> (Updated May 27, 2014, 4 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As agreed on irc (someday ago), the agenda part is useless until there's a 
> proper agenda backend and should just be hidden. Here's a patch simply hiding 
> the left part - it's easier to do just "visible: false" than comment it out 
> and then comment out/remove all the lines referencing parts of the agenda, 
> also cleaner.
> 
> I added a big comment at the file beginning, I'll fill the commit sha after 
> committing so it can be easily reverted (the comment will be separate commit).
> 
> Screenshot attached.
> 
> Oh and you might want to remove the clock from panel and readd it/remove 
> plasma config as the popup size seems to be saved and so after this patch you 
> may still get the original-sized half-empty dialog.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 
> 
> Diff: https://git.reviewboard.kde.org/r/118357/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Calendar without agenda
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

2014-06-02 Thread R.Harish Navnit 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118468/
---

Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Repository: plasma-mediacenter


Description
---

As of now, PMC only uses the MediaPlay button to give the user an option to 
play/pause media from the home screen. However, not all keyboards have the 
MediaPlay button AFAIK. 
This patch gives the user the option to play/pause the media from the home 
screen using the spacebar key as another alternative. 


Diffs
-

  shells/newshell/package/contents/ui/mediacenter.qml e1bc0e6 

Diff: https://git.reviewboard.kde.org/r/118468/diff/


Testing
---

Play any media, navigate to homescreen. Press the spacebar to check if the 
media plays/pauses. 

Seems to work fine to me. 


Thanks,

R.Harish  Navnit

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

2014-06-02 Thread Martin Gräßlin 


> On June 2, 2014, noon, Aleix Pol Gonzalez wrote:
> > Why do you rename the desktop file? If that's needed, then maybe we should 
> > rename them all?

I just didn't find the email thread, but IIRC dfaure requested such changes. 
It's done in kate which I looked at for the other change.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118461/#review58940
---


On June 2, 2014, 7:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118461/
> ---
> 
> (Updated June 2, 2014, 7:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Rename desktop file to org.kde.klipper.desktop
> 
> 
> [klipper] Add X-DBUS-ServiceName to desktop file
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 
>   klipper/klipper.desktop e8085c91f6bcb55c63c65ee110abb918306b3d02 
> 
> Diff: https://git.reviewboard.kde.org/r/118461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118038/#review58942
---

Ship it!


Ship It!

- Sebastian Kügler


On May 8, 2014, 5:17 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118038/
> ---
> 
> (Updated May 8, 2014, 5:17 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Bring back a KCM for the screen locker
> 
> Note: I will improve the default values to get them sane. That needs 
> adjustements in the screenlocker source base and I want to get the review of 
> the UI started earlier.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION 
>   ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION 
>   ksmserver/screenlocker/CMakeLists.txt 
> 3407ea46d5046f2f5b2e7321d714ad1e65ffceea 
> 
> Diff: https://git.reviewboard.kde.org/r/118038/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> KCM with values
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png
> KCM without values
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png
> In Systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName

2014-06-02 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118461/#review58940
---


Why do you rename the desktop file? If that's needed, then maybe we should 
rename them all?

- Aleix Pol Gonzalez


On June 2, 2014, 5:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118461/
> ---
> 
> (Updated June 2, 2014, 5:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Rename desktop file to org.kde.klipper.desktop
> 
> 
> [klipper] Add X-DBUS-ServiceName to desktop file
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 
>   klipper/klipper.desktop e8085c91f6bcb55c63c65ee110abb918306b3d02 
> 
> Diff: https://git.reviewboard.kde.org/r/118461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts

2014-06-02 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118428/#review58939
---

Ship it!


Ship It!

- Sebastian Kügler


On May 30, 2014, 3:42 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118428/
> ---
> 
> (Updated May 30, 2014, 3:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Drop configuration options for taskbar and desktop fonts
> 
> These weren't being used by plasma so it ended up as a config
> option to do nothing.
> 
> 
> Diffs
> -
> 
>   kcms/fonts/fonts.cpp 9747761 
> 
> Diff: https://git.reviewboard.kde.org/r/118428/diff/
> 
> 
> Testing
> ---
> 
> Opened KCM. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

2014-06-02 Thread Sebastian Kügler 


> On May 30, 2014, 3:39 p.m., Alexander Richardson wrote:
> > Shouldn't this rather use qCDebug() so that the output can be disabled?

I think it would be nice, but I'd also leave the choice between qDebug and 
qCDebug up to the maintainer -- Martin. :)

We haven't enforced it everywhere yet.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/#review58827
---


On May 30, 2014, 10:29 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118417/
> ---
> 
> (Updated May 30, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KDebug to QDebug
> 
> 
> Diffs
> -
> 
>   klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 
>   klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf 
>   klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf 
>   klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 
>   klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a 
>   klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 
>   klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 
>   klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 
>   klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 
>   klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b 
> 
> Diff: https://git.reviewboard.kde.org/r/118417/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118272: batterymonitor visual cleanups

2014-06-02 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118272/#review58934
---


There's been a bug report about inconsistent indicator/slider lengths: Bug 
335540

- Kai Uwe Broulik


On May 23, 2014, 7:21 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118272/
> ---
> 
> (Updated May 23, 2014, 7:21 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Clean up Battery Monitor
> 
> This patch simplifies the battery's ui, and brings spacing in line with
> Plasma 5 standards.
> 
> In detail:
> 
> - removing the selection item on batteries: it's already visible by the
>   text shown that the battery is selected. It also doesn't need the
>   selection semantics across the ui, because -- for what?
> - remove separator lines, in Plasma 5, we use spacing for this case
> - align extra battery info to the slider, improves logical grouping
> - Improve HighDPI by removing hard-coded layout hints, use units.gridUnit
>   throughout
> - Fix batteryitem's status: it would show the wrong icon and time label,
>   because AC Adapter can be empty. Checking charging is semantically
>   correct here, since it uses the charge state, not the adapter state.
> - remove a bunch of SVGs that were used internally to get margins -- use
>   gridUnit for layout internal margins instead
> - fix slider's right alignment, this would jump based on the percentage
>   label's width, which varies per item. We know the rough length of the
>   percentage label from the context, and can align the labels to that.
> 
> Code is also in kde-workspace[sebas/batterycleanup].
> 
> 
> Diffs
> -
> 
>   applets/batterymonitor/contents/ui/BatteryItem.qml 431aa9a 
>   applets/batterymonitor/contents/ui/BrightnessItem.qml a91ccde 
>   applets/batterymonitor/contents/ui/CompactRepresentation.qml 8d7b26e 
>   applets/batterymonitor/contents/ui/PopupDialog.qml 0444199 
>   applets/batterymonitor/contents/ui/PowerManagementItem.qml 530fce3 
>   applets/batterymonitor/contents/ui/batterymonitor.qml 7536f95 
> 
> Diff: https://git.reviewboard.kde.org/r/118272/diff/
> 
> 
> Testing
> ---
> 
> Tested with plasmoidviewer and in the shell, plugging ac in and out, tried 
> different combinations of values.
> 
> 
> File Attachments
> 
> 
> before (collapsed)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/abc1d750-6eb7-4728-a5f2-e9f8566b5b44__battery-before-collapsed.png
> before (expanded)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/2a0b9ad3-03e8-4f07-a158-ceb0d3d0e23c__battery-before-expanded.png
> after (collapsed)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/4439093c-345c-44af-afa1-a05cb0973990__battery-after-collapsed.png
> after (expanded)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/b18cf61f-0ff1-4e91-93c2-ebd6b1dab38d__battery-after-expanded.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel