Re: Review Request 118866: Start playing after Play All is used
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/#review60679 --- This should also be fixed in Browse Music backend for consistency. Other than that Looks good to me. - Sinny Kumari On June 21, 2014, 5:43 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- (Updated June 21, 2014, 5:43 p.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- We should ask the model to start playing once we add all the songs to the playlist as a result of the user using Play All. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 68eecf3 libs/mediacenter/multipleplaylistmodel.h 1c7731b libs/mediacenter/multipleplaylistmodel.cpp 4b475c7 libs/mediacenter/playlistmodel.h 50157ff libs/mediacenter/playlistmodel.cpp 44abbc1 Diff: https://git.reviewboard.kde.org/r/118866/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : plasma-workspace_master_qt5 #516
See http://build.kde.org/job/plasma-workspace_master_qt5/516/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118876: Remove start in systemtray option from the kmenuedit.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60694 --- This might make sense as a temp measure, but what about porting ksystraycmd to KStatusNotifierItem? The KDE 4 version does see active use. - Eike Hein On June 22, 2014, 12:17 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 12:17 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
On June 22, 2014, 5:55 p.m., Eike Hein wrote: This might make sense as a temp measure, but what about porting ksystraycmd to KStatusNotifierItem? The KDE 4 version does see active use. Porting is not possible (removed), one have to write from scratch.. - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60694 --- On June 22, 2014, 5:47 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 5:47 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60696 --- Additionally, note that the Place in system tray option is also in frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general .desktop app link properties UI (the one that also used to be loaded by the config dialog for Icon applets before we lost that due to the Qt Quick Controls switch). - Eike Hein On June 22, 2014, 12:17 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 12:17 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
On June 22, 2014, 12:25 p.m., Eike Hein wrote: This might make sense as a temp measure, but what about porting ksystraycmd to KStatusNotifierItem? The KDE 4 version does see active use. Bhushan Shah wrote: Porting is not possible (removed), one have to write from scratch.. Just because code was removed from a repo doesn't mean it can't be restored and ported. That's why we use version control in the first place - so we don't lose past code. It might still make sense to start from scratch considering it's not complex and needs to change quite a bit by switching from KSystemTrayIcon, but to maintain compatibility with existing menu entries and scripts people have the command line interface of ksystraycmd should be recreated closely. I know of distros that have shipped such things in their default configs quite recently (e.g. Netrunner Linux). - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60694 --- On June 22, 2014, 12:17 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 12:17 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
On June 22, 2014, 5:59 p.m., Eike Hein wrote: Additionally, note that the Place in system tray option is also in frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general .desktop app link properties UI (the one that also used to be loaded by the config dialog for Icon applets before we lost that due to the Qt Quick Controls switch). Or maybe we can make this option do nothing for now.. and revisit this once someone ports ksystraycmd to sni? I opened this review because one of user at #plasma reported autostart apps not starting due to this thing. - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60696 --- On June 22, 2014, 5:47 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 5:47 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
On June 22, 2014, 12:29 p.m., Eike Hein wrote: Additionally, note that the Place in system tray option is also in frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general .desktop app link properties UI (the one that also used to be loaded by the config dialog for Icon applets before we lost that due to the Qt Quick Controls switch). Bhushan Shah wrote: Or maybe we can make this option do nothing for now.. and revisit this once someone ports ksystraycmd to sni? I opened this review because one of user at #plasma reported autostart apps not starting due to this thing. We could, but people might also have existing custom menu entry .desktop files relying on ksystraycmd working, so while turning the option into a no-op would prevent broken entries from being created it wouldn't fully solve the problem (nor would removing the option actually). The problem of course is that this is a case that can't be fully addressed by keeping the KDE 4 version around as a fallback either, since the tray applet no longer supports KSystemTrayIcon. Seems to me the only real fix is to port ksystraycmd indeed ... - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60696 --- On June 22, 2014, 12:17 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 12:17 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 6:06 p.m.) Status -- This change has been discarded. Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118804: Register ksmserver as logind session leader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/#review60716 --- According to Lennart we should not call TakeControl, so I guess that while we wait for kdbus we should discard this review? - Àlex Fiestas On June 19, 2014, 7:03 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/ --- (Updated June 19, 2014, 7:03 p.m.) Review request for Plasma. Bugs: 335390 https://bugs.kde.org/show_bug.cgi?id=335390 Repository: plasma-workspace Description --- This is an initial (not yet working) attempt to fix bug#335390. After some discussion in #systemd, it seems there's some more work needed outside of ksmserver. Will have to figure out the next actions to be taken to continue on this. See also my mail on systemd-devel: http://lists.freedesktop.org/archives/systemd-devel/2014-June/020238.html Diffs - ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 Diff: https://git.reviewboard.kde.org/r/118804/diff/ Testing --- - Copy /usr/lib/systemd/system/systemd-logind.service to /etc/systemd/system/systemd-logind.service - Set Environment=SYSTEMD_LOG_LEVEL=debug in the [Service] section of /etc/systemd/system/systemd-logind.service - Run systemctl daemon-reload - Reboot (also possible without a reboot, but far more complicated and requires to terminate the X session anyways, so a reboot is the most straightforward solution) To test - apply patch + rebuild plasma-workspace - kill ksmserver - Run journalctl -n 20 -f -u systemd-logind to monitor logind - Run tail -f ~/.xsession-errors or journalctl --user -n 20 -f --user-unit ksmserver (for systemd user-session users) to monitor ksmserver's output - restart ksmserver Thanks, Elias Probst ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118883: Splash minor visual refinement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/ --- Review request for Plasma. Repository: plasma-workspace Description --- See before and after screenshots. Diffs - lookandfeel/contents/splash/Splash.qml f2246a4 Diff: https://git.reviewboard.kde.org/r/118883/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/199ecc64-0dca-4574-8548-f5f4063e6b5b__splash0.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/b6dc5cb0-f847-4fac-b7bd-3b4721d05f88__splash1.png Thanks, Andrew Lake ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
On Saturday 21 June 2014 16:18:10 Kai Uwe Broulik wrote: Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for lockscreen which needs to start quickly or splash which shouldn't unnecessarily delay startup. So, umm, while writing this I figured it's not that good of an idea as I initially thought :-) so you suggest that on millions of devices we blur the window fullscreen every time the user logs in (lots of more important stuff to do) and locks the screen? Compared to preparing it once and just installing it? That sounds like a very bad memory-time tradeoff [1]. Cheers Martin [1] https://en.wikipedia.org/wiki/Time-memory_tradeoff signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118804: Register ksmserver as logind session leader
On June 22, 2014, 4:54 p.m., Àlex Fiestas wrote: According to Lennart we should not call TakeControl, so I guess that while we wait for kdbus we should discard this review? why? And what does that have to do with kdbus? And how long should we wait for kdbus (my understanding here is that we cannot use kdbus any time soon as Qt won't support it)? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/#review60716 --- On June 19, 2014, 9:03 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/ --- (Updated June 19, 2014, 9:03 p.m.) Review request for Plasma. Bugs: 335390 https://bugs.kde.org/show_bug.cgi?id=335390 Repository: plasma-workspace Description --- This is an initial (not yet working) attempt to fix bug#335390. After some discussion in #systemd, it seems there's some more work needed outside of ksmserver. Will have to figure out the next actions to be taken to continue on this. See also my mail on systemd-devel: http://lists.freedesktop.org/archives/systemd-devel/2014-June/020238.html Diffs - ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 Diff: https://git.reviewboard.kde.org/r/118804/diff/ Testing --- - Copy /usr/lib/systemd/system/systemd-logind.service to /etc/systemd/system/systemd-logind.service - Set Environment=SYSTEMD_LOG_LEVEL=debug in the [Service] section of /etc/systemd/system/systemd-logind.service - Run systemctl daemon-reload - Reboot (also possible without a reboot, but far more complicated and requires to terminate the X session anyways, so a reboot is the most straightforward solution) To test - apply patch + rebuild plasma-workspace - kill ksmserver - Run journalctl -n 20 -f -u systemd-logind to monitor logind - Run tail -f ~/.xsession-errors or journalctl --user -n 20 -f --user-unit ksmserver (for systemd user-session users) to monitor ksmserver's output - restart ksmserver Thanks, Elias Probst ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/#review60725 --- I think the suggestion to port ksystemtraycmd to SNI is wrong: we don't want applications in the system tray. Removing X11 support from system tray is one part of the story for that. - Martin Gräßlin On June 22, 2014, 2:36 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118876/ --- (Updated June 22, 2014, 2:36 p.m.) Review request for Plasma and Àlex Fiestas. Repository: kmenuedit Description --- This option uses ksystraycmd tool which is removed long ago http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7 Diffs - basictab.h 9aa4c18 basictab.cpp 6e3e086 Diff: https://git.reviewboard.kde.org/r/118876/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118883: Splash minor visual refinement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/#review60726 --- Ship it! Ship It! - Marco Martin On June 22, 2014, 6:47 p.m., Andrew Lake wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/ --- (Updated June 22, 2014, 6:47 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- See before and after screenshots. Diffs - lookandfeel/contents/splash/Splash.qml f2246a4 Diff: https://git.reviewboard.kde.org/r/118883/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/199ecc64-0dca-4574-8548-f5f4063e6b5b__splash0.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/b6dc5cb0-f847-4fac-b7bd-3b4721d05f88__splash1.png Thanks, Andrew Lake ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118883: Splash minor visual refinement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118883/ --- (Updated June 22, 2014, 7:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- See before and after screenshots. Diffs - lookandfeel/contents/splash/Splash.qml f2246a4 Diff: https://git.reviewboard.kde.org/r/118883/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/199ecc64-0dca-4574-8548-f5f4063e6b5b__splash0.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/b6dc5cb0-f847-4fac-b7bd-3b4721d05f88__splash1.png Thanks, Andrew Lake ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
Well, imho the wallpaper on the lockscreen should be the one the user has chosen for his/her desktop, and there we cannot influence that. Even if the lockscreen wallpaper is configurable we don't have influence on its appearance either. Was just a thought, there may be a dozen of reasons not to do as I proposed ;) Cheers, Kai Uwe Am 22.06.2014 20:57 schrieb Martin Graesslin mgraess...@kde.org: On Saturday 21 June 2014 16:18:10 Kai Uwe Broulik wrote: Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for lockscreen which needs to start quickly or splash which shouldn't unnecessarily delay startup. So, umm, while writing this I figured it's not that good of an idea as I initially thought :-) so you suggest that on millions of devices we blur the window fullscreen every time the user logs in (lots of more important stuff to do) and locks the screen? Compared to preparing it once and just installing it? That sounds like a very bad memory-time tradeoff [1]. Cheers Martin [1] https://en.wikipedia.org/wiki/Time-memory_tradeoff ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
This blurred, dimmed version of the default wallpaper has been committed for use by the login, splash and lockscreen. Much respect, Andrew On Sun, Jun 22, 2014 at 12:34 PM, Kai Uwe Broulik k...@privat.broulik.de wrote: Well, imho the wallpaper on the lockscreen should be the one the user has chosen for his/her desktop, and there we cannot influence that. Even if the lockscreen wallpaper is configurable we don't have influence on its appearance either. Was just a thought, there may be a dozen of reasons not to do as I proposed ;) Cheers, Kai Uwe Am 22.06.2014 20:57 schrieb Martin Graesslin mgraess...@kde.org: On Saturday 21 June 2014 16:18:10 Kai Uwe Broulik wrote: Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for lockscreen which needs to start quickly or splash which shouldn't unnecessarily delay startup. So, umm, while writing this I figured it's not that good of an idea as I initially thought :-) so you suggest that on millions of devices we blur the window fullscreen every time the user logs in (lots of more important stuff to do) and locks the screen? Compared to preparing it once and just installing it? That sounds like a very bad memory-time tradeoff [1]. Cheers Martin [1] https://en.wikipedia.org/wiki/Time-memory_tradeoff ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-framework Description --- This adds paintedWidth and paintedHeight properties to PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is scaled keeping aspect ratio, actually is, similar to what QML Image does. This is will eventually allow the taskmanager to size its tooltips more appropriately. (Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?) Diffs - src/declarativeimports/core/windowthumbnail.h 14fc44a src/declarativeimports/core/windowthumbnail.cpp b10f030 Diff: https://git.reviewboard.kde.org/r/118886/diff/ Testing --- Works, reports the actual size Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118889: Use new Konqui in the about Dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/ --- Review request for KDE Frameworks and Plasma. Repository: kxmlgui Description --- This (actually no code, just a new png) replaces the current image in About KDE from the old 3d rendered Konqui to an image using the New official one, done by the author for the purpose Diffs - Diff: https://git.reviewboard.kde.org/r/118889/diff/ Testing --- File Attachments aboutkde.png https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/cf0875f5-52c0-429f-b852-54ea2b6f87fd__aboutkde.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60735 --- (Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?) My rule in these cases is to copy Qt :) QQuickText uses QRectF so it's fine. src/declarativeimports/core/windowthumbnail.h https://git.reviewboard.kde.org/r/118886/#comment42330 I would just have the one signal, paintedSizeChanged. Otherwise we potentially end up re-evaluating loads of bindings twice. (Qt does this for the Text item) src/declarativeimports/core/windowthumbnail.cpp https://git.reviewboard.kde.org/r/118886/#comment42329 Should this and m_paintedSize be QRectFs? We're using reals everywhere, and more importantly using QRectF for the node-setRect() - David Edmundson On June 22, 2014, 7:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/ --- (Updated June 22, 2014, 7:54 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-framework Description --- This adds paintedWidth and paintedHeight properties to PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is scaled keeping aspect ratio, actually is, similar to what QML Image does. This is will eventually allow the taskmanager to size its tooltips more appropriately. (Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?) Diffs - src/declarativeimports/core/windowthumbnail.h 14fc44a src/declarativeimports/core/windowthumbnail.cpp b10f030 Diff: https://git.reviewboard.kde.org/r/118886/diff/ Testing --- Works, reports the actual size Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118891: Folder view icon text background
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- Review request for Plasma. Bugs: 335070 https://bugs.kde.org/show_bug.cgi?id=335070 Repository: plasma-desktop Description --- Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070 The color of the text background is just the complement of the icon label text with a 0.6 opacity applied. Diffs - containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 Diff: https://git.reviewboard.kde.org/r/118891/diff/ Testing --- File Attachments After: Folderview as desktop https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png Thanks, Andrew Lake ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118891: Folder view icon text background
On June 22, 2014, 11:29 p.m., Mark Gaiser wrote: Not a +1 or -1. Just my preference for this. - No background (aka, fully transparent) when nothing is selected. - Selected items should show the background as in your screenshot. Just my preference though :) This change is for readability when nothing is selected. The normal icon selection background is unaffected. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60739 --- On June 22, 2014, 11:09 p.m., Andrew Lake wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- (Updated June 22, 2014, 11:09 p.m.) Review request for Plasma. Bugs: 335070 https://bugs.kde.org/show_bug.cgi?id=335070 Repository: plasma-desktop Description --- Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070 The color of the text background is just the complement of the icon label text with a 0.6 opacity applied. Diffs - containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 Diff: https://git.reviewboard.kde.org/r/118891/diff/ Testing --- File Attachments After: Folderview as desktop https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png Thanks, Andrew Lake ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118891: Folder view icon text background
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- (Updated June 23, 2014, 12:41 a.m.) Review request for Plasma. Changes --- Updated to remove configuration of the icon text color and use theme colors when folderview is the desktop background. Bugs: 335070 https://bugs.kde.org/show_bug.cgi?id=335070 Repository: plasma-desktop Description --- Addresses lack of contrast of folderview containment icon text on certain backgrounds: Bug 335070 The color of the text background is just the complement of the icon label text with a 0.6 opacity applied. Diffs (updated) - containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 Diff: https://git.reviewboard.kde.org/r/118891/diff/ Testing --- File Attachments (updated) Icon text background https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png Thanks, Andrew Lake ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail
On June 22, 2014, 9:29 p.m., David Edmundson wrote: src/declarativeimports/core/windowthumbnail.h, line 93 https://git.reviewboard.kde.org/r/118886/diff/1/?file=283725#file283725line93 I would just have the one signal, paintedSizeChanged. Otherwise we potentially end up re-evaluating loads of bindings twice. (Qt does this for the Text item) I can have the same changed signal for multiple properties? - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60735 --- On June 22, 2014, 7:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/ --- (Updated June 22, 2014, 7:54 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-framework Description --- This adds paintedWidth and paintedHeight properties to PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is scaled keeping aspect ratio, actually is, similar to what QML Image does. This is will eventually allow the taskmanager to size its tooltips more appropriately. (Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?) Diffs - src/declarativeimports/core/windowthumbnail.h 14fc44a src/declarativeimports/core/windowthumbnail.cpp b10f030 Diff: https://git.reviewboard.kde.org/r/118886/diff/ Testing --- Works, reports the actual size Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
