Re: Review Request 120298: Enable lastfmimagefetchertest again,
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/#review67100 --- libs/mediacenter/lastfmimagefetcher.cpp https://git.reviewboard.kde.org/r/120298/#comment46833 In addition to this, can you qDebug the error message so that when this fails in non-test scenarios, there is something to debug. - Shantanu Tushar On Sept. 20, 2014, 3:04 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- (Updated Sept. 20, 2014, 3:04 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- This enables lastfmimagefetchertest again with error handling Diffs - libs/mediacenter/lastfmimagefetcher.h 25d53fd libs/mediacenter/lastfmimagefetcher.cpp 8d9edf4 libs/test/lastfmimagefetchertest.h f315f7c libs/test/lastfmimagefetchertest.cpp e9ff4f1 Diff: https://git.reviewboard.kde.org/r/120298/diff/ Testing --- Checked without internet, test is getting skipped. Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/#review67101 --- Ship it! Ship It! - Shantanu Tushar On Sept. 20, 2014, 1:59 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/ --- (Updated Sept. 20, 2014, 1:59 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Double clicking the image adds toggles between PerspectiveCrop/Fit. This feature is particularly useful while viewing landscape images. Diffs - mediaelements/imageviewer/ImageViewer.qml 81f9cc6a9268040e657216d1dee2e00abf76b4fa Diff: https://git.reviewboard.kde.org/r/119218/diff/ Testing --- Open new image, double click -- toggles. double click again -- toggles again. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120298: Enable lastfmimagefetchertest again,
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/#review67102 --- Ship it! Other than that, this is okay to go in. - Shantanu Tushar On Sept. 20, 2014, 3:04 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- (Updated Sept. 20, 2014, 3:04 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- This enables lastfmimagefetchertest again with error handling Diffs - libs/mediacenter/lastfmimagefetcher.h 25d53fd libs/mediacenter/lastfmimagefetcher.cpp 8d9edf4 libs/test/lastfmimagefetchertest.h f315f7c libs/test/lastfmimagefetchertest.cpp e9ff4f1 Diff: https://git.reviewboard.kde.org/r/120298/diff/ Testing --- Checked without internet, test is getting skipped. Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
I'm running into a little bit of the inconsistency in systray icon sizes as
we're working to try to improve the systray icons.
http://wstaw.org/m/2014/09/21/5.1_systray_scaling_bug.png
The icons are still a WIP so please ignore that for the moment. All the
icons are 16x16 sitting on a padding rect in the svg. The only way I can
get all the icons to properly render at 16x16 is to use a 32x32 padding
rect for the example battery icon and a 24x24 padding rect for the klipper
icon (the first screenshot). If I put them both on a 24x24 rectangle the
battery icon appears to get scaled up resulting in both a bigger icon, and
the icon no longer aligned to the pixel grid resulting in bluriness (the
second screenshot) for the battery icon but a sharp klipper icon. The other
downside is that with such a big padding rect for the battery icon, where
it is used elsewhere the icon is really small.
The same thing happens with the network icons as the battery icons.
I'm not sure how to tell how the icon will be used, so I'm not what rule to
follow to ensure the icon sizes are rendered consistently.
I was going to file a bug, but I wasn't sure so I thought I'd chime in here.
Hope this helps,
Andrew
On Mon, Sep 15, 2014 at 12:56 AM, Marco Martin notm...@gmail.com wrote:
On Friday 12 September 2014, Kai Uwe Broulik wrote:
Hi,
One of the problems is that most of the tray icons use a Plasma IconItem
which follows the icon sizes (16, 22, 32, 48, ...) whereas a custom item
does not.
This is also the reason why battery and network usually appear in a
different size since they're using SvgItem which doesn't have this magic.
Imho that needs fixing in systray.
I'm not sure that can be fixed in the systray, because it's still important
for the clickable area to reach the screen edge(fitts law and all that
jazz),
so the actual item size should still touch the containment edges.
and is the same thing for applets just in the panel, you would have the
same
problem, so in order to retain flexibility custom compactrepresentation
items
should still compute their size...
What about a function
units.roundToIconSize(size) ?
would still be manual, but very quick to do
MouseArea {
//the rootitem that goes to the edget
Item {
//whatever is graphics goes here
width: units.roundToIconSize(parent.width)
height: width
anchors.centerIn: parent
}
}
--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
Correction: it's a 30x30 padding rect that gets the icon sizes the same,
not a 32x32 padding rect.
Hope this helps,
Andrew
On Sun, Sep 21, 2014 at 1:17 AM, Andrew Lake wrote:
I'm running into a little bit of the inconsistency in systray icon sizes
as we're working to try to improve the systray icons.
http://wstaw.org/m/2014/09/21/5.1_systray_scaling_bug.png
The icons are still a WIP so please ignore that for the moment. All the
icons are 16x16 sitting on a padding rect in the svg. The only way I can
get all the icons to properly render at 16x16 is to use a 32x32 padding
rect for the example battery icon and a 24x24 padding rect for the klipper
icon (the first screenshot). If I put them both on a 24x24 rectangle the
battery icon appears to get scaled up resulting in both a bigger icon, and
the icon no longer aligned to the pixel grid resulting in bluriness (the
second screenshot) for the battery icon but a sharp klipper icon. The other
downside is that with such a big padding rect for the battery icon, where
it is used elsewhere the icon is really small.
The same thing happens with the network icons as the battery icons.
I'm not sure how to tell how the icon will be used, so I'm not what rule
to follow to ensure the icon sizes are rendered consistently.
I was going to file a bug, but I wasn't sure so I thought I'd chime in
here.
Hope this helps,
Andrew
On Mon, Sep 15, 2014 at 12:56 AM, Marco Martin notm...@gmail.com wrote:
On Friday 12 September 2014, Kai Uwe Broulik wrote:
Hi,
One of the problems is that most of the tray icons use a Plasma IconItem
which follows the icon sizes (16, 22, 32, 48, ...) whereas a custom item
does not.
This is also the reason why battery and network usually appear in a
different size since they're using SvgItem which doesn't have this
magic.
Imho that needs fixing in systray.
I'm not sure that can be fixed in the systray, because it's still
important
for the clickable area to reach the screen edge(fitts law and all that
jazz),
so the actual item size should still touch the containment edges.
and is the same thing for applets just in the panel, you would have the
same
problem, so in order to retain flexibility custom compactrepresentation
items
should still compute their size...
What about a function
units.roundToIconSize(size) ?
would still be manual, but very quick to do
MouseArea {
//the rootitem that goes to the edget
Item {
//whatever is graphics goes here
width: units.roundToIconSize(parent.width)
height: width
anchors.centerIn: parent
}
}
--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : plasma-workspace_master_qt5 #880
See http://build.kde.org/job/plasma-workspace_master_qt5/880/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
On Sep 21, 2014 10:39 AM, Andrew Lake jamboar...@gmail.com wrote: Correction: it's a 30x30 padding rect that gets the icon sizes the same, not a 32x32 padding rect. The battery (and possibly metworkmanager) were known for being a bit too big. I have now added api to make it possible to compute the correct size, so tjey should be fixed in madter shortly. Btw, since we are refining systray icons, do they work also on a size of 22x22(if not I'll fix the code)? I would love to get rid of the old hack of 24x24, that is just a remnant of the xembed legacy icons -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images
On Sept. 21, 2014, 12:24 p.m., Shantanu Tushar wrote: Ship It! Worth reminding that I lack commit acccess :) - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/#review67101 --- On Sept. 20, 2014, 7:29 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/ --- (Updated Sept. 20, 2014, 7:29 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Double clicking the image adds toggles between PerspectiveCrop/Fit. This feature is particularly useful while viewing landscape images. Diffs - mediaelements/imageviewer/ImageViewer.qml 81f9cc6a9268040e657216d1dee2e00abf76b4fa Diff: https://git.reviewboard.kde.org/r/119218/diff/ Testing --- Open new image, double click -- toggles. double click again -- toggles again. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
Tangentially related: The icons aren't horizontally centered in a vertical panel. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
Btw, since we are refining systray icons, do they work also on a size of 22x22(if not I'll fix the code)? I would love to get rid of the old hack of 24x24, that is just a remnant of the xembed legacy icons Is that the reason why even if I use units.roundToIconSize on the batterymonitor the icon still resizes at different thresholds? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/ --- (Updated Sept. 21, 2014, 1:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Double clicking the image adds toggles between PerspectiveCrop/Fit. This feature is particularly useful while viewing landscape images. Diffs - mediaelements/imageviewer/ImageViewer.qml 81f9cc6a9268040e657216d1dee2e00abf76b4fa Diff: https://git.reviewboard.kde.org/r/119218/diff/ Testing --- Open new image, double click -- toggles. double click again -- toggles again. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120298: Enable lastfmimagefetchertest again,
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- (Updated Sept. 21, 2014, 2:06 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- This enables lastfmimagefetchertest again with error handling Diffs - libs/mediacenter/lastfmimagefetcher.h 25d53fd libs/mediacenter/lastfmimagefetcher.cpp 8d9edf4 libs/test/lastfmimagefetchertest.h f315f7c libs/test/lastfmimagefetchertest.cpp e9ff4f1 Diff: https://git.reviewboard.kde.org/r/120298/diff/ Testing --- Checked without internet, test is getting skipped. Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
On Sun, Sep 21, 2014 at 2:06 AM, Marco Martin wrote: Btw, since we are refining systray icons, do they work also on a size of 22x22(if not I'll fix the code)? I would love to get rid of the old hack of 24x24, that is just a remnant of the xembed legacy icons I changed the padding rect on klipper and the battery icons to 22x22 with the same 16x16 icon size in both. The result is here: http://wstaw.org/m/2014/09/21/5.1_scaling_bug_C.png The klipper icon seems to render fine. The battery icon scales up. With the fixes in-place or expected to be in-place, is it ok if I target a 22x22 padding rect for all icons? Thanks for all your help! Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Exclude X11 when building for Wayland Diffs - CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c Diff: https://git.reviewboard.kde.org/r/120306/diff/ Testing --- Thanks, Pier Luigi Fiorini ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)
https://bugs.kde.org/show_bug.cgi?id=158379 Hugo Pereira Da Costa hugo.pere...@free.fr changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #12 from Hugo Pereira Da Costa hugo.pere...@free.fr --- Closing because fixed after commits from previous comments -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
startkde script has some qt4 relics
startkde has the following code: # in case we have been started with full pathname spec without being in PATH bindir=`echo $0 | sed -n 's,^\(/.*\)/[^/][^/]*$,\1,p'` if [ -n $bindir ]; then qbindir=`qtpaths --binaries-dir` qdbus=$qbindir/qdbus case $PATH in $bindir|$bindir:*|*:$bindir|*:$bindir:*) ;; *) PATH=$bindir:$PATH; export PATH;; esac else qdbus=qdbus fi There are two problems with this 1. qdbus is a relic of qt4 2. qtpaths fails if qtbase is not installed to a system default path. How do I set the appropriate path before starting Plasma5 from sddm using /usr/share/xsessions/plasma.desktop? In my case qt4 and qt5 are in different prefixes. Regards, Treeve ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: startkde script has some qt4 relics
1. qdbus is a relic of qt4 No it isn't. qdbus exists in qt5 too. In my case qt4 and qt5 are in different prefixes. I suggest either set the qt paths in /etc/profile.d or in .pam_environment. (see man pam_env) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review67165 --- Why are we exclusive at compile time? - David Edmundson On Sept. 21, 2014, 2:50 p.m., Pier Luigi Fiorini wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- (Updated Sept. 21, 2014, 2:50 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Exclude X11 when building for Wayland Diffs - CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c Diff: https://git.reviewboard.kde.org/r/120306/diff/ Testing --- Thanks, Pier Luigi Fiorini ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
Padding inside the SVG? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
On Sep 21, 2014 3:47 PM, David Edmundson wrote: Padding inside the SVG? Yes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
Padding inside the SVG? Yes I don't think this is the right long-term approach. We end up with problems like in the original post where it's difficult to make another item line up with an icon. IMHO padding should be applied at a QML level, not inside the component. It makes the behaviour a bit different to everything else. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
On Sun, Sep 21, 2014 at 5:39 PM, David Edmundson wrote: Padding inside the SVG? Yes I don't think this is the right long-term approach. We end up with problems like in the original post where it's difficult to make another item line up with an icon. IMHO padding should be applied at a QML level, not inside the component. It makes the behaviour a bit different to everything else. David Sorry David, I wasn't terribly clear. I'm not advocating padding in the asset as the correct way to handle padding. I was actually asking if I should target the icon asset in the plasma theme icon svgs to a source size of 22x22 instead of the varying sizes right now that appears to be necessary to achieve consistent scaling and pixel grid alignment in the systray. (For the specific icons I'm working on they *happen* to have some padding in the asset relative to the visible portions of the asset, but only as required to match the corresponding icons in the main icon theme.) Sorry for the confusion. :-( Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
