Re: Review Request 120500: Remove VLC workaround
On Oct. 5, 2014, 3:11 p.m., Martin Klapetek wrote: VLC no longer seems to be exposing multiple mpris interfaces Kubuntu 14.04, VLC 2.1.4 and I still see two mpris interfaces. I'll try the patch out in the evening. Kai Uwe Broulik wrote: Kubuntu 14.10, VLC 2.2.0-pre2 here. Maybe they fixed that for the 2.2 version, so probably for master then instead of Plasma/5.1 Well we still need to have something for the people running 2.2.0, so I'd suggest to actually revert the logic - watch only the .vlc interface rather than the .vlc.instance interfaces. This does however limit it to control only one single instance of VLC while you can be running multiple instances of VLC with multiple mpris interfaces. On the other hand, we can always declare that as unsupported ;) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120500/#review67957 --- On Oct. 5, 2014, 3:09 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120500/ --- (Updated Oct. 5, 2014, 3:09 p.m.) Review request for Plasma, Bhushan Shah and Martin Klapetek. Bugs: 332584 https://bugs.kde.org/show_bug.cgi?id=332584 Repository: plasma-workspace Description --- commit a998595ff7fa0751c894987e2a046ef685169ef5 Author: Kai Uwe Broulik k...@privat.broulik.de Date: Sun Oct 5 15:03:56 2014 +0200 Revert Fix mediacontroller showing twice for VLC VLC no longer seems to be exposing multiple mpris interfaces, and also the media controller should only be shown once regardless of this. This fixes mediacontroller not working when Plasma starts after VLC (crash recovery) CCBUG: 332584 This reverts commit f18ef02d27a060e5db37f99ce359796f4d61. Diffs - dataengines/mpris2/mpris2engine.cpp 42ca565 Diff: https://git.reviewboard.kde.org/r/120500/diff/ Testing --- Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Collecting new/improved stuff in 5.1 for promo
On Tuesday 30 September 2014 01:04:12 David Edmundson wrote: we'll want a sentence or 2 about Wayland to show progress (kwayland lib etc.) * new binary kwin_wayland * kwin_wayland supports starting the X-Server it needs to connect to * Wayland (client) connection is hold in a thread * Support for using fullscreen shell interface * Wayland related code split out into a new kwayland lib Additional non Wayland related KWin stuff: * use of libepoxy * use of atlas texture for window decorations in OpenGL compositor * support for EGL_EXT_platform_x11 and EGL_EXT_platform_wayland * support for GLX_INTEL_swap_event in glxbackend Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Minutes Plasma Hangout, 6-10-2014 Present: Antonis, Kai Uwe, Jonathan, Martin K, Marco, Martin G, Harald, Sebastian For updates on TODO/status, see also Kanban board at: https://todo.kde.org/?controller=boardaction=showproject_id=13 Antonis: - Finished exams - Now planning to work on Plasma Active again Jonathan: - 5.1 Beta is out - Final tagging on Thursday (make sure all the bugs are fixed!) - gtk theme KCM won't make it into this release officially (hopefully next) Kai Uwe: - Did 5.1 visual fixes in battery, klipper, mediacontroller) Marco: - Bugfixing - Plasma::Theme fixes (less contrast in Breeze Dark, margins for highlights, dialog) - More fixes (plasma-workspace): panel positioning, panel configs - KPackage framework build fixes for Jenkins - started on a proof-of-concept app to load from one single package Martin G: - Back from vacation - Going to XDC in Bordeaux tomorrow (will present on porting KWin to XCB) done Martin K: - Refactored layout of digital clock (it's three labels now) - Switching to KAccounts and friends now Harald: - Just joined for trolling ;) - Didn't mention that he's rocking the CI and build orchestration game Sebastian: - Worked on Wayland libkscreen backend, - Some tests pass, initialization is OK now - Needs more tests and completing features, planning to do that - More details: https://plus.google.com/hangouts/_/g5nzbeyeb7zdihlmu3gjss3rl4a - Planning to prep promo work for 5.1 release with David Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review67980 --- src/client/registry.h https://git.reviewboard.kde.org/r/120471/#comment47383 I would recommend to move it to ConnectionThread as it's more connection related then registry related. Also please add a test case for it (both threaded and unthreaded) - should be fairly simple in fact. - Martin Gräßlin On Oct. 3, 2014, 5:15 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 3, 2014, 5:15 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs - src/client/registry.h 9e63a2b20c9734cc599f8c612441165b20d361bd src/client/registry.cpp 22f948488b88f2a9fbf2fd78f0d223d05585fe17 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339725] New: Breeze window decoration adds spacing around the window
https://bugs.kde.org/show_bug.cgi?id=339725 Bug ID: 339725 Summary: Breeze window decoration adds spacing around the window Product: Breeze Version: 5.0.1 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: sud...@sudhirkhanger.com Using Breeze window decoration adds some spacing around the window. It much more prominent on the top. Please see the screenshots. http://i.imgur.com/E14tTOU.png http://i.imgur.com/Jmv7khp.png Reproducible: Always Steps to Reproduce: 1. Choose Breeze Window decoration in systemsettings 2. 3. Actual Results: Added spacing around window Expected Results: There should be no padding around the window Plasma 5.0.2 and Frameworks 5.2 on Fedora 20. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339725] Breeze window decoration adds spacing around the window
https://bugs.kde.org/show_bug.cgi?id=339725 Martin Klapetek mklape...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||mklape...@kde.org --- Comment #1 from Martin Klapetek mklape...@kde.org --- *** This bug has been marked as a duplicate of bug 338979 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco
https://bugs.kde.org/show_bug.cgi?id=338979 Martin Gräßlin mgraess...@kde.org changed: What|Removed |Added Assignee|kwin-bugs-n...@kde.org |plasma-devel@kde.org Component|aurorae |general CC||kwin-bugs-n...@kde.org Product|kwin|Breeze --- Comment #5 from Martin Gräßlin mgraess...@kde.org --- to me this looks like intended in the Breeze theme - reassigning to Breeze therefore. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
black window on qml kcms
Hi all, since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer will be slower, hackier, but i don't think we can really ship 5.1 with kcm modules randomly turing black -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: black window on qml kcms
On Monday 06 October 2014 14:04:16 Marco Martin wrote: Hi all, since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer will be slower, hackier, but i don't think we can really ship 5.1 with kcm modules randomly turing black if we can get it without other regressions I think that sounds valid. I guess everybody would have used QQuickWidget if it had existed back when we wrote the code. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: black window on qml kcms
On Monday, October 06, 2014 14:04:16 Marco Martin wrote: since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer Just to prevent confusion (your email isn't 100 clear), you advocate to switch *to* QQuickWidget, and *away from* QWidget::createWindowContainer, right? will be slower, hackier, but i don't think we can really ship 5.1 with kcm modules randomly turing black I agree. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: black window on qml kcms
On Monday 06 October 2014, Martin Gräßlin wrote: On Monday 06 October 2014 14:04:16 Marco Martin wrote: Hi all, since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer will be slower, hackier, but i don't think we can really ship 5.1 with kcm modules randomly turing black if we can get it without other regressions I think that sounds valid. I guess everybody would have used QQuickWidget if it had existed back when we wrote the code. aand, right after writing this, i see the black window problem is not locally reproduceable anymore. Can anybody reproduce the problem on current master? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: black window on qml kcms
On Monday 06 October 2014, Sebastian Kügler wrote: On Monday, October 06, 2014 14:04:16 Marco Martin wrote: since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer Just to prevent confusion (your email isn't 100 clear), you advocate to switch *to* QQuickWidget, and *away from* QWidget::createWindowContainer, right? the other way around: the ones that exibit the problem are using QQuickWidget, that has a couple of upstream black window inducing bugs -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-desktop_master_qt5 #684
See http://build.kde.org/job/plasma-desktop_master_qt5/684/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: black window on qml kcms
On Monday 06 October 2014, Martin Gräßlin wrote: On Monday 06 October 2014 14:04:16 Marco Martin wrote: Hi all, since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer will be slower, hackier, but i don't think we can really ship 5.1 with kcm modules randomly turing black if we can get it without other regressions I think that sounds valid. I guess everybody would have used QQuickWidget if it had existed back when we wrote the code. the diff is very small: can someone try it to see if it solves the black widget for look and feel? (changes only that one, splash screen and lock screen should still be black) -- Marco Martin diff --git a/kcms/lookandfeel/kcm.cpp b/kcms/lookandfeel/kcm.cpp index 0cf0d22..2b61412 100644 --- a/kcms/lookandfeel/kcm.cpp +++ b/kcms/lookandfeel/kcm.cpp @@ -31,6 +31,7 @@ #include QStandardPaths #include QProcess #include QQuickWidget +#include QQuickView #include KGlobalSettings #include KIconLoader @@ -93,16 +94,17 @@ KCMLookandFeel::KCMLookandFeel(QWidget* parent, const QVariantList args) m_model-setItemRoleNames(roles); QVBoxLayout* layout = new QVBoxLayout(this); -m_quickWidget = new QQuickWidget(this); -m_quickWidget-setResizeMode(QQuickWidget::SizeRootObjectToView); +m_quickView = new QQuickView(0); +QWidget *widget = QWidget::createWindowContainer(m_quickView, this); +m_quickView-setResizeMode(QQuickView::SizeRootObjectToView); Plasma::Package package = Plasma::PluginLoader::self()-loadPackage(Plasma/Generic); package.setDefaultPackageRoot(plasma/kcms); package.setPath(kcm_lookandfeel); -m_quickWidget-rootContext()-setContextProperty(kcm, this); -m_quickWidget-setSource(QUrl::fromLocalFile(package.filePath(mainscript))); -setMinimumHeight(m_quickWidget-initialSize().height()); +m_quickView-rootContext()-setContextProperty(kcm, this); +m_quickView-setSource(QUrl::fromLocalFile(package.filePath(mainscript))); +setMinimumHeight(m_quickView-initialSize().height()); -layout-addWidget(m_quickWidget); +layout-addWidget(widget); } KCMLookandFeel::~KCMLookandFeel() diff --git a/kcms/lookandfeel/kcm.h b/kcms/lookandfeel/kcm.h index ca6d10f..b6b6ec9 100644 --- a/kcms/lookandfeel/kcm.h +++ b/kcms/lookandfeel/kcm.h @@ -28,7 +28,7 @@ #include Plasma/Package -class QQuickWidget; +class QQuickView; class QStandardItemModel; class KCMLookandFeel : public KCModule @@ -100,7 +100,7 @@ Q_SIGNALS: private: QDir cursorThemeDir(const QString theme, const int depth); const QStringList cursorSearchPaths(); -QQuickWidget *m_quickWidget; +QQuickView *m_quickView; QStandardItemModel *m_model; Plasma::Package m_package; QString m_selectedPlugin; ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review67994 --- systemmonitor/kdedksysguard.cpp https://git.reviewboard.kde.org/r/120513/#comment47395 It doesn't have to be a QList() - Lukáš Tinkl On Říj. 6, 2014, 4:14 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Říj. 6, 2014, 4:14 odp.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
On Okt. 6, 2014, 4:18 nachm., Lukáš Tinkl wrote: systemmonitor/kdedksysguard.cpp, line 57 https://git.reviewboard.kde.org/r/120513/diff/1/?file=316750#file316750line57 It doesn't have to be a QList() even if it were a list I would recommend to use the initializer list instead of first creating the list and then appending the shortcut. Otherwise +1 to the change. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review67994 --- On Okt. 6, 2014, 4:14 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Okt. 6, 2014, 4:14 nachm.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: black window on qml kcms
Short term: sure. Make sure it's documented as to why in the code. According to aleix and andreas its mostly fixed in qt 5.4, so we should be able to revert it for plasma 5.2. On 6 Oct 2014 14:04, Marco Martin notm...@gmail.com wrote: Hi all, since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer will be slower, hackier, but i don't think we can really ship 5.1 with kcm modules randomly turing black -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120515: Use QLineEdit rather than KLineEdit in libksysguard
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/ --- Review request for Plasma. Repository: libksysguard Description --- KLineEdit is deprecated in favor of QLineEdit and it makes ksysguard look more consistent with Breeze Diffs - processui/ProcessWidgetUI.ui 362bde9 Diff: https://git.reviewboard.kde.org/r/120515/diff/ Testing --- File Attachments Screenshot before/after https://git.reviewboard.kde.org/media/uploaded/files/2014/10/06/66d3ae48-77f4-422c-8cfe-de8ab25d7419__systemmonitor.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120515: Use QLineEdit rather than KLineEdit in libksysguard
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/#review68003 --- Ship it! Ship It! - Martin Gräßlin On Oct. 6, 2014, 5 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/ --- (Updated Oct. 6, 2014, 5 p.m.) Review request for Plasma. Repository: libksysguard Description --- KLineEdit is deprecated in favor of QLineEdit and it makes ksysguard look more consistent with Breeze Diffs - processui/ProcessWidgetUI.ui 362bde9 Diff: https://git.reviewboard.kde.org/r/120515/diff/ Testing --- File Attachments Screenshot before/after https://git.reviewboard.kde.org/media/uploaded/files/2014/10/06/66d3ae48-77f4-422c-8cfe-de8ab25d7419__systemmonitor.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68004 --- ping.. - Hrvoje Senjan On Sept. 30, 2014, 7:40 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Sept. 30, 2014, 7:40 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120515: Use QLineEdit rather than KLineEdit in libksysguard
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/ --- (Updated Oct. 6, 2014, 3:16 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: libksysguard Description --- KLineEdit is deprecated in favor of QLineEdit and it makes ksysguard look more consistent with Breeze Diffs - processui/ProcessWidgetUI.ui 362bde9 Diff: https://git.reviewboard.kde.org/r/120515/diff/ Testing --- File Attachments Screenshot before/after https://git.reviewboard.kde.org/media/uploaded/files/2014/10/06/66d3ae48-77f4-422c-8cfe-de8ab25d7419__systemmonitor.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68006 --- processui/ProcessModel.cpp https://git.reviewboard.kde.org/r/120441/#comment47399 you seem to be losing the precision here. processui/ProcessModel.cpp https://git.reviewboard.kde.org/r/120441/#comment47400 why change in the comment? - Martin Gräßlin On Sept. 30, 2014, 7:40 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Sept. 30, 2014, 7:40 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68007 --- Ship it! Looks good, couple remarks below processui/ProcessModel.cpp https://git.reviewboard.kde.org/r/120441/#comment47401 How is this sorted out instead? processui/ProcessModel.cpp https://git.reviewboard.kde.org/r/120441/#comment47402 Should it maybe share the KFormat() instance here rather than creating the same object 4 times? tests/processtest.cpp https://git.reviewboard.kde.org/r/120441/#comment47403 Seems like no i18n calls are actually being used, this can be removed (and possibly the CMake link too) - Martin Klapetek On Sept. 30, 2014, 7:40 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Sept. 30, 2014, 7:40 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Oct. 6, 2014, 5:21 p.m., Martin Gräßlin wrote: processui/ProcessModel.cpp, line 568 https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line568 why change in the comment? someone might uncomment this without realizing there's no KDELibs4Support here anymore ;-) On Oct. 6, 2014, 5:21 p.m., Martin Gräßlin wrote: processui/ProcessModel.cpp, lines 91-106 https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line91 you seem to be losing the precision here. that's true, but i haven't found suitable replacement, will investigate further - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68006 --- On Sept. 30, 2014, 7:40 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Sept. 30, 2014, 7:40 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Oct. 6, 2014, 5:28 p.m., Martin Klapetek wrote: processui/ProcessModel.cpp, line 146 https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line146 How is this sorted out instead? should be substituted with add_definitions(-DTRANSLATION_DOMAIN=\processui\) afaik (and that is in place already) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68007 --- On Sept. 30, 2014, 7:40 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Sept. 30, 2014, 7:40 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Říj. 6, 2014, 5:21 odp., Martin Gräßlin wrote: processui/ProcessModel.cpp, lines 91-106 https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line91 you seem to be losing the precision here. Hrvoje Senjan wrote: that's true, but i haven't found suitable replacement, will investigate further Use KFormat::formatByteSize() from KCoreAddons - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68006 --- On Zář. 30, 2014, 7:40 odp., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Zář. 30, 2014, 7:40 odp.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Oct. 6, 2014, 6:29 p.m.) Review request for Plasma. Changes --- fix (hopefully ;-) raised issues Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs (updated) - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Oct. 6, 2014, 5:21 p.m., Martin Gräßlin wrote: processui/ProcessModel.cpp, line 568 https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line568 why change in the comment? Hrvoje Senjan wrote: someone might uncomment this without realizing there's no KDELibs4Support here anymore ;-) they will notice when the compilation fails ;-) (Personal opinion is to just remove the debug statement - what's the point of a commented out debug statement?) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68006 --- On Oct. 6, 2014, 6:29 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Oct. 6, 2014, 6:29 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120516: introduce bool applicationMode for standalone application mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- this can be used by shell package to know if it is opened in application mode or full shell Diffs - drkonqi/data/debuggers/internal/gdbrc d998c66 shell/desktopview.h 1b07261 shell/desktopview.cpp dcd002d shell/standaloneappcorona.cpp dd9b69b Diff: https://git.reviewboard.kde.org/r/120516/diff/ Testing --- tested with pmc Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120516: introduce bool applicationMode for standalone application mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/#review68014 --- I am not sure i like exposing a bool, may be the only way. fo sure the signal would have to go drkonqi/data/debuggers/internal/gdbrc https://git.reviewboard.kde.org/r/120516/#comment47410 this seems to be unrelated shell/desktopview.h https://git.reviewboard.kde.org/r/120516/#comment47409 it can be CONSTANT, the mode is not going to change - Marco Martin On Ott. 6, 2014, 5:37 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- (Updated Ott. 6, 2014, 5:37 p.m.) Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- this can be used by shell package to know if it is opened in application mode or full shell Diffs - drkonqi/data/debuggers/internal/gdbrc d998c66 shell/desktopview.h 1b07261 shell/desktopview.cpp dcd002d shell/standaloneappcorona.cpp dd9b69b Diff: https://git.reviewboard.kde.org/r/120516/diff/ Testing --- tested with pmc Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:41 p.m.) Review request for Plasma and Martin Gräßlin. Changes --- Fix issues Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs (updated) - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120516: introduce bool applicationMode for standalone application mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/#review68016 --- I would go for it, but I would flip the logic, instead of an applicationMode property, a fullSession one. - Marco Martin On Ott. 6, 2014, 5:37 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- (Updated Ott. 6, 2014, 5:37 p.m.) Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- this can be used by shell package to know if it is opened in application mode or full shell Diffs - drkonqi/data/debuggers/internal/gdbrc d998c66 shell/desktopview.h 1b07261 shell/desktopview.cpp dcd002d shell/standaloneappcorona.cpp dd9b69b Diff: https://git.reviewboard.kde.org/r/120516/diff/ Testing --- tested with pmc Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
El Dilluns, 6 d'octubre de 2014, a les 01:30:47, Aleix Pol va escriure: On Sun, Oct 5, 2014 at 8:30 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure: On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley bcooks...@kde.org wrote: Hi all, It seems there has been a recent outbreak of repository moves which have been extremely poorly co-ordinated by those doing the requests. In addition, it is actually a requirement that modules moving from Extragear into (what was at least) the SC need to re-transit through KDE Review.It is also considered proper practice to at least inform the translation, documentation and release teams in advance you intend to make these moves - something which has also been neglected. For all further repository structure moves - please ensure you have received the appropriate consent from the above mentioned teams, and have announced them on the appropriate mailing lists in advance. @Plasma team: plasma-devel@kde.org does not constitute an appropriate mailing list, as it is not a community wide development mailing list. Only kde-devel and kde-core-devel qualify for this. Thanks, Ben Cooksley KDE Sysadmin My apologies, I shouldn't have rushed into doing such moves and send e-mails to all the interested parties. If someone considers it appropriate, I can roll some of the changes back. Maybe you should explain the changes so people is aware of them :) Cheers, Albert Aleix Changes: - kde-gtk-config was moved from extragear/base to kde/workspace. - muon was moved from extragear/sysadmin to kde/workspace. That is, only projects.kde.org structure change. That's a total understament, it changes them from being something extra to be something totally core. So it's not only at all. The reasoning is that this way they will be released together with Plasma Workspace. I don't see that anyone can have a problem with kde-gtk-config. The muon move i see as much less clear, there are other installers provided by KDE (kpackagekit comes to mind) and muon is not widely used (AFAIK) outside KUbuntu, thus putting all the weight of making it a core thing is something I think we should not be doing without a bigger discussion with the community, and not just in Plasma. I don't expect to compete with Apper. Muon Discover is a software center and that's the main solution I'm pushing here, as I explained in Plasma. Apper is a package manager. That is, a way where we can display to our end-users what software there's available and also lets us a couple of tricks to get biased. I think this is very important, because it opens an opportunity to offer the end-user the full KDE experience we've been talking about. So far, the way everyone had to expose software was by creating a (usually spin-off) distribution where there was tons of software pre-installed. By providing a software center we open channels to communicate with the user where he can leverage on previous' users experience, as well as our own. I'm not sure I understand the difference between a Software Center and a Package Manager, can you elaborate what is the difference? Cheers, Albert ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review68018 --- Ship it! Ship It! - Martin Gräßlin On Oct. 6, 2014, 7:41 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:41 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
2014-10-06 19:57 GMT+02:00 Albert Astals Cid aa...@kde.org: El Dilluns, 6 d'octubre de 2014, a les 01:30:47, Aleix Pol va escriure: [...] I don't expect to compete with Apper. Muon Discover is a software center and that's the main solution I'm pushing here, as I explained in Plasma. Apper is a package manager. That is, a way where we can display to our end-users what software there's available and also lets us a couple of tricks to get biased. I (as Apper contributor) would disagree with that - Daniel renamed KPackageKit to Apper years ago to stress that Apper is not about packages, but especially about applications. Unlike Muon or GNOME Software, the goal for Apper is to manage packages and apps in one UI though - and of course, Apper provides the session interface for PackageKit, which Muon does not (yet?). Does Muon work well with PackageKit on !Debian-based distros? I had lots of trouble with porting the Ubuntu Software Center to PK, since PK uses a completely different paradigm and API, compared to the Aptdaemon interface the USC used, so it would have required a complete rewrite. Last time I looked at QApt, it looked slightly more similar to Aptd compared to the PK API. (I'll soon test Muon on Fedora by myself, but more from an what can be improved in AppStream? PoV) I think this is very important, because it opens an opportunity to offer the end-user the full KDE experience we've been talking about. So far, the way everyone had to expose software was by creating a (usually spin-off) distribution where there was tons of software pre-installed. By providing a software center we open channels to communicate with the user where he can leverage on previous' users experience, as well as our own. I'm not sure I understand the difference between a Software Center and a Package Manager, can you elaborate what is the difference? Software Center almost always means that it shows GUI apps instead of packages, where app is more tightly defined as stuff which ship a .desktop file in share/applictions with Type=application. Package Managers display all kinds of packages on the system, including debug symbol packages and e.g. header packages. The Software Centers are generally thought to be more end-user friendly, while package managers have a technically advanced user as target audience. Cheers, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
El Diumenge, 5 d'octubre de 2014, a les 20:30:33, Albert Astals Cid va escriure: El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: Changes: - kde-gtk-config was moved from extragear/base to kde/workspace. - muon was moved from extragear/sysadmin to kde/workspace. I'm confused muon has been moved to kde/workspace that is home of all KF5- based workspace apps but it's master is still based in kdelibs4? Why is that? Cheers, Albert ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68025 --- Minor issues and +1 to Martin G's note about commented out debugs...imo they should just go signalplotter/ksignalplotter.cpp https://git.reviewboard.kde.org/r/120441/#comment47415 This should probably be qCDebug to keep the category tests/CMakeLists.txt https://git.reviewboard.kde.org/r/120441/#comment47416 Is the I18n still needed here in the tests linkage? I see only the signalplottertest.cpp using i18n (and even that usage could possibly be removed but meh, it's just tests) - Martin Klapetek On Oct. 6, 2014, 6:29 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Oct. 6, 2014, 6:29 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Říj. 7, 2014, 12:23 dop., Martin Klapetek wrote: tests/CMakeLists.txt, line 7 https://git.reviewboard.kde.org/r/120441/diff/3/?file=316814#file316814line7 Is the I18n still needed here in the tests linkage? I see only the signalplottertest.cpp using i18n (and even that usage could possibly be removed but meh, it's just tests) Tests shouldn't contain i18n() - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68025 --- On Říj. 6, 2014, 6:29 odp., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Říj. 6, 2014, 6:29 odp.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
On Oct. 6, 2014, 10:25 a.m., Martin Gräßlin wrote: src/client/registry.h, line 407 https://git.reviewboard.kde.org/r/120471/diff/1/?file=316079#file316079line407 I would recommend to move it to ConnectionThread as it's more connection related then registry related. Also please add a test case for it (both threaded and unthreaded) - should be fairly simple in fact. I've experimented with that, and ran into a few issues. We need to call wl_display_get_registry(display); wl_display_sync(display); in this order, that's what the Wayland API suggests. I've tried moving the whole callback mechanism into ConnectionThread, but ConnectionThread doesn't know enough about the Registry to issue the wl_display_sync right after wl_display_get_registry. Essentially, sync really is a global sync, and comes from the registry, rather than the ConnectionThread. Semantically, it does make more sense in ConnectionThread, along with connected() and failed() etc.. So I've tried keeping the mechanism in Registry, but emitting ConnectionThread's signal, if a connectionthread has been set on the registry. This also doesn't work very well, as in the tests (as an example), one doesn't get a sync signal unless one sets up the Registry. ConnectionThread isn't what triggers the wl_display_sync callback, it's set up in the registry. So what the wl_display_sync callback really does, is I'm done announcing interfaces, it is in fact more related to Registry, and not to ConnectionThread. In that regard, the current patch may be the best option, perhaps giving sync() a clearer name, and reflecting it better in the API docs? Other solutions altogether? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review67980 --- On Oct. 3, 2014, 3:15 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 3, 2014, 3:15 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs - src/client/registry.h 9e63a2b20c9734cc599f8c612441165b20d361bd src/client/registry.cpp 22f948488b88f2a9fbf2fd78f0d223d05585fe17 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 1:37 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Changes --- Add tests for Registry::sync signal This tests two scenarios: - Simply setting a Registry from wl_display, then initializing it, so it emits sync - Using ConnectionThread, EventQueue, and all that in a different QThread. The latter test currently fails due to SocketNotifier apparently not being thread-safe. This also fails in other tests, and it works as soon as I comment thread-moveToThread(ConnectionThread), it is unrelated. Note that in libkscreen, I don't have that issue so far, so it also works in the threaded scenario, in principle. Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs (updated) - autotests/client/test_wayland_connection_thread.cpp a1ef989 src/client/registry.h 9e63a2b src/client/registry.cpp 22f9484 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 1:56 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Changes --- * Clean up the thread properly, this makes also the threaded globalSync tests pass. * Move test to test_wayland_registry.cpp, where it belongs (it tests Registry, not ConnectionThread) Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs (updated) - autotests/client/test_wayland_registry.cpp 571be0f src/client/registry.h 9e63a2b src/client/registry.cpp 22f9484 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120516: introduce bool applicationMode for standalone application mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- (Updated Oct. 7, 2014, 9:54 a.m.) Review request for Plasma and Marco Martin. Changes --- Fix issue and rename property to fullSession instead of applicationMode Repository: plasma-workspace Description --- this can be used by shell package to know if it is opened in application mode or full shell Diffs (updated) - shell/desktopview.h 1b07261 shell/desktopview.cpp dcd002d shell/standaloneappcorona.cpp dd9b69b Diff: https://git.reviewboard.kde.org/r/120516/diff/ Testing --- tested with pmc Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
On Oct. 6, 2014, 12:25 p.m., Martin Gräßlin wrote: src/client/registry.h, line 407 https://git.reviewboard.kde.org/r/120471/diff/1/?file=316079#file316079line407 I would recommend to move it to ConnectionThread as it's more connection related then registry related. Also please add a test case for it (both threaded and unthreaded) - should be fairly simple in fact. Sebastian Kügler wrote: I've experimented with that, and ran into a few issues. We need to call wl_display_get_registry(display); wl_display_sync(display); in this order, that's what the Wayland API suggests. I've tried moving the whole callback mechanism into ConnectionThread, but ConnectionThread doesn't know enough about the Registry to issue the wl_display_sync right after wl_display_get_registry. Essentially, sync really is a global sync, and comes from the registry, rather than the ConnectionThread. Semantically, it does make more sense in ConnectionThread, along with connected() and failed() etc.. So I've tried keeping the mechanism in Registry, but emitting ConnectionThread's signal, if a connectionthread has been set on the registry. This also doesn't work very well, as in the tests (as an example), one doesn't get a sync signal unless one sets up the Registry. ConnectionThread isn't what triggers the wl_display_sync callback, it's set up in the registry. So what the wl_display_sync callback really does, is I'm done announcing interfaces, it is in fact more related to Registry, and not to ConnectionThread. In that regard, the current patch may be the best option, perhaps giving sync() a clearer name, and reflecting it better in the API docs? Other solutions altogether? Thanks for looking into it. So yeah let's rename it to make more clear what the signal is about, in my book it can be very verbose kind of interfacesAnnounced - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review67980 --- On Oct. 7, 2014, 3:56 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 3:56 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs - autotests/client/test_wayland_registry.cpp 571be0f src/client/registry.h 9e63a2b src/client/registry.cpp 22f9484 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review68034 --- src/client/registry.cpp https://git.reviewboard.kde.org/r/120471/#comment47424 please also set the callback to nullptr after destroying general comment: you are not destroying the callback if the Registry gets destroyed before the callback is received. Also in the destroy handling (server died) it's not handled, yet. - Martin Gräßlin On Oct. 7, 2014, 3:56 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 3:56 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs - autotests/client/test_wayland_registry.cpp 571be0f src/client/registry.h 9e63a2b src/client/registry.cpp 22f9484 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
