Re: Review Request 120516: introduce bool applicationMode for standalone application mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/#review68039 --- shell/desktopview.h https://git.reviewboard.kde.org/r/120516/#comment47425 don't put a NOTIFY, just a CONSTANT without signal shell/desktopview.h https://git.reviewboard.kde.org/r/120516/#comment47426 even the setter and the internal variable is not necessary, you can just check if m_corona is a shellcorona or not - Marco Martin On Ott. 7, 2014, 4:24 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- (Updated Ott. 7, 2014, 4:24 a.m.) Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- this can be used by shell package to know if it is opened in application mode or full shell Diffs - shell/desktopview.h 1b07261 shell/desktopview.cpp dcd002d shell/standaloneappcorona.cpp dd9b69b Diff: https://git.reviewboard.kde.org/r/120516/diff/ Testing --- tested with pmc Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120516: introduce bool applicationMode for standalone application mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- (Updated Oct. 7, 2014, 2:02 p.m.) Review request for Plasma and Marco Martin. Changes --- Fix issues Repository: plasma-workspace Description --- this can be used by shell package to know if it is opened in application mode or full shell Diffs (updated) - shell/desktopview.h 1b07261 shell/desktopview.cpp dcd002d Diff: https://git.reviewboard.kde.org/r/120516/diff/ Testing --- tested with pmc Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120471: Add Registry::sync() signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 9:12 a.m.) Review request for kwin, Plasma and Martin Gräßlin. Changes --- Don't leak wl_callback * Properly clean up the sync callback when registry is released or destroyed * Rename signal from Registry::sync() to interfacesAnnounced() Repository: kwayland Description --- Add Registry::sync() signal Emitted when the Wayland display is done flushing the initial interface callbacks, announcing wl_display properties. This can be used to compress events. Note that this signal is emitted only after announcing interfaces, such as outputs, but not after receiving callbacks of interface properties, such as the output's geometry, modes, etc.. This signal is emitted from the wl_display_sync callback. For this, we add a wl_callback_listener to the registry's Private, enqueue its events properly, if necessary, and trigger the signal through a callback mechanism similar to the wl_registry callbacks. This signal allows users of the API to find out when the signal emissions, such as outputAnnounced, etc. for all currently existing interfaces is complete. Diffs (updated) - autotests/client/test_wayland_registry.cpp 571be0f src/client/registry.h 9e63a2b src/client/registry.cpp 22f9484 Diff: https://git.reviewboard.kde.org/r/120471/diff/ Testing --- tests in libkscreen exercise this feature, it works as expected, meaning I can notify when all initial synchronization is done. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: plasma-desktop_master_qt5 #685
See http://build.kde.org/job/plasma-desktop_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
On Mon, Oct 6, 2014 at 11:37 PM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 5 d'octubre de 2014, a les 20:30:33, Albert Astals Cid va escriure: El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: Changes: - kde-gtk-config was moved from extragear/base to kde/workspace. - muon was moved from extragear/sysadmin to kde/workspace. I'm confused muon has been moved to kde/workspace that is home of all KF5- based workspace apps but it's master is still based in kdelibs4? Why is that? I was waiting for Kubuntu to freeze, in case they needed a last new KDE4 version. That's in the past anyway, so I went forward and merged frameworks to master. Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120038: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120038/#review68049 --- Ship it! Ship It! - Sebastian Kügler On Sept. 2, 2014, 5:56 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120038/ --- (Updated Sept. 2, 2014, 5:56 p.m.) Review request for Plasma. Repository: plasmate Description --- This is the second part of the review 'Port plasmate to KDevPlatform's shell'. This review contains various removes from plasmate's source code. The removed code is either depracated due to the port to KDevPlatform or it hasn't been used by anyone AFAIK since 2011. Also this review changes the directory structure of plasmate's repository. This change makes sense with the new plugins that will be added and it reflects the KDevelop's one. So the new directory structure is something like plasmate -plasmate --app (this is the place from which the plasmate binary will be created) --plugins (It's not there yet because we don't have any yet :) -plasmoidviewer -engineexplorer Here is the list of commits for this review Commits: The big cleanup. Most of those stuff are deprecated due to the port to KDevPlatform and the rest of them are leftover from years ago Change the directory structure of plasmate/plasmate * move all the Startpage related files to plasmate/plasmate/app/startpage * move the Startpage related tests to plasmate/plasmate/app/tests * move ProjectManager::exportProject to Publisher::exportProject. the ProjectManager wasn't making any use of it and by moving the method, the Publisher doesn't depend anymore to the ProjectManager - Cleanup the packagehandler, plasmoidhandler and themehandler We will use KDevelop::PackageModel which is a QAIM with its own info so we don't need our nodes. What we need is a a way (PackageModel::description) which will associate for example the filename main.qml to Mainscript. Diffs - plasmate/tests/modeltest.cpp d356b26 plasmate/tests/packagemodeltest.h 806d8f1 plasmate/tests/packagemodeltest.cpp 27907d6 plasmate/tests/plasmoidhandlertest.h e888c53 plasmate/tests/plasmoidhandlertest.cpp a6abc98 plasmate/tests/projecthandlertest.h 8f6b903 plasmate/tests/projecthandlertest.cpp afeca9c plasmate/sidebartablewidget.cpp c9980e1 plasmate/startpage.h a81176c plasmate/startpage.cpp ab94392 plasmate/startpage.ui plasmate/test-kpart/CMakeLists.txt 761afcd plasmate/test-kpart/kparttut1ui.rc a76749e plasmate/test-kpart/main.cpp 9d67674 plasmate/test-kpart/mainwindow.h ea517b3 plasmate/test-kpart/mainwindow.cpp a18a66a plasmate/tests/CMakeLists.txt 1b5632a plasmate/tests/modeltest.h 45c68f4 plasmate/sidebardelegate.cpp 07992ac plasmate/sidebaritem.cpp 40ffc99 plasmate/sidebartablewidget.h 73856e7 plasmate/projectmanager/projectmanager.cpp d691b44 plasmate/publisher/publisher.h 1faa149 plasmate/publisher/publisher.cpp 52173a9 plasmate/sidebar.h 08f26eb plasmate/sidebar.cpp 7b7aff1 plasmate/sidebardelegate.h 09fc506 plasmate/projecthandler.cpp plasmate/projectmanager/projectmanager.h 7a0f875 plasmate/plasmate.desktop plasmate/plasmate.knsrc plasmate/projecthandler.h plasmate/packagemodel.h 2ac1cb2 plasmate/packagemodel.cpp 93f158a plasmate/packagehandler/packagehandler.h 7dbc3bb plasmate/packagehandler/packagehandler.cpp ead1f37 plasmate/packagehandler/plasmoidhandler.h 11ca4ae plasmate/packagehandler/plasmoidhandler.cpp 60009c9 plasmate/packagehandler/themehandler.h 6c95d83 plasmate/packagehandler/themehandler.cpp 4d88361 plasmate/editors/svg/tests/battery-oxygen-inkscape.svgz ce87277 plasmate/editors/svg/tests/battery-oxygen.svgz ce87277 plasmate/editors/svg/tests/test_svg.cpp bc725ab plasmate/editors/text/texteditor.h 4ab8eed plasmate/editors/text/texteditor.cpp 2e346ca plasmate/mainwindow.h a609750 plasmate/mainwindow.cpp c7c95a9 plasmate/modeltest/dynamictreemodel.h 6fbd02a plasmate/modeltest/dynamictreemodel.cpp 2428ebe plasmate/modeltest/modeltest.h a5a6777 plasmate/modeltest/modeltest.cpp a5f1fe1 plasmate/editors/svg/tests/background.svg ca130f2 plasmate/editors/svg/tests/background.svgz f9e4b1d plasmate/editors/editpage.h 98a09ca plasmate/editors/editpage.cpp f21ec25 plasmate/editors/metadata/metadataeditor.cpp c07fafd plasmate/editors/svg/CMakeLists.txt 0214310 plasmate/editors/svg/svgviewer.h 01d4856
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: The reasoning is that this way they will be released together with Plasma Workspace. I don't see that anyone can have a problem with kde-gtk-config. Risking that someone might kill me for saying this: Given that this configures how GTK applications work inside Plasma and not inside the KDE community, shouldn't it be renamed to plasma-gtk-config so we don't add to the branding confusion with our own package names? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
KDE can still be used to mean by the KDE community. This kcm could be legitimately used from Xfce/lxde. So I think its OK. On 7 Oct 2014 15:13, Thomas Pfeiffer thomas.pfeif...@kde.org wrote: On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: The reasoning is that this way they will be released together with Plasma Workspace. I don't see that anyone can have a problem with kde-gtk-config. Risking that someone might kill me for saying this: Given that this configures how GTK applications work inside Plasma and not inside the KDE community, shouldn't it be renamed to plasma-gtk-config so we don't add to the branding confusion with our own package names? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure
On Tuesday 07 October 2014 15:28:21 David Edmundson wrote: KDE can still be used to mean by the KDE community. This kcm could be legitimately used from Xfce/lxde. So I think its OK. Wait, wasn't the argument for releasing it with Plasma that we think it doesn't make much sense outside Plasma? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #958
See http://build.kde.org/job/plasma-workspace_master_qt5/958/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: plasma-desktop_master_qt5 #686
See http://build.kde.org/job/plasma-desktop_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Oct. 7, 2014, 5:36 p.m.) Review request for Plasma. Changes --- fixed issues, except categorized logging - will open a separate review for that one Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs (updated) - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/ksysguarddtest.cpp cd0c8bd tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : plasma-workspace_master_qt5 #959
See http://build.kde.org/job/plasma-workspace_master_qt5/959/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68053 --- Ship it! Ship It! - Martin Klapetek On Oct. 7, 2014, 5:36 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Oct. 7, 2014, 5:36 p.m.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/ksysguarddtest.cpp cd0c8bd tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Dark themes
Thanks much for the feedback Eike and David. :-) With no noted objections and several thumbs up from our translators, I'll commit the Breeze Dark icon theme to the Plasma/5.1 branch of the breeze repo later this evening. Thanks much, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: plasma-desktop_master_qt5 #687
See http://build.kde.org/job/plasma-desktop_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120524: Let Search Folder Updater's name match by X-KDE-DBus-ModuleName and desktop file name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120524/ --- Review request for Plasma and Vishesh Handa. Repository: baloo Description --- no idea why the X-KDE-DBus-ModuleName was different at all.. Diffs - src/kioslaves/kded/baloosearchfolderupdater.desktop eda7f2f Diff: https://git.reviewboard.kde.org/r/120524/diff/ Testing --- i can see the kded module marked as running in kcm_kded Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120526/ --- Review request for Plasma, Solid, Àlex Fiestas, and Lukáš Tinkl. Repository: powerdevil Description --- there's still some usage left in the kcm subdir, i'll look into that one also soon. also, will open a review to convert to qCDebug Diffs - daemon/backends/upower/powerdevilupowerbackend.cpp f0fb73c daemon/backends/upower/upowersuspendjob.cpp 933de17 daemon/kdedpowerdevil.cpp 5d6b91c daemon/powerdevilaction.cpp f16394c daemon/powerdevilactionpool.h 93ade44 daemon/powerdevilactionpool.cpp 970aa18 daemon/powerdevilbackendinterface.h abf7618 daemon/powerdevilbackendinterface.cpp f157a73 daemon/powerdevilbackendloader.cpp 8259a13 daemon/powerdevilcore.h 36f4004 daemon/powerdevilcore.cpp b178cdf daemon/powerdevilkeyboardbrightnesslogic.cpp 7709fda daemon/powerdevilpolicyagent.h 41e8e6b daemon/powerdevilpolicyagent.cpp d217e92 daemon/powerdevilprofilegenerator.cpp 67ef77c daemon/powerdevilscreenbrightnesslogic.cpp 8da7dff kcmodule/common/CMakeLists.txt 9319067 kcmodule/common/ErrorOverlay.h a2249c0 kcmodule/common/ErrorOverlay.cpp adad48f kcmodule/common/actioneditwidget.h e73fb44 kcmodule/common/actioneditwidget.cpp d6c5e6c kcmodule/global/CMakeLists.txt 77bbd07 kcmodule/global/GeneralPage.cpp cdad263 kcmodule/profiles/CMakeLists.txt 1a13bb3 daemon/BackendConfig.cmake 54094e0 daemon/CMakeLists.txt 544cffe daemon/actions/bundled/brightnesscontrol.cpp 34dc578 daemon/actions/bundled/dimdisplay.cpp fc26585 daemon/actions/bundled/handlebuttonevents.cpp 6072507 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 7b1dfdc daemon/actions/bundled/suspendsession.cpp 6704134 daemon/backends/hal/powerdevilhalbackend.h b282634 daemon/backends/hal/powerdevilhalbackend.cpp 69e8ce0 daemon/backends/upower/login1suspendjob.cpp ce63c2e daemon/backends/upower/powerdevilupowerbackend.h beb12aa Diff: https://git.reviewboard.kde.org/r/120526/diff/ Testing --- builds, kded is succesfully initialized, reducing/increasing brightness work Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
