[Breeze] [Bug 339849] Can't set breeze dark color scheme
https://bugs.kde.org/show_bug.cgi?id=339849 --- Comment #3 from Andrew Lake jamboar...@gmail.com --- I changed the filename as suggested and made the commit. I don't have permissions to close this bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339849] Can't set breeze dark color scheme
https://bugs.kde.org/show_bug.cgi?id=339849 Bhushan Shah bhus...@gmail.com changed: What|Removed |Added Latest Commit||http://commits.kde.org/bree ||ze/04031cec8bd9ddab3f5e0d7d ||245a17e27b45d30a CC||bhus...@gmail.com Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #4 from Bhushan Shah bhus...@gmail.com --- I think someone should give you rights for that.. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- It appears the effect used to show an empty star is to desaturate the rating (star) icon. The effect makes sense for hi color icon themes like oxygen. However, monochrome or greyscale icons are by definition desaturated so the effect doesn't result in any visible difference. We could add color to the rating icon in the Breeze icon theme but that would break the style guidelines for the icon theme, and might fairly be considered a band-aid for the ineffectiveness of the desaturation effect to correctly produce the desired empty star for monochrome and greyscale rating icons. One solution to the underlying problem might be to decrease the opacity as well. I'll confirm that this a problem, but I think the underlying problem is in the components where ratings are displayed. I'm not entirely sure which components those are. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Breeze] [Bug 339863] full and empty stars are indistinguishable
Quoting jpwhiting, jpwhiting heh kratingpainter takes the rating icon from the theme and changes the image pixels to grayscale manually... jpwhiting strange jpwhiting works I guess, though I would think two opposite icons would be better for accessibility jpwhiting so if gray is the foreground color as it seems in that bug On Sat, Oct 11, 2014 at 12:23 PM, Andrew Lake jamboar...@gmail.com wrote: https://bugs.kde.org/show_bug.cgi?id=339863 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- It appears the effect used to show an empty star is to desaturate the rating (star) icon. The effect makes sense for hi color icon themes like oxygen. However, monochrome or greyscale icons are by definition desaturated so the effect doesn't result in any visible difference. We could add color to the rating icon in the Breeze icon theme but that would break the style guidelines for the icon theme, and might fairly be considered a band-aid for the ineffectiveness of the desaturation effect to correctly produce the desired empty star for monochrome and greyscale rating icons. One solution to the underlying problem might be to decrease the opacity as well. I'll confirm that this a problem, but I think the underlying problem is in the components where ratings are displayed. I'm not entirely sure which components those are. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 --- Comment #2 from Bhushan Shah bhus...@gmail.com --- Quoting jpwhiting, jpwhiting heh kratingpainter takes the rating icon from the theme and changes the image pixels to grayscale manually... jpwhiting strange jpwhiting works I guess, though I would think two opposite icons would be better for accessibility jpwhiting so if gray is the foreground color as it seems in that bug On Sat, Oct 11, 2014 at 12:23 PM, Andrew Lake jamboar...@gmail.com wrote: https://bugs.kde.org/show_bug.cgi?id=339863 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- It appears the effect used to show an empty star is to desaturate the rating (star) icon. The effect makes sense for hi color icon themes like oxygen. However, monochrome or greyscale icons are by definition desaturated so the effect doesn't result in any visible difference. We could add color to the rating icon in the Breeze icon theme but that would break the style guidelines for the icon theme, and might fairly be considered a band-aid for the ineffectiveness of the desaturation effect to correctly produce the desired empty star for monochrome and greyscale rating icons. One solution to the underlying problem might be to decrease the opacity as well. I'll confirm that this a problem, but I think the underlying problem is in the components where ratings are displayed. I'm not entirely sure which components those are. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 --- Comment #3 from Andrew Lake jamboar...@gmail.com --- Thanks much Bhushan. One option would be to provide a new icon for the non-filled state. The downside is that, except for breeze, no existing icon themes would have this new icon. So I think it might be better to fix the underlying problem in KRatingPainter. My suggestion then is that the product for this bug be changed to frameworks-kwidgetaddons since, as described, the greyscale conversion alone won't produce a difference with any monochrome or greyscale icon sets. Unfortunately, I don't currently have bugzilla permissions to do this. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 Bhushan Shah bhus...@gmail.com changed: What|Removed |Added Product|Breeze |frameworks-kwidgetsaddons Component|general |general CC||bhus...@gmail.com, ||kdelibs-b...@kde.org -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 --- Comment #4 from Antonio Rojas nqn1...@gmail.com --- It should also be fixed in KDE4 then, affected applications are still not ported to KF5 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
DialogNativeTest::position() breakage
Can a plasma developer look into this? http://build.kde.org/job/plasma-framework_master_qt5/830/Variation=All,label=LINBUILDER/testReport/(root)/TestSuite/dialognativetest/ Broken for one week now. FAIL! : DialogNativeTest::position() Compared values are not the same Actual (m_dialog-x()): 71 Expected (73) : 73 Loc: [/srv/jenkins/workspace/plasma-framework_master_qt5/Variation/All/label/LINBUILDER/autotests/dialognativetest.cpp(69)] -- Forwarded Message -- Subject: Jenkins build is still unstable: plasma-framework_master_qt5 ยป All,LINBUILDER #830 Date: Friday 10 October 2014, 16:21:11 From: KDE CI System n...@kde.org To: kde-frameworks-de...@kde.org See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list kde-frameworks-de...@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel - -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable
https://bugs.kde.org/show_bug.cgi?id=339863 Christoph Feck christ...@maxiom.de changed: What|Removed |Added Assignee|plasma-devel@kde.org|christ...@maxiom.de --- Comment #5 from Christoph Feck christ...@maxiom.de --- Please change assignee when moving bugs. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.1 beta tars
On 09/27/2014 02:13 AM, Michael Palimaka wrote: On 09/26/2014 08:28 AM, Jonathan Riddell wrote: New in this release.. - standard version number 5.0.95 for all Does this mean the stuff in extragear is moving to workspace? Any more thoughts about this? Are libkscreen, libmm-qt, libnm-qt now considered to be part of Plasma 5 proper - or are they still just extra software that happens to be released at the same time (and now with the same version number)? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: DialogNativeTest::position() breakage
On Saturday 11 October 2014 12:41:43 David Faure wrote: Can a plasma developer look into this? http://build.kde.org/job/plasma-framework_master_qt5/830/Variation=All,label =LINBUILDER/testReport/(root)/TestSuite/dialognativetest/ Broken for one week now. FAIL! : DialogNativeTest::position() Compared values are not the same Actual (m_dialog-x()): 71 Expected (73) : 73 Loc: [/srv/jenkins/workspace/plasma-framework_master_qt5/Variation/All/label/LIN BUILDER/autotests/dialognativetest.cpp(69)] actually, 71 is the correct value. i did a bisect, and i seen that before 419b344b6 (when the test broke) the dialog size was actually wrong, leading to a different position. i added a test on the size as well to make sure this doesn't happen again -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Sat, Oct 11, 2014 at 8:10 PM, David Faure fa...@kde.org wrote: On Friday 10 October 2014 16:24:52 David Edmundson wrote: Packagers, It seems Plasma 5.0 does NOT run smoothly against Plasma Framework 5.3. It would be easiest if distros hold off shipping frameworks 5.3 until Plasma 5.1 when Plasma5.1 is released. Clearly this is a screw-up and we need to come up with some better policies when we plan Plasma 5.2 Sorry about this. Verbose++ ? What's the actual problem? This mail is as informative as a bug report that says it doesn't work !!! :-) It doesn't work!!! was pretty much all I have. A G+ post [1] and a flurry of incoming people on IRC complaining of a black screen on login. Why it was broken didn't really matter as I just wanted to stop distros rolling 5.3 into their stable repos ASAP. Apparently users get: Warning: corona package invalid Invalid home screen package I /believe/ it's a3932843386a29faa3c62bf2934a173a3781d56c [2] in plasma-framework that's causing the issue. There was a plasma package structure that was hardcoded, this was moved into a plugin in Plasma Workspaces 5.1. I'm currently rebuilding this combo of packages into a clean prefix so I can prove it is this. I'll report back when I've confirmed this and then we can work out how we proceed. David [1] https://plus.google.com/u/0/+PaulHinchbergerIII/posts/PCtMbdJAkag [2] https://gerrit.vesnicky.cesnet.cz/r/#/c/37/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
