Re: Baloo - Not Indexing everything by default
On Thu, Oct 16, 2014 at 2:15 PM, Martin Gräßlin mgraess...@kde.org wrote: On Thursday 16 October 2014 13:20:57 Vishesh Handa wrote: Hey guys While Baloo performs better than Nepomuk. It does have its share of problems - mostly large text files, and high IO usage. Additionally, users on linux often seem to have the craziest files. Currently, we do not index plain text files which do not have a `.txt` extension, because otherwise we land up indexing genome data and other strange files. (Actual bugs) the txt being genome data doesn't surprise me[1], but I find it sad that now txt is disabled by default (I use them quite a lot for blog posts). As genome data is really huge wouldn't it make sense to go rather for file size or abort the indexing if it's obvious random gibberish? Or skip it if it looks like csv or is mostly numbers? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Oct. 13, 2014, 2:02 p.m., Martin Klapetek wrote: dataengines/comic/comic_package_plugin.cpp, line 21 https://git.reviewboard.kde.org/r/120276/diff/3/?file=317968#file317968line21 I think this should just go into comic_package.cpp to follow all the other exports, then this file can be removed Andrei Amuraritei wrote: This is exported in comicproviderkross.cpp because otherwise the engine doesn't detect the .comic packages. I get a plugin garfield could be created message when testing the engine with plasmaengineexplorer. This has nothing to do with with comicproviderkross.cpp, it should go to comic_package.cpp. Btw. this file is not even being built (it's nowhere in CMakeLists.txt), I guess it's added to the build system only because of the included moc file. Just move this one line at the bottom of comic_package.cpp. On Oct. 13, 2014, 2:02 p.m., Martin Klapetek wrote: dataengines/comic/CMakeLists.txt, lines 51-61 https://git.reviewboard.kde.org/r/120276/diff/3/?file=317961#file317961line51 These two could be merged into one Andrei Amuraritei wrote: Don't know if LINK_INTERFACE_LIBRARIES is really needed here so for commented out. Need some input from someone more knowledgeable about cmake building. My point was that you should be able to just write target_link_libraries( plasmacomicprovidercore KF5::WidgetsAddons KF5::KIOCore KF5::KrossCore KF5::KrossUi KF5::I18n KF5::KDELibs4Support LINK_INTERFACE_LIBRARIES KF5::KDELibs4Support ) ..instead of two separate calls. Also, if you commented it out and it still works, then it's probably useless here. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review68304 --- On Oct. 17, 2014, 2:08 a.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 2:08 a.m.) Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #741
See http://build.kde.org/job/plasma-desktop_master_qt5/741/changes Changes: [me] Add the Baloo File Search KCM [me] Add a basic doc file for the Baloo KCM [me] Baloo KCM: File Search instead of Desktop Search -- [...truncated 3781 lines...] http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/componentchooser/ui_componentchooser_ui.h:36:18: warning: ‘KListWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/klistwidget.h:41) [-Wdeprecated-declarations] KListWidget *ServiceChooser; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/componentchooser/ui_componentchooser_ui.h: In member function ‘void Ui_ComponentChooser_UI::setupUi(QWidget*)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/componentchooser/ui_componentchooser_ui.h:64:30: warning: ‘KListWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/klistwidget.h:41) [-Wdeprecated-declarations] ServiceChooser = new KListWidget(ComponentChooser_UI); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooserwm.cpp: In constructor ‘CfgWm::CfgWm(QWidget*)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooserwm.cpp:48:14: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] KGlobal::dirs()-addResourceType( windowmanagers, data, ksmserver/windowmanagers ); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooserwm.cpp:48:19: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] KGlobal::dirs()-addResourceType( windowmanagers, data, ksmserver/windowmanagers ); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooserwm.cpp: In member function ‘void CfgWm::loadWMs(const QString)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooserwm.cpp:229:33: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] QStringList list = KGlobal::dirs()-findAllResources( windowmanagers, QString(), KStandardDirs::NoDuplicates ); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooserwm.cpp:229:38: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] QStringList list = KGlobal::dirs()-findAllResources( windowmanagers, QString(), KStandardDirs::NoDuplicates ); ^ [ 77%] Generating ui_kcmtranslationswidget.h Scanning dependencies of target kcm_translations [ 77%] Building CXX object kcms/translations/CMakeFiles/kcm_translations.dir/kcmtranslations.cpp.o [ 77%] Built target testicons Scanning dependencies of target kcmspellchecking [ 77%] [ 77%] Building CXX object kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/spellchecking.cpp.o Building CXX object kcms/knotify/CMakeFiles/kcm_knotify.dir/kcm_knotify_automoc.cpp.o Linking CXX shared module kcm_kded.so In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/ktimerdialog.cpp:22:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/ktimerdialog.h:160:12: warning: ‘KHBox’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/khbox.h:40) [-Wdeprecated-declarations] KHBox *timerWidget; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/ktimerdialog.h:163:12: warning: ‘KVBox’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kvbox.h:36) [-Wdeprecated-declarations] KVBox *mainWidget; ^ [ 78%] http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/ktimerdialog.cpp: In constructor ‘KTimerDialog::KTimerDialog(int, KTimerDialog::TimerStyle, QWidget*, const QString, int, KDialog::ButtonCode, bool, const KGuiItem, const KGuiItem, const KGuiItem)’:
Build failed in Jenkins: plasma-desktop_master_qt5 #742
See http://build.kde.org/job/plasma-desktop_master_qt5/742/changes Changes: [me] Baloo KCM: Remove unnecessary translation domain removal -- [...truncated 3782 lines...] QStringList list = KGlobal::dirs()-findAllResources( windowmanagers, QString(), KStandardDirs::NoDuplicates ); ^ [ 76%] Building CXX object kcms/kded/CMakeFiles/kcm_kded.dir/kcm_kded_automoc.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/kded/kcmkded.cpp: In constructor ‘KDEDConfig::KDEDConfig(QWidget*, const QVariantList)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/kded/kcmkded.cpp:135:20: warning: ‘KDialogButtonBox’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kdialogbuttonbox.h:45) [-Wdeprecated-declarations] KDialogButtonBox *buttonBox = new KDialogButtonBox( gb, Qt::Horizontal); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/kded/kcmkded.cpp:135:36: warning: ‘KDialogButtonBox’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kdialogbuttonbox.h:45) [-Wdeprecated-declarations] KDialogButtonBox *buttonBox = new KDialogButtonBox( gb, Qt::Horizontal); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/knotify/knotify.cpp: In member function ‘virtual void KCMKNotify::load()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/knotify/knotify.cpp:160:18: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] KGlobal::dirs()-findAllResources(data, */*.notifyrc, KStandardDirs::NoDuplicates ); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/knotify/knotify.cpp:160:23: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] KGlobal::dirs()-findAllResources(data, */*.notifyrc, KStandardDirs::NoDuplicates ); ^ In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/componentchooser.h:19:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/kcm_componentchooser.h:21, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/componentchooser/kcm_componentchooser.cpp:16: http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/componentchooser/ui_componentchooser_ui.h:36:18: warning: ‘KListWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/klistwidget.h:41) [-Wdeprecated-declarations] KListWidget *ServiceChooser; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/componentchooser/ui_componentchooser_ui.h: In member function ‘void Ui_ComponentChooser_UI::setupUi(QWidget*)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/kcms/componentchooser/ui_componentchooser_ui.h:64:30: warning: ‘KListWidget’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/klistwidget.h:41) [-Wdeprecated-declarations] ServiceChooser = new KListWidget(ComponentChooser_UI); ^ [ 76%] Generating ui_kcmtranslationswidget.h [ 77%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/ktimerdialog.cpp.o Scanning dependencies of target kcm_translations [ 77%] Building CXX object kcms/translations/CMakeFiles/kcm_translations.dir/kcmtranslations.cpp.o [ 78%] Building CXX object kcms/translations/CMakeFiles/kcm_translations.dir/kcm_translations_automoc.cpp.o Linking CXX shared module kcm_icons.so Linking CXX shared module kcm_knotify.so [ 78%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/kcm_componentchooser_automoc.cpp.o Scanning dependencies of target kcmspellchecking [ 78%] Building CXX object kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/spellchecking.cpp.o [ 78%] Built target kcm_knotify [ 78%] [ 79%] Built target kcm_icons [ 79%] Generating ui_backendselection.h Building CXX object kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/kcmspellchecking_automoc.cpp.o [ 79%] Generating ui_devicepreference.h Linking CXX shared module kcm_kded.so Scanning dependencies of target kcm_phonon [ 79%] Building CXX object kcms/phonon/CMakeFiles/kcm_phonon.dir/main.cpp.o Linking CXX shared module kcm_formats.so [ 79%] Built target kcm_kded [ 79%] Building CXX
Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120623/#review68617 --- runners/locations/locationrunner.cpp https://git.reviewboard.kde.org/r/120623/#comment47801 and if we don't find the folder in the entries? we'll end up returning / and then trying to open it? - David Edmundson On Oct. 17, 2014, 3:32 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120623/ --- (Updated Oct. 17, 2014, 3:32 p.m.) Review request for Plasma. Bugs: 95 https://bugs.kde.org/show_bug.cgi?id=95 Repository: plasma-workspace Description --- See bug report Diffs - runners/locations/locationrunner.cpp 13035a9 Diff: https://git.reviewboard.kde.org/r/120623/diff/ Testing --- Bug fixed. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- Review request for Plasma. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one
On Oct. 17, 2014, 3:36 p.m., David Edmundson wrote: runners/locations/locationrunner.cpp, line 148 https://git.reviewboard.kde.org/r/120623/diff/1/?file=320194#file320194line148 and if we don't find the folder in the entries? we'll end up returning / and then trying to open it? No. The original path will be returned, and that will cause an error to be shown. - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120623/#review68617 --- On Oct. 17, 2014, 3:32 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120623/ --- (Updated Oct. 17, 2014, 3:32 p.m.) Review request for Plasma. Bugs: 95 https://bugs.kde.org/show_bug.cgi?id=95 Repository: plasma-workspace Description --- See bug report Diffs - runners/locations/locationrunner.cpp 13035a9 Diff: https://git.reviewboard.kde.org/r/120623/diff/ Testing --- Bug fixed. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Baloo - Not Indexing everything by default
On Fri, Oct 17, 2014 at 2:11 AM, Ömer Fadıl USTA omeru...@gmail.com wrote: Couldnt we add a .baloo file to specify for attributes for current directory, file or subdirectories about not indexing ? For example of a .baloo file skip_all skip_if_greater 1m skip_if_smaller 50k skip_ext txt jpg With --subdirs flag like Skip_ext --subdirs txt jpg Skip_all --subdirs This does seem like something I would want at some point. Except that instead of having a .baloo file. I would like us to use xattr of the folder. Maybe both? Anyway, this would still only be for advanced users. I've added a TODO about this to todo.kde.org. Hopefully, we can get a more advanced new comer to try and hack on this. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340063] New: Please make KDE fade to black before turning screen off
https://bugs.kde.org/show_bug.cgi?id=340063 Bug ID: 340063 Summary: Please make KDE fade to black before turning screen off Product: Powerdevil Version: 5.0.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: sb56...@gmail.com Hello, I sometimes am watching something on the screen or simply reading something for a long time without moving the mouse. I have my screen set to automatically turn off after a certain time. However, when that time is reached, it just abruptly turns the screen off. It would be a much nicer exeperience if it would fade to black and allow the user to interrupt the process before the screen turns off. For me this is actually such an important feature that it currently prevents me from using Plasma, although I would like to use it. Here are several related bugs, but not exactly the same, given that Plasma 5 is now out and there is no longer a screensaver mechanism. Bug #183119 Bug #86683 Thanks! Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Baloo - Not Indexing everything by default
On 17.10.2014 18:24, Vishesh Handa wrote: About gibberish. It's hard to figure out what gibberish is. I think I'll add some code that we only index the first 20 characters of each word. That should help to a certain extent. Define word - Chinese and Japanese (unless mostly kana) often don't have whitespace between words. -- Vishesh Handa Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? - Andrew Lake On Oct. 17, 2014, 3:47 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 17, 2014, 3:47 p.m.) Review request for Plasma. Repository: breeze Description --- add gtkbreeze, kconf_update tool to set gtk settings on first login this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits it does this for both gtk 2 and 3 it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3 I also could not get icons to show on buttons or in menus in gtk 3 Diffs - misc/CMakeLists.txt ff891a9 misc/gtkbreeze/CMakeLists.txt PRE-CREATION misc/gtkbreeze/gtkbreeze.upd PRE-CREATION misc/gtkbreeze/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120624/diff/ Testing --- run it and run gtk-demo and gtk3-demo Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Baloo - Not Indexing everything by default
Vishesh Handa wrote: ... Instead, we could only index - * $HOME - Not including any subfolders. * Desktop, Documents, Videos, Pictures and Music. All of these are xdg user directories. +1 Yes, please! -- Rex ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Baloo - Not Indexing everything by default
On Friday 17 October 2014 18:24:48 Vishesh Handa wrote: On Thu, Oct 16, 2014 at 2:15 PM, Martin Gräßlin mgraess...@kde.org wrote: the txt being genome data doesn't surprise me[1], but I find it sad that now txt is disabled by default (I use them quite a lot for blog posts). As genome data is really huge wouldn't it make sense to go rather for file size or abort the indexing if it's obvious random gibberish? We currently have a hard limit of 50mb on 'text/plain' files. However this does not include log files, which have a separate mimetype, Perhaps it would really be good to reduce it to about 5 mb. I think 5 MB could be a better limit. That's a huuuge text document. Someone with such a huge document is probably not needing baloo to get to it or the keywords will already be found in the first - what are that? 1000 pages? Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Baloo - Not Indexing everything by default
On Thu, Oct 16, 2014 at 1:20 PM, Vishesh Handa m...@vhanda.in wrote: Hey guys While Baloo performs better than Nepomuk. It does have its share of problems - mostly large text files, and high IO usage. Additionally, users on linux often seem to have the craziest files. Currently, we do not index plain text files which do not have a `.txt` extension, because otherwise we land up indexing genome data and other strange files. (Actual bugs) I've been thinking about actually disabling the file indexing by default. However, that might be too radical. Instead, we could only index - * $HOME - Not including any subfolders. * Desktop, Documents, Videos, Pictures and Music. All of these are xdg user directories. Gnome Tracker actually does something quite similar. Comments? Hi Vishesh, First of all, please don't even consider turning it off by default. Baloo might have some issues (can't really say for Plasma 5.x experience since im still on KDE 4.xx) but having a desktop search application is really worth a lot! It's just a difficult area to get right. Also, i don't think you should limit the indexer to the XDG folders. I personally have quite some data in $HOME specifically in sub folders. So it sounds like the indexer job needs to learn some new tricks then. Here's my idea on the top of my head that might work. 1. delay indexing file content that any application has open already. I don't know which C++/Qt function you can use for this, but the idea here is to not index the files/folders that you see when you type iostat. Store the list for later indexing. To still have some data there, just index the filenames. 2. What's left is everything _not_ currently in iostat which you could potentially index. Here you should filter out any file types that you don't have indexers for. 3. Now you're left with a list of files which could potentially be indexed. Here you should probably filter out those that are bigger then 5MB. 4. Everything that's left: index! 5. While indexing, periodically look at iostat to see if any process (other then the baloo processes) have new files.folders open. Like a compile job. If something like that is detected then you should probably follow step 1 again :) This would be a nice indexer, right? The only problem i see here is doing an iostat call in code. I have no clue if there is a posix c/c++ function for that. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
