[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=340137

Martin Gräßlin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Severity|normal  |wishlist
 Resolution|--- |WONTFIX

--- Comment #1 from Martin Gräßlin  ---
Please do not use breeze at this moment. The recommended window decoration is
Oxygen at the time being which supports Window Tabs (see
http://blog.martin-graesslin.com/blog/2014/07/why-breeze-is-not-the-default-window-decoration/).
The Aurorae version will never support window tabs, while the new KDecoration2
deco will support tabs. Thus this feature request is kind of a wontfix or
cantfix as the current version will never support it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120577/
---

(Updated Oct. 20, 2014, 7:59 a.m.)


Review request for Plasma and Aleix Pol Gonzalez.


Changes
---

Remove shutdown also from greeter app.


Bugs: 339453
https://bugs.kde.org/show_bug.cgi?id=339453


Repository: plasma-workspace


Description
---

Logging out from the locked screen is impossible. Logging out means
interaction with the session due to the session manager. The session
manager asks all applications to quit and applications are allowed to
ask for example saving changes. The session manager stopps the
logout in this case and asks the window manager to focus this window
and the session manager will only continue the logout once the
application resolved the situation. At any time in this process the
user is still able to abort the logout!

Switching to the application which needs interaction is impossible,
though as the screen is still locked. The result is a seemingly
frozen system as the logout cannot continue and there is no indication
what is going on.

Of course the lock screen cannot unlock the session for the logout as
that would circumvent the security. If the lock screen would unlock
one would just have to click the button and abort the logout really
fast to have the system unlocked. So this is clearly not an option.

The result is: we cannot implement this functionality in a working
and secure manner, so it's better to remove it.


Diffs (updated)
-

  ksmserver/screenlocker/greeter/greeterapp.cpp 
fd1d20b824dd7781cb5c2e96895694f290a46877 
  lookandfeel/contents/lockscreen/LockScreen.qml 
7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d 
  ksmserver/screenlocker/greeter/greeterapp.h 
f3033c701fb3c3ce5fa8f12f58ee8c6af739444b 

Diff: https://git.reviewboard.kde.org/r/120577/diff/


Testing
---

run kscreenlocker_greeter --testing and locked the screen - button is gone.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco

[rotter.martinos]

https://bugs.kde.org/show_bug.cgi?id=338979

rotter.marti...@gmail.com changed:

   What|Removed |Added

 CC||rotter.marti...@gmail.com

--- Comment #6 from rotter.marti...@gmail.com ---
This problem does not occur with Firefox.

Archlinux, breeze 5.1.0, plasma-desktop 5.1.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Andrew Lake]

> On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote:
> > Sorry if it's too much trouble, but would you be able to do a screenshot 
> > showing a gtk app with these settings alongside a KF5 app?
> 
> Jonathan Riddell wrote:
> http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png  GTK 2
> http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png  GTK 3 (the demo app 
> uses client side windows but the window border is still shown, I'm told this 
> bug is fixed in newer GTK)
> http://people.ubuntu.com/~jr/tmp/breeze-qt4.png  Qt 4
> 
> Martin Gräßlin wrote:
> for GTK 3 it's important that the style doesn't set a shadow because 
> that's causing the strange effect you have in the screenshot.

Just on the visual result, I think the proposal is quite reasonable. There's a 
QtCurve Breeze settings file available in the breeze repo that comes pretty 
close to matching the feel of the native Breeze style, but I'm not aware of a 
QtCurve implementation in GTK3 (is there?). So I'm fine with this solution to 
keeping GTK2/3 apps looking similar and not looking too out of place when 
running in Plasma.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68621
---


On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> ---
> 
> (Updated Oct. 19, 2014, 3:15 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to 
> oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 
> and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with 
> gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
> 
> 
> Diffs
> -
> 
>   misc/CMakeLists.txt ff891a9 
>   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
>   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
>   misc/gtkbreeze/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
> 
> 
> Testing
> ---
> 
> run it and run gtk-demo and gtk3-demo
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Fwd: Plasma Framework problems

[David Edmundson]

>Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it.

a3932843386a29faa3c62bf2934a173a3781d56c
​
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Fwd: Plasma Framework problems

[David Faure]

On Tuesday 14 October 2014 22:17:38 Marco Martin wrote:
> On Monday 13 October 2014, Marco Martin wrote:
> > > I need approval from Marco and other David.
> > 
> > after a quick chat with David E this morning, I would revert that patch
> > (and then remove the plugin in plasma-workspace master)
> > *but* this only if there will be a 5.3.1 (there should be a fix in
> > kwindowsystem as well as far i understood, so would be good a 5.3.1
> > release
> > with both fixes)
> 
> Updates on this? how to proceed? it would be released from the current
> master, 5.3 status plus one comit, or..?

Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it.

Sorry for the delay.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 340137] New: Implement support for window groups (window tabs) in Breeze

[Rodrigo Fernandes]

https://bugs.kde.org/show_bug.cgi?id=340137

Bug ID: 340137
   Summary: Implement support for window groups (window tabs) in
Breeze
   Product: Breeze
   Version: 5.1.0
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: rfernan...@gmx.com

Breeze is missing support for window groups.

Reproducible: Always

Steps to Reproduce:
1. Check "Window Behaviour -> Advanced -> Automatically group similar windows"
2. Open a second window to a program (Two Konsoles or two Dolphins, etc) 


Actual Results:  
The window appears seperatly as a normal window.

Expected Results:  
It should instead have appeared as a window tab, along side an the program's
existing window.


Additionally "middle click move to group does not work".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Martin Gräßlin]

> On Oct. 17, 2014, 7:59 p.m., Andrew Lake wrote:
> > Sorry if it's too much trouble, but would you be able to do a screenshot 
> > showing a gtk app with these settings alongside a KF5 app?
> 
> Jonathan Riddell wrote:
> http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png  GTK 2
> http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png  GTK 3 (the demo app 
> uses client side windows but the window border is still shown, I'm told this 
> bug is fixed in newer GTK)
> http://people.ubuntu.com/~jr/tmp/breeze-qt4.png  Qt 4

for GTK 3 it's important that the style doesn't set a shadow because that's 
causing the strange effect you have in the screenshot.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68621
---


On Oct. 19, 2014, 5:15 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> ---
> 
> (Updated Oct. 19, 2014, 5:15 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to 
> oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 
> and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with 
> gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
> 
> 
> Diffs
> -
> 
>   misc/CMakeLists.txt ff891a9 
>   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
>   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
>   misc/gtkbreeze/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
> 
> 
> Testing
> ---
> 
> run it and run gtk-demo and gtk3-demo
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68708
---



misc/gtkbreeze/main.cpp


mid-long term we probably want to split this out into a file that we copy

Otherwise this isn't really going to scale especially wrt GTK Config and 
changing themes later.



misc/gtkbreeze/main.cpp


do we even need the app? we're not using it.


- David Edmundson


On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> ---
> 
> (Updated Oct. 19, 2014, 3:15 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to 
> oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 
> and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with 
> gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
> 
> 
> Diffs
> -
> 
>   misc/CMakeLists.txt ff891a9 
>   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
>   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
>   misc/gtkbreeze/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
> 
> 
> Testing
> ---
> 
> run it and run gtk-demo and gtk3-demo
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Jonathan Riddell]

> On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote:
> > Sorry if it's too much trouble, but would you be able to do a screenshot 
> > showing a gtk app with these settings alongside a KF5 app?

http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png  GTK 2
http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png  GTK 3 (the demo app uses 
client side windows but the window border is still shown, I'm told this bug is 
fixed in newer GTK)
http://people.ubuntu.com/~jr/tmp/breeze-qt4.png  Qt 4


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68621
---


On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> ---
> 
> (Updated Oct. 19, 2014, 3:15 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to 
> oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 
> and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with 
> gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
> 
> 
> Diffs
> -
> 
>   misc/CMakeLists.txt ff891a9 
>   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
>   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
>   misc/gtkbreeze/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
> 
> 
> Testing
> ---
> 
> run it and run gtk-demo and gtk3-demo
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/
---

(Updated Oct. 19, 2014, 3:15 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

add gtkbreeze, kconf_update tool to set gtk settings on first login
this checks if gtk settings are already set, if they are not or are set to 
oxygen they update them, else it quits
it does this for both gtk 2 and 3
it sets gtk to the orion theme because it's available for both gtk 2 and 3 and 
it looks similar to breeze
it sets the icons to oxygen because I could not get breeze icons to work with 
gtk 2 or 3
I also could not get icons to show on buttons or in menus in gtk 3


Diffs
-

  misc/CMakeLists.txt ff891a9 
  misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
  misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
  misc/gtkbreeze/main.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120624/diff/


Testing
---

run it and run gtk-demo and gtk3-demo


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel