[Breeze] [Bug 340623] Breeze Widget style is very boxy and spacious. Takes too much space.

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=340623

Christoph Feck  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #3 from Christoph Feck  ---
*** Bug 340999 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121121: Remove all kdelibs4support from polkit-agent

[Lukáš Tinkl]

> On Lis. 14, 2014, 6:27 odp., Martin Klapetek wrote:
> > AuthDialog.cpp, lines 75-76
> > 
> >
> > Shouldn't this be one i18n("Details >>") to avoid string puzzles?
> > 
> > Would require another "Details <<" though, but that's necessary for RTL 
> > languages anyway (no?)
> 
> David Edmundson wrote:
> KDialog does it this way.
> 
> Martin Klapetek wrote:
> That doesn't make it correct.
> 
> 
> http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html#good_text

Include it in the string, I fancy RTL languages might want to put it on the 
left side


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121121/#review70376
---


On Lis. 14, 2014, 6:08 odp., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121121/
> ---
> 
> (Updated Lis. 14, 2014, 6:08 odp.)
> 
> 
> Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.
> 
> 
> Repository: polkit-kde-agent-1
> 
> 
> Description
> ---
> 
> Remove all kdelibs4support from polkit-agent
> 
> 
> Diffs
> -
> 
>   AuthDialog.h eaebbd2 
>   AuthDialog.cpp b76d91e 
>   AuthDialog.ui e4da0f9 
>   CMakeLists.txt 482fc57 
>   main.cpp f8f97b8 
>   policykitkde.h 85ce6b2 
>   policykitkde.cpp a25cb4f 
>   policykitlistener.h 538381f 
>   policykitlistener.cpp bab7fdf 
> 
> Diff: https://git.reviewboard.kde.org/r/121121/diff/
> 
> 
> Testing
> ---
> 
> Using pkexec tested using the correct password the wrong password viewing 
> details and tested trying to open two agents at once.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121121: Remove all kdelibs4support from polkit-agent

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121121/
---

(Updated Nov. 16, 2014, 1:16 p.m.)


Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.


Changes
---

I took screenshots of normal and --reverse with the current code. It seems to 
be correct, as not only is the text reversed but the button is too. So the 
arrows still point towards the inside of the dialog to open.

Given the text is for styling not actual words, I don't think it should be 
added to the string. 

If the screenshots don't convince you, I'll change it :)


Repository: polkit-kde-agent-1


Description
---

Remove all kdelibs4support from polkit-agent


Diffs
-

  AuthDialog.h eaebbd2 
  AuthDialog.cpp b76d91e 
  AuthDialog.ui e4da0f9 
  CMakeLists.txt 482fc57 
  main.cpp f8f97b8 
  policykitkde.h 85ce6b2 
  policykitkde.cpp a25cb4f 
  policykitlistener.h 538381f 
  policykitlistener.cpp bab7fdf 

Diff: https://git.reviewboard.kde.org/r/121121/diff/


Testing
---

Using pkexec tested using the correct password the wrong password viewing 
details and tested trying to open two agents at once.


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/1bb7a716-e855-4ad3-9c36-498077ee016b__polkit_normal.png
screenshot --reverse
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/0e03dc82-a81f-4192-81c7-f6376d545681__polkit_reverse.png


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121121: Remove all kdelibs4support from polkit-agent

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121121/#review70439
---

Ship it!


Ship It!

- Lukáš Tinkl


On Lis. 16, 2014, 2:16 odp., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121121/
> ---
> 
> (Updated Lis. 16, 2014, 2:16 odp.)
> 
> 
> Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl.
> 
> 
> Repository: polkit-kde-agent-1
> 
> 
> Description
> ---
> 
> Remove all kdelibs4support from polkit-agent
> 
> 
> Diffs
> -
> 
>   AuthDialog.h eaebbd2 
>   AuthDialog.cpp b76d91e 
>   AuthDialog.ui e4da0f9 
>   CMakeLists.txt 482fc57 
>   main.cpp f8f97b8 
>   policykitkde.h 85ce6b2 
>   policykitkde.cpp a25cb4f 
>   policykitlistener.h 538381f 
>   policykitlistener.cpp bab7fdf 
> 
> Diff: https://git.reviewboard.kde.org/r/121121/diff/
> 
> 
> Testing
> ---
> 
> Using pkexec tested using the correct password the wrong password viewing 
> details and tested trying to open two agents at once.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/1bb7a716-e855-4ad3-9c36-498077ee016b__polkit_normal.png
> screenshot --reverse
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/0e03dc82-a81f-4192-81c7-f6376d545681__polkit_reverse.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121133: Fix qml warnings in splash kcm

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121133/
---

(Updated Nov. 16, 2014, 4:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Warnings where


file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:95:29: QML 
Text: Cannot anchor to an item that isn't a parent or sibling.
file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:77:33: 
Unable to assign [undefined] to QUrl
file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:95:29: QML 
Text: Cannot anchor to an item that isn't a parent or sibling.

Since anchoring to non parent/sibling doesn't do anything i've just removed the 
anchoring.
I've fixed the undefined by adding || ""


Diffs
-

  kcms/splash/package/contents/ui/main.qml 9c8fed0 

Diff: https://git.reviewboard.kde.org/r/121133/diff/


Testing
---

Warnings are gone, dialog looks the same.


Thanks,

Albert Astals Cid

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

[Ivan Čukić]

Hi all,

I was MiA for some time now, sorry for that.

I've settled on a query-like API. There are too many different use-cases to
be covered by something overly specific.

Now, the API looks like this at the moment (just for the Query class, the
model-based part of the api will use the Query class):

// Creating a query
// Anything can be omitted to use the defaults
Query query {
Type { "image", "text", "application/vnd.oasis.opendocument" },
Agent { "okular" },
Activity::current(),
Ordering::HighScore,
// We can add more types if we want - no need
// to put them all into the same place
Type { "asdasd" }
};

// We forgot to add some type initially
query << Type { "blahblah" };

// We want to get the results
for (const auto &result: query) {
// Process the result
}

// And to listen for the changes
connect(&query, SIGNAL(added(...)), ...);
connect(&query, SIGNAL(removed(...)), ...);


Cheerio,
Ivan



On 22 October 2014 15:15, Marco Martin  wrote:

> On Tuesday 21 October 2014 22:48:55 Vishesh Handa wrote:
> >
> > The reason I'm prodding so much is I'm scared of activities becoming this
> > big central thing. I have a little bit of experience on working on a
>
> well, they always were, at least in the workspace.
> the thing is it's a feature done exactly in the right way: if one doesn't
> use
> multiple activities, they are completely invisible, and that's good.
> same thing for applications that would start to use activities, if only one
> exists, all scoring and linking becomes global, not imposing anyone to use
> multiple activities, and that's good ;)
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5 stable jenkins jobs created

[Albert Astals Cid]

Hi there, i've created all the stable jobs of the Plasma 5 jenkins jobs.

Can be found at http://build.kde.org/view/Plasma%205%20stable/

Cheers,
  Albert

P.S: I'm not subscribed
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is unstable: plasma-desktop_stable_qt5 #1

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

[Aleix Pol Gonzalez]

> On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote:
> > hm, i don't really like it.
> > is it working around a problem in particular?
> > if i try the patch, the difference during startup (or just duringopening a 
> > popup on the first time) is pretty noticeable like, the wallpaper appearing 
> > several *seconds* later.
> > This way, i think it's not using the incubator at all, and i don't think 
> > it's really acceptable.
> > In QML itself, QQuickView does internally use an incubator as well, even 
> > tough in a slightly different manner it seems.

Well, since I started developing in Qt, I've been told that using nested event 
loops is bad parallelization.

A good way to fix the WallpaperInterface issue (I understand it's an example, 
but still applies) is that instead of calling completeInitialization() 
(wallpaperinterface.cpp:147) we should be connect to a signal that notifies us 
about the background readiness (i.e. statusChanged) and then react to the 
initialization by connecting the object into the graphical elements, but 
forcing the end of the initialization is, of course, not parallelizable.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121113/#review70364
---


On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121113/
> ---
> 
> (Updated Nov. 13, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> We had a while loop which processed all application events whilst we
> were in the middle of creating objects. This leads to weird bugs, and
> workarounds in ShellCorona.
> 
> Qt's methods forceCompletion does not seem to have the same problems and
> works just as well.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.cpp 029edaf 
> 
> Diff: https://git.reviewboard.kde.org/r/121113/diff/
> 
> 
> Testing
> ---
> 
> Ran plasmashell with many panels filled with applets
> 
> Added debug on void ShellCorona::createWaitingPanels() to make sure it was 
> never called with m_loading true.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build became unstable: plasma-workspace_master_qt5 #1071

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121144: Remove MetadaBackendCommonModel

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121144/
---

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

this was just a wrapper around PmcMetadataModel and was not doing anything


Diffs
-

  browsingbackends/metadatavideobackend/metadatavideomodel.h 3e85f4a 
  browsingbackends/metadatavideobackend/metadatavideomodel.cpp 417cddd 
  browsingbackends/metadatabackendcommonmodel.h 0873bc0 
  browsingbackends/metadatabackendcommonmodel.cpp fbee1ff 
  browsingbackends/metadatamusicbackend/CMakeLists.txt 48e98ea 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.h 836ee21 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp d9f4fa6 
  browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.h 53efbd2 
  browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.cpp 55debf0 
  browsingbackends/metadatavideobackend/CMakeLists.txt 2b81ab2 
  browsingbackends/metadatavideobackend/metadatavideobackend.cpp 1ed833d 

Diff: https://git.reviewboard.kde.org/r/121144/diff/


Testing
---

everything works fine without it


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121144: Remove MetadaBackendCommonModel

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121144/#review70497
---



browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.h


will remove


- Bhushan Shah


On Nov. 17, 2014, 11:25 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121144/
> ---
> 
> (Updated Nov. 17, 2014, 11:25 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
> Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> this was just a wrapper around PmcMetadataModel and was not doing anything
> 
> 
> Diffs
> -
> 
>   browsingbackends/metadatavideobackend/metadatavideomodel.h 3e85f4a 
>   browsingbackends/metadatavideobackend/metadatavideomodel.cpp 417cddd 
>   browsingbackends/metadatabackendcommonmodel.h 0873bc0 
>   browsingbackends/metadatabackendcommonmodel.cpp fbee1ff 
>   browsingbackends/metadatamusicbackend/CMakeLists.txt 48e98ea 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.h 836ee21 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp d9f4fa6 
>   browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.h 53efbd2 
>   browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.cpp 55debf0 
>   browsingbackends/metadatavideobackend/CMakeLists.txt 2b81ab2 
>   browsingbackends/metadatavideobackend/metadatavideobackend.cpp 1ed833d 
> 
> Diff: https://git.reviewboard.kde.org/r/121144/diff/
> 
> 
> Testing
> ---
> 
> everything works fine without it
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121144: Remove MetadaBackendCommonModel

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121144/#review70498
---

Ship it!


Ship It!

- Shantanu Tushar


On Nov. 17, 2014, 5:55 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121144/
> ---
> 
> (Updated Nov. 17, 2014, 5:55 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
> Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> this was just a wrapper around PmcMetadataModel and was not doing anything
> 
> 
> Diffs
> -
> 
>   browsingbackends/metadatavideobackend/metadatavideomodel.h 3e85f4a 
>   browsingbackends/metadatavideobackend/metadatavideomodel.cpp 417cddd 
>   browsingbackends/metadatabackendcommonmodel.h 0873bc0 
>   browsingbackends/metadatabackendcommonmodel.cpp fbee1ff 
>   browsingbackends/metadatamusicbackend/CMakeLists.txt 48e98ea 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.h 836ee21 
>   browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp d9f4fa6 
>   browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.h 53efbd2 
>   browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.cpp 55debf0 
>   browsingbackends/metadatavideobackend/CMakeLists.txt 2b81ab2 
>   browsingbackends/metadatavideobackend/metadatavideobackend.cpp 1ed833d 
> 
> Diff: https://git.reviewboard.kde.org/r/121144/diff/
> 
> 
> Testing
> ---
> 
> everything works fine without it
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121144: Remove MetadaBackendCommonModel

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121144/
---

(Updated Nov. 17, 2014, 6:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

this was just a wrapper around PmcMetadataModel and was not doing anything


Diffs
-

  browsingbackends/metadatavideobackend/metadatavideomodel.h 3e85f4a 
  browsingbackends/metadatavideobackend/metadatavideomodel.cpp 417cddd 
  browsingbackends/metadatabackendcommonmodel.h 0873bc0 
  browsingbackends/metadatabackendcommonmodel.cpp fbee1ff 
  browsingbackends/metadatamusicbackend/CMakeLists.txt 48e98ea 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.h 836ee21 
  browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp d9f4fa6 
  browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.h 53efbd2 
  browsingbackends/metadatamusicbackend/metadatamusicsongsmodel.cpp 55debf0 
  browsingbackends/metadatavideobackend/CMakeLists.txt 2b81ab2 
  browsingbackends/metadatavideobackend/metadatavideobackend.cpp 1ed833d 

Diff: https://git.reviewboard.kde.org/r/121144/diff/


Testing
---

everything works fine without it


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel