Jenkins build is still unstable: plasma-desktop_stable_qt5 #2
See http://build.kde.org/job/plasma-desktop_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
No Plasma Meeting Today
There wont' be a Plasma hangout today as a lot of people are going to be away. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : plasma-workspace_master_qt5 #1072
See http://build.kde.org/job/plasma-workspace_master_qt5/1072/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Nov. 17, 2014, 2:37 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/1bb7a716-e855-4ad3-9c36-498077ee016b__polkit_normal.png screenshot --reverse https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/0e03dc82-a81f-4192-81c7-f6376d545681__polkit_reverse.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several *seconds* later. This way, i think it's not using the incubator at all, and i don't think it's really acceptable. In QML itself, QQuickView does internally use an incubator as well, even tough in a slightly different manner it seems. Aleix Pol Gonzalez wrote: Well, since I started developing in Qt, I've been told that using nested event loops is bad parallelization. A good way to fix the WallpaperInterface issue (I understand it's an example, but still applies) is that instead of calling completeInitialization() (wallpaperinterface.cpp:147) we should be connect to a signal that notifies us about the background readiness (i.e. statusChanged) and then react to the initialization by connecting the object into the graphical elements, but forcing the end of the initialization is, of course, not parallelizable. eh, they shouldn't put it in the documentation as an example how to di ti ;) so ok, let's try to go for it - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70364 --- On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 13, 2014, 6:24 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- We had a while loop which processed all application events whilst we were in the middle of creating objects. This leads to weird bugs, and workarounds in ShellCorona. Qt's methods forceCompletion does not seem to have the same problems and works just as well. Diffs - src/kdeclarative/qmlobject.cpp 029edaf Diff: https://git.reviewboard.kde.org/r/121113/diff/ Testing --- Ran plasmashell with many panels filled with applets Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121152: Provide async API for QmlObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/ --- Review request for Plasma. Repository: kdeclarative Description --- Introduces a method called ::delayedCompleteInitialization that will trigger the initialization then notify when it's done. Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of limitations in reviewboard. Diffs - src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 Diff: https://git.reviewboard.kde.org/r/121152/diff/ Testing --- See https://git.reviewboard.kde.org/r/121148/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121148: Make WallpaperInterface use the suggested async object loading API
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121148/ --- Review request for Plasma. Repository: plasma-framework Description --- Just asks QmlObject to create an object and waits for QmlObject::finished signal to acquire it. Diffs - src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 36e34b5 Diff: https://git.reviewboard.kde.org/r/121148/diff/ Testing --- plasmashell seems to load fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121152: Provide async API for QmlObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/#review70530 --- src/kdeclarative/qmlobject.h https://git.reviewboard.kde.org/r/121152/#comment49348 No API doc - Lukáš Tinkl On Lis. 17, 2014, 5:39 odp., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/ --- (Updated Lis. 17, 2014, 5:39 odp.) Review request for Plasma. Repository: kdeclarative Description --- Introduces a method called ::delayedCompleteInitialization that will trigger the initialization then notify when it's done. Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of limitations in reviewboard. Diffs - src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 Diff: https://git.reviewboard.kde.org/r/121152/diff/ Testing --- See https://git.reviewboard.kde.org/r/121148/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121154: Add context to i18n call
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/ --- Review request for Plasma. Repository: plasma-desktop Description --- The Catalan translator had translated it to the type you want to search, so make it clear type here is a verb Diffs - applets/kickoff/package/contents/ui/Header.qml 216ea41 Diff: https://git.reviewboard.kde.org/r/121154/diff/ Testing --- Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121155: Enforce StyledText in notifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek. Repository: plasma-workspace Description --- According to the notification spec, the body is a subset of HTML which implies that the client has to take care of escaping things that look like tags. To not break legacy clients that just use plain text and line breaks, and since the spec says each line is a paragraph a br is added for each line break instead. Diffs - applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/121155/diff/ Testing --- Tested using kdialog and knotificationdbustest and didn't find anything unusual, needs testing with Konversation and other IRC clients that tend to show things like user said something. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121155: Enforce StyledText in notifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- (Updated Nov. 17, 2014, 7:40 nachm.) Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek. Changes --- Added Bug 341029 Bugs: 341029 https://bugs.kde.org/show_bug.cgi?id=341029 Repository: plasma-workspace Description --- According to the notification spec, the body is a subset of HTML which implies that the client has to take care of escaping things that look like tags. To not break legacy clients that just use plain text and line breaks, and since the spec says each line is a paragraph a br is added for each line break instead. Diffs - applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/121155/diff/ Testing --- Tested using kdialog and knotificationdbustest and didn't find anything unusual, needs testing with Konversation and other IRC clients that tend to show things like user said something. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: The usage statistics [kactivities, baloo, ktp, plasma]
A small update.
In order to make the api avaliable to crappy compilers, I've made some small
changes to the code in the last mail:
// For crappy compilers
// Fancy query definition
auto fancyQuery = AllResources
| Type(text)
| Type(image)
| Agent(okular)
| Ordering::HighScore;
// The usual, 'object-oriented' query definition
Query normalQuery(AllResources);
normalQuery.addAgents(QStringList() okular);
normalQuery.addTypes(QStringList() text image);
normalQuery.setOrdering(Ordering::HighScore);
// For real compilers
// Fanct query definition
auto fancyQuery = AllResources
| Type{text, image}
| Agent{okular}
| Ordering::HighScore;
// The usual, 'object-oriented' query definition
Query normalQuery(AllResources);
normalQuery.addAgents({okular});
normalQuery.addTypes({text, image});
normalQuery.setOrdering(Ordering::HighScore);
In order to make the Query class cheap to copy and move, the actual work and
signals will be elsewhere (ResultSet or something similar).
Cheerio,
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121155: Enforce StyledText in notifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/#review70537 --- Ship it! applets/notifications/package/contents/ui/Notifications.qml https://git.reviewboard.kde.org/r/121155/#comment49357 Would this be faster on the c++ side (the dataengine)? We should move it there if so. Also, does StyledText/RichText not handle \n as line breaks? - Martin Klapetek On Nov. 17, 2014, 8:40 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- (Updated Nov. 17, 2014, 8:40 p.m.) Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek. Bugs: 341029 https://bugs.kde.org/show_bug.cgi?id=341029 Repository: plasma-workspace Description --- According to the notification spec, the body is a subset of HTML which implies that the client has to take care of escaping things that look like tags. To not break legacy clients that just use plain text and line breaks, and since the spec says each line is a paragraph a br is added for each line break instead. Diffs - applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/121155/diff/ Testing --- Tested using kdialog and knotificationdbustest and didn't find anything unusual, needs testing with Konversation and other IRC clients that tend to show things like user said something. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- Review request for kdelibs and Plasma. Repository: plasma-desktop Description --- Plugin unload order was making the attica_kde plugin crash on close, this works around it by leaking one AccessManager. Diffs - attica-kde/kdeplugin/kdeplatformdependent.cpp 489c03b18b7bb940007ab51cb197105fbc25de9f Diff: https://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 17, 2014, 2:11 p.m.) Review request for Plasma. Changes --- Added FIXME comment. Repository: plasma-desktop Description --- Plugin unload order was making the attica_kde plugin crash on close, this works around it by leaking one AccessManager. Diffs (updated) - attica-kde/kdeplugin/kdeplatformdependent.cpp 489c03b18b7bb940007ab51cb197105fbc25de9f Diff: https://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 17, 2014, 2:11 p.m.) Review request for kdelibs and Plasma. Repository: plasma-desktop Description --- Plugin unload order was making the attica_kde plugin crash on close, this works around it by leaking one AccessManager. Diffs - attica-kde/kdeplugin/kdeplatformdependent.cpp 489c03b18b7bb940007ab51cb197105fbc25de9f Diff: https://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121162: Some ideas for the image wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/ --- Review request for Plasma. Repository: plasma-workspace Description --- This is just a bunch of stuff I played around with I'd like to get comments on Diffs - wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 Diff: https://git.reviewboard.kde.org/r/121162/diff/ Testing --- QSG_VISUALIZE=overdraw and a bit of playing around Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121162: Some ideas for the image wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70539 --- wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49360 I don't know if readonly properties have any performance benefit but they certainly prevent you from accidentally changing things. wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49361 I was hoping for it to wait until the image was fully loaded to start the fade but that didn't help. Unfortunately QML has no please do this after rendering the current frame has finished method. wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49362 I didn't see any flickering. wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49363 Don't needlessly draw a root Rectangle that isn't visible in the first place. There's still yet another item below of the wallpaper according to qsg overdraw. wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49365 What is the clipping for? I thought clipping was evil :) Or does that actually improve things because we probably don't render outside the visible screen? Dunno. wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49364 Heh. - Kai Uwe Broulik On Nov. 17, 2014, 9:34 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/ --- (Updated Nov. 17, 2014, 9:34 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This is just a bunch of stuff I played around with I'd like to get comments on Diffs - wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 Diff: https://git.reviewboard.kde.org/r/121162/diff/ Testing --- QSG_VISUALIZE=overdraw and a bit of playing around Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---
attica-kde/kdeplugin/kdeplatformdependent.cpp
https://git.reviewboard.kde.org/r/121161/#comment49366
is
KdePlatformDependent::~KdePlatformDependent()
{
if (QCoreApplication::closingDown())
m_accessManager-setParent(nullptr);
}
sufficient?
- Thomas Lübking
On Nov. 17, 2014, 9:11 nachm., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---
(Updated Nov. 17, 2014, 9:11 nachm.)
Review request for kdelibs and Plasma.
Repository: plasma-desktop
Description
---
Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.
Diffs
-
attica-kde/kdeplugin/kdeplatformdependent.cpp
489c03b18b7bb940007ab51cb197105fbc25de9f
Diff: https://git.reviewboard.kde.org/r/121161/diff/
Testing
---
knewstuff tests no longer crash on close.
Thanks,
Jeremy Whiting
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
On nov. 17, 2014, 9:45 p.m., Thomas Lübking wrote:
attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
is
KdePlatformDependent::~KdePlatformDependent()
{
if (QCoreApplication::closingDown())
m_accessManager-setParent(nullptr);
}
sufficient?
Isn't that a more complex way of doing the same?
- Albert
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---
On nov. 17, 2014, 9:11 p.m., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---
(Updated nov. 17, 2014, 9:11 p.m.)
Review request for kdelibs and Plasma.
Repository: plasma-desktop
Description
---
Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.
Diffs
-
attica-kde/kdeplugin/kdeplatformdependent.cpp
489c03b18b7bb940007ab51cb197105fbc25de9f
Diff: https://git.reviewboard.kde.org/r/121161/diff/
Testing
---
knewstuff tests no longer crash on close.
Thanks,
Jeremy Whiting
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121162: Some ideas for the image wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70546 --- wallpapers/image/imagepackage/contents/ui/main.qml https://git.reviewboard.kde.org/r/121162/#comment49370 Don't unexpectedly colorize your Dashboard. After playing around with the color but choosing a covering wallpaper again I was quite surprised (it actually startled me when I pressed Meta+D, it was electric pink) to find my dashboard in that color still although I couldn't see it on the desktop and already had forgotten about. Maybe we should add a separate config option for the dashboard color or always have it black regardless, or ...? - Kai Uwe Broulik On Nov. 17, 2014, 9:34 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/ --- (Updated Nov. 17, 2014, 9:34 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This is just a bunch of stuff I played around with I'd like to get comments on Diffs - wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 Diff: https://git.reviewboard.kde.org/r/121162/diff/ Testing --- QSG_VISUALIZE=overdraw and a bit of playing around Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote:
attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
is
KdePlatformDependent::~KdePlatformDependent()
{
if (QCoreApplication::closingDown())
m_accessManager-setParent(nullptr);
}
sufficient?
Albert Astals Cid wrote:
Isn't that a more complex way of doing the same?
Depends on whether KdePlatformDependent is ever deleted in a running
application (where the leak would really matter)
If not, then yes: superfluous complication.
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---
On Nov. 17, 2014, 9:11 nachm., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---
(Updated Nov. 17, 2014, 9:11 nachm.)
Review request for kdelibs and Plasma.
Repository: plasma-desktop
Description
---
Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.
Diffs
-
attica-kde/kdeplugin/kdeplatformdependent.cpp
489c03b18b7bb940007ab51cb197105fbc25de9f
Diff: https://git.reviewboard.kde.org/r/121161/diff/
Testing
---
knewstuff tests no longer crash on close.
Thanks,
Jeremy Whiting
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121155: Enforce StyledText in notifications
On Nov. 17, 2014, 8:37 nachm., Martin Klapetek wrote: applets/notifications/package/contents/ui/Notifications.qml, line 48 https://git.reviewboard.kde.org/r/121155/diff/1/?file=328915#file328915line48 Would this be faster on the c++ side (the dataengine)? We should move it there if so. Also, does StyledText/RichText not handle \n as line breaks? Yeah, right, dataengine should be it. No, StyledText solely uses br for line breaks. I just found that KMail for example does not escape in subjects which makes Text just cut off(!) the message there. Meh, all of this stupid braindead markup stuff is killing me :( - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/#review70537 --- On Nov. 17, 2014, 7:40 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- (Updated Nov. 17, 2014, 7:40 nachm.) Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek. Bugs: 341029 https://bugs.kde.org/show_bug.cgi?id=341029 Repository: plasma-workspace Description --- According to the notification spec, the body is a subset of HTML which implies that the client has to take care of escaping things that look like tags. To not break legacy clients that just use plain text and line breaks, and since the spec says each line is a paragraph a br is added for each line break instead. Diffs - applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/121155/diff/ Testing --- Tested using kdialog and knotificationdbustest and didn't find anything unusual, needs testing with Konversation and other IRC clients that tend to show things like user said something. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121155: Enforce StyledText in notifications
On Nov. 17, 2014, 8:37 nachm., Martin Klapetek wrote: applets/notifications/package/contents/ui/Notifications.qml, line 48 https://git.reviewboard.kde.org/r/121155/diff/1/?file=328915#file328915line48 Would this be faster on the c++ side (the dataengine)? We should move it there if so. Also, does StyledText/RichText not handle \n as line breaks? Kai Uwe Broulik wrote: Yeah, right, dataengine should be it. No, StyledText solely uses br for line breaks. I just found that KMail for example does not escape in subjects which makes Text just cut off(!) the message there. Meh, all of this stupid braindead markup stuff is killing me :( But then KMail is a 4.x application, in text are evil anyway, and we have plenty of time to look after broken clients :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/#review70537 --- On Nov. 17, 2014, 7:40 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- (Updated Nov. 17, 2014, 7:40 nachm.) Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek. Bugs: 341029 https://bugs.kde.org/show_bug.cgi?id=341029 Repository: plasma-workspace Description --- According to the notification spec, the body is a subset of HTML which implies that the client has to take care of escaping things that look like tags. To not break legacy clients that just use plain text and line breaks, and since the spec says each line is a paragraph a br is added for each line break instead. Diffs - applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 applets/notifications/package/contents/ui/Notifications.qml 4312774 Diff: https://git.reviewboard.kde.org/r/121155/diff/ Testing --- Tested using kdialog and knotificationdbustest and didn't find anything unusual, needs testing with Konversation and other IRC clients that tend to show things like user said something. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121154: Add context to i18n call
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/#review70552 --- Ship it! Ship It! - David Edmundson On Nov. 17, 2014, 6:19 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/ --- (Updated Nov. 17, 2014, 6:19 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The Catalan translator had translated it to the type you want to search, so make it clear type here is a verb Diffs - applets/kickoff/package/contents/ui/Header.qml 216ea41 Diff: https://git.reviewboard.kde.org/r/121154/diff/ Testing --- Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121154: Add context to i18n call
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/#review70557 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 17, 2014, 6:19 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/ --- (Updated Nov. 17, 2014, 6:19 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The Catalan translator had translated it to the type you want to search, so make it clear type here is a verb Diffs - applets/kickoff/package/contents/ui/Header.qml 216ea41 Diff: https://git.reviewboard.kde.org/r/121154/diff/ Testing --- Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121152: Provide async API for QmlObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/#review70559 --- I think this makes sense. +1 - David Edmundson On Nov. 17, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/ --- (Updated Nov. 17, 2014, 4:39 p.m.) Review request for Plasma. Repository: kdeclarative Description --- Introduces a method called ::delayedCompleteInitialization that will trigger the initialization then notify when it's done. Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of limitations in reviewboard. Diffs - src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 Diff: https://git.reviewboard.kde.org/r/121152/diff/ Testing --- See https://git.reviewboard.kde.org/r/121148/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121154: Add context to i18n call
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/ --- (Updated Nov. 17, 2014, 11:06 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- The Catalan translator had translated it to the type you want to search, so make it clear type here is a verb Diffs - applets/kickoff/package/contents/ui/Header.qml 216ea41 Diff: https://git.reviewboard.kde.org/r/121154/diff/ Testing --- Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121148: Make WallpaperInterface use the suggested async object loading API
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121148/ --- (Updated Nov. 17, 2014, 11:10 p.m.) Review request for Plasma. Changes --- add missing API call. Repository: plasma-framework Description --- Just asks QmlObject to create an object and waits for QmlObject::finished signal to acquire it. Diffs (updated) - src/scriptengines/qml/plasmoid/wallpaperinterface.h 20c811f src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 36e34b5 Diff: https://git.reviewboard.kde.org/r/121148/diff/ Testing --- plasmashell seems to load fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.
On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote:
attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
is
KdePlatformDependent::~KdePlatformDependent()
{
if (QCoreApplication::closingDown())
m_accessManager-setParent(nullptr);
}
sufficient?
Albert Astals Cid wrote:
Isn't that a more complex way of doing the same?
Thomas Lübking wrote:
Depends on whether KdePlatformDependent is ever deleted in a running
application (where the leak would really matter)
If not, then yes: superfluous complication.
Did I hear a Ship it! in there somewhere?
- Jeremy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---
On Nov. 17, 2014, 2:11 p.m., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---
(Updated Nov. 17, 2014, 2:11 p.m.)
Review request for kdelibs and Plasma.
Repository: plasma-desktop
Description
---
Plugin unload order was making the attica_kde plugin crash on close,
this works around it by leaking one AccessManager.
Diffs
-
attica-kde/kdeplugin/kdeplatformdependent.cpp
489c03b18b7bb940007ab51cb197105fbc25de9f
Diff: https://git.reviewboard.kde.org/r/121161/diff/
Testing
---
knewstuff tests no longer crash on close.
Thanks,
Jeremy Whiting
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
