Re: Re: OSD and Notification Window Type

[Martin Gräßlin]

On Monday 24 November 2014 20:25:09 Marco Martin wrote:
> On Monday 24 November 2014, Martin Gräßlin wrote:
> > > First of all, the OSD uses the Notification WindowType, which - I think
> > > there has been a bit of a miscommunication - is meant for notifications.
> > > The OSD stays on top of everything, which is fine, but not the active
> > > fullscreen window. I thus propose to have a window type/layer for the
> > > OSD
> > > that stays on top of everything since I want to have volume feedback
> > > even
> > > when watching a movie.
> > 
> > +1 to that
> 
> shouldn't that window type be perhaps renamed in OSD to avoid future
> confusion?

no, we need to introduce a new window type OSD. Notification is a NETWM 
specified window type, we cannot rename it.

> plasma tooltips are override redirect yes

did that change recently? If yes, Kai Uwe could you please try again?

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId

[Martin Gräßlin]

> On Nov. 24, 2014, 8:13 p.m., Eike Hein wrote:
> > Questions:
> > 
> > a) I can't find createNewStartupIdForTimestamp in the apidox, I assume this 
> > is new and means this is master-only since it needs fresh KWS?
> > 
> > b) If it's new API assume you know it doesn't break on non-x11?
> > 
> > c) Should Task Manager launchers do it, too?

a) see the depends on review requests: https://git.reviewboard.kde.org/r/121197/
b) no I do not, but I hardly doubt that Windows and OSX use the 
DESKTOP_STARTUP_ID env variable as defined for X11. The code works and doesn't 
break but I doubt it does anything.
c) probably yes


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121234/#review70866
---


On Nov. 24, 2014, 8:05 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121234/
> ---
> 
> (Updated Nov. 24, 2014, 8:05 p.m.)
> 
> 
> Review request for Plasma, Eike Hein and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The StartupInfoId is supposed to contain information about the
> process and event which triggered the startup of the application.
> E.g. in the case of Kickoff it should be the last input event and
> the pid of Plasma. By creating the StartupInfoId directly in Kickoff
> and passing it to KRun we can ensure that this information is
> correct.
> 
> The code so far lost this information and the launch information
> was not correct. The timestamp is set to a "random" timestamp after
> the event and the pid is set to the one of the klauncher process.
> Furthermore this saves a roundtrip to the X Server from klauncher.
> 
> 
> @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f 
>   applets/kickoff/core/urlitemlauncher.cpp 
> 2ed074709c88ed10cdd72bae7d2b6bf2879183ae 
> 
> Diff: https://git.reviewboard.kde.org/r/121234/diff/
> 
> 
> Testing
> ---
> 
> started applications through plasmoidviewer and inspected the /proc/x/environ 
> to check the DESKTOP_STARTUP_ID env variable.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121239: Port ktouchpadenabler

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121239/
---

(Updated Nov. 25, 2014, 12:30 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Repository: plasma-desktop


Description
---

Unless used with kwindowsystem 5.5 it won't work (but will still compile)
Unless used with "a really new Qt" (i.e. when 
https://codereview.qt-project.org/#/c/100200/ finally integrates) the system 
settings kcm will say "¶?" instead of "Touchpad Toggle" (but it will work just 
fine)


Diffs
-

  CMakeLists.txt 6612aa4 
  ktouchpadenabler/CMakeLists.txt 1e46605 
  ktouchpadenabler/ktouchpadenabler_daemon.cpp 9cab81b 
  ktouchpadenabler/settings.kcfgc 9e49060 

Diff: https://git.reviewboard.kde.org/r/121239/diff/


Testing
---

Works for me.


Thanks,

Albert Astals Cid

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121239: Port ktouchpadenabler

[Albert Astals Cid]

> On nov. 25, 2014, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 135
> > 
> >
> > Maybe if(KF5WindowSystem_VERSION VERSION_GREATER 5.5)?

As said, there's no need, it will still compile, and once the system has 
kwindowsystem 5.5 it will just work without any recompilation needed, so adding 
the if is actually detrimental.


> On nov. 25, 2014, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > ktouchpadenabler/ktouchpadenabler_daemon.cpp, line 231
> > 
> >
> > weird indentation? =.='

Yeah will fix.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121239/#review70888
---


On nov. 25, 2014, 12:12 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121239/
> ---
> 
> (Updated nov. 25, 2014, 12:12 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Unless used with kwindowsystem 5.5 it won't work (but will still compile)
> Unless used with "a really new Qt" (i.e. when 
> https://codereview.qt-project.org/#/c/100200/ finally integrates) the system 
> settings kcm will say "¶?" instead of "Touchpad Toggle" (but it will work 
> just fine)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6612aa4 
>   ktouchpadenabler/CMakeLists.txt 1e46605 
>   ktouchpadenabler/ktouchpadenabler_daemon.cpp 9cab81b 
>   ktouchpadenabler/settings.kcfgc 9e49060 
> 
> Diff: https://git.reviewboard.kde.org/r/121239/diff/
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121239: Port ktouchpadenabler

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121239/#review70888
---

Ship it!



CMakeLists.txt


Maybe if(KF5WindowSystem_VERSION VERSION_GREATER 5.5)?



ktouchpadenabler/ktouchpadenabler_daemon.cpp


weird indentation? =.='


Thanks!

- Aleix Pol Gonzalez


On Nov. 25, 2014, 12:12 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121239/
> ---
> 
> (Updated Nov. 25, 2014, 12:12 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Unless used with kwindowsystem 5.5 it won't work (but will still compile)
> Unless used with "a really new Qt" (i.e. when 
> https://codereview.qt-project.org/#/c/100200/ finally integrates) the system 
> settings kcm will say "¶?" instead of "Touchpad Toggle" (but it will work 
> just fine)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6612aa4 
>   ktouchpadenabler/CMakeLists.txt 1e46605 
>   ktouchpadenabler/ktouchpadenabler_daemon.cpp 9cab81b 
>   ktouchpadenabler/settings.kcfgc 9e49060 
> 
> Diff: https://git.reviewboard.kde.org/r/121239/diff/
> 
> 
> Testing
> ---
> 
> Works for me.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121239: Port ktouchpadenabler

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121239/
---

Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Repository: plasma-desktop


Description
---

Unless used with kwindowsystem 5.5 it won't work (but will still compile)
Unless used with "a really new Qt" (i.e. when 
https://codereview.qt-project.org/#/c/100200/ finally integrates) the system 
settings kcm will say "¶?" instead of "Touchpad Toggle" (but it will work just 
fine)


Diffs
-

  CMakeLists.txt 6612aa4 
  ktouchpadenabler/CMakeLists.txt 1e46605 
  ktouchpadenabler/ktouchpadenabler_daemon.cpp 9cab81b 
  ktouchpadenabler/settings.kcfgc 9e49060 

Diff: https://git.reviewboard.kde.org/r/121239/diff/


Testing
---

Works for me.


Thanks,

Albert Astals Cid

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121236: Minimize overdraw in Desktop view

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121236/#review70885
---

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Nov. 24, 2014, 9:07 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121236/
> ---
> 
> (Updated Nov. 24, 2014, 9:07 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This changes the root item to be Item and only shows a black Rectangle when 
> dashboard is shown. Together with Review 121162 there is only ever one 
> full-sized root item (used to be three and more).
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/views/Desktop.qml 73698f6 
> 
> Diff: https://git.reviewboard.kde.org/r/121236/diff/
> 
> 
> Testing
> ---
> 
> Should look like it did before, however, when the dashboard is shown ontop of 
> a light maximized window (browser) the contrast is too low imho (don't 
> remember if that was the case before that). Plasmoidviewer also looks normal 
> (eg. no transparent spots when resizing the window)
> 
> Also, when switching wallpaper plugins (like from image to color) the 
> transparency in the dashboard is gone. Afaics this has been the case without 
> this patch as well but I failed to fix it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70884
---

Ship it!



wallpapers/image/imagepackage/contents/ui/main.qml


I wouldn't add this change.


Looks good to me.

- Aleix Pol Gonzalez


On Nov. 24, 2014, 9:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> ---
> 
> (Updated Nov. 24, 2014, 9:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> ---
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Different calendars in Plasma 5

[Aleix Pol]

Hi,
I went through some bug reports earlier today and found this one, that
looks quite important in principle:
https://bugs.kde.org/show_bug.cgi?id=340558

Apparently it's not possible to change Plasma's calendar type anymore. Can
somebody who has worked on the plasmoid shed some light? Martin, Sebas?

Thanks!
Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121206: Port savesystem to KDevPlatform and qml

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121206/#review70881
---



plasmate/plugins/savesystemview/git.h


Have you seen we already have a BranchesModel? It can be useful to you, in 
this case. Also there's a VcsEventsModel, IIRC.



plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml


i18n()?



plasmate/plugins/savesystemview/savesystemviewplugin.cpp


Wouldn't it be better to use QQuickWidget?



plasmate/plugins/savesystemview/savesystemviewplugin.cpp


You're showing it at the bottom here, it's good to have a good default, 
people usually don't move these around.


- Aleix Pol Gonzalez


On Nov. 22, 2014, 3:46 p.m., Giorgos Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121206/
> ---
> 
> (Updated Nov. 22, 2014, 3:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> ---
> 
> This patch is a port of the savesystem to KDevPlatform and qml.
> 
> 
> Savesystem is using KDevPlatform's code for handling the git and
> the ui is rewritten in qml.
> 
> I have attached an image of the new savesystem
> 
> 
> Diffs
> -
> 
>   
> plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml
>  PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml 
> PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml 
> PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml 
> PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml 
> PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION 
>   plasmate/plugins/CMakeLists.txt 410080b 
>   plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/savesystemview/Messages.sh PRE-CREATION 
>   plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION 
>   plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION 
>   plasmate/plugins/savesystemview/git.h PRE-CREATION 
>   plasmate/plugins/savesystemview/git.cpp PRE-CREATION 
>   plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake 
> PRE-CREATION 
>   plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION 
>   
> plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml
>  PRE-CREATION 
>   
> plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml
>  PRE-CREATION 
>   
> plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml 
> PRE-CREATION 
>   
> plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml
>  PRE-CREATION 
>   
> plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml
>  PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121206/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> savesystem in kdevelop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121207: Port the notes editor to KDevPlatform

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121207/#review70880
---


Again, why not in the document view? Note that you can change the tab title if 
you consider it needed, but to me it looks like a README editor...?

- Aleix Pol Gonzalez


On Nov. 22, 2014, 3:53 p.m., Giorgos Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121207/
> ---
> 
> (Updated Nov. 22, 2014, 3:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> ---
> 
> This is a simple port of the noteseditor to KDevPlatform.
> The internals have remained the same.
> 
> Also I have attached an image showing the noteseditor inside
> KDevelop
> 
> 
> Diffs
> -
> 
>   plasmate/noteseditor/noteseditor.h 2176456 
>   plasmate/noteseditor/noteseditor.cpp 6118d4e 
>   plasmate/plugins/CMakeLists.txt 410080b 
>   plasmate/plugins/noteseditor/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/noteseditor/kdevnoteseditor.desktop.cmake PRE-CREATION 
>   plasmate/plugins/noteseditor/kdevnoteseditor.rc PRE-CREATION 
>   plasmate/plugins/noteseditor/noteseditorplugin.h PRE-CREATION 
>   plasmate/plugins/noteseditor/noteseditorplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121207/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> noteseditor in kdevelop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/6bdfb03a-444f-4368-b789-e7aeb9db6148__notes.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121208/#review70879
---


Shouldn't this go in a document view rather than a tool view?

- Aleix Pol Gonzalez


On Nov. 22, 2014, 3:57 p.m., Giorgos Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121208/
> ---
> 
> (Updated Nov. 22, 2014, 3:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> ---
> 
> This is a port of the KConfigXtEditor to KDevPlatform.
> The internals of the kconfigxteditor haven't changed.
> 
> 
> Diffs
> -
> 
>   plasmate/plugins/kconfigxteditor/kconfigxteditorplugin.cpp PRE-CREATION 
>   plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION 
>   plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake 
> PRE-CREATION 
>   plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.rc PRE-CREATION 
>   plasmate/plugins/utils.h PRE-CREATION 
>   plasmate/plugins/utils.cpp PRE-CREATION 
>   plasmate/editors/kconfigxt/kconfigxteditor.cpp  
>   plasmate/editors/kconfigxt/kconfigxteditor.ui  
>   plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af 
>   plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c 
>   plasmate/editors/kconfigxt/kconfigxtreader.h  
>   plasmate/editors/kconfigxt/kconfigxtreader.cpp  
>   plasmate/editors/kconfigxt/kconfigxtwriter.h  
>   plasmate/editors/kconfigxt/kconfigxtwriter.cpp  
>   plasmate/editors/kconfigxt/standalone/main.cpp  
>   plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 
>   plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp  
>   plasmate/plugins/CMakeLists.txt 410080b 
>   plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/kconfigxteditor/kconfigxteditorplugin.h PRE-CREATION 
>   CMakeLists.txt 72f5eb2 
>   Plasmate.cmake PRE-CREATION 
>   kconfigxteditor/CMakeLists.txt PRE-CREATION 
>   plasmate/CMakeLists.txt 6e07b30 
>   plasmate/editors/kconfigxt/kconfigxteditor.h  
> 
> Diff: https://git.reviewboard.kde.org/r/121208/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> kconfigxteditor in kdevelop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/
---

(Updated Nov. 24, 2014, 9:19 nachm.)


Review request for Plasma.


Changes
---

Use OpacityAnimator and delay transition when switching wallpapers not when 
changing fillmode

No more stuttering when changing wallpapers \o/
The Plasma Next wallpaper is quite heavy, when switching to it there has always 
been stuttering. This no more! Slideshows should benefit from this a lot as 
well.


Repository: plasma-workspace


Description
---

This is just a bunch of stuff I played around with I'd like to get comments on


Diffs (updated)
-

  wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 

Diff: https://git.reviewboard.kde.org/r/121162/diff/


Testing
---

QSG_VISUALIZE=overdraw and a bit of playing around


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121236: Minimize overdraw in Desktop view

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121236/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This changes the root item to be Item and only shows a black Rectangle when 
dashboard is shown. Together with Review 121162 there is only ever one 
full-sized root item (used to be three and more).


Diffs
-

  desktoppackage/contents/views/Desktop.qml 73698f6 

Diff: https://git.reviewboard.kde.org/r/121236/diff/


Testing
---

Should look like it did before, however, when the dashboard is shown ontop of a 
light maximized window (browser) the contrast is too low imho (don't remember 
if that was the case before that). Plasmoidviewer also looks normal (eg. no 
transparent spots when resizing the window)

Also, when switching wallpaper plugins (like from image to color) the 
transparency in the dashboard is gone. Afaics this has been the case without 
this patch as well but I failed to fix it.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/
---

(Updated Nov. 24, 2014, 9:01 nachm.)


Review request for Plasma.


Changes
---

Improve a bit

Since the dashboard isn't actually a different view I cannot just hide the 
wallpaper altogether otherwise we end up with a black desktop


Repository: plasma-workspace


Description
---

This is just a bunch of stuff I played around with I'd like to get comments on


Diffs (updated)
-

  wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 

Diff: https://git.reviewboard.kde.org/r/121162/diff/


Testing
---

QSG_VISUALIZE=overdraw and a bit of playing around


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PageStack and StackView

[Kai Uwe Broulik]

Am Montag, 24. November 2014, 20:47:26 schrieb Marco Martin:

> pageStack.push(someItem, {fgcolor: "red", bgcolor: "blue"}, true) would just
> wrap internally
> stackView.push({item: someItem, immediate: true, properties: {fgcolor:
> "red", bgcolor: "blue"}})

So it seems when I define a

function push(item, properties, immediate) {
push({item: item, properties: properties, immediate: immediate})
}

works, that was... unexpected.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PageStack and StackView

[Marco Martin]

On Monday 24 November 2014, Marco Martin wrote:
> > push(page, properties, immediate) → push(item) as a shortcut, or
> > push({item: someItem, immediate: true, properties: {foo: "bar", baz:
> > "bla"} }) which cannot be (easily, if at all?) overloaded to provide
> > legacy support
> 
> Uuh, from where the latter syntax of push comes from?
> I don't see any problems overloading push and pop...

ah ok, is StackView that supports it, so that's just fine:

pageStack.push(someItem, {fgcolor: "red", bgcolor: "blue"}, true) would just 
wrap internally
stackView.push({item: someItem, immediate: true, properties: {fgcolor: "red", 
bgcolor: "blue"}})

so should just work

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PageStack and StackView

[Marco Martin]

On Monday 24 November 2014, Kai Uwe Broulik wrote:
> Hi again,
> 
> I was looking into porting PlasmaComponents.PageStack to
> QtQuick.Controls.StackView. PageStack provides quite some legacy features
> Marco told me weren't that important but it also has a lot of similar-but-
> different API with JavaScript functions taking a couple of parameters
> whereas Qt takes one JS Object and I think we cannot overload them (ie.
> have a method foo(bar, baz) call a foo(bla) instead.
> 
> API differences (PageStack → StackView)
> depth → depth (identical)
> currentPage → currentItem (could be alias'd)
> toolBar → for some magic toolbar thing, allegedly used in the widget
> gallery animate → there's an "immediate" property for pushing/popping
> items, our StackViewDelegate could honor that/the duration settings
> initialPage → initialItem
> busy → busy (identical)
> push(page, properties, immediate) → push(item) as a shortcut, or
> push({item: someItem, immediate: true, properties: {foo: "bar", baz:
> "bla"} }) which cannot be (easily, if at all?) overloaded to provide
> legacy support 

Uuh, from where the latter syntax of push comes from?
I don't see any problems overloading push and pop...

> Due to the invasive API differences I was thinking of keeping the PageStack
> as is, deprecated, and add a new PlasmaComponents.StackView with all the
> new fancy QQC API.
> 
> Thoughts?

I think they can be overloaded, and I would like to have that tried to see how 
many things it breaks
I would prefer keeping a single class, every new one that gets added means 
future problems.
Actually, what I would really prefer, is (besides porting the internals of 
PageStack  to it) is to have the stackviewdelegate actually come from the 
style (so no stackview subclasses needed) that may be worth of trying a patch 
to upstream stackview

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QtQuick Controls Calendar

[Marco Martin]

On Saturday 08 November 2014, Kai Uwe Broulik wrote:
> Hi all,
> 
> I was looking into migrating the Plasma Calendar to QtQuick Controls
> Calendar.
> 
> However, we went through so much work making this thing efficient and fast
> using Canvas but the QtQuick Controls Calendar again uses one item per day
> (which potentially contains a Label and Rects for the borders). I do not
> know whether it re-uses the items when switching through months (which is
> a bit laggy with the Canvas calendar), though. One advantage is that it
> would give us week numbers for free.
> 
> Suggestions?

last week this was discussed a bit, and the conclusion in the end seemed that 
they really solve two different problems.

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: OSD and Notification Window Type

[Marco Martin]

On Monday 24 November 2014, Martin Gräßlin wrote:
> > First of all, the OSD uses the Notification WindowType, which - I think
> > there has been a bit of a miscommunication - is meant for notifications.
> > The OSD stays on top of everything, which is fine, but not the active
> > fullscreen window. I thus propose to have a window type/layer for the OSD
> > that stays on top of everything since I want to have volume feedback even
> > when watching a movie.
> 
> +1 to that

shouldn't that window type be perhaps renamed in OSD to avoid future 
confusion?

> 
> > Furthermore, I've been using the notification applet with the
> > Notification window type and it was no pleasant experience. The popups
> > were always in the way, systray and other popups, even tooltips(!) were
> > covered by the notification popup. At the moment you can bring popups
> > above notifications by focussing the popup which is nice but there's an
> > issue where clicking a notification causes the popup to close, which
> > eats focus [1].
> 
> tooltips should not be managed windows, but override redirect. From EWMH
> spec: "This property is typically used on override-redirect windows." - If
> Plasma is not using override redirect windows for tooltips this is a bug
> that should be fixed. An override redirect window is always on top of any
> window managed by KWin (e.g. the notifications).

plasma tooltips are override redirect yes

> 
> Concerning other popups and the systray popups this need to be thought
> about what we want to achieve. Concerning the systray popup I think we
> rather found a weak spot in our setup: systray popup and notification
> using the same area on the screen might not be the best solution. Anyway

if the popup is open i think the notification should reposition itself to 
accomodate that (both appearing on top or under the systray popup is quite 
wrong, should simply be elsewhere).
I had a patch for it but was quite horrible, maybe i can give it another go in 
a prettier way



-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70869
---


+1, I like the approach.
+do you think it still requires work?

- Marco Martin


On Nov. 17, 2014, 9:34 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> ---
> 
> (Updated Nov. 17, 2014, 9:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> ---
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Marco Martin]

> On Nov. 17, 2014, 9:37 p.m., Kai Uwe Broulik wrote:
> > wallpapers/image/imagepackage/contents/ui/main.qml, line 167
> > 
> >
> > What is the clipping for? I thought clipping was evil :) Or does that 
> > actually improve things because we probably don't render outside the 
> > visible screen? Dunno.

yeah, should be completely useless


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70539
---


On Nov. 17, 2014, 9:34 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> ---
> 
> (Updated Nov. 17, 2014, 9:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> ---
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QtQuick Controls Calendar

[Aleix Pol]

On Sat, Nov 8, 2014 at 6:20 PM, Kai Uwe Broulik 
wrote:

> Hi all,
>
> I was looking into migrating the Plasma Calendar to QtQuick Controls
> Calendar.
>
> However, we went through so much work making this thing efficient and fast
> using Canvas but the QtQuick Controls Calendar again uses one item per day
> (which potentially contains a Label and Rects for the borders). I do not
> know
> whether it re-uses the items when switching through months (which is a bit
> laggy with the Canvas calendar), though. One advantage is that it would
> give
> us week numbers for free.
>
> Suggestions?
>
> Cheers,
> Kai Uwe


Would it maybe help with calendars l10n?
https://bugs.kde.org/show_bug.cgi?id=340558

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121234/
---

Review request for Plasma, Eike Hein and Vishesh Handa.


Repository: plasma-desktop


Description
---

The StartupInfoId is supposed to contain information about the
process and event which triggered the startup of the application.
E.g. in the case of Kickoff it should be the last input event and
the pid of Plasma. By creating the StartupInfoId directly in Kickoff
and passing it to KRun we can ensure that this information is
correct.

The code so far lost this information and the launch information
was not correct. The timestamp is set to a "random" timestamp after
the event and the pid is set to the one of the klauncher process.
Furthermore this saves a roundtrip to the X Server from klauncher.


@Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner.


Diffs
-

  applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f 
  applets/kickoff/core/urlitemlauncher.cpp 
2ed074709c88ed10cdd72bae7d2b6bf2879183ae 

Diff: https://git.reviewboard.kde.org/r/121234/diff/


Testing
---

started applications through plasmoidviewer and inspected the /proc/x/environ 
to check the DESKTOP_STARTUP_ID env variable.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70868
---


+1, I like the approach.
+do you think it still requires work?

- Marco Martin


On Nov. 17, 2014, 9:34 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> ---
> 
> (Updated Nov. 17, 2014, 9:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> ---
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

PageStack and StackView

[Kai Uwe Broulik]

Hi again,

I was looking into porting PlasmaComponents.PageStack to 
QtQuick.Controls.StackView. PageStack provides quite some legacy features 
Marco told me weren't that important but it also has a lot of similar-but-
different API with JavaScript functions taking a couple of parameters whereas 
Qt takes one JS Object and I think we cannot overload them (ie. have a method 
foo(bar, baz) call a foo(bla) instead.

API differences (PageStack → StackView)
depth → depth (identical)
currentPage → currentItem (could be alias'd)
toolBar → for some magic toolbar thing, allegedly used in the widget gallery
animate → there's an "immediate" property for pushing/popping items, our 
StackViewDelegate could honor that/the duration settings
initialPage → initialItem
busy → busy (identical)
push(page, properties, immediate) → push(item) as a shortcut, or push({item: 
someItem, immediate: true, properties: {foo: "bar", baz: "bla"} }) which 
cannot be (easily, if at all?) overloaded to provide legacy support
pop(page, immediate) → pop(null), pop(item), or pop({item: item, immediate: 
true})
replace(page, properties, immediate) → push({item: item, replace: true, ...})
clear() → clear() (identical)
find(func) → find(func, onlySearchLoadedItems) (compatible)

There's also a CodeReview [1] which hopefully soon[tm] allow the use of 
Animators for the StackViewDelegate reducing the stutter we currently have 
when eg. switching between systray items. I tried in one of my apps and the 
results were stunning, really.

Due to the invasive API differences I was thinking of keeping the PageStack as 
is, deprecated, and add a new PlasmaComponents.StackView with all the new 
fancy QQC API.

Thoughts?

Cheers,
Kai Uwe

[1] https://codereview.qt-project.org/#/c/100657/

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

OSD and Notification Window Type

[Kai Uwe Broulik]

Hi everyone,

owing to Eike's request I have investigated how to improve fullscreen handling 
in notifications, queuing them while in fullscreen. While doing so I found a 
few usability quirks:

First of all, the OSD uses the Notification WindowType, which - I think there 
has been a bit of a miscommunication - is meant for notifications. The OSD 
stays on top of everything, which is fine, but not the active fullscreen 
window. I thus propose to have a window type/layer for the OSD that stays on 
top of everything since I want to have volume feedback even when watching a 
movie.

Furthermore, I've been using the notification applet with the Notification 
window type and it was no pleasant experience. The popups were always in the 
way, systray and other popups, even tooltips(!) were covered by the 
notification popup. At the moment you can bring popups above notifications by 
focussing the popup which is nice but there's an issue where clicking a 
notification causes the popup to close, which eats focus [1].

As far as I can see, it has been agreed upon that notifications should never 
go ontop of an active fullscreen window (you don't want a "Hey, darling" 
notification pop up during a presentation) but otherwise on top.

I am fairly out of ideas now.

Cheers,
Kai Uwe

[1] https://bugs.kde.org/show_bug.cgi?id=338946

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: OSD and Notification Window Type

[Martin Gräßlin]

On Monday 24 November 2014 19:55:21 Kai Uwe Broulik wrote:
> Hi everyone,
> 
> owing to Eike's request I have investigated how to improve fullscreen
> handling in notifications, queuing them while in fullscreen. While doing so
> I found a few usability quirks:
> 
> First of all, the OSD uses the Notification WindowType, which - I think
> there has been a bit of a miscommunication - is meant for notifications.
> The OSD stays on top of everything, which is fine, but not the active
> fullscreen window. I thus propose to have a window type/layer for the OSD
> that stays on top of everything since I want to have volume feedback even
> when watching a movie.

+1 to that

> 
> Furthermore, I've been using the notification applet with the Notification
> window type and it was no pleasant experience. The popups were always in the
> way, systray and other popups, even tooltips(!) were covered by the
> notification popup. At the moment you can bring popups above notifications
> by focussing the popup which is nice but there's an issue where clicking a
> notification causes the popup to close, which eats focus [1].

tooltips should not be managed windows, but override redirect. From EWMH spec: 
"This property is typically used on override-redirect windows." - If Plasma is 
not using override redirect windows for tooltips this is a bug that should be 
fixed. An override redirect window is always on top of any window managed by 
KWin (e.g. the notifications).

Concerning other popups and the systray popups this need to be thought about 
what we want to achieve. Concerning the systray popup I think we rather found 
a weak spot in our setup: systray popup and notification using the same area 
on the screen might not be the best solution. Anyway also this is fixable by 
looking at the window types and then redefining where the notifications should 
go. IMHO the layer is currently correct. A notification should be on top of 
other windows, we don't want to have it shown e.g. behind the panel.

> 
> As far as I can see, it has been agreed upon that notifications should never
> go ontop of an active fullscreen window (you don't want a "Hey, darling"
> notification pop up during a presentation) but otherwise on top.

yes, exactly.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121234/#review70866
---


Questions:

a) I can't find createNewStartupIdForTimestamp in the apidox, I assume this is 
new and means this is master-only since it needs fresh KWS?

b) If it's new API assume you know it doesn't break on non-x11?

c) Should Task Manager launchers do it, too?

- Eike Hein


On Nov. 24, 2014, 7:05 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121234/
> ---
> 
> (Updated Nov. 24, 2014, 7:05 p.m.)
> 
> 
> Review request for Plasma, Eike Hein and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The StartupInfoId is supposed to contain information about the
> process and event which triggered the startup of the application.
> E.g. in the case of Kickoff it should be the last input event and
> the pid of Plasma. By creating the StartupInfoId directly in Kickoff
> and passing it to KRun we can ensure that this information is
> correct.
> 
> The code so far lost this information and the launch information
> was not correct. The timestamp is set to a "random" timestamp after
> the event and the pid is set to the one of the klauncher process.
> Furthermore this saves a roundtrip to the X Server from klauncher.
> 
> 
> @Eike and Vishesh: I'd suggest to add the same change to Kicker and KRunner.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 817c7e41f4454aab66db5ad84e4b494395e5484f 
>   applets/kickoff/core/urlitemlauncher.cpp 
> 2ed074709c88ed10cdd72bae7d2b6bf2879183ae 
> 
> Diff: https://git.reviewboard.kde.org/r/121234/diff/
> 
> 
> Testing
> ---
> 
> started applications through plasmoidviewer and inspected the /proc/x/environ 
> to check the DESKTOP_STARTUP_ID env variable.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121229: Highlight first entry when searching

[Aleix Pol Gonzalez]

> On Nov. 24, 2014, 5:36 p.m., Aleix Pol Gonzalez wrote:
> > Definitely, does pressing up & down work as expected too?
> > 
> > In fact, here it looks like I already get a highlight delegate...
> 
> Kai Uwe Broulik wrote:
> Yes, pressing up and down works as expected, only if you type again 
> (which resets the list anyway) you end up at the top again.
> 
> Make sure you don't have your mouse hovering there, I had the same and 
> thought it already worked :)

I made sure. But your patch seems to make sense and fix the bug, so +1.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121229/#review70859
---


On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121229/
> ---
> 
> (Updated Nov. 24, 2014, 5:27 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Bugs: 340067
> https://bugs.kde.org/show_bug.cgi?id=340067
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Since pressing enter invokes the first entry it should be highlighted.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 
> 
> Diff: https://git.reviewboard.kde.org/r/121229/diff/
> 
> 
> Testing
> ---
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121229: Highlight first entry when searching

[Kai Uwe Broulik]

> On Nov. 24, 2014, 5:36 nachm., Aleix Pol Gonzalez wrote:
> > Definitely, does pressing up & down work as expected too?
> > 
> > In fact, here it looks like I already get a highlight delegate...

Yes, pressing up and down works as expected, only if you type again (which 
resets the list anyway) you end up at the top again.

Make sure you don't have your mouse hovering there, I had the same and thought 
it already worked :)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121229/#review70859
---


On Nov. 24, 2014, 5:27 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121229/
> ---
> 
> (Updated Nov. 24, 2014, 5:27 nachm.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Bugs: 340067
> https://bugs.kde.org/show_bug.cgi?id=340067
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Since pressing enter invokes the first entry it should be highlighted.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 
> 
> Diff: https://git.reviewboard.kde.org/r/121229/diff/
> 
> 
> Testing
> ---
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121229: Highlight first entry when searching

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121229/#review70859
---


Definitely, does pressing up & down work as expected too?

In fact, here it looks like I already get a highlight delegate...

- Aleix Pol Gonzalez


On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121229/
> ---
> 
> (Updated Nov. 24, 2014, 5:27 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Bugs: 340067
> https://bugs.kde.org/show_bug.cgi?id=340067
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Since pressing enter invokes the first entry it should be highlighted.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 
> 
> Diff: https://git.reviewboard.kde.org/r/121229/diff/
> 
> 
> Testing
> ---
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121229: Highlight first entry when searching

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121229/
---

Review request for Plasma and Sebastian Kügler.


Bugs: 340067
https://bugs.kde.org/show_bug.cgi?id=340067


Repository: plasma-desktop


Description
---

Since pressing enter invokes the first entry it should be highlighted.


Diffs
-

  applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 

Diff: https://git.reviewboard.kde.org/r/121229/diff/


Testing
---

Works as expected.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=340063

Aleix Pol  changed:

   What|Removed |Added

  Flags||VisualDesign+

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121228: Fix minimum height in notifications

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121228/
---

Review request for Plasma, Martin Klapetek and Vishesh Handa.


Bugs: 341218
https://bugs.kde.org/show_bug.cgi?id=341218


Repository: plasma-workspace


Description
---

This changes the bahavior from Math.max(icon, text + margins) to Math.max(icon, 
text) + margins which should fix the layout in case the notification has no 
bodytext.


Diffs
-

  applets/notifications/package/contents/ui/NotificationItem.qml 1074e63 

Diff: https://git.reviewboard.kde.org/r/121228/diff/


Testing
---

Nope, no 5 here, hence the RR :)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1094

[KDE CI System]

See 

Changes:

[me] ServicesRunner: Give a higher relevance when the exec matches the term

[me] Recent Documents Runner: Run the actual URL when running

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson291565240529333520.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   f9e1dcc..8738452  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at f9e1dcc Small code cleanup
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@53f1aa51
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-workspace 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 8738452c9c2ad2000bb7499dca3533945d5b9aac 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 8738452c9c2ad2000bb7499dca3533945d5b9aac
 > git rev-list f1d19362c1ae8390d100def8d0a7f57470f8990a # timeout=10
 > git tag -a -f -m Jenkins Build #1094 
 > jenkins-plasma-workspace_master_qt5-1094 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson2200806837469812671.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kitemviews - Branch master
 kfilemetadata - Branch master
 kio-extras - Branch master
 kwayland - Branch master
 libkscreen - Branch frameworks
 ki18n - Branch master
 kitemmodels - Branch master
 kdesignerplugin - Branch master
 milou - Branch master
 kcodecs - Branch master
 kconfig - Branch master
 knotifyconfig - Branch master
 kunitconversion - Branch master
 dogtail - Branch master
 kidletime - Branch master
 libgit2 - Branch master
 krunner - Branch master
 kde-cli-tools - Branch master
 threadweaver - Branch master
 kauth - Branch master
 kiconthemes - Branch master
 kded - Branch master
 kdewebkit - Branch master
 kcompletion - Branch master
 breeze - Branch master
 kactivities - Branch master
 cmake - Branch master
 kcrash - Branch master
 kdelibs4support - Branch master
 knewstuff - Branch master
 kdnssd - Branch master
 kjs - Branch master
 kwallet - Branch master
 kio - Branch master
 kcmutils - Branch master
 kwidgetsaddons - Branch master
 kbookmarks - Branch master
 libdbusmenu-qt - Branch master
 solid - Branch master
 kparts - Branch master
 sonnet - Branch master
 kdeclarative - Branch master
 kjobwidgets - Branch master
 kwin - Branch master
 frameworkintegration - Branch master
 kcoreaddons - Branch master
 phonon - Branch master
 plasma-framework - Branch master
 khelpcenter - Branch master
 kemoticons - Branch master
 extra-cmake-modules - Branch master
 polkit-qt-1 - Branch master
 kinit - Branch master
 kxmlgui - Branch master
 kdesu - Branch master
 kwindowsystem - Branch master
 kguiaddons - Branch master
 kdoctools - Branch master
 kdesupport-svn - Branch master
 kplotting - Branch master
 ktexteditor - Branch master
 khtml - Branch master
 kpty - Branch master
 kross - Branch master
 baloo - Branch master
 kjsembed - Branch master
 kdbusaddons - Branch master
 ktextwidgets - Branch master
 knotifications - Branch master
 kconfigwidgets - Branch master
 kservice - Branch master
 qt5 - Branch stable
 karchive - Branch master
 kglobalaccel - Branch master
 attica - Branch master
 libksysguard - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

Connection closed by 5.9.19.111
rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
rsync error: unexplained error (code 255) at io.c(605) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-workspace failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build 

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Minutes Plasma Hangout, 24-11-2014

Present: Kai Uwe, David, Marco, Martin G, Martin K, Sebas, Vishesh

(Much of the team has been to a business meeting, hence reduced bandwidth last 
week.)

Kai Uwe:
- Wallpaper improvements https://git.reviewboard.kde.org/r/121162/
- IconItem patch https://git.reviewboard.kde.org/r/121219/
- KNotifications use styled text now, fixing fallout of that
- pending an email about osd and notification windowtypes

David:
- Implementing properties.GetAll and Notify for quicker DBus chatter (Qt 5.5 
timeframe)

Marco:
- started branch for highdpi in Plasma::Svg (marg/SvgDevicePixelRatio )
- started branch for Qt Components that shift shape between Plasma::Applets 
and "normal" UI mode
- to work with someone doing a statusnotifier implementation in Qt
- to ready KPackage

Martin G:
- looking into screenhandling issue https://git.reviewboard.kde.org/r/117614/ 
(wrong layering of just-started apps)
- to work on finishing kdecoration2
- to work on KWayland server API stability

Martin K:
- finished facebook resource
- finished KAccounts daemon part handling akonadi resources (fb is now 
exclusively set up by kaccounts, more to follow)
- to move KAccounts out of playground this week into workspace
- started porting kcalcore to resurrect calendars in Plasma

Vishesh:
- krunner is more responsive now \o/
- working and to work on baloo optimizations
- https://git.reviewboard.kde.org/r/121201/

Sebastian:
- worked on Wayland roadmap (see plasma list)
- researched / tested some high dpi stuff
- started on prototyping a config synching solution
- to work on libkscreen/wayland
- to work on Plugin indexing work planned

-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121162: Some ideas for the image wallpaper

[Marco Martin]

> On Nov. 17, 2014, 10:02 p.m., Kai Uwe Broulik wrote:
> > wallpapers/image/imagepackage/contents/ui/main.qml, line 157
> > 
> >
> > Don't unexpectedly colorize your Dashboard. After playing around with 
> > the color but choosing a covering wallpaper again I was quite surprised (it 
> > actually startled me when I pressed Meta+D, it was electric pink) to find 
> > my dashboard in that color still although I couldn't see it on the desktop 
> > and already had forgotten about.
> > 
> > Maybe we should add a separate config option for the dashboard color or 
> > always have it black regardless, or ...?

it could just hide the wallpaper completely when dashboard is shown


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70546
---


On Nov. 17, 2014, 9:34 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> ---
> 
> (Updated Nov. 17, 2014, 9:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> ---
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120914: [kcmkwin/tabbox] Find all layouts in lnf package

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120914/
---

(Updated Nov. 24, 2014, 9:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kwin


Description
---

First try to locate all look-and-feel packages and check whether
they provide a WindowSwitcher. If they do they are inserted in
the list with the Package name being the user visible name.
So the good old sidebar is now called "Breeze".


Diffs
-

  kcmkwin/kwintabbox/CMakeLists.txt 3241390775d6cec37097b266c73ef10c5e90865f 
  kcmkwin/kwintabbox/main.cpp 1e94b7ea1d6cae899558366b32eb9bf828d09d3b 

Diff: https://git.reviewboard.kde.org/r/120914/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121197/
---

(Updated Nov. 24, 2014, 9:09 a.m.)


Review request for KDE Frameworks, kwin and Plasma.


Changes
---

added bug


Bugs: 337798
https://bugs.kde.org/show_bug.cgi?id=337798


Repository: kwindowsystem


Description (updated)
---

KStartupInfo::createNewStartupId is supposed to return a new
id with a properly setup user timestamp. But if QX11Info::appUserTime
returns 0 this was included in the id and cannot be considered a
properly setup user timestamp. An app user time of 0 is the case
for klauncher. If an application uses this timestamp of 0 passed from
the startup notification it causes problems with passing focus to it
from KWin. The application sets the timestamp in the
_NET_WM_USER_TIME property and the value "0" has the special meaning
of requesting to not be initially mapped. KWin honors that and doesn't
focus the window. An application is not supposed to interpret a 0 time
stamp passed through the startup notification as a special value to get
the current time. It is totally fine to expect that it gets a proper
value passed. Thus one cannot blame applications for not interpreting
this value accordingly. An example for an application passing the 0
to the _NET_WM_USER_TIME is Firefox. Starting Firefox in a Plasma 5
session through e.g. the launcher results in KWin not passing focus
to it and instead demands attention. This is clearly wrong and not
intended.

The solution in this change is to get the current timestamp from
the X server in case the appUserTime is 0. This fixes the described
problem with Firefox: it now gets properly focused on starting
through a launcher.


Diffs
-

  autotests/kstartupinfo_unittest.cpp f4b607d2a21da7dcf32434c00b2bdeeaf401ee65 
  src/kstartupinfo.cpp 03418fce1a154ea388d0f65665dc0c9724a5623a 

Diff: https://git.reviewboard.kde.org/r/121197/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel