Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite
On Dec. 23, 2014, 3:15 a.m., Marco Martin wrote: > > If this is the only thing that is going to be using the plotter, I really > > don't think it's worth rushing it if it isn't ready by 5.6 I'm fine for having it delayed for 5.3 if you think that's risky - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/#review72446 --- On Dec. 16, 2014, 1:39 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121554/ > --- > > (Updated Dec. 16, 2014, 1:39 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > a simple rewrite of the "network" systemmonitor plasmoid, using the new > "plotter" component from extracomponents > > > Diffs > - > > applets/systemmonitor/metadata.desktop PRE-CREATION > applets/systemmonitor/contents/config/main.xml PRE-CREATION > applets/systemmonitor/contents/ui/configGeneral.qml PRE-CREATION > applets/systemmonitor/contents/ui/net.qml PRE-CREATION > applets/systemmonitor/contents/config/config.qml PRE-CREATION > applets/CMakeLists.txt c4d40ac > applets/systemmonitor/Messages.sh PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121554/diff/ > > > Testing > --- > > > File Attachments > > > sysmon.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/16/4b5ba6d2-bc5e-4369-9f1e-ce80d510c894__sysmon.png > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
> On Dec. 11, 2014, 10:24 a.m., Marco Martin wrote: > > what's the status of this? > > Andrei Amuraritei wrote: > Hi there, this compiles and works, as best I could test it. Still needs > work to port away from kde4support libs. > Sadly my time with it has been null, too busy with work and other stuff > still. can you push your work so far in a git branch? so is easy for people to try, and eventually contribute ;) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- On Oct. 17, 2014, 12:08 a.m., Andrei Amuraritei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Oct. 17, 2014, 12:08 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > comic DataEngine initial port to frameworks. > > > Diffs > - > > dataengines/CMakeLists.txt 04c7985 > dataengines/comic/CMakeLists.txt 8e382e6 > dataengines/comic/cachedprovider.h baac8a9 > dataengines/comic/cachedprovider.cpp caca25e > dataengines/comic/comic.h 8cc3969 > dataengines/comic/comic.cpp 7130f44 > dataengines/comic/comic_package.h 32be381 > dataengines/comic/comic_package.cpp 6d2ff0b > dataengines/comic/comic_package_plugin.cpp d997947 > dataengines/comic/comicprovider.h 630ee8d > dataengines/comic/comicprovider.cpp ab248a5 > dataengines/comic/comicproviderkross.h 46a9072 > dataengines/comic/comicproviderkross.cpp 9820f05 > dataengines/comic/comicproviderwrapper.h 81eee68 > dataengines/comic/comicproviderwrapper.cpp 48ced42 > > Diff: https://git.reviewboard.kde.org/r/120276/diff/ > > > Testing > --- > > Building from source, compiles 100%, some deprecated warnings. DataEngine > shows up in plasmaengineexplorer and detects installed .comic packages. > This is the initial port, still need to review code to fix issues like > whitespaces around ( or the deprecated parts. > Thanks notmart, d_ed, sebas, bshas etc for helping. > > Update: Engine is working...still need to port away from Solid and KService > to remove KDELibs4Support, that is still wip. > > > Thanks, > > Andrei Amuraritei > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KPackage framework
On Mon, Dec 22, 2014 at 4:01 PM, David Edmundson wrote: > No objections from me ok, opened a sysadmin ticket for the move -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Sprint Q1 2015
On Friday, 2014-12-19, 17:43:00, Scarlett Clark wrote: > On Friday, December 19, 2014 11:51:34 PM David Edmundson wrote: > > You know the drill: https://sprints.kde.org/sprint/260 > > > > Any questions, ping me. > > Oh oh! I wanna go! But the question is would it be useful for me to go. I > need to convince people to pay my way lol. What do these sprints usually > entail? Scarlett David already answered with the general plan, but I think it is important to also say that sprints are always shaped by the people who attend. My personal experience is mostly with PIM sprints, but these morph quite a lot depending on who attends. Lately we had the pleasure of having usuability/design/interaction people attending the sprints which naturally lead to lot of UI work being done (as in contrast to primarily backend work). The attendence of translators, for example, could help to improve the quality of the source strings, e.g. adding context to strings that translators have difficulties with, changing phrasing that is hard to translate, splitting messages, etc. The attendence of documenttion writers could help to get "hidden" things documented properly, e.g. unknown configuration options, locations of important files, etc., but also lead to restructuring workflows when documentation difficulties indicate that they are currently too complex or unintuitive. Since we are currently in the early phases of our new major cycle, presence of marketing/promo people should be very valuable to work on vision statements, roadmap documents and core messaging, etc. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off
https://bugs.kde.org/show_bug.cgi?id=340063 Philipp Stefan changed: What|Removed |Added CC||neptuneca...@gmail.com --- Comment #1 from Philipp Stefan --- Valid criticism. Having it fade to warn the user that the screen is about to turn off is a sensible thing to do. A go from me. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.2 bits for kdereview
Hi, On Friday 19 of December 2014 17:27 Jonathan Riddell wrote: > Plasma 5.2 is due out next month and there's a few KDE projects which would > be good to be included. Please review these for inclusion in > kde/workspace.. > > Bluedevil frameworks branch by David Rosca > https://projects.kde.org/projects/extragear/base/bluedevil > https://projects.kde.org/projects/playground/libs/libbluedevil > > User-manager frameworks port (it overlaps a little with account details kcm > but is mostly an admin tool) > https://projects.kde.org/projects/playground/base/user-manager > > kscreen and libkscreen maintained by Dan Vrátil. libkscreen is already > released with Plasma but isn't in kde/workspace. > https://projects.kde.org/projects/extragear/libs/libkscreen > https://projects.kde.org/projects/extragear/base/kscreen > > ModemManagerQt, already released with Plasma, makes sense to move to > kde/workspace (libnm-qt is moving to frameworks) > https://projects.kde.org/projects/extragear/libs/libmm-qt > We plan to move ModemManagerQt also to frameworks, we just didn't have time for polishing the library, writing unit tests and so on. With NetworkManagerQt being already moved to frameworks I plan to start working on ModemManagerQt after the new year. If you want to move it to kde/workspace for now I'm fine with it, but it's not necessary as we move it to frameworks later. > Touchpad KCM, ported to KF5 by Rajeesh K Nambiar > https://projects.kde.org/projects/playground/utils/kcm-touchpad > > sddm-kcm is already in > http://thread.gmane.org/gmane.comp.kde.devel.core/84629 > > polkit-kde already requested on this list > http://thread.gmane.org/gmane.comp.kde.devel.general/68224/focus=85357 > > It has also been suggested that ksshaskpass should moved to kde/workspace > for release with Plasma (currently it has no home and is looking for one), > anyone have an opinion on whether it should be part of the desktop or > applications? > http://thread.gmane.org/gmane.comp.kde.devel.core/85039 > > I'll ask for the ones in playground to be moved to kdereview now so URLs > may change. > > Jonathan Regards, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Change in plasma-framework[master]: migrate to KPackage
Marco Martin has uploaded a new change for review.
https://gerrit.vesnicky.cesnet.cz/r/260
Change subject: migrate to KPackage
..
migrate to KPackage
Plasma::Package internally uses KPackage, being a pure wrapper.
old client code and old packagestructures still work using the wrapper.
old workspace code that is not directly using kpackage continues to work
correctly
Change-Id: I05f95e8d05e3b67759973c4009e3753c61b1dcce
---
M CMakeLists.txt
M src/plasma/CMakeLists.txt
M src/plasma/applet.cpp
M src/plasma/applet.h
M src/plasma/corona.cpp
M src/plasma/corona.h
M src/plasma/package.cpp
M src/plasma/package.h
M src/plasma/packagestructure.cpp
M src/plasma/packagestructure.h
M src/plasma/pluginloader.cpp
M src/plasma/private/applet_p.cpp
M src/plasma/private/applet_p.h
M src/plasma/private/corona_p.h
M src/plasma/private/package_p.h
D src/plasma/private/packagejob.cpp
D src/plasma/private/packagejob_p.h
D src/plasma/private/packagejobthread.cpp
D src/plasma/private/packagejobthread_p.h
M src/plasma/private/packages.cpp
M src/plasma/private/packages_p.h
A src/plasma/private/packagestructure_p.h
M src/plasmaquick/packageurlinterceptor.cpp
23 files changed, 345 insertions(+), 1,455 deletions(-)
git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework
refs/changes/60/260/1
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ccec0ed..891183c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -59,6 +59,7 @@
find_package(KF5WindowSystem ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5XmlGui ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5Notifications ${KF5_DEP_VERSION} REQUIRED)
+find_package(KF5Package ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5DocTools ${KF5_DEP_VERSION})
set_package_properties(KF5DocTools PROPERTIES DESCRIPTION "Tools to generate
documentation"
diff --git a/src/plasma/CMakeLists.txt b/src/plasma/CMakeLists.txt
index f7aa38b..423b3e7 100644
--- a/src/plasma/CMakeLists.txt
+++ b/src/plasma/CMakeLists.txt
@@ -66,8 +66,6 @@
#packages
package.cpp
packagestructure.cpp
-private/packagejob.cpp
-private/packagejobthread.cpp
private/packages.cpp
#graphics
@@ -112,6 +110,7 @@
PUBLIC
KF5::Service # For kplugininfo.h and kservice.h
Qt5::Gui
+KF5::Package
PRIVATE
Qt5::Sql
Qt5::Svg
diff --git a/src/plasma/applet.cpp b/src/plasma/applet.cpp
index 5594bf8..1793a94 100644
--- a/src/plasma/applet.cpp
+++ b/src/plasma/applet.cpp
@@ -287,7 +287,12 @@
Package Applet::package() const
{
-return d->package ? *d->package : Package();
+return d->legacyPackage ? *d->legacyPackage : Package();
+}
+
+KPackage::Package Applet::kPackage() const
+{
+return d->package ? *d->package : KPackage::Package();
}
void Applet::updateConstraints(Plasma::Types::Constraints constraints)
diff --git a/src/plasma/applet.h b/src/plasma/applet.h
index a30a7ac..daff8df 100644
--- a/src/plasma/applet.h
+++ b/src/plasma/applet.h
@@ -33,6 +33,8 @@
#include
#include
+#include
+
class KActionCollection;
class KConfigLoader;
@@ -224,13 +226,26 @@
void setUserConfiguring(bool configuring);
//UTILS
+#ifndef PLASMA_NO_DEPRECATED
+/**
+ * Accessor for the associated Package object if any.
+ * Generally, only Plasmoids come in a Package.
+ * Deprecated: please use kPackage()
+ *
+ * @deprecated use kPackage() instead
+ * @return the Package object, or an invalid one if none
+ **/
+PLASMA_DEPRECATED Package package() const;
+#endif
+
/**
* Accessor for the associated Package object if any.
* Generally, only Plasmoids come in a Package.
*
* @return the Package object, or an invalid one if none
+ * @since 5.5
**/
-Package package() const;
+KPackage::Package kPackage() const;
/**
* Called when any of the geometry constraints have been updated.
diff --git a/src/plasma/corona.cpp b/src/plasma/corona.cpp
index 038be7b..b04a510 100644
--- a/src/plasma/corona.cpp
+++ b/src/plasma/corona.cpp
@@ -38,8 +38,10 @@
#include "containment.h"
#include "pluginloader.h"
+#include "packagestructure.h"
#include "private/applet_p.h"
#include "private/containment_p.h"
+#include "private/package_p.h"
#include "private/timetracker.h"
using namespace Plasma;
@@ -71,15 +73,28 @@
Plasma::Package Corona::package() const
{
-return d->package;
+return d->legacyPackage;
}
void Corona::setPackage(const Plasma::Package &package)
{
-d->package = package;
+d->legacyPackage = package;
emit packageChanged(package);
}
+KPackage::Package Corona::kPackage() const
+{
+return d->package;
+}
+
+void Corona::setKPackage(const KPackage::Package &package)
+{
+d->package = package;
+d->legacyPackage = Package(new PackageStructure());
+d->legacyPackage.d->internalPackage = new KPackage::Package(package);
+emit kPackageChanged(package);
+}
+
void Corona::saveLayout(const
Re: Plasma 5.2 bits for kdereview
On Friday, December 19, 2014 18:46:11 Luigi Toscano wrote: > > kscreen and libkscreen maintained by Dan Vrátil. libkscreen is already > > released with Plasma but isn't in kde/workspace. > > > > https://projects.kde.org/projects/extragear/libs/libkscreen > > https://projects.kde.org/projects/extragear/base/kscreen > > I disagree with moving libkscreen to kde/workspace. It is a dependency for > at least one application (Okular), which has no Framework version for now > but it will have it. It would make more sense to have libkscreen in > Frameworks, like libnm* libkscreen is not ready for that, currently. It's not API stable enough to warrant such a step. It is used mainly in Plasma, but also by others (you name Okular). I don't see that as a problem, you won't have to install all of Plasma just to get libkscreen. It's at least a much better place to be grouped under than "playground". If you're still against moving it from playground, where would you rather see it? Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.2 bits for kdereview
Sebastian Kügler ha scritto:
> On Friday, December 19, 2014 18:46:11 Luigi Toscano wrote:
>>> kscreen and libkscreen maintained by Dan Vrátil. libkscreen is already
>>> released with Plasma but isn't in kde/workspace.
>>>
>>> https://projects.kde.org/projects/extragear/libs/libkscreen
>>> https://projects.kde.org/projects/extragear/base/kscreen
>>
>> I disagree with moving libkscreen to kde/workspace. It is a dependency for
>> at least one application (Okular), which has no Framework version for now
>> but it will have it. It would make more sense to have libkscreen in
>> Frameworks, like libnm*
>
> libkscreen is not ready for that, currently. It's not API stable enough to
> warrant such a step. It is used mainly in Plasma, but also by others (you
> name
> Okular). I don't see that as a problem, you won't have to install all of
> Plasma just to get libkscreen. It's at least a much better place to be
> grouped
> under than "playground".
>
> If you're still against moving it from playground, where would you rather see
> it?
I'm not sure that playground is the right place (even if "extragear" is more
appropriate, given that it's a software with regular releases).
libkscreen is in the same situation of baloo: not a Frameworks, but a generic
library that can be used by applications. Right now baloo is in the "kdelibs"
module, which is an unfortunate event too IMHO.
On the other side we have something like phonon, which is kdesupport.
It's a bit complicated situation. I think that we miss - or we should even
discuss - the placement of common libraries which are useful for everyone, but
they not stable enough to be part of Frameworks (the proper place). We have
some libraries in submodules, see kdegraphics or kdeedu for example, but
sometimes the boundary is a bit blurry, see the discussion about the placement
for libkgeomap on kde-core-devel@.
What's wrong with extragear/libs in the first place for those libraries?
Otherwise, a generic common-libs namespace ? Or some other name ("libs" enough
is a bit too generic maybe).
Ciao
--
Luigi
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342169] sddm theme: Session combobox's text is white
https://bugs.kde.org/show_bug.cgi?id=342169 Christoph Feck changed: What|Removed |Added Assignee|plasma-b...@kde.org |plasma-devel@kde.org Version|5.1.2 |unspecified Target Milestone|1.0 |--- Component|Look & Feel package |general Product|plasmashell |Breeze -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342169] sddm theme: Session combobox's text is white
https://bugs.kde.org/show_bug.cgi?id=342169 David Edmundson changed: What|Removed |Added Resolution|--- |FIXED CC||k...@davidedmundson.co.uk Status|UNCONFIRMED |RESOLVED --- Comment #1 from David Edmundson --- Thanks, it was a bug in the combo box that I fixed last week. -- You are receiving this mail because: You are the assignee for the bug. Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340892] System Settings's Power management complains about power management service
https://bugs.kde.org/show_bug.cgi?id=340892 Valerio De Angelis changed: What|Removed |Added CC||valeriod...@yahoo.it --- Comment #3 from Valerio De Angelis --- I can confirm this bug. F21, Plasma 5.1.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
