Re: Review Request 121761: Fix build on FreeBSD
On Dec. 31, 2014, 3:19 p.m., Pino Toscano wrote: ksmserver/screenlocker/greeter/autotests/killtest.cpp, lines 79-82 https://git.reviewboard.kde.org/r/121761/diff/1/?file=337442#file337442line79 This (and all the other cases of this) should rather be: ``` #ifdef SIGUNUSED ... #endif ``` so the code using this signal is built when it is available, not just on Linux/$OS. that's just a unit test, let's not make it too complicated. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/#review72846 --- On Dec. 30, 2014, 7:33 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/ --- (Updated Dec. 30, 2014, 7:33 p.m.) Review request for Plasma and Raphael Kubo da Costa. Repository: plasma-workspace Description --- Add missing errno.h include Wrap Linux-only signals in #ifdef Q_OS_LINUX Fix build with X11 not installed to /usr Diffs - drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af ksmserver/screenlocker/greeter/authenticator.cpp ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a ksmserver/screenlocker/greeter/autotests/killtest.cpp 6f2ef114459b5d641e357f3a817b82e7af2e72a3 libkworkspace/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1 Diff: https://git.reviewboard.kde.org/r/121761/diff/ Testing --- compiles, still compiles on linux Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121763: Fix build on FreeBSD
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/#review72900 --- Ship it! Modules/info/CMakeLists.txt https://git.reviewboard.kde.org/r/121763/#comment50751 just out of interest: is devinfo a FreeBSD only library or is it of interest for more non-Linux variants? - Martin Gräßlin On Dec. 30, 2014, 7:48 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/ --- (Updated Dec. 30, 2014, 7:48 p.m.) Review request for Plasma and Raphael Kubo da Costa. Repository: kinfocenter Description --- We can't call the KCM devinfo there since we need to link against -ldevinfo and CMake would try to link to the KCM instead of the library in that case. Diffs - Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9 Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 Diff: https://git.reviewboard.kde.org/r/121763/diff/ Testing --- Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Black Screen on Login
Apparently there's a bug, supposedly with kscreen (unconfirmed), that means as login as a new user you will be greeted with a black screen with plasmashell not drawing any windows. I've heard multiple people comment on various channels, but it seems no-one has had the sense to file a proper bug report so I'm commenting here. If someone can still reproduce this issue can you all please attach _all_ possible information so we can try to find a pattern. Pastebins on IRC really are not enough as they tend to get lost. This bug is super critical so it should be everyone's number 1 priority for the moment. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121301: Expose OSD window type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/ --- Review request for Plasma. Repository: plasma-framework Description --- This exposes the new OSD window type. I will change the OSD in the look and feel package accordingly. Diffs - src/plasmaquick/dialog.h 64930fb Diff: https://git.reviewboard.kde.org/r/121301/diff/ Testing --- I finally have volume and brightness feedback again when watching a movie \o/ Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #6 from Martin Gräßlin mgraess...@kde.org --- (In reply to Kai Uwe Broulik from comment #2) Martin, could (should) we abuse the KScreen effect for this? certainly -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-workspace_stable_qt5 #20
See http://build.kde.org/job/plasma-workspace_stable_qt5/20/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor
*bump* nobody got an idea? 2014-12-29 13:45 GMT+01:00 Philipp A. flying-sh...@web.de: 2014-12-29 10:23 GMT+01:00 Marco Martin notm...@gmail.com: does it load when installed? yes. i think it’s the way that plasmoidviewer loads it that breaks, see my other mail, where i changed the interceptor to allow these requests and still get errors: 2014-12-28 21:21 GMT+01:00 Philipp A. flying-sh...@web.de: aha, so the problem seems to be that when loaded via plasmoidviewer m_package.metadata().pluginName() == org.kde.desktopcontainment when using a custom interceptor to circumvent it, i still get strange errors. can someone help? QML debugging is enabled. Only use this in a safe environment. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Plasma/FocusFrameStyle.qml: File not found file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth qml: View QML loaded kf5.kservice.sycoca: Trying to open ksycoca from /home/phil/.cache/ksycoca5 Trying to use rootObject before initialization is completed, whilst using setInitializationDelayed. Forcing completion Plasmoidviewer detected: circumventing security QUrl( file:///home/phil/Dev/KDE/steam-plasmoid/build/org/kde/plasma/private/steam/qmldir ) Plasmoidviewer detected: circumventing security QUrl( file:///home/phil/Dev/KDE/steam-plasmoid/build/org/kde/plasma/private/steam/qmldir ) Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. qml: New Containment: ContainmentInterface(0x194b390) QQmlComponent: Component is not ready QCoreApplication::postEvent: Unexpected null receiver file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/applet/AppletError.qml Error loading QML file. File not found Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from
Re: Review Request 121790: Port plasmasehll away from kscreen
On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Lukáš Tinkl wrote: Ugh, that's nasty, I wasn't aware of this bug... Aleix Pol Gonzalez wrote: Yes, well, I don't know. People keep discussing the dependency of KScreen as if it was something that happened because there was an explicit interest for using it. I spent quite some time with the port and it was (and still is) the only option. Fixing Qt is possible, but I'm quite sure it won't happen if we don't make it happen. Changing hte Plasma side, is indeed the easy part. ok, so focus on Qt part for now.. tough let's keep this open, that i would like having this merged when will be possible :) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. I appreciate a good theory. 3 I just added a warning that will output something if the GetConfigOperation fails. All those of you who can reproduce it, should rebuild and run again. Maybe we'll see the answer there. Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for plasmashell to show up (because of the notifications it wants to display). Eventually the dbus calls time out, plasmashell start but as there is no config, you just get a black screen. After updating powerdevil, I can no longer reproduce this; kscreen is broken in a different way (doesn't apply the config) but that's another story -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. I appreciate a good theory. 3 I just added a warning that will output something if the GetConfigOperation fails. All those of you who can reproduce it, should rebuild and run again. Maybe we'll see the answer there. Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342420] New: Provide default wallpaper in png format
https://bugs.kde.org/show_bug.cgi?id=342420 Bug ID: 342420 Summary: Provide default wallpaper in png format Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: grave Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: hrvoje.sen...@gmail.com Plasma tries to load wallpaper in that format, but currently git master of new wallpaper has them in jpg format. Changing the suffix in plasma-framework is not wise, as that will break Plasma 5.1.x Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns
On Fri, Jan 2, 2015 at 10:13 PM, David Edmundson da...@davidedmundson.co.uk wrote: Won't these messages will get eaten by our noMessageOutput message handler on login anyway? To workaround edit plasmashell.desktop to remove --shut-up Exec=plasmashell --shut-up to Exec=plasmashell -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342420] Provide default wallpaper in png format
https://bugs.kde.org/show_bug.cgi?id=342420 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added CC||k...@davidedmundson.co.uk Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns
Won't these messages will get eaten by our noMessageOutput message handler on login anyway? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns
If that still works fine, why was this argument added? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/#review72925 --- @Kai Uwe: you added a signal somewhere for non-logind systems. How can I adjust this change to make use of it? - Martin Gräßlin On Dec. 15, 2014, 11:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/ --- (Updated Dec. 15, 2014, 11:18 a.m.) Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace Description --- [ksld] ScreenLocker inhibits sleep on logind When the system is going to sleep we want to ensure that the screen gets locked before the system goes to sleep. Logind provides the inhibitor locks which can be used for this. If logind is available ksld gains an inhibitor lock for sleep when the screen is unlocked. As soon as the screen gets locked the inhibitor lock is released. In addition it connects to the prepareForSleep signal by logind and locks the screen. The solution needs to be extended to have a config option whether the screen should be locked on sleep. Currently this is provided by powerdevil. Also the solution can only work properly if power devil uses logind's sleep dbus interface. [ksld] Don't block till the greeter is started We only want to ensure that the greeter gets started. There is no need to block for that. Instead we can connect to the error signal and unlock in case the greeter failed to start. - @Alex: what do you think is the best solution for handling the lock screen on resume config option? My idea would be to move it to screen locker and expose the value through DBus, so that powerdevil can still read it. Diffs - ksmserver/screenlocker/CMakeLists.txt 5378a10df2be70cee95b5612c23046eae639f610 ksmserver/screenlocker/autotests/CMakeLists.txt 4bff1c6b1d8fc360197c422f8d036dff3eae5efe ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg a0253d687150702aa4c22200d9f6a577d0cab6be ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 Diff: https://git.reviewboard.kde.org/r/119814/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121772: Fade panels when dashboard is shown
On Dec. 31, 2014, 11:29 a.m., Thomas Pfeiffer wrote: The more we (the VDG) think and learn about this, the more we realize that we haven't really thought it through yet. It looks like it's back to the drawing board here, as we don't want to make a change that makes as many users unhappy as it makes users happy. The whole concept of the dashboard definitely needs to be improved, but just changing one thing while leaving the rest as it is won't help, so we'll get back to you guys when we have a real, thought-through plan. Aleix Pol Gonzalez wrote: Yes, I had a conversation about that yesterday as well. I think it would be very healthy if the usability/vdg thought about the dashboard and plasma interaction in general. Thomas Pfeiffer wrote: Yes, it would, and we're on it. Stay tuned for an official announcement once we've figured out our approach to this (I expect this to be a rather big effort if we're going to do it right). Aleix Pol Gonzalez wrote: Shameless plug. Plasma sprint coming up, great place to discuss rather big efforts: https://sprints.kde.org/sprint/260 Thomas, Kai: asking a subtly different question: Any redesign is not going to get into Plamsa before 5.3. Do we want to have this in for the next 3 months or leave it like it currently is. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/#review72832 --- On Dec. 31, 2014, 10:01 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/ --- (Updated Dec. 31, 2014, 10:01 a.m.) Review request for Plasma and KDE Usability. Bugs: 342123 https://bugs.kde.org/show_bug.cgi?id=342123 Repository: plasma-desktop Description --- As suggested by the VDG. Diffs - desktoppackage/contents/views/Panel.qml 04a8e0b Diff: https://git.reviewboard.kde.org/r/121772/diff/ Testing --- Dashboard there, Panel faded; Dashboard gone, Panel there File Attachments Dashboard with dim panel https://git.reviewboard.kde.org/media/uploaded/files/2014/12/31/957bad71-2bfc-4451-b1dd-479d747f1a19__dashboardpanel2.jpg Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- (Updated Jan. 2, 2015, 11:20 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Solid and Daniel Vrátil. Repository: libkscreen Description --- Avoid risk of starting two kscreen_launchers at the same having a race condition. There were three possible bugs: CheckIsAlreadyRunning tried to register a service and check if it worked. This could clash with another process checking at the same time. Causing them both to fail saying another is running Similarly, a daemon doing actual registering could clash with another daemon just checking if the name is free, and then it would fail saying we can't init() There was also a risk that two launchers pass the check that nothing is running, then both try to activate a session. DBus server handles this fine and one will gracefully fail. Without this patch the second launcher would just die without returning the path of the service that was activated causing the relevant app to do nothing. -- IMHO, you'd be better off having a fixed service name and using DBus activation for exactly these reasons. You could put the different backends at different object paths, and have a method on the root object that says which object path to use rather than using the stdout of a launcher. That's a discussion for another day though. Diffs - src/backendlauncher/backendloader.cpp e7da8cd src/backendlauncher/main.cpp f8bf323 Diff: https://git.reviewboard.kde.org/r/121710/diff/ Testing --- Send it to bshah. Plasmashell started for him. Previously it didn't. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121763: Fix build on FreeBSD
On Jan. 2, 2015, 10:24 a.m., Martin Gräßlin wrote: Modules/info/CMakeLists.txt, lines 28-30 https://git.reviewboard.kde.org/r/121763/diff/1/?file=337463#file337463line28 just out of interest: is devinfo a FreeBSD only library or is it of interest for more non-Linux variants? It's a library that originated on FreeBSD (http://mdoc.su/f/devinfo.3) and as far as I can tell only DragonFlyBSD also uses/ships it, so I wouldn't worry about making the check more generic for now (I don't use DragonFly myself, but I remember some checks used to work for both OSes). If someone from DragonFlyBSD complains at some point, we can turn this into a proper Find module. - Raphael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/#review72900 --- On Dec. 30, 2014, 8:48 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/ --- (Updated Dec. 30, 2014, 8:48 p.m.) Review request for Plasma and Raphael Kubo da Costa. Repository: kinfocenter Description --- We can't call the KCM devinfo there since we need to link against -ldevinfo and CMake would try to link to the KCM instead of the library in that case. Diffs - Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9 Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 Diff: https://git.reviewboard.kde.org/r/121763/diff/ Testing --- Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Jan. 2, 2015, 11:30 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Widget Explorer / Activity Manager Dock type
On Friday 02 January 2015 01:56:47 Kai Uwe Broulik wrote: Hi everyone, while investigating why Widget Explorer and Activity Manager wouldn't accept any input often (the filterbox visually being focussed with blinking cursor but no way to enter anything) I found that it's using the NET::Dock window type. NET::Dock is the window type for what we in the Plasma world call a panel. That one is used by the panels, too, right? And these don't accept focus, so when plasmashell is not focussed (eg. pressing Meta+Q or opening widget explorer through the panel context menu) there is no way to get keyboard events to the respective sidebars. Any ideas? I guess they should stay Dock? (Works fine when I remove that afaics) A dock window can get focus. I do not think that there is any code in KWin which would prevent it, but I would have to check again. Anyway an application can force focus by going down to X11 level or using the KWindowSystem wrapper for it. Normally applications are not supposed to do it, but on a workspace level that's totally fine. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121476: Port showdesktop applet to Plasma Next
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72912 --- The adjustments look good to me. If we want it for the next plasma release I call it a ShipIt. If we want to delay by one release the code could be extremely simplified by making use of https://git.reviewboard.kde.org/r/121667/ - Martin Gräßlin On Dec. 19, 2014, 6:23 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- (Updated Dec. 19, 2014, 6:23 p.m.) Review request for Plasma, Bhushan Shah, Martin Gräßlin, and Vishesh Handa. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs - applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 config-kdeplasma-addons.h.cmake PRE-CREATION CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121530: Remove lock screen on suspend
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/#review72924 --- ping? - Martin Gräßlin On Dec. 15, 2014, 11:45 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/ --- (Updated Dec. 15, 2014, 11:45 a.m.) Review request for Plasma and Solid. Repository: powerdevil Description --- This is handled internally in the screenlocker daemon using logind. It requires that powerdevil is supending through logind, though. Diffs - daemon/actions/bundled/suspendsession.h 0c319f266ecfe6e712abe436e7891298d853c592 daemon/actions/bundled/suspendsession.cpp 7308b7e7b797438aa5e772924af0014ddc8067cd kcmodule/global/GeneralPage.cpp 1f56a6a4aa350b18bfea082c99964671154c1c31 kcmodule/global/generalPage.ui 780b701b580ea71d1218632b0596ad947576384d PowerDevilSettings.kcfg cd103c6d8da47be210b954e324bec3fc3fae5467 Diff: https://git.reviewboard.kde.org/r/121530/diff/ Testing --- it compiles. I'm not familiar enough with powerdevil to know whether this is correct. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121301: Expose OSD window type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/#review72926 --- Ship it! Ship It! - Martin Gräßlin On Jan. 2, 2015, 12:10 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/ --- (Updated Jan. 2, 2015, 12:10 p.m.) Review request for Plasma. Repository: plasma-framework Description --- This exposes the new OSD window type. I will change the OSD in the look and feel package accordingly. Diffs - src/plasmaquick/dialog.h 64930fb Diff: https://git.reviewboard.kde.org/r/121301/diff/ Testing --- I finally have volume and brightness feedback again when watching a movie \o/ Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121301: Expose OSD window type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/ --- (Updated Jan. 2, 2015, 11:18 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- This exposes the new OSD window type. I will change the OSD in the look and feel package accordingly. Diffs - src/plasmaquick/dialog.h 64930fb Diff: https://git.reviewboard.kde.org/r/121301/diff/ Testing --- I finally have volume and brightness feedback again when watching a movie \o/ Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72938 --- Definitely where we want to go long term, and if it fixes our immediate main problem then maybe we should aim for 5.2 The KScreen changes were done because QScreen had problems not just for fun. I really want to put this under some stress testing to make sure we don't regress anything. shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50771 maybe put screen-name() here too so it matches with SCREEN ADDED. Will make debugging easier. shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50772 We still need this. It's for the case where we have mirrored mode i.e two screens on top of each other. That will still happen with QScreen. shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50773 slightly offtopic, but maybe this is the cause of our original kscreen error. With the kscreen part now being out of process, we might be processing KScreens before the XCB backend of plasmashell has had a chance to load everything. Previously when it was in process we just had to wait one event loop to be sure that they were using the same data and in sync. - David Edmundson On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Dec. 11, 2014, 10:24 a.m., Marco Martin wrote: what's the status of this? Andrei Amuraritei wrote: Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and other stuff still. Marco Martin wrote: can you push your work so far in a git branch? so is easy for people to try, and eventually contribute ;) As there has been no reply, I'm going to push this into master but leave the dataengine commented out in the CMakeLists.txt. There's no point shipping it till the plasmoid is done. To me the diff looks OK. Clearly a bit of work left, but what is here seems good. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- On Oct. 17, 2014, 12:08 a.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 12:08 a.m.) Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121429: Use out-of-band communication between ksld and greeter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/ --- (Updated Jan. 2, 2015, 12:01 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Àlex Fiestas and David Edmundson. Repository: plasma-workspace Description --- The screenlocker_greet needs to tell the parent ksld process which windows it created. Ksld sends input events to these windows. So far this was based on an X property on the window. Unfortunately ksld didn't validate whether the windows tagged with this property belong to the screenlocker_greet process it started. With this change the communication for announcing windows is moved away from the X11 protocol and instead a custom Wayland protocol is used. Ksld starts a KWaylandServer when the greet process gets started. It creates anonymous unix sockets for the connection and passes one filedescriptor to the started greeter process. The check for the X property is removed in ksld and instead only windows ids passed through the Wayland socket connection are accepted. Diffs - ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 ksmserver/screenlocker/lockwindow.h 9938d201269c89a24c9c0bd6275aa5f731bb5535 ksmserver/screenlocker/lockwindow.cpp 3aa963a59e21636862f5ca59e220bbea3bd41ff9 ksmserver/screenlocker/protocols/ksld.xml PRE-CREATION ksmserver/screenlocker/waylandserver.h PRE-CREATION ksmserver/screenlocker/waylandserver.cpp PRE-CREATION ksmserver/screenlocker/greeter/greeterapp.h b92b13b63365a9026dba5d71b772dcd8c9ee3d3b ksmserver/screenlocker/greeter/greeterapp.cpp 30d1821bdba38028959f3457e900a1b32e628192 ksmserver/screenlocker/greeter/main.cpp 12e570107d0cba851b8978131d730b27924529bb ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 ksmserver/screenlocker/CMakeLists.txt 5378a10df2be70cee95b5612c23046eae639f610 ksmserver/screenlocker/greeter/CMakeLists.txt 10c473488f08354096f68784b9240392a444af5f Diff: https://git.reviewboard.kde.org/r/121429/diff/ Testing --- Running ksmserver with the patch. Lock/unlock working, my exploit is failing. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72937 --- shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50770 This fixes the panels dancing around btw :D - Lukáš Tinkl On Led. 2, 2015, 1 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Led. 2, 2015, 1 odp.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121774: Let month menu navigate in current year
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/#review72936 --- Ship it! Ship It! - Martin Klapetek On Dec. 31, 2014, 11:39 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/ --- (Updated Dec. 31, 2014, 11:39 a.m.) Review request for Plasma and Martin Klapetek. Bugs: 342327 http://bugs.kde.org/show_bug.cgi?id=342327 Repository: plasma-framework Description --- Rather than jumping back to the current year unconditionally just navigate inside the current year. We might need to add a separate year menu/spinbox somehow also. Also use the nifty Instantiator rather than 12x copy paste. Diffs - src/declarativeimports/calendar/qml/MonthMenu.qml 6b0fb96 src/declarativeimports/calendar/qml/MonthView.qml 11013a7 Diff: https://git.reviewboard.kde.org/r/121774/diff/ Testing --- Works fine, changing the month through the menu keeps the current year. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121774: Let month menu navigate in current year
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/ --- (Updated Jan. 2, 2015, 1:11 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Klapetek. Bugs: 342327 http://bugs.kde.org/show_bug.cgi?id=342327 Repository: plasma-framework Description --- Rather than jumping back to the current year unconditionally just navigate inside the current year. We might need to add a separate year menu/spinbox somehow also. Also use the nifty Instantiator rather than 12x copy paste. Diffs - src/declarativeimports/calendar/qml/MonthMenu.qml 6b0fb96 src/declarativeimports/calendar/qml/MonthView.qml 11013a7 Diff: https://git.reviewboard.kde.org/r/121774/diff/ Testing --- Works fine, changing the month through the menu keeps the current year. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #1172
See http://build.kde.org/job/plasma-workspace_master_qt5/1172/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : plasma-workspace_master_qt5 #1174
See http://build.kde.org/job/plasma-workspace_master_qt5/1174/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: plasma-workspace_master_qt5 #1173
See http://build.kde.org/job/plasma-workspace_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. I appreciate a good theory. 3 I just added a warning that will output something if the GetConfigOperation fails. All those of you who can reproduce it, should rebuild and run again. Maybe we'll see the answer there. Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for plasmashell to show up (because of the notifications it wants to display). Eventually the dbus calls time out, plasmashell start but as there is no config, you just get a black screen. After updating powerdevil, I can no longer reproduce this; kscreen is broken in a different way (doesn't apply the config) but that's another story That theory doesn't make sense - plasmashell doesn't query kded for the config. plasmashell links libkscreen, libkscreen starts it's own unique backend process for the current config then we query that. This might delay kscreen setting the screen config, but it shouldn't prevent reading the current state unless there's something else going on... -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. I appreciate a good theory. 3 I just added a warning that will output something if the GetConfigOperation fails. All those of you who can reproduce it, should rebuild and run again. Maybe we'll see the answer there. Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for plasmashell to show up (because of the notifications it wants to display). Eventually the dbus calls time out, plasmashell start but as there is no config, you just get a black screen. After updating powerdevil, I can no longer reproduce this; kscreen is broken in a different way (doesn't apply the config) but that's another story I can't reproduce myself, that's why I just added debug information... Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns
On Fri, Jan 2, 2015 at 5:43 PM, David Edmundson da...@davidedmundson.co.uk wrote: Won't these messages will get eaten by our noMessageOutput message handler on login anyway? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel No, because it's a warning. The shut-up thing only blocks debugs. I wouldn't remove it just yet. There's still plenty of output that it's not very useful and probably should be removing. i.e. there's plenty of networkmanager stuff going on there. Maybe what we want to do, though, is this: QLoggingCategory::setFilterRules(QStringLiteral(*.debug=false\ndefault.debug=true\n)); Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for plasmashell to show up (because of the notifications it wants to display). Eventually the dbus calls time out, plasmashell start but as there is no config, you just get a black screen. Notifications should (and do here) fall back to KPassivePopup if the service is not on the bus, it's not waiting for it to appear. Or did you mean other notifications? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342420] Provide default wallpaper in png format
https://bugs.kde.org/show_bug.cgi?id=342420 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #3 from Andrew Lake jamboar...@gmail.com --- Thanks much David. The jpg versions have been repaced with the png version of the wallpapers are now in breeze master. I'll mark it resolved. -- You are receiving this mail because: You are the assignee for the bug. Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342420] Provide default wallpaper in png format
https://bugs.kde.org/show_bug.cgi?id=342420 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added CC||jamboar...@gmail.com --- Comment #1 from Andrew Lake jamboar...@gmail.com --- Is any VDG effort needed to resolve this or does the dev team already have the wallpaper assets necessary to convert to png? Let us know if there's anything we need to do? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342420] Provide default wallpaper in png format
https://bugs.kde.org/show_bug.cgi?id=342420 --- Comment #2 from David Edmundson k...@davidedmundson.co.uk --- I don't have the original assets. I could convert the JPEGs but that'd be a bit silly. Marco made the commit: updated version of the default wallpaper from the KDE VDG I don't know if he did the exporting or someone else did. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns
The handler is:
void noMessageOutput(QtMsgType type, const char *msg)
{
Q_UNUSED(type);
Q_UNUSED(msg);
}
that's going to block warnings too.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns
Oh, it was added because there was that weird Qt bug that used to flood the logs (pre 5.2) Any objections to me removing it? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121772: Fade panels when dashboard is shown
On Dez. 31, 2014, 11:29 vorm., Thomas Pfeiffer wrote: The more we (the VDG) think and learn about this, the more we realize that we haven't really thought it through yet. It looks like it's back to the drawing board here, as we don't want to make a change that makes as many users unhappy as it makes users happy. The whole concept of the dashboard definitely needs to be improved, but just changing one thing while leaving the rest as it is won't help, so we'll get back to you guys when we have a real, thought-through plan. Aleix Pol Gonzalez wrote: Yes, I had a conversation about that yesterday as well. I think it would be very healthy if the usability/vdg thought about the dashboard and plasma interaction in general. Thomas Pfeiffer wrote: Yes, it would, and we're on it. Stay tuned for an official announcement once we've figured out our approach to this (I expect this to be a rather big effort if we're going to do it right). Aleix Pol Gonzalez wrote: Shameless plug. Plasma sprint coming up, great place to discuss rather big efforts: https://sprints.kde.org/sprint/260 David Edmundson wrote: Thomas, Kai: asking a subtly different question: Any redesign is not going to get into Plamsa before 5.3. Do we want to have this in for the next 3 months or leave it like it currently is. I think we shouldn't do any half-baked sort of thing, so rather leave it as is and then we can come up with something awesome™ later. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/#review72832 --- On Dez. 31, 2014, 10:01 vorm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/ --- (Updated Dez. 31, 2014, 10:01 vorm.) Review request for Plasma and KDE Usability. Bugs: 342123 https://bugs.kde.org/show_bug.cgi?id=342123 Repository: plasma-desktop Description --- As suggested by the VDG. Diffs - desktoppackage/contents/views/Panel.qml 04a8e0b Diff: https://git.reviewboard.kde.org/r/121772/diff/ Testing --- Dashboard there, Panel faded; Dashboard gone, Panel there File Attachments Dashboard with dim panel https://git.reviewboard.kde.org/media/uploaded/files/2014/12/31/957bad71-2bfc-4451-b1dd-479d747f1a19__dashboardpanel2.jpg Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Lukáš Tinkl wrote: Ugh, that's nasty, I wasn't aware of this bug... Yes, well, I don't know. People keep discussing the dependency of KScreen as if it was something that happened because there was an explicit interest for using it. I spent quite some time with the port and it was (and still is) the only option. Fixing Qt is possible, but I'm quite sure it won't happen if we don't make it happen. Changing hte Plasma side, is indeed the easy part. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Change in plasma-framework[master]: Add HiddenAction in Plasma::Types::ActionType
Bhushan Shah has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/301 Change subject: Add HiddenAction in Plasma::Types::ActionType .. Add HiddenAction in Plasma::Types::ActionType This is to hide actions from menu or toolbox but still having action enabled. Setting visible property to false disables it and hence global shortcut to. This is clean solution to hide action and as well as keeping it up to date. CCBUG: 342186 Change-Id: Ib4e310ba0ebdfcef90e38be542b38f613a6188fa --- M src/plasma/plasma.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/01/301/1 diff --git a/src/plasma/plasma.h b/src/plasma/plasma.h index 15c346b..3ad6327 100644 --- a/src/plasma/plasma.h +++ b/src/plasma/plasma.h @@ -113,7 +113,8 @@ ControlAction = 200, /** Generic control, similar to ConfigureAction TODO: better doc */ MiscAction = 300, /** A type of action that doesn't fit in the oher categories */ DestructiveAction = 400, /** A dangerous action, such as deletion of objects, plasmoids and files. They are intended to be shown separed from other actions */ -UserAction = DestructiveAction + 1000 /** If new types are needed in a C++ implementation, define them as ids more than UserAction*/ +HiddenAction = 500, /** This can be used to have hidden from view but enabled action */ +UserAction = HiddenAction + 1000 /** If new types are needed in a C++ implementation, define them as ids more than UserAction*/ }; Q_ENUMS(ActionType) -- To view, visit https://gerrit.vesnicky.cesnet.cz/r/301 To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4e310ba0ebdfcef90e38be542b38f613a6188fa Gerrit-PatchSet: 1 Gerrit-Project: plasma-framework Gerrit-Branch: master Gerrit-Owner: Bhushan Shah bhus...@gmail.com Gerrit-Reviewer: Kevin Ottens er...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
On Led. 2, 2015, 3:25 odp., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Ugh, that's nasty, I wasn't aware of this bug... - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Led. 2, 2015, 1 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Led. 2, 2015, 1 odp.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 - Aleix Pol Gonzalez On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. I'll give it a go, as I've reproduced this problem once or twice. Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: what's the status of this? Andrei Amuraritei wrote: Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and other stuff still. Marco Martin wrote: can you push your work so far in a git branch? so is easy for people to try, and eventually contribute ;) David Edmundson wrote: As there has been no reply, I'm going to push this into master but leave the dataengine commented out in the CMakeLists.txt. There's no point shipping it till the plasmoid is done. To me the diff looks OK. Clearly a bit of work left, but what is here seems good. Sorry for not replying sooner, but I guess David did the better thing here. The engine works and I guess if people do really want to work on it (I still do), now they'll do it easier. On my part, I still need to get hold of the whole devel phase, so I'm slower. Thanks David. And Happy New Year to you all. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- On Jan. 2, 2015, 1:30 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Jan. 2, 2015, 1:30 p.m.) Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
Okay people, I reported this bug on bugzilla https://bugs.kde.org/show_bug.cgi?id=342431 On Sat, Jan 3, 2015 at 3:47 AM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. I appreciate a good theory. 3 I just added a warning that will output something if the GetConfigOperation fails. All those of you who can reproduce it, should rebuild and run again. Maybe we'll see the answer there. Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for plasmashell to show up (because of the notifications it wants to display). Eventually the dbus calls time out, plasmashell start but as there is no config, you just get a black screen. After updating powerdevil, I can no longer reproduce this; kscreen is broken in a different way (doesn't apply the config) but that's another story I can't reproduce myself, that's why I just added debug information... Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121360: Rework Plasma's notification positioning code
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121360/
---
(Updated Jan. 3, 2015, 1:26 a.m.)
Review request for Plasma and Kai Uwe Broulik.
Changes
---
Take 2. Reworked it a bit, used recursive QReadWriteLock instead of QMutex.
Bugs: 339732
https://bugs.kde.org/show_bug.cgi?id=339732
Repository: plasma-workspace
Description
---
There can easily be situations where the popups could overlap one another or
result in strange animations. This patch rewrites the notifications so that all
actions such as show/reposition/hide are handled from a one single place and
every action is properly queued and protected around, which makes it more
robust, more predictive and less chaotic. There's also a slight delay between
every action so it's also visually much more cleaner and easier to see what's
going on.
Diffs (updated)
-
applets/notifications/package/contents/ui/NotificationPopup.qml 4491230
applets/notifications/plugin/notificationshelper.h af8f6fa
applets/notifications/plugin/notificationshelper.cpp 425f0d6
Diff: https://git.reviewboard.kde.org/r/121360/diff/
Testing
---
Tested whole day plus stress-tested with something like for i in {1..200}; do
notify-send $i - $RANDOM $RANDOM sdf sdf sdfwefhsdjfnskdfbkwefnos igodsfgn
sodifgj asodfgnsdlfgdf g; done executed from 4 terminals at once, all works
fine and as expected.
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
