Review Request 121974: Don't invoke context menu when there is only one ContainmentAction contextualAction

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121974/
---

Review request for Plasma.


Bugs: 342702
http://bugs.kde.org/show_bug.cgi?id=342702


Repository: plasma-framework


Description
---

This fixes a broken context menu appearing when middle clicking in Plasma 
popups. That unlabled item is actually the "Paste" action. The check is taken 
straight from the containmentinterface.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp ec96224 

Diff: https://git.reviewboard.kde.org/r/121974/diff/


Testing
---

Middle clicking system tray popup now gives me a sticky note in my panel :) no 
more broken context menu.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121973: Proper plural handling for seconds in logout screen

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121973/
---

Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
---

1 seconds is even wrong for english ;)


Diffs
-

  lookandfeel/contents/components/LogoutScreen.qml 511dac3 

Diff: https://git.reviewboard.kde.org/r/121973/diff/


Testing
---

It now works


Thanks,

Albert Astals Cid

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121945: Use i18np for plural units in the jobs applet

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121945/#review73715
---



applets/notifications/package/contents/ui/JobDetailsItem.qml


What about something like

return i18np("%2 of 1 file", "%2 of %1 files", total, processed);

and the same for dirs?


- Albert Astals Cid


On gen. 9, 2015, 1:55 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121945/
> ---
> 
> (Updated gen. 9, 2015, 1:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 342640
> https://bugs.kde.org/show_bug.cgi?id=342640
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Yesterday came a bug report about using non-plural i18n for the jobs unit. We 
> need to use plural so that some locales may provide different variations for 
> different numbers.
> 
> For example Czech has
> 1 soubor
> 2 soubory
> ...
> 5 soubor?
> ...
> 
> Unfortunately this came with the string freeze for 5.2, but I think this 
> would be nice to have for 5.2. I'll ask for an exception (and review).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 
> 
> Diff: https://git.reviewboard.kde.org/r/121945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: RFC: Use Grid as default for KWin's Presnt windows effect

[Martin Gräßlin]

On Saturday 10 January 2015 17:54:34 Martin Klapetek wrote:
> On Sat, Jan 10, 2015 at 4:31 PM, Martin Gräßlin  wrote:
> > -2
> > 
> > The reason for the natural layout is that the other layout sucks. That was
> > what we shipped with in 4.0 and 4.1. Let's learn from history and don't
> > repeat
> > it .
> 
> What was the history? I was not around at that time. Is there a thread
> somewhere?

It's years ago (2008 or 2009). I don't know whether there was a thread about 
it or whether there was IRC discussion or bug reports.

> 
> Also what exactly does suck about it?

The problems with the non natural layouts are various, e.g.:
* windows might get too small as all windows have same size
* windows might move to a bad position, e.g. a window from the top left goes 
to bottom right

The natural layout tries to optimize that by using an algorithm using size and 
position as reference. The downside is that the layout might appear to be 
random. But so would a movement all across the screen look random.

> Can it be improved without a full
> rewrite?

It needs a full rewrite no matter what :-)

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Use Grid as default for KWin's Presnt windows effect

[Martin Klapetek]

On Sat, Jan 10, 2015 at 4:31 PM, Martin Gräßlin  wrote:

>
> -2
>
> The reason for the natural layout is that the other layout sucks. That was
> what we shipped with in 4.0 and 4.1. Let's learn from history and don't
> repeat
> it .
>

What was the history? I was not around at that time. Is there a thread
somewhere?

Also what exactly does suck about it? Can it be improved without a full
rewrite?

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120878: Remove unused header

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/
---

(Updated Jan. 10, 2015, 4:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Plasma.


Repository: krunner


Description
---

Since scripting/runnerscript.cpp is not compiled, we get a linking error by 
exporting but not defining RunnerScript.


Diffs
-

  src/abstractrunner.cpp 4da0394 

Diff: https://git.reviewboard.kde.org/r/120878/diff/


Testing
---

Tested building using MSVC 64bit


Thanks,

Andrius da Costa Ribas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Use Grid as default for KWin's Presnt windows effect

[Martin Gräßlin]

On Friday 09 January 2015 17:16:56 Martin Klapetek wrote:
> Hey there,
> 
> so I've been thinking about the Present Windows effect of KWin. The default
> setting for laying the windows out is currently "Natural", but to me that
> layout looks rather random as the windows are scattered all around with
> different sizes and for me personally it's always hard jumping with eyes
> all over the screen.
> 
> Pic here: http://paste.opensuse.org/images/1f043922.png
> 
> Switching to Regular grid makes the layout more uniform, better aligned,
> predictable and somewhat consistent. Given that Plasma5 is now all about
> pixel-perfection and streamlineing, this change imo fits into that.
> 
> Pic here: http://paste.opensuse.org/images/ac9f8f90.png
> 
> So I'd like to propose changing the default of Present Windows effect to
> the grid setting.
> 
> What do you think?

-2

The reason for the natural layout is that the other layout sucks. That was 
what we shipped with in 4.0 and 4.1. Let's learn from history and don't repeat 
it .

I have asked for a rewrite for Present Windows/Desktop Grid for a long time. 
It just needs someone coming up with a good design (thread on VDG forum exists 
but died out) and implement it in QML. That's the way to do it, changing 
defaults doesn't improve the situation.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel