Re: Re: 5.2 Bugs and Missing Features

[Martin Gräßlin]

On Wednesday 14 January 2015 00:33:05 Aleix Pol wrote:
> On Tue, Jan 13, 2015 at 12:52 PM, Jonathan Riddell  wrote:
> > Please add any notable bugs in Plasma 5.2 here
> > 
> >  https://community.kde.org/Plasma/5.2_Errata
> > 
> > Please check over the 5.1 errata page to see if any should be copied over
> > 
> >  https://community.kde.org/Plasma/5.1_Errata
> > 
> > Jonathan
> 
> Hi,
> I don't really understand the Performance explanation over there.
> If there's a case we don't perform properly (for example: Nvidia x954
> with mesa 17.14) then we name it, but saying [1] and [2] is far too
> vague and sounds like a cheeky "I told you so in the errata page
> move".
> 
> My proposal: if we know when it doesn't work, we list it or put up
> with it. If it's a problem and it's not listed, people can still
> report it and maybe even help.

I'm for removing that block completely. It's copied from previous releases and 
I don't think it applies any more. With Plasma 5.2 and Qt 5.4 we reached that 
point where "future releases brought us significant performance improvements".

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.2 Bugs and Missing Features

[Aleix Pol]

On Tue, Jan 13, 2015 at 12:52 PM, Jonathan Riddell  wrote:
> Please add any notable bugs in Plasma 5.2 here
>  https://community.kde.org/Plasma/5.2_Errata
>
> Please check over the 5.1 errata page to see if any should be copied over
>  https://community.kde.org/Plasma/5.1_Errata
>
> Jonathan

Hi,
I don't really understand the Performance explanation over there.
If there's a case we don't perform properly (for example: Nvidia x954
with mesa 17.14) then we name it, but saying [1] and [2] is far too
vague and sounds like a cheeky "I told you so in the errata page
move".

My proposal: if we know when it doesn't work, we list it or put up
with it. If it's a problem and it's not listed, people can still
report it and maybe even help.

Aleix

[1] While it has great potential, it takes time to wrangle this out of
it and the underlying stack is not entirely ready for this either.
[2] Future releases are expected to bring significant performance
improvements thanks to fixes at all levels.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121945: Use i18np for plural units in the jobs applet

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121945/#review73971
---

Ship it!


Ship It!

- Albert Astals Cid


On gen. 13, 2015, 11:34 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121945/
> ---
> 
> (Updated gen. 13, 2015, 11:34 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 342640
> https://bugs.kde.org/show_bug.cgi?id=342640
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Yesterday came a bug report about using non-plural i18n for the jobs unit. We 
> need to use plural so that some locales may provide different variations for 
> different numbers.
> 
> For example Czech has
> 1 soubor
> 2 soubory
> ...
> 5 soubor?
> ...
> 
> Unfortunately this came with the string freeze for 5.2, but I think this 
> would be nice to have for 5.2. I'll ask for an exception (and review).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 
> 
> Diff: https://git.reviewboard.kde.org/r/121945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.2 features

[David Edmundson]

​For future, can we start this promo process earlier. Trying to do it all
in one day makes it all ridiculously rushed.

This one features a screenshot that a few people explicitly said not to
use, that's why I was busy redoing all of the other ones I sent you split
up.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1217

[KDE CI System]

See 

Changes:

[kde] Show cumulative battery percentage on lock screen

--
[...truncated 2394 lines...]
:52:93:
 warning: ‘QString Plasma::Package::filePath(const char*, const QString&) 
const’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:144)
 [-Wdeprecated-declarations]
 KConfigGroup lnfCfg = 
KConfigGroup(KSharedConfig::openConfig(package.filePath("defaults")), "Theme");

 ^
:55:97:
 warning: ‘QString Plasma::Package::filePath(const char*, const QString&) 
const’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:144)
 [-Wdeprecated-declarations]
 m_desktopDefaultsConfig = 
KConfigGroup(KSharedConfig::openConfig(package.filePath("defaults")), 
"Desktop");

 ^
:
 In member function ‘virtual void StandaloneAppCorona::loadDefaultLayout()’:
:119:36:
 warning: ‘Plasma::Package Plasma::Corona::package() const’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/corona.h:64)
 [-Wdeprecated-declarations]
 const QString script = package().filePath("defaultlayout");
^
:119:62:
 warning: ‘QString Plasma::Package::filePath(const char*, const QString&) 
const’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:144)
 [-Wdeprecated-declarations]
 const QString script = package().filePath("defaultlayout");
  ^
[ 34%] Built target kded_freespacenotifier
[ 34%] Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/modeltest.cpp.o
[ 35%] : 
In constructor ‘Osd::Osd(ShellCorona*)’:
:35:82: 
warning: ‘QString Plasma::Package::filePath(const char*, const QString&) const’ 
is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:144)
 [-Wdeprecated-declarations]
 const QString osdPath = 
corona->lookAndFeelPackage().filePath("osdmainscript");

  ^
Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/__/historymodel.cpp.o
[ 35%] Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/__/historyimageitem.cpp.o
[ 35%] [ 35%] Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/__/historyitem.cpp.o
Building CXX object klipper/CMakeFiles/kdeinit_klipper.dir/history.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/plasma_engine_clipboard.dir/urlgrabber.cpp.o
[ 36%] Building CXX object 
shell/CMakeFiles/plasmashell.dir/scripting/appinterface.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/historyitem.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/plasma_engine_clipboard.dir/configdialog.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/historymodel.cpp.o
[ 36%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/history.cpp.o
[ 36%] [ 36%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/historystringitem.cpp.o
Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/__/historystringitem.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/klipperpopup.cpp.o
[ 37%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/popupproxy.cpp.o
[ 38%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/historyimageitem.cpp.o
[ 38%] [ 38%] [ 38%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/historyitem.cpp.o
[ 38%] Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/__/historyurlitem.cpp.o
Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/applet.cpp.o
Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/testHistoryModel_automoc.cpp.o
[ 38%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/historyim

Re: Review Request 122044: Show cumulative battery percentage on lock screen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122044/
---

(Updated Jan. 13, 2015, 8:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Rather than just picking a random battery, which could be your mouse, it now 
shows the cumulative battery percentage which is now exposed through the 
dataengine. Also use AC adapter state for the bolt to be consistent with 
battery monitor.


Diffs
-

  lookandfeel/contents/components/InfoPane.qml 02b5ec9 

Diff: https://git.reviewboard.kde.org/r/122044/diff/


Testing
---

I only have one battery here but it shows 99% as it is supposed to, plugging in 
and out the AC changes the bolt's color.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122044: Show cumulative battery percentage on lock screen

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122044/#review73962
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 13, 2015, 9:45 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122044/
> ---
> 
> (Updated Led. 13, 2015, 9:45 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Rather than just picking a random battery, which could be your mouse, it now 
> shows the cumulative battery percentage which is now exposed through the 
> dataengine. Also use AC adapter state for the bolt to be consistent with 
> battery monitor.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/InfoPane.qml 02b5ec9 
> 
> Diff: https://git.reviewboard.kde.org/r/122044/diff/
> 
> 
> Testing
> ---
> 
> I only have one battery here but it shows 99% as it is supposed to, plugging 
> in and out the AC changes the bolt's color.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122044: Show cumulative battery percentage on lock screen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122044/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Rather than just picking a random battery, which could be your mouse, it now 
shows the cumulative battery percentage which is now exposed through the 
dataengine. Also use AC adapter state for the bolt to be consistent with 
battery monitor.


Diffs
-

  lookandfeel/contents/components/InfoPane.qml 02b5ec9 

Diff: https://git.reviewboard.kde.org/r/122044/diff/


Testing
---

I only have one battery here but it shows 99% as it is supposed to, plugging in 
and out the AC changes the bolt's color.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1216

[KDE CI System]

See 

Changes:

[kde] Use Solid::Battery energyFull rather than deducing it from the capacity

[kde] Revamp battery cumulative handling and clean up

--
[...truncated 2428 lines...]

 ^
:459:38:
 warning: ‘void Plasma::Package::setPath(const QString&)’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:125)
 [-Wdeprecated-declarations]
 package.setPath(info.pluginName());
  ^
:461:61:
 warning: ‘QString Plasma::Package::filePath(const char*, const QString&) 
const’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:144)
 [-Wdeprecated-declarations]
 const QString scriptFile = package.filePath("mainscript");
 ^
:
 In static member function ‘static QStringList 
WorkspaceScripting::ScriptEngine::pendingUpdateScripts(Plasma::Corona*)’:
:869:26:
 warning: ‘Plasma::Package Plasma::Corona::package() const’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/corona.h:64)
 [-Wdeprecated-declarations]
 if (!corona->package().metadata().isValid()) {
  ^
:869:37:
 warning: ‘KPluginInfo Plasma::Package::metadata() const’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:196)
 [-Wdeprecated-declarations]
 if (!corona->package().metadata().isValid()) {
 ^
:874:45:
 warning: ‘Plasma::Package Plasma::Corona::package() const’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/corona.h:64)
 [-Wdeprecated-declarations]
 const QString appName = corona->package().metadata().pluginName();
 ^
:874:56:
 warning: ‘KPluginInfo Plasma::Package::metadata() const’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:196)
 [-Wdeprecated-declarations]
 const QString appName = corona->package().metadata().pluginName();
^
[ 36%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/urlgrabber.cpp.o
[ 36%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/history.cpp.o
[ 36%] Building CXX object 
shell/CMakeFiles/plasmashell.dir/scripting/widget.cpp.o
[ 36%] [ 36%] Building CXX object 
shell/CMakeFiles/plasmashell.dir/plasmashelladaptor.cpp.o
Building CXX object shell/CMakeFiles/plasmashell.dir/krunner_interface.cpp.o
[ 36%] Building CXX object 
shell/CMakeFiles/plasmashell.dir/plasmashell_automoc.cpp.o
Scanning dependencies of target testHistoryModel
[ 36%] Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/historymodeltest.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/plasma_engine_clipboard.dir/historymodel.cpp.o
Linking CXX shared module kded_freespacenotifier.so
:129:6:
 warning: unused parameter ‘index’ [-Wunused-parameter]
 void Widget::setIndex(int index)
  ^
:159:6:
 warning: unused parameter ‘geometry’ [-Wunused-parameter]
 void Widget::setGeometry(const QRectF &geometry)
  ^
[ 37%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/historyimageitem.cpp.o
[ 37%] Built target kded_freespacenotifier
[ 37%] Generating appadaptor.cpp, appadaptor.h
Scanning dependencies of target kcheckrunning
[ 37%] Building CXX object 
ksmserver/CMakeFiles/kcheckrunning.dir/kcheckrunning.cpp.o
[ 37%] Generating appadaptor.moc
[ 37%] Building CXX object 
ksmserver/CMakeFiles/kcheckrunning.dir/kcheckrunning_automoc.cpp.o
[ 37%] Building CXX object 
klipper/CMakeFiles/kdeinit_klipper.dir/configdialog.cpp.o
Scanning depend

Re: 5.2 features

[Martin Gräßlin]

On Tuesday 13 January 2015 14:12:19 Jonathan Riddell wrote:
> What features should we highlight in Plasma 5.2?  Bonus points if you take a
> nice screenshot of the feature.
> 
> https://www.kde.org/announcements/plasma-5.1.95.php

From KWin side I would highlight the new decoration even more. Especially 
pointing out memory, performance and stability improvements. It also might be 
an idea that not all features known from previous releases are available, but 
are planned to return in 5.3.

Also we have huge improvements in the handling of multiple monitors.

For screen locker I would point out that we improved the integration with 
logind to ensure the screen is properly locked before suspend and that it's 
the first component to use Wayland by default. Another new feature is that the 
background of the lock screen can be configured.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1215

[KDE CI System]

See 

Changes:

[scripty] SVN_SILENT made messages (.desktop file)

[aleixpol] Improve KRunner behavior on adding/removing screens

--
[...truncated 2374 lines...]
:238:90:
 warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, 
xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988)
 [-Wdeprecated-declarations]
 NETWinInfo ni(QX11Info::connection(), d->win, QX11Info::appRootWindow(), 
NET::WMState);

  ^
:
 In member function ‘void TaskManager::Task::publishIconGeometry(QRect)’:
:252:79:
 warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, 
xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988)
 [-Wdeprecated-declarations]
 NETWinInfo ni(QX11Info::connection(), d->win, QX11Info::appRootWindow(), 
0);
   ^
[ 35%] Building CXX object 
klipper/CMakeFiles/plasma_engine_clipboard.dir/urlgrabber.cpp.o
[ 35%] Built target plasmashellprivateplugin
[ 35%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/historystringitem.cpp.o
[ 35%] Building CXX object 
klipper/CMakeFiles/plasma_engine_clipboard.dir/configdialog.cpp.o
[ 35%] Building CXX object 
freespacenotifier/CMakeFiles/kded_freespacenotifier.dir/settings.cpp.o
Linking CXX shared library libtaskmanager.so
[ 35%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/historyurlitem.cpp.o
[ 35%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/__/historymodel.cpp.o
[ 35%] Built target taskmanager
[ 35%] Building CXX object shell/CMakeFiles/plasmashell.dir/shellmanager.cpp.o
[ 35%] Building CXX object 
shell/CMakeFiles/plasmashell.dir/standaloneappcorona.cpp.o
[ 35%] Building CXX object 
klipper/autotests/CMakeFiles/testHistory.dir/testHistory_automoc.cpp.o
[ 35%] Building CXX object klipper/CMakeFiles/kdeinit_klipper.dir/history.cpp.o
[ 35%] Building CXX object shell/CMakeFiles/plasmashell.dir/osd.cpp.o
[ 36%] Building CXX object 
freespacenotifier/CMakeFiles/kded_freespacenotifier.dir/kded_freespacenotifier_automoc.cpp.o
[ 36%] Building CXX object 
klipper/CMakeFiles/plasma_engine_clipboard.dir/history.cpp.o
[ 36%] Building CXX object 
shell/CMakeFiles/plasmashell.dir/scripting/appinterface.cpp.o
Linking CXX executable testHistory
Scanning dependencies of target testHistoryModel
[ 36%] Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/historymodeltest.cpp.o
[ 36%] Built target testHistory
[ 36%] : 
In constructor ‘Osd::Osd(ShellCorona*)’:
:35:82: 
warning: ‘QString Plasma::Package::filePath(const char*, const QString&) const’ 
is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:144)
 [-Wdeprecated-declarations]
 const QString osdPath = 
corona->lookAndFeelPackage().filePath("osdmainscript");

  ^
Building CXX object 
klipper/autotests/CMakeFiles/testHistoryModel.dir/modeltest.cpp.o
:
 In constructor ‘StandaloneAppCorona::StandaloneAppCorona(const QString&, 
QObject*)’:
:45:35:
 warning: ‘void Plasma::Package::setPath(const QString&)’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:125)
 [-Wdeprecated-declarations]
 package.setPath(m_coronaPlugin);
   ^
:46:39:
 warning: ‘void Plasma::Package::setAllowExternalPaths(bool)’ is deprecated 
(declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/include/KF5/plasma/package.h:289)
 [-Wdeprecated-declarations]
 package.setAllowExternalPaths(true);
   ^
:47:23:
 warning: ‘void Plasma::Corona::setPack

Re: Review Request 122040: Improve KRunner behavior on adding/removing screens

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122040/
---

(Updated Jan. 13, 2015, 3:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Vishesh Handa.


Bugs: 336616
https://bugs.kde.org/show_bug.cgi?id=336616


Repository: plasma-workspace


Description
---

Use Qt 5.4 API for screen removal which notifies us about the screen removed 
before having it removed.
Treat differently add and remove, current implementation wasn't very sensible.


Diffs
-

  krunner/view.cpp 9d33fe5 

Diff: https://git.reviewboard.kde.org/r/122040/diff/


Testing
---

Played around with it, no crashes.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122040: Improve KRunner behavior on adding/removing screens

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122040/
---

Review request for Plasma and Vishesh Handa.


Bugs: 336616
https://bugs.kde.org/show_bug.cgi?id=336616


Repository: plasma-workspace


Description
---

Use Qt 5.4 API for screen removal which notifies us about the screen removed 
before having it removed.
Treat differently add and remove, current implementation wasn't very sensible.


Diffs
-

  krunner/view.cpp 9d33fe5 

Diff: https://git.reviewboard.kde.org/r/122040/diff/


Testing
---

Played around with it, no crashes.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122040: Improve KRunner behavior on adding/removing screens

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122040/#review73946
---

Ship it!


Good job! Gold star!

- Vishesh Handa


On Jan. 13, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122040/
> ---
> 
> (Updated Jan. 13, 2015, 3:21 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Bugs: 336616
> https://bugs.kde.org/show_bug.cgi?id=336616
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Use Qt 5.4 API for screen removal which notifies us about the screen removed 
> before having it removed.
> Treat differently add and remove, current implementation wasn't very sensible.
> 
> 
> Diffs
> -
> 
>   krunner/view.cpp 9d33fe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122040/diff/
> 
> 
> Testing
> ---
> 
> Played around with it, no crashes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

5.2 features

[Jonathan Riddell]

What features should we highlight in Plasma 5.2?  Bonus points if you take a 
nice screenshot of the feature.

https://www.kde.org/announcements/plasma-5.1.95.php

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121819: Don't mess with the mouse if the dialog isn't visible

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121819/
---

(Updated Jan. 13, 2015, 12:31 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Bugs: 342444
http://bugs.kde.org/show_bug.cgi?id=342444


Repository: plasma-framework


Description
---

As a workaround for Bug 342444 the dialog should not mess with the mouse if it 
is not visible. This patch makes sense even outside of that context imho.


Diffs
-

  src/plasmaquick/dialog.cpp 74c68a6 

Diff: https://git.reviewboard.kde.org/r/121819/diff/


Testing
---

No more crash when switching between activities and moving my mouse, see test 
case in the linked bug report.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

5.2 Bugs and Missing Features

[Jonathan Riddell]

Please add any notable bugs in Plasma 5.2 here
 https://community.kde.org/Plasma/5.2_Errata

Please check over the 5.1 errata page to see if any should be copied over
 https://community.kde.org/Plasma/5.1_Errata

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121945: Use i18np for plural units in the jobs applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121945/
---

(Updated Jan. 13, 2015, 12:34 p.m.)


Review request for Plasma.


Bugs: 342640
https://bugs.kde.org/show_bug.cgi?id=342640


Repository: plasma-workspace


Description
---

Yesterday came a bug report about using non-plural i18n for the jobs unit. We 
need to use plural so that some locales may provide different variations for 
different numbers.

For example Czech has
1 soubor
2 soubory
...
5 soubor?
...

Unfortunately this came with the string freeze for 5.2, but I think this would 
be nice to have for 5.2. I'll ask for an exception (and review).


Diffs (updated)
-

  applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 

Diff: https://git.reviewboard.kde.org/r/121945/diff/


Testing
---


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

[Martin Klapetek]

> On Jan. 9, 2015, 12:25 p.m., Àlex Fiestas wrote:
> > Where do you plan to use this? We are not maintaining compatibility (so 
> > far) in our dbus apis, so why add this at all?
> 
> Daniel Vrátil wrote:
> KScreen. For now we are listening to UPower, which IMO sucks and we 
> should use PowerDevil instead (as it provides abstraction for alternative 
> backends). This makes it just easier to monitor changes.
> 
> Àlex Fiestas wrote:
> This has a few problems:
> 1-It couples KScreen more to PLasma by adding a runtime dependency (which 
> is ok if you decide to do so)
> 2-It might create a deadlock since kscreen is a kded module asking to 
> another module (powerdevil) for things.
> 3-We will depend on Powerdevil if we use kscreen in other places (sddm 
> desperatly needs something like kscreen, or kscreen itself)
> 4-Adds a dependency to an api that is not stable (so far it has not 
> been), we have changed it many times and I am sure we will change it again
> 
> My recommendation for this will be to merge the new power management api 
> in Solid and make kscreen depend on it. Solid already offers backends (so we 
> don't have to implement this in kscreen) and we don't have to expose 
> powerdevil internals.
> 
> So this is a -1 from my side (if the only reason to add this is KSCreen).
> 
> Martin Klapetek wrote:
> > 2-It might create a deadlock since kscreen is a kded module asking to 
> another module (powerdevil) for things.
> 
> As dfaure explained in https://git.reviewboard.kde.org/r/121885/ QtDbus 
> is really smart and in-process DBus calls are made into direct methods and 
> should never deadlock. Which is cool :)
> 
> Àlex Fiestas wrote:
> Oh wow! One less problem to worry about then.
> We still need to be careful not to deadlock by doing sync calls between 
> the same kded modules (happened already).

That should still work no? I mean if sync QtDBus works in-process, then it 
doesn't matter which modules it calls to as it is all the same process...right?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121915/#review73569
---


On Jan. 8, 2015, 1:04 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121915/
> ---
> 
> (Updated Jan. 8, 2015, 1:04 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> There's no way to detect when lid has been closed other than listening to 
> `changed` signal org.freedesktop.UPower and then polling the Powerdevil for 
> new values. This patch adds a new signal to the PowerDevil interface to 
> notify about the change and provide new value right away. Makes it much 
> easier to use.
> 
> 
> Diffs
> -
> 
>   daemon/org.kde.Solid.PowerManagement.xml 53f77e5 
>   daemon/powerdevilbackendinterface.h 702b66b 
>   daemon/powerdevilbackendinterface.cpp 6dd8c71 
>   daemon/powerdevilcore.h e255703 
>   daemon/powerdevilcore.cpp d51ab19 
> 
> Diff: https://git.reviewboard.kde.org/r/121915/diff/
> 
> 
> Testing
> ---
> 
> Tested with qdbus-monitor, signal is emitted when laptop lid is closed/opened.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: wayland support in plasma

[Martin Gräßlin]

On Monday 12 January 2015 17:52:55 Treeve Jelbert wrote:
> now that plasma-workspace requires wayland, is there any reason not to
> build kwin with wayland supoprt?

plasma-workspace doesn't "require" wayland. We use a custom Wayland protocol 
at one place without using Wayland as a windowing system. I will do a blog 
post about what it means exactly when we release 5.2. At the moment Plasma 
still fully requires an X11 session.

> 
> If kwin supports wayland, do I need xorg-server in order to run
> plasma-desktop?

KWin doesn't support Wayland.

> 
> 
> If not, it appears that the only user of xorg-server would be sddm. Is
> a version of sddm which only requires wayland likely?
> 
> Does kwin require a special start option in order to use wayland?

Yes, the development code for Wayland is in the kwin_wayland binary, but it 
doesn't support starting a Wayland server yet.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel