Re: Touchpad KCM - was - Re: Plasma 5.2 bits for kdereview
On Thu, Jan 1, 2015 at 8:39 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Thu, Jan 1, 2015 at 4:50 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 19 de desembre de 2014, a les 17:27:01, Jonathan Riddell va escriure: Touchpad KCM, ported to KF5 by Rajeesh K Nambiar https://projects.kde.org/projects/playground/utils/kcm-touchpad This is not a kcm, it's a kcm + a kded. The kded is partly conflicting with what ktouchpadenabler does (it's doing it worse though since the proper shortcuts are not set). I know nothing about touchpads, just tried to port it to KF5 :-) I have adapted the logic to set shortcuts from ktouchpadenabler and attached in this bug report - https://bugs.kde.org/show_bug.cgi?id=342629 Could you take a look if this is okay/sufficient? I understand you guys have decided to remove ktouchpadenabler when merging this. FWIW, it's not merged yet. It's not going to be part of 5.2 unless the rest of my review comments (other thread) are addressed within the next few days. I have no time to try this, but can you please at least fix the shortcuts? -- Rajeesh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Change in plasma-framework[master]: never resize a dialog bigger than the screen
Marco Martin has uploaded a new change for review.
https://gerrit.vesnicky.cesnet.cz/r/334
Change subject: never resize a dialog bigger than the screen
..
never resize a dialog bigger than the screen
in cases screen resolution is quite low, and font size is enormous, popups
tend to become bigger than the screen
BUG:337041
Change-Id: I840868dbd7db665a3953687977d30dd6c3b4a386
---
M src/plasmaquick/dialog.cpp
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework
refs/changes/34/334/1
diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index 8c38f47..95d9497 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -331,6 +331,9 @@
//on the scene
auto margin = frameSvgItem-fixedMargins();
int minimumWidth = mainItemLayout-property(minimumWidth).toInt() +
margin-left() + margin-right();
+if (q-screen()) {
+minimumWidth = qMin(q-screen()-availableGeometry().width(),
minimumWidth);
+}
q-contentItem()-setWidth(qMax(q-width(), minimumWidth));
q-setWidth(qMax(q-width(), minimumWidth));
@@ -354,6 +357,10 @@
//on the scene
auto margin = frameSvgItem-fixedMargins();
int minimumHeight = mainItemLayout-property(minimumHeight).toInt() +
margin-top() + margin-bottom();
+if (q-screen()) {
+minimumHeight = qMin(q-screen()-availableGeometry().height(),
minimumHeight);
+
+}
q-contentItem()-setHeight(qMax(q-height(), minimumHeight));
q-setHeight(qMax(q-height(), minimumHeight));
@@ -373,6 +380,9 @@
auto margin = frameSvgItem-fixedMargins();
int maximumWidth = mainItemLayout-property(maximumWidth).toInt() +
margin-left() + margin-right();
+if (q-screen()) {
+maximumWidth = qMin(q-screen()-availableGeometry().width(),
maximumWidth);
+}
q-contentItem()-setWidth(qMax(q-width(), maximumWidth));
q-setWidth(qMax(q-width(), maximumWidth));
@@ -392,6 +402,9 @@
auto margin = frameSvgItem-fixedMargins();
int maximumHeight = mainItemLayout-property(maximumHeight).toInt() +
margin-top() + margin-bottom();
+if (q-screen()) {
+maximumHeight = qMin(q-screen()-availableGeometry().height(),
maximumHeight);
+}
q-contentItem()-setHeight(qMax(q-height(), maximumHeight));
q-setHeight(qMin(q-height(), maximumHeight));
@@ -423,6 +436,12 @@
minimumWidth += margin-left() + margin-right();
maximumWidth += margin-left() + margin-right();
+if (q-screen()) {
+minimumWidth = qMin(q-screen()-availableGeometry().width(),
minimumWidth);
+minimumHeight = qMin(q-screen()-availableGeometry().height(),
minimumHeight);
+maximumWidth = qMin(q-screen()-availableGeometry().width(),
maximumWidth);
+maximumHeight = qMin(q-screen()-availableGeometry().height(),
maximumHeight);
+}
const QSize finalSize(qBound(minimumWidth, q-width(), maximumWidth),
qBound(minimumHeight, q-height(), maximumHeight));
--
To view, visit https://gerrit.vesnicky.cesnet.cz/r/334
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I840868dbd7db665a3953687977d30dd6c3b4a386
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Marco Martin notm...@gmail.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 Nickolay Krachkovsky krachkov...@mail.ru changed: What|Removed |Added CC||krachkov...@mail.ru --- Comment #34 from Nickolay Krachkovsky krachkov...@mail.ru --- Same for me. kded5 consumes 1 core. I'm using notebook, if I change monitor brightness cpu usage is lowered to 0%, but after time may up again. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
kio-extras kio-mtp translations collide with kdelibs4-based kio-mtp
Maybe rename the whole thing to kio-mtp5? Cheers, Albert ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_stable_qt5 #24
See http://build.kde.org/job/plasma-desktop_stable_qt5/24/changes Changes: [notmart] avoid crossing the offset and size handles [hein] Run first match on Enter/Return in search field. [vkrause] Make constants const, saves a few symbols in the .data section. [scripty] SVN_SILENT made messages (.desktop file) [hein] Fix BUG#105797: inappropriate fontconfig settings are saved when kcontrol/fonts is shown and no way to revert them [kde] Avoid text rendering outside toolbox frame when dragging from corner - edge [arysin] Take keyboard geometry into account when showing layout preview [scripty] SVN_SILENT made messages (.desktop file) [notmart] use the runner match querydata if available [hein] Add system action to manually save session. [notmart] close button at top-right on vertical panels [scripty] SVN_SILENT made messages (.desktop file) [notmart] remove binding loop [notmart] fullRepresentation is null on quit [scripty] SVN_SILENT made messages (.desktop file) [arysin] Take keyboard geometry into account when showing layout preview [arysin] port kDebug to qCDebug [arysin] port to kde frameworks (non-UI changes) [notmart] fix export dialog [arysin] resurrect restoring keyboard layouts when new keyboard device is plugged in [arysin] stop ibus daemon so it does not mess with our keyboard configuration [arysin] port layout restore to kf5 [arysin] port UI code to kf5 [arysin] port UI code to kf5 (button groups) [notmart] solve layer bug on qml side [lukas] fix broken dialog layout [montel] kdelibs4support--. Remove not necessary include moc [montel] Convert to QPushButton [kde] Read/Write ColorScheme to configGroup General instead of KDE [kde] Re-install test package if it already exists + wait for install to finish [montel] kdelibs4support--, kdelibs4support-- [montel] kdelibs4support--, convert to new connect api [jr] Update version number for 5.1.0 [notmart] fix the offset slider in vertical centered panels [notmart] don't animate move in some situations [scripty] SVN_SILENT made messages (.desktop file) [lukas] fix emptying the trash from the context menu [lukas] drop invalid config keys [lukas] drop invalid config keys [notmart] show the expanded marker only if the theme has it [amourphious1992] fixed preview for Sun models by adding include in grammar and improved preview implementation [arysin] revert back the change to pass geometry around [arysin] code formatting and renaming [jr] Update version number for 5.2 development 5.1.90 [mart] make apply button work correctly [aleixpol] Fix warnings [notmart] when resize or move buttons pressed, hide dialog [notmart] fix test [lukas] use KIO::emptyTrash(), comment out unused and expensive code [lukas] fix broken tooltip icon [lasse.liehu] Extract messages from qml files in look and feel kcm [scripty] SVN_SILENT made messages (.desktop file) [hein] Hide the sidebar separator if only one type of sidebar item is shown. [me] Add the Baloo File Search KCM [me] Add a basic doc file for the Baloo KCM [me] Baloo KCM: File Search instead of Desktop Search [me] Baloo KCM: Remove unnecessary translation domain removal [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [mgraesslin] Fix reconfiguring launch feedback [scripty] SVN_SILENT made messages (.desktop file) [sebas] Switch to favorites after a new favorite has been added [arysin] code formatting for preview files [scripty] SVN_SILENT made messages (.desktop file) [montel] Port to reverse dns desktop, kdelibs4support-- [montel] convert to new api. kdelibs4support-- [notmart] add margins into panel [kde] typo-- [yurchor] Fix typo [montel] convert to new connect api. Fix includes, fix forward declaration. kdelibs4support-- [montel] Convert to new connect api [scripty] SVN_SILENT made messages (.desktop file) [notmart] make kde4 apps react to icon theme change [mklapetek] Fix build of keyboards kcm on debian-based systems [notmart] add simple tooltips in the applet handle actions [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [notmart] fix layout [notmart] adjust margins [mgraesslin] [kcm/lookandfeel] Add support for changing WindowSwitcher [scripty] SVN_SILENT made messages (.desktop file) [notmart] recalculate borders on prefix or theme change [notmart] parse error -- [mgraesslin] [kcm/lookandfeel] Add support for changing DesktopSwitcher [notmart] correctly manage applets removal in the panel [faure] Port from KonqOperations::doPaste to KIO::paste [faure] Update from the real libkonq, to make sure nothing that was removed creates a problem here. [osterfeld] Avoid binding loop [mgraesslin] [kcms/lnf] Make a list variable const [sitter] drop libkonq_export for internal libkonq copy [jr] Update default applications
Build failed in Jenkins: plasma-workspace_stable_qt5 #23
See http://build.kde.org/job/plasma-workspace_stable_qt5/23/ -- [...truncated 2173 lines...] http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:145:90: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), NET::WMState); ^ http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp: In member function ‘void TaskManager::Task::restore()’: http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:171:90: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), NET::WMState); ^ http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp: In member function ‘void TaskManager::Task::setAlwaysOnTop(bool)’: http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:207:90: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), NET::WMState); ^ http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp: In member function ‘void TaskManager::Task::setKeptBelowOthers(bool)’: http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:216:90: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), NET::WMState); ^ http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp: In member function ‘void TaskManager::Task::setFullScreen(bool)’: http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:227:90: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), NET::WMState); ^ http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp: In member function ‘void TaskManager::Task::setShaded(bool)’: http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:238:90: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), NET::WMState); ^ http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp: In member function ‘void TaskManager::Task::publishIconGeometry(QRect)’: http://build.kde.org/job/plasma-workspace_stable_qt5/ws/libtaskmanager/task_x11.cpp:252:79: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo ni(QX11Info::connection(), d-win, QX11Info::appRootWindow(), 0); ^
Build failed in Jenkins: plasma-desktop_stable_qt5 #25
See http://build.kde.org/job/plasma-desktop_stable_qt5/25/ -- [...truncated 1181 lines...] [ 36%] In file included from http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/applicationmodel.h:25:0, from http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/kickoffplugin.cpp:21: http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/recentapplications.cpp.o [ 37%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/recentlyusedmodel.cpp.o [ 37%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/systemmodel.cpp.o [ 37%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/menuentryeditor.cpp.o In file included from http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.h:23:0, from http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:21: http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:98:54: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KService::Ptr Kickoff::serviceForUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:138:49: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] bool KRunnerItemHandler::openUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual Qt::ItemFlags Kickoff::KRunnerModel::flags(const QModelIndex) const’: http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:258:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual QMimeData* Kickoff::KRunnerModel::mimeData(const QModelIndexList) const’: http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:272:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls; ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:275:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/applets/kickoff/core/krunnermodel.cpp:287:39: warning: ‘void KUrl::List::populateMimeData(QMimeData*, const MetaDataMap, KUrl::MimeDataFlags) const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:221) [-Wdeprecated-declarations] urls.populateMimeData(mimeData); ^ http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_copytomenu.cpp: In member function ‘void KonqCopyToMenu::addActionsTo(QMenu*)’: http://build.kde.org/job/plasma-desktop_stable_qt5/ws/containments/folder/plugin/internallibkonq/konq_copytomenu.cpp:81:12: warning: ‘KMenu’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/stable-kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kmenu.h:42)
Jenkins build is back to normal : plasma-workspace_stable_qt5 #24
See http://build.kde.org/job/plasma-workspace_stable_qt5/24/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_stable_qt5 #26
See http://build.kde.org/job/plasma-desktop_stable_qt5/26/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Change in plasma-framework[master]: don't animate icons when they get resized
Marco Martin has uploaded a new change for review.
https://gerrit.vesnicky.cesnet.cz/r/336
Change subject: don't animate icons when they get resized
..
don't animate icons when they get resized
simplify a bit logic ans
make sure if m_sizeChanged is true, never to animate the change
Change-Id: I552f79b13f7714749137fa90df1f9f30120e6a37
---
M src/declarativeimports/core/iconitem.cpp
1 file changed, 10 insertions(+), 16 deletions(-)
git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework
refs/changes/36/336/1
diff --git a/src/declarativeimports/core/iconitem.cpp
b/src/declarativeimports/core/iconitem.cpp
index 08bb47d..005e339 100644
--- a/src/declarativeimports/core/iconitem.cpp
+++ b/src/declarativeimports/core/iconitem.cpp
@@ -251,20 +251,16 @@
QSGTexture *source =
window()-createTextureFromImage(m_iconPixmap.toImage());
QSGTexture *target =
window()-createTextureFromImage(m_oldIconPixmap.toImage());
animatingNode = new FadingNode(source, target);
-m_sizeChanged = true;
m_textureChanged = false;
}
animatingNode-setProgress(m_animValue);
-if (m_sizeChanged) {
-const int iconSize =
Units::roundToIconSize(qMin(boundingRect().size().width(),
boundingRect().size().height()));
-const QRect destRect(QPointF(boundingRect().center() -
QPointF(iconSize/2, iconSize/2)).toPoint(),
- QSize(iconSize, iconSize));
+const int iconSize =
Units::roundToIconSize(qMin(boundingRect().size().width(),
boundingRect().size().height()));
+const QRect destRect(QPointF(boundingRect().center() -
QPointF(iconSize/2, iconSize/2)).toPoint(),
+QSize(iconSize, iconSize));
-animatingNode-setRect(destRect);
-m_sizeChanged = false;
-}
+animatingNode-setRect(destRect);
return animatingNode;
} else {
@@ -274,18 +270,15 @@
delete oldNode;
textureNode = new ManagedTextureNode;
textureNode-setTexture(QSharedPointerQSGTexture(window()-createTextureFromImage(m_iconPixmap.toImage(;
-m_sizeChanged = true;
m_textureChanged = false;
}
-if (m_sizeChanged) {
-const int iconSize =
Units::roundToIconSize(qMin(boundingRect().size().width(),
boundingRect().size().height()));
-const QRect destRect(QPointF(boundingRect().center() -
QPointF(iconSize/2, iconSize/2)).toPoint(),
- QSize(iconSize, iconSize));
+const int iconSize =
Units::roundToIconSize(qMin(boundingRect().size().width(),
boundingRect().size().height()));
+const QRect destRect(QPointF(boundingRect().center() -
QPointF(iconSize/2, iconSize/2)).toPoint(),
+QSize(iconSize, iconSize));
-textureNode-setRect(destRect);
-m_sizeChanged = false;
-}
+textureNode-setRect(destRect);
+
return textureNode;
}
}
@@ -354,6 +347,7 @@
m_animation-stop();
}
update();
+m_sizeChanged = false;
}
void IconItem::geometryChanged(const QRectF newGeometry,
--
To view, visit https://gerrit.vesnicky.cesnet.cz/r/336
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I552f79b13f7714749137fa90df1f9f30120e6a37
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Marco Martin notm...@gmail.com
Gerrit-Reviewer: David Edmundson da...@davidedmundson.co.uk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 tajidin...@archlinux.us changed: What|Removed |Added CC||tajidin...@archlinux.us --- Comment #35 from tajidin...@archlinux.us --- Also on Archlinux git build the kded5 is killing one core on my machine at 100%. If i kill it things return to normal -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: sddm-kcm_master-qt5 #1
See http://build.kde.org/job/sddm-kcm_master-qt5/1/
--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/sddm-kcm_master-qt5/ws/
Running Prebuild steps
[sddm-kcm_master-qt5] $ /bin/sh -xe /tmp/hudson4392433221889428867.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Cloning into '.'...
fatal: Not a valid object name: 'origin/'.
== Cleaning Source Tree
HEAD is now at b91c904 Update version number for 5.2.90
Success build forhudson.tasks.Shell@42d80105
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-desktop #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-desktop +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch
configuration for this job.
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception
hudson.AbortException: No test report files were found. Configuration error?
at
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:116)
at
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:93)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2677)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to LinuxSlave - 4(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at hudson.FilePath.act(FilePath.java:970)
at hudson.FilePath.act(FilePath.java:959)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:90)
at
hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:120)
at
hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:137)
at
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:74)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:770)
at
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:734)
at hudson.model.Build$BuildExecution.post2(Build.java:183)
at
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:683)
at hudson.model.Run.execute(Run.java:1784)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: sddm-kcm_master-qt5 #2
See http://build.kde.org/job/sddm-kcm_master-qt5/2/
--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/sddm-kcm_master-qt5/ws/
Running Prebuild steps
[sddm-kcm_master-qt5] $ /bin/sh -xe /tmp/hudson8916659943310577068.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
fatal: Not a valid object name: 'origin/'.
== Cleaning Source Tree
HEAD is now at b91c904 Update version number for 5.2.90
Success build forhudson.tasks.Shell@3252f47
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/sddm-kcm # timeout=10
Fetching upstream changes from git://anongit.kde.org/sddm-kcm
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/sddm-kcm +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch
configuration for this job.
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception
hudson.AbortException: No test report files were found. Configuration error?
at
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:116)
at
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:93)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2677)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to LinuxSlave - 4(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
at hudson.remoting.Channel.call(Channel.java:752)
at hudson.FilePath.act(FilePath.java:970)
at hudson.FilePath.act(FilePath.java:959)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:90)
at
hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:120)
at
hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:137)
at
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:74)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:770)
at
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:734)
at hudson.model.Build$BuildExecution.post2(Build.java:183)
at
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:683)
at hudson.model.Run.execute(Run.java:1784)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : sddm-kcm_master_qt5 #3
See http://build.kde.org/job/sddm-kcm_master_qt5/3/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is unstable: kde-gtk-config_master_qt5 #1
See http://build.kde.org/job/kde-gtk-config_master_qt5/1/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is unstable: kde-gtk-config_stable_qt5 #1
See http://build.kde.org/job/kde-gtk-config_stable_qt5/1/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 Steven Franzen sfranze...@hotmail.com changed: What|Removed |Added CC||sfranze...@hotmail.com --- Comment #36 from Steven Franzen sfranze...@hotmail.com --- (In reply to Mykola Krachkovsky from comment #34) Same for me. kded5 consumes 1 core. I'm using notebook, if I change monitor brightness cpu usage is lowered to 0%, but after time may up again. This trick also works for me. I can further report that I can reliably trigger the CPU usage manually by unlocking (not just locking) the screen from the screen locker. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121761: Fix build on FreeBSD
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/ --- (Updated Jan. 17, 2015, 12:01 vorm.) Status -- This change has been marked as submitted. Review request for Plasma and Raphael Kubo da Costa. Repository: plasma-workspace Description --- Add missing errno.h include Wrap Linux-only signals in #ifdef Q_OS_LINUX Fix build with X11 not installed to /usr Diffs - drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af ksmserver/screenlocker/greeter/authenticator.cpp ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a ksmserver/screenlocker/greeter/autotests/killtest.cpp 6f2ef114459b5d641e357f3a817b82e7af2e72a3 libkworkspace/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1 Diff: https://git.reviewboard.kde.org/r/121761/diff/ Testing --- compiles, still compiles on linux Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121763: Fix build on FreeBSD
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/ --- (Updated Jan. 17, 2015, 12:05 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Raphael Kubo da Costa. Repository: kinfocenter Description --- We can't call the KCM devinfo there since we need to link against -ldevinfo and CMake would try to link to the KCM instead of the library in that case. Diffs - Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9 Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 Diff: https://git.reviewboard.kde.org/r/121763/diff/ Testing --- Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_master_qt5 #2
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is still unstable: kde-gtk-config_stable_qt5 #2
See http://build.kde.org/job/kde-gtk-config_stable_qt5/2/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #1228
See http://build.kde.org/job/plasma-workspace_master_qt5/1228/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
