Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/#review74912 --- Isn't this a bit too restrictive? - Mark Gaiser On jan 28, 2015, 1:27 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- (Updated jan 28, 2015, 1:27 p.m.) Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/#review74914 --- Ship it! Ship It! - David Edmundson On Jan. 22, 2015, 9:43 p.m., Andreas Sturmlechner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated Jan. 22, 2015, 9:43 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Qt5Test should not be mandatory. The patch moves find_package(Qt5Test...) out of CMakeLists.txt and adds drkonqi/internalkxmlrpcclient/autotests only if(BUILD_TESTING). I do not have write access. Diffs - CMakeLists.txt e4d2b2dcf25ce7892f63c0279cea99329ec4b5f4 drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaaa0b058fa38d44dd52bd5b93f2b839d6f8 Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
On Jan. 28, 2015, 3:30 p.m., Mark Gaiser wrote: Isn't this a bit too restrictive? why would you want to have the content of your clipboard being interpreted? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/#review74912 --- On Jan. 28, 2015, 2:27 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- (Updated Jan. 28, 2015, 2:27 p.m.) Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343436] Systemmonitor detailed view is almost unreadable with Breeze Dark color theme
https://bugs.kde.org/show_bug.cgi?id=343436 Sebastian Kügler se...@kde.org changed: What|Removed |Added CC||se...@kde.org --- Comment #1 from Sebastian Kügler se...@kde.org --- Could you attach a screenshot illustrating the problem? That would make it way easier to triage and fix. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343436] Systemmonitor detailed view is almost unreadable with Breeze Dark color theme
https://bugs.kde.org/show_bug.cgi?id=343436 --- Comment #2 from supaiku supa...@protonmail.ch --- Created attachment 90746 -- https://bugs.kde.org/attachment.cgi?id=90746action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 343436] Systemmonitor detailed view is almost unreadable with Breeze Dark color theme
https://bugs.kde.org/show_bug.cgi?id=343436 Sebastian Kügler se...@kde.org changed: What|Removed |Added Version|unspecified |5.2.0 Product|Breeze |ksysguard Assignee|plasma-devel@kde.org|ksysguard-b...@kde.org Component|general |ksysguard -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #53 from Nick Shaforostoff sha...@ukr.net --- i have updated packages to 5.2 version and the issue is still there. i can see it after screenlocker run as well. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #51 from Ruman Gerst mrbo...@live.de --- Huh? What happened? It was gone for me with Plasma 5.1.1, now I'm using Plasma 5.2 from Kubuntu Next Backports - now it's back! I'll post a sysprof file, again. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #52 from Ruman Gerst mrbo...@live.de --- Created attachment 90766 -- https://bugs.kde.org/attachment.cgi?id=90766action=edit Output from sudo sysprof now with Plasma 5.2 [Kubuntu Next Backports] -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 Ruman Gerst mrbo...@live.de changed: What|Removed |Added Version|5.1.95 |5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340964] System misreporting battery status and won't hibernate at 5% default battery value
https://bugs.kde.org/show_bug.cgi?id=340964 donniezazen sud...@sudhirkhanger.com changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |WORKSFORME --- Comment #4 from donniezazen sud...@sudhirkhanger.com --- I am no longer able to replicate it with powerdevil-5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
On jan 28, 2015, 2:30 p.m., Mark Gaiser wrote: Isn't this a bit too restrictive? Martin Gräßlin wrote: why would you want to have the content of your clipboard being interpreted? Eike Hein wrote: IMHO this is more or less the same case as HTML in window titles, which is why the Task Manager forces plain text, too. That is a very good point. Ignore my comment :) - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/#review74912 --- On jan 28, 2015, 1:27 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- (Updated jan 28, 2015, 1:27 p.m.) Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids David Edmundson wrote: Generic is always better. KDeclarative is used from places outside Plasma. Applications in future will need to open KCMs too. If we put it in Plasma in one year we'll end up with this anyway and we end up maintaining a weird system used only by us. Also from a discussion on IRC you'll end up guessing the name to put in the UI. This will lead to blocking developers from being able to do the right thing by trying to be too clever. Bhushan Shah wrote: My suggestion is to have both this can be used by applets if they don't like solution provided by plasma-framework OR optionally turn this into simple processrunner, there are use cases for both methods Marco Martin wrote: apart that reading an always makes me cringe :p what I really don't like is the ui inconsistencies that this will cause (an encourages). They will happen anyways true, but at least a timid attempt at fighting that could be done (this was always been a problem in KDE, wasn't it..), creating a path of least resistence and trying to enforce it is an approach. in the end is mostly a technical problem, since the actual proper solution (putting them in the configure dialog) is not possible anymore. if some day this will be possible again (for instance kcms in qml) that should be the preferred way again, so both approaches are in the end just workarounds, so... whatever (/me shrugs) Bhushan Shah wrote: Or another option is something like https://paste.kde.org/pirqonxvl so that you can just do plasmoid.openConfigurationModules() It would be possible if we made the applet's config dialog a QWidget (the KCM container) and put a QML container into that to load the actual config modules for the applet. The problem with this approach is that it's the exact opposite direction we have been going to, but at least it's not hidden from the API. I'm not proposing this, just bringing it up since it came up in my head: food for thought. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74750 --- On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated Jan. 24, 2015, 11:54 p.m.) Review request for Plasma. Repository: kdeclarative Description --- Since there are already like 10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a KCMShell.open(foo) and KCMShell.open([foo, bar, baz]) singleton. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed Diff: https://git.reviewboard.kde.org/r/122239/diff/ Testing --- Works. Dunno if the name causes clashes or this is the right place to put it. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
On Jan. 28, 2015, 2:30 p.m., Mark Gaiser wrote: Isn't this a bit too restrictive? Martin Gräßlin wrote: why would you want to have the content of your clipboard being interpreted? IMHO this is more or less the same case as HTML in window titles, which is why the Task Manager forces plain text, too. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/#review74912 --- On Jan. 28, 2015, 1:27 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- (Updated Jan. 28, 2015, 1:27 p.m.) Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/#review74917 --- Ship it! Ship It! - David Edmundson On Jan. 28, 2015, 1:27 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- (Updated Jan. 28, 2015, 1:27 p.m.) Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving plasmaengineexplorer to plasma-framework?
Hello, On 1/23/15 7:18 AM, Bhushan Shah wrote: So at moment plasmaengineexplorer is provided by plasmate which is not released at moment. yes unfortunately I haven't done a good job in that. I haven't abandoned plasmate, its just that I don't have the free time that I used to have. AFAIK nobody picked the task of releasing the plasmate repo, so I would like to help on this one. I believe that this thread is quite big enough, so I will make a new one in which we can discuss about the release. -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 Nick Shaforostoff sha...@ukr.net changed: What|Removed |Added CC||sha...@ukr.net --- Comment #50 from Nick Shaforostoff sha...@ukr.net --- i don't know whether the fix is installed in my vivid (most packages have 5.1.95 version), but i'm able to reproduce high cpu usage by connecting external monitor. when i connect external monitor, it has black background and immediately everything becomes slow: at first 'top' shows that 4 'migration' processes are taking cpu time, then after a while kded5 eats 100% cpu time (it goes crazy with PowerDevilUPowerBackend::brightnessValueMax() and PowerDevilUPowerBackend::brightnessValue()). -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122289: [applets/clipboard] Force tooltips to be PlainText
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/#review74921 --- Ship it! Ship It! - Marco Martin On Jan. 28, 2015, 1:27 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122289/ --- (Updated Jan. 28, 2015, 1:27 p.m.) Review request for Plasma and Martin Klapetek. Bugs: 343301 https://bugs.kde.org/show_bug.cgi?id=343301 Repository: plasma-workspace Description --- Prevents cross-side scripting attempts. This requires 8044e15 of plasma-framework. BUG: 343301 FIXED-IN: 5.3.0 Diffs - applets/clipboard/contents/ui/clipboard.qml 6ff1e2b56588293df76a24de92727a9f24437fdc Diff: https://git.reviewboard.kde.org/r/122289/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122207: [plasma-desktop] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122207/ --- (Updated Jan. 28, 2015, 5:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- This is a small patch for CMakeLists.txt to only require Qt5Test if BUILD_TESTING. Also changed kcms/keyboard/CMakeLists.txt kcms/lookandfeel/CMakeLists.txt to only add test subdirs if BUILD_TESTING. Diffs - kcms/keyboard/CMakeLists.txt 6ed3cd7bd597c987b96131e44b5ed3d098d43319 kcms/lookandfeel/CMakeLists.txt 5f5defd83cbb9b148b172978f92f55e2185ff340 CMakeLists.txt 4fc6a1dd3e53585d304a4c4143e262c825d83c3a Diff: https://git.reviewboard.kde.org/r/122207/diff/ Testing --- Built with and without test. Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
