Review Request 122450: Do not set global shortcuts for the Media keys

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122450/
---

Review request for Amarok and Plasma.


Repository: amarok


Description
---

Amarok used to grab the keys for:
* Qt::Key_MediaPlay
* Qt::Key_MediaStop
* Qt::Key_MediaNext
* Qt::Key_MediaPrevious

As those are global shortcuts they are taken away from any other
application when Amarok is running. E.g. if I watch a movie in VLC
and press the media play button (which VLC handles) Amarok will start
playback if it's running. If Amarok is not running, VLC will pause
the playback. This shows that a multi-media application should not
globally grab these keys.

In addition we just introduced a change [1] in plasma-workspace for the
Plasma/5.3 release to grab these shortcuts and bind them to the
mpris2 dataengine. Now the mpris2 engine handles those shortcuts and
delegates to the currently active application.

[1] 
http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b


Diffs
-

  src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d 
  src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 

Diff: https://git.reviewboard.kde.org/r/122450/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122449: [ksmserver/screenlocker] Allow media control global shortcuts

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122449/#review75516
---

Ship it!


Ship It!

- David Edmundson


On Feb. 6, 2015, 7:52 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122449/
> ---
> 
> (Updated Feb. 6, 2015, 7:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 198097
> https://bugs.kde.org/show_bug.cgi?id=198097
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> White list the media control global shortcuts from plasmashell in
> the lock screen.
> 
> FEATURE: 198097
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/globalaccel.cpp 
> 10d87d00ca49c361c0907e0a45ed732a36cd9cfa 
> 
> Diff: https://git.reviewboard.kde.org/r/122449/diff/
> 
> 
> Testing
> ---
> 
> test application and pressed play/pause - worked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122449: [ksmserver/screenlocker] Allow media control global shortcuts

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122449/
---

(Updated Feb. 6, 2015, 9:07 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 198097
https://bugs.kde.org/show_bug.cgi?id=198097


Repository: plasma-workspace


Description
---

White list the media control global shortcuts from plasmashell in
the lock screen.

FEATURE: 198097
FIXED-IN: 5.3.0


Diffs
-

  ksmserver/screenlocker/globalaccel.cpp 
10d87d00ca49c361c0907e0a45ed732a36cd9cfa 

Diff: https://git.reviewboard.kde.org/r/122449/diff/


Testing
---

test application and pressed play/pause - worked.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122451: Whitelist brightness keys in the lockscreen

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/
---

Review request for Plasma, Daniel Vrátil and Martin Gräßlin.


Repository: plasma-workspace


Description
---

Based on popular request, add brightness keys (increase, decrease) to the 
lockscreen white list of allowed shortcuts.


Diffs
-

  ksmserver/screenlocker/globalaccel.cpp 169515a 

Diff: https://git.reviewboard.kde.org/r/122451/diff/


Testing
---

Tested, works fine


Thanks,

Lukáš Tinkl

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/#review75518
---



ksmserver/screenlocker/globalaccel.cpp


isn't this missing QList or is C++11 even smarter than I expected?


- Martin Gräßlin


On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122451/
> ---
> 
> (Updated Feb. 6, 2015, 11:04 a.m.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Based on popular request, add brightness keys (increase, decrease) to the 
> lockscreen white list of allowed shortcuts.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/globalaccel.cpp 169515a 
> 
> Diff: https://git.reviewboard.kde.org/r/122451/diff/
> 
> 
> Testing
> ---
> 
> Tested, works fine
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

[Lukáš Tinkl]

> On Úno. 6, 2015, 11:21 dop., Martin Gräßlin wrote:
> > ksmserver/screenlocker/globalaccel.cpp, line 52
> > 
> >
> > isn't this missing QList or is C++11 even smarter than I 
> > expected?

It's that smart ;) I was expecting a QStringList instead of QList, but 
either is really not necessary with modern compilers.


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/#review75518
---


On Úno. 6, 2015, 11:04 dop., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122451/
> ---
> 
> (Updated Úno. 6, 2015, 11:04 dop.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Based on popular request, add brightness keys (increase, decrease) to the 
> lockscreen white list of allowed shortcuts.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/globalaccel.cpp 169515a 
> 
> Diff: https://git.reviewboard.kde.org/r/122451/diff/
> 
> 
> Testing
> ---
> 
> Tested, works fine
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/#review75521
---

Ship it!


Ship It!

- Martin Gräßlin


On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122451/
> ---
> 
> (Updated Feb. 6, 2015, 11:04 a.m.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Based on popular request, add brightness keys (increase, decrease) to the 
> lockscreen white list of allowed shortcuts.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/globalaccel.cpp 169515a 
> 
> Diff: https://git.reviewboard.kde.org/r/122451/diff/
> 
> 
> Testing
> ---
> 
> Tested, works fine
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

[Martin Gräßlin]

> On Feb. 6, 2015, 11:21 a.m., Martin Gräßlin wrote:
> > ksmserver/screenlocker/globalaccel.cpp, line 52
> > 
> >
> > isn't this missing QList or is C++11 even smarter than I 
> > expected?
> 
> Lukáš Tinkl wrote:
> It's that smart ;) I was expecting a QStringList instead of 
> QList, but either is really not necessary with modern compilers.

wohoo, learn something new each day :-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/#review75518
---


On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122451/
> ---
> 
> (Updated Feb. 6, 2015, 11:04 a.m.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Based on popular request, add brightness keys (increase, decrease) to the 
> lockscreen white list of allowed shortcuts.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/globalaccel.cpp 169515a 
> 
> Diff: https://git.reviewboard.kde.org/r/122451/diff/
> 
> 
> Testing
> ---
> 
> Tested, works fine
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/
---

(Updated Feb. 6, 2015, 10:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Daniel Vrátil and Martin Gräßlin.


Repository: plasma-workspace


Description
---

Based on popular request, add brightness keys (increase, decrease) to the 
lockscreen white list of allowed shortcuts.


Diffs
-

  ksmserver/screenlocker/globalaccel.cpp 169515a 

Diff: https://git.reviewboard.kde.org/r/122451/diff/


Testing
---

Tested, works fine


Thanks,

Lukáš Tinkl

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/
---

Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

Emitting dbus signals allows interested parties to be notified about
OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.

[lookandfeel] Split mainItem of Osd into a dedicated OsdItem

Allows to reuse the content of the Osd in other parts without
having it to be a Dialog.

[screenlocker] Support OnScreenDisplay messages

KSld connects to the DBus signals for the OnScreenDisplay and forwards
them to the greeter application through the private Wayland protocol.
The idea here is to not have the greeter connect to the DBus as in future
it would be preferable if the greeter cannot connect to DBus.

The lookandfeel package might expose an object called "onScreenDisplay".
Whenever an OSD message is recieved by the greeter it looks for such an
object and updates the osd specific properties.

The default breeze lookandfeel package integrates the OsdItem from the
same lookandfeel package.


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.h 
4a90fafee810940c3f932c8e2bfed10459adc425 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
a23b5625adc99661ab07534403ee23d005581c03 
  ksmserver/screenlocker/protocols/ksld.xml 
bfb32190bf2529a14b39fac4c7e6029a5df811d0 
  ksmserver/screenlocker/waylandserver.h 
5a8ed2249152277b505fe7a944b1b7251ef995d3 
  ksmserver/screenlocker/waylandserver.cpp 
746032e1a7b1bad3625b9f0a156de059e5fba31a 
  lookandfeel/contents/lockscreen/LockScreen.qml 
1c4e4a510dd9196ae2b36bc355490580c06a78a6 
  lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
  lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
  shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
  shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 

Diff: https://git.reviewboard.kde.org/r/122452/diff/


Testing
---


File Attachments


Lock screen with volume OSD
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75533
---

Ship it!


Looks good, can't really comment on the wayland stuff tho

- Martin Klapetek


On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 1:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

ISO for 2015-02-06

[Harald Sitter]

http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist

After a brief 5.2 testing interlude, this week's ISO is again
integrating Plasma from master (i.e. what is going to become 5.3).

# changes
- kde4breeze is working again \o/

# errata
- only limited testing as I am currently working on other things
- kate session systray plasmoid has broken qml or something or
nothing. also added by default. also constantly marked active
(although that might be because of the brokenness)

# virtual machines
virtual machines have a bit of trouble with the graphics. At least
with virtualbox you can workaround the problem by temporarily
switching to a different TTY (right-ctrl+f2 -> right-ctrl+f1)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ISO for 2015-02-06

[Aleix Pol]

On Fri, Feb 6, 2015 at 4:38 PM, Harald Sitter  wrote:
> http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist
>
> After a brief 5.2 testing interlude, this week's ISO is again
> integrating Plasma from master (i.e. what is going to become 5.3).
>
> # changes
> - kde4breeze is working again \o/
>
> # errata
> - only limited testing as I am currently working on other things
> - kate session systray plasmoid has broken qml or something or
> nothing. also added by default. also constantly marked active
> (although that might be because of the brokenness)
This was fixed by David on the 18th January on kate's Applications/14.12 branch:
3a161aba170950e7c7e57985694fd4493a6ea44e

Why isn't it being pulled? is it maybe because it hasn't been merged to master?

>
> # virtual machines
> virtual machines have a bit of trouble with the graphics. At least
> with virtualbox you can workaround the problem by temporarily
> switching to a different TTY (right-ctrl+f2 -> right-ctrl+f1)

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ISO for 2015-02-06

[Harald Sitter]

On Fri, Feb 6, 2015 at 4:44 PM, Aleix Pol  wrote:
> On Fri, Feb 6, 2015 at 4:38 PM, Harald Sitter  wrote:
>> http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist
>>
>> After a brief 5.2 testing interlude, this week's ISO is again
>> integrating Plasma from master (i.e. what is going to become 5.3).
>>
>> # changes
>> - kde4breeze is working again \o/
>>
>> # errata
>> - only limited testing as I am currently working on other things
>> - kate session systray plasmoid has broken qml or something or
>> nothing. also added by default. also constantly marked active
>> (although that might be because of the brokenness)
> This was fixed by David on the 18th January on kate's Applications/14.12 
> branch:
> 3a161aba170950e7c7e57985694fd4493a6ea44e
>
> Why isn't it being pulled? is it maybe because it hasn't been merged to 
> master?

Yes, there's only master builds on the ISO as of right now.
Looking at  the kate git history it appears the last merge of 14.12
into master actually was in november :O

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ISO for 2015-02-06

[Aleix Pol]

On Fri, Feb 6, 2015 at 5:16 PM, Harald Sitter  wrote:
> On Fri, Feb 6, 2015 at 4:44 PM, Aleix Pol  wrote:
>> On Fri, Feb 6, 2015 at 4:38 PM, Harald Sitter  wrote:
>>> http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist
>>>
>>> After a brief 5.2 testing interlude, this week's ISO is again
>>> integrating Plasma from master (i.e. what is going to become 5.3).
>>>
>>> # changes
>>> - kde4breeze is working again \o/
>>>
>>> # errata
>>> - only limited testing as I am currently working on other things
>>> - kate session systray plasmoid has broken qml or something or
>>> nothing. also added by default. also constantly marked active
>>> (although that might be because of the brokenness)
>> This was fixed by David on the 18th January on kate's Applications/14.12 
>> branch:
>> 3a161aba170950e7c7e57985694fd4493a6ea44e
>>
>> Why isn't it being pulled? is it maybe because it hasn't been merged to 
>> master?
>
> Yes, there's only master builds on the ISO as of right now.
> Looking at  the kate git history it appears the last merge of 14.12
> into master actually was in november :O
>
> HS

Ok, just sent an e-mail to kwrite-devel to see if they can do the merge.

Cheers!
Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75551
---


Nice!


File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png


I suggest you add a dialog background framesvg item around it to ease 
visiblity. Also y should be  2 * (background.height - osd.height) * 3

This ensures consistency between the real OSD and this one.


- Kai Uwe Broulik


On Feb. 6, 2015, 12:03 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 12:03 nachm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122332: KQuickControls IconDialog

[Kai Uwe Broulik]

> On Feb. 2, 2015, 9:13 vorm., Marco Martin wrote:
> > to do modality you have to use exec i guess

I guess we don't want to black all of plasma just for this one dialog. So, we 
go without modality then?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review75197
---


On Jan. 30, 2015, 10:07 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122332/
> ---
> 
> (Updated Jan. 30, 2015, 10:07 nachm.)
> 
> 
> Review request for Plasma and Daniel Vrátil.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This patch adds KQuickControls wrapper around KIconDialog similar to how the 
> ColorDialog and other QtQuick Dialogs work. This can be used, for instance, 
> in Kickoff's config UI to provide a picker for a custom item.
> 
> It is an initial draft and lacks for example window modality as I couldn't 
> figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic 
> inside) and I'm also not sure about the lifecycle/ownership of the dialog, 
> I've seen a lot of fixes for issues in that area on Review Board.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff 
>   src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed 
> 
> Diff: https://git.reviewboard.kde.org/r/122332/diff/
> 
> 
> Testing
> ---
> 
> For testing I added a button to Kickoff that allows to open the dialog and 
> the button icon source is bound to the dialog's iconName property. Didn't 
> test the icon source/user/custom path stuff.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122370: Prevent icon transition in tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122370/
---

(Updated Feb. 7, 2015, 12:14 vorm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

The fading between totally unrelated images is highly distracting imho, 
especially when the tooltip just appeared rather than fading from the old 
position. A similar approach is used in the OSD to prevent this.


Diffs
-

  src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae 

Diff: https://git.reviewboard.kde.org/r/122370/diff/


Testing
---

No more transitions.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122463: Wipe source when IconItem becomes invisible

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122463/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

When IconItem becomes invisible release the image. This prevents transition 
from stale pixmaps, like in the tooltip, and could reduce memory consumption. 


Diffs
-

  src/declarativeimports/core/iconitem.h d3b9305 
  src/declarativeimports/core/iconitem.cpp 5da5265 

Diff: https://git.reviewboard.kde.org/r/122463/diff/


Testing
---

I didn't notice a performance impact, when eg. opening the systray popup or 
kickoff.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122463: Wipe source when IconItem becomes invisible

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122463/#review75553
---


It does seem to break the close icon in the notification popup :/

- Kai Uwe Broulik


On Feb. 7, 2015, 12:14 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122463/
> ---
> 
> (Updated Feb. 7, 2015, 12:14 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> When IconItem becomes invisible release the image. This prevents transition 
> from stale pixmaps, like in the tooltip, and could reduce memory consumption. 
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h d3b9305 
>   src/declarativeimports/core/iconitem.cpp 5da5265 
> 
> Diff: https://git.reviewboard.kde.org/r/122463/diff/
> 
> 
> Testing
> ---
> 
> I didn't notice a performance impact, when eg. opening the systray popup or 
> kickoff.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122463: Wipe source when IconItem becomes invisible

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122463/
---

(Updated Feb. 7, 2015, 12:54 vorm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

When IconItem becomes invisible release the image. This prevents transition 
from stale pixmaps, like in the tooltip, and could reduce memory consumption. 


Diffs
-

  src/declarativeimports/core/iconitem.h d3b9305 
  src/declarativeimports/core/iconitem.cpp 5da5265 

Diff: https://git.reviewboard.kde.org/r/122463/diff/


Testing
---

I didn't notice a performance impact, when eg. opening the systray popup or 
kickoff.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel