Review Request 122464: Remove bell kcm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/ --- Review request for Plasma. Repository: plasma-desktop Description --- The kcm sets up the xbell, but konsole for example doesn't use the xbell but knotify. The code is also xcb only, I have no idea if it could be ported to wayland. For users the knotify way of treating the bell (visual/sound/custom executable) should satisfy all needs. Then there is also the accessibility kcm allowing to switch on and off the system bell (using xbell as well) and allowing to flash the screen in a color (I could not get that one to work, neither using xterm nor konsole). A recent discussion on the accessibility mailing list also gave no real use case for this duplicate kcm to exist. http://lists.kde.org/?t=14202382732r=1w=2 Diffs - kcms/CMakeLists.txt 06056cd kcms/bell/CMakeLists.txt f2ebe19 kcms/bell/Messages.sh cb6a478 kcms/bell/bell.cpp 1c4f552 kcms/bell/bell.desktop f1cd552 kcms/bell/bell.h fda09b5 Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122464: Remove bell kcm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/#review75561 --- Ship it! Ship It! - Jeremy Whiting On Feb. 7, 2015, 5:55 a.m., Frederik Gladhorn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/ --- (Updated Feb. 7, 2015, 5:55 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- The kcm sets up the xbell, but konsole for example doesn't use the xbell but knotify. The code is also xcb only, I have no idea if it could be ported to wayland. For users the knotify way of treating the bell (visual/sound/custom executable) should satisfy all needs. Then there is also the accessibility kcm allowing to switch on and off the system bell (using xbell as well) and allowing to flash the screen in a color (I could not get that one to work, neither using xterm nor konsole). A recent discussion on the accessibility mailing list also gave no real use case for this duplicate kcm to exist. http://lists.kde.org/?t=14202382732r=1w=2 Diffs - kcms/CMakeLists.txt 06056cd kcms/bell/CMakeLists.txt f2ebe19 kcms/bell/Messages.sh cb6a478 kcms/bell/bell.cpp 1c4f552 kcms/bell/bell.desktop f1cd552 kcms/bell/bell.h fda09b5 Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review75566 --- Looks great! Might be helpful to see what it looks like with Kai suggestion for using a dialog background for improved visibility. - Andrew Lake On Feb. 6, 2015, 12:03 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- (Updated Feb. 6, 2015, 12:03 p.m.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Emitting dbus signals allows interested parties to be notified about OSD changes. E.g. the lock screen might want to show the OSD values, but blocks the actual OSD, so it needs to be informed about changes to react on them. [lookandfeel] Split mainItem of Osd into a dedicated OsdItem Allows to reuse the content of the Osd in other parts without having it to be a Dialog. [screenlocker] Support OnScreenDisplay messages KSld connects to the DBus signals for the OnScreenDisplay and forwards them to the greeter application through the private Wayland protocol. The idea here is to not have the greeter connect to the DBus as in future it would be preferable if the greeter cannot connect to DBus. The lookandfeel package might expose an object called onScreenDisplay. Whenever an OSD message is recieved by the greeter it looks for such an object and updates the osd specific properties. The default breeze lookandfeel package integrates the OsdItem from the same lookandfeel package. Diffs - ksmserver/screenlocker/greeter/greeterapp.h 4a90fafee810940c3f932c8e2bfed10459adc425 ksmserver/screenlocker/greeter/greeterapp.cpp a23b5625adc99661ab07534403ee23d005581c03 ksmserver/screenlocker/protocols/ksld.xml bfb32190bf2529a14b39fac4c7e6029a5df811d0 ksmserver/screenlocker/waylandserver.h 5a8ed2249152277b505fe7a944b1b7251ef995d3 ksmserver/screenlocker/waylandserver.cpp 746032e1a7b1bad3625b9f0a156de059e5fba31a lookandfeel/contents/lockscreen/LockScreen.qml 1c4e4a510dd9196ae2b36bc355490580c06a78a6 lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 lookandfeel/contents/osd/OsdItem.qml PRE-CREATION shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 Diff: https://git.reviewboard.kde.org/r/122452/diff/ Testing --- File Attachments Lock screen with volume OSD https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122464: Remove bell kcm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/#review75564 --- Ship it! Ship It! - David Edmundson On Feb. 7, 2015, 12:55 p.m., Frederik Gladhorn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/ --- (Updated Feb. 7, 2015, 12:55 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The kcm sets up the xbell, but konsole for example doesn't use the xbell but knotify. The code is also xcb only, I have no idea if it could be ported to wayland. For users the knotify way of treating the bell (visual/sound/custom executable) should satisfy all needs. Then there is also the accessibility kcm allowing to switch on and off the system bell (using xbell as well) and allowing to flash the screen in a color (I could not get that one to work, neither using xterm nor konsole). A recent discussion on the accessibility mailing list also gave no real use case for this duplicate kcm to exist. http://lists.kde.org/?t=14202382732r=1w=2 Diffs - kcms/CMakeLists.txt 06056cd kcms/bell/CMakeLists.txt f2ebe19 kcms/bell/Messages.sh cb6a478 kcms/bell/bell.cpp 1c4f552 kcms/bell/bell.desktop f1cd552 kcms/bell/bell.h fda09b5 Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 343903] Crash when opening power management settings
https://bugs.kde.org/show_bug.cgi?id=343903 Lasse Liehu lasse.li...@gmail.com changed: What|Removed |Added Assignee|unassigned-b...@kde.org |plasma-devel@kde.org Component|general |general Product|kde |Powerdevil -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
On Jan. 26, 2015, 9:08 vorm., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids David Edmundson wrote: Generic is always better. KDeclarative is used from places outside Plasma. Applications in future will need to open KCMs too. If we put it in Plasma in one year we'll end up with this anyway and we end up maintaining a weird system used only by us. Also from a discussion on IRC you'll end up guessing the name to put in the UI. This will lead to blocking developers from being able to do the right thing by trying to be too clever. Bhushan Shah wrote: My suggestion is to have both this can be used by applets if they don't like solution provided by plasma-framework OR optionally turn this into simple processrunner, there are use cases for both methods Marco Martin wrote: apart that reading an always makes me cringe :p what I really don't like is the ui inconsistencies that this will cause (an encourages). They will happen anyways true, but at least a timid attempt at fighting that could be done (this was always been a problem in KDE, wasn't it..), creating a path of least resistence and trying to enforce it is an approach. in the end is mostly a technical problem, since the actual proper solution (putting them in the configure dialog) is not possible anymore. if some day this will be possible again (for instance kcms in qml) that should be the preferred way again, so both approaches are in the end just workarounds, so... whatever (/me shrugs) Bhushan Shah wrote: Or another option is something like https://paste.kde.org/pirqonxvl so that you can just do plasmoid.openConfigurationModules() Sebastian Kügler wrote: It would be possible if we made the applet's config dialog a QWidget (the KCM container) and put a QML container into that to load the actual config modules for the applet. The problem with this approach is that it's the exact opposite direction we have been going to, but at least it's not hidden from the API. I'm not proposing this, just bringing it up since it came up in my head: food for thought. That could also give us back the widget sidebar looking consistent with the KCMs if we used a traditional window with a sidebar and then have pages for each of the qml config pages and add additional KCMs there as needed. For other formfactors the old all-QML view could be used again, given that widget-based apps don't really fit into a touch environment anyway. On the other hand, isn't systemsettings destined to become QtQuick-based eventually? - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74750 --- On Jan. 24, 2015, 11:54 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated Jan. 24, 2015, 11:54 nachm.) Review request for Plasma. Repository: kdeclarative Description --- Since there are already like 10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a KCMShell.open(foo) and KCMShell.open([foo, bar, baz]) singleton. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed Diff: https://git.reviewboard.kde.org/r/122239/diff/ Testing --- Works. Dunno if the name causes clashes or this is the right place to put it. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340652] Regression: Activity-specific settings gone
https://bugs.kde.org/show_bug.cgi?id=340652 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://quickgit.kde.org/?p= ||powerdevil.gita=commith=0 ||e27382a423509d21f706f65831a ||7d461e6571c0 Version Fixed In||5.3.0 --- Comment #2 from Kai Uwe Broulik k...@privat.broulik.de --- Activity-related settings will return in 5.3 as per [1] [1] http://quickgit.kde.org/?p=powerdevil.gita=commith=0e27382a423509d21f706f65831a7d461e6571c0 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 343631] With buttons event handling set to turn off screen, screen does not turn off
https://bugs.kde.org/show_bug.cgi?id=343631 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- All notebooks I have experienced so far turn off their screen backlight hardware-wise when the lid is closed. Can you check the output of qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement org.kde.Solid.PowerManagement.isActionSupported DPMSControl -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 339391] system hangs during suspend-to-ram (must poweroff), while pm-suspend works.
https://bugs.kde.org/show_bug.cgi?id=339391 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added Resolution|--- |UPSTREAM Status|REOPENED|RESOLVED CC||k...@privat.broulik.de --- Comment #20 from Kai Uwe Broulik k...@privat.broulik.de --- Looks like an upstream issue. Thanks Vincent for filing a kernel bug, please continue the discussion there. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122339: Add KWorkSpace::isShuttingDown()
On Feb. 2, 2015, 7:45 vorm., Martin Gräßlin wrote: is that for the case that no logind is used? Or should ksmserver better integrate with logind? KSMServer handles the session teardown and only after that does Logind get involved which means PreparingForShutdown is false until the Plasma session quits which is why I need this method. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/#review75190 --- On Jan. 31, 2015, 4:02 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/ --- (Updated Jan. 31, 2015, 4:02 nachm.) Review request for Plasma and Martin Gräßlin. Bugs: 189456 https://bugs.kde.org/show_bug.cgi?id=189456 Repository: plasma-workspace Description --- Since KSMServer does the session teardown, we can't just rely on Logind's PreparingForShutdown property. This patch will allow for instance PowerDevil to not suspend the session when it's currently shutting down, otherwise you'll have your system suspend and continue shutting down after resuming. Diffs - ksmserver/shutdown.cpp e6bc708 libkworkspace/kworkspace.h 816f8f1 libkworkspace/kworkspace.cpp ac979bd ksmserver/org.kde.KSMServerInterface.xml 9dad130 ksmserver/server.h 20b5faa Diff: https://git.reviewboard.kde.org/r/122339/diff/ Testing --- Works, adjusted PowerDevil and the system did not suspend during shutdown. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 343018] Screen Energy Saving doesn't work at all
https://bugs.kde.org/show_bug.cgi?id=343018 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- Can you verify whether running the command xset -display :0 dpms force off turns off the screen (don't worry, it will turn on when you move the mouse)? If it does not work, this is a driver issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 342882] Broken battery notification popups at random times during computer use
https://bugs.kde.org/show_bug.cgi?id=342882 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- Could it be that kded crashed? Are you using an AMD graphics card? I haven't experienced such a message, although I changed the threshold to 98% for debugging so I would get those notifications. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 343631] With buttons event handling set to turn off screen, screen does not turn off
https://bugs.kde.org/show_bug.cgi?id=343631 Martin Klapetek mklape...@kde.org changed: What|Removed |Added CC||mklape...@kde.org --- Comment #2 from Martin Klapetek mklape...@kde.org --- All notebooks I have experienced so far turn off their screen backlight hardware-wise when the lid is closed. Fwiw, my macbook pro 2011 does not do close-to-switch-off-lights-by-hardware. If there's no action configured, the light simply stays on (but I always configure suspend for that so not a problem for me). -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 343903] Crash when opening power management settings
https://bugs.kde.org/show_bug.cgi?id=343903 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/powe ||rdevil/1bc24e996a62838ccc07 ||d75f065577afff4365ea --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- Git commit 1bc24e996a62838ccc07d75f065577afff4365ea by Kai Uwe Broulik. Committed on 07/02/2015 at 19:18. Pushed by broulik into branch 'Plasma/5.2'. Fix crash when one of the combo boxes is not present M +16 -5daemon/actions/bundled/handlebuttoneventsconfig.cpp http://commits.kde.org/powerdevil/1bc24e996a62838ccc07d75f065577afff4365ea -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 343631] With buttons event handling set to turn off screen, screen does not turn off
https://bugs.kde.org/show_bug.cgi?id=343631 --- Comment #3 from Kai Uwe Broulik k...@privat.broulik.de --- Thanks for the info! So it might be desirable to always turn off the screen (I think DPMS affects all outputs, in case an external monitor is present, set brightness to zero) when closing the lid and turning it back on when the lid opens. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122467: Add open wallpaper action
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122467/ --- Review request for Plasma. Bugs: 343854 https://bugs.kde.org/show_bug.cgi?id=343854 Repository: plasma-workspace Description --- This restores the Open Wallpaper action we had in the 4.x slideshow Diffs - wallpapers/image/imagepackage/contents/ui/main.qml 1378d54 Diff: https://git.reviewboard.kde.org/r/122467/diff/ Testing --- Slideshow configured, right click on desktop, chose Open Wallpaper, image opened in the default application. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122467: Add open wallpaper action
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122467/#review75575 --- Ship it! Ship It! - Jeremy Whiting On Feb. 7, 2015, 1:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122467/ --- (Updated Feb. 7, 2015, 1:19 p.m.) Review request for Plasma. Bugs: 343854 https://bugs.kde.org/show_bug.cgi?id=343854 Repository: plasma-workspace Description --- This restores the Open Wallpaper action we had in the 4.x slideshow Diffs - wallpapers/image/imagepackage/contents/ui/main.qml 1378d54 Diff: https://git.reviewboard.kde.org/r/122467/diff/ Testing --- Slideshow configured, right click on desktop, chose Open Wallpaper, image opened in the default application. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122467: Add open wallpaper action
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122467/ --- (Updated Feb. 7, 2015, 8:26 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 343854 https://bugs.kde.org/show_bug.cgi?id=343854 Repository: plasma-workspace Description --- This restores the Open Wallpaper action we had in the 4.x slideshow Diffs - wallpapers/image/imagepackage/contents/ui/main.qml 1378d54 Diff: https://git.reviewboard.kde.org/r/122467/diff/ Testing --- Slideshow configured, right click on desktop, chose Open Wallpaper, image opened in the default application. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122470: Optimize DataSource
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/ --- Review request for Plasma. Repository: plasma-framework Description --- This optimizes the DataSource Item. - Use QQmlParserStatus to provide event compression for the setupData() method so it is only called once all the bindings have been setup, it used to be called repeatedly a lot - Split setting up the binding outside of setupData, so connections like connectedSources: sources work with this new approach (that consumer thing looks like it leaks) - Re-introduce interval alignment, this allows the clock to use a 60s interval for polling and align to the minute, need to use int since we cannot pass an enum defined in a different class - Cache sources() and emit change signal only when it has actually changed Diffs - src/declarativeimports/core/datasource.h 3aaa2bb src/declarativeimports/core/datasource.cpp 759e5f4 Diff: https://git.reviewboard.kde.org/r/122470/diff/ Testing --- Battery monitor, which does crazy things to the data source works, media controller works, and the clock is able to align to the minute. Could potentially speed up applet initialization a little. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 Eike Hein h...@kde.org changed: What|Removed |Added CC||h...@kde.org --- Comment #2 from Eike Hein h...@kde.org --- It's because the Background Contrast effect is available in OpenGL, but not XRender. The OpenGL version is the intended design. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122473: Treat normal selected timezone as local if it matches the local
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122473/ --- Review request for Plasma. Bugs: 343908 https://bugs.kde.org/show_bug.cgi?id=343908 Repository: plasma-workspace Description --- The real timezone that Local links to is also in the list of timezones for which teh time can be displayed. For whatever reason, it can happen that the real timezone is selected and not 'Local' and then it's not treated as local anymore, making the Show local timezone setting not work. This fixes it. Diffs - applets/digital-clock/package/contents/ui/DigitalClock.qml 0389f2a Diff: https://git.reviewboard.kde.org/r/122473/diff/ Testing --- Selected Europe/Prague and deselected Local, Show local timezone setting still works. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 --- Comment #3 from supaiku supa...@protonmail.ch --- Created attachment 90966 -- https://bugs.kde.org/attachment.cgi?id=90966action=edit Transparency with OpenGL -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService
On Feb. 7, 2015, 1 a.m., Kai Uwe Broulik wrote: File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png https://git.reviewboard.kde.org/r/122452/#fcomment283 I suggest you add a dialog background framesvg item around it to ease visiblity. Also y should be 2 * (background.height - osd.height) * 3 This ensures consistency between the real OSD and this one. Personally I thought this actually looks better in here than the huge rectangle around. Though maybe it should have at least some rectangle around if not the whole background. Also there are the cases with custom wallpaper which might make this not very clearly seen (well hello blurred desktop background ^_^), sooo...probably should have the whole background, yeah :S - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review75551 --- On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- (Updated Feb. 6, 2015, 1:03 p.m.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Emitting dbus signals allows interested parties to be notified about OSD changes. E.g. the lock screen might want to show the OSD values, but blocks the actual OSD, so it needs to be informed about changes to react on them. [lookandfeel] Split mainItem of Osd into a dedicated OsdItem Allows to reuse the content of the Osd in other parts without having it to be a Dialog. [screenlocker] Support OnScreenDisplay messages KSld connects to the DBus signals for the OnScreenDisplay and forwards them to the greeter application through the private Wayland protocol. The idea here is to not have the greeter connect to the DBus as in future it would be preferable if the greeter cannot connect to DBus. The lookandfeel package might expose an object called onScreenDisplay. Whenever an OSD message is recieved by the greeter it looks for such an object and updates the osd specific properties. The default breeze lookandfeel package integrates the OsdItem from the same lookandfeel package. Diffs - ksmserver/screenlocker/greeter/greeterapp.h 4a90fafee810940c3f932c8e2bfed10459adc425 ksmserver/screenlocker/greeter/greeterapp.cpp a23b5625adc99661ab07534403ee23d005581c03 ksmserver/screenlocker/protocols/ksld.xml bfb32190bf2529a14b39fac4c7e6029a5df811d0 ksmserver/screenlocker/waylandserver.h 5a8ed2249152277b505fe7a944b1b7251ef995d3 ksmserver/screenlocker/waylandserver.cpp 746032e1a7b1bad3625b9f0a156de059e5fba31a lookandfeel/contents/lockscreen/LockScreen.qml 1c4e4a510dd9196ae2b36bc355490580c06a78a6 lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 lookandfeel/contents/osd/OsdItem.qml PRE-CREATION shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 Diff: https://git.reviewboard.kde.org/r/122452/diff/ Testing --- File Attachments Lock screen with volume OSD https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService
On Feb. 7, 2015, 1 a.m., Kai Uwe Broulik wrote: File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png https://git.reviewboard.kde.org/r/122452/#fcomment284 I suggest you add a dialog background framesvg item around it to ease visiblity. Also y should be 2 * (background.height - osd.height) * 3 This ensures consistency between the real OSD and this one. Martin Klapetek wrote: Personally I thought this actually looks better in here than the huge rectangle around. Though maybe it should have at least some rectangle around if not the whole background. Also there are the cases with custom wallpaper which might make this not very clearly seen (well hello blurred desktop background ^_^), sooo...probably should have the whole background, yeah :S Second thought - this should have the background of the lock strip maybe? The dark one? Maybe? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review75551 --- On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- (Updated Feb. 6, 2015, 1:03 p.m.) Review request for Plasma and Martin Klapetek. Repository: plasma-workspace Description --- Emitting dbus signals allows interested parties to be notified about OSD changes. E.g. the lock screen might want to show the OSD values, but blocks the actual OSD, so it needs to be informed about changes to react on them. [lookandfeel] Split mainItem of Osd into a dedicated OsdItem Allows to reuse the content of the Osd in other parts without having it to be a Dialog. [screenlocker] Support OnScreenDisplay messages KSld connects to the DBus signals for the OnScreenDisplay and forwards them to the greeter application through the private Wayland protocol. The idea here is to not have the greeter connect to the DBus as in future it would be preferable if the greeter cannot connect to DBus. The lookandfeel package might expose an object called onScreenDisplay. Whenever an OSD message is recieved by the greeter it looks for such an object and updates the osd specific properties. The default breeze lookandfeel package integrates the OsdItem from the same lookandfeel package. Diffs - ksmserver/screenlocker/greeter/greeterapp.h 4a90fafee810940c3f932c8e2bfed10459adc425 ksmserver/screenlocker/greeter/greeterapp.cpp a23b5625adc99661ab07534403ee23d005581c03 ksmserver/screenlocker/protocols/ksld.xml bfb32190bf2529a14b39fac4c7e6029a5df811d0 ksmserver/screenlocker/waylandserver.h 5a8ed2249152277b505fe7a944b1b7251ef995d3 ksmserver/screenlocker/waylandserver.cpp 746032e1a7b1bad3625b9f0a156de059e5fba31a lookandfeel/contents/lockscreen/LockScreen.qml 1c4e4a510dd9196ae2b36bc355490580c06a78a6 lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 lookandfeel/contents/osd/OsdItem.qml PRE-CREATION shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 Diff: https://git.reviewboard.kde.org/r/122452/diff/ Testing --- File Attachments Lock screen with volume OSD https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 --- Comment #4 from supaiku supa...@protonmail.ch --- Created attachment 90967 -- https://bugs.kde.org/attachment.cgi?id=90967action=edit Transparency with XRender -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343907] New: Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 Bug ID: 343907 Summary: Breeze plasma panel doesn't use transparency with OpenGL backend Product: Breeze Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: supa...@protonmail.ch It's well explained here - https://bbs.archlinux.org/viewtopic.php?pid=1500613#p1500613 tl;dr: Using XRender makes the plasma panel transparent, OpenGL doesn't. What's the intended behaviour here? IMO it should be transparent regardless of the backend. Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kwin] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 supaiku supa...@protonmail.ch changed: What|Removed |Added Component|general |compositing Product|Breeze |kwin Version|unspecified |5.2.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kwin] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 --- Comment #5 from supaiku supa...@protonmail.ch --- @Mark Dunno how to edit the description. I added the screenshots as an attachment and moved the bug to KWin. @Eike Hein Well ok... but it looks better with more transparency. Especially for dark backgrounds. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 Mark mark...@gmail.com changed: What|Removed |Added CC||mark...@gmail.com --- Comment #1 from Mark mark...@gmail.com --- You do realize that this is upstream, right? All the relevant information for a bug should be placed here, not in a forum thread on archlinux. Please do add the proper description here along with the screenshots. For what it's worth, i also find it a bit weird that the taskbar is more transparent with XRender then it is witl OpenGL. I also think this isn't breeze specific. You just happen to see it in breeze. I'm guessing it's kwin. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kwin] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 --- Comment #6 from Eike Hein h...@kde.org --- Note that you can go to Desktop Effects and disable the Background Contrast effect if you prefer the look without it. Its introduction has been very well received, though. It's unlikely the effect will be ported to XRender, I think. It might be possible to make the asset used in XRender mode look similar to some degree, but then the user can't disable it anymore since it's baked into the theme. Overall I'm not sure there's much to do here, although consistent behavior across all modes would be nice, of course. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122470: Optimize DataSource
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/#review75581 --- +1 src/declarativeimports/core/datasource.h https://git.reviewboard.kde.org/r/122470/#comment52279 use the enum? at the very least reference it in the docs. - David Edmundson On Feb. 7, 2015, 10:21 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/ --- (Updated Feb. 7, 2015, 10:21 p.m.) Review request for Plasma. Repository: plasma-framework Description --- This optimizes the DataSource Item. - Use QQmlParserStatus to provide event compression for the setupData() method so it is only called once all the bindings have been setup, it used to be called repeatedly a lot - Split setting up the binding outside of setupData, so connections like connectedSources: sources work with this new approach (that consumer thing looks like it leaks) - Re-introduce interval alignment, this allows the clock to use a 60s interval for polling and align to the minute, need to use int since we cannot pass an enum defined in a different class - Cache sources() and emit change signal only when it has actually changed Diffs - src/declarativeimports/core/datasource.h 3aaa2bb src/declarativeimports/core/datasource.cpp 759e5f4 Diff: https://git.reviewboard.kde.org/r/122470/diff/ Testing --- Battery monitor, which does crazy things to the data source works, media controller works, and the clock is able to align to the minute. Could potentially speed up applet initialization a little. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
