[Powerdevil] [Bug 343631] With buttons event handling set to turn off screen, screen does not turn off
https://bugs.kde.org/show_bug.cgi?id=343631 --- Comment #4 from Oded Arbel o...@geek.co.il --- (In reply to Kai Uwe Broulik from comment #1) Can you check the output of qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement org.kde.Solid.PowerManagement.isActionSupported DPMSControl The output is true. Also, running `org.kde.Solid.PowerManagement.isLidClosed` in a loop while I close and open the lid shows that the lid detection works fine. Interesting behavior, which may or may not be related - if I close the lid and then open it again, then click the mouse anywhere on a plasma element (panel, desktop, but not the inside of an application window), then the screen turns off and immediately turns back on. Here's the (trimmed and annotated) output of a loop displaying the output of running Solid's `IsLidClose` and `xset`s DPMS and Monitor status in a loop: Lid closed: false, DPMS is Enabled Monitor is On ## we start with this ... Lid closed: true, DPMS is Enabled Monitor is On ## closed the lid ... Lid closed: false, DPMS is Enabled Monitor is On ## opened the lid ... Lid closed: false, DPMS is Enabled Monitor is Off ## Clicked a task bar entry, screen blanks Lid closed: false, DPMS is Enabled Monitor is Off ## Screen is now back on ... And yes, the laptop's LCD screen is on, even though `xset` reports Monitor is Off. If I turn off the battery applet's Enable Power Management, then turn it back on, then `xset`s goes back to reporting Monitor is On. I've also managed, at one point, to have the screen actually turned off about 8 seconds after I closed the lid, but I couldn't reproduce - so it might be a combination of behaviors associated with the behavior described above, that I didn't manage properly. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 342882] Broken battery notification popups at random times during computer use
https://bugs.kde.org/show_bug.cgi?id=342882 --- Comment #2 from Antonis G. gaanto...@civil.auth.gr --- Sorry after my exams are finished I will get back to you. (my main system is kde 4 and I need to recompile everything kf5 to test) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343930] New: Widgets that are disabled do not render themselves in the faded state
https://bugs.kde.org/show_bug.cgi?id=343930 Bug ID: 343930 Summary: Widgets that are disabled do not render themselves in the faded state Product: Breeze Version: 5.1.95 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: kitts.mailingli...@gmail.com Pure Qt4 based applications only seem to be affected by this. If a widget is disabled, the color scheme does not indicate this in the text color. Reproducible: Always Steps to Reproduce: 1. Open any pure qt4 based application (Take CuteCom as an example) 2. Look for any disabled widgets (The close button should be disabled initially in cutecom) 3. Unless you try clicking on the disabled widget, you never know that it is disabled to begin with. Actual Results: The disabled widget in indistinguishable. Expected Results: The disabled widget should be grayed out. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122371: Disable session management for kwrited
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122371/#review75599 --- bump - Xuetian Weng On Feb. 1, 2015, 8:55 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122371/ --- (Updated Feb. 1, 2015, 8:55 p.m.) Review request for Plasma. Bugs: 343550 https://bugs.kde.org/show_bug.cgi?id=343550 Repository: kwrited Description --- kwrited has its autostart file IMHO doesn't need session management. Diffs - kwrited.cpp a4dac6b Diff: https://git.reviewboard.kde.org/r/122371/diff/ Testing --- no kwrited started by session. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122371: Disable session management for kwrited
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122371/#review75601 --- Ship it! kwrited.cpp https://git.reviewboard.kde.org/r/122371/#comment52288 why this? - David Edmundson On Feb. 1, 2015, 8:55 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122371/ --- (Updated Feb. 1, 2015, 8:55 p.m.) Review request for Plasma. Bugs: 343550 https://bugs.kde.org/show_bug.cgi?id=343550 Repository: kwrited Description --- kwrited has its autostart file IMHO doesn't need session management. Diffs - kwrited.cpp a4dac6b Diff: https://git.reviewboard.kde.org/r/122371/diff/ Testing --- no kwrited started by session. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343930] Widgets that are disabled do not render themselves in the faded state
https://bugs.kde.org/show_bug.cgi?id=343930 --- Comment #1 from Kishore kitts.mailingli...@gmail.com --- Created attachment 90976 -- https://bugs.kde.org/attachment.cgi?id=90976action=edit Screenshot of cutecom; a pute qt4 based app. This is a picture for cutecom. The Close button is disabled but you can't tell looking at it. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343930] Widgets that are disabled do not render themselves in the faded state
https://bugs.kde.org/show_bug.cgi?id=343930 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added Component|general |QStyle Assignee|plasma-devel@kde.org|hugo.pere...@free.fr CC||k...@davidedmundson.co.uk -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122392: Fix Klipper Performance issues
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 8, 2015, 5:08 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This patch fixes multiple klipper issues: * Moves filtering logic into a background task. This makes Klipper responsive while the clipboard is being filtered. Previously, Klipper would hang while it was filtering the results. This was worse when there were no matches as Klipper had to go through the entire history. THe computation is immediate on small history sets, but significant on larger sets with larger strings in the clipboard * Provides a progress bar at the top to indicate the filtering process. * Simplifies the code significantly, by: * Moving filtering in a separate class file * Cleaning up Popup proxy to build the menu directly using a QList * Removing the index magic in KlipperPopup. Now we maintain a list of history actions which can be easily cleared. * Removed explicit deletion of the more submenus, as these are owned by the parent menus and should be removed automatically * Avoids flickering of Klipper while removing and inserting actions by forcing the height and width during the update. * Fixes a potential memory leak. The QActions for the KlipperPopup were only removed, but never deleted. The API used to add actions addAction(QAction*) was not taking ownership of the action. This is fixed by deleting the actions manually when clearing. * Fixes a performance issue during menu rendering when truncating large strings. The method call elidedText() can be slow on large pieces of text. This is worked around by creating a much smaller string of the prefix and suffix of the string. We use the average character width to compute the approximate amount of characters which can be displayed and use twice as much. (this is because in corner cases, such as we might end up with a string which is not long enough). This also fixes the bug https://bugs.kde.org/show_bug.cgi?id=238084 Diffs - klipper/popupproxy.h f33f62c117a08ddbe6b761da4c2e28e51b985044 klipper/popupproxy.cpp 12dd3dd637d0ff9d134fb71237d6f0d3bcc5bd77 klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 klipper/filterresult.h PRE-CREATION klipper/filterresult.cpp PRE-CREATION klipper/history.h 1bfd0424714ff79d93206a74cb7e4214a6c8c652 klipper/history.cpp 9640c23b0cf06dd0135ca573aea0819e2788b852 klipper/historyfilter.h PRE-CREATION klipper/historyfilter.cpp PRE-CREATION klipper/klipperpopup.h 6f7b30747562b5e7227504b8c53be2863686072b klipper/klipperpopup.cpp 0b2f11d6d6d95e96ece0ac7b386fae2492ad0efd Diff: https://git.reviewboard.kde.org/r/122392/diff/ Testing --- File Attachments (updated) A screencast with foreground processing vs background processing https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1d998fd9-57fd-4997-92f8-11b8e038e795__screencast.mp4 Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122392: Fix Klipper Performance issues
On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote: could you please split the review in a per-commit review? I find it hard to review as there are so many changes to different areas. Especially I think there are a few no-brainer which could go in quickly, while the threaded filtering is the part which needs most thought, so having that in a dedicated review would certainly help :-) Filip Wieladek wrote: Yes, I can do that once I get home. If you really believe that the popup is going away anyway, then I would however prefer to work on the new way, so that the legacy way can be removed. Martin Gräßlin wrote: we probably cannot completely remove the legacy way as we still want to support the dedicated klipper mode without plasmoid. So improvements on that are still fine. I looked at splitting the change, but what hit me is that none of the changes I have make much of a difference unless I have background filtering. Unless background filtering is enabled, the UI still remains to be very sluggish. I have attached a screencast with the current version vs the version with my changes. Note, that the UI is sluggish when there are a lot of entries (e.g. 2048) which are also long. This happens quite frequently in my workflow where I copy the contents of whole files - Filip --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75260 --- On Feb. 8, 2015, 5:08 p.m., Filip Wieladek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 8, 2015, 5:08 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This patch fixes multiple klipper issues: * Moves filtering logic into a background task. This makes Klipper responsive while the clipboard is being filtered. Previously, Klipper would hang while it was filtering the results. This was worse when there were no matches as Klipper had to go through the entire history. THe computation is immediate on small history sets, but significant on larger sets with larger strings in the clipboard * Provides a progress bar at the top to indicate the filtering process. * Simplifies the code significantly, by: * Moving filtering in a separate class file * Cleaning up Popup proxy to build the menu directly using a QList * Removing the index magic in KlipperPopup. Now we maintain a list of history actions which can be easily cleared. * Removed explicit deletion of the more submenus, as these are owned by the parent menus and should be removed automatically * Avoids flickering of Klipper while removing and inserting actions by forcing the height and width during the update. * Fixes a potential memory leak. The QActions for the KlipperPopup were only removed, but never deleted. The API used to add actions addAction(QAction*) was not taking ownership of the action. This is fixed by deleting the actions manually when clearing. * Fixes a performance issue during menu rendering when truncating large strings. The method call elidedText() can be slow on large pieces of text. This is worked around by creating a much smaller string of the prefix and suffix of the string. We use the average character width to compute the approximate amount of characters which can be displayed and use twice as much. (this is because in corner cases, such as we might end up with a string which is not long enough). This also fixes the bug https://bugs.kde.org/show_bug.cgi?id=238084 Diffs - klipper/popupproxy.h f33f62c117a08ddbe6b761da4c2e28e51b985044 klipper/popupproxy.cpp 12dd3dd637d0ff9d134fb71237d6f0d3bcc5bd77 klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 klipper/filterresult.h PRE-CREATION klipper/filterresult.cpp PRE-CREATION klipper/history.h 1bfd0424714ff79d93206a74cb7e4214a6c8c652 klipper/history.cpp 9640c23b0cf06dd0135ca573aea0819e2788b852 klipper/historyfilter.h PRE-CREATION klipper/historyfilter.cpp PRE-CREATION klipper/klipperpopup.h 6f7b30747562b5e7227504b8c53be2863686072b klipper/klipperpopup.cpp 0b2f11d6d6d95e96ece0ac7b386fae2492ad0efd Diff: https://git.reviewboard.kde.org/r/122392/diff/ Testing --- File Attachments A screencast with foreground processing vs background processing https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1d998fd9-57fd-4997-92f8-11b8e038e795__screencast.mp4 Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
On Feb. 5, 2015, 5:16 p.m., Martin Gräßlin wrote: how difficult would it be to get this with runtime detection? Just because the distro compiles with systemd support doesn't mean the user uses systemd (c.f. Debian). David Edmundson wrote: They don't need to use it, they just need to have it installed. It's possible; we'd just have to query some read property from timedated and see if it errors in the kcmodule ctor then switch accordingly. Downside is it means we still needs to provide our helper, even though it won't be used and the code gets even uglier. Martin Gräßlin wrote: if it works with having it just installed without needing e.g. systemd as init, that's good enough, I'd say. I went for runtime. On reflection I think it makes sense. As much as I like stirring up some controversy, this is both politically and practically safer for now. It's not like people with timedated are going to lose much by having to install a tiny helper. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review75487 --- On Feb. 8, 2015, 5:18 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 8, 2015, 5:18 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs - kcms/dateandtime/timedated1.xml PRE-CREATION kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_stable_qt5 #55
See http://build.kde.org/job/plasma-workspace_stable_qt5/55/changes
Changes:
[lukas] set the right widget theme
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_stable_qt5/ws/
Running Prebuild steps
[plasma-workspace_stable_qt5] $ /bin/sh -xe /tmp/hudson519002251813055846.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
210e916..e9681f2 Plasma/5.2 - origin/Plasma/5.2
8c67628..ca2df47 master - origin/master
Branch jenkins set up to track remote branch Plasma/5.2 from origin.
== Cleaning Source Tree
HEAD is now at 210e916 Merge branch 'Plasma/5.2' of
git://anongit.kde.org/plasma-workspace into Plasma/5.2
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@19100ec7
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision e9681f258d234baaa66957629cea5f4ef4387a1b
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f e9681f258d234baaa66957629cea5f4ef4387a1b
git rev-list 210e91654a9f9f451ff9b1027c24672c7567c265 # timeout=10
git tag -a -f -m Jenkins Build #55 jenkins-plasma-workspace_stable_qt5-55 #
timeout=10
[plasma-workspace_stable_qt5] $ /bin/sh -xe /tmp/hudson4104201403913319792.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch Plasma/5.2
== Build Dependencies:
libksysguard - Branch Plasma/5.2
kactivities - Branch master
khelpcenter - Branch Plasma/5.2
kconfig - Branch master
kwidgetsaddons - Branch master
kdecoration - Branch Plasma/5.2
kjsembed - Branch master
libgit2 - Branch master
kwallet - Branch master
dogtail - Branch master
kio - Branch master
kpty - Branch master
sonnet - Branch master
kemoticons - Branch master
attica - Branch master
kfilemetadata - Branch Plasma/5.2
kidletime - Branch master
khtml - Branch master
kglobalaccel - Branch master
knotifyconfig - Branch master
kbookmarks - Branch master
kdoctools - Branch master
kinit - Branch master
kdnssd - Branch master
kio-extras - Branch Plasma/5.2
threadweaver - Branch master
kconfigwidgets - Branch master
kded - Branch master
frameworkintegration - Branch master
solid - Branch master
kdbusaddons - Branch master
kcompletion - Branch master
kwindowsystem - Branch master
polkit-qt-1 - Branch master
kjobwidgets - Branch master
extra-cmake-modules - Branch master
kcoreaddons - Branch master
breeze - Branch Plasma/5.2
kguiaddons - Branch master
milou - Branch Plasma/5.2
kparts - Branch master
kxmlgui - Branch master
kwayland - Branch Plasma/5.2
phonon - Branch master
kdesupport-svn - Branch master
baloo - Branch Plasma/5.2
cmake - Branch master
kdelibs4support - Branch master
karchive - Branch master
kiconthemes - Branch master
qt5 - Branch 5.3.2
kdeclarative - Branch master
ktexteditor - Branch master
kdewebkit - Branch master
kitemviews - Branch master
kcrash - Branch master
kitemmodels - Branch master
libkscreen - Branch Plasma/5.2
poppler - Branch master
libssh - Branch master
libdbusmenu-qt - Branch master
knewstuff - Branch master
kauth - Branch master
kross - Branch master
kservice - Branch master
krunner - Branch master
kcodecs - Branch master
kunitconversion - Branch master
kcmutils - Branch master
ki18n - Branch master
kpackage - Branch master
ktextwidgets - Branch master
knotifications - Branch master
kdesu - Branch master
kplotting - Branch master
kdesignerplugin - Branch master
kwin - Branch Plasma/5.2
kjs - Branch master
kde-cli-tools - Branch Plasma/5.2
plasma-framework - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/general/poppler/inst
failed: No such file or directory (2)
rsync error: some files/attrs were
[kwin] [Bug 343907] Breeze plasma panel doesn't use transparency with OpenGL backend
https://bugs.kde.org/show_bug.cgi?id=343907 Martin Gräßlin mgraess...@kde.org changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED --- Comment #7 from Martin Gräßlin mgraess...@kde.org --- intended design as explained. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 8, 2015, 5:18 p.m.) Review request for Plasma. Changes --- Changed to runtime detection. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs (updated) - kcms/dateandtime/timedated1.xml PRE-CREATION kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122470: Optimize DataSource
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/#review75620 --- LGTM src/declarativeimports/core/datasource.cpp https://git.reviewboard.kde.org/r/122470/#comment52294 Why this empty comment? Maybe it would be better to align all data sources and make them wake up at the same time rather than having separate timers for all of them. - Aleix Pol Gonzalez On Feb. 7, 2015, 11:21 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/ --- (Updated Feb. 7, 2015, 11:21 p.m.) Review request for Plasma. Repository: plasma-framework Description --- This optimizes the DataSource Item. - Use QQmlParserStatus to provide event compression for the setupData() method so it is only called once all the bindings have been setup, it used to be called repeatedly a lot - Split setting up the binding outside of setupData, so connections like connectedSources: sources work with this new approach (that consumer thing looks like it leaks) - Re-introduce interval alignment, this allows the clock to use a 60s interval for polling and align to the minute, need to use int since we cannot pass an enum defined in a different class - Cache sources() and emit change signal only when it has actually changed Diffs - src/declarativeimports/core/datasource.h 3aaa2bb src/declarativeimports/core/datasource.cpp 759e5f4 Diff: https://git.reviewboard.kde.org/r/122470/diff/ Testing --- Battery monitor, which does crazy things to the data source works, media controller works, and the clock is able to align to the minute. Could potentially speed up applet initialization a little. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75633 --- Good stuff! Perhaps add some visual hover feedback on the month/year so it's evident that it's live compared to hovering on other text. Nothing other than that. Very nice! - Andrew Lake On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Feb. 8, 2015, 9:54 nachm., Andrew Lake wrote: Good stuff! Perhaps add some visual hover feedback on the month/year so it's evident that it's live compared to hovering on other text. Nothing other than that. Very nice! Yes, I thought the same, I wanted to turn it into a ToolButton so it gets both hover feedback and a tooltip but not sure how to get the same text alignment that way. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75633 --- On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75635 --- That's some seriously cool stuff. One thing I noticed in the video - what happened with the bottom frame of the calendar? Seems missing. I'll do proper review tomorrow. - Martin Klapetek On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 9:52 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 nachm.) Review request for Plasma and KDE Usability. Changes --- Add usability group Repository: plasma-framework Description (updated) --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122470: Optimize DataSource
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122470/ --- (Updated Feb. 8, 2015, 9:06 nachm.) Review request for Plasma. Changes --- - Use the enum, so I suppose it's only Q_INVOKABLEs that suffer from this? - Remove empty comment, bad habit :) Repository: plasma-framework Description --- This optimizes the DataSource Item. - Use QQmlParserStatus to provide event compression for the setupData() method so it is only called once all the bindings have been setup, it used to be called repeatedly a lot - Split setting up the binding outside of setupData, so connections like connectedSources: sources work with this new approach (that consumer thing looks like it leaks) - Re-introduce interval alignment, this allows the clock to use a 60s interval for polling and align to the minute, need to use int since we cannot pass an enum defined in a different class - Cache sources() and emit change signal only when it has actually changed Diffs (updated) - src/declarativeimports/core/datasource.h 3aaa2bb src/declarativeimports/core/datasource.cpp 759e5f4 Diff: https://git.reviewboard.kde.org/r/122470/diff/ Testing --- Battery monitor, which does crazy things to the data source works, media controller works, and the clock is able to align to the minute. Could potentially speed up applet initialization a little. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122464: Remove bell kcm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122464/ --- (Updated Feb. 8, 2015, 8:13 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- The kcm sets up the xbell, but konsole for example doesn't use the xbell but knotify. The code is also xcb only, I have no idea if it could be ported to wayland. For users the knotify way of treating the bell (visual/sound/custom executable) should satisfy all needs. Then there is also the accessibility kcm allowing to switch on and off the system bell (using xbell as well) and allowing to flash the screen in a color (I could not get that one to work, neither using xterm nor konsole). A recent discussion on the accessibility mailing list also gave no real use case for this duplicate kcm to exist. http://lists.kde.org/?t=14202382732r=1w=2 Diffs - kcms/CMakeLists.txt 06056cd kcms/bell/CMakeLists.txt f2ebe19 kcms/bell/Messages.sh cb6a478 kcms/bell/bell.cpp 1c4f552 kcms/bell/bell.desktop f1cd552 kcms/bell/bell.h fda09b5 Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- Review request for Plasma. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Feb. 8, 2015, 10:07 nachm., Martin Klapetek wrote: That's some seriously cool stuff. One thing I noticed in the video - what happened with the bottom frame of the calendar? Seems missing. I'll do proper review tomorrow. That's a rounding error in the height calculation of the grid, the bottom border gets drawn outside the canvas, that's been that way for some time for me, though. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75635 --- On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122489: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/
---
Review request for Plasma and KDE Usability.
Description
---
KDE Plasma 5 system tray applets resize
Diffs
-
Diff: https://git.reviewboard.kde.org/r/122489/diff/
Testing
---
Hello I've modified the size of the expanded system tray applets using the file
main.qml located at:
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I
have uploaded a copy of the modified file below), thus when expanded they take
less space on notebook screens with low resolution (15 inch 1376x768), I also
tested it with a high resolution monitor (19 inch) and it definitely improves
the space there too. Below there are some screenshots with the before and
after the edit.
Also here are the modified values:
Plasmoid.fullRepresentation: ExpandedRepresentation {
Layout.minimumWidth: Layout.minimumHeight * 2.15 // from 1.75
Layout.minimumHeight: units.gridUnit * 12 // from 14
Layout.preferredWidth: Layout.minimumWidth
Layout.preferredHeight: Layout.minimumHeight * 1.5
}
Kind regards!
File Attachments
battery_unmod_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1e78a73d-d0e7-46bf-9bf8-719575f25b3a__battery_unmod_laptop.png
battery_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d318ebb5-4070-4f5c-acc4-7a841ec77799__battery_modif_laptop.png
networks_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2b400553-d97d-4113-94e4-55a870530a5f__networks_modif_laptop.png
networks_unmodif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/c5f2ddb3-7cf3-46e6-9c9f-da126d4fe63b__networks_unmodif_laptop.png
wireless_modif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2ec0e14c-561f-4ae4-9077-117644e2b50e__wireless_modif_hires.png
wireless_unmodif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/387c2b43-aff0-4c72-a5e8-6c564c5d82dd__wireless_unmodif_hires.png
high_unmodif_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/85a7e63e-9c12-4f48-89fe-cc41c3b913ab__high_unmodif_bat.png
high_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d1c4b2d4-e5bb-4897-8d1f-243713044b6e__high_bat.png
main.qml
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f5c63bb7-04af-4338-b7c0-8e8dd8f7bdc0__main.qml
Thanks,
Blaga Florentin Gabriel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122489: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/#review75639
---
Ship it!
Ship It!
- Blaga Florentin Gabriel
On Feb. 8, 2015, 10:37 p.m., Blaga Florentin Gabriel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/
---
(Updated Feb. 8, 2015, 10:37 p.m.)
Review request for Plasma and KDE Usability.
Description
---
KDE Plasma 5 system tray applets resize
Diffs
-
Diff: https://git.reviewboard.kde.org/r/122489/diff/
Testing
---
Hello I've modified the size of the expanded system tray applets using the
file main.qml located at:
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I
have uploaded a copy of the modified file below), thus when expanded they
take less space on notebook screens with low resolution (15 inch 1376x768), I
also tested it with a high resolution monitor (19 inch) and it definitely
improves the space there too. Below there are some screenshots with the
before and after the edit.
Also here are the modified values:
Plasmoid.fullRepresentation: ExpandedRepresentation {
Layout.minimumWidth: Layout.minimumHeight * 2.15 // from 1.75
Layout.minimumHeight: units.gridUnit * 12 // from 14
Layout.preferredWidth: Layout.minimumWidth
Layout.preferredHeight: Layout.minimumHeight * 1.5
}
Kind regards!
File Attachments
battery_unmod_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1e78a73d-d0e7-46bf-9bf8-719575f25b3a__battery_unmod_laptop.png
battery_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d318ebb5-4070-4f5c-acc4-7a841ec77799__battery_modif_laptop.png
networks_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2b400553-d97d-4113-94e4-55a870530a5f__networks_modif_laptop.png
networks_unmodif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/c5f2ddb3-7cf3-46e6-9c9f-da126d4fe63b__networks_unmodif_laptop.png
wireless_modif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2ec0e14c-561f-4ae4-9077-117644e2b50e__wireless_modif_hires.png
wireless_unmodif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/387c2b43-aff0-4c72-a5e8-6c564c5d82dd__wireless_unmodif_hires.png
high_unmodif_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/85a7e63e-9c12-4f48-89fe-cc41c3b913ab__high_unmodif_bat.png
high_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d1c4b2d4-e5bb-4897-8d1f-243713044b6e__high_bat.png
main.qml
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f5c63bb7-04af-4338-b7c0-8e8dd8f7bdc0__main.qml
Thanks,
Blaga Florentin Gabriel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122489: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/#review75640
---
Ship it!
Ship It!
- Blaga Florentin Gabriel
On Feb. 8, 2015, 10:37 p.m., Blaga Florentin Gabriel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/
---
(Updated Feb. 8, 2015, 10:37 p.m.)
Review request for Plasma and KDE Usability.
Description
---
KDE Plasma 5 system tray applets resize
Diffs
-
Diff: https://git.reviewboard.kde.org/r/122489/diff/
Testing
---
Hello I've modified the size of the expanded system tray applets using the
file main.qml located at:
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I
have uploaded a copy of the modified file below), thus when expanded they
take less space on notebook screens with low resolution (15 inch 1376x768), I
also tested it with a high resolution monitor (19 inch) and it definitely
improves the space there too. Below there are some screenshots with the
before and after the edit.
Also here are the modified values:
Plasmoid.fullRepresentation: ExpandedRepresentation {
Layout.minimumWidth: Layout.minimumHeight * 2.15 // from 1.75
Layout.minimumHeight: units.gridUnit * 12 // from 14
Layout.preferredWidth: Layout.minimumWidth
Layout.preferredHeight: Layout.minimumHeight * 1.5
}
Kind regards!
File Attachments
battery_unmod_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1e78a73d-d0e7-46bf-9bf8-719575f25b3a__battery_unmod_laptop.png
battery_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d318ebb5-4070-4f5c-acc4-7a841ec77799__battery_modif_laptop.png
networks_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2b400553-d97d-4113-94e4-55a870530a5f__networks_modif_laptop.png
networks_unmodif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/c5f2ddb3-7cf3-46e6-9c9f-da126d4fe63b__networks_unmodif_laptop.png
wireless_modif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2ec0e14c-561f-4ae4-9077-117644e2b50e__wireless_modif_hires.png
wireless_unmodif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/387c2b43-aff0-4c72-a5e8-6c564c5d82dd__wireless_unmodif_hires.png
high_unmodif_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/85a7e63e-9c12-4f48-89fe-cc41c3b913ab__high_unmodif_bat.png
high_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d1c4b2d4-e5bb-4897-8d1f-243713044b6e__high_bat.png
main.qml
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f5c63bb7-04af-4338-b7c0-8e8dd8f7bdc0__main.qml
Thanks,
Blaga Florentin Gabriel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122489: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/
---
(Updated Feb. 8, 2015, 10:42 p.m.)
Review request for Plasma and KDE Usability.
Changes
---
KDE Plasma 5 system tray expaned applets resized to take less space on
notebooks low resolution screens by editing
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml
Description
---
KDE Plasma 5 system tray applets resize
Diffs
-
Diff: https://git.reviewboard.kde.org/r/122489/diff/
Testing (updated)
---
Hello I've modified the size of the expanded system tray applets using the file
main.qml located at:
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I
have uploaded a copy of the modified file below), thus when expanded they take
less space on notebook screens with low resolution (15 inch 1376x768), I also
tested it with a high resolution monitor (19 inch) and it definitely improves
the space there too. Below there are some screenshots with the before and
after the edit.
Also here are the modified values:
Plasmoid.fullRepresentation: ExpandedRepresentation {
Layout.minimumWidth: Layout.minimumHeight * 2.15 // from 1.75
Layout.minimumHeight: units.gridUnit * 12 // from 14
Layout.preferredWidth: Layout.minimumWidth
Layout.preferredHeight: Layout.minimumHeight * 1.5
}
Kind regards!
File Attachments
battery_unmod_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1e78a73d-d0e7-46bf-9bf8-719575f25b3a__battery_unmod_laptop.png
battery_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d318ebb5-4070-4f5c-acc4-7a841ec77799__battery_modif_laptop.png
networks_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2b400553-d97d-4113-94e4-55a870530a5f__networks_modif_laptop.png
networks_unmodif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/c5f2ddb3-7cf3-46e6-9c9f-da126d4fe63b__networks_unmodif_laptop.png
wireless_modif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2ec0e14c-561f-4ae4-9077-117644e2b50e__wireless_modif_hires.png
wireless_unmodif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/387c2b43-aff0-4c72-a5e8-6c564c5d82dd__wireless_unmodif_hires.png
high_unmodif_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/85a7e63e-9c12-4f48-89fe-cc41c3b913ab__high_unmodif_bat.png
high_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d1c4b2d4-e5bb-4897-8d1f-243713044b6e__high_bat.png
main.qml
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f5c63bb7-04af-4338-b7c0-8e8dd8f7bdc0__main.qml
Thanks,
Blaga Florentin Gabriel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122489: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122489/
---
(Updated Feb. 8, 2015, 10:48 p.m.)
Status
--
This change has been discarded.
Review request for Plasma and KDE Usability.
Description
---
KDE Plasma 5 system tray applets resize
Diffs
-
Diff: https://git.reviewboard.kde.org/r/122489/diff/
Testing
---
Hello I've modified the size of the expanded system tray applets using the file
main.qml located at:
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I
have uploaded a copy of the modified file below), thus when expanded they take
less space on notebook screens with low resolution (15 inch 1376x768), I also
tested it with a high resolution monitor (19 inch) and it definitely improves
the space there too. Below there are some screenshots with the before and
after the edit.
Also here are the modified values:
Plasmoid.fullRepresentation: ExpandedRepresentation {
Layout.minimumWidth: Layout.minimumHeight * 2.15 // from 1.75
Layout.minimumHeight: units.gridUnit * 12 // from 14
Layout.preferredWidth: Layout.minimumWidth
Layout.preferredHeight: Layout.minimumHeight * 1.5
}
Kind regards!
File Attachments
battery_unmod_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1e78a73d-d0e7-46bf-9bf8-719575f25b3a__battery_unmod_laptop.png
battery_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d318ebb5-4070-4f5c-acc4-7a841ec77799__battery_modif_laptop.png
networks_modif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2b400553-d97d-4113-94e4-55a870530a5f__networks_modif_laptop.png
networks_unmodif_laptop.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/c5f2ddb3-7cf3-46e6-9c9f-da126d4fe63b__networks_unmodif_laptop.png
wireless_modif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2ec0e14c-561f-4ae4-9077-117644e2b50e__wireless_modif_hires.png
wireless_unmodif_hires.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/387c2b43-aff0-4c72-a5e8-6c564c5d82dd__wireless_unmodif_hires.png
high_unmodif_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/85a7e63e-9c12-4f48-89fe-cc41c3b913ab__high_unmodif_bat.png
high_bat.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/d1c4b2d4-e5bb-4897-8d1f-243713044b6e__high_bat.png
main.qml
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f5c63bb7-04af-4338-b7c0-8e8dd8f7bdc0__main.qml
Thanks,
Blaga Florentin Gabriel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75641 --- Awesome! But please take care of alternative access (keyboard, mouse wheel) and accessibilty. - Heiko Tietze On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122491: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122491/ --- Review request for Plasma and KDE Usability. Description --- KDE Plasma 5 system tray applets resize Diffs - Diff: https://git.reviewboard.kde.org/r/122491/diff/ Testing --- Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the before and after the edit. Also here are the modified values: 74,75c74,75 Layout.minimumWidth: Layout.minimumHeight * 2.15 Layout.minimumHeight: units.gridUnit * 12 --- Layout.minimumWidth: Layout.minimumHeight * 1.75 Layout.minimumHeight: units.gridUnit * 14 Kind regards! File Attachments main.qml.diff https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b48a4d4d-f1f9-474f-b09a-361705cdfea4__main.qml.diff main.qml https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/379e714e-5aee-4717-90d6-cc16015fcf41__main.qml networks_unmodif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/df932fb4-018f-4413-82ef-bd1095d3af3b__networks_unmodif_laptop.png networks_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2e30dc37-e102-4490-bff6-1992c39f0361__networks_modif_laptop.png battery_unmod_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/bb58fe79-160d-47c4-bfa5-d08b2a89c617__battery_unmod_laptop.png battery_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/0304c37e-f51d-4776-8693-cf54c02e946e__battery_modif_laptop.png high_unmodif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/afcf8ed1-2806-4806-a22d-18cb4c1085e8__high_unmodif_bat.png high_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f2059ea3-30f6-42f0-9ea2-2e79996fff53__high_bat.png wireless_modif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/506fd7b8-20e8-41d0-8026-371be5f8dc95__wireless_modif_hires.png wireless_unmodif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/0e595cef-2890-431c-a843-dfaf665f7f30__wireless_unmodif_hires.png Thanks, Blaga Florentin Gabriel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Feb. 8, 2015, 10:59 nachm., Heiko Tietze wrote: Awesome! But please take care of alternative access (keyboard, mouse wheel) and accessibilty. The calendar lacks any keyboard input and accessibility support whatsoever, so this should be added separately later. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75641 --- On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122491: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122491/ --- (Updated Feb. 8, 2015, 11:01 p.m.) Status -- This change has been discarded. Review request for Plasma and KDE Usability. Description --- KDE Plasma 5 system tray applets resize Diffs - Diff: https://git.reviewboard.kde.org/r/122491/diff/ Testing --- Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the before and after the edit. Also here are the modified values: 74,75c74,75 Layout.minimumWidth: Layout.minimumHeight * 2.15 Layout.minimumHeight: units.gridUnit * 12 --- Layout.minimumWidth: Layout.minimumHeight * 1.75 Layout.minimumHeight: units.gridUnit * 14 Kind regards! File Attachments main.qml.diff https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b48a4d4d-f1f9-474f-b09a-361705cdfea4__main.qml.diff main.qml https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/379e714e-5aee-4717-90d6-cc16015fcf41__main.qml networks_unmodif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/df932fb4-018f-4413-82ef-bd1095d3af3b__networks_unmodif_laptop.png networks_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2e30dc37-e102-4490-bff6-1992c39f0361__networks_modif_laptop.png battery_unmod_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/bb58fe79-160d-47c4-bfa5-d08b2a89c617__battery_unmod_laptop.png battery_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/0304c37e-f51d-4776-8693-cf54c02e946e__battery_modif_laptop.png high_unmodif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/afcf8ed1-2806-4806-a22d-18cb4c1085e8__high_unmodif_bat.png high_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f2059ea3-30f6-42f0-9ea2-2e79996fff53__high_bat.png wireless_modif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/506fd7b8-20e8-41d0-8026-371be5f8dc95__wireless_modif_hires.png wireless_unmodif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/0e595cef-2890-431c-a843-dfaf665f7f30__wireless_unmodif_hires.png Thanks, Blaga Florentin Gabriel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122491: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122491/ --- (Updated Feb. 8, 2015, 11:01 p.m.) Review request for Plasma and KDE Usability. Description --- KDE Plasma 5 system tray applets resize Diffs - Diff: https://git.reviewboard.kde.org/r/122491/diff/ Testing (updated) --- Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the before and after the edit. Also here are the modified values: 74,75c74,75 Layout.minimumWidth: Layout.minimumHeight * 2.15 Layout.minimumHeight: units.gridUnit * 12 --- Layout.minimumWidth: Layout.minimumHeight * 1.75 Layout.minimumHeight: units.gridUnit * 14 Kind regards! File Attachments main.qml.diff https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b48a4d4d-f1f9-474f-b09a-361705cdfea4__main.qml.diff main.qml https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/379e714e-5aee-4717-90d6-cc16015fcf41__main.qml networks_unmodif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/df932fb4-018f-4413-82ef-bd1095d3af3b__networks_unmodif_laptop.png networks_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2e30dc37-e102-4490-bff6-1992c39f0361__networks_modif_laptop.png battery_unmod_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/bb58fe79-160d-47c4-bfa5-d08b2a89c617__battery_unmod_laptop.png battery_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/0304c37e-f51d-4776-8693-cf54c02e946e__battery_modif_laptop.png high_unmodif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/afcf8ed1-2806-4806-a22d-18cb4c1085e8__high_unmodif_bat.png high_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/f2059ea3-30f6-42f0-9ea2-2e79996fff53__high_bat.png wireless_modif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/506fd7b8-20e8-41d0-8026-371be5f8dc95__wireless_modif_hires.png wireless_unmodif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/0e595cef-2890-431c-a843-dfaf665f7f30__wireless_unmodif_hires.png Thanks, Blaga Florentin Gabriel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122492: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122492/ --- Review request for Plasma and KDE Usability. Description --- KDE Plasma 5 system tray expanded applets resize Diffs - Diff: https://git.reviewboard.kde.org/r/122492/diff/ Testing --- Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the before and after the edit. Kind regards! File Attachments main.qml.diff https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/917e1e6f-6113-4881-8e1f-51fa9fb539ba__main.qml.diff main.qml https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/e7063523-5a1b-404e-9146-b4d34676c1a6__main.qml networks_unmodif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05fd3296-9463-4ee1-8c17-6d03c470e96c__networks_unmodif_laptop.png networks_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/afa67907-a0af-440c-9c8e-60446ffd720a__networks_modif_laptop.png battery_unmod_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/3b21e2ea-7925-4f00-a77f-e471ff752290__battery_unmod_laptop.png battery_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/db5f3a2e-70e8-45ec-8004-b8223511104a__battery_modif_laptop.png high_modif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/8c085bd0-0b2b-4754-bf06-b3054a0caf6b__high_modif_bat.png high_unmodif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/e1aa2796-98dd-401e-9c4d-29d5690a194e__high_unmodif_bat.png wireless_unmodif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/077c1074-5b15-42e2-a3d7-b3f9cae39745__wireless_unmodif_hires.png wireless_modif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/9035ec5f-37f3-455e-9af3-9c9df71d5285__wireless_modif_hires.png Thanks, Blaga Florentin Gabriel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-workspace_stable_qt5 #56
See http://build.kde.org/job/plasma-workspace_stable_qt5/56/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Feb. 8, 2015, 10:59 nachm., Heiko Tietze wrote: Awesome! But please take care of alternative access (keyboard, mouse wheel) and accessibilty. Kai Uwe Broulik wrote: The calendar lacks any keyboard input and accessibility support whatsoever, so this should be added separately later. It would be easy to solve when every control gets a label (as the HIG demands). Like Year: 2012 or Month: January, and the dropdown expands on focus or when the hotkey is pressed with access by cursor up/down. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75641 --- On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- (Updated Feb. 9, 2015, 8:33 a.m.) Review request for Plasma and Martin Klapetek. Changes --- new screenshot with a plasma background. Repository: plasma-workspace Description (updated) --- Emitting dbus signals allows interested parties to be notified about OSD changes. E.g. the lock screen might want to show the OSD values, but blocks the actual OSD, so it needs to be informed about changes to react on them. [lookandfeel] Split mainItem of Osd into a dedicated OsdItem Allows to reuse the content of the Osd in other parts without having it to be a Dialog. [screenlocker] Support OnScreenDisplay messages KSld connects to the DBus signals for the OnScreenDisplay and forwards them to the greeter application through the private Wayland protocol. The idea here is to not have the greeter connect to the DBus as in future it would be preferable if the greeter cannot connect to DBus. The lookandfeel package might expose an object called onScreenDisplay. Whenever an OSD message is recieved by the greeter it looks for such an object and updates the osd specific properties. The default breeze lookandfeel package integrates the OsdItem from the same lookandfeel package. Diffs - ksmserver/screenlocker/greeter/greeterapp.h 4a90fafee810940c3f932c8e2bfed10459adc425 ksmserver/screenlocker/greeter/greeterapp.cpp a23b5625adc99661ab07534403ee23d005581c03 ksmserver/screenlocker/protocols/ksld.xml bfb32190bf2529a14b39fac4c7e6029a5df811d0 ksmserver/screenlocker/waylandserver.h 5a8ed2249152277b505fe7a944b1b7251ef995d3 ksmserver/screenlocker/waylandserver.cpp 746032e1a7b1bad3625b9f0a156de059e5fba31a lookandfeel/contents/lockscreen/LockScreen.qml 1c4e4a510dd9196ae2b36bc355490580c06a78a6 lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 lookandfeel/contents/osd/OsdItem.qml PRE-CREATION shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 Diff: https://git.reviewboard.kde.org/r/122452/diff/ Testing --- File Attachments (updated) Lock screen with volume OSD https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png With background https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- (Updated Feb. 9, 2015, 8:35 a.m.) Review request for Plasma and Martin Klapetek. Changes --- Added the background Repository: plasma-workspace Description --- Emitting dbus signals allows interested parties to be notified about OSD changes. E.g. the lock screen might want to show the OSD values, but blocks the actual OSD, so it needs to be informed about changes to react on them. [lookandfeel] Split mainItem of Osd into a dedicated OsdItem Allows to reuse the content of the Osd in other parts without having it to be a Dialog. [screenlocker] Support OnScreenDisplay messages KSld connects to the DBus signals for the OnScreenDisplay and forwards them to the greeter application through the private Wayland protocol. The idea here is to not have the greeter connect to the DBus as in future it would be preferable if the greeter cannot connect to DBus. The lookandfeel package might expose an object called onScreenDisplay. Whenever an OSD message is recieved by the greeter it looks for such an object and updates the osd specific properties. The default breeze lookandfeel package integrates the OsdItem from the same lookandfeel package. Diffs (updated) - ksmserver/screenlocker/greeter/greeterapp.h 4a90fafee810940c3f932c8e2bfed10459adc425 ksmserver/screenlocker/greeter/greeterapp.cpp a23b5625adc99661ab07534403ee23d005581c03 ksmserver/screenlocker/protocols/ksld.xml bfb32190bf2529a14b39fac4c7e6029a5df811d0 ksmserver/screenlocker/waylandserver.h 5a8ed2249152277b505fe7a944b1b7251ef995d3 ksmserver/screenlocker/waylandserver.cpp 746032e1a7b1bad3625b9f0a156de059e5fba31a lookandfeel/contents/lockscreen/LockScreen.qml 1c4e4a510dd9196ae2b36bc355490580c06a78a6 lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 lookandfeel/contents/osd/OsdItem.qml PRE-CREATION shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 Diff: https://git.reviewboard.kde.org/r/122452/diff/ Testing --- File Attachments Lock screen with volume OSD https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png With background https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122339: Add KWorkSpace::isShuttingDown()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/#review75659 --- libkworkspace/kworkspace.cpp https://git.reviewboard.kde.org/r/122339/#comment52313 why bind to HAVE_X11? If it's not X11 the call will fail and return false. - Martin Gräßlin On Jan. 31, 2015, 5:02 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/ --- (Updated Jan. 31, 2015, 5:02 p.m.) Review request for Plasma and Martin Gräßlin. Bugs: 189456 https://bugs.kde.org/show_bug.cgi?id=189456 Repository: plasma-workspace Description --- Since KSMServer does the session teardown, we can't just rely on Logind's PreparingForShutdown property. This patch will allow for instance PowerDevil to not suspend the session when it's currently shutting down, otherwise you'll have your system suspend and continue shutting down after resuming. Diffs - ksmserver/shutdown.cpp e6bc708 libkworkspace/kworkspace.h 816f8f1 libkworkspace/kworkspace.cpp ac979bd ksmserver/org.kde.KSMServerInterface.xml 9dad130 ksmserver/server.h 20b5faa Diff: https://git.reviewboard.kde.org/r/122339/diff/ Testing --- Works, adjusted PowerDevil and the system did not suspend during shutdown. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review75660 --- Thanks for going runtime selection. I think that will be appreciated kcms/dateandtime/CMakeLists.txt https://git.reviewboard.kde.org/r/122400/#comment52314 nitpick: removed an empty line kcms/dateandtime/dtime.cpp https://git.reviewboard.kde.org/r/122400/#comment52315 nitpick: added empty lines kcms/dateandtime/main.cpp https://git.reviewboard.kde.org/r/122400/#comment52317 does it need to be a blocking dbus call? Any chance in getting it use a watcher? kcms/dateandtime/main.cpp https://git.reviewboard.kde.org/r/122400/#comment52316 suggestion: move it into the dbus reply check kcms/dateandtime/main.cpp https://git.reviewboard.kde.org/r/122400/#comment52318 why wait? If I understand correctly the next dbus calls do not depend on the outcome of the first one. So you could just fire all of them and only check in the end whether they failed. - Martin Gräßlin On Feb. 8, 2015, 6:18 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 8, 2015, 6:18 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs - kcms/dateandtime/timedated1.xml PRE-CREATION kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Úno. 9, 2015, 2:40 dop., Lukáš Tinkl wrote: src/declarativeimports/calendar/qml/MonthView.qml, line 61 https://git.reviewboard.kde.org/r/122488/diff/1/?file=347954#file347954line61 I know this is not your code but still... we must absolutely not make any asumptions about how the strings should be rendered. In some languages it's just plain wrong to display month names capitalized. For the rationale: http://meta.wikimedia.org/wiki/Capitalization_of_Wiktionary_pages#Capitalization_of_month_names Most languages DO NOT capitalize month names - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75650 --- On Úno. 8, 2015, 9:52 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Úno. 8, 2015, 9:52 odp.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Feb. 8, 2015, 10:59 p.m., Heiko Tietze wrote: Awesome! But please take care of alternative access (keyboard, mouse wheel) and accessibilty. Kai Uwe Broulik wrote: The calendar lacks any keyboard input and accessibility support whatsoever, so this should be added separately later. Heiko Tietze wrote: It would be easy to solve when every control gets a label (as the HIG demands). Like Year: 2012 or Month: January, and the dropdown expands on focus or when the hotkey is pressed with access by cursor up/down. That would do the trick in the QWidget world, but we're in the QtQuick world here, where everything is... different. When Kai Uwe says there is no accessibility support yet then trust him: If it were easy to fix, he'd already have done it ;) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75641 --- On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122494: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122494/ --- Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- KDE Plasma 5 system tray expanded applets resize for notebooks Diffs - .reviewboardrc 771837c982012f580f10923aa83d83b181afc881 applets/systemtray/package/contents/ui/main.qml 553ad7a23d8d18974a02f35dc64b3f7dd4816585 Diff: https://git.reviewboard.kde.org/r/122494/diff/ Testing --- Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the before and after the edit. Kind regards! File Attachments battery_unmod_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05de2078-6dce-4578-a6a4-06bb6811e7e1__battery_unmod_laptop.png battery_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2c497b47-5180-420e-93bb-09a0225acd3b__battery_modif_laptop.png networks_unmodif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/4752ba6f-329b-461b-bab9-b3cf6c6707ae__networks_unmodif_laptop.png networks_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b614adf0-9d88-4c64-a448-07c9f5d39fd5__networks_modif_laptop.png high_unmodif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1600dac7-9516-4ec9-b66e-ce595c82d10a__high_unmodif_bat.png high_modif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/7f00e424-1c76-490a-a698-ec25e148101c__high_modif_bat.png wireless_unmodif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/71a32e89-ffdd-49c4-9db2-8a0e02b1c777__wireless_unmodif_hires.png wireless_modif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/469148e3-9ac6-4e0e-aafc-91431e87a48d__wireless_modif_hires.png Thanks, Blaga Florentin Gabriel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122492: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122492/ --- (Updated Feb. 8, 2015, 11:35 p.m.) Status -- This change has been discarded. Review request for Plasma and KDE Usability. Description --- KDE Plasma 5 system tray expanded applets resize Diffs - Diff: https://git.reviewboard.kde.org/r/122492/diff/ Testing --- Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the before and after the edit. Kind regards! File Attachments main.qml.diff https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/917e1e6f-6113-4881-8e1f-51fa9fb539ba__main.qml.diff main.qml https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/e7063523-5a1b-404e-9146-b4d34676c1a6__main.qml networks_unmodif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05fd3296-9463-4ee1-8c17-6d03c470e96c__networks_unmodif_laptop.png networks_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/afa67907-a0af-440c-9c8e-60446ffd720a__networks_modif_laptop.png battery_unmod_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/3b21e2ea-7925-4f00-a77f-e471ff752290__battery_unmod_laptop.png battery_modif_laptop.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/db5f3a2e-70e8-45ec-8004-b8223511104a__battery_modif_laptop.png high_modif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/8c085bd0-0b2b-4754-bf06-b3054a0caf6b__high_modif_bat.png high_unmodif_bat.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/e1aa2796-98dd-401e-9c4d-29d5690a194e__high_unmodif_bat.png wireless_unmodif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/077c1074-5b15-42e2-a3d7-b3f9cae39745__wireless_unmodif_hires.png wireless_modif_hires.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/9035ec5f-37f3-455e-9af3-9c9df71d5285__wireless_modif_hires.png Thanks, Blaga Florentin Gabriel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75649 --- src/declarativeimports/calendar/calendar.cpp https://git.reviewboard.kde.org/r/122488/#comment52303 replace with: setDisplayDate(QDate(m_displayedDate.year(), month, m_displayedDate.day())); src/declarativeimports/calendar/calendar.cpp https://git.reviewboard.kde.org/r/122488/#comment52304 replace with: setDisplayDate(QDate(year, m_displayedDate.month(), m_displayedDate.day())); src/declarativeimports/calendar/calendar.cpp https://git.reviewboard.kde.org/r/122488/#comment52305 setDisplayDate... src/declarativeimports/calendar/calendar.cpp https://git.reviewboard.kde.org/r/122488/#comment52306 setDisplayDate... I'd advice against the new C++ functions. You can use setDisplayDate (even in QML with the displayedDate property) to accomplish the exact same thing and it keeps the C++ API clean. If you really want to have the helper functions on the C++ side then you should call setDisplayDate(...) within those helper functions. But i like your change from a visual perspective :) I actually think John Layt had this on his wish lish for the calendar! Also, did you notice your bottom border in the month view is missing? It's like that in plasma 5.2 as well. - Mark Gaiser On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 8:52 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75650 --- src/declarativeimports/calendar/daysmodel.cpp https://git.reviewboard.kde.org/r/122488/#comment52307 You should override roleNames() instead src/declarativeimports/calendar/qml/DaysCalendar.qml https://git.reviewboard.kde.org/r/122488/#comment52308 I know this is nitpicking but... how is an arrow pointing to the left implemented as previous() meant to work for RTL languages? :) src/declarativeimports/calendar/qml/MonthView.qml https://git.reviewboard.kde.org/r/122488/#comment52309 I know this is not your code but still... we must absolutely not make any asumptions about how the strings should be rendered. In some languages it's just plain wrong to display month names capitalized. - Lukáš Tinkl On Úno. 8, 2015, 9:52 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Úno. 8, 2015, 9:52 odp.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75656 --- +1 I like it. Why is it even possible to select a day though? It doesn't do anything at the moment... Maybe it would be food that when hovering a day, the weekday was highlighted, it's useful to know what day is it. - Aleix Pol Gonzalez On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Feb. 8, 2015, 9:52 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
