Re: Review Request 122609: Drop size check for round ToolButton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/#review76191 --- +1 - David Edmundson On Feb. 17, 2015, 4:31 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/ --- (Updated Feb. 17, 2015, 4:31 p.m.) Review request for Plasma. Bugs: 339303 and 340588 http://bugs.kde.org/show_bug.cgi?id=339303 http://bugs.kde.org/show_bug.cgi?id=340588 Repository: plasma-framework Description --- It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway. Diffs - src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da Diff: https://git.reviewboard.kde.org/r/122609/diff/ Testing --- Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #1332
See http://build.kde.org/job/plasma-workspace_master_qt5/1332/changes
Changes:
[bhush94] Allow shells to know the current session
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson9128945242713673790.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
3b4bc68..8e3c188 Plasma/5.2 - origin/Plasma/5.2
4ebe0dc..77112d4 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 4ebe0dc Adjust powermanagement dataengine to API change in
PowerDevil
Removing build/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 77112d402e3c22311dd2d70f9d2b264d1465cf03
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 77112d402e3c22311dd2d70f9d2b264d1465cf03
git rev-list 236fcaebdd0bee73abba4532e65d547cd0dfb8ab # timeout=10
git tag -a -f -m Jenkins Build #1332
jenkins-plasma-workspace_master_qt5-1332 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson6928596108840193839.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kwallet - Branch master
ktextwidgets - Branch master
kio-extras - Branch master
kiconthemes - Branch master
kpty - Branch master
kactivities - Branch master
attica - Branch master
baloo - Branch master
knotifications - Branch master
kwidgetsaddons - Branch master
kjsembed - Branch master
kinit - Branch master
kded - Branch master
kidletime - Branch master
kservice - Branch master
kauth - Branch master
kconfig - Branch master
kemoticons - Branch master
kdelibs4support - Branch master
kconfigwidgets - Branch master
phonon - Branch master
sonnet - Branch master
milou - Branch master
frameworkintegration - Branch master
libksysguard - Branch master
threadweaver - Branch master
kross - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
kplotting - Branch master
kbookmarks - Branch master
kitemmodels - Branch master
karchive - Branch master
kwindowsystem - Branch master
kxmlgui - Branch master
extra-cmake-modules - Branch master
kitemviews - Branch master
kdbusaddons - Branch master
kwin - Branch master
kunitconversion - Branch master
breeze - Branch master
kdesupport-svn - Branch master
kdewebkit - Branch master
kguiaddons - Branch master
kwayland - Branch master
knotifyconfig - Branch master
kcrash - Branch master
libgit2 - Branch master
plasma-framework - Branch master
kio - Branch master
libkscreen - Branch master
kjobwidgets - Branch master
polkit-qt-1 - Branch master
kdnssd - Branch master
kcoreaddons - Branch master
kparts - Branch master
kxmlrpcclient - Branch master
cmake - Branch master
krunner - Branch master
poppler - Branch master
kcmutils - Branch master
kglobalaccel - Branch master
kdesignerplugin - Branch master
ktexteditor - Branch master
dogtail - Branch master
kfilemetadata - Branch master
knewstuff - Branch master
kdeclarative - Branch master
ki18n - Branch master
kdecoration - Branch master
kdoctools - Branch master
kjs - Branch master
khtml - Branch master
kdesu - Branch master
solid - Branch master
libdbusmenu-qt - Branch master
kcompletion - Branch master
kpackage - Branch master
libssh - Branch master
khelpcenter - Branch master
kcodecs - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler:
Re: Review Request 122603: Adjust to PowerDevil api change
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122603/ --- (Updated Feb. 17, 2015, 1:36 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- Adjusts powermanagement dataengine to DBus API change in powerdevil Diffs - dataengines/powermanagement/powermanagementengine.cpp 9828ace dataengines/powermanagement/powermanagementjob.cpp 633d832 Diff: https://git.reviewboard.kde.org/r/122603/diff/ Testing --- Works, requires no adjustment in users of the data engine Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Feb. 17, 2015, 1:35 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #1329
See http://build.kde.org/job/plasma-workspace_master_qt5/1329/changes
Changes:
[kde] Adjust powermanagement dataengine to API change in PowerDevil
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson922369178225751433.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
411a746..4ebe0dc master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 411a746 Merge branch 'Plasma/5.2'
Removing build/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 4ebe0dc4275f786af6ff97094d7990d4fc2fe83e
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 4ebe0dc4275f786af6ff97094d7990d4fc2fe83e
git rev-list 411a746d73aaae3e736e0dffc5e07ca5cb5245b0 # timeout=10
git tag -a -f -m Jenkins Build #1329
jenkins-plasma-workspace_master_qt5-1329 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5842177237333234630.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
frameworkintegration - Branch master
kwallet - Branch master
ktextwidgets - Branch master
kio-extras - Branch master
kdesu - Branch master
kactivities - Branch master
kitemmodels - Branch master
attica - Branch master
baloo - Branch master
polkit-qt-1 - Branch master
knotifications - Branch master
kwidgetsaddons - Branch master
kjsembed - Branch master
kdnssd - Branch master
kidletime - Branch master
kauth - Branch master
kconfig - Branch master
kservice - Branch master
kpty - Branch master
kdelibs4support - Branch master
poppler - Branch master
phonon - Branch master
sonnet - Branch master
ktexteditor - Branch master
khelpcenter - Branch master
kunitconversion - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
libdbusmenu-qt - Branch master
kxmlgui - Branch master
kpackage - Branch master
kparts - Branch master
kitemviews - Branch master
kwindowsystem - Branch master
extra-cmake-modules - Branch master
kconfigwidgets - Branch master
kdbusaddons - Branch master
kwin - Branch master
kdesignerplugin - Branch master
breeze - Branch master
kguiaddons - Branch master
kross - Branch master
kdesupport-svn - Branch master
kdewebkit - Branch master
ki18n - Branch master
kdecoration - Branch master
kwayland - Branch master
kjs - Branch master
kcmutils - Branch master
kcrash - Branch master
kbookmarks - Branch master
kcompletion - Branch master
knewstuff - Branch master
khtml - Branch master
kio - Branch master
libkscreen - Branch master
kemoticons - Branch master
kcoreaddons - Branch master
libgit2 - Branch master
kxmlrpcclient - Branch master
cmake - Branch master
kded - Branch master
kiconthemes - Branch master
krunner - Branch master
kfilemetadata - Branch master
kplotting - Branch master
kglobalaccel - Branch master
dogtail - Branch master
kinit - Branch master
plasma-framework - Branch master
kdeclarative - Branch master
solid - Branch master
kdoctools - Branch master
knotifyconfig - Branch master
libssh - Branch master
karchive - Branch master
libksysguard - Branch master
kjobwidgets - Branch master
threadweaver - Branch master
kcodecs - Branch master
milou - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C
Review Request 122609: Drop size check for round ToolButton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/ --- Review request for Plasma. Bugs: 339303 and 340588 http://bugs.kde.org/show_bug.cgi?id=339303 http://bugs.kde.org/show_bug.cgi?id=340588 Repository: plasma-framework Description --- It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway. Diffs - src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da Diff: https://git.reviewboard.kde.org/r/122609/diff/ Testing --- Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122609: Drop size check for round ToolButton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/#review76192 --- Maybe it should be documented somewhere then, no? That if there's no text you get a round button. - Aleix Pol Gonzalez On Feb. 17, 2015, 5:31 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/ --- (Updated Feb. 17, 2015, 5:31 p.m.) Review request for Plasma. Bugs: 339303 and 340588 http://bugs.kde.org/show_bug.cgi?id=339303 http://bugs.kde.org/show_bug.cgi?id=340588 Repository: plasma-framework Description --- It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway. Diffs - src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da Diff: https://git.reviewboard.kde.org/r/122609/diff/ Testing --- Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122609: Drop size check for round ToolButton
On Feb. 17, 2015, 4:56 nachm., Aleix Pol Gonzalez wrote: Maybe it should be documented somewhere then, no? That if there's no text you get a round button. ...a non-flat(!) button without text but yeah it's pretty magic unexpected - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/#review76192 --- On Feb. 17, 2015, 4:31 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/ --- (Updated Feb. 17, 2015, 4:31 nachm.) Review request for Plasma. Bugs: 339303 and 340588 http://bugs.kde.org/show_bug.cgi?id=339303 http://bugs.kde.org/show_bug.cgi?id=340588 Repository: plasma-framework Description --- It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway. Diffs - src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da Diff: https://git.reviewboard.kde.org/r/122609/diff/ Testing --- Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122609: Drop size check for round ToolButton
On Feb. 17, 2015, 5:56 p.m., Aleix Pol Gonzalez wrote: Maybe it should be documented somewhere then, no? That if there's no text you get a round button. Kai Uwe Broulik wrote: ...a non-flat(!) button without text but yeah it's pretty magic unexpected Yes, a bit. Well if you can document it, great. +1 nevertheless. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/#review76192 --- On Feb. 17, 2015, 5:31 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/ --- (Updated Feb. 17, 2015, 5:31 p.m.) Review request for Plasma. Bugs: 339303 and 340588 http://bugs.kde.org/show_bug.cgi?id=339303 http://bugs.kde.org/show_bug.cgi?id=340588 Repository: plasma-framework Description --- It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway. Diffs - src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da Diff: https://git.reviewboard.kde.org/r/122609/diff/ Testing --- Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #1331
See http://build.kde.org/job/plasma-workspace_master_qt5/1331/changes
Changes:
[kde] Add activities config to battery monitor settings
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4680771902857653676.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
99bd87a..236fcae master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 99bd87a SVN_SILENT made messages (.desktop file)
Removing build/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 236fcaebdd0bee73abba4532e65d547cd0dfb8ab
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 236fcaebdd0bee73abba4532e65d547cd0dfb8ab
git rev-list 99bd87a5ad6b2f410e6afc752c9791e0df064dd5 # timeout=10
git tag -a -f -m Jenkins Build #1331
jenkins-plasma-workspace_master_qt5-1331 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson1593719218071090715.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
polkit-qt-1 - Branch master
kpty - Branch master
kwallet - Branch master
ktextwidgets - Branch master
kio-extras - Branch master
ktexteditor - Branch master
kactivities - Branch master
libdbusmenu-qt - Branch master
baloo - Branch master
kxmlgui - Branch master
knotifications - Branch master
kparts - Branch master
kwidgetsaddons - Branch master
kjsembed - Branch master
kidletime - Branch master
kconfigwidgets - Branch master
kauth - Branch master
kconfig - Branch master
kdesignerplugin - Branch master
libgit2 - Branch master
kdelibs4support - Branch master
attica - Branch master
phonon - Branch master
sonnet - Branch master
ki18n - Branch master
kguiaddons - Branch master
threadweaver - Branch master
kjs - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
kinit - Branch master
kcompletion - Branch master
kbookmarks - Branch master
kunitconversion - Branch master
libssh - Branch master
kwindowsystem - Branch master
kemoticons - Branch master
extra-cmake-modules - Branch master
khtml - Branch master
kdbusaddons - Branch master
kdesupport-svn - Branch master
kdnssd - Branch master
breeze - Branch master
kservice - Branch master
libksysguard - Branch master
kdewebkit - Branch master
kcodecs - Branch master
kwayland - Branch master
krunner - Branch master
kcrash - Branch master
solid - Branch master
knewstuff - Branch master
knotifyconfig - Branch master
kio - Branch master
libkscreen - Branch master
poppler - Branch master
kcoreaddons - Branch master
kfilemetadata - Branch master
kxmlrpcclient - Branch master
kitemviews - Branch master
frameworkintegration - Branch master
kcmutils - Branch master
kplotting - Branch master
kglobalaccel - Branch master
kross - Branch master
kiconthemes - Branch master
kitemmodels - Branch master
plasma-framework - Branch master
kdeclarative - Branch master
milou - Branch master
kded - Branch master
kdoctools - Branch master
kpackage - Branch master
karchive - Branch master
kwin - Branch master
kdesu - Branch master
kdecoration - Branch master
kjobwidgets - Branch master
khelpcenter - Branch master
cmake - Branch master
dogtail - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
--
Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76180 --- Ship it! daemon/powerdevilbrightnesslogic.cpp https://git.reviewboard.kde.org/r/122602/#comment52535 Seems to be unused now (only the one that has no arguments). Could be safely removed. - Nikita Skovoroda On Фев. 17, 2015, 1:35 п.п., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Фев. 17, 2015, 1:35 п.п.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
On Фев. 17, 2015, 1:37 п.п., Nikita Skovoroda wrote: daemon/powerdevilbrightnesslogic.cpp, line 117 https://git.reviewboard.kde.org/r/122602/diff/1/?file=350053#file350053line117 Seems to be unused now (only the one that has no arguments). Could be safely removed. It is actually used from the inside of that class, but is unnecessary, the inner call to `percentage()` could be replaced with `percentage(m_value)`. - Nikita --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76180 --- On Фев. 17, 2015, 1:35 п.п., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Фев. 17, 2015, 1:35 п.п.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #1330
See http://build.kde.org/job/plasma-workspace_master_qt5/1330/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson7159141219239406052.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
5629da4..3b4bc68 Plasma/5.2 - origin/Plasma/5.2
642392e..99bd87a master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 642392e Forward key events to the StackView
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 99bd87a5ad6b2f410e6afc752c9791e0df064dd5
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 99bd87a5ad6b2f410e6afc752c9791e0df064dd5
git rev-list 4ebe0dc4275f786af6ff97094d7990d4fc2fe83e # timeout=10
git tag -a -f -m Jenkins Build #1330
jenkins-plasma-workspace_master_qt5-1330 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5415035942009667005.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
polkit-qt-1 - Branch master
kpty - Branch master
kwallet - Branch master
ktextwidgets - Branch master
kio-extras - Branch master
libssh - Branch master
ktexteditor - Branch master
kactivities - Branch master
kpackage - Branch master
libdbusmenu-qt - Branch master
baloo - Branch master
kxmlgui - Branch master
knotifications - Branch master
kparts - Branch master
kwidgetsaddons - Branch master
kjsembed - Branch master
kidletime - Branch master
kconfigwidgets - Branch master
kauth - Branch master
kconfig - Branch master
kdesignerplugin - Branch master
libgit2 - Branch master
kdelibs4support - Branch master
kross - Branch master
phonon - Branch master
sonnet - Branch master
ki18n - Branch master
threadweaver - Branch master
kjs - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
kinit - Branch master
attica - Branch master
kcompletion - Branch master
kbookmarks - Branch master
kunitconversion - Branch master
kguiaddons - Branch master
kwindowsystem - Branch master
kemoticons - Branch master
kxmlrpcclient - Branch master
kdnssd - Branch master
kdbusaddons - Branch master
kdesupport-svn - Branch master
breeze - Branch master
kservice - Branch master
libksysguard - Branch master
kdewebkit - Branch master
khtml - Branch master
kcodecs - Branch master
kwayland - Branch master
kcmutils - Branch master
kcrash - Branch master
solid - Branch master
knewstuff - Branch master
knotifyconfig - Branch master
kio - Branch master
libkscreen - Branch master
kcoreaddons - Branch master
kfilemetadata - Branch master
extra-cmake-modules - Branch master
kitemviews - Branch master
frameworkintegration - Branch master
krunner - Branch master
kplotting - Branch master
kglobalaccel - Branch master
kiconthemes - Branch master
kitemmodels - Branch master
plasma-framework - Branch master
kdeclarative - Branch master
milou - Branch master
kded - Branch master
kdoctools - Branch master
poppler - Branch master
karchive - Branch master
kwin - Branch master
kdesu - Branch master
kdecoration - Branch master
kjobwidgets - Branch master
khelpcenter - Branch master
cmake - Branch master
dogtail - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler:
Build failed in Jenkins: plasma-workspace_master_qt5 #1333
See http://build.kde.org/job/plasma-workspace_master_qt5/1333/changes
Changes:
[kde] Fix warnings and cleanup
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson1609090084972420744.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
77112d4..3d20070 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 77112d4 Allow shells to know the current session
Removing build/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 3d200702b7251e3581aac99e23fff7fe67b2a452
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 3d200702b7251e3581aac99e23fff7fe67b2a452
git rev-list 77112d402e3c22311dd2d70f9d2b264d1465cf03 # timeout=10
git tag -a -f -m Jenkins Build #1333
jenkins-plasma-workspace_master_qt5-1333 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson6450134012509070795.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
polkit-qt-1 - Branch master
kcompletion - Branch master
kwallet - Branch master
poppler - Branch master
ktextwidgets - Branch master
kio-extras - Branch master
kactivities - Branch master
kcmutils - Branch master
baloo - Branch master
kpty - Branch master
knotifications - Branch master
kwidgetsaddons - Branch master
kjsembed - Branch master
kunitconversion - Branch master
libssh - Branch master
kidletime - Branch master
khtml - Branch master
knewstuff - Branch master
kauth - Branch master
kconfig - Branch master
solid - Branch master
kguiaddons - Branch master
knotifyconfig - Branch master
kparts - Branch master
phonon - Branch master
sonnet - Branch master
threadweaver - Branch master
kconfigwidgets - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
kdesignerplugin - Branch master
frameworkintegration - Branch master
kbookmarks - Branch master
kpackage - Branch master
kross - Branch master
kitemviews - Branch master
kwindowsystem - Branch master
attica - Branch master
kdbusaddons - Branch master
kdesu - Branch master
extra-cmake-modules - Branch master
kitemmodels - Branch master
karchive - Branch master
kwin - Branch master
kinit - Branch master
kdnssd - Branch master
breeze - Branch master
libksysguard - Branch master
kdewebkit - Branch master
kemoticons - Branch master
libgit2 - Branch master
kwayland - Branch master
kdelibs4support - Branch master
kcrash - Branch master
kiconthemes - Branch master
plasma-framework - Branch master
kio - Branch master
libkscreen - Branch master
kjs - Branch master
ktexteditor - Branch master
kcoreaddons - Branch master
kfilemetadata - Branch master
kxmlrpcclient - Branch master
cmake - Branch master
kxmlgui - Branch master
krunner - Branch master
kplotting - Branch master
kglobalaccel - Branch master
dogtail - Branch master
libdbusmenu-qt - Branch master
kdeclarative - Branch master
milou - Branch master
kdoctools - Branch master
kcodecs - Branch master
kdesupport-svn - Branch master
ki18n - Branch master
kdecoration - Branch master
kjobwidgets - Branch master
kded - Branch master
khelpcenter - Branch master
kservice - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info -
Jenkins build is back to normal : plasma-workspace_master_qt5 #1336
See http://build.kde.org/job/plasma-workspace_master_qt5/1336/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #1334
See http://build.kde.org/job/plasma-workspace_master_qt5/1334/changes
Changes:
[kde] Trigger the current action button when pressing return
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson2679465548796592964.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
3d20070..a4a3ed5 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 3d20070 Fix warnings and cleanup
Removing build/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision a4a3ed5fc5e8a63f4a440cc6fc969651f02f2a27
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f a4a3ed5fc5e8a63f4a440cc6fc969651f02f2a27
git rev-list 3d200702b7251e3581aac99e23fff7fe67b2a452 # timeout=10
git tag -a -f -m Jenkins Build #1334
jenkins-plasma-workspace_master_qt5-1334 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson7525553252822016217.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kemoticons - Branch master
kwallet - Branch master
kconfigwidgets - Branch master
kservice - Branch master
kio-extras - Branch master
kiconthemes - Branch master
kactivities - Branch master
kross - Branch master
attica - Branch master
baloo - Branch master
kdesu - Branch master
knotifications - Branch master
kitemmodels - Branch master
karchive - Branch master
kjsembed - Branch master
kxmlgui - Branch master
kidletime - Branch master
kfilemetadata - Branch master
kauth - Branch master
kconfig - Branch master
kdelibs4support - Branch master
kunitconversion - Branch master
phonon - Branch master
sonnet - Branch master
kded - Branch master
threadweaver - Branch master
kguiaddons - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
kbookmarks - Branch master
kitemviews - Branch master
kwindowsystem - Branch master
polkit-qt-1 - Branch master
kdnssd - Branch master
milou - Branch master
kparts - Branch master
kdbusaddons - Branch master
kwin - Branch master
breeze - Branch master
libksysguard - Branch master
kdewebkit - Branch master
kdesignerplugin - Branch master
kpackage - Branch master
kwayland - Branch master
ktextwidgets - Branch master
knotifyconfig - Branch master
kcrash - Branch master
ki18n - Branch master
poppler - Branch master
kdecoration - Branch master
libdbusmenu-qt - Branch master
kjs - Branch master
frameworkintegration - Branch master
libkscreen - Branch master
solid - Branch master
kcompletion - Branch master
kcoreaddons - Branch master
libssh - Branch master
kxmlrpcclient - Branch master
cmake - Branch master
krunner - Branch master
extra-cmake-modules - Branch master
kplotting - Branch master
kglobalaccel - Branch master
kwidgetsaddons - Branch master
kpty - Branch master
dogtail - Branch master
kcmutils - Branch master
knewstuff - Branch master
kdeclarative - Branch master
ktexteditor - Branch master
kdoctools - Branch master
kio - Branch master
khtml - Branch master
kdesupport-svn - Branch master
kinit - Branch master
plasma-framework - Branch master
kjobwidgets - Branch master
libgit2 - Branch master
khelpcenter - Branch master
kcodecs - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C
Build failed in Jenkins: plasma-workspace_master_qt5 #1335
See http://build.kde.org/job/plasma-workspace_master_qt5/1335/changes
Changes:
[bhush94] use QString::fromUtf8
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4656122200180207795.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
a4a3ed5..4e2bcae master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a4a3ed5 Trigger the current action button when pressing return
Removing build/
Success build forhudson.tasks.Shell@102d30ab
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace #
timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress
git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 4e2bcaeec2b03dd5363128d634dc8ec7aab62ef3
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 4e2bcaeec2b03dd5363128d634dc8ec7aab62ef3
git rev-list a4a3ed5fc5e8a63f4a440cc6fc969651f02f2a27 # timeout=10
git tag -a -f -m Jenkins Build #1335
jenkins-plasma-workspace_master_qt5-1335 # timeout=10
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson6902918734643114079.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
ktexteditor - Branch master
kunitconversion - Branch master
kwallet - Branch master
kguiaddons - Branch master
kio-extras - Branch master
kactivities - Branch master
attica - Branch master
baloo - Branch master
knotifications - Branch master
libgit2 - Branch master
kwidgetsaddons - Branch master
kjsembed - Branch master
polkit-qt-1 - Branch master
kdnssd - Branch master
kidletime - Branch master
kparts - Branch master
kauth - Branch master
kconfig - Branch master
kplotting - Branch master
knotifyconfig - Branch master
kcmutils - Branch master
sonnet - Branch master
kdesignerplugin - Branch master
khelpcenter - Branch master
qt5 - Branch 5.4.1
kde-cli-tools - Branch master
ki18n - Branch master
kdecoration - Branch master
kbookmarks - Branch master
kjs - Branch master
kitemviews - Branch master
kwindowsystem - Branch master
solid - Branch master
khtml - Branch master
kcompletion - Branch master
kxmlrpcclient - Branch master
libssh - Branch master
kdbusaddons - Branch master
kwin - Branch master
breeze - Branch master
phonon - Branch master
kfilemetadata - Branch master
libksysguard - Branch master
kdewebkit - Branch master
kded - Branch master
kpty - Branch master
kwayland - Branch master
kdelibs4support - Branch master
kcrash - Branch master
libdbusmenu-qt - Branch master
kpackage - Branch master
kio - Branch master
libkscreen - Branch master
kinit - Branch master
plasma-framework - Branch master
kcoreaddons - Branch master
extra-cmake-modules - Branch master
cmake - Branch master
kemoticons - Branch master
krunner - Branch master
kconfigwidgets - Branch master
kservice - Branch master
kglobalaccel - Branch master
milou - Branch master
frameworkintegration - Branch master
kiconthemes - Branch master
dogtail - Branch master
kross - Branch master
knewstuff - Branch master
kdeclarative - Branch master
ktextwidgets - Branch master
kdesu - Branch master
kdoctools - Branch master
kitemmodels - Branch master
karchive - Branch master
kdesupport-svn - Branch master
poppler - Branch master
kxmlgui - Branch master
kjobwidgets - Branch master
threadweaver - Branch master
kcodecs - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C
Review Request 122603: Adjust to PowerDevil api change
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122603/ --- Review request for Plasma. Repository: plasma-workspace Description --- Adjusts powermanagement dataengine to DBus API change in powerdevil Diffs - dataengines/powermanagement/powermanagementengine.cpp 9828ace dataengines/powermanagement/powermanagementjob.cpp 633d832 Diff: https://git.reviewboard.kde.org/r/122603/diff/ Testing --- Works, requires no adjustment in users of the data engine Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Merging KCM Touchpad
El Divendres, 13 de febrer de 2015, a les 00:17:41, Aleix Pol va escriure: On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson da...@davidedmundson.co.uk wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think there's a reason to keep it in a separate repo now it's ready for usage. I'll filter branch to keep the history. ktouchpadenabler will then be dropped as this provides the same feature only more configurable and with future proofed with libinput support. +1 CC'ing Albert, who is the ktouchpadenabler maintainer, IIRC. The code of kcm-touchpad looks *very* scary compared to the one in ktouchpadenabler But if you guys are going to maintain it, well it's less work for me :) Cheers, Albert Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122596: Kill lock logout checkLayout() function
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122596/ --- (Updated Feb. 17, 2015, 9:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 337318 and 339435 https://bugs.kde.org/show_bug.cgi?id=337318 https://bugs.kde.org/show_bug.cgi?id=339435 Repository: plasma-workspace Description --- This replaces size and orientation handling by bindings and also uses units for the minimum size. Diffs - applets/lock_logout/contents/ui/lockout.qml d5d6a04 Diff: https://git.reviewboard.kde.org/r/122596/diff/ Testing --- I now get reasonably sized buttons and spacing in my panel Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #1338
See http://build.kde.org/job/plasma-workspace_master_qt5/1338/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Merging KCM Touchpad
On Tue, Feb 17, 2015 at 10:17 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 13 de febrer de 2015, a les 00:17:41, Aleix Pol va escriure: On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson da...@davidedmundson.co.uk wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think there's a reason to keep it in a separate repo now it's ready for usage. I'll filter branch to keep the history. ktouchpadenabler will then be dropped as this provides the same feature only more configurable and with future proofed with libinput support. +1 CC'ing Albert, who is the ktouchpadenabler maintainer, IIRC. The code of kcm-touchpad looks *very* scary compared to the one in ktouchpadenabler But if you guys are going to maintain it, well it's less work for me :) ktouchpadenabler wouldn't work in the next Fedora anyway due to libinput being preferred over synaptics. Once we start adding in that abstraction we would start to get complex in ktouchpadenabler too. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122609: Drop size check for round ToolButton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122609/ --- (Updated Feb. 17, 2015, 10:22 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 339303 and 340588 http://bugs.kde.org/show_bug.cgi?id=339303 http://bugs.kde.org/show_bug.cgi?id=340588 Repository: plasma-framework Description --- It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway. Diffs - src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da Diff: https://git.reviewboard.kde.org/r/122609/diff/ Testing --- Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122603: Adjust to PowerDevil api change
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122603/#review76179 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 17, 2015, 1:07 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122603/ --- (Updated Úno. 17, 2015, 1:07 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Adjusts powermanagement dataengine to DBus API change in powerdevil Diffs - dataengines/powermanagement/powermanagementengine.cpp 9828ace dataengines/powermanagement/powermanagementjob.cpp 633d832 Diff: https://git.reviewboard.kde.org/r/122603/diff/ Testing --- Works, requires no adjustment in users of the data engine Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76178 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 17, 2015, 1:06 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Úno. 17, 2015, 1:06 odp.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
