Re: Review Request 121856: KWindowSystem import for KDeclarative

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76265
---



src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h


please make the methods non-static



src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp


why is a method needed which wraps QWindow::fromWinId?


- Martin Gräßlin


On Jan. 5, 2015, 11:49 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 11:49 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122629: Simplify ToolBox and implement keyboard navigation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122629/
---

(Updated Feb. 18, 2015, 8:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
---

This turns the Column with a Repeater into a ListView by which we will get 
keyboard and highlight handling for free, also add Accessible to the items.


Diffs
-

  toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 07457c3 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 8f91fd1 

Diff: https://git.reviewboard.kde.org/r/122629/diff/


Testing
---

Using the arrow keys to navigate the menu, Return to trigger an action and 
Escape to close it; looks like before.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121856: KWindowSystem import for KDeclarative

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121856/#review76258
---


Ping

- Kai Uwe Broulik


On Jan. 5, 2015, 10:49 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
> ---
> 
> (Updated Jan. 5, 2015, 10:49 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a thin proxy around KWindowSystem exposing most of its methods to qml 
> via KWindowSystem item in an org.kde.kwindowsystem import.
> 
> It uses QWindow instead of WId parameters so you can just pass a qml Item, 
> such as a Plasma Dialog as parameter for ease of use (and so you cannot mess 
> with others windows without effort, also I don't know what "WId" would 
> translate to anyway). It omits all those methods that return WId/QWindow as I 
> don't know how expensive QWindow::fromWinId is or who takes ownership of it. 
> We need to decide which methods make sense in this import.
> 
> Methods that have signals and don't take parameters are turned into 
> full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the 
> rest stays Q_INVOKABLE.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION 
>   src/qmlcontrols/CMakeLists.txt 39c39a5 
>   src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121856/diff/
> 
> 
> Testing
> ---
> 
> The properties work and change accordingly (compositing active signal doesn't 
> seem to be emitted by KWindowSystem in the first place, at least 
> Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works 
> for Review 121807
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122629: Simplify ToolBox and implement keyboard navigation

[Kai Uwe Broulik]

> On Feb. 18, 2015, 4 nachm., David Edmundson wrote:
> > toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml, line 42
> > 
> >
> > I don't understand this comment?
> > 
> > if you don't want it to close event.accepted = false to not eat the 
> > event.

I suppose it's the Escape key that is handled by the dashboard as well, it 
doesn't matter whether I set accepted to true or false, whenever I press Escape 
the dashboard closes.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122629/#review76243
---


On Feb. 18, 2015, 3:17 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122629/
> ---
> 
> (Updated Feb. 18, 2015, 3:17 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This turns the Column with a Repeater into a ListView by which we will get 
> keyboard and highlight handling for free, also add Accessible to the items.
> 
> 
> Diffs
> -
> 
>   toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 07457c3 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 8f91fd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122629/diff/
> 
> 
> Testing
> ---
> 
> Using the arrow keys to navigate the menu, Return to trigger an action and 
> Escape to close it; looks like before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122629: Simplify ToolBox and implement keyboard navigation

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122629/#review76243
---



toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml


I don't understand this comment?

if you don't want it to close event.accepted = false to not eat the event.



toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml


this doesn't make sense.

Maybe you meant Key_Enter on the second one?


- David Edmundson


On Feb. 18, 2015, 3:17 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122629/
> ---
> 
> (Updated Feb. 18, 2015, 3:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This turns the Column with a Repeater into a ListView by which we will get 
> keyboard and highlight handling for free, also add Accessible to the items.
> 
> 
> Diffs
> -
> 
>   toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 07457c3 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 8f91fd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122629/diff/
> 
> 
> Testing
> ---
> 
> Using the arrow keys to navigate the menu, Return to trigger an action and 
> Escape to close it; looks like before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122629: Simplify ToolBox and implement keyboard navigation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122629/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This turns the Column with a Repeater into a ListView by which we will get 
keyboard and highlight handling for free, also add Accessible to the items.


Diffs
-

  toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 07457c3 
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 8f91fd1 

Diff: https://git.reviewboard.kde.org/r/122629/diff/


Testing
---

Using the arrow keys to navigate the menu, Return to trigger an action and 
Escape to close it; looks like before.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/
---

(Updated Feb. 18, 2015, 2:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

If there are no metadata, showing "by Unknown" is a bit strange and serves not 
much purpose. So let it show only the filename when no metadata available.


Diffs
-

  wallpapers/image/backgroundlistmodel.cpp 346bc8f 
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 

Diff: https://git.reviewboard.kde.org/r/122622/diff/


Testing
---

Images both with and without metadata works show tooltip as intended.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Martin Klapetek]

> On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote:
> > Ship It!
> 
> Martin Klapetek wrote:
> Can i18n strings be removed in stable?
> 
> Lukáš Tinkl wrote:
> Sure, removing is fine, it's like B(I)C rules ;)

Ah nice, I thought so but just wanted to make double sure, thanks :)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/#review76221
---


On Feb. 18, 2015, 12:25 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122622/
> ---
> 
> (Updated Feb. 18, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> If there are no metadata, showing "by Unknown" is a bit strange and serves 
> not much purpose. So let it show only the filename when no metadata available.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/backgroundlistmodel.cpp 346bc8f 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 
> 
> Diff: https://git.reviewboard.kde.org/r/122622/diff/
> 
> 
> Testing
> ---
> 
> Images both with and without metadata works show tooltip as intended.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122617: Require Qt 5.4

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122617/#review76237
---

Ship it!


Ship It!

- David Edmundson


On Feb. 18, 2015, 9:06 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122617/
> ---
> 
> (Updated Feb. 18, 2015, 9:06 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> Require Qt 5.4
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6dbfcc961fe573c5621670a8cdc08a09ac7a01d9 
>   clients/aurorae/src/aurorae.h f6ef39ba2d4b510d3d452dba5b37e34f8a18217e 
>   clients/aurorae/src/aurorae.cpp e24687d9cd7ca690d887aba0cd7569db54cbf6cb 
>   glxbackend.cpp c97fbee4743f3af239a8d640827113fcd8d04ed5 
>   libkwineffects/kwingltexture.cpp ab38883d88045a239daea0d8c7dd1a1ec76ec476 
>   workspace.cpp dcf4479f588355635be61bf6dc6957945dd7de3f 
> 
> Diff: https://git.reviewboard.kde.org/r/122617/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/
---

(Updated Feb. 18, 2015, 3:37 p.m.)


Review request for Plasma.


Changes
---

* added support for country
* removed the fields which are not set (city, ip)


Repository: plasma-workspace


Description
---

The service used so far is broken (doesn't resolve latitude and
longitude). Which means we need to switch the service to unbreak.

This change implements support for the Mozilla Location Service [1].
Advantages are:
* free
* open
* supports wifi based locationing
* provided by our FLOSS friends

[1] https://location.services.mozilla.com/


Diffs (updated)
-

  dataengines/geolocation/location_ip.h 
0a7780c1344c0f48416e524249be6fdada6b9bfd 
  dataengines/geolocation/location_ip.cpp 
1be2acd9478fceafa83896c552e7a3177368b194 

Diff: https://git.reviewboard.kde.org/r/122628/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Lukáš Tinkl]

> On Úno. 18, 2015, 12:33 odp., Eike Hein wrote:
> > Ship It!
> 
> Martin Klapetek wrote:
> Can i18n strings be removed in stable?

Sure, removing is fine, it's like B(I)C rules ;)


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/#review76221
---


On Úno. 18, 2015, 12:25 odp., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122622/
> ---
> 
> (Updated Úno. 18, 2015, 12:25 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> If there are no metadata, showing "by Unknown" is a bit strange and serves 
> not much purpose. So let it show only the filename when no metadata available.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/backgroundlistmodel.cpp 346bc8f 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 
> 
> Diff: https://git.reviewboard.kde.org/r/122622/diff/
> 
> 
> Testing
> ---
> 
> Images both with and without metadata works show tooltip as intended.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76235
---


definitely +1 from me

- Lukáš Tinkl


On Úno. 18, 2015, 1:52 odp., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> ---
> 
> (Updated Úno. 18, 2015, 1:52 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -
> 
>   dataengines/geolocation/location_ip.cpp 
> 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122624: Make non-interactive tooltips outputOnly

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122624/
---

(Updated Feb. 18, 2015, 1:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

Makes them much less annoying by having them close more reliably when leaving 
the tooltiparea and more importantly fixes the tooltip interrupting the applet 
resize operation


Diffs
-

  src/declarativeimports/core/tooltipdialog.cpp 3ae79ab 

Diff: https://git.reviewboard.kde.org/r/122624/diff/


Testing
---

Resizing applets now works interruption-free and tooltips seem to be in the way 
less often


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122623: Ignore single actions on popups

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122623/
---

(Updated Feb. 18, 2015, 1:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 344309
http://bugs.kde.org/show_bug.cgi?id=344309


Repository: plasma-framework


Description
---

Prevents sticky notes from appearing when middle clicking a plasmoid popup


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp 89e02d4 

Diff: https://git.reviewboard.kde.org/r/122623/diff/


Testing
---

Middle clicking the panel and desktop containment still works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Martin Gräßlin]

> On Feb. 18, 2015, 2:20 p.m., Vishesh Handa wrote:
> > dataengines/geolocation/location_ip.cpp, line 45
> > 
> >
> > Any idea why we have this magic number?

I can only guess: the accuracy returned by mozilla's service for just IP 
address is 5, so I guess it's what was considered a useful accuracy for the 
old service.


> On Feb. 18, 2015, 2:20 p.m., Vishesh Handa wrote:
> > dataengines/geolocation/location_ip.cpp, line 55
> > 
> >
> > It could be possible that 'lat' and 'lng' do not exist in the response. 
> > Perhaps we should be checking for it.

I consider this as unlikely given that it already checks whehter the key 
"location" is available. Assuming well formed data here and if the key is 
missing we get a default value anyway.


> On Feb. 18, 2015, 2:20 p.m., Vishesh Handa wrote:
> > dataengines/geolocation/location_ip.cpp, line 58
> > 
> >
> > This is slightly strange.
> > 
> > 
> > Normally it's given a double value, but otherwise we give it a string. 
> > Why not just not add it?

I based that on the old implementation. If it wasn't present it added it as an 
empty string. I wanted to keep it compatible (as it explicitly mentions the 
ordering mattered in a comment).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76231
---


On Feb. 18, 2015, 1:52 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> ---
> 
> (Updated Feb. 18, 2015, 1:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -
> 
>   dataengines/geolocation/location_ip.cpp 
> 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76231
---



dataengines/geolocation/location_ip.cpp


Any idea why we have this magic number?



dataengines/geolocation/location_ip.cpp


It could be possible that 'lat' and 'lng' do not exist in the response. 
Perhaps we should be checking for it.



dataengines/geolocation/location_ip.cpp


This is slightly strange.

Normally it's given a double value, but otherwise we give it a string. Why 
not just not add it?


- Vishesh Handa


On Feb. 18, 2015, 12:52 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> ---
> 
> (Updated Feb. 18, 2015, 12:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -
> 
>   dataengines/geolocation/location_ip.cpp 
> 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76229
---


+1 for the approach

- Martin Klapetek


On Feb. 18, 2015, 1:52 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> ---
> 
> (Updated Feb. 18, 2015, 1:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -
> 
>   dataengines/geolocation/location_ip.cpp 
> 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76228
---



dataengines/geolocation/location_ip.cpp


there's an additional API call to resolve these. If I get enough +1 for the 
general approach, I'll add support for it.



dataengines/geolocation/location_ip.cpp


I'll request an API key for KDE if I get enough +1 for the approach.


- Martin Gräßlin


On Feb. 18, 2015, 1:52 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> ---
> 
> (Updated Feb. 18, 2015, 1:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -
> 
>   dataengines/geolocation/location_ip.cpp 
> 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

The service used so far is broken (doesn't resolve latitude and
longitude). Which means we need to switch the service to unbreak.

This change implements support for the Mozilla Location Service [1].
Advantages are:
* free
* open
* supports wifi based locationing
* provided by our FLOSS friends

[1] https://location.services.mozilla.com/


Diffs
-

  dataengines/geolocation/location_ip.cpp 
1be2acd9478fceafa83896c552e7a3177368b194 

Diff: https://git.reviewboard.kde.org/r/122628/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122627: Fix line breaks in Digital Clock tooltip

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122627/
---

(Updated Feb. 18, 2015, 1:51 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Apparently the tooltip does not interpret , use \n instead.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 40317d0 

Diff: https://git.reviewboard.kde.org/r/122627/diff/


Testing
---

Enable multiple timezones in config and hover mouse over the applet - timezones 
in the tooltip are on new lines.


Thanks,

Daniel Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122627: Fix line breaks in Digital Clock tooltip

[Daniel Vrátil]

> On Feb. 18, 2015, 1:42 p.m., Martin Klapetek wrote:
> > Are you sure you're running the latest 5.2 branch? This was fixed globally 
> > in the tooltip I think (by ltinkl)

Slightly outdated master. Works after updating. Lukas was faster than me then 
and has a better fix ;-)


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122627/#review76226
---


On Feb. 18, 2015, 1:41 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122627/
> ---
> 
> (Updated Feb. 18, 2015, 1:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Apparently the tooltip does not interpret , use \n instead.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 40317d0 
> 
> Diff: https://git.reviewboard.kde.org/r/122627/diff/
> 
> 
> Testing
> ---
> 
> Enable multiple timezones in config and hover mouse over the applet - 
> timezones in the tooltip are on new lines.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122627: Fix line breaks in Digital Clock tooltip

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122627/#review76226
---


Are you sure you're running the latest 5.2 branch? This was fixed globally in 
the tooltip I think (by ltinkl)

- Martin Klapetek


On Feb. 18, 2015, 1:41 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122627/
> ---
> 
> (Updated Feb. 18, 2015, 1:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Apparently the tooltip does not interpret , use \n instead.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 40317d0 
> 
> Diff: https://git.reviewboard.kde.org/r/122627/diff/
> 
> 
> Testing
> ---
> 
> Enable multiple timezones in config and hover mouse over the applet - 
> timezones in the tooltip are on new lines.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122627: Fix line breaks in Digital Clock tooltip

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122627/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Apparently the tooltip does not interpret , use \n instead.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 40317d0 

Diff: https://git.reviewboard.kde.org/r/122627/diff/


Testing
---

Enable multiple timezones in config and hover mouse over the applet - timezones 
in the tooltip are on new lines.


Thanks,

Daniel Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122623: Ignore single actions on popups

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122623/#review76225
---

Ship it!



src/scriptengines/qml/plasmoid/appletinterface.cpp


just check if ci is valid


- Marco Martin


On Feb. 18, 2015, 11:36 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122623/
> ---
> 
> (Updated Feb. 18, 2015, 11:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344309
> http://bugs.kde.org/show_bug.cgi?id=344309
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Prevents sticky notes from appearing when middle clicking a plasmoid popup
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 89e02d4 
> 
> Diff: https://git.reviewboard.kde.org/r/122623/diff/
> 
> 
> Testing
> ---
> 
> Middle clicking the panel and desktop containment still works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122624: Make non-interactive tooltips outputOnly

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122624/#review76224
---

Ship it!


Ship It!

- Marco Martin


On Feb. 18, 2015, 12:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122624/
> ---
> 
> (Updated Feb. 18, 2015, 12:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Makes them much less annoying by having them close more reliably when leaving 
> the tooltiparea and more importantly fixes the tooltip interrupting the 
> applet resize operation
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltipdialog.cpp 3ae79ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122624/diff/
> 
> 
> Testing
> ---
> 
> Resizing applets now works interruption-free and tooltips seem to be in the 
> way less often
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122624: Make non-interactive tooltips outputOnly

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122624/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Makes them much less annoying by having them close more reliably when leaving 
the tooltiparea and more importantly fixes the tooltip interrupting the applet 
resize operation


Diffs
-

  src/declarativeimports/core/tooltipdialog.cpp 3ae79ab 

Diff: https://git.reviewboard.kde.org/r/122624/diff/


Testing
---

Resizing applets now works interruption-free and tooltips seem to be in the way 
less often


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Martin Klapetek]

> On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote:
> > Ship It!

Can i18n strings be removed in stable?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/#review76221
---


On Feb. 18, 2015, 12:25 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122622/
> ---
> 
> (Updated Feb. 18, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> If there are no metadata, showing "by Unknown" is a bit strange and serves 
> not much purpose. So let it show only the filename when no metadata available.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/backgroundlistmodel.cpp 346bc8f 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 
> 
> Diff: https://git.reviewboard.kde.org/r/122622/diff/
> 
> 
> Testing
> ---
> 
> Images both with and without metadata works show tooltip as intended.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122623: Ignore single actions on popups

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122623/
---

Review request for Plasma.


Bugs: 344309
http://bugs.kde.org/show_bug.cgi?id=344309


Repository: plasma-framework


Description
---

Prevents sticky notes from appearing when middle clicking a plasmoid popup


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp 89e02d4 

Diff: https://git.reviewboard.kde.org/r/122623/diff/


Testing
---

Middle clicking the panel and desktop containment still works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/#review76221
---

Ship it!


Ship It!

- Eike Hein


On Feb. 18, 2015, 11:25 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122622/
> ---
> 
> (Updated Feb. 18, 2015, 11:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> If there are no metadata, showing "by Unknown" is a bit strange and serves 
> not much purpose. So let it show only the filename when no metadata available.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/backgroundlistmodel.cpp 346bc8f 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 
> 
> Diff: https://git.reviewboard.kde.org/r/122622/diff/
> 
> 
> Testing
> ---
> 
> Images both with and without metadata works show tooltip as intended.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

If there are no metadata, showing "by Unknown" is a bit strange and serves not 
much purpose. So let it show only the filename when no metadata available.


Diffs
-

  wallpapers/image/backgroundlistmodel.cpp 346bc8f 
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 

Diff: https://git.reviewboard.kde.org/r/122622/diff/


Testing
---

Images both with and without metadata works show tooltip as intended.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 334411] Screen Energy Saving timeout on dual-monitor system starting one after another with timeout delay

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=334411

Martin Gräßlin  changed:

   What|Removed |Added

Product|systemsettings  |Powerdevil
  Component|kcm_screensaver |general
   Assignee|kscreensaver-bugs-null@kde. |plasma-devel@kde.org
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122619: [KPluginMetaData] Add support for Hidden key

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122619/
---

Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure, and 
Marco Martin.


Repository: kcoreaddons


Description
---

Add support for Hidden key

This key does not make a lot of sense for binary plugins (those loaded
from .so files which retrieve their metadata from the json-embedded
data), but is useful for plugins loaded from .desktop files.
This allows us to override the visibility of installed plugins by the
user.

I'm only considering the Hidden key here. I am not sure how the
NoDisplay key (which seems to be used here and there), so maybe we
should also consider NoDisplay. This is the most basic patch we can
achieve the desired results with, however.


Diffs
-

  autotests/data/hiddenplugin.desktop PRE-CREATION 
  autotests/kpluginmetadatatest.cpp 8a14f57dd0a8650f41185290da966f036cb66fb6 
  src/lib/plugin/desktopfileparser.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 
  src/lib/plugin/kpluginmetadata.h 7ca6747c766d92be828fa3350d088a2f8b1b12f4 
  src/lib/plugin/kpluginmetadata.cpp cf90ebc204186f26a3199753fb8c97922a278bd1 

Diff: https://git.reviewboard.kde.org/r/122619/diff/


Testing
---

* Added autotest to make sure both cases work
* Tried to hide a KPackage by adding a Hidden=true to the metadata.desktop file

Both work as expected with this patch.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122617: Require Qt 5.4

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122617/
---

Review request for kwin and Plasma.


Repository: kwin


Description
---

Require Qt 5.4


Diffs
-

  CMakeLists.txt 6dbfcc961fe573c5621670a8cdc08a09ac7a01d9 
  clients/aurorae/src/aurorae.h f6ef39ba2d4b510d3d452dba5b37e34f8a18217e 
  clients/aurorae/src/aurorae.cpp e24687d9cd7ca690d887aba0cd7569db54cbf6cb 
  glxbackend.cpp c97fbee4743f3af239a8d640827113fcd8d04ed5 
  libkwineffects/kwingltexture.cpp ab38883d88045a239daea0d8c7dd1a1ec76ec476 
  workspace.cpp dcf4479f588355635be61bf6dc6957945dd7de3f 

Diff: https://git.reviewboard.kde.org/r/122617/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : plasma-workspace_master_qt5 #1339

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122589/
---

(Updated Feb. 18, 2015, 8:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

If there was a vlc engine it got skipped due to a bug in VLC. This
bug seems to be fixed as of VLC 2.1.5 which contains the following
item in the changelog:
"dbus: Upgrade to an mpris2 compliant interface"

Given that the workaround breaks with the fixed VLC (no media control
at all), it's better to drop it and brake VLC installations which
haven't updated for more than half a year.


Diffs
-

  dataengines/mpris2/mpris2engine.cpp 42ca565d06b240712fbc75cfdaf7b1cc03404796 

Diff: https://git.reviewboard.kde.org/r/122589/diff/


Testing
---

media controller created if VLC is running when restarting plasmashell.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122588/
---

(Updated Feb. 18, 2015, 8:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Kai Uwe Broulik.


Repository: plasma-workspace


Description
---

Instead of having the media control shortcuts being grouped under
"plasmashell" a dedicated component "Media Controller" is added and all
shortcuts are assigned to it.

This solves the problem if multiple processes include the dataengine, the
shortcuts would be registered in each application.


Diffs
-

  dataengines/mpris2/CMakeLists.txt 3ca83589470b8851e7d51b1f3d2bb3ca3ee436c3 
  dataengines/mpris2/multiplexer.cpp ab7927d902dfa55b1afaa978e01e5a00f9fca127 

Diff: https://git.reviewboard.kde.org/r/122588/diff/


Testing
---


File Attachments


component in global shortcuts configuration
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/51fe906f-58ee-485d-a861-24e886459498__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel