Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/ --- Review request for Plasma. Repository: plasma-framework Description --- (still in progress but here for feedback) when QT_DEVICE_PIXELRATIO is something different from 1, the pixmaps generated by Svg will be scaled up to give a proper texture. This is complementary but not replacing our current approach: the pixelratio that can be accessed by units is now in relation to the qt pixel ratio, spacings are also adjusted accordingly (therefore, spaces and sizes won't need an integer value like pixelratio) svg introduces also a scaleFactor property (that is pretty much like its old pixelRatio) basically, scalefactor, will scale both the textures *and* all the reported sizes, (old method) pixelratio just scales textures without altering measures (like qt pixelratio likes) they are now both used and combined, so a) we can have this working before supporting officially qt pixelratio when will be good enough but b) keeping the old mwthod working for the time being c) by using both at the sae time we can at least scale sizes of values != from integers, for screens that are too dense for 1 and not enough for 2 Diffs - src/declarativeimports/core/framesvgitem.cpp dae8a4f src/declarativeimports/core/svgitem.cpp 570c1c3 src/declarativeimports/core/units.h 6c038ba src/declarativeimports/core/units.cpp a740145 src/plasma/private/svg_p.h a31d0ac src/plasma/svg.h 0bcbd7a src/plasma/svg.cpp 0a0db5e Diff: https://git.reviewboard.kde.org/r/122673/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76428 --- layers.cpp https://git.reviewboard.kde.org/r/122679/#comment52647 This is the volatile part - mostly a matter of what do we want this to be Possible layers (for showing desktop) - Dock Plasma panels can still cover the desktop, less dash-a-like. Drawback: all KeepAbove windows will be above - Above KeepAbove windows _can_ be brought above, but are not by default. All panels are below. We might alter the panel behavior (depending on transiency for the desktop and/or keep above state) to keep them in sight (if desired) - Fullscreen The Desktop will be the thing on top. Only its transients and override redirect windows (popups, tooltips, etc.) will be visible above. - Thomas Lübking On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 nachm.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] New: Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 Bug ID: 344456 Summary: Plasma 5 desktop does not suspend with only upower, no systemd Product: Powerdevil Version: 5.2.0 Platform: Slackware Packages OS: Linux Status: UNCONFIRMED Severity: major Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: al...@slackware.com Symptom: The system does not offer suspend or hibernate options, whereas the old KDE 4.x versions that were installed prior to Plasma 5 have always offered shutdown and hibernate options. Additionally, the laptop can not be left running on battery because it will never suspend and will drain the battery completely. Reproducible: Always Steps to Reproduce: 1. Install Slackware-current (Slackware's development tree) 2. Install Plasma 5 packages from http://taper.alienbase.nl/mirrors/alien-kde/current/testing/ 3. Run the Plasma 5 desktop Actual Results: In the Leave menu: Shutdown and Hibernate are missing. If a laptop running this software is left alone and on battery power, it will not suspend (thereby preserving battery charge) but instead it will keep running until the battery is drained. Expected Results: In the Leave menu: Shutdown and Hibernate are present. If the Slackware laptop running Plasma 5 is left unattended while on battery power, it will suspend before the battery is fully drained. Affected system: Slackware-current (development tree of Feb 2015) combined with Framework 5.7.0, Plasma 5.2.0 and Applications 14.12.2. Points of interest: Slackware uses upower 0.9.17 and does not have systemd or a shim. It uses ConsoleKit (1, not 2) for session and seat management, and polkit-0.105 for handling the privileges. Additional packages for the KDE 4 and Plasma 5 environments are, polkit-qt-1, polkit-qt5-1, polkit-kde-agent-1, polkit-kde-framework, polkit-kde-kcmodules-1, polkit-kde-kcmodules-framework. Note: this older version of UPower which Slackware uses, still offers the shutdown and hibernate functionality which was ultimately removed after 0.9.23. Diagnostics: Here is output of the relevant programs, feel free to ask more detail: $ upower -d ... Daemon: daemon-version: 0.9.17 can-suspend: yes can-hibernateno on-battery: no on-low-battery: no lid-is-closed: no lid-is-present: yes is-docked: no $ qdbus org.kde.kded5 /org/freedesktop/PowerManagement CanSuspend false $ qdbus org.freedesktop.PowerManagement /org/freedesktop/PowerManagement CanSuspend false $ qdbus --system org.freedesktop.login1 /org/freedesktop/login1 org.freedesktop.login1.Manager.CanSuspend Service 'org.freedesktop.login1' does not exist. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122676: Use our internal blur enabled variable for the texture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122676/ --- Review request for Plasma and Martin Gräßlin. Bugs: 344179 http://bugs.kde.org/show_bug.cgi?id=344179 Repository: plasma-framework Description --- Since we already watch blurEnabled ourselves, we should use that variable to determin which SVGs to load. KWindowEffects::isEffectAvailable might not have caught up yet when we decide do nuke the cache resulting in the translucent graphics staying when enabling/disabling Blur or swtiching to XRender. Diffs - src/plasma/private/theme_p.cpp f3c1e89 Diff: https://git.reviewboard.kde.org/r/122676/diff/ Testing --- Switching from OpenGL to XRender now properly switches to the opaque textures. I'm not sure whether that's a bug in KWindowEffects, but then, less roundtrips are always good :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
No Monday Hangout
Hi all, Since most of us have just spent an intensive week together, there is little to no use to have a hangout tomorrow. Instead, everybody can take a breath, because we're not doing our noon hangout tomorrow (Monday). We'll reconvene as usual the following week. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- Can you check the SuspendAllowed and CanSuspend properties of org.freedesktop.UPower? Both of them have to be true in order for it to announce suspend support. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #2 from Eric Hameleers al...@slackware.com --- Hi Kai First: my apologies for stating shutdown and hibernate when I meant to say suspend and hibernate of course. Here are the results on my laptop: $ qdbus --system org.freedesktop.UPower /org/freedesktop/UPower org.freedesktop.UPower.CanSuspend true $ qdbus --system org.freedesktop.UPower /org/freedesktop/UPower org.freedesktop.UPower.SuspendAllowed true And this actually suspended the laptop: $ dbus-send --system --print-reply --dest='org.freedesktop.UPower' /org/freedesktop/UPower org.freedesktop.UPower.Suspend method return sender=:1.14 - dest=:1.52 reply_serial=2 Still, no suspend option in the Leave menu or in the System Settings Power Management. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
Dne 21.2.2015 v 17:56 Sebastian Kügler napsal(a): * Application Color Scheme KCM has [ ] Apply colors to non-KDE4 applications This is what krdb obeys and it basically applies color schemes and/or themes to gtk apps. Or was just the wording the problem? -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456
--- Comment #3 from Lukáš Tinkl lu...@kde.org ---
Are you really sure there's no login1 service on DBUS? It may not be visible
but it's activated on first usage.
The code responsible for querying the suspend/hibernate capabilities first
tries with login1 and only if that's not available, falls back to upower. It
not only checks whether the method is available (CanSuspend) but also whether
it's allowed by polkit (SuspendAllowed), see below for the snippet:
if (m_login1Interface) {
QDBusPendingReplyQString canSuspend =
m_login1Interface.data()-asyncCall(CanSuspend);
canSuspend.waitForFinished();
if (canSuspend.isValid() (canSuspend.value() == yes ||
canSuspend.value() == challenge))
supported |= ToRam;
QDBusPendingReplyQString canHibernate =
m_login1Interface.data()-asyncCall(CanHibernate);
canHibernate.waitForFinished();
if (canHibernate.isValid() (canHibernate.value() == yes ||
canHibernate.value() == challenge))
supported |= ToDisk;
QDBusPendingReplyQString canHybridSleep =
m_login1Interface.data()-asyncCall(CanHybridSleep);
canHybridSleep.waitForFinished();
if (canHybridSleep.isValid() (canHybridSleep.value() == yes ||
canHybridSleep.value() == challenge))
supported |= HybridSuspend;
} else {
if (m_upowerInterface-canSuspend()
m_upowerInterface-SuspendAllowed()) {
qCDebug(POWERDEVIL) Can suspend;
supported |= ToRam;
}
if (m_upowerInterface-canHibernate()
m_upowerInterface-HibernateAllowed()) {
qCDebug(POWERDEVIL) Can hibernate;
supported |= ToDisk;
}
}
--
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: * Whatsthis (?) button in the window decoration is almost never used (can this button be either hidden, or shown conditionally) The button is only shown if the window provides context help. So it is already quite conditionally. Where is that a problem? signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
