Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray
On March 2, 2015, 10:30 p.m., Kai Uwe Broulik wrote: That sounds like a bug in the qml engine to me: The QML engine provides automatic type conversion between QVariantList and JavaScript arrays[…] and I haven't seen any issues with the conversion. Did you try QStringList? I didn't try. Is QStringList any better? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/#review76927 --- On March 2, 2015, 7:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- (Updated March 2, 2015, 7:14 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- QVariantList are treated as objects with integer indexes for some reasons and leads to weird scenarios. Diffs - src/qmlcontrols/draganddrop/DeclarativeMimeData.h 4a0723b src/qmlcontrols/draganddrop/DeclarativeMimeData.cpp 0db74f9 Diff: https://git.reviewboard.kde.org/r/122741/diff/ Testing --- QuickShare plasmoid can use now DeclarativeMimeData. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
On March 2, 2015, 6:26 p.m., Martin Klapetek wrote: File Attachment: screenshot.png - screenshot.png https://git.reviewboard.kde.org/r/122742/#fcomment368 I'd suggest FormLayout/GridLayout so these are aligned I'd suggest the same. Perhaps we can even move the message about the setting taking effect next to the combo? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76917 --- On March 2, 2015, 6:16 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated March 2, 2015, 6:16 p.m.) Review request for Plasma. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- File Attachments screenshot.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122668: port of comic applet to plasma5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122668/#review76934 --- Ship it! A bunch of niggles, nothing really big, but would be nice if we had these bits cleaned up before shipping the comic applet. CMakeLists.txt https://git.reviewboard.kde.org/r/122668/#comment52910 Can we remove KDELibs4Support? It doesn't seem to be used in the linker. applets/comic/checknewstrips.cpp https://git.reviewboard.kde.org/r/122668/#comment52911 Remove those commented lines? applets/comic/comic.h https://git.reviewboard.kde.org/r/122668/#comment52912 *availableComicsModel Or maybe just run the whole thing through astyle in a separate commit. applets/comic/comic.h https://git.reviewboard.kde.org/r/122668/#comment52913 remove commented lines applets/comic/comic.h https://git.reviewboard.kde.org/r/122668/#comment52917 There's an l too much at the end of the property name here, may be fixed as well while we're at it. applets/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52914 compile time connect? applets/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52915 compile-time connect? applets/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52916 This looks a bit brittle. Perhaps we can propagate the busy / loading state throug a property and have the BusyWidget pick it up from there? applets/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52918 const? applets/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52919 const applets/comic/comicupdater.cpp https://git.reviewboard.kde.org/r/122668/#comment52920 The intervall typo again. If we fix this, we must not forget the config name here. applets/comic/comicupdater.cpp https://git.reviewboard.kde.org/r/122668/#comment52921 compile-time connection? applets/comic/package/contents/config/config.qml https://git.reviewboard.kde.org/r/122668/#comment52923 inconsistent with other QtQuick imports (e.g. 2.1 in the next file) applets/comic/package/contents/ui/ComicCentralView.qml https://git.reviewboard.kde.org/r/122668/#comment52924 units.gridUnit applets/comic/package/contents/ui/ComicCentralView.qml https://git.reviewboard.kde.org/r/122668/#comment52925 clean... applets/comic/package/contents/ui/configAppearance.qml https://git.reviewboard.kde.org/r/122668/#comment52926 over - mouse over? applets/comic/package/contents/ui/main.qml https://git.reviewboard.kde.org/r/122668/#comment52927 use gridUnits? applets/comic/stripselector.cpp https://git.reviewboard.kde.org/r/122668/#comment52922 compile-time connections dataengines/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52928 // comment out the debug statements before pushing please dataengines/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52929 I'm not sure if we should risk quitting the application here. Seems a bit rough to quit the Plasma shell when something goes wrong in the comic widget. dataengines/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52930 Also here, qCritical seems to harsh. dataengines/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52931 This may litter the log file too much, I think. Maybe qDebug() here? dataengines/comic/comic.cpp https://git.reviewboard.kde.org/r/122668/#comment52932 remove? dataengines/comic/comicproviderwrapper.h https://git.reviewboard.kde.org/r/122668/#comment52933 doesn't seem to be initialized to 0 in the .cpp file. Potentially dangerous later on. - Sebastian Kügler On Feb. 25, 2015, 5 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122668/ --- (Updated Feb. 25, 2015, 5 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- this ports the comic applet to plasma5 (and the dataengine to kpackage, dropping the support of c++ comic plugins that don't exist anymore since KDE 4.3 anyways) Diffs - dataengines/comic/comicproviderkross.h d80a686 dataengines/comic/comicprovider.h db3c3f1 dataengines/comic/comic.h 38a3cc2 dataengines/CMakeLists.txt 41288df applets/comic/plasma-comic-default.desktop 69874bf applets/comic/package/contents/ui/main.qml 1862475 applets/comic/package/contents/ui/configGeneral.qml PRE-CREATION applets/comic/package/contents/ui/configAppearance.qml PRE-CREATION applets/comic/package/contents/ui/configAdvanced.qml PRE-CREATION
Re: Review Request 122733: Fix path traversal checks in KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review76933 --- Ship it! Very nice. :) - Sebastian Kügler On Feb. 26, 2015, 7:34 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ --- (Updated Feb. 26, 2015, 7:34 p.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kpackage Description --- They did not canonicalize the package base directory path so it would always fail when the package base path contained symlinks Diffs - src/kpackage/package.cpp eb4a09b987970e89f28587426b21d63731634087 src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122717: Improve tooltip layouting
On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: I'm now getting most of my headlines elided or wrapped: K-\n Menü 99%. Wird\n geladen (battery) Aktualisierung... (updater) KM... (rather than KMail) Volume at\n 45% (kmix) Donnerst... (rather than Donnerstag, digitalclock) Lukáš Tinkl wrote: Yup, seeing the same here: http://developer.kde.org/~lukas/screenshots/tooltip.png Sebastian Kügler wrote: Thanks for the feedback! This patch indeed shortens the max width a bit, so it's likely the culprit. Could you guys try changing property int preferredTextWidth: units.gridUnit * 20 to 25 or 30 and see if that fixes the problems? I'd like to not make it too wide, so we'll need some testing here, I think. Martin Klapetek wrote: 25 nor 30 does any difference here, in fact, not even 40 makes any difference at all Thanks for the testing. I've investigated a bit further, though without any conclusive solution. Let's take a step back. The implicitWidth of the text item (which is the width the text would be rendered at in one single line without linebreaks) set min and max width of the surrounding layout, which is propagated into the root item's Layout.min and Layout.max widths. On my system (Intel, dunno if it makes a difference), this works correctly, the dialog's size correctly makes the tooltip window resize and fit. The bug we're seeing looks like the dialog size is not correctly scaled up, so the text in the heading either breaks, or elides. What should happen here is that the mainitems Layout sizing takes preference, and the tooltip window is scaled to the content, not the other way around. I'm puzzled for now. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76692 --- On Feb. 26, 2015, 3:46 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 26, 2015, 3:46 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Improve tooltip layouting This patch ports the default tooltip away from custom spacing, positioning and Row/Column to QtQuick.Layouts. It makes the sizing more predictable, and the code more modern and readable. Tooltips feel to behave a bit smoother with this patch. In the process, this... - fixes spacing when no icon or image is set - limits the maximum height of the subtext to 8 lines (this prevents the klipper tooltip for example from growing super-high) - Makes the icon on the LHS proportional to the text - Limits the width a bit more to prevent super-wide tooltips - makes it use units.gridUnit throughout Changelog: Improve tooltip layout This is the more radical approach to https://git.reviewboard.kde.org/r/122715/ Diffs - src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae Diff: https://git.reviewboard.kde.org/r/122717/diff/ Testing --- Tested all applets' tooltips in the default panel File Attachments launcher (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/a6c636ce-3aef-4d5a-82f0-d78f9dab19a1__old-kickoff.png pager (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fae793bb-2965-4a81-be27-08efce5b3838__old-pager.png kdeconnect (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fc079c52-be17-47cf-bd11-976aed566155__old-kdeconnect.png clock (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/8214146b-cdd4-41d7-b406-f6fc404585cc__old-clock.png new-kickoff.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/9a96304f-1deb-4f57-9417-121a95b7ed03__new-kickoff.png new-pager.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/e2c5738f-e701-4a5e-a179-cedc6bb55181__new-pager.png new-kdeconnect.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/0c73a854-de8a-4dc2-bd57-c22e0700dbb5__new-kdeconnect.png new-clock.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/7311d304-cdf3-4bf2-8fdc-519d1a4c020d__new-clock.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122598: Add separate checkbox for automatically lock screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review76936 --- Ship it! Looking good as far as I can see. - Sebastian Kügler On Feb. 26, 2015, 12:06 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/ --- (Updated Feb. 26, 2015, 12:06 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This improves usability over setting the timeout to 0. Defaults behaviour is unchanged BUG: 342596 Diffs - ksmserver/screenlocker/kcm/kcm.ui fe32cf3 ksmserver/screenlocker/ksldapp.cpp 6c41f4e ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 Diff: https://git.reviewboard.kde.org/r/122598/diff/ Testing --- File Attachments a.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png aleix suggests doing this...thoughts? https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png this? https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/e4196951-0578-4149-914f-d310efe70ce2__this.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review76937 --- Ship it! Ship It! - Sebastian Kügler On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated Jan. 24, 2015, 11:54 p.m.) Review request for Plasma. Repository: kdeclarative Description --- Since there are already like 10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a KCMShell.open(foo) and KCMShell.open([foo, bar, baz]) singleton. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed Diff: https://git.reviewboard.kde.org/r/122239/diff/ Testing --- Works. Dunno if the name causes clashes or this is the right place to put it. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122781: Enable high DPI pixmaps in systemsettings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122781/#review76938 --- Coding all looks fine from my perspective. I don't have a Plasma 5 environment though - so can't comment on how well this works. - Ben Cooksley On March 2, 2015, 6:51 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122781/ --- (Updated March 2, 2015, 6:51 p.m.) Review request for Plasma and Ben Cooksley. Repository: systemsettings Description --- Enable high DPI pixmaps in systemsettings Diffs - app/main.cpp 150ca90 Diff: https://git.reviewboard.kde.org/r/122781/diff/ Testing --- Went through every KCM in systemsettings with QT_DEVICE_PIXEL_RATIO=2,including tree view and checked that nothing was broken. A few things are still low res pixmaps scaled up, but without this everything is low res pixmaps scaled up, so it's no worse. Full list of TODO tasks at https://todo.kde.org/?controller=taskaction=showtask_id=981. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation
https://bugs.kde.org/show_bug.cgi?id=344355 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kio- ||extras/d50a54f861f80f78d85f ||8fdefb6959f6c44828d3 Status|CONFIRMED |RESOLVED --- Comment #4 from Lukáš Tinkl lu...@kde.org --- Git commit d50a54f861f80f78d85f8fdefb6959f6c44828d3 by Lukáš Tinkl. Committed on 02/03/2015 at 08:38. Pushed by lukas into branch 'master'. unbreak thumbnail plguin loading M +2-1thumbnail/thumbnail.cpp http://commits.kde.org/kio-extras/d50a54f861f80f78d85f8fdefb6959f6c44828d3 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122506/ --- (Updated March 2, 2015, 8:48 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- Fix crash due to unsafe access to ShellCorona::m_screenConfiguration Diffs - shell/shellcorona.cpp cf489b9f8f1abce864bcb3375d3be01bc2c3430d Diff: https://git.reviewboard.kde.org/r/122506/diff/ Testing --- Thanks, Sandro Mani ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121206: Port savesystem to KDevPlatform and qml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- (Updated March 2, 2015, 4:30 p.m.) Review request for Plasma. Changes --- I have fixed the issues except from the QQuickWidget. When I try to add a QQuickWidget into a QDocWidget the QQuickWidget becomes black. Repository: plasmate Description --- This patch is a port of the savesystem to KDevPlatform and qml. Savesystem is using KDevPlatform's code for handling the git and the ui is rewritten in qml. I have attached an image of the new savesystem Diffs (updated) - plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION plasmate/plugins/savesystemview/Messages.sh PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION plasmate/plugins/savesystemview/git.h PRE-CREATION plasmate/plugins/savesystemview/git.cpp PRE-CREATION plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121206/diff/ Testing --- File Attachments savesystem in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122740: set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122740/#review76887 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015, 2:16 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122740/ --- (Updated Feb. 27, 2015, 2:16 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file Diffs - startkde/startkde.cmake 046543e Diff: https://git.reviewboard.kde.org/r/122740/diff/ Testing --- set it to 2. logged out, logged in everything was /huuuge/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76885 --- Code-wise, it looks fine to me. Could you add a screenshot, since it adds UI? - Sebastian Kügler On Feb. 27, 2015, 4:13 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated Feb. 27, 2015, 4:13 p.m.) Review request for Plasma. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Hey there! Today's minutes from our weekly hangout session ahead! Present: Harald, Kai, Martin G., Sebastian, David, Vishesh, Jonathan 2nd March, 2015 David * Merged timedated patches into systemsettings * worked on highdpi stuff, has test hardware now * Fixed ksnapshot hidpi * has Qt patches for hidpi * More hidpi stuff this week (mostly QT_DEVICE_PIXEL_RATIO) * Kubuntu testing fixes planned Vishesh * Worked on Xapian replacement, looking /really/ good performance-wise * Working on calculator runner to be safer not to lock up resources Jonathan * Released 5.2.1 bugfix update Harald * Just here for the biscuits (which biscuits? someone should bring biscuits!) * Looks into docs of release scripts, tarballs and translation problem Kai * Fixed bug in popups when switching themes (used wrong, transparent artwork) Marco * Working on hidpi support in FrameSvg ( https://git.reviewboard.kde.org/r/122673/ ) * Working on QML modules as KCModules * Works on a little tool to explore and edit Plasma themes Martin * Has Wayland server running, not yet able to manage Wayland clients * XWayland compositing, cursor handling and input goes through Wayland * Integrate Wayland clients, starting with Kwin's integrated ones, highly WIP * Work is in clones/mgraesslin/kwin[wayland-qpa-no-merge] * Problem with Samsung monitor and dpi settings / icon scaling * Fixed geolocation to use Mozilla location services * Patch to use wifi data for geolocation (will make it default to off for privacy) Sebastian Kügler * Rewrote Plasma's tooltip layout * WIP work on pager tooltips -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122766: Don't use a possibly non-existent property animationsEnabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122766/#review76872 --- Ship it! Ship It! - Marco Martin On Feb. 28, 2015, 10:47 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122766/ --- (Updated Feb. 28, 2015, 10:47 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- **Commit MSG:** ``` This prevents the following error message on plasmashell startup: default unknown: file:///usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml:448: Error: Cannot assign to non-existent property animationsEnabled ``` As I'm not sure what the hackery in the Timer element actually does, somebody needs to review this before I go and commit it. Diffs - containments/panel/contents/ui/main.qml 2772bfe934ca7a80e58953c15ed76d99c358 Diff: https://git.reviewboard.kde.org/r/122766/diff/ Testing --- - error message on plasmashell startup is gone - animations in panel still work Thanks, Elias Probst ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-desktop] applets/icontasks: make icontasks work with new sycocaless explorer
On Sat, Feb 28, 2015 at 11:54 PM, Marco Martin notm...@gmail.com wrote: so it gets listed but can't load? ookay (should still install the desktop file in services for now i think) Fixed in http://commits.kde.org/plasma-desktop/bbb8741d19d8a4cb68bb0e1d6f6c3c0e73707912 -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma Hangout
Ivan: In Moscow, spreading C++ and KDE love. Will be back this Thursday. Cheerio, Ivan On 2 March 2015 at 13:48, Sebastian Kügler se...@kde.org wrote: Hey there! Today's minutes from our weekly hangout session ahead! Present: Harald, Kai, Martin G., Sebastian, David, Vishesh, Jonathan 2nd March, 2015 David * Merged timedated patches into systemsettings * worked on highdpi stuff, has test hardware now * Fixed ksnapshot hidpi * has Qt patches for hidpi * More hidpi stuff this week (mostly QT_DEVICE_PIXEL_RATIO) * Kubuntu testing fixes planned Vishesh * Worked on Xapian replacement, looking /really/ good performance-wise * Working on calculator runner to be safer not to lock up resources Jonathan * Released 5.2.1 bugfix update Harald * Just here for the biscuits (which biscuits? someone should bring biscuits!) * Looks into docs of release scripts, tarballs and translation problem Kai * Fixed bug in popups when switching themes (used wrong, transparent artwork) Marco * Working on hidpi support in FrameSvg ( https://git.reviewboard.kde.org/r/122673/ ) * Working on QML modules as KCModules * Works on a little tool to explore and edit Plasma themes Martin * Has Wayland server running, not yet able to manage Wayland clients * XWayland compositing, cursor handling and input goes through Wayland * Integrate Wayland clients, starting with Kwin's integrated ones, highly WIP * Work is in clones/mgraesslin/kwin[wayland-qpa-no-merge] * Problem with Samsung monitor and dpi settings / icon scaling * Fixed geolocation to use Mozilla location services * Patch to use wifi data for geolocation (will make it default to off for privacy) Sebastian Kügler * Rewrote Plasma's tooltip layout * WIP work on pager tooltips -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122717: Improve tooltip layouting
On Feb. 26, 2015, 11:10 p.m., Kai Uwe Broulik wrote: I'm now getting most of my headlines elided or wrapped: K-\n Menü 99%. Wird\n geladen (battery) Aktualisierung... (updater) KM... (rather than KMail) Volume at\n 45% (kmix) Donnerst... (rather than Donnerstag, digitalclock) Lukáš Tinkl wrote: Yup, seeing the same here: http://developer.kde.org/~lukas/screenshots/tooltip.png Sebastian Kügler wrote: Thanks for the feedback! This patch indeed shortens the max width a bit, so it's likely the culprit. Could you guys try changing property int preferredTextWidth: units.gridUnit * 20 to 25 or 30 and see if that fixes the problems? I'd like to not make it too wide, so we'll need some testing here, I think. 25 nor 30 does any difference here, in fact, not even 40 makes any difference at all - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76692 --- On Feb. 26, 2015, 4:46 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 26, 2015, 4:46 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Improve tooltip layouting This patch ports the default tooltip away from custom spacing, positioning and Row/Column to QtQuick.Layouts. It makes the sizing more predictable, and the code more modern and readable. Tooltips feel to behave a bit smoother with this patch. In the process, this... - fixes spacing when no icon or image is set - limits the maximum height of the subtext to 8 lines (this prevents the klipper tooltip for example from growing super-high) - Makes the icon on the LHS proportional to the text - Limits the width a bit more to prevent super-wide tooltips - makes it use units.gridUnit throughout Changelog: Improve tooltip layout This is the more radical approach to https://git.reviewboard.kde.org/r/122715/ Diffs - src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae Diff: https://git.reviewboard.kde.org/r/122717/diff/ Testing --- Tested all applets' tooltips in the default panel File Attachments launcher (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/a6c636ce-3aef-4d5a-82f0-d78f9dab19a1__old-kickoff.png pager (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fae793bb-2965-4a81-be27-08efce5b3838__old-pager.png kdeconnect (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fc079c52-be17-47cf-bd11-976aed566155__old-kdeconnect.png clock (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/8214146b-cdd4-41d7-b406-f6fc404585cc__old-clock.png new-kickoff.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/9a96304f-1deb-4f57-9417-121a95b7ed03__new-kickoff.png new-pager.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/e2c5738f-e701-4a5e-a179-cedc6bb55181__new-pager.png new-kdeconnect.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/0c73a854-de8a-4dc2-bd57-c22e0700dbb5__new-kdeconnect.png new-clock.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/7311d304-cdf3-4bf2-8fdc-519d1a4c020d__new-clock.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1052
See http://build.kde.org/job/plasma-desktop_master_qt5/1052/changes Changes: [hein] Move SystemSettings to the Desktop plugin. -- [...truncated 243 lines...] -- Looking for XRRGetScreenResourcesCurrent -- Looking for XRRGetScreenResourcesCurrent - found -- Found OpenGL: /usr/lib64/libGL.so CMake Warning (dev) at solid-actions-kcm/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at applets/trash/plugin/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at kcms/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it. -- Found Freetype: /usr/lib64/libfreetype.so (found version 2.4.11) CMake Warning (dev) at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kauth/inst/lib64/cmake/KF5Auth/KF5AuthMacros.cmake:55 (add_custom_target): Policy CMP0037 is not set: Target names should not be reserved and should match a validity pattern. Run cmake --help-policy CMP0037 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The target name actions for org.kde.kcontrol.kcmclock is reserved or not valid for certain CMake features, such as generator expressions, and may result in undefined behavior. Call Stack (most recent call first): kcms/dateandtime/CMakeLists.txt:36 (kauth_install_actions) This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at kcms/autostart/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at kcms/desktoptheme/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it. -- Found PulseAudio: /usr/lib64/libpulse.so (found suitable version 3.0.0, minimum required is 0.9.16) -- Found GLIB2: /usr/lib64/libglib-2.0.so -- checking for module 'libcanberra' -- package 'libcanberra' not found -- Could NOT find Canberra (missing: CANBERRA_LIBRARIES CANBERRA_INCLUDE_DIRS) -- Looking for include file locale.h -- Looking for include file locale.h - found CMake Warning (dev) at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kauth/inst/lib64/cmake/KF5Auth/KF5AuthMacros.cmake:55 (add_custom_target): Policy CMP0037 is not set: Target names should not be reserved and should match a validity pattern. Run cmake --help-policy CMP0037 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The target name actions for org.kde.fontinst is reserved or not valid for certain CMake features, such as generator expressions, and may result in undefined behavior. Call Stack (most recent call first): kcms/kfontinst/dbus/CMakeLists.txt:31 (kauth_install_actions) This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at imports/activitymanager/CMakeLists.txt:3 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR This warning is for project developers. Use -Wno-dev to suppress it. -- Looking for dgettext -- Looking for dgettext - found -- Found
Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/#review76914 --- Ship it! Ship It! - Eike Hein On Feb. 27, 2015, 3:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- (Updated Feb. 27, 2015, 3:14 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- QVariantList are treated as objects with integer indexes for some reasons and leads to weird scenarios. Diffs - src/qmlcontrols/draganddrop/DeclarativeMimeData.h 4a0723b src/qmlcontrols/draganddrop/DeclarativeMimeData.cpp 0db74f9 Diff: https://git.reviewboard.kde.org/r/122741/diff/ Testing --- QuickShare plasmoid can use now DeclarativeMimeData. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- (Updated March 2, 2015, 6:14 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- QVariantList are treated as objects with integer indexes for some reasons and leads to weird scenarios. Diffs - src/qmlcontrols/draganddrop/DeclarativeMimeData.h 4a0723b src/qmlcontrols/draganddrop/DeclarativeMimeData.cpp 0db74f9 Diff: https://git.reviewboard.kde.org/r/122741/diff/ Testing --- QuickShare plasmoid can use now DeclarativeMimeData. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated March 2, 2015, 6:16 p.m.) Review request for Plasma. Changes --- add screenie. I'm not entirely happy with it, so suggestions welcome. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- File Attachments (updated) screenshot.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_master_qt5 #1053
See http://build.kde.org/job/plasma-desktop_master_qt5/1053/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76917 --- File Attachment: screenshot.png - screenshot.png https://git.reviewboard.kde.org//r/122742/#fcomment367 I'd suggest FormLayout/GridLayout so these are aligned - Martin Klapetek On March 2, 2015, 7:16 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated March 2, 2015, 7:16 p.m.) Review request for Plasma. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- File Attachments screenshot.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122781: Enable high DPI pixmaps in systemsettings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122781/ --- Review request for Plasma and Ben Cooksley. Repository: systemsettings Description --- Enable high DPI pixmaps in systemsettings Diffs - app/main.cpp 150ca90 Diff: https://git.reviewboard.kde.org/r/122781/diff/ Testing --- Went through every KCM in systemsettings with QT_DEVICE_PIXEL_RATIO=2,including tree view and checked that nothing was broken. A few things are still low res pixmaps scaled up, but without this everything is low res pixmaps scaled up, so it's no worse. Full list of TODO tasks at https://todo.kde.org/?controller=taskaction=showtask_id=981. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
