Re: Review Request 123106: Layout children in TabBarLayout right away
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123106/#review78038 --- Ship it! Ship It! - David Edmundson On March 22, 2015, 8:13 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123106/ --- (Updated March 22, 2015, 8:13 p.m.) Review request for Plasma. Repository: plasma-framework Description --- When Component.onCompleted is fired all the static children have been initialized thus we can call the layout function right away. OnChildrenChanged is fired like 20 times afterwards for some reason (the number of children doesn't change) compressed by the Timer. Diffs - src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml fd9f532 Diff: https://git.reviewboard.kde.org/r/123106/diff/ Testing --- Improves Kickoff's first appearance, the tabs no longer stick to the top left corner (top panel) for a couple of frames. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123124: Display an instance of the grey login strip in the sddm theme on every screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123124/#review78036 --- Ship it! Looks good. Do you have commit access? lookandfeel/contents/loginmanager/Main.qml (line 62) https://git.reviewboard.kde.org/r/123124/#comment53474 would be nice if you could also add a fake screenModel inisde the dummydata folder so the test still work? - David Edmundson On March 24, 2015, 11:29 p.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123124/ --- (Updated March 24, 2015, 11:29 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Display the grey login strip in sddm on every screen separated instead of displaying one strip that goes over all screens. The latter could result in a password promt or user selection that is subdivided into two parts on two screens. This commit displays the strip on every screen (like the background image) so it won't be subdivided anymore. Diffs - lookandfeel/contents/loginmanager/Main.qml edabd0c6eac1fbc038208010cc6c772acc735105 Diff: https://git.reviewboard.kde.org/r/123124/diff/ Testing --- Using sddm and the breeze theme with one and two monitors attached. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122332: KQuickControls IconDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122332/ --- (Updated March 25, 2015, 5:18 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Daniel Vrátil. Changes --- Submitted with commit eb9c12199be7f091463faeaca616759530408884 by Kai Uwe Broulik to branch master. Repository: kdeclarative Description --- This patch adds KQuickControls wrapper around KIconDialog similar to how the ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in Kickoff's config UI to provide a picker for a custom item. It is an initial draft and lacks for example window modality as I couldn't figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a lot of fixes for issues in that area on Review Board. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 tests/icondialog.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122332/diff/ Testing --- For testing I added a button to Kickoff that allows to open the dialog and the button icon source is bound to the dialog's iconName property. Didn't test the icon source/user/custom path stuff. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123106: Layout children in TabBarLayout right away
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123106/ --- (Updated March 25, 2015, 5:20 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit b7e4669db2f4ef5366f4dc5baee38bb809aaa5c7 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- When Component.onCompleted is fired all the static children have been initialized thus we can call the layout function right away. OnChildrenChanged is fired like 20 times afterwards for some reason (the number of children doesn't change) compressed by the Timer. Diffs - src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml fd9f532 Diff: https://git.reviewboard.kde.org/r/123106/diff/ Testing --- Improves Kickoff's first appearance, the tabs no longer stick to the top left corner (top panel) for a couple of frames. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122894: Add config option for Kickoff icon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122894/ --- (Updated March 25, 2015, 5:23 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit cc988b74382b8ab49cacb1056c6c7671f0eccc85 by Kai Uwe Broulik to branch master. Repository: plasma-desktop Description --- This restores the functionality from the 4.x times. The button uses the same style used in various places, such as lockscreen and display manager, it has a Choose action and a, previously missing, convenient Clear action. Diffs - applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 Diff: https://git.reviewboard.kde.org/r/122894/diff/ Testing --- Choosing an icon works, applying changes the icon, and reset resets it. Is there a way to set a config back to its defaults? File Attachments Config in action https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? Thomas Lübking wrote: - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. My use case for the dashboard was mainly, when I had a lot of windows and I wanted to customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you would have to use Show Desktop or change to an empty workspace. I really liked what we had in plasma5 till now, because the panels were accessible, why wouldn't they be? What speaks against the panels? They are accesible all the time, why wouldn't that be in dashboard mode too? When the panels are inacessible, I have to treat cutsomization (my main use case), seperately for widgets and panels, something I find an unnecessary barrier. If my opinion is worth anything here, I would vote for accessible panels, dimmed or not. On another note: even when you do not customize stuff, you use the dashboard/show desktop for accessing information on the workspace. Now I trigger dashboard, but want to have a look at a notificaiton too, while I am for example reading my plasma notes. Now I would have to exit the dashboard and reenter it, because the panels are not accessible. I don't think the panels ever distract that much, they should be made inaccessible. - kdeuser --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77926 --- On Feb. 26, 2015, 1:16 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 26, 2015, 1:16 p.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more
Re: Review Request 123046: Use own copy of org.kde.JobView.xml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123046/#review78040 --- Ping. This is now needed with kjobwidgets master for setError being called in adaptors and thus making the error value available in dataengine. - David Rosca On March 19, 2015, 11:16 a.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123046/ --- (Updated March 19, 2015, 11:16 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- Use own copy of org.kde.JobView interface file to make it possible to extend the interface without breaking build (https://git.reviewboard.kde.org/r/122970/) This also fixes 2 cases where error/errorText would be incorrect in applicationsjob dataengine. Diffs - dataengines/applicationjobs/CMakeLists.txt e25ff0c dataengines/applicationjobs/jobaction.cpp f06977e kuiserver/CMakeLists.txt a4fc049 kuiserver/org.kde.JobView.xml PRE-CREATION kuiserver/progresslistmodel.cpp 11fccac Diff: https://git.reviewboard.kde.org/r/123046/diff/ Testing --- build works fine Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123131: Port kio_man away from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/ --- Review request for KDE Frameworks and Plasma. Repository: kio-extras Description --- Port kio_man away from kdelibs4support Diffs - CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 Diff: https://git.reviewboard.kde.org/r/123131/diff/ Testing --- man view in kdevelop5 works Not sure about the `KLocale::global()-languageList();` - `QLocale().uiLanguages();` change though so I would like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122850: Fix regression in highlight of tabboxes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122850/ --- (Updated mar. 25, 2015, 8:18 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 341007 http://bugs.kde.org/show_bug.cgi?id=341007 Repository: kdeplasma-addons Description --- Don't animate the highlight when the holder is not visible This way it's always at the correct place on first show. Diffs - windowswitchers/thumbnails/contents/ui/main.qml f70b3fc windowswitchers/informative/contents/ui/main.qml e50dee6 windowswitchers/text/contents/ui/main.qml 79f97c9 windowswitchers/compact/contents/ui/main.qml c90959d windowswitchers/IconTabBox.qml 589d3da Diff: https://git.reviewboard.kde.org/r/122850/diff/ Testing --- Did an alt+tab, didn't get dizzy because the tab was going backwards when it should not. Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123131: Port kio_man away from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78044 --- - please add Martin Koller, kio_man maintainer. - about the locale, I fear a difference between Qt locales and system locales; it should be properly checked - Luigi Toscano On March 25, 2015, 9:41 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/ --- (Updated March 25, 2015, 9:41 p.m.) Review request for KDE Frameworks and Plasma. Repository: kio-extras Description --- Port kio_man away from kdelibs4support Diffs - CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 Diff: https://git.reviewboard.kde.org/r/123131/diff/ Testing --- man view in kdevelop5 works Not sure about the `KLocale::global()-languageList();` - `QLocale().uiLanguages();` change though so I would like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123131: Port kio_man away from kdelibs4support
On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: man/kio_man.cpp, line 242 https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. please see https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp for the ways to get a list of all languages (there is a KDE-way and Qt-way) - Nick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78048 --- On March 25, 2015, 9:17 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/ --- (Updated March 25, 2015, 9:17 p.m.) Review request for KDE Frameworks, Plasma and Martin Koller. Repository: kio-extras Description --- Port kio_man away from kdelibs4support Diffs - CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 Diff: https://git.reviewboard.kde.org/r/123131/diff/ Testing --- man view in kdevelop5 works Not sure about the `KLocale::global()-languageList();` - `QLocale().uiLanguages();` change though so I would like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123131: Port kio_man away from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78048 --- man/kio_man.cpp (line 242) https://git.reviewboard.kde.org/r/123131/#comment53475 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. - Lukáš Tinkl On Bře. 25, 2015, 10:17 odp., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/ --- (Updated Bře. 25, 2015, 10:17 odp.) Review request for KDE Frameworks, Plasma and Martin Koller. Repository: kio-extras Description --- Port kio_man away from kdelibs4support Diffs - CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 Diff: https://git.reviewboard.kde.org/r/123131/diff/ Testing --- man view in kdevelop5 works Not sure about the `KLocale::global()-languageList();` - `QLocale().uiLanguages();` change though so I would like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123131: Port kio_man away from kdelibs4support
On März 25, 2015, 9:54 nachm., Lukáš Tinkl wrote: man/kio_man.cpp, line 242 https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. Nick Shaforostoff wrote: please see https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp for the ways to get a list of all languages (there is a KDE-way and Qt-way) So if I parse this correctly the KDE way is: `KConfig(QLatin1String(locale/kf5_all_languages), KConfig::NoGlobals, QStandardPaths::GenericDataLocation).groupList()`? Should there be something in KI18n or is this sufficiently rare that we can just add @deprecated use `KConfig(QLatin1String(locale/kf5_all_languages), KConfig::NoGlobals, QStandardPaths::GenericDataLocation).groupList()` instead to KLocale::languageList()? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78048 --- On März 25, 2015, 9:17 nachm., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/ --- (Updated März 25, 2015, 9:17 nachm.) Review request for KDE Frameworks, Plasma and Martin Koller. Repository: kio-extras Description --- Port kio_man away from kdelibs4support Diffs - CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 Diff: https://git.reviewboard.kde.org/r/123131/diff/ Testing --- man view in kdevelop5 works Not sure about the `KLocale::global()-languageList();` - `QLocale().uiLanguages();` change though so I would like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.4 release schedule
On Wed, Mar 25, 2015 at 2:13 AM, Jonathan Riddell j...@jriddell.org wrote: If it's only for a couple of weeks we can just advise distros to either wait for next dolphin or take a snapshot? I'm not willing to wait till Frameworks 5.9 + .6 = 5.15 Probably it's too late, what's the relevance of this? Hopefully, Baloo will become a framework with 5.9. If I'm not allowed to cause it will break Dolphin, then I'll have to wait till KF 5.12 because it will continue being part of Plasma and packagers will complain if Baloo is shipped with both frameworks and Plasma at the same time. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
