Re: Review Request 123088: Adding libkactivities-stats to the build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78062 --- Ship it! Ship It! - Marco Martin On March 26, 2015, 7:34 a.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 7:34 a.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/common.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml PRE-CREATION lib/kactivities-stats/src/common/specialvalues.h PRE-CREATION lib/kactivities-stats/src/lib/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.h PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake PRE-CREATION lib/kactivities-stats/src/lib/stats/query.h PRE-CREATION lib/kactivities-stats/src/lib/stats/query.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.h PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/version.h PRE-CREATION lib/kactivities-stats/src/lib/stats/version.cpp PRE-CREATION lib/kactivities-stats/src/utils/continue_with.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr_implementation.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.cpp PRE-CREATION lib/kactivities-stats/src/utils/debug_and_return.h PRE-CREATION lib/kactivities-stats/src/utils/for_each_assoc.h PRE-CREATION lib/kactivities-stats/src/utils/lazy_val.h PRE-CREATION lib/kactivities-stats/src/utils/member_matcher.h PRE-CREATION
Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible
On March 14, 2015, 10:29 p.m., Eike Hein wrote: @Eike: Could you check whether this makes it more viable for Kicker? Will do tomorrow. Might make it _more_ viable, but probably not viable yet - the other problem is that Kicker really wants to disable the blend tween completely, because it works very hard to reuse existing delegate instances when you switch categories. That is, when you move from one category to another and they differ in size, delegates may be created or destroyed as needed to fit the new size, but existing ones are reused and just handed new data. Since the text labels don't blend it's awkward when the icons do, and also generally makes things feel too slow. Tried it now - initial appearance seems fine, but the crossblends during category moves are still the expected problem (they don't even start at the same time, so ... really ugly). - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review77482 --- On March 14, 2015, 2:53 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated March 14, 2015, 2:53 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We have a lot of reusable singletons that are just hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the previous state, even if the previous action happened minutes ago. This patch makes it track its visibility and skip the fade-and-wait dance when it just became visible. It also removes a visible false call in the tooltip which I didn't know what it was for. (With it in place, the IconItem always becomes visible when moving between tooltip areas, breaking the animation altogether). @Eike: Could you check whether this makes it more viable for Kicker? Diffs - src/declarativeimports/core/iconitem.h 3ef0306 src/declarativeimports/core/iconitem.cpp d653bf3 src/declarativeimports/core/tooltip.cpp 40e0af5 Diff: https://git.reviewboard.kde.org/r/122859/diff/ Testing --- Moving between tray icons - icon fades, moving relly rapidly causes it not to load any icon until you halt (dunno if that happened before but doesn't seem too bad) Hovering tray icon, leaving, waiting, hovering another one - icon does not fade, is there right away There is an issue with the OSD where it would not fade at all anymore when changing states (eg. change volume, then screen brightness), only on the first invocation, hence the WIP badge. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123088: Adding libkactivities-stats to the build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78061 --- Ship it! Ship It! - Eike Hein On March 26, 2015, 7:34 a.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 7:34 a.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/common.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml PRE-CREATION lib/kactivities-stats/src/common/specialvalues.h PRE-CREATION lib/kactivities-stats/src/lib/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.h PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake PRE-CREATION lib/kactivities-stats/src/lib/stats/query.h PRE-CREATION lib/kactivities-stats/src/lib/stats/query.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.h PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/version.h PRE-CREATION lib/kactivities-stats/src/lib/stats/version.cpp PRE-CREATION lib/kactivities-stats/src/utils/continue_with.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr_implementation.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.cpp PRE-CREATION lib/kactivities-stats/src/utils/debug_and_return.h PRE-CREATION lib/kactivities-stats/src/utils/for_each_assoc.h PRE-CREATION lib/kactivities-stats/src/utils/lazy_val.h PRE-CREATION lib/kactivities-stats/src/utils/member_matcher.h PRE-CREATION
Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123136/#review78069 --- shell/panelview.cpp (line 429) https://git.reviewboard.kde.org/r/123136/#comment53490 and here? shell/panelview.cpp (line 433) https://git.reviewboard.kde.org/r/123136/#comment53491 and here. shell/panelview.cpp (line 443) https://git.reviewboard.kde.org/r/123136/#comment53489 and here? shell/panelview.cpp (line 453) https://git.reviewboard.kde.org/r/123136/#comment53488 comments Otherwise someone is going to smartly change this to say topLeft(); - David Edmundson On March 26, 2015, 4:41 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123136/ --- (Updated March 26, 2015, 4:41 p.m.) Review request for Plasma, Martin Gräßlin and Marco Martin. Bugs: 339323 and 340549 https://bugs.kde.org/show_bug.cgi?id=339323 https://bugs.kde.org/show_bug.cgi?id=340549 Repository: plasma-workspace Description --- Appearantly right() / bottomRight() / topRight() returns values with 1 pixel x off for historical reasons and hence 1px gap. This causes the autohide panel not hiding automatically. Diffs - shell/panelview.cpp 3435736 Diff: https://git.reviewboard.kde.org/r/123136/diff/ Testing --- added right aligned panel and tested various combinations Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123136/ --- Review request for Plasma, Martin Gräßlin and Marco Martin. Bugs: 339323 and 340549 https://bugs.kde.org/show_bug.cgi?id=339323 https://bugs.kde.org/show_bug.cgi?id=340549 Repository: plasma-workspace Description --- Appearantly right() / bottomRight() / topRight() returns values with 1 pixel x off for historical reasons and hence 1px gap. This causes the autohide panel not hiding automatically. Diffs - shell/panelview.cpp 3435736 Diff: https://git.reviewboard.kde.org/r/123136/diff/ Testing --- added right aligned panel and tested various combinations Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123142: Fixes plasma-desktop compilation with boost 1.56
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/ --- Review request for Plasma. Repository: plasma-desktop Description --- Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed. Diffs - lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 Diff: https://git.reviewboard.kde.org/r/123142/diff/ Testing --- compiles. Thanks, Tomaz Canabrava ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/ --- (Updated March 26, 2015, 7:47 p.m.) Review request for Plasma. Summary (updated) - Fixes plasma-desktop compilation with boost 1.57 Repository: plasma-desktop Description --- Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed. Diffs - lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 Diff: https://git.reviewboard.kde.org/r/123142/diff/ Testing --- compiles. Thanks, Tomaz Canabrava ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/#review78077 --- +1, should fix the build for me. Not sure what the preferred style in plasma is (`static_castbool(foo)` or `bool(foo)`) so I can't give the ship it. - Alex Richardson On March 26, 2015, 7:47 p.m., Tomaz Canabrava wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/ --- (Updated March 26, 2015, 7:47 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed. Diffs - lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 Diff: https://git.reviewboard.kde.org/r/123142/diff/ Testing --- compiles. Thanks, Tomaz Canabrava ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123088: Adding libkactivities-stats to the build
On March 26, 2015, 3:34 p.m., Hrvoje Senjan wrote: the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` Ivan Čukić wrote: Is it fixed if you replace with this (seems this is a nice 1.56 bug): bool thisValid = !!currentValue; bool otherValid = !!other.currentValue; Seems they are using c++11 `explicit operator bool()`, so I wouldn't call it a bug but intentional. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- On March 26, 2015, 1:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 1:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION
Re: Review Request 123088: Adding libkactivities-stats to the build
On March 26, 2015, 4:34 p.m., Hrvoje Senjan wrote: the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` Ivan Čukić wrote: Is it fixed if you replace with this (seems this is a nice 1.56 bug): bool thisValid = !!currentValue; bool otherValid = !!other.currentValue; Alex Richardson wrote: Seems they are using c++11 `explicit operator bool()`, so I wouldn't call it a bug but intentional. builds with https://build.opensuse.org/package/view_file/KDE:Unstable:Frameworks/plasma5-desktop/boost.diff?expand=1 - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- On March 26, 2015, 2:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 2:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt
Re: Review Request 123088: Adding libkactivities-stats to the build
On March 26, 2015, 3:34 p.m., Hrvoje Senjan wrote: the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` Is it fixed if you replace with this (seems this is a nice 1.56 bug): bool thisValid = !!currentValue; bool otherValid = !!other.currentValue; - Ivan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- On March 26, 2015, 1:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 1:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh
Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible
On March 14, 2015, 10:29 p.m., Eike Hein wrote: @Eike: Could you check whether this makes it more viable for Kicker? Will do tomorrow. Might make it _more_ viable, but probably not viable yet - the other problem is that Kicker really wants to disable the blend tween completely, because it works very hard to reuse existing delegate instances when you switch categories. That is, when you move from one category to another and they differ in size, delegates may be created or destroyed as needed to fit the new size, but existing ones are reused and just handed new data. Since the text labels don't blend it's awkward when the icons do, and also generally makes things feel too slow. Eike Hein wrote: Tried it now - initial appearance seems fine, but the crossblends during category moves are still the expected problem (they don't even start at the same time, so ... really ugly). Nope, doesn't help with bug 345545. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review77482 --- On March 14, 2015, 2:53 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated March 14, 2015, 2:53 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We have a lot of reusable singletons that are just hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the previous state, even if the previous action happened minutes ago. This patch makes it track its visibility and skip the fade-and-wait dance when it just became visible. It also removes a visible false call in the tooltip which I didn't know what it was for. (With it in place, the IconItem always becomes visible when moving between tooltip areas, breaking the animation altogether). @Eike: Could you check whether this makes it more viable for Kicker? Diffs - src/declarativeimports/core/iconitem.h 3ef0306 src/declarativeimports/core/iconitem.cpp d653bf3 src/declarativeimports/core/tooltip.cpp 40e0af5 Diff: https://git.reviewboard.kde.org/r/122859/diff/ Testing --- Moving between tray icons - icon fades, moving relly rapidly causes it not to load any icon until you halt (dunno if that happened before but doesn't seem too bad) Hovering tray icon, leaving, waiting, hovering another one - icon does not fade, is there right away There is an issue with the OSD where it would not fade at all anymore when changing states (eg. change volume, then screen brightness), only on the first invocation, hence the WIP badge. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345208] OSD not updating when keeping brightness keys pressed.
https://bugs.kde.org/show_bug.cgi?id=345208 --- Comment #5 from Antonis G. gaanto...@civil.auth.gr --- I am sorry I don't have access to these machines for the time being. Also kmix works as expected on the othe hand. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123088: Adding libkactivities-stats to the build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 1:47 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Eike Hein and Marco Martin. Changes --- Submitted with commit cc309752f42806eca73e212fd89f3b8a580277d8 by Ivan ?uki? to branch master. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/common.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml PRE-CREATION lib/kactivities-stats/src/common/specialvalues.h PRE-CREATION lib/kactivities-stats/src/lib/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.h PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake PRE-CREATION lib/kactivities-stats/src/lib/stats/query.h PRE-CREATION lib/kactivities-stats/src/lib/stats/query.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.h PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/version.h PRE-CREATION lib/kactivities-stats/src/lib/stats/version.cpp PRE-CREATION lib/kactivities-stats/src/utils/continue_with.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr_implementation.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.cpp PRE-CREATION lib/kactivities-stats/src/utils/debug_and_return.h PRE-CREATION lib/kactivities-stats/src/utils/for_each_assoc.h PRE-CREATION lib/kactivities-stats/src/utils/lazy_val.h PRE-CREATION lib/kactivities-stats/src/utils/member_matcher.h PRE-CREATION lib/kactivities-stats/src/utils/merge_into.h PRE-CREATION lib/kactivities-stats/src/utils/qsqlquery_iterator.h PRE-CREATION lib/kactivities-stats/src/utils/qsqlquery_iterator.cpp PRE-CREATION lib/kactivities-stats/src/utils/range.h PRE-CREATION
Build failed in Jenkins: plasma-desktop_master_qt5 #1124
See http://build.kde.org/job/plasma-desktop_master_qt5/1124/changes Changes: [ivan.cukic] Adding libkactivities-stats to the build -- [...truncated 1009 lines...] Scanning dependencies of target fontthumbnail_automoc [ 19%] Automatic moc for target kio_fonts [ 19%] Automatic moc for target fontthumbnail [ 19%] Built target fontthumbnail_automoc Scanning dependencies of target kfontviewpart_automoc [ 20%] Automatic moc for target kfontviewpart Generating fonts.moc Generating moc_fonts.cpp [ 20%] Built target kcm_fonts_automoc Generating moc_FontinstIface.cpp Generating moc_Helper.cpp Scanning dependencies of target knetattach_automoc [ 20%] [ 20%] Built target fontinst_helper_automoc Generating moc_Viewer.cpp Automatic moc for target knetattach [ 20%] Built target kfontview_bin_automoc Scanning dependencies of target attica_kde_automoc [ 20%] Scanning dependencies of target activityswitcherextensionplugin_automoc [ 20%] Automatic moc for target attica_kde Automatic moc for target activityswitcherextensionplugin Generating moc_knetattach.cpp [ 20%] Built target knetattach_automoc [ 20%] Generating ui_ActionEditor.h [ 21%] Generating moc_kdeplatformdependent.cpp Generating moc_Printer.cpp Generating moc_ActionLabel.cpp Generating moc_FontInst.cpp Generating moc_FontinstIface.cpp [ 21%] Generating ui_SolidActions.h [ 21%] Built target attica_kde_automoc [ 21%] Built target fontinst_bin_automoc [ 21%] Built target kfontprint_bin_automoc Generating ui_AddAction.h [ 21%] Generating resourceslinking_interface.cpp, resourceslinking_interface.h [ 21%] Generating resourcesscoring_interface.cpp, resourcesscoring_interface.h Generating switcherbackend.moc http://build.kde.org/job/plasma-desktop_master_qt5/ws/imports/activitymanager/switcherbackend.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target solid-action-desktop-gen [ 21%] Generating resourceslinking_interface.moc [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/DesktopFileGenerator.cpp.o [ 21%] Generating resourcesscoring_interface.moc Generating moc_FontinstIface.cpp Generating moc_ActionLabel.cpp Generating moc_JobRunner.cpp Generating moc_FontinstIface.cpp Generating moc_FontInstInterface.cpp [ 21%] [ 21%] Built target kfontinst_bin_automoc Scanning dependencies of target desktopplugin Built target kio_fonts_automoc [ 21%] Generating ksmserver_interface.cpp, ksmserver_interface.h [ 21%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/desktopplugin.cpp.o [ 21%] Generating ksmserver_interface.moc Generating moc_activityswitcherextensionplugin.cpp Generating moc_switcherbackend.cpp Scanning dependencies of target KF5ActivitiesExperimentalStats [ 21%] Built target activityswitcherextensionplugin_automoc [ 22%] Scanning dependencies of target kcm_solid_actions Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/eventforge.cpp.o [ 23%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/query.cpp.o [ 23%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateItem.cpp.o Scanning dependencies of target folderplugin [ 24%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/directorypicker.cpp.o Generating FontViewPart.moc Generating moc_FontinstIface.cpp Generating moc_CharTip.cpp Generating moc_FontPreview.cpp Generating moc_FontViewPart.cpp Generating moc_PreviewSelectAction.cpp [ 24%] Built target kfontviewpart_automoc [ 24%] http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:28:17: warning: unused parameter ‘types’ [-Wunused-parameter] inline void validateTypes(QStringList types) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:33:17: warning: unused parameter ‘agents’ [-Wunused-parameter] inline void validateAgents(QStringList agents) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:38:17: warning: unused parameter ‘activities’ [-Wunused-parameter] inline void validateActivities(QStringList activities) ^ Scanning dependencies of target kickerplugin Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateModel.cpp.o [ 24%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/SolidActionData.cpp.o [ 24%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/abstractentry.cpp.o [ 24%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/terms.cpp.o [ 24%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/resultset.cpp.o [ 24%] Building CXX object
Re: Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/#review78063 --- Ship it! Ship It! - Marco Martin On March 23, 2015, 7:06 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/ --- (Updated March 23, 2015, 7:06 p.m.) Review request for Plasma. Repository: plasma-framework Description --- When the tooltip is empty (no text and no subtext and no mainitem) it will not show. However, when it becomes empty while it is shown, it stays there as a small rectangle. This patch hides the tooltip immediately (so KWin's fadeout animation still has the proper content rather than the empty tooltip) when the area has been destroyed or its content becomes empty. It access s_dialog directly not to unneccessarily create a tooltipInstance just for a call in the destructor or that wouldn't have effect without a tooltip anyway. Diffs - src/declarativeimports/core/tooltip.h 7a58826 src/declarativeimports/core/tooltip.cpp 40e0af5 src/declarativeimports/core/tooltipdialog.h d81dadb src/declarativeimports/core/tooltipdialog.cpp 6c5675e Diff: https://git.reviewboard.kde.org/r/122939/diff/ Testing --- Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon. Previously the tooltip would change into an empty rectangle, staying there until the tooltip times out, now it hides nicely. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1127
See http://build.kde.org/job/plasma-desktop_master_qt5/1127/changes Changes: [ivan.cukic] And another place for the new boost to complain removed. -- [...truncated 1296 lines...] KComponentData componentData(); ^ In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.cpp:21:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:98:54: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KService::Ptr Kickoff::serviceForUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:138:49: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] bool KRunnerItemHandler::openUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual Qt::ItemFlags Kickoff::KRunnerModel::flags(const QModelIndex) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:258:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual QMimeData* Kickoff::KRunnerModel::mimeData(const QModelIndexList) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:272:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:275:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:287:39: warning: ‘void KUrl::List::populateMimeData(QMimeData*, const MetaDataMap, KUrl::MimeDataFlags) const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:221) [-Wdeprecated-declarations] urls.populateMimeData(mimeData); ^ In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:38:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp: In member function ‘void Kickoff::LeaveModel::updateModel()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:181:85: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:74) [-Wdeprecated-declarations] QSet Solid::PowerManagement::SleepState spdMethods = Solid::PowerManagement::supportedSleepStates(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:181:106: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at
[Powerdevil] [Bug 345533] Crash on resume from suspend
https://bugs.kde.org/show_bug.cgi?id=345533 Christoph Feck cf...@kde.org changed: What|Removed |Added Component|kded|general Assignee|unassigned-b...@kde.org |plasma-devel@kde.org Product|kdelibs |Powerdevil -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_master_qt5 #1128
See http://build.kde.org/job/plasma-desktop_master_qt5/1128/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1126
See http://build.kde.org/job/plasma-desktop_master_qt5/1126/changes Changes: [ivan.cukic] Fixing the build with the newer boost library versions -- [...truncated 1008 lines...] Scanning dependencies of target fontthumbnail_automoc [ 19%] Automatic moc for target kio_fonts [ 19%] Automatic moc for target fontthumbnail Generating moc_FontinstIface.cpp Generating moc_Helper.cpp [ 19%] [ 19%] Built target fontinst_helper_automoc Built target fontthumbnail_automoc Generating fonts.moc Generating moc_fonts.cpp Scanning dependencies of target kfontviewpart_automoc Scanning dependencies of target knetattach_automoc [ 20%] [ 20%] [ 20%] Automatic moc for target kfontviewpart Automatic moc for target knetattach Built target kcm_fonts_automoc Scanning dependencies of target attica_kde_automoc Generating moc_Viewer.cpp [ 20%] Generating moc_knetattach.cpp [ 20%] [ 20%] Built target kfontview_bin_automoc Automatic moc for target attica_kde Built target knetattach_automoc [ 20%] Scanning dependencies of target activityswitcherextensionplugin_automoc Generating ui_ActionEditor.h [ 20%] Generating moc_Printer.cpp Generating moc_ActionLabel.cpp Automatic moc for target activityswitcherextensionplugin [ 20%] Built target kfontprint_bin_automoc [ 21%] Generating ui_SolidActions.h Generating moc_FontInst.cpp Generating moc_FontinstIface.cpp [ 21%] Built target fontinst_bin_automoc [ 21%] Generating ui_AddAction.h [ 21%] Generating resourceslinking_interface.cpp, resourceslinking_interface.h Generating moc_kdeplatformdependent.cpp [ 21%] Built target attica_kde_automoc [ 21%] Scanning dependencies of target solid-action-desktop-gen Generating resourcesscoring_interface.cpp, resourcesscoring_interface.h [ 21%] [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/DesktopFileGenerator.cpp.o Generating resourceslinking_interface.moc [ 21%] [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/SolidActionData.cpp.o Generating resourcesscoring_interface.moc Generating switcherbackend.moc http://build.kde.org/job/plasma-desktop_master_qt5/ws/imports/activitymanager/switcherbackend.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target kcm_solid_actions Generating moc_FontinstIface.cpp Generating moc_FontInstInterface.cpp [ 21%] Generating moc_FontinstIface.cpp Generating moc_ActionLabel.cpp Generating moc_JobRunner.cpp Scanning dependencies of target KF5ActivitiesExperimentalStats Built target kio_fonts_automoc [ 21%] [ 21%] Built target kfontinst_bin_automoc [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateItem.cpp.o Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/solid-action-desktop-gen_automoc.cpp.o [ 22%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/query.cpp.o Generating moc_activityswitcherextensionplugin.cpp Generating moc_switcherbackend.cpp [ 22%] Built target activityswitcherextensionplugin_automoc [ 22%] Scanning dependencies of target desktopplugin Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateModel.cpp.o [ 22%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/desktopplugin.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:28:17: warning: unused parameter ‘types’ [-Wunused-parameter] inline void validateTypes(QStringList types) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:33:17: warning: unused parameter ‘agents’ [-Wunused-parameter] inline void validateAgents(QStringList agents) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:38:17: warning: unused parameter ‘activities’ [-Wunused-parameter] inline void validateActivities(QStringList activities) ^ [ 22%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/terms.cpp.o [ 22%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/resultset.cpp.o Generating FontViewPart.moc Generating moc_FontinstIface.cpp Generating moc_CharTip.cpp Generating moc_FontPreview.cpp Generating moc_FontViewPart.cpp Generating moc_PreviewSelectAction.cpp [ 23%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/ActionItem.cpp.o [ 23%] Built target kfontviewpart_automoc [ 23%] Generating ksmserver_interface.cpp, ksmserver_interface.h [ 23%] Generating ksmserver_interface.moc Linking CXX executable solid-action-desktop-gen Scanning dependencies of target folderplugin [ 24%] [ 24%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/foldermodel.cpp.o Building CXX object
Re: Build failed in Jenkins: plasma-desktop_master_qt5 #1126
Which version of boost does jenkins have? Cheers, Ivan On 26 March 2015 at 21:44, KDE CI System n...@kde.org wrote: See http://build.kde.org/job/plasma-desktop_master_qt5/1126/changes Changes: [ivan.cukic] Fixing the build with the newer boost library versions -- [...truncated 1008 lines...] Scanning dependencies of target fontthumbnail_automoc [ 19%] Automatic moc for target kio_fonts [ 19%] Automatic moc for target fontthumbnail Generating moc_FontinstIface.cpp Generating moc_Helper.cpp [ 19%] [ 19%] Built target fontinst_helper_automoc Built target fontthumbnail_automoc Generating fonts.moc Generating moc_fonts.cpp Scanning dependencies of target kfontviewpart_automoc Scanning dependencies of target knetattach_automoc [ 20%] [ 20%] [ 20%] Automatic moc for target kfontviewpart Automatic moc for target knetattach Built target kcm_fonts_automoc Scanning dependencies of target attica_kde_automoc Generating moc_Viewer.cpp [ 20%] Generating moc_knetattach.cpp [ 20%] [ 20%] Built target kfontview_bin_automoc Automatic moc for target attica_kde Built target knetattach_automoc [ 20%] Scanning dependencies of target activityswitcherextensionplugin_automoc Generating ui_ActionEditor.h [ 20%] Generating moc_Printer.cpp Generating moc_ActionLabel.cpp Automatic moc for target activityswitcherextensionplugin [ 20%] Built target kfontprint_bin_automoc [ 21%] Generating ui_SolidActions.h Generating moc_FontInst.cpp Generating moc_FontinstIface.cpp [ 21%] Built target fontinst_bin_automoc [ 21%] Generating ui_AddAction.h [ 21%] Generating resourceslinking_interface.cpp, resourceslinking_interface.h Generating moc_kdeplatformdependent.cpp [ 21%] Built target attica_kde_automoc [ 21%] Scanning dependencies of target solid-action-desktop-gen Generating resourcesscoring_interface.cpp, resourcesscoring_interface.h [ 21%] [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/DesktopFileGenerator.cpp.o Generating resourceslinking_interface.moc [ 21%] [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/SolidActionData.cpp.o Generating resourcesscoring_interface.moc Generating switcherbackend.moc http://build.kde.org/job/plasma-desktop_master_qt5/ws/imports/activitymanager/switcherbackend.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target kcm_solid_actions Generating moc_FontinstIface.cpp Generating moc_FontInstInterface.cpp [ 21%] Generating moc_FontinstIface.cpp Generating moc_ActionLabel.cpp Generating moc_JobRunner.cpp Scanning dependencies of target KF5ActivitiesExperimentalStats Built target kio_fonts_automoc [ 21%] [ 21%] Built target kfontinst_bin_automoc [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateItem.cpp.o Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/solid-action-desktop-gen_automoc.cpp.o [ 22%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/query.cpp.o Generating moc_activityswitcherextensionplugin.cpp Generating moc_switcherbackend.cpp [ 22%] Built target activityswitcherextensionplugin_automoc [ 22%] Scanning dependencies of target desktopplugin Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateModel.cpp.o [ 22%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/desktopplugin.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:28:17: warning: unused parameter ‘types’ [-Wunused-parameter] inline void validateTypes(QStringList types) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:33:17: warning: unused parameter ‘agents’ [-Wunused-parameter] inline void validateAgents(QStringList agents) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/lib/kactivities-stats/src/lib/stats/query.cpp:38:17: warning: unused parameter ‘activities’ [-Wunused-parameter] inline void validateActivities(QStringList activities) ^ [ 22%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/terms.cpp.o [ 22%] Building CXX object lib/kactivities-stats/src/lib/stats/CMakeFiles/KF5ActivitiesExperimentalStats.dir/resultset.cpp.o Generating FontViewPart.moc Generating moc_FontinstIface.cpp Generating moc_CharTip.cpp Generating moc_FontPreview.cpp Generating moc_FontViewPart.cpp Generating moc_PreviewSelectAction.cpp [ 23%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/ActionItem.cpp.o [ 23%] Built target kfontviewpart_automoc [ 23%] Generating ksmserver_interface.cpp, ksmserver_interface.h [ 23%] Generating ksmserver_interface.moc Linking CXX
Re: Review Request 123088: Adding libkactivities-stats to the build
On March 26, 2015, 3:34 p.m., Hrvoje Senjan wrote: the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` Ivan Čukić wrote: Is it fixed if you replace with this (seems this is a nice 1.56 bug): bool thisValid = !!currentValue; bool otherValid = !!other.currentValue; Alex Richardson wrote: Seems they are using c++11 `explicit operator bool()`, so I wouldn't call it a bug but intentional. Hrvoje Senjan wrote: builds with https://build.opensuse.org/package/view_file/KDE:Unstable:Frameworks/plasma5-desktop/boost.diff?expand=1 @Alex, yes, it seems intentional. Then I'd call it an intentional bug :) (api break, if nothing else) @Hrvoje master now contains a fixed version - Ivan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- On March 26, 2015, 1:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 1:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs
Re: Review Request 123088: Adding libkactivities-stats to the build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 7:34 a.m.) Review request for Plasma, Eike Hein and Marco Martin. Changes --- Do not instal Devel files Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs (updated) - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/common.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml PRE-CREATION lib/kactivities-stats/src/common/specialvalues.h PRE-CREATION lib/kactivities-stats/src/lib/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.h PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake PRE-CREATION lib/kactivities-stats/src/lib/stats/query.h PRE-CREATION lib/kactivities-stats/src/lib/stats/query.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.h PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/version.h PRE-CREATION lib/kactivities-stats/src/lib/stats/version.cpp PRE-CREATION lib/kactivities-stats/src/utils/continue_with.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr.h PRE-CREATION lib/kactivities-stats/src/utils/d_ptr_implementation.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.h PRE-CREATION lib/kactivities-stats/src/utils/dbusfuture_p.cpp PRE-CREATION lib/kactivities-stats/src/utils/debug_and_return.h PRE-CREATION lib/kactivities-stats/src/utils/for_each_assoc.h PRE-CREATION lib/kactivities-stats/src/utils/lazy_val.h PRE-CREATION lib/kactivities-stats/src/utils/member_matcher.h PRE-CREATION lib/kactivities-stats/src/utils/merge_into.h PRE-CREATION lib/kactivities-stats/src/utils/qsqlquery_iterator.h PRE-CREATION lib/kactivities-stats/src/utils/qsqlquery_iterator.cpp PRE-CREATION lib/kactivities-stats/src/utils/range.h PRE-CREATION lib/kactivities-stats/src/utils/remove_if.h PRE-CREATION lib/kactivities-stats/src/utils/slide.h PRE-CREATION
[Breeze] [Bug 345547] New: Caps Lock warning is always on with Breeze SDDM theme
https://bugs.kde.org/show_bug.cgi?id=345547 Bug ID: 345547 Summary: Caps Lock warning is always on with Breeze SDDM theme Product: Breeze Version: 5.2.2 Platform: ROSA RPMs OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: pul...@list.ru Caps Lock warning is always on with Breeze SDDM theme. There's no such issue with screenlocker or small testing QML application used to read data from keystate engine. SDDM 0.11.0. Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123088: Adding libkactivities-stats to the build
On 21-Mar-2015 2:38 am, Ivan Čukić ivan.cu...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ Review request for Plasma, Eike Hein and Marco Martin. By Ivan Čukić. Repository: plasma-desktop Description The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs CMakeLists.txt (2d43890) lib/kactivities-stats/CMakeLists.txt (PRE-CREATION) lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in (PRE-CREATION) lib/kactivities-stats/README (PRE-CREATION) lib/kactivities-stats/src/CMakeLists.txt (PRE-CREATION) lib/kactivities-stats/src/Messages.sh (PRE-CREATION) lib/kactivities-stats/src/common/database/Database.h (PRE-CREATION) lib/kactivities-stats/src/common/database/Database.cpp (PRE-CREATION) lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h (PRE-CREATION) lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp (PRE-CREATION) lib/kactivities-stats/src/common/dbus/common.h (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml (PRE-CREATION) lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml (PRE-CREATION) lib/kactivities-stats/src/common/specialvalues.h (PRE-CREATION) lib/kactivities-stats/src/lib/CMakeLists.txt (PRE-CREATION) lib/kactivities-stats/src/lib/stats/CMakeLists.txt (PRE-CREATION) lib/kactivities-stats/src/lib/stats/activitiessync_p.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake (PRE-CREATION) lib/kactivities-stats/src/lib/stats/query.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/query.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultmodel.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultmodel.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultset.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultset.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultwatcher.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/resultwatcher.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/terms.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/terms.cpp (PRE-CREATION) lib/kactivities-stats/src/lib/stats/version.h (PRE-CREATION) lib/kactivities-stats/src/lib/stats/version.cpp (PRE-CREATION) lib/kactivities-stats/src/utils/continue_with.h (PRE-CREATION) lib/kactivities-stats/src/utils/d_ptr.h (PRE-CREATION) lib/kactivities-stats/src/utils/d_ptr_implementation.h (PRE-CREATION) lib/kactivities-stats/src/utils/dbusfuture_p.h (PRE-CREATION) lib/kactivities-stats/src/utils/dbusfuture_p.cpp (PRE-CREATION) lib/kactivities-stats/src/utils/debug_and_return.h (PRE-CREATION) lib/kactivities-stats/src/utils/for_each_assoc.h (PRE-CREATION) lib/kactivities-stats/src/utils/lazy_val.h (PRE-CREATION) lib/kactivities-stats/src/utils/member_matcher.h (PRE-CREATION) lib/kactivities-stats/src/utils/merge_into.h (PRE-CREATION) lib/kactivities-stats/src/utils/qsqlquery_iterator.h (PRE-CREATION) lib/kactivities-stats/src/utils/qsqlquery_iterator.cpp (PRE-CREATION) lib/kactivities-stats/src/utils/range.h (PRE-CREATION) lib/kactivities-stats/src/utils/remove_if.h (PRE-CREATION) lib/kactivities-stats/src/utils/slide.h (PRE-CREATION) lib/kactivities-stats/update.sh (PRE-CREATION) View Diff ___ Plasma-devel mailing list Plasma-devel@kde.org
Re: Review Request 123088: Adding libkactivities-stats to the build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` - Hrvoje Senjan On March 26, 2015, 2:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 2:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION
[Breeze] [Bug 345547] Caps Lock warning is always on with Breeze SDDM theme
https://bugs.kde.org/show_bug.cgi?id=345547 Rajeesh K Nambiar rajeeshknamb...@gmail.com changed: What|Removed |Added CC||rajeeshknamb...@gmail.com --- Comment #1 from Rajeesh K Nambiar rajeeshknamb...@gmail.com --- Also reproducible here with 5.2.1, x86_64 Fedora 21. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123124: Display an instance of the grey login strip in the sddm theme on every screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123124/ --- (Updated March 26, 2015, 4:53 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Display the grey login strip in sddm on every screen separated instead of displaying one strip that goes over all screens. The latter could result in a password promt or user selection that is subdivided into two parts on two screens. This commit displays the strip on every screen (like the background image) so it won't be subdivided anymore. Diffs (updated) - lookandfeel/contents/loginmanager/Main.qml edabd0c6eac1fbc038208010cc6c772acc735105 lookandfeel/contents/loginmanager/dummydata/screenModel.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123124/diff/ Testing --- Using sddm and the breeze theme with one and two monitors attached. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1125
See http://build.kde.org/job/plasma-desktop_master_qt5/1125/changes Changes: [notmart] position considering availableScreenRegion -- [...truncated 1322 lines...] In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/applicationmodel.h:25:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/kickoffplugin.cpp:21: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ [ 37%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/subdialog.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:98:54: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KService::Ptr Kickoff::serviceForUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:138:49: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] bool KRunnerItemHandler::openUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual Qt::ItemFlags Kickoff::KRunnerModel::flags(const QModelIndex) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:258:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual QMimeData* Kickoff::KRunnerModel::mimeData(const QModelIndexList) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:272:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:275:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:287:39: warning: ‘void KUrl::List::populateMimeData(QMimeData*, const MetaDataMap, KUrl::MimeDataFlags) const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:221) [-Wdeprecated-declarations] urls.populateMimeData(mimeData); ^ [ 37%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/viewpropertiesmenu.cpp.o [ 37%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/menuentryeditor.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:38:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp: In member function ‘void Kickoff::LeaveModel::updateModel()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:181:85: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:74) [-Wdeprecated-declarations] QSet Solid::PowerManagement::SleepState spdMethods = Solid::PowerManagement::supportedSleepStates();
Re: Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/ --- (Updated March 26, 2015, 2:26 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 4985a4fe6508c7219145776101eecd3d3eaeb871 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- When the tooltip is empty (no text and no subtext and no mainitem) it will not show. However, when it becomes empty while it is shown, it stays there as a small rectangle. This patch hides the tooltip immediately (so KWin's fadeout animation still has the proper content rather than the empty tooltip) when the area has been destroyed or its content becomes empty. It access s_dialog directly not to unneccessarily create a tooltipInstance just for a call in the destructor or that wouldn't have effect without a tooltip anyway. Diffs - src/declarativeimports/core/tooltip.h 7a58826 src/declarativeimports/core/tooltip.cpp 40e0af5 src/declarativeimports/core/tooltipdialog.h d81dadb src/declarativeimports/core/tooltipdialog.cpp 6c5675e Diff: https://git.reviewboard.kde.org/r/122939/diff/ Testing --- Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon. Previously the tooltip would change into an empty rectangle, staying there until the tooltip times out, now it hides nicely. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/#review78064 --- Ship it! src/declarativeimports/core/tooltip.cpp (line 312) https://git.reviewboard.kde.org/r/122939/#comment53485 I think checking owner here is going to fix some bugs too. - David Edmundson On March 23, 2015, 7:06 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122939/ --- (Updated March 23, 2015, 7:06 p.m.) Review request for Plasma. Repository: plasma-framework Description --- When the tooltip is empty (no text and no subtext and no mainitem) it will not show. However, when it becomes empty while it is shown, it stays there as a small rectangle. This patch hides the tooltip immediately (so KWin's fadeout animation still has the proper content rather than the empty tooltip) when the area has been destroyed or its content becomes empty. It access s_dialog directly not to unneccessarily create a tooltipInstance just for a call in the destructor or that wouldn't have effect without a tooltip anyway. Diffs - src/declarativeimports/core/tooltip.h 7a58826 src/declarativeimports/core/tooltip.cpp 40e0af5 src/declarativeimports/core/tooltipdialog.h d81dadb src/declarativeimports/core/tooltipdialog.cpp 6c5675e Diff: https://git.reviewboard.kde.org/r/122939/diff/ Testing --- Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon. Previously the tooltip would change into an empty rectangle, staying there until the tooltip times out, now it hides nicely. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123124: Display an instance of the grey login strip in the sddm theme on every screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123124/ --- (Updated March 26, 2015, 3:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 1985e8bf6bbc6044bd5ffac3c1b501536f2d1dd2 by David Edmundson on behalf of David Kahles to branch master. Repository: plasma-workspace Description --- Display the grey login strip in sddm on every screen separated instead of displaying one strip that goes over all screens. The latter could result in a password promt or user selection that is subdivided into two parts on two screens. This commit displays the strip on every screen (like the background image) so it won't be subdivided anymore. Diffs - lookandfeel/contents/loginmanager/Main.qml edabd0c6eac1fbc038208010cc6c772acc735105 lookandfeel/contents/loginmanager/dummydata/screenModel.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123124/diff/ Testing --- Using sddm and the breeze theme with one and two monitors attached. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
