[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.
https://bugs.kde.org/show_bug.cgi?id=345209 Antonis G. gaanto...@civil.auth.gr changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from Antonis G. gaanto...@civil.auth.gr --- Yep, your wright, closing. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module
On Wednesday 08 April 2015 23:25:40 Ragnar Thomsen wrote: Hey Plasma devs, My name is Ragnar Thomsen. I have developed a kcm module for managing systemd called kcmsystemd, which some of you may be familiar with. Kcmsystemd currently allows for controlling systemd units, logind sessions, timers and easy editing of the main config files. Recently, I ported kcmsystemd to KF5. Kcmsystemd is currently hosted on GitHub (https://github.com/rthomsen/kcmsystemd), but I was encouraged by Jonathan Riddell to move it to KDE infrastructure. So I have now acquired a KDE dev account and will attempt to setup a repository under playground/sysadmin. Any comments on kcmsystemd are welcome :) I will be using the nick rthomsen on IRC. looking forward to it, and welcome! -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma/5.3 branched, master will be 5.4
I've branched for 5.3, please ensure bugfixes go into both Plasma/5.3 and master branches. Go wild in master. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 Michael Palimaka kensing...@gentoo.org changed: What|Removed |Added Version|5.2.0 |5.2.2 CC||kensing...@gentoo.org --- Comment #20 from Michael Palimaka kensing...@gentoo.org --- (In reply to Eric Hameleers from comment #19) You will get shutdown reboot back by editing /usr/bin/startkde and changing the line: kwrapper5 ksmserver $KDEWM $KSMSERVEROPTIONS to ksmserver $KDEWM $KSMSERVEROPTIONS i.e. by removing the kwrapper5. I can confirm that removing kwrapper causes shutdown/reboot entries to reappear. It turns out that launching ksmserver with kwrapper5 causes org.freedesktop.ConsoleKit.Manager.CanStop to return false. Not really sure what the cause of that could be. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KGamma and Plasma
On Thursday 09 April 2015 16:29:05 David Edmundson wrote: A while back I ported kgamma to KF5, which is in a branch somewhere. It's currently being released with applications, which doesn't really make sense as it's a KCM. As far as I can tell the main author is inactive. We have two options: - move kgamma to kde/workspace for Plasma 5.4 - merge the code into plasma-desktop with the other kcms I'm torn as on one hand I don't like having a lot of repos for tiny things on the other gamma adjustment really isn't an essential thing, and I like having a core - extra stuff split. It seems a month ago Lukas ported colord-kde, as I understand it these two do basically the same thing but with competing implementations. So maybe there's a 3rd option of going with that. The main author on that also seems to have been inactive in that repo for a long time. Thoughts? workspace/kcmaddons? perhaps can be moved there even stuff from plasma-desktop not 100% needed, so minimalist/poweruser setups would be one installed package away -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 9, 2015, 1:41 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit ba61ce61b4e1ebb28df0cc10aefa7a1824282394 by Antonis Tsiapaliokas to branch master. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KGamma and Plasma
On Thursday 09 April 2015 16:29:05 David Edmundson wrote: A while back I ported kgamma to KF5, which is in a branch somewhere. It's currently being released with applications, which doesn't really make sense as it's a KCM. As far as I can tell the main author is inactive. We have two options: - move kgamma to kde/workspace for Plasma 5.4 - merge the code into plasma-desktop with the other kcms I'm torn as on one hand I don't like having a lot of repos for tiny things on the other gamma adjustment really isn't an essential thing, and I like having a core - extra stuff split. It seems a month ago Lukas ported colord-kde, as I understand it these two do basically the same thing but with competing implementations. So maybe there's a 3rd option of going with that. The main author on that also seems to have been inactive in that repo for a long time. I wouldn't call it competing implementation, just a different scale. colord gives better results than kgamma if it works, if not kgamma is better than nothing. Given that it would be awesome if we could figure out whether colord is properly supported and then show colord, otherwise kgamma. Does that sound possible? Anyway I'd say both are candidates for plasma-desktop. Oh and yes there is the 3rd way which is hooked up with KWin's color correction. But that is such a weird setup that I still haven't succeeded with setting it up at all. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #22 from Michael Palimaka kensing...@gentoo.org --- Created attachment 91963 -- https://bugs.kde.org/attachment.cgi?id=91963action=edit environment with krapper -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
5.3 errata
5.3 beta tars are made, please add known bugs and features which have been removed to: (I've put bugs marked critical on it already) https://community.kde.org/Plasma/5.3_Errata There two seem kindae nasty, could someone confirm them? 345459 systemse kcm_desk unassigned-b...@kde.org UNCO --- Changing 'Downloads' default path attempts to move *ALL* files in $HOME to new location 345729 systemse kcm_desk unassigned-b...@kde.org UNCO --- Changing the directory of documents completely wipes out user's home folder Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KGamma and Plasma
A while back I ported kgamma to KF5, which is in a branch somewhere. It's currently being released with applications, which doesn't really make sense as it's a KCM. As far as I can tell the main author is inactive. We have two options: - move kgamma to kde/workspace for Plasma 5.4 - merge the code into plasma-desktop with the other kcms I'm torn as on one hand I don't like having a lot of repos for tiny things on the other gamma adjustment really isn't an essential thing, and I like having a core - extra stuff split. It seems a month ago Lukas ported colord-kde, as I understand it these two do basically the same thing but with competing implementations. So maybe there's a 3rd option of going with that. The main author on that also seems to have been inactive in that repo for a long time. Thoughts? David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #23 from Michael Palimaka kensing...@gentoo.org --- Created attachment 91964 -- https://bugs.kde.org/attachment.cgi?id=91964action=edit environment without kwrapper -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 Michael Palimaka kensing...@gentoo.org changed: What|Removed |Added Attachment #91963|environment with krapper|environment with kwrapper description|| -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.
https://bugs.kde.org/show_bug.cgi?id=345209 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #3 from David Edmundson k...@davidedmundson.co.uk --- Hrvoje Senjan does it still show the battery OK? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-devel] Re: Default wallpaper
Thanks Johnathon, For clarity, David updated the intended 5.3 default wallpaper, Next. I added a few more wallpapers from the wallpaper competition (not default, but meant to be shipped). Hope that makes sense. Thanks again, Andrew On Thu, Apr 9, 2015, 6:00 AM Jonathan Riddell j...@jriddell.org wrote: On Wed, Apr 08, 2015 at 11:25:07PM +0200, David Edmundson wrote: this is now all sorted. These were put in breeze, I've moved them now to plasma-workspace-wallpapers in svn. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 5.3 beta tars
beta tars for Plasma 5.3 are up on depot for packagers sha256 and git commits at http://starsky.19inch.net/~jr/tmp/5.2.95-release-data kinfocentre has had about-distro added so you'll need to remove that package if you use it. also worth checking it works for your distro as it's the new kinfocentre front page gone is -libbluedevil (replaced by bluez-qt) -libmm-qt (now in kf 5.9) all new is +bluez-qt - new bluedevil library +plasma-mediacenter - a tech preview of the kf5 port) +plasma-sdk - you may be familiar with plasmate which this includes although it's not currently compiled and again in beta +user-manager Lots of new wallpapers in plasma-workspace-wallpapers from the competition but that's still being sorted so I'll make that tar this evening. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 09, 2015 at 10:30:34PM +0200, Vishesh Handa wrote: On Thu, Apr 9, 2015 at 10:01 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: A A Hi Johnathan A A Could you please tell me what is accomplished by creating this errata A A page? It means people can see what significant problems exist before they install.A It means people can see what bugs are known when they are reporting bugs.A It means people upgrading from Plasma 4 can see what features are missing.A It's a very normal part of release notes. Great. That makes sense. However, the page currently also lists bugs -A Bugs https://bugs.kde.org/342631 user-manager overlaps Account Details KCM http://bugs.kde.org/338506 image wallpapers are blurry in scaled and scaled and cropped mode https://bugs.kde.org/346018 The default wallpaper has pixelated lines https://bugs.kde.org/233471 Baloo abuses Disk access for excessive periods of time after startup https://bugs.kde.org/341581 baloo_file - using 100% cpu I'm confused as to why need to specifically duplicate these bugs when they are already present in the bug tracker. I agree that these bugs have a 'critical' flag set, but highlighting them doesn't help us in any way. I refer the honourable gentleman to the answer I gave some moments ago It means people can see what significant problems exist before they install. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
On April 8, 2015, 4:41 p.m., David Edmundson wrote: New plan as I didn't really like this, and now I have another 3 months. I want to move the Xft.dpi setting currently in the fonts KCM into here as a slider with a preview. (It turns out you can store xrdb settings per screen, but we'll need to patch the Qt XCB plugin to make full use of that. Either way, no worse than current state) Then I'll make it scale everything if the logical DPI is set to 144. Will save having two similar things in two places, and it will make doing 1.5 scaling look kinda sensible. Nice, sounds good to me. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review78678 --- On April 8, 2015, 4:41 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated April 8, 2015, 4:41 p.m.) Review request for Plasma. Repository: kscreen Description --- Add a combo box to select QT_DEVICE_PIXEL_RATIO Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. Diffs - CMakeLists.txt 6f1769a kcm/src/CMakeLists.txt 8c693b5 kcm/src/kcm_kscreen.cpp b9f3596 kcm/src/widget.h 88d6407 kcm/src/widget.cpp 9ff8af6 Diff: https://git.reviewboard.kde.org/r/122742/diff/ Testing --- File Attachments screenshot.png https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
On April 7, 2015, 8:31 a.m., Marco Martin wrote: wallpapers/image/imagepackage/contents/ui/config.qml, line 296 https://git.reviewboard.kde.org/r/123275/diff/1/?file=360286#file360286line296 hmm, not understanding exactly why the index has to be decremented by count. shouldn't be just deceremented by 1 iff the removed index is than currentindex? Antonis Tsiapaliokas wrote: No, because if we remove 5 wallpapers instead of 1, then we are still going to point into the wrong wallpaper. Right? Marco Martin wrote: shouldn't be done for each wallaper every time, so always 1? Marco Martin wrote: any updates on this? yes, but technically we cannot decrease the index by 1 for each wallpaper, because multiple wallpapers can be deleted at once And we can only understand how many wallpapers have been deleted. We cannot understand which wallpaper has been deleted and when... - Antonis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/#review78598 --- On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 6, 2015, 1:15 p.m.) Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123303: include FindPackageHandleStandardArgs rather than find it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123303/#review78702 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 9, 2015, 10:22 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123303/ --- (Updated April 9, 2015, 10:22 a.m.) Review request for Plasma and Aleix Pol Gonzalez. Repository: kde-gtk-config Description --- FindPackageHandleStandardArgs is a macro include not an actual finder, find_package actually will refuse to find it anyway, only reason this did not have adverse effects is supposedly because the GTK3 finder correctly includes it. it does however falsely report it as missing (what with it not being found by find_package) Diffs - cmake/modules/FindGTK2.cmake 75c2aba933c41f4bbfcb44eb2deaf424064de752 Diff: https://git.reviewboard.kde.org/r/123303/diff/ Testing --- clean cmake make with all deps installed Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: 5.3 errata
On Thursday 09 April 2015 21:01:13 Jonathan Riddell wrote: On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: Hi Johnathan Could you please tell me what is accomplished by creating this errata page? It means people can see what significant problems exist before they install. It means people can see what bugs are known when they are reporting bugs. It means people upgrading from Plasma 4 can see what features are missing. It's a very normal part of release notes. For example I know that there are (very few) people considering window tabbing as a killer feature. For them a switch to Plasma 5 would be a major regression and a reason to stay on Plasma 4 - which is totally fine. Such a page puts out the warning and also tells away the screaming from disappointed users. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KGamma and Plasma
Dne 9.4.2015 v 16:29 David Edmundson napsal(a): A while back I ported kgamma to KF5, which is in a branch somewhere. It's currently being released with applications, which doesn't really make sense as it's a KCM. As far as I can tell the main author is inactive. We have two options: - move kgamma to kde/workspace for Plasma 5.4 - merge the code into plasma-desktop with the other kcms I'm torn as on one hand I don't like having a lot of repos for tiny things on the other gamma adjustment really isn't an essential thing, and I like having a core - extra stuff split. It seems a month ago Lukas ported colord-kde, as I understand it these two do basically the same thing but with competing implementations. So maybe there's a 3rd option of going with that. The main author on that also seems to have been inactive in that repo for a long time. Thoughts? David Well kcmcolord does a slightly different (more complete in a way) thing and, unlike the kwin color correction, works independently from the window manager. Having said that, I'd like to see colord-kde moved into plasma-desktop, together with other kcms and kgamma possibly too, to act as a fallback to it. -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: Hi Johnathan Could you please tell me what is accomplished by creating this errata page? It means people can see what significant problems exist before they install. It means people can see what bugs are known when they are reporting bugs. It means people upgrading from Plasma 4 can see what features are missing. It's a very normal part of release notes. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123294: Fix check to see if we are the active window before showing notification in polkit agent
On April 8, 2015, 4:08 p.m., Martin Gräßlin wrote: AuthDialog.cpp, lines 320-321 https://git.reviewboard.kde.org/r/123294/diff/1/?file=360483#file360483line320 one event cycle might not be sufficient to figure out whether it's the active window. And honestly I have no idea how one could get the information whether the window manager processed it in a reliable way. What might be the most reliable is to wait for the window being added to KWindowSystem::stackingOrder (there's a changed signal). It would give at least the hint that the window manager processed the window being shown. David Edmundson wrote: The check to see if we're on top is currently broken. It looks at kwindowsystem::activeWindow which indirectly comes from looking a property on the root window. KWindowsystem only updates changes from the root window system every event loop. So we can't use the value directly after we've opened our dialog. Given we're calling forceWindowActive in policykitlistener when we show, so I don't actually need to see what the window manager has to say as I know we'll always be on top. To some extent we don't need this notification code at all, and I could just remove it. However, for the case that forceWindowActive doesn't work (such as running on Wayland) I left the code in. Martin Gräßlin wrote: forceWindowActive does not guarantee that you will have focus afterwards. It will also not (even less) guarantee that it's the top most window. David Edmundson wrote: If forceWindowActive doesn't force the window to be active that's a bug in kwin. In any case, for now I'll just delete that notification. no, it isn't. Nothing in forceWindowActive doesn't guarantee it. What if at the same time another window calls it? You are interacting with a different system which doesn't give you the guarantee you expect. And this has nothing to do with KWin, but with how X11 works. No window manager in this world can guarantee this. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123294/#review78671 --- On April 8, 2015, 3:16 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123294/ --- (Updated April 8, 2015, 3:16 p.m.) Review request for Plasma. Repository: polkit-kde-agent-1 Description --- KWindowSystem::activeWindow result is cached, we need to process an event loop for it to update. Diffs - AuthDialog.h 561c6a0 AuthDialog.cpp 16ee64d Diff: https://git.reviewboard.kde.org/r/123294/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
On April 7, 2015, 8:31 a.m., Marco Martin wrote: wallpapers/image/imagepackage/contents/ui/config.qml, line 296 https://git.reviewboard.kde.org/r/123275/diff/1/?file=360286#file360286line296 hmm, not understanding exactly why the index has to be decremented by count. shouldn't be just deceremented by 1 iff the removed index is than currentindex? Antonis Tsiapaliokas wrote: No, because if we remove 5 wallpapers instead of 1, then we are still going to point into the wrong wallpaper. Right? Marco Martin wrote: shouldn't be done for each wallaper every time, so always 1? Marco Martin wrote: any updates on this? Antonis Tsiapaliokas wrote: yes, but technically we cannot decrease the index by 1 for each wallpaper, because multiple wallpapers can be deleted at once And we can only understand how many wallpapers have been deleted. We cannot understand which wallpaper has been deleted and when... ok, so go for it (closing the bug) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/#review78598 --- On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 6, 2015, 1:15 p.m.) Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
On April 7, 2015, 8:31 a.m., Marco Martin wrote: wallpapers/image/imagepackage/contents/ui/config.qml, line 296 https://git.reviewboard.kde.org/r/123275/diff/1/?file=360286#file360286line296 hmm, not understanding exactly why the index has to be decremented by count. shouldn't be just deceremented by 1 iff the removed index is than currentindex? Antonis Tsiapaliokas wrote: No, because if we remove 5 wallpapers instead of 1, then we are still going to point into the wrong wallpaper. Right? Marco Martin wrote: shouldn't be done for each wallaper every time, so always 1? any updates on this? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/#review78598 --- On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 6, 2015, 1:15 p.m.) Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated April 9, 2015, 1:53 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 9, 2015 at 10:46 PM, Jonathan Riddell j...@jriddell.org wrote: Really this is normal practice. Can you please give me sources for this? KDE 4.9 - No errata KDE 4.10 - No errata KDE 4.11 - No errata The applications release has a 'This is a list of grave bugs and common pitfalls surfacing after the release was packaged' [1]. That doesn't seem like an errata. Just for the record, I'm not against highlighting missing features on the errata. I am, however, very against linking to bugs from 2010, which aren't solvable. -- Vishesh Handa [1] https://www.kde.org/info/applications-15.03.95.php ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 9, 2015 at 10:01 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: Hi Johnathan Could you please tell me what is accomplished by creating this errata page? It means people can see what significant problems exist before they install. It means people can see what bugs are known when they are reporting bugs. It means people upgrading from Plasma 4 can see what features are missing. It's a very normal part of release notes. Great. That makes sense. However, the page currently also lists bugs - Bugs https://bugs.kde.org/342631 user-manager overlaps Account Details KCM http://bugs.kde.org/338506 image wallpapers are blurry in scaled and scaled and cropped mode https://bugs.kde.org/346018 The default wallpaper has pixelated lines https://bugs.kde.org/233471 Baloo abuses Disk access for excessive periods of time after startup https://bugs.kde.org/341581 baloo_file - using 100% cpu I'm confused as to why need to specifically duplicate these bugs when they are already present in the bug tracker. I agree that these bugs have a 'critical' flag set, but highlighting them doesn't help us in any way. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123303: include FindPackageHandleStandardArgs rather than find it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123303/ --- (Updated April 9, 2015, 12:05 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Aleix Pol Gonzalez. Changes --- Submitted with commit 3d751fa7b762d20c2650ada5648c2a7bb1b4f007 by Harald Sitter to branch master. Repository: kde-gtk-config Description --- FindPackageHandleStandardArgs is a macro include not an actual finder, find_package actually will refuse to find it anyway, only reason this did not have adverse effects is supposedly because the GTK3 finder correctly includes it. it does however falsely report it as missing (what with it not being found by find_package) Diffs - cmake/modules/FindGTK2.cmake 75c2aba933c41f4bbfcb44eb2deaf424064de752 Diff: https://git.reviewboard.kde.org/r/123303/diff/ Testing --- clean cmake make with all deps installed Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/#review78701 --- Ship it! Ship It! - Marco Martin On April 6, 2015, 1:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- (Updated April 6, 2015, 1:15 p.m.) Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.
https://bugs.kde.org/show_bug.cgi?id=345209 --- Comment #4 from Hrvoje Senjan hrvoje.sen...@gmail.com --- It shows Fully charged - i shall believe it =) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123294: Fix check to see if we are the active window before showing notification in polkit agent
On April 8, 2015, 2:08 p.m., Martin Gräßlin wrote: AuthDialog.cpp, lines 320-321 https://git.reviewboard.kde.org/r/123294/diff/1/?file=360483#file360483line320 one event cycle might not be sufficient to figure out whether it's the active window. And honestly I have no idea how one could get the information whether the window manager processed it in a reliable way. What might be the most reliable is to wait for the window being added to KWindowSystem::stackingOrder (there's a changed signal). It would give at least the hint that the window manager processed the window being shown. David Edmundson wrote: The check to see if we're on top is currently broken. It looks at kwindowsystem::activeWindow which indirectly comes from looking a property on the root window. KWindowsystem only updates changes from the root window system every event loop. So we can't use the value directly after we've opened our dialog. Given we're calling forceWindowActive in policykitlistener when we show, so I don't actually need to see what the window manager has to say as I know we'll always be on top. To some extent we don't need this notification code at all, and I could just remove it. However, for the case that forceWindowActive doesn't work (such as running on Wayland) I left the code in. Martin Gräßlin wrote: forceWindowActive does not guarantee that you will have focus afterwards. It will also not (even less) guarantee that it's the top most window. If forceWindowActive doesn't force the window to be active that's a bug in kwin. In any case, for now I'll just delete that notification. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123294/#review78671 --- On April 8, 2015, 1:16 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123294/ --- (Updated April 8, 2015, 1:16 p.m.) Review request for Plasma. Repository: polkit-kde-agent-1 Description --- KWindowSystem::activeWindow result is cached, we need to process an event loop for it to update. Diffs - AuthDialog.h 561c6a0 AuthDialog.cpp 16ee64d Diff: https://git.reviewboard.kde.org/r/123294/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-devel] Re: Default wallpaper
On Wed, Apr 08, 2015 at 11:25:07PM +0200, David Edmundson wrote: this is now all sorted. These were put in breeze, I've moved them now to plasma-workspace-wallpapers in svn. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-devel] Re: Default wallpaper
On Thursday 09 April 2015 13:06:32 Andrew Lake wrote: Thanks Johnathon, For clarity, David updated the intended 5.3 default wallpaper, Next. I added a few more wallpapers from the wallpaper competition (not default, but meant to be shipped). Hope that makes sense. yes, basically the idea is that in breeze there stays only one wallpaper, the default one, while the other ones, usually photos, go in plasma-workspace-wallpapers in svn so the git repo doesn't get too much clobbered in huge binaries (even with just the default one may become too big in the future tough) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #24 from Michael Palimaka kensing...@gentoo.org --- Note that the environment with kwrapper is from kwrapper5 ksmserver and ksmserver [kdeinit5] has none. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 changelog
Major things: - touchpad KCM is back (not by me, but it hasn't been mentioned yet) - oxygen window deco is back - timedated support in clock KCM (setting NTP works again!) - more performance improvements Also I think we should have a paragraph on bugs, we've closed 343 bugs as resolved-fixed since 5.2 https://bugs.kde.org/buglist.cgi?bug_status=RESOLVEDchfield=resolutionchfieldfrom=2015-01-27chfieldto=Nowknown_name=AllPlasmalist_id=1242660product=Breezeproduct=kde-cli-toolsproduct=kde-gtk-configproduct=kded-appmenuproduct=kdeplasma-addonsproduct=khelpcenterproduct=khotkeysproduct=kinfocenterproduct=kio-extrasproduct=klipperproduct=kmenueditproduct=knetattachproduct=krunnerproduct=ksmserverproduct=ksplashproduct=ksshaskpassproduct=kstartproduct=ksysguardproduct=kwaylandproduct=kwinproduct=kwritedproduct=muonproduct=Plasma%20Workspace%20Wallpapersproduct=plasma-nmproduct=plasmashellproduct=Powerdevilproduct=solidproduct=systemsettingsquery_based_on=AllPlasmaquery_format=advancedresolution=FIXED ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123290: Port task manager away from mouse event listener
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123290/ --- (Updated April 9, 2015, 6:14 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Eike Hein. Bugs: 339482 https://bugs.kde.org/show_bug.cgi?id=339482 Repository: plasma-desktop Description --- For some reason, MouseEventListener exists because mousearea in qml 1.0 doesn't handle wheel event. Now seems it's fine to use Qt5's MouseArea. And it will handle my touch screen event properly. MouseEventListener doesn't call onReleased on my touch screen. Diffs - applets/taskmanager/package/contents/ui/MouseHandler.qml bbe573e applets/taskmanager/package/contents/ui/Task.qml 49afaae Diff: https://git.reviewboard.kde.org/r/123290/diff/ Testing --- Works like old one. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On 04/09/2015 11:01 PM, Vishesh Handa wrote: KDE 4.9 - No errata KDE 4.10 - No errata KDE 4.11 - No errata https://community.kde.org/Plasma/5.0_Errata https://community.kde.org/Plasma/5.1_Errata https://community.kde.org/Plasma/5.2_Errata Just for the record, I'm not against highlighting missing features on the errata. I am, however, very against linking to bugs from 2010, which aren't solvable. Bugs that aren't solvable are excellent candidates for errata, though. An example is the DND artifacting on nVidia bug in Folder View I added to the 5.0 errata back then; this was solved by switching to new Qt API that only became available in Qt 5.4, and before that there was no good way to fix it. The errata were a good way to make people aware of this and let them know what to expect. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123046: Use own copy of org.kde.JobView.xml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123046/ --- (Updated April 9, 2015, 7:50 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson and Martin Klapetek. Changes --- Submitted with commit 636456b7736a798229e5e4e7e5eeb915118d1462 by David Rosca to branch master. Repository: plasma-workspace Description --- Use own copy of org.kde.JobView interface file to make it possible to extend the interface without breaking build (https://git.reviewboard.kde.org/r/122970/) This also fixes 2 cases where error/errorText would be incorrect in applicationsjob dataengine. Diffs - dataengines/applicationjobs/CMakeLists.txt e25ff0c dataengines/applicationjobs/jobaction.cpp f06977e kuiserver/CMakeLists.txt a4fc049 kuiserver/org.kde.JobView.xml PRE-CREATION kuiserver/progresslistmodel.cpp 11fccac Diff: https://git.reviewboard.kde.org/r/123046/diff/ Testing --- build works fine Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Moving User Manager back to playground
Hey guys It seems that 'user-manager' was moved into the kde/workspace subdirectory a couple of months ago, even though it was clearly blocked during the review process in kde-core-devel. I'm going to ask the system-admin request to move it back there. If you have any objections please let me know. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #21 from David Edmundson k...@davidedmundson.co.uk --- I have a theory. Console Kit sets a an environment variable which possibly isn't being transferred. Can you cat /proc/PIDofKSMServer/environment both with and without kwrapper5 and attach results -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-devel] Re: Default wallpaper
Ahhh, I see that makes sense. Thanks much, Andrew On Thu, Apr 9, 2015, 8:05 AM Marco Martin wrote: basically the idea is that in breeze there stays only one wallpaper, the default one, while the other ones, usually photos, go in plasma-workspace-wallpapers in svn so the git repo doesn't get too much clobbered in huge binaries (even with just the default one may become too big in the future tough) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5.3 beta tars
plasma-desktop updated to stop a bug where it could delete all the files in $HOME plasma-desktop;Plasma/5.3;d21f348766a0a42ffa284aaa2c4ecc8f500efdc1;plasma-desktop-5.2.95.tar.xz;748546306f3fad3d51e973e31cdf4904d8efccf865db697b474e175f2bc4dfff On 9 April 2015 at 15:52, Jonathan Riddell j...@jriddell.org wrote: beta tars for Plasma 5.3 are up on depot for packagers sha256 and git commits at http://starsky.19inch.net/~jr/tmp/5.2.95-release-data kinfocentre has had about-distro added so you'll need to remove that package if you use it. also worth checking it works for your distro as it's the new kinfocentre front page gone is -libbluedevil (replaced by bluez-qt) -libmm-qt (now in kf 5.9) all new is +bluez-qt - new bluedevil library +plasma-mediacenter - a tech preview of the kf5 port) +plasma-sdk - you may be familiar with plasmate which this includes although it's not currently compiled and again in beta +user-manager Lots of new wallpapers in plasma-workspace-wallpapers from the competition but that's still being sorted so I'll make that tar this evening. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 9, 2015 at 10:32 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Apr 09, 2015 at 10:30:34PM +0200, Vishesh Handa wrote: On Thu, Apr 9, 2015 at 10:01 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Apr 09, 2015 at 07:14:18PM +0200, Vishesh Handa wrote: A A Hi Johnathan A A Could you please tell me what is accomplished by creating this errata A A page? It means people can see what significant problems exist before they install.A It means people can see what bugs are known when they are reporting bugs.A It means people upgrading from Plasma 4 can see what features are missing.A It's a very normal part of release notes. Great. That makes sense. However, the page currently also lists bugs -A Bugs https://bugs.kde.org/342631 user-manager overlaps Account Details KCM http://bugs.kde.org/338506 image wallpapers are blurry in scaled and scaled and cropped mode https://bugs.kde.org/346018 The default wallpaper has pixelated lines https://bugs.kde.org/233471 Baloo abuses Disk access for excessive periods of time after startup https://bugs.kde.org/341581 baloo_file - using 100% cpu I'm confused as to why need to specifically duplicate these bugs when they are already present in the bug tracker. I agree that these bugs have a 'critical' flag set, but highlighting them doesn't help us in any way. I refer the honourable gentleman to the answer I gave some moments ago The answer above doesn't specifically answer what I would like to know - 1. The stated reason is so that people can see what bugs are known when they are reporting bugs. This is what we have bugzilla for. Plasma has over 100 bugs. 2. If, you think these bugs deserve mention because they are marked as critical - Is it our policy to be highlighting 'critical' bugs in the errata? Yes / No. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 09, 2015 at 10:43:00PM +0200, Vishesh Handa wrote: The answer above doesn't specifically answer what I would like to know - 1. The stated reason is so that people can see what bugs are known when they are reporting bugs. This is what we have bugzilla for. Plasma has over 100 bugs. It is to highlight the most important ones. 2. If, you think these bugs deserve mention because they are marked as critical - Is it our policy to be highlighting 'critical' bugs in the errata? Yes / No. That's the practice I'm following currently yes but I've asked the team to add other bugs they think are worth highlighting. Really this is normal practice. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
Hi Johnathan Could you please tell me what is accomplished by creating this errata page? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123303: include FindPackageHandleStandardArgs rather than find it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123303/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository: kde-gtk-config Description --- FindPackageHandleStandardArgs is a macro include not an actual finder, find_package actually will refuse to find it anyway, only reason this did not have adverse effects is supposedly because the GTK3 finder correctly includes it. it does however falsely report it as missing (what with it not being found by find_package) Diffs - cmake/modules/FindGTK2.cmake 75c2aba933c41f4bbfcb44eb2deaf424064de752 Diff: https://git.reviewboard.kde.org/r/123303/diff/ Testing --- clean cmake make with all deps installed Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.3 errata
On Thu, Apr 9, 2015 at 11:25 PM, Eike Hein h...@kde.org wrote: On 04/09/2015 11:01 PM, Vishesh Handa wrote: KDE 4.9 - No errata KDE 4.10 - No errata KDE 4.11 - No errata https://community.kde.org/Plasma/5.0_Errata https://community.kde.org/Plasma/5.1_Errata https://community.kde.org/Plasma/5.2_Errata I was under the impression we were *specially* doing this for Plasma 5 since the initial releases had some issues. Just for the record, I'm not against highlighting missing features on the errata. I am, however, very against linking to bugs from 2010, which aren't solvable. Bugs that aren't solvable are excellent candidates for errata, though. An example is the DND artifacting on nVidia bug in Folder View I added to the 5.0 errata back then; this was solved by switching to new Qt API that only became available in Qt 5.4, and before that there was no good way to fix it. The errata were a good way to make people aware of this and let them know what to expect. Okay. I'll update the list. My main gripe was that many of the current bugs shouldn't have been put there in the first place. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
