date:20150419

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

2015-04-19 Thread Martin Gräßlin

https://bugs.kde.org/show_bug.cgi?id=346369

Martin Gräßlin  changed:

   What|Removed |Added

 CC||mgraess...@kde.org

--- Comment #3 from Martin Gräßlin  ---
Having the password not-empty is (at least) in the screenlocker intended
behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123435: Fix vertical alignment of entry names in system tray configuration

2015-04-19 Thread Lasse Liehu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123435/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Summarized. Also see screenshots.


Diffs
-

  applets/systemtray/package/contents/ui/ConfigEntries.qml 61271da 

Diff: https://git.reviewboard.kde.org/r/123435/diff/


Testing
---

Yep.


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/20/0a6eea4d-2b06-4fc5-8fe2-d0dff385e47e__before.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/20/2e0fc3a9-7808-4d79-a81f-e0d449daa429__after.png


Thanks,

Lasse Liehu

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

2015-04-19 Thread David Edmundson

https://bugs.kde.org/show_bug.cgi?id=346369

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #2 from David Edmundson  ---
Marking as needsinfo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2015-04-19 Thread Armin K.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121086/
---

(Updated April 19, 2015, 7:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Runtime, KDE Frameworks and Plasma.


Repository: kio-extras


Description
---

Simply add 5 as a suffix to avoid conflicts with KDE 4 version which
is shipped in KDE-Runtime which isn't going away any time now.


Diffs
-

  thumbnail/CMakeLists.txt e9ab79b 
  thumbnail/jpegcreator.cpp de4902b 
  thumbnail/jpegcreatorsettings.kcfg 8f68f46 
  thumbnail/jpegcreatorsettings.kcfgc 3f6cdab 
  thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION 
  thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121086/diff/


Testing
---


Thanks,

Armin K.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

2015-04-19 Thread David Edmundson

https://bugs.kde.org/show_bug.cgi?id=346369

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #1 from David Edmundson  ---
Where? Lock screen? or Login Screen? or somewhere else?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 346369] New: the password feild is not set to empty after wrong password attempt

2015-04-19 Thread Santhosh

https://bugs.kde.org/show_bug.cgi?id=346369

Bug ID: 346369
   Summary: the password feild is not set to empty after wrong
password attempt
   Product: Breeze
   Version: 5.2.1
  Platform: Kubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: sj.santhoshj...@gmail.com

when a wrong password is entered ,it shows up an error as authentication
failed. but  it does not clear the password field for next attempt.

Reproducible: Always

Steps to Reproduce:
1.enter a wrong password while logging  in.
2.then u can see the authentication failure message.
3.but the password field is not cleard for another attempt

Actual Results:  
the password field is set to entered value (in selection)

Expected Results:  
the password field should be empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123416: Set i18n domain where it was missing

2015-04-19 Thread Lasse Liehu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123416/
---

(Updated April 19, 2015, 1:16 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit d7525011d356d573941ad3d54f110a2b23673868 by Lasse Liehu 
to branch Plasma/5.3.


Repository: kde-cli-tools


Description
---

Summarized.


Diffs
-

  kdesu/kdesu.cpp 483d805 
  kioclient/kioclient.cpp 196650b 
  kmimetypefinder/kmimetypefinder.cpp 6091f3d 
  kstart/kstart.cpp 8146774 
  ktraderclient/ktraderclient.cpp a01fedb 

Diff: https://git.reviewboard.kde.org/r/123416/diff/


Testing
---

Yep. All of them look translated now.


Thanks,

Lasse Liehu

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-workspace_master_qt5 #1474

2015-04-19 Thread KDE CI System

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

2015-04-19 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123426/#review79200
---


OK, thanks for the explanation. Will merge.

- David Edmundson


On April 19, 2015, 9:52 a.m., Konrad Materka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123426/
> ---
> 
> (Updated April 19, 2015, 9:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346002
> None
> 
> 
> Description
> ---
> 
> Fixed version of /r/123350/
> 
> Why VisualDelegateModel? It may be workaround/hack/you name it but it was the 
> only way I found acceptable. You need to pass QModelIndex to openItem and I 
> don't know how to get it using plain ListView and SystemModel. 
> VisualDelegateModel has a convenience method modelIndex which is already used 
> in KickoffItem.qml (but only if ApplicationsView tab is active). I changed 
> BaseView to use VisualDelegateModel to have modelIndex method and to be more 
> consistent with ApplicaitonView. 
> 
> "this change seems uneeded; we're using modelIndex fine in the old code, see 
> line 40 in KickoffItem.qml  in the old code.
> (unless maybe that didn't work ?)
> My understanding is setting the model to a QAIM, internally just creates a 
> VDM anyway."
> 
> It didn't work. modelIndex is used only if flag hasModelChildren is set to 
> true. That can happen only for ApplicationView, as only there children exist. 
> Also ApplicationView uses VisualDataModel explicitly, so method modelIndex is 
> available.
> In SystemView model is set directly, VisualDataModel is not created 
> implicitly (or even if it is it is not accessible). In other words 
> listItem.ListView.view.model returns SystemModel object which is 
> QAbstractProxyModel/QAbstractItemModel implementation. SystemModel does not 
> have any slot that would be usefull in this case.
> Passing "model" variable is not an option. It would be a good idea as it 
> contains all data related to current item but this is internal QML/Qt Quick 
> class.
> 
> In KDE 4 it was not a problem as it was easy to get QModelIndex from event 
> (lines 860 - 878):
> https://projects.kde.org/projects/kde/kde-workspace/repository/entry/plasma/desktop/applets/kickoff/ui/launcher.cpp?rev=KDE%2F4.9
> 
> 
> Diffs
> -
> 
> 
> Diff: https://git.reviewboard.kde.org/r/123426/diff/
> 
> 
> Testing
> ---
> 
> I was able to reproduce bug using latest GIT code.
> Screenshots, first shows not mounted removable device, second is error 
> message (in Polish):
> https://www.dropbox.com/s/8vcokx17kmn3onw/zrzut%20ekranu1.png?dl=0&s=sl
> https://www.dropbox.com/s/sqkci1z1fhb3h3p/zrzut%20ekranu2.png?dl=0&s=sl
> 
> In console I can find this message:
> Opening item with URL ""
> 
> It looks that KFilePlacesModel->url(index) returns empty string for not 
> mounted devices. I have 5.9.0 version of libkf5kiocore5 installed.
> 
> Patch fixed mounting. I also tested all tabs, all items works as expected.
> 
> 
> File Attachments
> 
> 
> Use VisualDataModel->modelIndex in openItem
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch
> 
> 
> Thanks,
> 
> Konrad Materka
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

2015-04-19 Thread Konrad Materka

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123426/
---

Review request for Plasma.

Bugs: 346002
None

Description
---

Fixed version of /r/123350

Why VisualDelegateModel? It may be workaround/hack/you name it but it was the
only way I found acceptable. You need to pass QModelIndex to openItem and I
don't know how to get it using plain ListView and SystemModel.
VisualDelegateModel has a convenience method modelIndex which is already used
in KickoffItem.qml (but only if ApplicationsView tab is active). I changed
BaseView to use VisualDelegateModel to have modelIndex method and to be more
consistent with ApplicaitonView.

"this change seems uneeded; we're using modelIndex fine in the old code, see
line 40 in KickoffItem.qml in the old code.
(unless maybe that didn't work ?)
My understanding is setting the model to a QAIM, internally just creates a VDM
anyway."

It didn't work. modelIndex is used only if flag hasModelChildren is set to
true. That can happen only for ApplicationView, as only there children exist.
Also ApplicationView uses VisualDataModel explicitly, so method modelIndex is
available.
In SystemView model is set directly, VisualDataModel is not created implicitly
(or even if it is it is not accessible). In other words
listItem.ListView.view.model returns SystemModel object which is
QAbstractProxyModel/QAbstractItemModel implementation. SystemModel does not
have any slot that would be usefull in this case.
Passing "model" variable is not an option. It would be a good idea as it
contains all data related to current item but this is internal QML/Qt Quick
class.

In KDE 4 it was not a problem as it was easy to get QModelIndex from event
(lines 860 - 878):
https://projects.kde.org/projects/kde/kde-workspace/repository/entry/plasma/desktop/applets/kickoff/ui/launcher.cpp?rev=KDE%2F4.9

Diffs
-

Diff: https://git.reviewboard.kde.org/r/123426/diff/

Testing
---

I was able to reproduce bug using latest GIT code.
Screenshots, first shows not mounted removable device, second is error message
(in Polish):
https://www.dropbox.com/s/8vcokx17kmn3onw/zrzut%20ekranu1.png?dl=0&s=sl
https://www.dropbox.com/s/sqkci1z1fhb3h3p/zrzut%20ekranu2.png?dl=0&s=sl

In console I can find this message:
Opening item with URL ""

It looks that KFilePlacesModel->url(index) returns empty string for not mounted
devices. I have 5.9.0 version of libkf5kiocore5 installed.

Patch fixed mounting. I also tested all tabs, all items works as expected.

File Attachments

Use VisualDataModel->modelIndex in openItem

https://git.reviewboard.kde.org/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch

Thanks,

Konrad Materka

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

2015-04-19 Thread Konrad Materka

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123426/
---

(Updated Kwi 19, 2015, 9:52 rano)

Review request for Plasma.

Bugs: 346002
None

Description (updated)
---

Fixed version of /r/123350/

Diffs
-

Diff: https://git.reviewboard.kde.org/r/123426/diff/

Testing
---

In console I can find this message:
Opening item with URL ""

It looks that KFilePlacesModel->url(index) returns empty string for not mounted
devices. I have 5.9.0 version of libkf5kiocore5 installed.

Patch fixed mounting. I also tested all tabs, all items works as expected.

File Attachments

Use VisualDataModel->modelIndex in openItem

https://git.reviewboard.kde.org/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch

Thanks,

Konrad Materka

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123416: Set i18n domain where it was missing

2015-04-19 Thread Lukáš Tinkl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123416/#review79195
---

Ship it!


Ship It!

- Lukáš Tinkl


On Dub. 18, 2015, 6:29 odp., Lasse Liehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123416/
> ---
> 
> (Updated Dub. 18, 2015, 6:29 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> Summarized.
> 
> 
> Diffs
> -
> 
>   kdesu/kdesu.cpp 483d805 
>   kioclient/kioclient.cpp 196650b 
>   kmimetypefinder/kmimetypefinder.cpp 6091f3d 
>   kstart/kstart.cpp 8146774 
>   ktraderclient/ktraderclient.cpp a01fedb 
> 
> Diff: https://git.reviewboard.kde.org/r/123416/diff/
> 
> 
> Testing
> ---
> 
> Yep. All of them look translated now.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

Review Request 123435: Fix vertical alignment of entry names in system tray configuration

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

[Breeze] [Bug 346369] New: the password feild is not set to empty after wrong password attempt

Re: Review Request 123416: Set i18n domain where it was missing

Jenkins build is back to normal : plasma-workspace_master_qt5 #1474

Re: Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

Re: Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

Re: Review Request 123416: Set i18n domain where it was missing

12 matches

Site Navigation

Mail list logo

Footer information