Re: Review Request 123556: KPackage::findPackages with a filter callback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 10:51 a.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- Add a KPackage::findPackages function similar to KPluginLoader::findPlugins Diffs (updated) - src/kpackage/packageloader.h 2761d98 src/kpackage/packageloader.cpp 00defbd Diff: https://git.reviewboard.kde.org/r/123556/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123556: KPackage::findPackages with a filter callback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- Add a KPackage::findPackages function similar to KPluginLoader::findPlugins Diffs - src/kpackage/packageloader.h 2761d98 src/kpackage/packageloader.cpp 00defbd Diff: https://git.reviewboard.kde.org/r/123556/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspace Description --- Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty. Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash. The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case) IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?! Diffs - dataengines/powermanagement/powermanagementengine.cpp 2fbf23f Diff: https://git.reviewboard.kde.org/r/123555/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On April 29, 2015, 1:48 a.m., Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Martin Gräßlin wrote: Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. Yoann Laissus wrote: @Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? Middle click normaly pastes the content of the copy buffer (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On April 28, 2015, 10:45 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated April 28, 2015, 10:45 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On avr. 28, 2015, 11:48 après-midi, Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Martin Gräßlin wrote: Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. @Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On avr. 28, 2015, 8:45 après-midi, Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated avr. 28, 2015, 8:45 après-midi) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On avr. 28, 2015, 9:47 après-midi, David Edmundson wrote: applets/taskmanager/package/contents/ui/Task.qml, line 108 https://git.reviewboard.kde.org/r/123547/diff/1/?file=364298#file364298line108 now shift + right click will also start a new instance, that's probably unintended? The right click was inhibitted in the press event (pressed != true) as it doesn't need a release event to be triggered. But I could add a check in release just to be safe. - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79647 --- On avr. 28, 2015, 8:45 après-midi, Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated avr. 28, 2015, 8:45 après-midi) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On April 29, 2015, 1:48 a.m., Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On April 28, 2015, 10:45 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated April 28, 2015, 10:45 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/#review79666 --- Ship it! Nice one! Please commit to Plasma/5.3 and then merge into master. - Kai Uwe Broulik On April 29, 2015, 10:40 vorm., Emmanuel Pescosta wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- (Updated April 29, 2015, 10:40 vorm.) Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspace Description --- Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty. Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash. The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case) IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?! Diffs - dataengines/powermanagement/powermanagementengine.cpp 2fbf23f Diff: https://git.reviewboard.kde.org/r/123555/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: 5.4 kickoff meeting
On Wednesday 29 April 2015 13:22:47 David Edmundson wrote: I have some things I want to add to the agenda - dividing up the most major bugs in 5.3.0 between us for priority fixing I can create that list. - we have one recurring piece of feedback about different wallpaperes on different virtual desktops. We should discuss it a bit. speaking of recurring piece of feedback: xembed systray. Over the last 12 months the most often clicked blog post was: * Where are my systray icons? (12,702 views) followed by: * System Tray in Plasma Next (10,879 views) The next blog post has just half of the number of views. From what I see the main issues are: * skype being 32 bit, so one needs to manually install sni-qt:i386 (yes distros could help here, but in practice they don't) * dropbox statically linking Qt * wine having weird own stuff * Java having weird own stuff * 3rd party extensions for applications (e.g. Firefox/Thunderbird) So it's unfortunately also a candidate to discuss :-( Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/#review79675 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 29, 2015, 12:40 odp., Emmanuel Pescosta wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- (Updated Dub. 29, 2015, 12:40 odp.) Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspace Description --- Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty. Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash. The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case) IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?! Diffs - dataengines/powermanagement/powermanagementengine.cpp 2fbf23f Diff: https://git.reviewboard.kde.org/r/123555/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On April 28, 2015, 11:48 p.m., Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Martin Gräßlin wrote: Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. Yoann Laissus wrote: @Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? Martin Gräßlin wrote: Middle click normaly pastes the content of the copy buffer (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded. Sebastian Kügler wrote: That sounds like a really neat thing. Hidden, but really neat. :) Pass URL in clipboard as argument could be an optional add-on behavior to Start new instance which would get that Firefox thing going. Bit concerned with an option jungle though and I fear it's too unpredictable and too likely to lead to bad results to make a default ... - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On April 28, 2015, 8:45 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated April 28, 2015, 8:45 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.4 kickoff meeting
I started an agenda doc, edits welcome https://notes.kde.org/p/plasma-5.4 Jonthan On Wed, Apr 29, 2015 at 01:22:47PM +0200, David Edmundson wrote: I have some things I want to add to the agenda A - dividing up the most major bugs in 5.3.0 between us for priority fixing I can create that list. A - we have one recurring piece of feedback about different wallpaperes on different virtual desktops. We should discuss it a bit. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.4 kickoff meeting
I have some things I want to add to the agenda - dividing up the most major bugs in 5.3.0 between us for priority fixing I can create that list. - we have one recurring piece of feedback about different wallpaperes on different virtual desktops. We should discuss it a bit. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123556: KPackage::findPackages with a filter callback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 12:12 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit bdae2dcaccbb16dede01bd44ab17e9bd2d42c998 by Marco Martin to branch master. Repository: kpackage Description --- Add a KPackage::findPackages function similar to KPluginLoader::findPlugins Diffs - src/kpackage/packageloader.h 2761d98 src/kpackage/packageloader.cpp 00defbd Diff: https://git.reviewboard.kde.org/r/123556/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123557: FindQalculate: Use FindPkgConfig instead of UsePkgConfig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123557/ --- Review request for Plasma. Repository: plasma-workspace Description --- The latter is deprecated and doesn't respect the PKG_CONFIG environment variable which makes it easy to deal with differently named pkg-config executables, e.g. arch-prefixed ones. Diffs - cmake/FindQalculate.cmake 707a9f7c96b16daf18c1b75400eb8ac4dd30da2c Diff: https://git.reviewboard.kde.org/r/123557/diff/ Testing --- Configured, built and checked that plasma-workspace links to qualculate and cln. Thanks, Heiko Becker ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On April 28, 2015, 11:48 p.m., Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Martin Gräßlin wrote: Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. Yoann Laissus wrote: @Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? Martin Gräßlin wrote: Middle click normaly pastes the content of the copy buffer (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded. That sounds like a really neat thing. Hidden, but really neat. :) - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On April 28, 2015, 8:45 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated April 28, 2015, 8:45 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123556: KPackage::findPackages with a filter callback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79667 --- Ship it! Ship It! src/kpackage/packageloader.h (line 59) https://git.reviewboard.kde.org/r/123556/#comment54489 api docs, including @since - Sebastian Kügler On April 29, 2015, 10:51 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 10:51 a.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- Add a KPackage::findPackages function similar to KPluginLoader::findPlugins Diffs - src/kpackage/packageloader.h 2761d98 src/kpackage/packageloader.cpp 00defbd Diff: https://git.reviewboard.kde.org/r/123556/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module - inclusion in Plasma?
2015-04-29 18:21 GMT+02:00 Ragnar Thomsen rthoms...@gmail.com: On Wed, Apr 29, 2015 at 4:10 PM, Martin Gräßlin mgraess...@kde.org wrote: Just run kdesrc-build and gave it a try and was greeted with an error message: http://paste.opensuse.org/54725251 That's on a Debian stable/testing system and the file does not exist. As that file is missing on that distribution an error message is wrong ;-) Otherwise I would also suggest to not use an in-your-face dialog but rather a KMessageWidget. Thanks for the feedback, Martin. I agree with you about the error message and will change this to a KMessageWidget. FYI, we patch this out of systemd-kcm in Debian at time, since coredumps aren't (yet?) handled by our systemd. So maybe instead of displaying an error, just hide the page for coredumpctl? (Making a check for Debian is also not a good idea, since we might enable coredumpctl and coredumps-in-journal support at one time in the future) Cheers, Matthias -- Debian Developer | Freedesktop-Developer I welcome VSRE emails. See http://vsre.info/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module - inclusion in Plasma?
On Wed, Apr 29, 2015 at 4:10 PM, Martin Gräßlin mgraess...@kde.org wrote: Just run kdesrc-build and gave it a try and was greeted with an error message: http://paste.opensuse.org/54725251 That's on a Debian stable/testing system and the file does not exist. As that file is missing on that distribution an error message is wrong ;-) Otherwise I would also suggest to not use an in-your-face dialog but rather a KMessageWidget. Thanks for the feedback, Martin. I agree with you about the error message and will change this to a KMessageWidget. What do you think about including systemd-kcm in Plasma? Regards, Ragnar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On avr. 28, 2015, 11:48 après-midi, Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Martin Gräßlin wrote: Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. Yoann Laissus wrote: @Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? Martin Gräßlin wrote: Middle click normaly pastes the content of the copy buffer (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded. Sebastian Kügler wrote: That sounds like a really neat thing. Hidden, but really neat. :) Eike Hein wrote: Pass URL in clipboard as argument could be an optional add-on behavior to Start new instance which would get that Firefox thing going. Bit concerned with an option jungle though and I fear it's too unpredictable and too likely to lead to bad results to make a default ... I think it's a very nice idea too. But as you said, Eike, it will depend a lot of the app and the copied content. So having that as an option makes sense. To sum up, we will have three choices for the mid button combo box : - Close app - Open new instance - Open new instance with clipboard content as argument For the default one, I think it's better to have Open new instance. Close apps can be dangerous if users don't know the behaviour. Are you ok with that ? - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On avr. 28, 2015, 8:45 après-midi, Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated avr. 28, 2015, 8:45 après-midi) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123544: kioclient ls: properly construct QUrl.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79694 --- Ship it! Ship It! - David Faure On April 28, 2015, 6:18 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- (Updated April 28, 2015, 6:18 p.m.) Review request for Plasma and David Faure. Repository: kde-cli-tools Description --- The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like kioclient ls ~ to work again. Again because it worked in the kdelibs version thus this was a regression. Diffs - kioclient/kioclient.cpp 74c9985 Diff: https://git.reviewboard.kde.org/r/123544/diff/ Testing --- kioclient ls path works. No need to prefix the path with file:// anymore. Thanks, Mark Gaiser ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123556: KPackage::findPackages with a filter callback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79698 --- src/kpackage/packageloader.cpp (line 273) https://git.reviewboard.kde.org/r/123556/#comment54542 This will crash if there is no filter. `if (!filter || filter(plugin))` should work. - Alex Richardson On April 29, 2015, 1:12 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 1:12 p.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- Add a KPackage::findPackages function similar to KPluginLoader::findPlugins Diffs - src/kpackage/packageloader.h 2761d98 src/kpackage/packageloader.cpp 00defbd Diff: https://git.reviewboard.kde.org/r/123556/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123544: kioclient ls: properly construct QUrl.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79701 --- Pushed. But slightly different then was reviewed here. I added the define which subsequently gave me two more issues of the same nature in kioclient (cat and openProperties). I've fixed those as well and changed the commit message accordingly. Yes, i did test them before pushing and they seem to work just fine now. http://quickgit.kde.org/?p=kde-cli-tools.gita=commith=787bdf628fdf9f74c978363e07ddad0ae306d8bf - Mark Gaiser On apr 29, 2015, 10:56 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- (Updated apr 29, 2015, 10:56 p.m.) Review request for Plasma and David Faure. Repository: kde-cli-tools Description --- The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like kioclient ls ~ to work again. Again because it worked in the kdelibs version thus this was a regression. Diffs - kioclient/kioclient.cpp 74c9985 Diff: https://git.reviewboard.kde.org/r/123544/diff/ Testing --- kioclient ls path works. No need to prefix the path with file:// anymore. Thanks, Mark Gaiser ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
On April 28, 2015, 11:48 p.m., Eike Hein wrote: People frequently request either new instance or close window for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. Martin Gräßlin wrote: Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. Yoann Laissus wrote: @Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? Martin Gräßlin wrote: Middle click normaly pastes the content of the copy buffer (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded. Sebastian Kügler wrote: That sounds like a really neat thing. Hidden, but really neat. :) Eike Hein wrote: Pass URL in clipboard as argument could be an optional add-on behavior to Start new instance which would get that Firefox thing going. Bit concerned with an option jungle though and I fear it's too unpredictable and too likely to lead to bad results to make a default ... Yoann Laissus wrote: I think it's a very nice idea too. But as you said, Eike, it will depend a lot of the app and the copied content. So having that as an option makes sense. To sum up, we will have three choices for the mid button combo box : - Close app - Open new instance - Open new instance with clipboard content as argument For the default one, I think it's better to have Open new instance. Close apps can be dangerous if users don't know the behaviour. Are you ok with that ? Let's keep it simple for now and do: On middle-click: Do nothing (Default) / Close Window / Start New Instance Let's hold back the clipboard thing for now and perhaps try to do it in a second patch. It needs some fairly careful thought and implementation, e.g. parsing %u and %U in .desktop files (where windows can be mapped to them) to figure out what to with single vs. multiple URLs in the clipboard and possibly other MIME-related considerations. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- On April 28, 2015, 8:45 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated April 28, 2015, 8:45 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both. Diffs - applets/taskmanager/package/contents/ui/Task.qml f5fc723 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123544: kioclient ls: properly construct QUrl.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- (Updated April 29, 2015, 10:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and David Faure. Changes --- Submitted with commit 787bdf628fdf9f74c978363e07ddad0ae306d8bf by Mark Gaiser to branch master. Repository: kde-cli-tools Description --- The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like kioclient ls ~ to work again. Again because it worked in the kdelibs version thus this was a regression. Diffs - kioclient/kioclient.cpp 74c9985 Diff: https://git.reviewboard.kde.org/r/123544/diff/ Testing --- kioclient ls path works. No need to prefix the path with file:// anymore. Thanks, Mark Gaiser ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123544: kioclient ls: properly construct QUrl.
On April 30, 2015, 1:02 a.m., Mark Gaiser wrote: Pushed. But slightly different then was reviewed here. I added the define which subsequently gave me two more issues of the same nature in kioclient (cat and openProperties). I've fixed those as well and changed the commit message accordingly. Yes, i did test them before pushing and they seem to work just fine now. http://quickgit.kde.org/?p=kde-cli-tools.gita=commith=787bdf628fdf9f74c978363e07ddad0ae306d8bf Wonderful. Thanks! - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79701 --- On April 30, 2015, 12:56 a.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- (Updated April 30, 2015, 12:56 a.m.) Review request for Plasma and David Faure. Repository: kde-cli-tools Description --- The ls command was using direct user input as QUrl. That in turn caused the QUrl to be constructed without a scheme. Constructing it via makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows for example a command like kioclient ls ~ to work again. Again because it worked in the kdelibs version thus this was a regression. Diffs - kioclient/kioclient.cpp 74c9985 Diff: https://git.reviewboard.kde.org/r/123544/diff/ Testing --- kioclient ls path works. No need to prefix the path with file:// anymore. Thanks, Mark Gaiser ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Systemd kcm module - inclusion in Plasma?
Hey all, The systemd kcm module is now setup at: http://quickgit.kde.org/?p=systemd-kcm.git I hope some of you have found time to try it out and would like to hear your opinions on whether this is suitable for inclusion in Plasma (maybe in time for 5.4). If yes, can it be included in its current form or some modifications need to be done? Regards, Ragnar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module - inclusion in Plasma?
On Wed, Apr 29, 2015 at 3:45 PM, Aleix Pol aleix...@kde.org wrote: Some people mentioned that you might want to look into integrating it in the current solutions, on the last thread. Did you have the opportunity? Hey Aleix, I think you are confusing the systemd kcm module (systemd-kcm) with the systemd journal viewer (journalktl). Regards, Ragnar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module - inclusion in Plasma?
On Wed, Apr 29, 2015 at 3:22 PM, Ragnar Thomsen rthoms...@gmail.com wrote: Hey all, The systemd kcm module is now setup at: http://quickgit.kde.org/?p=systemd-kcm.git I hope some of you have found time to try it out and would like to hear your opinions on whether this is suitable for inclusion in Plasma (maybe in time for 5.4). If yes, can it be included in its current form or some modifications need to be done? Some people mentioned that you might want to look into integrating it in the current solutions, on the last thread. Did you have the opportunity? Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module - inclusion in Plasma?
On Wednesday 29 April 2015 15:22:56 Ragnar Thomsen wrote: Hey all, The systemd kcm module is now setup at: http://quickgit.kde.org/?p=systemd-kcm.git I hope some of you have found time to try it out and would like to hear your opinions on whether this is suitable for inclusion in Plasma (maybe in time for 5.4). If yes, can it be included in its current form or some modifications need to be done? Just run kdesrc-build and gave it a try and was greeted with an error message: http://paste.opensuse.org/54725251 That's on a Debian stable/testing system and the file does not exist. As that file is missing on that distribution an error message is wrong ;-) Otherwise I would also suggest to not use an in-your-face dialog but rather a KMessageWidget. Cheers, Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- (Updated April 29, 2015, 1:24 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Kai Uwe Broulik. Changes --- Submitted with commit 08cbba07eb8927ce3a0f864eda8dfe1f8f1a6e44 by Emmanuel Pescosta to branch Plasma/5.3. Repository: plasma-workspace Description --- Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty. Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash. The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case) IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?! Diffs - dataengines/powermanagement/powermanagementengine.cpp 2fbf23f Diff: https://git.reviewboard.kde.org/r/123555/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemd kcm module - inclusion in Plasma?
On Wed, Apr 29, 2015 at 6:43 PM, Matthias Klumpp matth...@tenstral.net wrote: FYI, we patch this out of systemd-kcm in Debian at time, since coredumps aren't (yet?) handled by our systemd. So maybe instead of displaying an error, just hide the page for coredumpctl? (Making a check for Debian is also not a good idea, since we might enable coredumpctl and coredumps-in-journal support at one time in the future) Current master now uses KMessageWidget to warn for missing conf files. I also disabled configuration of coredump.conf if the file is not found. Regards, Ragnar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
