Re: Review Request 123808: Add FindEvdev cmake module BUG:347749
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123808/ --- (Updated May 17, 2015, 4:10 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson and Harald Sitter. Changes --- Submitted with commit ec5bb558cabc3726ccd082b6675fc997af9c9f4e by Yue Liu to branch master. Bugs: 347749 https://bugs.kde.org/show_bug.cgi?id=347749 Repository: plasma-desktop Description --- Add FindEvdev cmake module BUG:347749 Diffs - kcms/input/mouse.cpp 6eb9915da11729f197deadfd5220694f18be96bf kcms/input/CMakeLists.txt 25320bd5e35cb8c49ed3cc98251cc922a2a2801e kcms/CMakeLists.txt fee138093fde9788212e83a17b4c07679c596b59 cmake/modules/FindEvdev.cmake PRE-CREATION CMakeLists.txt 9d715b426678a9002836c0fb99521bf7643cc1bd Diff: https://git.reviewboard.kde.org/r/123808/diff/ Testing --- built and works on x86_64 archlinux Thanks, Yue Liu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123738: Use column major in the taskbar when Force row settings is set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80550 --- Aside from the string issue I think this is fine now. Technically the string won't really work for vertical panels, but as you pointed out the force code is currently not working for vertical anyway (which is a regression). I'll fix this and address making the config UI adapt to plasmoid location after this gets in. applets/taskmanager/package/contents/ui/ConfigGeneral.qml (line 66) https://git.reviewboard.kde.org/r/123738/#comment55225 This will literally show Always arrange tasks in columns of x rows when maxStripes.value is 1. I don't think i18np will really work for us here, could you go with the string I suggested? - Eike Hein On May 17, 2015, 8:01 p.m., Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated May 17, 2015, 8:01 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- When we have Force row settings and more than one row of items, the items start to jump around and it is had to keep track of where each item is. The atached patch changes the flow to TopToBottom, in stead of LeftToRight, when we have a horizontal layout and Force row settings, and similarly to LeftToRight in vertical layout. (In practice the vertical layout is always one column and this patch has no effect) Here are two videos that describe the problem First is the row major where taskbar items jump around: https://youtu.be/8udr2DJKobw And the second with a patched taskbar where the items jump around a lot less: https://youtu.be/bk17gnu1ETo Diffs - applets/taskmanager/package/contents/ui/ConfigGeneral.qml 36dd134 applets/taskmanager/package/contents/ui/main.qml 98ba7c3 Diff: https://git.reviewboard.kde.org/r/123738/diff/ Testing --- I have applied this patch to the system installed plasma 5.3 installation. Thanks, Kåre Särs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma
https://bugs.kde.org/show_bug.cgi?id=347532 --- Comment #3 from suscavalen...@gmail.com --- im running plasma 5 and os kubuntu 15.04 and at set the wallpaper dektop show a message url cannot be listed and not allow set the wallpaper on desktop only the system' wallpaper help me please -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated mai 17, 2015, 9:42 matin) Review request for Plasma. Changes --- Enable the datasource timer only when the plasmoid is visible. Repository: plasma-workspace Description --- Previously, it was set to 0 so the space indicator was never refreshed. Diffs (updated) - applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 Diff: https://git.reviewboard.kde.org/r/123817/diff/ Testing --- Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80511 --- Ship it! Ship It! - Kai Uwe Broulik On Mai 17, 2015, 9:42 vorm., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated Mai 17, 2015, 9:42 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- Previously, it was set to 0 so the space indicator was never refreshed. Diffs - applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 Diff: https://git.reviewboard.kde.org/r/123817/diff/ Testing --- Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123814: Use KMessageWidget for polkit error
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123814/ --- (Updated May 17, 2015, 11:37 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 9edb5e8041db3080cbebee363a29f699b0a20e3d by Kai Uwe Broulik to branch master. Repository: polkit-kde-agent-1 Description --- The new style for KTitleWidget makes the message get huge. Make it a KMessageWidget, that's also a bit more prominent with its red color. Diffs - AuthDialog.ui 20ed6d3 AuthDialog.cpp 16ee64d Diff: https://git.reviewboard.kde.org/r/123814/diff/ Testing --- No widget, enter wrong password, get a widget. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e68c1609-ea84-4c57-8ecc-6d70ca8bdf0a__errorwidgetbefore.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/4cf63a1d-f4df-4d02-9cee-dc16fbfbb845__errorwidgetafter.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.
On mai 16, 2015, 10:33 après-midi, Kai Uwe Broulik wrote: I think it should be refreshed whenever you hover a device, not every 5 seconds needlessly consuming resources when you don't look at it. You're right. The refresh is now triggered only when the device notifier is visible. - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80492 --- On mai 17, 2015, 9:42 matin, Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated mai 17, 2015, 9:42 matin) Review request for Plasma. Repository: plasma-workspace Description --- Previously, it was set to 0 so the space indicator was never refreshed. Diffs - applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 Diff: https://git.reviewboard.kde.org/r/123817/diff/ Testing --- Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated May 17, 2015, 11:01 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 44f957af3ef3d786012a70167e5cd170df0d5440 by Yoann Laissus to branch master. Repository: plasma-workspace Description --- Previously, it was set to 0 so the space indicator was never refreshed. Diffs - applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 Diff: https://git.reviewboard.kde.org/r/123817/diff/ Testing --- Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123808: Add FindEvdev cmake module BUG:347749
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123808/#review80513 --- Ship it! Ship It! - David Edmundson On May 16, 2015, 7:07 a.m., Yue Liu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123808/ --- (Updated May 16, 2015, 7:07 a.m.) Review request for Plasma, David Edmundson and Harald Sitter. Bugs: 347749 https://bugs.kde.org/show_bug.cgi?id=347749 Repository: plasma-desktop Description --- Add FindEvdev cmake module BUG:347749 Diffs - kcms/input/mouse.cpp 6eb9915da11729f197deadfd5220694f18be96bf kcms/input/CMakeLists.txt 25320bd5e35cb8c49ed3cc98251cc922a2a2801e kcms/CMakeLists.txt fee138093fde9788212e83a17b4c07679c596b59 cmake/modules/FindEvdev.cmake PRE-CREATION CMakeLists.txt 9d715b426678a9002836c0fb99521bf7643cc1bd Diff: https://git.reviewboard.kde.org/r/123808/diff/ Testing --- built and works on x86_64 archlinux Thanks, Yue Liu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123807: Fix popup menu items getting stray highlighted
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/#review80517 --- +1 - David Edmundson On May 15, 2015, 10:39 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/ --- (Updated May 15, 2015, 10:39 p.m.) Review request for Plasma, David Edmundson and Hugo Pereira Da Costa. Bugs: 332377 https://bugs.kde.org/show_bug.cgi?id=332377 Repository: oxygen Description --- Make sure we finish the animation before stopping it. Diffs - kstyle/animations/oxygenmenubardata_imp.h fcfe788 Diff: https://git.reviewboard.kde.org/r/123807/diff/ Testing --- Moved the mouse like crazy over the Help menu of konsole and can't get it to be wrong anymore. Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/#review80514 --- Ship it! Nice work, thanks. - David Edmundson On May 16, 2015, 5:13 p.m., Yoann Laissus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/ --- (Updated May 16, 2015, 5:13 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The panel configuration width is defined to a fixed value when it's vertical. In English, it's not a problem because strings are very compacts. But for example, in French, some strings get too big for the buttons. The width is now computed dynamically from the button layout. I'm really not a QML expert, please let me know if there is a better way to achieve that. Diffs - desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd Diff: https://git.reviewboard.kde.org/r/123815/diff/ Testing --- Tested in all screen edges. File Attachments Truncated text https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg After the fix https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123688: Improve sddm login experience
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/#review80518 --- Ship it! Would be nice to make sure the lock screen behaviour matches - David Edmundson On May 9, 2015, 12:46 p.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/ --- (Updated May 9, 2015, 12:46 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Disables the button and the passwordfield while the password check is running and hides the Login Failed message after 3 seconds. Diffs - lookandfeel/contents/loginmanager/Main.qml 528f9b4e43ee6b8636ca1c816d5bad556bede871 Diff: https://git.reviewboard.kde.org/r/123688/diff/ Testing --- Login and failed login are working as expected. Tested in qmlscene and on two computers running Archlinux. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123821: Highlight leading and trailing whitespace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/#review80530 --- Ship it! Would be nice to get the same for the good old popup (can be opened by e.g. global shortcut). Though I don't know whether that's possible as it's a QMenu. - Martin Gräßlin On May 16, 2015, 8:54 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/ --- (Updated May 16, 2015, 8:54 p.m.) Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick Eigensatz. Bugs: 159267 https://bugs.kde.org/show_bug.cgi?id=159267 Repository: plasma-workspace Description --- This patch makes klipper highlight leading and trailing white-space (line break, spaces, tabs) by coloring them and replacing them with visible characters (Using the open box, double arrow and down-left arrow that look more familiar (though I recall word processors using a mid dot for space) instead of the unicode SP/HT/CR thingies) Diffs - applets/clipboard/contents/ui/ClipboardItemDelegate.qml f9b0d59 Diff: https://git.reviewboard.kde.org/r/123821/diff/ Testing --- Seems to work pretty well, copied random console output File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e31d060b-ab13-4f37-9ba3-26cb743ddee4__klippercolorcoded.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123821: Highlight leading and trailing whitespace
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/ --- (Updated May 17, 2015, 6:18 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick Eigensatz. Changes --- Submitted with commit 4fdfcded48f222a2aa1f8032142d8191f0624f5e by Kai Uwe Broulik to branch master. Bugs: 159267 https://bugs.kde.org/show_bug.cgi?id=159267 Repository: plasma-workspace Description --- This patch makes klipper highlight leading and trailing white-space (line break, spaces, tabs) by coloring them and replacing them with visible characters (Using the open box, double arrow and down-left arrow that look more familiar (though I recall word processors using a mid dot for space) instead of the unicode SP/HT/CR thingies) Diffs - applets/clipboard/contents/ui/ClipboardItemDelegate.qml f9b0d59 Diff: https://git.reviewboard.kde.org/r/123821/diff/ Testing --- Seems to work pretty well, copied random console output File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e31d060b-ab13-4f37-9ba3-26cb743ddee4__klippercolorcoded.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123688: Improve sddm login experience
On May 17, 2015, 1:39 p.m., David Edmundson wrote: Would be nice to make sure the lock screen behaviour matches Yes, that's on my todo list, but it will need some time because I have to lern the ksmserver stuff. The only difference besides multiscreen behavior is the moment when the wrong password gets selected, or do I miss a difference? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/#review80518 --- On May 9, 2015, 2:46 p.m., David Kahles wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/ --- (Updated May 9, 2015, 2:46 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Disables the button and the passwordfield while the password check is running and hides the Login Failed message after 3 seconds. Diffs - lookandfeel/contents/loginmanager/Main.qml 528f9b4e43ee6b8636ca1c816d5bad556bede871 Diff: https://git.reviewboard.kde.org/r/123688/diff/ Testing --- Login and failed login are working as expected. Tested in qmlscene and on two computers running Archlinux. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123738: Use column major in the taskbar when Force row settings is set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 17, 2015, 8:01 e.m.) Review request for Plasma and Eike Hein. Changes --- Update the if-statement, rearrange the configure options as requested and apply similar indentation/option-disabling to Grouping and sorting Note: This patch is tested against the system installed plasma 5.3 instalation. It should work with master also but I have not been able to test that as I don't have the build environment up and running (yet). Repository: plasma-desktop Description --- When we have Force row settings and more than one row of items, the items start to jump around and it is had to keep track of where each item is. The atached patch changes the flow to TopToBottom, in stead of LeftToRight, when we have a horizontal layout and Force row settings, and similarly to LeftToRight in vertical layout. (In practice the vertical layout is always one column and this patch has no effect) Here are two videos that describe the problem First is the row major where taskbar items jump around: https://youtu.be/8udr2DJKobw And the second with a patched taskbar where the items jump around a lot less: https://youtu.be/bk17gnu1ETo Diffs (updated) - applets/taskmanager/package/contents/ui/ConfigGeneral.qml 36dd134 applets/taskmanager/package/contents/ui/main.qml 98ba7c3 Diff: https://git.reviewboard.kde.org/r/123738/diff/ Testing (updated) --- I have applied this patch to the system installed plasma 5.3 installation. Thanks, Kåre Särs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/ --- (Updated May 17, 2015, 1:23 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit ad81cae37b112b67de2a515255cf73ce6df2330d by Yoann Laissus to branch master. Repository: plasma-desktop Description --- The panel configuration width is defined to a fixed value when it's vertical. In English, it's not a problem because strings are very compacts. But for example, in French, some strings get too big for the buttons. The width is now computed dynamically from the button layout. I'm really not a QML expert, please let me know if there is a better way to achieve that. Diffs - desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd Diff: https://git.reviewboard.kde.org/r/123815/diff/ Testing --- Tested in all screen edges. File Attachments Truncated text https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg After the fix https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
