Re: Review Request 123926: Unbreak Undo notifications on Plasma delete

2015-05-28 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/#review80934
---

Ship it!


Ship It!

- Marco Martin


On May 28, 2015, 3:50 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123926/
> ---
> 
> (Updated May 28, 2015, 3:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for 
> plasmashell and that broke the undo notifications if you undo twice in a row.
> 
> 
> Diffs
> -
> 
>   dataengines/notifications/notificationsengine.cpp 509f349 
> 
> Diff: https://git.reviewboard.kde.org/r/123926/diff/
> 
> 
> Testing
> ---
> 
> Now I get two separate Undo notifications.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123926: Unbreak Undo notifications on Plasma delete

2015-05-28 Thread Martin Klapetek 


> On May 28, 2015, 5:52 p.m., Lukáš Tinkl wrote:
> > dataengines/notifications/notificationsengine.cpp, line 157
> > 
> >
> > QStringLiteral() ?

Nah, QLatin1String is faster for comparisons (and enough for comparisons).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/#review80932
---


On May 28, 2015, 5:50 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123926/
> ---
> 
> (Updated May 28, 2015, 5:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for 
> plasmashell and that broke the undo notifications if you undo twice in a row.
> 
> 
> Diffs
> -
> 
>   dataengines/notifications/notificationsengine.cpp 509f349 
> 
> Diff: https://git.reviewboard.kde.org/r/123926/diff/
> 
> 
> Testing
> ---
> 
> Now I get two separate Undo notifications.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123926: Unbreak Undo notifications on Plasma delete

2015-05-28 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/#review80932
---

Ship it!



dataengines/notifications/notificationsengine.cpp (line 157)


QStringLiteral() ?


- Lukáš Tinkl


On Kvě. 28, 2015, 5:50 odp., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123926/
> ---
> 
> (Updated Kvě. 28, 2015, 5:50 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for 
> plasmashell and that broke the undo notifications if you undo twice in a row.
> 
> 
> Diffs
> -
> 
>   dataengines/notifications/notificationsengine.cpp 509f349 
> 
> Diff: https://git.reviewboard.kde.org/r/123926/diff/
> 
> 
> Testing
> ---
> 
> Now I get two separate Undo notifications.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123926: Unbreak Undo notifications on Plasma delete

2015-05-28 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/#review80931
---

Ship it!


Ship It!

- Bhushan Shah


On May 28, 2015, 9:20 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123926/
> ---
> 
> (Updated May 28, 2015, 9:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for 
> plasmashell and that broke the undo notifications if you undo twice in a row.
> 
> 
> Diffs
> -
> 
>   dataengines/notifications/notificationsengine.cpp 509f349 
> 
> Diff: https://git.reviewboard.kde.org/r/123926/diff/
> 
> 
> Testing
> ---
> 
> Now I get two separate Undo notifications.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123926: Unbreak Undo notifications on Plasma delete

2015-05-28 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123926/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Somewhere somewhen the applicationDisplayName() got changed to "Plasma" for 
plasmashell and that broke the undo notifications if you undo twice in a row.


Diffs
-

  dataengines/notifications/notificationsengine.cpp 509f349 

Diff: https://git.reviewboard.kde.org/r/123926/diff/


Testing
---

Now I get two separate Undo notifications.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

2015-05-28 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/
---

(Updated May 28, 2015, 3:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin 
Klapetek to branch Plasma/5.3.


Repository: plasma-workspace


Description
---

This puts the notifications coming from the Jobs applet through the same 
routines as normal notifications, including proper parsing and escaping and 
stuff.

This also fixes bug 342605


Diffs
-

  applets/notifications/package/contents/ui/Jobs.qml 3307d38 
  applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
  dataengines/notifications/notificationaction.cpp db27cb3 
  dataengines/notifications/notifications.operations 93b7f0c 
  dataengines/notifications/notificationsengine.h d8507d0 
  dataengines/notifications/notificationsengine.cpp 37a11dd 

Diff: https://git.reviewboard.kde.org/r/123923/diff/


Testing
---

Copy files, notification appears correctly, is closed correctly and everything 
works as expected.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

2015-05-28 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/#review80927
---

Ship it!


Ship It!

- Marco Martin


On May 28, 2015, 1:27 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123923/
> ---
> 
> (Updated May 28, 2015, 1:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This puts the notifications coming from the Jobs applet through the same 
> routines as normal notifications, including proper parsing and escaping and 
> stuff.
> 
> This also fixes bug 342605
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/Jobs.qml 3307d38 
>   applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
>   dataengines/notifications/notificationaction.cpp db27cb3 
>   dataengines/notifications/notifications.operations 93b7f0c 
>   dataengines/notifications/notificationsengine.h d8507d0 
>   dataengines/notifications/notificationsengine.cpp 37a11dd 
> 
> Diff: https://git.reviewboard.kde.org/r/123923/diff/
> 
> 
> Testing
> ---
> 
> Copy files, notification appears correctly, is closed correctly and 
> everything works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

2015-05-28 Thread Martin Klapetek 


> On May 28, 2015, 3:30 p.m., David Edmundson wrote:
> > dataengines/notifications/notificationsengine.cpp, line 367
> > 
> >
> > does this get lost?

No, this is inserted by the Notify() method, which does some more checks if it 
can actually configure it or not.

I should probably remove it from the function params though.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/#review80924
---


On May 28, 2015, 3:27 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123923/
> ---
> 
> (Updated May 28, 2015, 3:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This puts the notifications coming from the Jobs applet through the same 
> routines as normal notifications, including proper parsing and escaping and 
> stuff.
> 
> This also fixes bug 342605
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/Jobs.qml 3307d38 
>   applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
>   dataengines/notifications/notificationaction.cpp db27cb3 
>   dataengines/notifications/notifications.operations 93b7f0c 
>   dataengines/notifications/notificationsengine.h d8507d0 
>   dataengines/notifications/notificationsengine.cpp 37a11dd 
> 
> Diff: https://git.reviewboard.kde.org/r/123923/diff/
> 
> 
> Testing
> ---
> 
> Copy files, notification appears correctly, is closed correctly and 
> everything works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

2015-05-28 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/#review80924
---



dataengines/notifications/notificationsengine.cpp 


does this get lost?


- David Edmundson


On May 28, 2015, 1:27 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123923/
> ---
> 
> (Updated May 28, 2015, 1:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This puts the notifications coming from the Jobs applet through the same 
> routines as normal notifications, including proper parsing and escaping and 
> stuff.
> 
> This also fixes bug 342605
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/Jobs.qml 3307d38 
>   applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
>   dataengines/notifications/notificationaction.cpp db27cb3 
>   dataengines/notifications/notifications.operations 93b7f0c 
>   dataengines/notifications/notificationsengine.h d8507d0 
>   dataengines/notifications/notificationsengine.cpp 37a11dd 
> 
> Diff: https://git.reviewboard.kde.org/r/123923/diff/
> 
> 
> Testing
> ---
> 
> Copy files, notification appears correctly, is closed correctly and 
> everything works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNotification call

2015-05-28 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This puts the notifications coming from the Jobs applet through the same 
routines as normal notifications, including proper parsing and escaping and 
stuff.

This also fixes bug 342605


Diffs
-

  applets/notifications/package/contents/ui/Jobs.qml 3307d38 
  applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
  dataengines/notifications/notificationaction.cpp db27cb3 
  dataengines/notifications/notifications.operations 93b7f0c 
  dataengines/notifications/notificationsengine.h d8507d0 
  dataengines/notifications/notificationsengine.cpp 37a11dd 

Diff: https://git.reviewboard.kde.org/r/123923/diff/


Testing
---

Copy files, notification appears correctly, is closed correctly and everything 
works as expected.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt Contributor Summit

2015-05-28 Thread Marco Martin 
On Thursday 28 May 2015, David Edmundson wrote:
> Hey all,
> 
> Aleix and I are going to the Qt Contributor Summit in a week to talk to Qt
> people about Qt things.
> 
> If there's a specific issue you want us to talk aboout, please poke either
> of us.

There is one aspect I'm a bit concerned about and bitchy about is 
QtQuickControls, so here it is my list to santa :p

It's still nowhere near good enough, development is very slow, direction seems 
unclear
so, some questions for them would be
* what is the status/eta of the c++ rewrite?
* what is their future? is planned to make them a first class citizen on the 
desktop? (therefore filling the many gaps they have such as keyboard 
navigation, form layouts, way better comboboxes..)
* how can we help? we could put a bit of work in it, but right now if even an 
one-liner patch(like https://codereview.qt-project.org/#/c/111326/ ) gets 
ignored for months there isn't bing incentive in doing bigger work. We could 
take some tasks on them if then is feasible to merge

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

2015-05-28 Thread no-reply 
We thank you for fixing your build!___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Qt Contributor Summit

2015-05-28 Thread David Edmundson 
Hey all,

Aleix and I are going to the Qt Contributor Summit in a week to talk to Qt
people about Qt things.

If there's a specific issue you want us to talk aboout, please poke either
of us.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123855: Split obsolete language docbook into translations + format docbook

2015-05-28 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123855/
---

(Updated May 28, 2015, 9:30 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Plasma, John Layt, and Sebastian Kügler.


Changes
---

Submitted with commit c86ff5303d51eff49caa2187ef5e188bc0426422 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

The obsolete language docbook is splitted into translations + format docbook 
with updated content

I added a FIXME in the translations docbook about the (for me) 
strange/unexpected behavior of the "Available Languages" list
and need some input whether my findings are correct and what of the FIXME 
content should be visible in the docbook


Diffs
-

  doc/kcontrol/CMakeLists.txt c2f27d5 
  doc/kcontrol/formats/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/formats/index.docbook PRE-CREATION 
  doc/kcontrol/language/CMakeLists.txt c0fb059 
  doc/kcontrol/language/index.docbook ea9f4ef 
  doc/kcontrol/language/oxygen-22x22-document-revert.png 75ff210 
  doc/kcontrol/translations/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/translations/index.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123855/diff/


Testing
---

Builds


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123855: Split obsolete language docbook into translations + format docbook

2015-05-28 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123855/#review80919
---

Ship it!


Ship It!

- Sebastian Kügler


On May 28, 2015, 5:43 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123855/
> ---
> 
> (Updated May 28, 2015, 5:43 a.m.)
> 
> 
> Review request for Documentation, Plasma, John Layt, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The obsolete language docbook is splitted into translations + format docbook 
> with updated content
> 
> I added a FIXME in the translations docbook about the (for me) 
> strange/unexpected behavior of the "Available Languages" list
> and need some input whether my findings are correct and what of the FIXME 
> content should be visible in the docbook
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/CMakeLists.txt c2f27d5 
>   doc/kcontrol/formats/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/formats/index.docbook PRE-CREATION 
>   doc/kcontrol/language/CMakeLists.txt c0fb059 
>   doc/kcontrol/language/index.docbook ea9f4ef 
>   doc/kcontrol/language/oxygen-22x22-document-revert.png 75ff210 
>   doc/kcontrol/translations/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/translations/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123855/diff/
> 
> 
> Testing
> ---
> 
> Builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel