plasma-mobile repository cleaned up
Howdy, The plasma-mobile repository has over time accumulated lots of stuff, apps, engines, plugins, and has been on the way of becoming one hairy tarball. Before it all gets too interconnected, Marco and I have sat down and went over what's in there, keeping in mind the general direction of Plasma 5 and what's still useful in a Plasma 5 and Wayland world, and what's fallout We've split out what's generic enough to be useful elsewhere, and deleted the things we know aren't applicable anymore (some have been replaced by better solutions, others are architecturally outdated and better replaced by something simple based on new technology). The repo is not completely empty, but can of course always be further cleaned up. Things that have been split out: - the angelfish webbrowser, now in the plasma-angelfish repo - the settings app, now found in plasma-settings - the samegame demo, now in plasma-samegame - the camera app, now in plasma-camera These repos are currently under sebas/scratch/$reponame, but will be moved shortly. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma-mobile repository cleaned up
On Friday, June 05, 2015 03:18:08 Sebastian Kügler wrote: Things that have been split out: - the angelfish webbrowser, now in the plasma-angelfish repo - the settings app, now found in plasma-settings - the samegame demo, now in plasma-samegame - the camera app, now in plasma-camera These repos are currently under sebas/scratch/$reponame, but will be moved shortly. Update: They're all in their final location now, kde:plasma-settings, kde:plasma-samegame, kde:plasma-angelfish and kde:plasma-camera. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81218
---
src/declarativeimports/calendar/calendar.cpp (line 264)
https://git.reviewboard.kde.org/r/124004/#comment55616
QJsonArray
+1 LGTM
- Aleix Pol Gonzalez
On June 4, 2015, 10:29 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 10:29 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 31 - Fixed!
We thank you for fixing your build!___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: bluez qt bic sic - soversion regression
thanks, confirmed fixed :) On Thu, Jun 4, 2015 at 9:41 AM, David Rosca now...@gmail.com wrote: Fixed now, sorry about that. David On Thu, Jun 4, 2015 at 6:24 PM, Harald Sitter sit...@kde.org wrote: alohas this commit http://quickgit.kde.org/?p=bluez-qt.gita=commith=7e05a4a4fae19550b1dcc11e5a363a0884b5f8d8 removed the soversion6 which is needed as the present API is incompatible with the one released as 5.3.x needs to be brought back. kthxbai ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On June 4, 2015, 11:57 a.m., Kai Uwe Broulik wrote:
Somehow the Repeater { model: } does not like QListint
I think that's a limitation of the JavaScript engine and/or type conversion
thing. QVariantList and QStringList are converted to JS Arrays but I don't
think it does that for any other QListT.
Martin Klapetek wrote:
QListint should still work, according to
http://doc.qt.io/qt-5/qtqml-cppintegration-data.html#sequence-type-to-javascript-array
Kai Uwe Broulik wrote:
Oh, didn't know that. Looks like a Qt bug then.
Or maybe Qt 5.4.0 is just too old to have that :O
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81162
---
On June 4, 2015, 7:48 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 7:48 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On June 4, 2015, 11:57 a.m., Kai Uwe Broulik wrote:
Somehow the Repeater { model: } does not like QListint
I think that's a limitation of the JavaScript engine and/or type conversion
thing. QVariantList and QStringList are converted to JS Arrays but I don't
think it does that for any other QListT.
QListint should still work, according to
http://doc.qt.io/qt-5/qtqml-cppintegration-data.html#sequence-type-to-javascript-array
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81162
---
On June 4, 2015, 11:53 a.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 11:53 a.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On Juni 4, 2015, 9:57 vorm., Kai Uwe Broulik wrote:
Somehow the Repeater { model: } does not like QListint
I think that's a limitation of the JavaScript engine and/or type conversion
thing. QVariantList and QStringList are converted to JS Arrays but I don't
think it does that for any other QListT.
Martin Klapetek wrote:
QListint should still work, according to
http://doc.qt.io/qt-5/qtqml-cppintegration-data.html#sequence-type-to-javascript-array
Oh, didn't know that. Looks like a Qt bug then.
- Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81162
---
On Juni 4, 2015, 9:53 vorm., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated Juni 4, 2015, 9:53 vorm.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On June 4, 2015, 12:07 p.m., Kai Uwe Broulik wrote:
src/declarativeimports/calendar/calendar.h, line 56
https://git.reviewboard.kde.org/r/124004/diff/1/?file=378752#file378752line56
Oh, and I'd say you should use QVariantList so you can still store
numbers and not break the API by suddenly returning a list of strings. (?)
This is so far unused API (afaik), so that should be fine?
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81167
---
On June 4, 2015, 11:53 a.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 11:53 a.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote:
You can use QJSArray. In fact it's quite faster as I think it's what V4
uses internally, so no casting happens.
Martin Klapetek wrote:
There is no QJSArray; you mean QJSValue? Or QJsonArray?
QJsonArray I meant.
We already use it in some places, in fact.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81169
---
On June 4, 2015, 7:48 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 7:48 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On Juni 4, 2015, 10:14 vorm., Aleix Pol Gonzalez wrote:
You can use QJSArray. In fact it's quite faster as I think it's what V4
uses internally, so no casting happens.
Martin Klapetek wrote:
There is no QJSArray; you mean QJSValue? Or QJsonArray?
Aleix Pol Gonzalez wrote:
QJsonArray I meant.
We already use it in some places, in fact.
I once tried to investigate that. I don't think QML can directly handle
QJsonArray, it's just that you can convert them to QVariantList and that QML
understands.
- Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81169
---
On Juni 4, 2015, 5:48 nachm., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated Juni 4, 2015, 5:48 nachm.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. David Edmundson wrote: I've never used them. I'm with Martin. Kai Uwe Broulik wrote: I'd say bring in the usability team :) David Edmundson wrote: effectively done: https://bugs.kde.org/show_bug.cgi?id=299174#c13 comments 13 14 are Heiko and Thomas Kai Uwe Broulik wrote: Ok then It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog But that's the case with about /all/ our powerful when needed features, isn't it? How else would you do powerful when needed? And it shouldn't be decoupled from the Simple by default part, which this really is. it's advertised nowhere that this feature is now available. Come on now, we add manymanymany new features every release, portion of which is also off by default. That's what release notes are for. -- Anywho, from the aformentioned bug, comment by Thomas Pfeiffer: A configuration option would definitely be helpful here, because the week number is useless for many people, but essential for many others: In many companies, week numbers are used regularly for time planning, but for people not working in such companies they're indeed pretty much meaningless. One more interesting comment by someone: I can not understand why you can configure the bejesus out of the clock, but the calendar is a immutable monolithic totem to somebody's preferred format. ...to which I have to really agree. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 11:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 11:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. David Edmundson wrote: I've never used them. I'm with Martin. Kai Uwe Broulik wrote: I'd say bring in the usability team :) David Edmundson wrote: effectively done: https://bugs.kde.org/show_bug.cgi?id=299174#c13 comments 13 14 are Heiko and Thomas Kai Uwe Broulik wrote: Ok then Martin Klapetek wrote: It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog But that's the case with about /all/ our powerful when needed features, isn't it? How else would you do powerful when needed? And it shouldn't be decoupled from the Simple by default part, which this really is. it's advertised nowhere that this feature is now available. Come on now, we add manymanymany new features every release, portion of which is also off by default. That's what release notes are for. -- Anywho, from the aformentioned bug, comment by Thomas Pfeiffer: A configuration option would definitely be helpful here, because the week number is useless for many people, but essential for many others: In many companies, week numbers are used regularly for time planning, but for people not working in such companies they're indeed pretty much meaningless. One more interesting comment by someone: I can not understand why you can configure the bejesus out of the clock, but the calendar is a immutable monolithic totem to somebody's preferred format. ...to which I have to really agree. I'm ok with that, I trust our usability people. In my perception, weeknumbers are an essential calendar feature, but apparently they're less used outside of my world. :) - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 9:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 9:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/ui/configAppearance.qml, line 75 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378758#file378758line75 Show week numbers in calendar ? Ok. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 11:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 11:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124004: Add week numbers to calendar - Part 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't show
anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81164
---
src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 103 - 104)
https://git.reviewboard.kde.org/r/124004/#comment55573
The Repeater doesn't but the Column does :)
- Kai Uwe Broulik
On Juni 4, 2015, 9:53 vorm., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated Juni 4, 2015, 9:53 vorm.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote:
You can use QJSArray. In fact it's quite faster as I think it's what V4
uses internally, so no casting happens.
Martin Klapetek wrote:
There is no QJSArray; you mean QJSValue? Or QJsonArray?
Aleix Pol Gonzalez wrote:
QJsonArray I meant.
We already use it in some places, in fact.
Kai Uwe Broulik wrote:
I once tried to investigate that. I don't think QML can directly handle
QJsonArray, it's just that you can convert them to QVariantList and that QML
understands.
Martin Klapetek wrote:
So is it worth using for this simple 5 elements array?
No, there's direct translation between the internal QV4 types and QJsonArray,
that's for sure, no need to go through QVariantList.
Another possibility is:
QJSValue array = engine.newArray();
array.setProperty(1, myValue);
You probably won't have the engine though, and it's needed for the value
garbage collection I guess.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81169
---
On June 4, 2015, 7:48 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 7:48 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On Juni 4, 2015, 9:59 vorm., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. David Edmundson wrote: I've never used them. I'm with Martin. I'd say bring in the usability team :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On Juni 4, 2015, 9:55 vorm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated Juni 4, 2015, 9:55 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124004: Add week numbers to calendar - Part 1
On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote:
You can use QJSArray. In fact it's quite faster as I think it's what V4
uses internally, so no casting happens.
Martin Klapetek wrote:
There is no QJSArray; you mean QJSValue? Or QJsonArray?
Aleix Pol Gonzalez wrote:
QJsonArray I meant.
We already use it in some places, in fact.
Kai Uwe Broulik wrote:
I once tried to investigate that. I don't think QML can directly handle
QJsonArray, it's just that you can convert them to QVariantList and that QML
understands.
So is it worth using for this simple 5 elements array?
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81169
---
On June 4, 2015, 7:48 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
---
(Updated June 4, 2015, 7:48 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
One of the most requested features for Plasma5. The backend is all there*, it
just needs the frontend part. Optional, defaults to off.
*Somehow the Repeater { model: } does not like QListint, it just doesn't
show anything while QStringList works just fine. Any ideas on that?
Diffs
-
src/declarativeimports/calendar/calendar.h ea20bf5
src/declarativeimports/calendar/calendar.cpp a766acb
src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
Diff: https://git.reviewboard.kde.org/r/124004/diff/
Testing
---
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
Thanks,
Martin Klapetek
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 9:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 9:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. I've never used them. I'm with Martin. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 9:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 9:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/#review81161 --- Ship it! Ship It! - Lukáš Tinkl On Čer. 4, 2015, 1:08 dop., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/ --- (Updated Čer. 4, 2015, 1:08 dop.) Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerdevil Description --- On e.g. platform wayland XRandrBrightness shouldn't do anything. By skipping the initialization the isSupported returns false. Diffs - daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850 Diff: https://git.reviewboard.kde.org/r/123999/diff/ Testing --- kded5 no longer crashes when initializing powerdevil when running with platform wayland. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- applets/digital-clock/package/contents/config/main.xml (line 43) https://git.reviewboard.kde.org/r/124005/#comment55571 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. applets/digital-clock/package/contents/ui/configAppearance.qml (line 75) https://git.reviewboard.kde.org/r/124005/#comment55572 Show week numbers in calendar ? - Kai Uwe Broulik On Juni 4, 2015, 9:55 vorm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated Juni 4, 2015, 9:55 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On Juni 4, 2015, 9:59 vorm., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. David Edmundson wrote: I've never used them. I'm with Martin. Kai Uwe Broulik wrote: I'd say bring in the usability team :) David Edmundson wrote: effectively done: https://bugs.kde.org/show_bug.cgi?id=299174#c13 comments 13 14 are Heiko and Thomas Ok then - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On Juni 4, 2015, 9:55 vorm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated Juni 4, 2015, 9:55 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. David Edmundson wrote: I've never used them. I'm with Martin. Kai Uwe Broulik wrote: I'd say bring in the usability team :) effectively done: https://bugs.kde.org/show_bug.cgi?id=299174#c13 comments 13 14 are Heiko and Thomas - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 9:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 9:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124005: Add week numbers to calendar - Part 2
On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote: applets/digital-clock/package/contents/config/main.xml, line 43 https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43 Why not make it default? Yours looks much more beautiful and tidy than the old 4.x version which always confused me. Martin Klapetek wrote: Simple by default, powerful when needed ;) It's not a feature everyone wants/needs, but it's there when they do. Sebastian Kügler wrote: IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional. It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog this way, it's advertised nowhere that this feature is now available. David Edmundson wrote: I've never used them. I'm with Martin. Kai Uwe Broulik wrote: I'd say bring in the usability team :) David Edmundson wrote: effectively done: https://bugs.kde.org/show_bug.cgi?id=299174#c13 comments 13 14 are Heiko and Thomas Kai Uwe Broulik wrote: Ok then Martin Klapetek wrote: It's not powerful when needed, it's powerful when the user happens to find the option in the config dialog But that's the case with about /all/ our powerful when needed features, isn't it? How else would you do powerful when needed? And it shouldn't be decoupled from the Simple by default part, which this really is. it's advertised nowhere that this feature is now available. Come on now, we add manymanymany new features every release, portion of which is also off by default. That's what release notes are for. -- Anywho, from the aformentioned bug, comment by Thomas Pfeiffer: A configuration option would definitely be helpful here, because the week number is useless for many people, but essential for many others: In many companies, week numbers are used regularly for time planning, but for people not working in such companies they're indeed pretty much meaningless. One more interesting comment by someone: I can not understand why you can configure the bejesus out of the clock, but the calendar is a immutable monolithic totem to somebody's preferred format. ...to which I have to really agree. Sebastian Kügler wrote: I'm ok with that, I trust our usability people. In my perception, weeknumbers are an essential calendar feature, but apparently they're less used outside of my world. :) While I have never worked in a company where week numbers matter, it's actually the most important feature I need a calender for. Maybe it's a cultural thing, but week numbers are pretty common in Germany - we even used them in school. So IMHO our usability team is wrong here. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/#review81163 --- On June 4, 2015, 11:55 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124005/ --- (Updated June 4, 2015, 11:55 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- One of the most requested features for Plasma5. This is the applet's part (basically just the config). See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot. Another part will be the (standalone) Calendar applet. Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/124005/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
