Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review81977 --- Ship it! Ship It! - Hrvoje Senjan On July 2, 2015, 1:07 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/ --- (Updated July 2, 2015, 1:07 a.m.) Review request for Plasma. Bugs: 349658 https://bugs.kde.org/show_bug.cgi?id=349658 Repository: plasma-desktop Description --- Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for. Also drop XBINDIR, as it wasn't being used at all. Should give something like this directory: ``` $ ls /usr/share/X11/xkb/ compat geometry keycodes rules symbols types ``` Diffs - ConfigureChecks.cmake 4fc4bce config-workspace.h.cmake eda8996 kcms/keyboard/xkb_rules.cpp 9fd0324 Diff: https://git.reviewboard.kde.org/r/124215/diff/ Testing --- re-compiled on my system, everything still works. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen
https://bugs.kde.org/show_bug.cgi?id=349750 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added Severity|normal |major CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik k...@privat.broulik.de --- Frying your laptop is a severe issue, raising priority -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82018 --- I'd change the label to Always show all entries (actually, it would make sense to add Always to the combobox labels as well, but that's a different story). Other than that, it looks fine, and even though the same effect could be achieved by manually setting all entries to (Always) Shown, I think it's worth having it in there as a convenience feature for those who just don't like auto-hidding stuff. - Thomas Pfeiffer On July 2, 2015, 7:47 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated July 2, 2015, 7:47 p.m.) Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82024 --- Nice addition. I was checking if users are able to realize the setting - and it is obvious since the drop down is hidden. However the layout of the checkbox is not really nice. Add more space to the details below and indent the siblings. Maybe it's worth to think about an alternativ text to allow accordance with the configurability of the dropdowns. E.g. 'Personalized tray icons', and enable/checked means you can change the details below. - Heiko Tietze On Juli 2, 2015, 9:23 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated Juli 2, 2015, 9:23 nachm.) Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/TaskDelegate.qml 221c6e7 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Better dialog layout https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png Dim System Tray https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82025 --- Yeah, let's not bother with the dimming. It just introduces another visualization for a state that's ostensibly disabled. Hide or no hide, there is no try. :-) - Andrew Lake On July 2, 2015, 9:23 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated July 2, 2015, 9:23 p.m.) Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/TaskDelegate.qml 221c6e7 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Better dialog layout https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png Dim System Tray https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124236: More sensible sizing for containment configuration
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/ --- Review request for Plasma. Repository: plasma-desktop Description --- That dialog is pretty tall on laptops and can hardly be resized any smaller. This gives it a sensible minimum size and keeps the preferred at the old value Diffs - desktoppackage/contents/configuration/ContainmentConfiguration.qml 09a4d22 Diff: https://git.reviewboard.kde.org/r/124236/diff/ Testing --- Nuked my plasma config, dialog looked nice initially but I could make it smaller for my preference. Please #lowdpi people test Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82008 --- Perhaps we should/could slightly reduce opacity on items that would normally be hidden? - Kai Uwe Broulik On Juli 2, 2015, 7:47 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated Juli 2, 2015, 7:47 nachm.) Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82007 --- No usability review without screenshots ;) - Thomas Pfeiffer On July 2, 2015, 6:23 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated July 2, 2015, 6:23 p.m.) Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated Juli 2, 2015, 7:47 nachm.) Review request for Plasma and KDE Usability. Changes --- Add screenshots Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments (updated) Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82012 --- Requested a long time ago (for KDE 4) as https://git.reviewboard.kde.org/r/100743/ Good luck... - Jonathan Marten On July 2, 2015, 7:47 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated July 2, 2015, 7:47 p.m.) Review request for Plasma and KDE Usability. Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124234: Add option to always show all system tray icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated Juli 2, 2015, 9:23 nachm.) Review request for Plasma and KDE Usability. Changes --- - Rename option to Always show all items - Refactor dialog to use QtLayouts so it can properly be resized (will split that into a separate commit) - Dim passive items when all are shown, looks a bit muddy to me, though Bugs: 349812 https://bugs.kde.org/show_bug.cgi?id=349812 Repository: plasma-workspace Description --- This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this. Diffs (updated) - applets/systemtray/package/contents/config/main.xml 8e8996c applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 applets/systemtray/package/contents/ui/TaskDelegate.qml 221c6e7 applets/systemtray/package/contents/ui/main.qml e794d1c applets/systemtray/plugin/host.h bd9728b applets/systemtray/plugin/host.cpp 5c897fa Diff: https://git.reviewboard.kde.org/r/124234/diff/ Testing --- Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options. File Attachments (updated) Settings dialog (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png Settings dialog (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png System Tray (disabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png System Tray (enabled) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png Better dialog layout https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png Dim System Tray https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
